Re: [Mesa-dev] [PATCH] anv: Implement VK_ANDROID_native_buffer (v5)

2017-09-24 Thread Tapani Pälli
On 09/22/2017 03:09 AM, Chad Versace wrote: On Thu 21 Sep 2017, Tapani Pälli wrote: Hi Chad; The build works ok now on Android-IA. There is still something wrong with 'exec async' though. It behaves differently with small/big apps but eventually I think it just starts to block .. somewhere. I

Re: [Mesa-dev] [PATCH] Revert "Revert "radv: fallback to an in-memory cache when no pipline cache is provided""

2017-09-24 Thread Timothy Arceri
On 25/09/17 14:43, Bas Nieuwenhuizen wrote: I tested this 10 times with ./deqp-vk --deqp-case=dEQP-VK.texture.filtering.3d.formats.r4g4b4a4* and one full run of CTS, seems the issue is gone. Also reduces CTS runtime by 30% or so. Nice :) For what its worth: Reviewed-by: Timothy Arceri --

Re: [Mesa-dev] [Mesa-stable] [PATCH] vulkan/wsi/wayland: Stop printing out the DRM device

2017-09-24 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On Friday, September 22, 2017 12:45:27 PM CEST Jason Ekstrand wrote: > Cc: mesa-sta...@lists.freedesktop.org > --- > src/vulkan/wsi/wsi_common_wayland.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/vulkan/wsi/wsi_common_wayland.c > b/src/vul

[Mesa-dev] [PATCH] radv: Fix VK_KHR_image_format_list.

2017-09-24 Thread Bas Nieuwenhuizen
Spec adding corner cases ... Fixes: 969537d9358 "radv: Add support for more DCC compression with VK_KHR_image_format_list." --- src/amd/vulkan/radv_image.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index cff1b

[Mesa-dev] [PATCH] Revert "Revert "radv: fallback to an in-memory cache when no pipline cache is provided""

2017-09-24 Thread Bas Nieuwenhuizen
I tested this 10 times with ./deqp-vk --deqp-case=dEQP-VK.texture.filtering.3d.formats.r4g4b4a4* and one full run of CTS, seems the issue is gone. Also reduces CTS runtime by 30% or so. --- src/amd/vulkan/radv_pipeline.c | 13 - src/amd/vulkan/radv_pipeline_cache.c | 7 +--

Re: [Mesa-dev] [PATCH 3/8] nir: add a helper for getting the bitmask for a variable's location

2017-09-24 Thread Timothy Arceri
On 23/09/17 04:33, Kenneth Graunke wrote: On Tuesday, September 12, 2017 4:37:30 PM PDT Timothy Arceri wrote: --- src/compiler/nir/nir.h | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index fab2110f619..e52a

Re: [Mesa-dev] [PATCH 1/3] i965/vec4: Actually handle atomic op intrinsics.

2017-09-24 Thread Jason Ekstrand
This is all a bit embarrassing... Can't review yet because I'm not at my computer. On September 24, 2017 5:10:31 PM Kenneth Graunke wrote: Embarassingly, someone enabled the ARB_shader_atomic_counter_ops extension for Gen7+ but never added the intrinsics to the switch statement in the vec4 b

[Mesa-dev] [PATCH 2/3] i965/vec4: Fix swizzles on atomic sources.

2017-09-24 Thread Kenneth Graunke
Atomic operation sources are scalar values, but we were failing to select the .x component of the second operand. For example, atomicCounterCompSwapARB(counter, 5u, 10u) would generate mov(8) vgrf4.x:D, 5D mov(8) vgrf5.x:D, 10D mov(8) vgrf9.x:UD, vgrf4.xyzw:D mov(8) vgrf9.y:UD,

[Mesa-dev] [PATCH 1/3] i965/vec4: Actually handle atomic op intrinsics.

2017-09-24 Thread Kenneth Graunke
Embarassingly, someone enabled the ARB_shader_atomic_counter_ops extension for Gen7+ but never added the intrinsics to the switch statement in the vec4 backend, so they just hit an unreachable() call and died. Fixes: 40dd45d0c6aa4a9d (i965: Enable ARB_shader_atomic_counter_ops) Cc: "17.2 17.1 17.0

[Mesa-dev] [PATCH 3/3] i965: Support copy propagating of untyped atomic surface indexes.

2017-09-24 Thread Kenneth Graunke
In the vec4 backend, SHADER_OPCODE_UNTYPED_ATOMIC's src[1] is the surface index. We want to copy propagate so we can use an immediate message descriptor, rather than an indirect send. --- src/intel/compiler/brw_vec4_copy_propagation.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git a/s

Re: [Mesa-dev] [PATCH 4/4] i965: Drop the batch and limp along if execbuf fails.

2017-09-24 Thread Jason Ekstrand
I've got this a few times recently and it's really annoying. I don't know if this will fix anything or not but it may be worth a go. I fear, however, that ignoring an execbuf failure will lead to permanently corrupted rendering or even additional hangs due to a chunk of the stream being missi

[Mesa-dev] [Bug 102964] [amdgpu][tahiti xt] dota2-vulkan tournament drafting phase has no skys

2017-09-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102964 --- Comment #1 from Bas Nieuwenhuizen --- Do you have images of intended ad actual skies? (i.e. vulkan vs. GL or such?) -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.__

[Mesa-dev] [Bug 102964] [amdgpu][tahiti xt] dota2-vulkan tournament drafting phase has no skys

2017-09-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102964 Bug ID: 102964 Summary: [amdgpu][tahiti xt] dota2-vulkan tournament drafting phase has no skys Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linu

Re: [Mesa-dev] [PATCH 1/4] i965: Convert brw_bufmgr to use C11 mutexes instead of pthreads.

2017-09-24 Thread Kenneth Graunke
On Sunday, September 24, 2017 7:36:17 AM PDT Jason Ekstrand wrote: > On September 24, 2017 01:02:21 Kenneth Graunke wrote: > > There's no real advantage or disadvantage here, it's just for stylistic > > consistency with the rest of the codebase. > > Didn't Kristian do a bunch of work done time ag

Re: [Mesa-dev] [PATCH 1/4] i965: Convert brw_bufmgr to use C11 mutexes instead of pthreads.

2017-09-24 Thread Jason Ekstrand
On September 24, 2017 01:02:21 Kenneth Graunke wrote: There's no real advantage or disadvantage here, it's just for stylistic consistency with the rest of the codebase. Didn't Kristian do a bunch of work done time ago to make mutexes faster by not using pthread on Linux? If so, this should b

[Mesa-dev] [Bug 101378] interpolateAtSample check for input parameter is too strict

2017-09-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101378 --- Comment #5 from Nicolai Hähnle --- Thanks for the reminder. There were some related spec issues that we cleared up with the GL and ES working groups, but I have a set of patches that is almost ready to go in. -- You are receiving this mail