[Mesa-dev] [PATCH 1/3] egl: Allow creation of per surface out fence

2017-09-14 Thread yogesh . marathe
From: Zhongmin Wu Add plumbing to allow creation of per display surface out fence. Currently enabled only on android, since the system expects a valid fd in ANativeWindow::{queue,cancel}Buffer. We pass a fd of -1 with which native applications such as flatland fail. The patch enables explicit sy

[Mesa-dev] [PATCH 2/3] egl: Wrap dri3 surface primitive around dri2 egl surface

2017-09-14 Thread yogesh . marathe
From: Yogesh Marathe Originally dri3 egl surface was wrapped around _EGLSurface. To support explicit sync, new variables (e.g. enable_out_fence) were added to dri2_egl_surface. As we reference these new variables we write on to dri3 loader bits. These get toggled later in execution due to dri3 lo

[Mesa-dev] [PATCH 3/3] egl: dri3 changes to support surface primitive wrap around dri2

2017-09-14 Thread yogesh . marathe
From: Yogesh Marathe As base is moved one level down corresponding implementation in dri3 needs a change. Tested with Intel Mesa CI Signed-off-by: Yogesh Marathe --- src/egl/drivers/dri2/platform_x11_dri3.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a

Re: [Mesa-dev] [PATCH] i965: fix build warning on clang

2017-09-14 Thread Tapani Pälli
On 09/14/2017 09:31 PM, Jordan Justen wrote: On 2017-09-14 00:26:39, Tapani Pälli wrote: fixes following warning: warning: format specifies type 'long' but the argument has type 'uint64_t' (aka 'unsigned long long') cast is needed to avoid this turning in to another warning on 32bit buil

Re: [Mesa-dev] [PATCH 1/2] anv: android build system changes

2017-09-14 Thread Tapani Pälli
On 09/14/2017 07:54 PM, Rob Herring wrote: On Thu, Sep 14, 2017 at 1:57 AM, Tapani Pälli wrote: Following changes are made to support VK_ANDROID_native_buffer: - bring in vk_android_native_buffer.xml - rename target as vulkan.$(TARGET_BOARD_PLATFORM) - use LOCAL_PROPRIETARY_MODUL

Re: [Mesa-dev] [PATCH 2/2] anv: set has_exec_async to false on Android

2017-09-14 Thread Tapani Pälli
On 09/15/2017 01:09 AM, Chad Versace wrote: On Thu 14 Sep 2017, Emil Velikov wrote: On 14 September 2017 at 07:57, Tapani Pälli wrote: Other WSI implementations set has_exec_async false for WSI buffers, so far haven't found a place to do it so we just claim to not have async exec. What's t

[Mesa-dev] [PATCH 1/5] mesa: align atomic buffer handling code with ubo/ssbo

2017-09-14 Thread Dave Airlie
From: Dave Airlie this adds automatic size support to the atomic buffer code, but also realigns the code to act like the ubo/ssbo code. Signed-off-by: Dave Airlie --- src/mesa/main/bufferobj.c | 132 ++ src/mesa/main/mtypes.h| 1 + 2 files chan

[Mesa-dev] [PATCH 3/5] mesa/bufferobj: consolidate some codepaths between ubo/ssbo/atomics.

2017-09-14 Thread Dave Airlie
From: Dave Airlie These are 90% the same code, consoldiate them into a couple of common codepaths. Signed-off-by: Dave Airlie --- src/mesa/main/bufferobj.c | 146 +++--- 1 file changed, 47 insertions(+), 99 deletions(-) diff --git a/src/mesa/main/buffer

[Mesa-dev] realign some atomic/ssbo/ubo code

2017-09-14 Thread Dave Airlie
I was digging around the atomic code looking at r600 again, and noticed this code had some inconsistencies for the 3 codepaths that should really be the same. There is probably further room for consolidation here. This saves 300 bytes in the text segment :-P Dave. ___

[Mesa-dev] [PATCH 2/5] mesa: rename various buffer bindings to one struct.

2017-09-14 Thread Dave Airlie
From: Dave Airlie One binding to bind them all, these are all the same thing. Signed-off-by: Dave Airlie --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 6 ++--- src/mesa/drivers/dri/i965/genX_state_upload.c| 2 +- src/mesa/main/bufferobj.c| 18 ++--

[Mesa-dev] [PATCH 4/5] mesa/bufferobj: consolidate some buffer binding code.

2017-09-14 Thread Dave Airlie
From: Dave Airlie These paths are again 90% the same, consolidate them into one. Signed-off-by: Dave Airlie --- src/mesa/main/bufferobj.c | 76 ++- 1 file changed, 35 insertions(+), 41 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/m

[Mesa-dev] [PATCH 5/5] mesa/st: fix atomic buffer sizing to align with ssbo.

2017-09-14 Thread Dave Airlie
From: Dave Airlie This respects the size from the range setting like ssbo. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_atom_atomicbuf.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/state_tracker/st_atom_atomicbuf.c b/src/mesa/state_tracker/st_atom_atomicbuf.

Re: [Mesa-dev] [PATCH 3/3] i965: Disable stencil cache optimization combining two 4x2 blocks

2017-09-14 Thread Pohjolainen, Topi
On Thu, Sep 14, 2017 at 04:16:05PM -0700, Kenneth Graunke wrote: > On Monday, September 11, 2017 5:48:26 AM PDT Topi Pohjolainen wrote: > > From the BDW PRM, Volume 15, Workarounds: > > > > KMD Wa4x4STCOptimizationDisable HIZ/STC hang in hawx frames. > > > > W/A: Disable 4x4 RCPFE STC optimizatio

Re: [Mesa-dev] [PATCH 20/20] anv: Implement VK_ANDROID_native_buffer (v2)

2017-09-14 Thread zhoucm1
On 2017年09月14日 07:03, Chad Versace wrote: From: Chad Versace This implementation is correct (afaict), but takes two shortcuts regarding the import/export of Android sync fds. Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync fd into a VkSemaphore or VkFence, the dri

[Mesa-dev] [PATCH 3/5] i965/tex: Make a couple of helpers static

2017-09-14 Thread Kenneth Graunke
From: Jason Ekstrand Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/intel_tex.h | 20 src/mesa/drivers/dri/i965/intel_tex_image.c | 4 ++-- 2 files changed, 2 insertions(+), 22 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex.h b/src/mesa/d

[Mesa-dev] [PATCH 4/5] i965/tex: Remove the for_glTexImage parameter from texsubimage_tiled_memcpy

2017-09-14 Thread Kenneth Graunke
From: Jason Ekstrand It is set to false in both callers. It isn't needed for glTexImage because intelTexImage calls AllocTextureImageBuffer before calling texsubimage_tiled_memcpy. Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/intel_tex_image.c | 19 +-- 1 file ch

[Mesa-dev] [PATCH 5/5] i965/tex: Unify the TexImage and TexSubImage code

2017-09-14 Thread Kenneth Graunke
From: Jason Ekstrand It's nearly the same so there's no good reason why it can't be in a common function. The one difference is that _mesa_store_teximage calls AllocTextureImageBuffer for us, while _mesa_store_texsubimage doesn't, but we don't need that anyway - intelTexImage already does it. R

[Mesa-dev] [PATCH 1/5] i965/blorp: Set r8stencil_needs_update when writing stencil

2017-09-14 Thread Kenneth Graunke
From: Jason Ekstrand This fixes a crash on Haswell when we try to upload a stencil texture with blorp. It would also be a problem if someone tried to texture from stencil after glBlitFramebuffers. Cc: "17.2 17.1" Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_blorp.c | 6

[Mesa-dev] [PATCH 2/5] i965: Move TexSubImage functions to intel_tex_image.c

2017-09-14 Thread Kenneth Graunke
From: Jason Ekstrand These two paths are basically the same. There's no good reason to have them in different files. Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/Makefile.sources | 1 - src/mesa/drivers/dri/i965/brw_context.c| 1 - src/mesa/drivers/dri/i965/intel

Re: [Mesa-dev] [RFC] NIR serialization

2017-09-14 Thread Connor Abbott
On Thu, Sep 14, 2017 at 10:15 PM, Connor Abbott wrote: > me too :) I'll push my stuff now > > On Thu, Sep 14, 2017 at 8:58 PM, Jason Ekstrand wrote: >> On Thu, Sep 14, 2017 at 12:40 PM, Connor Abbott wrote: >>> >>> On Tue, Sep 12, 2017 at 2:09 PM, Jason Ekstrand >>> wrote: >>> > On Tue, Sep 12,

Re: [Mesa-dev] [RFC] NIR serialization

2017-09-14 Thread Connor Abbott
me too :) I'll push my stuff now On Thu, Sep 14, 2017 at 8:58 PM, Jason Ekstrand wrote: > On Thu, Sep 14, 2017 at 12:40 PM, Connor Abbott wrote: >> >> On Tue, Sep 12, 2017 at 2:09 PM, Jason Ekstrand >> wrote: >> > On Tue, Sep 12, 2017 at 10:12 AM, Ian Romanick >> > wrote: >> >> >> >> On 09/11/

Re: [Mesa-dev] [PATCH 3/4] i965/tex_image: Reference the renderbuffer miptree in setTexBuffer2

2017-09-14 Thread Eric Anholt
Jason Ekstrand writes: > The old code made a new miptree that referenced the same BO as the > renderbuffer and just trusted in the memory aliasing to work. There are > only two ways in which the new miptree is liable to differ from the one > in the renderbuffer and neither of them matter: > > 1

Re: [Mesa-dev] [PATCH 4/4] i965: Use prepare_external instead of make_shareable in setTexBuffer2

2017-09-14 Thread Eric Anholt
Jason Ekstrand writes: > The setTexBuffer2 hook from GLX is used to implement glxBindTexImageEXT > which has tighter restrictions than just "it's shared". In particular, > it says that any rendering to the image while it is bound causes the > contents to become undefined. This means that we can

Re: [Mesa-dev] [RFC] NIR serialization

2017-09-14 Thread Jason Ekstrand
On Thu, Sep 14, 2017 at 12:40 PM, Connor Abbott wrote: > On Tue, Sep 12, 2017 at 2:09 PM, Jason Ekstrand > wrote: > > On Tue, Sep 12, 2017 at 10:12 AM, Ian Romanick > wrote: > >> > >> On 09/11/2017 11:17 PM, Kenneth Graunke wrote: > >> > On Monday, September 11, 2017 9:23:05 PM PDT Ian Romanick

Re: [Mesa-dev] [PATCH] r600: fork and import gallium/radeon

2017-09-14 Thread Dave Airlie
On 15 September 2017 at 02:10, Marek Olšák wrote: > On Thu, Sep 14, 2017 at 4:19 PM, Emil Velikov > wrote: >> Hi Marek, >> >> On 14 September 2017 at 14:06, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> This marks the end of code sharing between r600 and radeonsi. >>> >> It has the "what" b

Re: [Mesa-dev] Vulkan extensions

2017-09-14 Thread Bas Nieuwenhuizen
On Fri, Sep 15, 2017 at 1:18 AM, Dave Airlie wrote: > On 15 September 2017 at 09:12, Jordan Justen > wrote: >> On 2017-09-14 15:36:10, Romain Failliot wrote: >>> Le 14 sept. 2017 6:11 PM, "Bas Nieuwenhuizen" a >>> écrit : >>> >>> > For vulkan, because 1.0 is the initial version, there are no >>

Re: [Mesa-dev] Vulkan extensions

2017-09-14 Thread Bas Nieuwenhuizen
On Fri, Sep 15, 2017 at 1:18 AM, Dave Airlie wrote: > On 15 September 2017 at 09:12, Jordan Justen > wrote: >> On 2017-09-14 15:36:10, Romain Failliot wrote: >>> Le 14 sept. 2017 6:11 PM, "Bas Nieuwenhuizen" a >>> écrit : >>> >>> > For vulkan, because 1.0 is the initial version, there are no >>

Re: [Mesa-dev] Vulkan extensions

2017-09-14 Thread Dave Airlie
On 15 September 2017 at 09:12, Jordan Justen wrote: > On 2017-09-14 15:36:10, Romain Failliot wrote: >> Le 14 sept. 2017 6:11 PM, "Bas Nieuwenhuizen" a >> écrit : >> >> > For vulkan, because 1.0 is the initial version, there are no >> > extensions to implement to get to that version, so having an

Re: [Mesa-dev] [PATCH 1/3] i965/gen8: Remove unused gen8_emit_3dstate_multisample()

2017-09-14 Thread Kenneth Graunke
On Monday, September 11, 2017 5:48:24 AM PDT Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_context.h| 1 - > src/mesa/drivers/dri/i965/gen8_multisample_state.c | 16 > 2 files changed, 17 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 3/3] i965: Disable stencil cache optimization combining two 4x2 blocks

2017-09-14 Thread Kenneth Graunke
On Monday, September 11, 2017 5:48:26 AM PDT Topi Pohjolainen wrote: > From the BDW PRM, Volume 15, Workarounds: > > KMD Wa4x4STCOptimizationDisable HIZ/STC hang in hawx frames. > > W/A: Disable 4x4 RCPFE STC optimization and therefore only send one > valid 4x4 to STC on 4x4 interface. This

Re: [Mesa-dev] [PATCH 2/3] intel/blorp/hiz: Always set sample number

2017-09-14 Thread Kenneth Graunke
On Monday, September 11, 2017 5:48:25 AM PDT Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/intel/blorp/blorp_genX_exec.h | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/src/intel/blorp/blorp_genX_exec.h > b/src/intel/blorp/blorp_genX_exec.h > index

Re: [Mesa-dev] Vulkan extensions

2017-09-14 Thread Jordan Justen
On 2017-09-14 15:36:10, Romain Failliot wrote: > Le 14 sept. 2017 6:11 PM, "Bas Nieuwenhuizen" a > écrit : > > > For vulkan, because 1.0 is the initial version, there are no > > extensions to implement to get to that version, so having an > > extensions list would be nonsensical. > > I don't thi

Re: [Mesa-dev] [PATCH 1/3] glsl: don't drop intructions from unreachable terminators continue branch

2017-09-14 Thread Matt Turner
On Wed, Sep 13, 2017 at 9:47 PM, Timothy Arceri wrote: > These instruction will be executed on every iteration of the loop > we cannot drop them. > --- > src/compiler/glsl/loop_analysis.h | 7 +++ > src/compiler/glsl/loop_controls.cpp | 15 +++ > src/compiler/glsl/loop_unroll.c

Re: [Mesa-dev] [PATCH 1/3] glsl: don't drop intructions from unreachable terminators continue branch

2017-09-14 Thread Timothy Arceri
On 15/09/17 04:25, Emil Velikov wrote: Hi Tim On 14 September 2017 at 05:47, Timothy Arceri wrote: These instruction will be executed on every iteration of the loop we cannot drop them. This and 2/3 sound like very nice bugfixes. I haven't checked if they apply for 17.2 - if not can you do s

Re: [Mesa-dev] Vulkan extensions

2017-09-14 Thread Bas Nieuwenhuizen
So AFAIK we always put the extensions there that we need to implement to be able to claim that version, or that is my understanding for GL at least. For vulkan, because 1.0 is the initial version, there are no extensions to implement to get to that version, so having an extensions list would be no

Re: [Mesa-dev] [PATCH 2/2] anv: set has_exec_async to false on Android

2017-09-14 Thread Chad Versace
On Thu 14 Sep 2017, Emil Velikov wrote: > On 14 September 2017 at 07:57, Tapani Pälli wrote: > > Other WSI implementations set has_exec_async false for WSI buffers, > > so far haven't found a place to do it so we just claim to not have > > async exec. > > > What's the actual side-effects you're se

[Mesa-dev] [PATCH 20/20 v4]] anv: Implement VK_ANDROID_native_buffer (v4)

2017-09-14 Thread Chad Versace
This implementation is correct (afaict), but takes two shortcuts regarding the import/export of Android sync fds. Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync fd into a VkSemaphore or VkFence, the driver instead simply blocks on the sync fd, then puts the VkSemaphore

[Mesa-dev] [PATCH 21/20] anv: Install as Vulkan HAL module in Android.mk build

2017-09-14 Thread Chad Versace
From: Tapani Pälli Now that anvil fully implements the Vulkan HAL interface, we can install it as the vendor HAL module at /vendor/lib/hw/vulkan.${board}.so. To do so: - Rename LOCAL_MODULE to vulkan.$(TARGET_BOARD_PLATFORM). - Use LOCAL_PROPRIETARY_MODULE to install under vendor path. Test

Re: [Mesa-dev] [PATCH v4 1/1] clover: Wait for requested operation if blocking flag is set

2017-09-14 Thread Francisco Jerez
Jan Vesely writes: > On Mon, 2017-09-04 at 13:23 -0700, Francisco Jerez wrote: >> Jan Vesely writes: >> >> > v2: wait in map_buffer and map_image as well >> > v3: use event::wait instead of wait (skips fence wait for hard_event) >> > v4: use wait_signalled() >> > >> > Signed-off-by: Jan Vesely

Re: [Mesa-dev] [PATCH v4 1/1] clover: Wait for requested operation if blocking flag is set

2017-09-14 Thread Jan Vesely
On Mon, 2017-09-04 at 13:23 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > v2: wait in map_buffer and map_image as well > > v3: use event::wait instead of wait (skips fence wait for hard_event) > > v4: use wait_signalled() > > > > Signed-off-by: Jan Vesely > > --- > > Hi Francisco, >

[Mesa-dev] Vulkan extensions

2017-09-14 Thread Romain Failliot
Hi! I'm working on exposing the vulkan information recently added in features.txt in mesamatrix.net, but there is no extension list under "Vulkan 1.0 - all DONE: anv, radv" There is a couple of command lines in the commit message though: https://cgit.freedesktop.org/mesa/mesa/commit/?id=fe3d2559d

Re: [Mesa-dev] [PATCH 1/2] anv: android build system changes

2017-09-14 Thread Chad Versace
On Thu 14 Sep 2017, Tapani Pälli wrote: > Following changes are made to support VK_ANDROID_native_buffer: > >- bring in vk_android_native_buffer.xml >- rename target as vulkan.$(TARGET_BOARD_PLATFORM) >- use LOCAL_PROPRIETARY_MODULE to install under vendor path >- link with libsync

[Mesa-dev] [PATCH 20/20 v3] anv: Implement VK_ANDROID_native_buffer (v3)

2017-09-14 Thread Chad Versace
This implementation is correct (afaict), but takes two shortcuts regarding the import/export of Android sync fds. Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync fd into a VkSemaphore or VkFence, the driver instead simply blocks on the sync fd, then puts the VkSemaphore

Re: [Mesa-dev] [PATCH 20/20] anv: Implement VK_ANDROID_native_buffer (v2)

2017-09-14 Thread Chad Versace
On Thu 14 Sep 2017, Tapani Pälli wrote: > > > On 09/14/2017 08:51 AM, Tapani Pälli wrote: > > > > > > On 09/14/2017 02:03 AM, Chad Versace wrote: > > > From: Chad Versace > > > > > > This implementation is correct (afaict), but takes two shortcuts > > > regarding the import/export of Android

[Mesa-dev] [PATCH 9.5/20] anv/android: Link to libsync, liblog in Android.mk

2017-09-14 Thread Chad Versace
From: Tapani Pälli chadv: I made this patch by extracting the hunk from Tapani's patch in https://lists.freedesktop.org/archives/mesa-dev/2017-September/169602.html. Signed-off-by: Chad Versace --- src/intel/Android.vulkan.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [Mesa-dev] [PATCH] anv: Feed vk_android_native_buffer.xml to generators (v2)

2017-09-14 Thread Chad Versace
OOPS. Ignore this. This message has the wrong In-Reply-To. On Thu 14 Sep 2017, Chad Versace wrote: > Feed the XML to anv_extensions.py and anv_entrypoints_gen.py. > Do it on all platforms, not just Android. Tested on Android and Fedora. > > We always parse the Android XML, regardless of target pl

[Mesa-dev] [PATCH] anv: Feed vk_android_native_buffer.xml to generators (v2)

2017-09-14 Thread Chad Versace
Feed the XML to anv_extensions.py and anv_entrypoints_gen.py. Do it on all platforms, not just Android. Tested on Android and Fedora. We always parse the Android XML, regardless of target platform, to help reduce the chance that people working on non-Android break the Android build. v2: - Squas

[Mesa-dev] [PATCH] anv: Feed vk_android_native_buffer.xml to generators (v2)

2017-09-14 Thread Chad Versace
Feed the XML to anv_extensions.py and anv_entrypoints_gen.py. Do it on all platforms, not just Android. Tested on Android and Fedora. We always parse the Android XML, regardless of target platform, to help reduce the chance that people working on non-Android break the Android build. v2: - Squas

[Mesa-dev] [PATCH] util: Add a string buffer implementation

2017-09-14 Thread Thomas Helland
Based on Vladislav Egorovs work on the preprocessor, but split out to a util functionality that should be universal. Setup, teardown, memory handling and general layout is modeled around the hash_table and the set, to make it familiar for everyone. A notable change is that this implementation is a

[Mesa-dev] [PATCH] glcpp: Avoid unnecessary call to strlen

2017-09-14 Thread Thomas Helland
Length of the token was already calculated by flex and stored in yyleng, no need to implicitly call strlen() via linear_strdup(). Reviewed-by: Nicolai Hähnle Reviewed-by: Timothy Arceri V2: Also convert this pattern in glsl_lexer.ll V3: Remove a misplaced comment V4: Use a temporary char to a

Re: [Mesa-dev] [PATCH 2/2] radv: dump the device name into the hang report

2017-09-14 Thread Bas Nieuwenhuizen
This series is Reviewed-by: Bas Nieuwenhuizen On Thu, Sep 14, 2017 at 11:25 AM, Samuel Pitoiset wrote: > Similar to RadeonSI renderer string. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_debug.c | 30 ++ > 1 file changed, 30 insertions(+) > > diff

Re: [Mesa-dev] Mesa (master): drirc: enable glthread for more games (Civ5, CivBE, Dreamfall, Hitman, SR3)

2017-09-14 Thread Samuel Pitoiset
On 09/14/2017 09:57 PM, Marek Olšák wrote: On Thu, Sep 14, 2017 at 9:18 PM, Samuel Pitoiset wrote: On 09/14/2017 09:03 PM, Marek Olšák wrote: Module: Mesa Branch: master Commit: 7ffd4d2a6670ccefd4d697954a1ac67b5839da7d URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7ffd4d2a6670ccef

Re: [Mesa-dev] Mesa (master): drirc: enable glthread for more games (Civ5, CivBE, Dreamfall, Hitman, SR3)

2017-09-14 Thread Marek Olšák
On Thu, Sep 14, 2017 at 9:18 PM, Samuel Pitoiset wrote: > > > On 09/14/2017 09:03 PM, Marek Olšák wrote: >> >> Module: Mesa >> Branch: master >> Commit: 7ffd4d2a6670ccefd4d697954a1ac67b5839da7d >> URL: >> http://cgit.freedesktop.org/mesa/mesa/commit/?id=7ffd4d2a6670ccefd4d697954a1ac67b5839da7d >>

Re: [Mesa-dev] [PATCH 3/3] i965: Disable stencil cache optimization combining two 4x2 blocks

2017-09-14 Thread Chad Versace
On Mon 11 Sep 2017, Topi Pohjolainen wrote: > From the BDW PRM, Volume 15, Workarounds: > > KMD Wa4x4STCOptimizationDisable HIZ/STC hang in hawx frames. > > W/A: Disable 4x4 RCPFE STC optimization and therefore only send one > valid 4x4 to STC on 4x4 interface. This will require setting bit

Re: [Mesa-dev] [PATCH] radv: fix a potential crash if attachments allocation failed

2017-09-14 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Sep 14, 2017 at 6:47 PM, Samuel Pitoiset wrote: > Also, it's useless to set the error code twice. Though, we > should probably skip the next commands when the command buffer > is considered invalid. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulka

Re: [Mesa-dev] [RFC] NIR serialization

2017-09-14 Thread Connor Abbott
On Tue, Sep 12, 2017 at 2:09 PM, Jason Ekstrand wrote: > On Tue, Sep 12, 2017 at 10:12 AM, Ian Romanick wrote: >> >> On 09/11/2017 11:17 PM, Kenneth Graunke wrote: >> > On Monday, September 11, 2017 9:23:05 PM PDT Ian Romanick wrote: >> >> On 09/08/2017 01:59 AM, Kenneth Graunke wrote: >> >>> On

Re: [Mesa-dev] Mesa (master): drirc: enable glthread for more games (Civ5, CivBE, Dreamfall, Hitman, SR3)

2017-09-14 Thread Samuel Pitoiset
On 09/14/2017 09:03 PM, Marek Olšák wrote: Module: Mesa Branch: master Commit: 7ffd4d2a6670ccefd4d697954a1ac67b5839da7d URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7ffd4d2a6670ccefd4d697954a1ac67b5839da7d Author: Christoph Berliner Date: Thu Sep 14 21:01:04 2017 +0200 drirc:

Re: [Mesa-dev] [PATCH 2/2] util/u_atomic: Add implementation of __sync_val_compare_and_swap_8

2017-09-14 Thread Matt Turner
Grazvydas, I noticed that there are some __atomic functions in this file, but I'm not sure what they do or why they're necessary. Remind me? Thanks, Matt ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/list

[Mesa-dev] [PATCH 2/2] util/u_atomic: Add implementation of __sync_val_compare_and_swap_8

2017-09-14 Thread Matt Turner
Needed for 32-bit PowerPC. --- src/util/u_atomic.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/util/u_atomic.c b/src/util/u_atomic.c index 44b75fb0c0..b32527fe34 100644 --- a/src/util/u_atomic.c +++ b/src/util/u_atomic.c @@ -61,6 +61,20 @@ __sync_sub_and_fetch_8(uint64_

[Mesa-dev] [PATCH 1/2] util: Link libmesautil into u_atomic_test

2017-09-14 Thread Matt Turner
Platforms without particular atomic operations require the implementations in u_atomic.c --- src/util/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/Makefile.am b/src/util/Makefile.am index 4512dc99d5..9885bbe968 100644 --- a/src/util/Makefile.am +++ b/src/util/Makefile.a

Re: [Mesa-dev] [PATCH v2 0/4] gbm: Add a modifier_plane_count query

2017-09-14 Thread Daniel Stone
Hi, On 5 September 2017 at 16:48, Jason Ekstrand wrote: > This is mostly just a re-send of the original patch series I sent out only > with a couple of reviews and fixes applied. I'm happy with it and I think > Daniel can confirm that it fixes the problem we're having in modesetting > when tryin

Re: [Mesa-dev] [RFC 0/3] Flag new aux state when we create/drop aux surfaces

2017-09-14 Thread Kenneth Graunke
On Thursday, September 14, 2017 10:33:22 AM PDT Jason Ekstrand wrote: > I read through the series and, while I think it will fix the issue in 90% > of cases, I don't think it's quite the right solution. There's a *lot* of > subtlety here and we need to tread carefully. I think the better thing to

Re: [Mesa-dev] [PATCH v2 2/4] gbm: Add a gbm_device_get_format_modifier_plane_count function

2017-09-14 Thread Daniel Stone
On 5 September 2017 at 16:48, Jason Ekstrand wrote: > +/** Get the number of planes that are required for a given format+modifier > + * > + * \param gbm The gbm device returned from gbm_create_device() > + * \param format The format to query > + * \param modifier The modifier to query > + */ > +in

Re: [Mesa-dev] [PATCH] i965: fix build warning on clang

2017-09-14 Thread Jordan Justen
On 2017-09-14 00:26:39, Tapani Pälli wrote: > fixes following warning: >warning: format specifies type 'long' but the argument has type 'uint64_t' > (aka 'unsigned long long') > > cast is needed to avoid this turning in to another warning on 32bit build: >warning: format specifies type 'u

Re: [Mesa-dev] [PATCH 1/3] glsl: don't drop intructions from unreachable terminators continue branch

2017-09-14 Thread Emil Velikov
Hi Tim On 14 September 2017 at 05:47, Timothy Arceri wrote: > These instruction will be executed on every iteration of the loop > we cannot drop them. This and 2/3 sound like very nice bugfixes. I haven't checked if they apply for 17.2 - if not can you do some backports. Once people have checke

Re: [Mesa-dev] [PATCH 2/3] intel/blorp/hiz: Always set sample number

2017-09-14 Thread Chad Versace
On Wed 13 Sep 2017, Matt Turner wrote: > In-Reply-To: <20170913220107.gd6...@ivybridge.mattst88.com> Matt, upgrade your machine. Ivy Bridge is ancient. > On 09/11, Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > > Patches 2-3 (because I don't know a lot about this code) are > > A

Re: [Mesa-dev] [PATCH 2/2] anv: set has_exec_async to false on Android

2017-09-14 Thread Emil Velikov
On 14 September 2017 at 07:57, Tapani Pälli wrote: > Other WSI implementations set has_exec_async false for WSI buffers, > so far haven't found a place to do it so we just claim to not have > async exec. > What's the actual side-effects you're seeing? I'd imagine Jason, Chris and the gang may have

Re: [Mesa-dev] [PATCH 1/2] anv: android build system changes

2017-09-14 Thread Emil Velikov
Hi Tapani, On 14 September 2017 at 07:57, Tapani Pälli wrote: > Following changes are made to support VK_ANDROID_native_buffer: > >- bring in vk_android_native_buffer.xml >- rename target as vulkan.$(TARGET_BOARD_PLATFORM) >- use LOCAL_PROPRIETARY_MODULE to install under vendor path >

Re: [Mesa-dev] [PATCH 1/3] i965/gen8: Remove unused gen8_emit_3dstate_multisample()

2017-09-14 Thread Chad Versace
On Mon 11 Sep 2017, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_context.h| 1 - > src/mesa/drivers/dri/i965/gen8_multisample_state.c | 16 > 2 files changed, 17 deletions(-) Reviewed-by: Chad Versace _

[Mesa-dev] [PATCH 2/2] radeonsi: reallocate if a non-sharable textures is being shared

2017-09-14 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index 26afc98..e9507c3 100644 --- a/src/gallium/drivers/radeon/r600_text

[Mesa-dev] [PATCH 1/2] radeonsi: PIPE_BIND_SHARED should allow inter-process sharing

2017-09-14 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_buffer_common.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_buffer_common.c b/src/gallium/drivers/radeon/r600_buffer_common.c index f35bc2c..7515f7d 100644 --- a/src/gallium/dr

Re: [Mesa-dev] [RFC 0/3] Flag new aux state when we create/drop aux surfaces

2017-09-14 Thread Jason Ekstrand
I read through the series and, while I think it will fix the issue in 90% of cases, I don't think it's quite the right solution. There's a *lot* of subtlety here and we need to tread carefully. I think the better thing to do would be to whack the new flag in two places: Whenever we change the fa

[Mesa-dev] [Bug 101747] Steam-Game Turmoil, Segfault on start

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101747 --- Comment #5 from John --- In case it helps, this is the minimum needed: R600_DEBUG="vs,ps" to not crash. The others don't seem to matter. -- You are receiving this mail because: You are the assignee for the bug._

[Mesa-dev] [Bug 101747] Steam-Game Turmoil, Segfault on start

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101747 --- Comment #4 from John --- That's right it does not! Out of curiosity why is a debug print command preventing the crash? -- You are receiving this mail because: You are the assignee for the bug.__

Re: [Mesa-dev] [PATCH 1/2] anv: android build system changes

2017-09-14 Thread Rob Herring
On Thu, Sep 14, 2017 at 1:57 AM, Tapani Pälli wrote: > Following changes are made to support VK_ANDROID_native_buffer: > >- bring in vk_android_native_buffer.xml >- rename target as vulkan.$(TARGET_BOARD_PLATFORM) >- use LOCAL_PROPRIETARY_MODULE to install under vendor path Good to se

[Mesa-dev] [PATCH 4/4] radv: move compute related code to radv_compute.c

2017-09-14 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/Makefile.sources | 2 + src/amd/vulkan/radv_cmd_buffer.c | 239 +- src/amd/vulkan/radv_compute.c| 275 +++ src/amd/vulkan/radv_compute.h| 69 ++ src/amd/vulkan

[Mesa-dev] [PATCH 3/4] radv: inline radv_flush_compute_state() into radv_dispatch()

2017-09-14 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 143acf1719..10a071c3d6 100644 --- a/src/amd/vulkan/radv_cmd_buffer.

[Mesa-dev] [PATCH 1/4] radv: add radv_emit_dispatch_packets() helper

2017-09-14 Thread Samuel Pitoiset
To share common dispatch compute code. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 252 +++ 1 file changed, 149 insertions(+), 103 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 06

[Mesa-dev] [PATCH 2/4] radv: add radv_dispatch() helper

2017-09-14 Thread Samuel Pitoiset
To share common dispatch compute code. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 6ffbba2f1d..143

[Mesa-dev] [PATCH] radv: fix a potential crash if attachments allocation failed

2017-09-14 Thread Samuel Pitoiset
Also, it's useless to set the error code twice. Though, we should probably skip the next commands when the command buffer is considered invalid. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulka

Re: [Mesa-dev] [PATCH v2 12/15] i965: Make BLORP properly avoid batch wrapping.

2017-09-14 Thread Kenneth Graunke
On Thursday, September 14, 2017 3:22:48 AM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2017-09-13 21:54:14) > > We need to set brw->no_batch_wrap to actually avoid flushing in the > > middle of our BLORP operation, and instead grow the batchbuffer. > > --- > > src/mesa/drivers/dri/i965/genX

Re: [Mesa-dev] [PATCH 1/3] glsl: don't drop intructions from unreachable terminators continue branch

2017-09-14 Thread tournier.elie
With the small nitpick from Eric, the series is: Reviewed-by: Elie Tournier On 14 September 2017 at 05:47, Timothy Arceri wrote: > These instruction will be executed on every iteration of the loop > we cannot drop them. > --- > src/compiler/glsl/loop_analysis.h | 7 +++ > src/compiler/gl

Re: [Mesa-dev] [PATCH] r600: fork and import gallium/radeon

2017-09-14 Thread Marek Olšák
On Thu, Sep 14, 2017 at 4:19 PM, Emil Velikov wrote: > Hi Marek, > > On 14 September 2017 at 14:06, Marek Olšák wrote: >> From: Marek Olšák >> >> This marks the end of code sharing between r600 and radeonsi. >> > It has the "what" but it's missing the "why". Can you please add some > information

Re: [Mesa-dev] [PATCH 4/7] radeonsi: make use of LOAD for UBOs

2017-09-14 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Aug 22, 2017 at 2:14 PM, Timothy Arceri wrote: > v2: always set can_speculate and allow_smem to true > --- > src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 31 > +++ > 1 file changed, 21 insertions(+), 10 deletions(-) > > diff --

[Mesa-dev] [Bug 101747] Steam-Game Turmoil, Segfault on start

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101747 --- Comment #3 from Samuel Pitoiset --- I guess it shouldn't crash with R600_DEBUG="vs,ps,gs,tcs,tes,cs" ? -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailin

Re: [Mesa-dev] [PATCH v2 0/2] Add libunwind to travis gallium build and fix it

2017-09-14 Thread Eric Engestrom
On Thursday, 2017-09-14 12:27:40 +0200, Gert Wollny wrote: > The second version of the two patches now forces llvm-3.3 for > "make Gallium ST Other" and no longer requires changing any Makefile.am. > In addition, like suggested by Emil, --enable/disable-libunwind is set > appropriately. Thanks,

Re: [Mesa-dev] [PATCH] r600: fork and import gallium/radeon

2017-09-14 Thread Nicolai Hähnle
On 14.09.2017 16:19, Emil Velikov wrote: Hi Marek, On 14 September 2017 at 14:06, Marek Olšák wrote: From: Marek Olšák This marks the end of code sharing between r600 and radeonsi. It has the "what" but it's missing the "why". Can you please add some information. Basically, it's getting

Re: [Mesa-dev] V2 radeonsi use STD430 packing of UBOs by default

2017-09-14 Thread Nicolai Hähnle
On 14.09.2017 15:14, Marek Olšák wrote: On Thu, Sep 14, 2017 at 12:31 PM, Timothy Arceri wrote: On 31/08/17 01:55, Marek Olšák wrote: On Wed, Aug 30, 2017 at 2:22 PM, Timothy Arceri wrote: On 30/08/17 20:07, Marek Olšák wrote: If LLVM was fixed to do the correct thing, we could enable

Re: [Mesa-dev] [PATCH] r600: fork and import gallium/radeon

2017-09-14 Thread Emil Velikov
Hi Marek, On 14 September 2017 at 14:06, Marek Olšák wrote: > From: Marek Olšák > > This marks the end of code sharing between r600 and radeonsi. > It has the "what" but it's missing the "why". Can you please add some information. From a quick look which will make each binary ~140KiB larger (dr

[Mesa-dev] [PATCH v2] r600g/sb: Don't require array declarations for TGSI_FILE_SYSTEM_VALUE

2017-09-14 Thread Gert Wollny
Although gl_SampleMaskIn is declared as an array in GLSL, it is effectively a 32 bit mask on all hardware supported by mesa, so the array indexing is ignored (Thanks Glenn Kennard for the explanation). Add a comment that the assert is not made superfluos by the else branch. Corrects: piglit spec@

[Mesa-dev] [Bug 102318] Mesa3D Scons build - LLVM 5.0 not supported

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102318 --- Comment #4 from Emil Velikov --- (In reply to Alex Granni from comment #3) > Created attachment 134221 [details] [review] > Patch that enables LLVM 5.0 support to Mesa3D scons build > > Here is the patch that adds support for LLVM 5.0 to Sc

Re: [Mesa-dev] V2 radeonsi use STD430 packing of UBOs by default

2017-09-14 Thread Marek Olšák
On Thu, Sep 14, 2017 at 12:31 PM, Timothy Arceri wrote: > > > On 31/08/17 01:55, Marek Olšák wrote: >> >> On Wed, Aug 30, 2017 at 2:22 PM, Timothy Arceri >> wrote: >>> >>> On 30/08/17 20:07, Marek Olšák wrote: If LLVM was fixed to do the correct thing, we could enable CONSTBUF

[Mesa-dev] [PATCH] r600: fork and import gallium/radeon

2017-09-14 Thread Marek Olšák
From: Marek Olšák This marks the end of code sharing between r600 and radeonsi. A lot of functions had to be renamed to prevent linker conflicts. There are also minor cleanups. --- This one is huge. Please review here: https://cgit.freedesktop.org/~mareko/mesa/commit/?h=master&id=858b2d1c8cec7

Re: [Mesa-dev] i965 NIR linking

2017-09-14 Thread Timothy Arceri
On 14/09/17 18:19, Eduardo Lima Mitev wrote: On 09/13/2017 01:37 AM, Timothy Arceri wrote: This started out based off the work Jason did back in 2015 to add NIR linking to the Intel VK driver. It needed a reasonable amount of updates to work with the GL driver, tess, xfb, etc. As per the resu

[Mesa-dev] [RFC 2/3] i965: emit BRW_NEW_AUX_STATE when we allocate aux surfaces

2017-09-14 Thread Iago Toral Quiroga
Fixes a regression introduced with b96313c0e1289b296d7, which removed BRW_NEW_BLORP for a bunch of SURFACE_STATE setup code, including render targets, on the basis that blorp invalidates binding tables but not surface states, however, at least on Broadwell, this caused a regression in a CTS test, w

[Mesa-dev] [RFC 3/3] i965: flag BRW_NEW_AUX_STATE if we drop the aux buffer

2017-09-14 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 8a809a7320d..0328a4604dd 100644 --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c +++ b/src

[Mesa-dev] [RFC 0/3] Flag new aux state when we create/drop aux surfaces

2017-09-14 Thread Iago Toral Quiroga
Jason, Ken: this is what I came up based on your findings that Ken reported in https://bugs.freedesktop.org/show_bug.cgi?id=102611. Ken mentioned that he is not completely certain that we need to flag dirty state every time we update the surfaces and that maybe flagging only when we go from/to AUX

[Mesa-dev] [RFC 1/3] i965: rename BRW_NEW_FAST_CLEAR_COLOR to BRW_NEW_AUX_STATE

2017-09-14 Thread Iago Toral Quiroga
We want to use this flag to signal changes to the aux surfaces, so let's not make it about fast clearing only. Suggested by Jason. --- src/mesa/drivers/dri/i965/brw_blorp.c | 2 +- src/mesa/drivers/dri/i965/brw_context.h | 4 ++-- src/mesa/drivers/dri/i965/brw_gs_surface_st

Re: [Mesa-dev] [PATCH v2 01/15] i965: Delete a batch size assertion that isn't very useful.

2017-09-14 Thread Chris Wilson
Quoting Matt Turner (2017-09-14 00:22:45) > The series looks good to me. I had a question on 03/15, mostly for > clarification in the commit message. The series is > > Reviewed-by: Matt Turner Seconded. Just a minor tweak around reallocing the shadow in my case, but that doesn't have to happen i

Re: [Mesa-dev] V2 radeonsi use STD430 packing of UBOs by default

2017-09-14 Thread Timothy Arceri
On 31/08/17 01:55, Marek Olšák wrote: On Wed, Aug 30, 2017 at 2:22 PM, Timothy Arceri wrote: On 30/08/17 20:07, Marek Olšák wrote: If LLVM was fixed to do the correct thing, we could enable CONSTBUF LOAD for LLVM 6.0 and later. You seem to think that the compiler *should* be placing them

  1   2   >