Re: [Mesa-dev] [PATCH 07/16] radeonsi: add reference count to si_compute

2017-08-20 Thread Gert Wollny
Am Sonntag, den 20.08.2017, 15:48 +0200 schrieb Marek Olšák: > The patch seems OK to me. Hmm, you're right in that I was wrong about "program", I still need learn to think in patches.  However, when I look at si_delete_compute_state where si_compute_reference is called: >+ si_compute_refe

Re: [Mesa-dev] [PATCH] gles2: Support for GL_EXT_occlusion_query_boolean

2017-08-20 Thread Tapani Pälli
On 08/21/2017 08:47 AM, Harish Krupo wrote: Hi Ilia, On 08/21/2017 10:42 AM, Ilia Mirkin wrote: On Mon, Aug 21, 2017 at 12:52 AM, Harish Krupo wrote: Hi Ilia, On 08/18/2017 07:20 PM, Ilia Mirkin wrote: Why the static data changes? Also, I haven't double checked the code, but I'm almost

Re: [Mesa-dev] [PATCH] gles2: Support for GL_EXT_occlusion_query_boolean

2017-08-20 Thread Harish Krupo
Hi Ilia, On 08/21/2017 10:42 AM, Ilia Mirkin wrote: On Mon, Aug 21, 2017 at 12:52 AM, Harish Krupo wrote: Hi Ilia, On 08/18/2017 07:20 PM, Ilia Mirkin wrote: Why the static data changes? Also, I haven't double checked the code, but I'm almost certain this is incomplete. You have to add code

Re: [Mesa-dev] [PATCH] gles2: Support for GL_EXT_occlusion_query_boolean

2017-08-20 Thread Ilia Mirkin
On Mon, Aug 21, 2017 at 12:52 AM, Harish Krupo wrote: > Hi Ilia, > > On 08/18/2017 07:20 PM, Ilia Mirkin wrote: >> >> Why the static data changes? Also, I haven't double checked the code, but >> I'm almost certain this is incomplete. You have to add code disallowing the >> other enums from being u

Re: [Mesa-dev] [PATCH] gles2: Support for GL_EXT_occlusion_query_boolean

2017-08-20 Thread Harish Krupo
Hi Ilia, On 08/18/2017 07:20 PM, Ilia Mirkin wrote: Why the static data changes? Also, I haven't double checked the code, but I'm almost certain this is incomplete. You have to add code disallowing the other enums from being used on es2. Thank you for pointing out that code is required to dis

[Mesa-dev] [PATCH 7/8] docs: remove link to MissingFunctionality wiki page

2017-08-20 Thread Timothy Arceri
Outdated, features.txt is used instead. --- It would be great if someone who knows how could just remove the wiki page. It doesn't really offer anything of value anymore. docs/helpwanted.html | 2 -- 1 file changed, 2 deletions(-) diff --git a/docs/helpwanted.html b/docs/helpwanted.html index

[Mesa-dev] [PATCH 6/8] docs: remove MSVC testing/building from help wanted

2017-08-20 Thread Timothy Arceri
We are using appveyor for Windows continuous integration. --- docs/helpwanted.html | 3 --- 1 file changed, 3 deletions(-) diff --git a/docs/helpwanted.html b/docs/helpwanted.html index bf6f788096..48e57fc716 100644 --- a/docs/helpwanted.html +++ b/docs/helpwanted.html @@ -28,23 +28,20 @@ Patches

[Mesa-dev] [RPF PATCH 8/8] docs: add todo.txt for various Mesa tasks

2017-08-20 Thread Timothy Arceri
Generally I'm not a huge fan of todo.txt files as they tend to not get updated. However we have a faily active community looking for ways to contribute and wiki pages tend to be forgotten about even more easily as well as being more onerous to update. features.txt although more specific has been s

[Mesa-dev] [PATCH 5/8] docs: remove automatic testing from help wanted

2017-08-20 Thread Timothy Arceri
Intel has a Jenkins setup and has made the various scripts and documentation open source. --- docs/helpwanted.html | 6 -- 1 file changed, 6 deletions(-) diff --git a/docs/helpwanted.html b/docs/helpwanted.html index 273d4d56be..bf6f788096 100644 --- a/docs/helpwanted.html +++ b/docs/helpwant

[Mesa-dev] [PATCH 1/8] gallium/docs: remove old llvmpipe TODO

2017-08-20 Thread Timothy Arceri
Features are already covered by features.txt like all the other drivers. --- docs/helpwanted.html | 2 -- src/gallium/docs/llvm-todo.txt | 14 -- 2 files changed, 16 deletions(-) delete mode 100644 src/gallium/docs/llvm-todo.txt diff --git a/docs/helpwanted.html b/docs/hel

[Mesa-dev] [PATCH 4/8] docs: rename TODOs to Legacy Driver TODOs

2017-08-20 Thread Timothy Arceri
--- docs/helpwanted.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/helpwanted.html b/docs/helpwanted.html index 11be4e0454..273d4d56be 100644 --- a/docs/helpwanted.html +++ b/docs/helpwanted.html @@ -56,21 +56,21 @@ You can find some further To-do lists here: Common

[Mesa-dev] [PATCH 2/8] docs: remove link to radeonsi TODO wiki page

2017-08-20 Thread Timothy Arceri
This page is deprecated. --- docs/helpwanted.html | 2 -- 1 file changed, 2 deletions(-) diff --git a/docs/helpwanted.html b/docs/helpwanted.html index 683ebbe615..f7bba0f479 100644 --- a/docs/helpwanted.html +++ b/docs/helpwanted.html @@ -59,22 +59,20 @@ You can find some further To-do lists her

[Mesa-dev] [PATCH 3/8] docs: remove link to i915g TODOs

2017-08-20 Thread Timothy Arceri
This is an unoffical unmaintained driver, we don't really want people wasting effort trying to improve it. --- docs/helpwanted.html | 2 -- 1 file changed, 2 deletions(-) diff --git a/docs/helpwanted.html b/docs/helpwanted.html index f7bba0f479..11be4e0454 100644 --- a/docs/helpwanted.html +++ b/

Re: [Mesa-dev] [PATCH] radeonsi: remove Constant Engine support

2017-08-20 Thread Dieter Nützel
Tested-by: Dieter Nützel on RX580 smaller foot print, now;-) Dieter Am 19.08.2017 19:03, schrieb Marek Olšák: From: Marek Olšák We have come to the conclusion that it doesn't improve performance. --- src/gallium/drivers/radeon/r600_gpu_load.c| 3 - src/gallium/drivers/radeon/r600_pi

Re: [Mesa-dev] [PATCH 00/18] Gallium blitter optimizations

2017-08-20 Thread Dave Airlie
On 21 August 2017 at 10:58, Marek Olšák wrote: > On Mon, Aug 21, 2017 at 2:41 AM, Dave Airlie wrote: >> On 21 August 2017 at 10:22, Dave Airlie wrote: >>> Hi Gert, >>> >>> Can you test this along with the fetch shader patch Marek sent? >>> >>> I'm giving it a piglit run now. >> >> Actually that

Re: [Mesa-dev] [PATCH 00/18] Gallium blitter optimizations

2017-08-20 Thread Marek Olšák
On Mon, Aug 21, 2017 at 2:41 AM, Dave Airlie wrote: > On 21 August 2017 at 10:22, Dave Airlie wrote: >> Hi Gert, >> >> Can you test this along with the fetch shader patch Marek sent? >> >> I'm giving it a piglit run now. > > Actually that patch is probably not necessary, > > I think you need to f

[Mesa-dev] [PATCH] mesa: fix ES only draw if we have vertex positions

2017-08-20 Thread Timothy Arceri
This code was separated from the validation code so it could use used with KHR_no_error paths. The return values were inverted to reflect the name of the helper, but here the condtion was mistakenly inverted rather than the return value. Fixes: 4df2931a87fe (mesa/vbo: move some Draw checks out of

Re: [Mesa-dev] [PATCH 00/18] Gallium blitter optimizations

2017-08-20 Thread Dave Airlie
On 21 August 2017 at 10:22, Dave Airlie wrote: > Hi Gert, > > Can you test this along with the fetch shader patch Marek sent? > > I'm giving it a piglit run now. Actually that patch is probably not necessary, I think you need to fill in 0 for the 4th 2D coordinate for LD to be used. TGSI spec f

Re: [Mesa-dev] [PATCH 00/18] Gallium blitter optimizations

2017-08-20 Thread Dave Airlie
Hi Gert, Can you test this along with the fetch shader patch Marek sent? I'm giving it a piglit run now. Dave. On 21 August 2017 at 09:22, Dave Airlie wrote: > On 20 August 2017 at 05:25, Marek Olšák wrote: >> On Sat, Aug 19, 2017 at 7:24 PM, Gert Wollny wrote: >>> Am Samstag, den 19.08.2017

Re: [Mesa-dev] [PATCH 02/18] gallium/radeon: use rectangles for 1D and 2D texture blits

2017-08-20 Thread Dave Airlie
> > Actually I can still get into a wierd place where simple tests that > readback fail. > > I'll try and dig some more. Ignore previous, the problem is you don't zero the other coords in the vertex buffer, so r600 sees a TXF 2D but passes all 4 texture coord to the hw. Dave.

Re: [Mesa-dev] i965/radeonsi use STD430 packing of UBOs by default

2017-08-20 Thread Marek Olšák
On Mon, Aug 21, 2017 at 1:38 AM, Timothy Arceri wrote: > > > On 21/08/17 08:58, Marek Olšák wrote: >> >> On Mon, Aug 21, 2017 at 12:52 AM, Timothy Arceri >> wrote: >>> >>> On 21/08/17 03:25, Marek Olšák wrote: On Thu, Aug 17, 2017 at 1:02 PM, Timothy Arceri wrote: > >

Re: [Mesa-dev] [PATCH 02/18] gallium/radeon: use rectangles for 1D and 2D texture blits

2017-08-20 Thread Dave Airlie
On 21 August 2017 at 09:28, Dave Airlie wrote: > On 18 August 2017 at 04:31, Marek Olšák wrote: >> From: Marek Olšák >> > > This break r600 first. > >> - if (attrib) { >> + switch (type) { >> + case UTIL_BLITTER_ATTRIB_COLOR: >> memcpy(vb+4, attrib->f, sizeof(fl

Re: [Mesa-dev] i965/radeonsi use STD430 packing of UBOs by default

2017-08-20 Thread Timothy Arceri
On 21/08/17 08:58, Marek Olšák wrote: On Mon, Aug 21, 2017 at 12:52 AM, Timothy Arceri wrote: On 21/08/17 03:25, Marek Olšák wrote: On Thu, Aug 17, 2017 at 1:02 PM, Timothy Arceri wrote: Shared (the default) and packed layouts are decided by the implementation. Currently we just pack the

Re: [Mesa-dev] [PATCH 24/27] glsl: Assign atomic counter resources on shader compile fall back path

2017-08-20 Thread Timothy Arceri
On 19/08/17 17:44, Jordan Justen wrote: Signed-off-by: Jordan Justen Cc: Timothy Arceri --- src/compiler/glsl/linker.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index 306051f1f0..671c38e8e1 100644 --- a

Re: [Mesa-dev] [PATCH 02/18] gallium/radeon: use rectangles for 1D and 2D texture blits

2017-08-20 Thread Dave Airlie
On 18 August 2017 at 04:31, Marek Olšák wrote: > From: Marek Olšák > This break r600 first. > - if (attrib) { > + switch (type) { > + case UTIL_BLITTER_ATTRIB_COLOR: > memcpy(vb+4, attrib->f, sizeof(float)*4); > memcpy(vb+12, attrib->f, sizeof(f

Re: [Mesa-dev] [PATCH 00/18] Gallium blitter optimizations

2017-08-20 Thread Dave Airlie
On 20 August 2017 at 05:25, Marek Olšák wrote: > On Sat, Aug 19, 2017 at 7:24 PM, Gert Wollny wrote: >> Am Samstag, den 19.08.2017, 18:35 +0200 schrieb Marek Olšák: >>> Can you try the attached patch? >> >> While if fixes the crash and lets me run glxgears and some other rathe >> simple OpenGL pr

Re: [Mesa-dev] [PATCH 25/27] glsl/shader_cache: Save fs (BlendSupport) metadata

2017-08-20 Thread Timothy Arceri
On 19/08/17 17:44, Jordan Justen wrote: Fixes many GL 4.5 CTS blend tests, such as: * GL45-CTS.blend_equation_advanced.extension_directive_enable * GL45-CTS.blend_equation_advanced.extension_directive_warn * GL45-CTS.blend_equation_advanced.blend_all.GL_MULTIPLY_KHR_all_qualifier * GL45-CTS.bl

Re: [Mesa-dev] i965/radeonsi use STD430 packing of UBOs by default

2017-08-20 Thread Marek Olšák
On Mon, Aug 21, 2017 at 12:52 AM, Timothy Arceri wrote: > On 21/08/17 03:25, Marek Olšák wrote: >> >> On Thu, Aug 17, 2017 at 1:02 PM, Timothy Arceri >> wrote: >>> >>> Shared (the default) and packed layouts are decided by the >>> implementation. >>> Currently we just pack them using the std140 l

Re: [Mesa-dev] i965/radeonsi use STD430 packing of UBOs by default

2017-08-20 Thread Timothy Arceri
On 21/08/17 03:25, Marek Olšák wrote: On Thu, Aug 17, 2017 at 1:02 PM, Timothy Arceri wrote: Shared (the default) and packed layouts are decided by the implementation. Currently we just pack them using the std140 layout. This change makes it so we use the slightly more compact std430 layout on

[Mesa-dev] [Bug 102308] segfault in glCompressedTextureSubImage3D

2017-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102308 Ilia Mirkin changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

2017-08-20 Thread Rob Herring
On Fri, Aug 18, 2017 at 8:53 PM, Chih-Wei Huang wrote: > 2017-08-19 8:27 GMT+08:00 Emil Velikov : >> On 18 August 2017 at 20:46, Rob Herring wrote: >>> Both statically linking libLLVMCore and dynamically linking libLLVM causes >>> duplicated symbols in gallium_dri.so and it fails to dlopen. We do

Re: [Mesa-dev] i965/radeonsi use STD430 packing of UBOs by default

2017-08-20 Thread Marek Olšák
On Thu, Aug 17, 2017 at 1:02 PM, Timothy Arceri wrote: > Shared (the default) and packed layouts are decided by the implementation. > Currently we just pack them using the std140 layout. This change makes it so > we use the slightly more compact std430 layout on i965 and radeonsi. > > I doubt this

Re: [Mesa-dev] Mesa 17.1.7 release candidate

2017-08-20 Thread Jason Ekstrand
On August 20, 2017 8:57:15 AM Andres Gomez wrote: On Sun, 2017-08-20 at 07:19 -0700, Jason Ekstrand wrote: On August 19, 2017 8:38:04 AM Andres Gomez wrote: [...] > > Mesa stable queue > - > > Nominated (3) > = > > Ilia Mirkin (1): > glsl: add a few miss

Re: [Mesa-dev] [PATCH] mesa: only copy requested compressed teximage faces

2017-08-20 Thread Ilia Mirkin
On Sun, Aug 20, 2017 at 3:42 AM, Christoph Haag wrote: > On 20.08.2017 02:07, Ilia Mirkin wrote: >> Reviewed-by: Ilia Mirkin >> >> Will push this out tomorrow unless there are any objections. > > It would probably be also good for mesa stable, right? > Yep, I have it tagged as such in my tree. _

Re: [Mesa-dev] [PATCH 8/8] gallium: remove TGSI opcode KILL

2017-08-20 Thread Ilia Mirkin
On Sun, Aug 20, 2017 at 6:51 AM, Marek Olšák wrote: > On Sun, Aug 20, 2017 at 4:29 AM, Roland Scheidegger > wrote: >> For 1-3/8, I don't think anything ever used these, and 5/8 (DPH) we >> don't need neither, so >> Reviewed-by: Roland Scheidegger >> >> 4,6,7, well we can live fine without them,

Re: [Mesa-dev] [PATCH 16/16] gallium: remove unused PIPE_DUMP_* defines

2017-08-20 Thread Marek Olšák
For patches 12-16: Reviewed-by: Marek Olšák Marek On Wed, Aug 16, 2017 at 1:05 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/drivers/ddebug/dd_draw.c| 21 - > src/gallium/drivers/radeonsi/si_debug.c | 8 +++- > src/gallium/include/pipe/p_

Re: [Mesa-dev] [PATCH 11/16] radeonsi: print saved CS to the log context

2017-08-20 Thread Marek Olšák
On Wed, Aug 16, 2017 at 1:05 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Use the auto logger facility, so that CS chunks will be interleaved > with other log info. > --- > src/gallium/drivers/radeonsi/si_debug.c | 215 > +-- > src/gallium/drivers/radeonsi/

Re: [Mesa-dev] Mesa 17.1.7 release candidate

2017-08-20 Thread Andres Gomez
On Sun, 2017-08-20 at 07:19 -0700, Jason Ekstrand wrote: > On August 19, 2017 8:38:04 AM Andres Gomez wrote: > [...] > > > > Mesa stable queue > > - > > > > Nominated (3) > > = > > > > Ilia Mirkin (1): > > glsl: add a few missing int64 constant propagation c

Re: [Mesa-dev] [PATCH 10/16] radeonsi: start using u_log_context for debugging

2017-08-20 Thread Marek Olšák
For patches 1-10: Reviewed-by: Marek Olšák Marek On Wed, Aug 16, 2017 at 1:05 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/drivers/radeon/r600_pipe_common.h | 2 +- > src/gallium/drivers/radeon/r600_texture.c | 41 +++-- > src/gallium/drivers/radeonsi/si_debu

Re: [Mesa-dev] Mesa 17.1.7 release candidate

2017-08-20 Thread Jason Ekstrand
On August 19, 2017 8:38:04 AM Andres Gomez wrote: Hello list, The candidate for the Mesa 17.1.7 is now available. Currently we have:  - 33 queued  - 3 nominated (outstanding)  - and 3 rejected patches In the current queue we have: The state tracker received a fix to avoid a crash accessing

Re: [Mesa-dev] [PATCH 07/16] radeonsi: add reference count to si_compute

2017-08-20 Thread Marek Olšák
The patch seems OK to me. Marek On Wed, Aug 16, 2017 at 1:50 PM, Gert Wollny wrote: > Hello Nicolai, > > I've spotted a little problem in you code (see below). > > Best, > Gert > > > Am Mittwoch, den 16.08.2017, 13:05 +0200 schrieb Nicolai Hähnle: >> From: Nicolai Hähnle >> >> To allow keep-ali

Re: [Mesa-dev] [PATCH 8/8] gallium: remove TGSI opcode KILL

2017-08-20 Thread Marek Olšák
On Sun, Aug 20, 2017 at 4:29 AM, Roland Scheidegger wrote: > For 1-3/8, I don't think anything ever used these, and 5/8 (DPH) we > don't need neither, so > Reviewed-by: Roland Scheidegger > > 4,6,7, well we can live fine without them, just translating them away > the same as you do here too. (I t

[Mesa-dev] [PATCH] gallium: remove TGSI opcode BREAKC

2017-08-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c | 1 - src/gallium/auxiliary/gallivm/lp_bld_tgsi_info.c | 1 - src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c| 43 - src/gallium/auxiliary/nir/tgsi_to_nir.c| 3 -- src/gallium/auxil

Re: [Mesa-dev] Mesa 17.1.7 release candidate

2017-08-20 Thread Andres Gomez
On Sat, 2017-08-19 at 17:56 -0400, Ilia Mirkin wrote: > On Sat, Aug 19, 2017 at 11:37 AM, Andres Gomez wrote: > > nouveau's nv50 has gotten a fix for a problem involving ConstantFolding > > with saturation that was visible in Hitman Absolution and, possibly, in > > some other games. Also, it has g

Re: [Mesa-dev] [PATCH 2/2] i965/bufmgr: s/BO_ALLOC_FOR_RENDER/BO_ALLOC_BUSY/

2017-08-20 Thread Chris Wilson
Quoting Jason Ekstrand (2017-08-19 23:07:48) > "Alloc for render" is a terrible name for a flag because it means > basically nothing. What the flag really does is allocate a busy BO > which someone theorized at one point in time would be more efficient if > you're planning to immediately render to

[Mesa-dev] [Bug 102318] Scons build - LLVM 5.0 not supported

2017-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102318 Alex Granni changed: What|Removed |Added Attachment #133638|Mesa3D scons build with |Mesa3D scons build with descriptio

[Mesa-dev] [Bug 102318] Scons build - LLVM 5.0 not supported

2017-08-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102318 Bug ID: 102318 Summary: Scons build - LLVM 5.0 not supported Product: Mesa Version: unspecified Hardware: All OS: All Status: NEW Severity: major

Re: [Mesa-dev] [PATCH] mesa: only copy requested compressed teximage faces

2017-08-20 Thread Christoph Haag
It would probably be also good for mesa stable, right? On 20.08.2017 02:07, Ilia Mirkin wrote: > Reviewed-by: Ilia Mirkin > > Will push this out tomorrow unless there are any objections. > > On Sat, Aug 19, 2017 at 7:59 PM, Christoph Haag > wrote: >> From: Christoph Haag >> >> This is analogo