[Mesa-dev] [PATCH] i965/clear: Quantize the depth clear value based on the format

2017-08-19 Thread Jason Ekstrand
In f9fd976e8adba733b08d we changed the clear value to be stored as an isl_color_value. This had the side-effect same clear value check is now happening directly between the f32[0] field of the isl_color_value and ctx->Depth.Clear. This isn't what we want for two reasons. One is that the comparis

[Mesa-dev] [PATCH] i965/clear: Quantize the depth clear value based on the format

2017-08-19 Thread Jason Ekstrand
In f9fd976e8adba733b08d we changed the clear value to be stored as an isl_color_value. This had the side-effect same clear value check is now happening directly between the f32[0] field of the isl_color_value and ctx->Depth.Clear. This isn't what we want for two reasons. One is that the comparis

[Mesa-dev] [Bug 102315] GPU Hang when replaying API trace of lightsmark

2017-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102315 Bug ID: 102315 Summary: GPU Hang when replaying API trace of lightsmark Product: Mesa Version: 17.2 Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 8/8] gallium: remove TGSI opcode KILL

2017-08-19 Thread Roland Scheidegger
For 1-3/8, I don't think anything ever used these, and 5/8 (DPH) we don't need neither, so Reviewed-by: Roland Scheidegger 4,6,7, well we can live fine without them, just translating them away the same as you do here too. (I thought some hw could do them natively, hence the driver would have to r

[Mesa-dev] [Bug 101851] [regression] libEGL_common.a undefined reference to '__gxx_personality_v0'

2017-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101851 --- Comment #6 from Steve Arnold --- I think one of the main problems is libtool failing to pass flags specified by the user; note in the previous comment #5 it fails to pass "-fuse-ld=bfd". Also, I'm assuming the upstream flag -Wl,--no-undefin

[Mesa-dev] [PATCH 8/8] gallium: remove TGSI opcode KILL

2017-08-19 Thread Marek Olšák
From: Marek Olšák use KILL_IF -1 instead. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c | 11 -- src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c| 3 -- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c| 42 -- src/gallium/auxiliary/nir/tgsi_to_nir.c

[Mesa-dev] [PATCH 7/8] gallium: remove TGSI opcode SCS

2017-08-19 Thread Marek Olšák
From: Marek Olšák use COS+SIN instead. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c | 26 - src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c| 3 - src/gallium/auxiliary/nir/tgsi_to_nir.c| 22 src/gallium/auxiliary/tgsi/tgsi_exec.c | 31 - sr

[Mesa-dev] [PATCH 3/8] gallium: remove TGSI_OPCODE_CALLNZ

2017-08-19 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_info.c | 1 - src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 1 - src/gallium/auxiliary/nir/tgsi_to_nir.c | 1 - src/gallium/auxiliary/tgsi/tgsi_info.c | 2 +- src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h

[Mesa-dev] [PATCH 5/8] gallium: remove TGSI opcode DPH

2017-08-19 Thread Marek Olšák
From: Marek Olšák use DP4 or DP3 + ADD. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c | 17 -- src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c| 3 -- src/gallium/auxiliary/nir/tgsi_to_nir.c| 12 --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 33 ---

[Mesa-dev] [PATCH 6/8] gallium: remove TGSI opcode XPD

2017-08-19 Thread Marek Olšák
From: Marek Olšák use MUL+MAD+MOV instead. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c | 56 -- src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c| 3 - src/gallium/auxiliary/nir/tgsi_to_nir.c| 20 src/gallium/auxiliary/tgsi/tgsi_exec.c | 49

[Mesa-dev] [PATCH 2/8] gallium: remove TGSI FENCE opcodes

2017-08-19 Thread Marek Olšák
From: Marek Olšák use MEMBAR instead --- src/gallium/auxiliary/tgsi/tgsi_info.c | 6 ++--- src/gallium/docs/source/tgsi.rst | 30 -- .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 10 src/gallium/drivers/r600/r600_shader.c

[Mesa-dev] [PATCH 4/8] gallium: remove TGSI opcode DP2A

2017-08-19 Thread Marek Olšák
From: Marek Olšák use DP3 instead. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c | 29 src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c| 3 -- src/gallium/auxiliary/nir/tgsi_to_nir.c| 14 -- src/gallium/auxiliary/tgsi/tgsi_exec.c | 29 ---

[Mesa-dev] [PATCH 1/8] gallium: remove TGSI opcodes PUSHA, POPA, SAD, TXQ_LZ

2017-08-19 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/gallivm/lp_bld_tgsi.c| 3 -- src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c| 17 src/gallium/auxiliary/nir/tgsi_to_nir.c| 6 --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 12 -- src/gallium/auxiliary/t

[Mesa-dev] [Bug 97481] mesa-12.0.1 exposes only OpenGL 3.0 on wayland under gnome-shell on Intel HD 520

2017-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97481 --- Comment #3 from Yaroslav Isakov --- Oh, and huge thank you for help! -- You are receiving this mail because: You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop

[Mesa-dev] [Bug 97481] mesa-12.0.1 exposes only OpenGL 3.0 on wayland under gnome-shell on Intel HD 520

2017-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97481 Yaroslav Isakov changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

Re: [Mesa-dev] [PATCH] mesa: only copy requested compressed teximage faces

2017-08-19 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin Will push this out tomorrow unless there are any objections. On Sat, Aug 19, 2017 at 7:59 PM, Christoph Haag wrote: > From: Christoph Haag > > This is analogous to commit 2259b11 which missed the compressed case > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?i

[Mesa-dev] [Bug 102308] segfault in glCompressedTextureSubImage3D

2017-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102308 --- Comment #5 from Christoph Haag --- https://lists.freedesktop.org/archives/mesa-dev/2017-August/166827.html -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___

[Mesa-dev] [PATCH] mesa: only copy requested compressed teximage faces

2017-08-19 Thread Christoph Haag
From: Christoph Haag This is analogous to commit 2259b11 which missed the compressed case Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102308 Signed-off-by: Christoph Haag --- src/mesa/main/teximage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/ma

Re: [Mesa-dev] [PATCH 2/2] i965/bufmgr: s/BO_ALLOC_FOR_RENDER/BO_ALLOC_BUSY/

2017-08-19 Thread Kenneth Graunke
On Saturday, August 19, 2017 3:07:48 PM PDT Jason Ekstrand wrote: > "Alloc for render" is a terrible name for a flag because it means > basically nothing. What the flag really does is allocate a busy BO > which someone theorized at one point in time would be more efficient if > you're planning to

Re: [Mesa-dev] [PATCH 06/27] i965: add initial implementation of on disk shader cache

2017-08-19 Thread Jordan Justen
On 2017-08-19 13:44:23, Emil Velikov wrote: > On 19 August 2017 at 08:44, Jordan Justen wrote: > > > --- a/src/mesa/drivers/dri/i965/Makefile.sources > > +++ b/src/mesa/drivers/dri/i965/Makefile.sources > > @@ -14,6 +14,7 @@ i965_FILES = \ > > brw_cs.h \ > > brw_curbe.c \ > >

Re: [Mesa-dev] [PATCH 1/2] st/omx_tizonia: add --enable-omx-tizonia flag and build files

2017-08-19 Thread Andy Furniss
Ahh, I didn't let it error out so didn't see it listed in the error message. Though I've built tizonia I haven't installed yet because I wanted to remind myself where bellagio is speed/function wise. I am now a bit sidetracked with a couple of issues I found but will try it soon. I did do a ./c

Re: [Mesa-dev] [PATCH 1/2] gallium/docs: improve docs for SAMPLE_POS, SAMPLE_INFO, TXQS, MSAA semantics

2017-08-19 Thread Roland Scheidegger
Am 19.08.2017 um 21:32 schrieb Marek Olšák: > How about we remove all opcodes that are unused? Like: > > SAMPLE_POS > SAMPLE_INFO > SAMPLE > SAMPLE_I > SAMPLE_I_MS > SAMPLE_B > SAMPLE_C > SAMPLE_C_LZ > SAMPLE_D > SAMPLE_L > GATHER4 > SVIEWINFO These are all d3d10 opcodes, and we need them (llvmpip

[Mesa-dev] [PATCH 2/2] i965/bufmgr: s/BO_ALLOC_FOR_RENDER/BO_ALLOC_BUSY/

2017-08-19 Thread Jason Ekstrand
"Alloc for render" is a terrible name for a flag because it means basically nothing. What the flag really does is allocate a busy BO which someone theorized at one point in time would be more efficient if you're planning to immediately render to it. If the flag really means "alloc a busy BO" we s

[Mesa-dev] [PATCH 1/2] i965/tex: Change the flags type on create_for_teximage

2017-08-19 Thread Jason Ekstrand
This matches the actual function declaration. --- src/mesa/drivers/dri/i965/intel_tex.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex.h b/src/mesa/drivers/dri/i965/intel_tex.h index 376f075..beefc4b 100644 --- a/src/mesa/drivers/dri/i965/i

Re: [Mesa-dev] [PATCH 1/2] anv: Add error handling to setup_empty_execbuf().

2017-08-19 Thread Lionel Landwerlin
Both patches are : Reviewed-by: Lionel Landwerlin On 18/08/17 21:52, Francisco Jerez wrote: The anv_execbuf_add_bo() call can actually fail in practice, which should cause the QueueSubmit operation to fail. Reported by Coverity. CID: 1416606: Unchecked return value (CHECKED_RETURN) --- src

Re: [Mesa-dev] Mesa 17.1.7 release candidate

2017-08-19 Thread Ilia Mirkin
On Sat, Aug 19, 2017 at 11:37 AM, Andres Gomez wrote: > nouveau's nv50 has gotten a fix for a problem involving ConstantFolding > with saturation that was visible in Hitman Absolution and, possibly, in > some other games. Also, it has gotten fixes for the srcMask > computation, for TG4, TXF and TX

Re: [Mesa-dev] Mesa 17.1.7 release candidate

2017-08-19 Thread Andres Gomez
On Sat, 2017-08-19 at 21:40 +0100, Emil Velikov wrote: > [Slimming down the CC list] > > Hi Andres, > > On 19 August 2017 at 16:37, Andres Gomez wrote: > > > 4c09f648929fbde25e4be44fa2983c0f3ac2fd11 > > commit 774e77ab64de05d437939110dd11c35a300d47f6 > Seems like the remaining shas are also of

[Mesa-dev] [Bug 102308] segfault in glCompressedTextureSubImage3D

2017-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102308 --- Comment #4 from Ilia Mirkin --- Care to send a proper patch? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 06/27] i965: add initial implementation of on disk shader cache

2017-08-19 Thread Emil Velikov
On 19 August 2017 at 08:44, Jordan Justen wrote: > --- a/src/mesa/drivers/dri/i965/Makefile.sources > +++ b/src/mesa/drivers/dri/i965/Makefile.sources > @@ -14,6 +14,7 @@ i965_FILES = \ > brw_cs.h \ > brw_curbe.c \ > brw_defines.h \ > + brw_disk_cache.cpp \ >

Re: [Mesa-dev] Mesa 17.1.7 release candidate

2017-08-19 Thread Emil Velikov
[Slimming down the CC list] Hi Andres, On 19 August 2017 at 16:37, Andres Gomez wrote: > 4c09f648929fbde25e4be44fa2983c0f3ac2fd11 commit 774e77ab64de05d437939110dd11c35a300d47f6 Seems like the remaining shas are also off. > Author: Emil Velikov > > egl: avoid eglCreatePlatform*Surface{EXT

Re: [Mesa-dev] [v2] intel/blorp: Adjust intra-tile x when faking rgb with red-only

2017-08-19 Thread Jason Ekstrand
Much better. Rb On August 19, 2017 12:42:58 PM Topi Pohjolainen wrote: v2 (Jason): Adjust directly in surf_fake_rgb_with_red() Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101910 CC: Jason Ekstrand CC: Mark Janes CC: mesa-sta...@lists.freedesktop.org Signed-off-by: Topi Pohjo

Re: [Mesa-dev] XDC 2017 : Call for paper

2017-08-19 Thread Rodrigo Vivi
Hi Stephane, I will attend. Please, add me to the list. I just couldn't edit the wiki for some reason... Thanks, Rodrigo On Fri, Aug 18, 2017 at 5:51 PM Stéphane Marchesin < stephane.marche...@gmail.com> wrote: > On Tue, Jun 6, 2017 at 4:19 PM, Martin Peres wrote: > > Hello, > > > > I have the

Re: [Mesa-dev] [PATCH] i965/tex: Don't pass samples to miptree_create_for_teximage

2017-08-19 Thread Pohjolainen, Topi
On Sat, Aug 19, 2017 at 11:07:35AM -0700, Jason Ekstrand wrote: > In 76e2f390f9863a35, when Topi switched num_samples from 0 to 1 for > single-sampled, he accidentally switched the last parameter in the call > to miptree_create_for_teximage from 0 to 1 thinking it was num_samples > when it was actu

[Mesa-dev] [v2] intel/blorp: Adjust intra-tile x when faking rgb with red-only

2017-08-19 Thread Topi Pohjolainen
v2 (Jason): Adjust directly in surf_fake_rgb_with_red() Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101910 CC: Jason Ekstrand CC: Mark Janes CC: mesa-sta...@lists.freedesktop.org Signed-off-by: Topi Pohjolainen --- src/intel/blorp/blorp_blit.c | 1 + 1 file changed, 1 insertion(+)

Re: [Mesa-dev] [PATCH 1/2] gallium/docs: improve docs for SAMPLE_POS, SAMPLE_INFO, TXQS, MSAA semantics

2017-08-19 Thread Marek Olšák
How about we remove all opcodes that are unused? Like: SAMPLE_POS SAMPLE_INFO SAMPLE SAMPLE_I SAMPLE_I_MS SAMPLE_B SAMPLE_C SAMPLE_C_LZ SAMPLE_D SAMPLE_L GATHER4 SVIEWINFO SWITCH CASE DEFAULT ENDSWITCH BREAKC BGNSUB ENDSUB CAL Marek On Tue, Jun 13, 2017 at 4:00 PM, Brian Paul wrote: > On 06/12/

Re: [Mesa-dev] [PATCH 00/18] Gallium blitter optimizations

2017-08-19 Thread Marek Olšák
On Sat, Aug 19, 2017 at 7:24 PM, Gert Wollny wrote: > Am Samstag, den 19.08.2017, 18:35 +0200 schrieb Marek Olšák: >> Can you try the attached patch? > > While if fixes the crash and lets me run glxgears and some other rathe > simple OpenGL programs it completely messes up blender (menu unreadable

Re: [Mesa-dev] [PATCH 1/2] st/omx_tizonia: add --enable-omx-tizonia flag and build files

2017-08-19 Thread Gurkirpal Singh
Hi, The target tizonia is available with gst-omx on current git https://cgit.freedesktop.org/gstreamer/gst-omx/commit/?id=ae14bb362a26bb1b48f7f99c7fc2350e0fa50ffa The option --with-omx-target=tizonia should work. Cheers On Thu, Aug 17, 2017 at 4:39 AM, Andy Furniss wrote: > Thanks, I'll try so

[Mesa-dev] [PATCH] i965/tex: Don't pass samples to miptree_create_for_teximage

2017-08-19 Thread Jason Ekstrand
In 76e2f390f9863a35, when Topi switched num_samples from 0 to 1 for single-sampled, he accidentally switched the last parameter in the call to miptree_create_for_teximage from 0 to 1 thinking it was num_samples when it was actually layout_flags. Switching from 0 to 1 added the MIPTREE_LAYOUT_ACCEL

[Mesa-dev] [Bug 102308] segfault in glCompressedTextureSubImage3D

2017-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102308 --- Comment #3 from Christoph Haag --- Tried it and hifi works with it. Thanks! diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 7bcd734204..e5dc469437 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c

Re: [Mesa-dev] [PATCH 00/18] Gallium blitter optimizations

2017-08-19 Thread Gert Wollny
Am Samstag, den 19.08.2017, 18:35 +0200 schrieb Marek Olšák: > Can you try the attached patch? While if fixes the crash and lets me run glxgears and some other rathe simple OpenGL programs it completely messes up blender (menu unreadable etc) and UE4Editor Window is also flickering.  Best, Gert

[Mesa-dev] [PATCH] radeonsi: remove Constant Engine support

2017-08-19 Thread Marek Olšák
From: Marek Olšák We have come to the conclusion that it doesn't improve performance. --- src/gallium/drivers/radeon/r600_gpu_load.c| 3 - src/gallium/drivers/radeon/r600_pipe_common.c | 2 - src/gallium/drivers/radeon/r600_pipe_common.h | 5 +- src/gallium/drivers/radeon/r600_query.c

[Mesa-dev] [Bug 102308] segfault in glCompressedTextureSubImage3D

2017-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102308 --- Comment #2 from Ilia Mirkin --- No wonder this felt familiar. commit 2259b111003f2e8c55cae42677ec45345fb1b6e3 Author: Ilia Mirkin Date: Thu Aug 27 15:28:24 2015 -0400 mesa: only copy the requested teximage faces Cube maps are s

[Mesa-dev] [Bug 102308] segfault in glCompressedTextureSubImage3D

2017-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102308 --- Comment #1 from Ilia Mirkin --- That seems like a bug... /* Copy in each face. */ for (int i = 0; i < 6; ++i) { That should probably be for (int i = zoffset; i < zoffset + depth; i++) { This feels somehow familiar... either i

Re: [Mesa-dev] [PATCH 00/18] Gallium blitter optimizations

2017-08-19 Thread Marek Olšák
Can you try the attached patch? Thanks, Marek On Sat, Aug 19, 2017 at 4:01 PM, Gert Wollny wrote: > Am Samstag, den 19.08.2017, 12:13 +0200 schrieb Gert Wollny: >> >> I did this and unfortunately it crashes with 744c3e2254 applied. >> Specifically, in >> >>src/gallium/drivers/r600/evergreen_

Re: [Mesa-dev] [PATCH 06/27] i965: add initial implementation of on disk shader cache

2017-08-19 Thread Jason Ekstrand
On August 19, 2017 12:45:09 AM Jordan Justen wrote: From: Timothy Arceri This uses the recently-added disk_cache.c to write out the final linked binary for vertex and fragment shader programs. This is based off the initial implementation done by Carl Worth. [jordan.l.jus...@intel.com: *_cac

[Mesa-dev] [Bug 102308] segfault in glCompressedTextureSubImage3D

2017-08-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102308 Bug ID: 102308 Summary: segfault in glCompressedTextureSubImage3D Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH] intel/blorp: Adjust intra-tile x when faking rgb with red-only

2017-08-19 Thread Pohjolainen, Topi
On Sat, Aug 19, 2017 at 08:37:15AM -0700, Jason Ekstrand wrote: > On August 19, 2017 7:24:55 AM Topi Pohjolainen > wrote: > > >Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101910 > > > >CC: Jason Ekstrand > >CC: Mark Janes > >CC: mesa-sta...@lists.freedesktop.org > > > >Signed-off-by:

[Mesa-dev] Mesa 17.1.7 release candidate

2017-08-19 Thread Andres Gomez
Hello list, The candidate for the Mesa 17.1.7 is now available. Currently we have:  - 33 queued  - 3 nominated (outstanding)  - and 3 rejected patches In the current queue we have: The state tracker received a fix to avoid a crash accessing a null pointer exposed using llvmpipe on Windows. The

Re: [Mesa-dev] [PATCH] intel/blorp: Adjust intra-tile x when faking rgb with red-only

2017-08-19 Thread Jason Ekstrand
On August 19, 2017 7:24:55 AM Topi Pohjolainen wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101910 CC: Jason Ekstrand CC: Mark Janes CC: mesa-sta...@lists.freedesktop.org Signed-off-by: Topi Pohjolainen --- src/intel/blorp/blorp_blit.c | 6 ++ 1 file changed, 6 inser

Re: [Mesa-dev] [PATCH 05/27] i965: add new field for storing program size

2017-08-19 Thread Jason Ekstrand
On August 19, 2017 12:46:02 AM Jordan Justen wrote: From: Carl Worth This will be used by the on disk shader cache. Signed-off-by: Timothy Arceri [jordan.l.jus...@intel.com: Only add to brw_stage_prog_data] Signed-off-by: Jordan Justen --- src/intel/compiler/brw_compiler.h | 2 ++ src/m

[Mesa-dev] [PATCH] intel/blorp: Adjust intra-tile x when faking rgb with red-only

2017-08-19 Thread Topi Pohjolainen
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101910 CC: Jason Ekstrand CC: Mark Janes CC: mesa-sta...@lists.freedesktop.org Signed-off-by: Topi Pohjolainen --- src/intel/blorp/blorp_blit.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/intel/blorp/blorp_blit.c b/src/i

Re: [Mesa-dev] [PATCH 00/18] Gallium blitter optimizations

2017-08-19 Thread Gert Wollny
Am Samstag, den 19.08.2017, 12:13 +0200 schrieb Gert Wollny: > > I did this and unfortunately it crashes with 744c3e2254 applied. > Specifically, in   > >    src/gallium/drivers/r600/evergreen_state.c2302:  >    evergreen_emit_vertex_fetch_shader  > > de-referencing shader fails because stat

Re: [Mesa-dev] [PATCH 1/2] i965: Issue performance warnings when growing the program cache

2017-08-19 Thread Chris Wilson
Quoting Kenneth Graunke (2017-08-19 08:26:58) > This involves a bunch of unnecessary copying, a batch flush, and > state re-emission. > --- > src/mesa/drivers/dri/i965/brw_program_cache.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_program_cache.c > b

Re: [Mesa-dev] [PATCH 00/18] Gallium blitter optimizations

2017-08-19 Thread Gert Wollny
Am Freitag, den 18.08.2017, 18:25 +0200 schrieb Marek Olšák: > > Sure. The changes are here: > https://cgit.freedesktop.org/~mareko/mesa/log/?h=blitter-optz > > If somebody wants to test it on r600g, that would be appreciated too. > > I did this and unfortunately it crashes with 744c3e2254 appl

[Mesa-dev] [PATCH V2 0/2] mesa: Modify drirc options

2017-08-19 Thread Quentin Liu
This series of patches changes drirc's semantically boolean options, options that are enum type options but which in essence are boolean options e.g. pp_shalde, into actual boolean options. Backward compatibility is maintained by relaxing xmlconfig parser so that xml files before this change can s

[Mesa-dev] [PATCH V2 1/2] mesa: Fix backward compatibility for XML parser

2017-08-19 Thread QuRyu
From: Quentin Liu If the type of drirc options are changed, the parser will not be able to recognize xml files that had been present before the change. To achieve backward compatibility, the parser is relaxed to recognize boolean type options with enum values. --- src/util/xmlconfig.c | 17

[Mesa-dev] [PATCH V2 0/2] mesa: Modify drirc options

2017-08-19 Thread QuRyu
From: Quentin Liu This serie of patches changes drirc's semanticaclly boolean options, options that are enum type options but which in essence are boolean options e.g. pp_shalde, into actual boolean optioinns. Backwawrd compatbility is maintained by relaxinig xmlconfig parser so that xml file

[Mesa-dev] [PATCH V2 2/2] mesa: Modify drirc option types

2017-08-19 Thread QuRyu
From: Quentin Liu The type and default values of certain drirc options are changed, namely, those semantically boolean options such as pp_celshade. --- src/gallium/auxiliary/pipe-loader/driinfo_gallium.h | 8 src/util/xmlpool/t_options.h| 8 2 files chan

[Mesa-dev] [PATCH 19/27] i965: add cache fallback support

2017-08-19 Thread Jordan Justen
From: Timothy Arceri This is fairly simple, if we have no IR we compile the fallback shaders then copy the other fallback data such as attibute bindings to a temp shader program struct, then we link the program and clean up the mess. The IR will be attached to the existing gl_program. [jordan.l.

[Mesa-dev] [PATCH 20/27] i965: add support for caching clip planes

2017-08-19 Thread Jordan Justen
From: Timothy Arceri --- src/mesa/drivers/dri/i965/brw_disk_cache.c | 45 -- 1 file changed, 42 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_disk_cache.c b/src/mesa/drivers/dri/i965/brw_disk_cache.c index 0385856409..e8b4f2f5a9 100644 ---

[Mesa-dev] [PATCH 23/27] i965: Initialize sha1 hash of dri config options

2017-08-19 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_context.c | 4 src/mesa/drivers/dri/i965/brw_context.h | 1 + 2 files changed, 5 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index d97a24fbf8..3904bc708b 100644 -

[Mesa-dev] [PATCH 27/27] i965/brw_disk_cache: Support INTEL_SHADER_CACHE_TIMESTAMP debug override

2017-08-19 Thread Jordan Justen
When making tweaks to the driver that should not affect the code generation, the INTEL_SHADER_CACHE_TIMESTAMP can be set to override the shader disk cache to use a consistent timestamp. This will allow the shader cache entries to remain valid across driver builds, but it should be used with cautio

[Mesa-dev] [PATCH 22/27] i965: Don't link when the program was found in the disk cache

2017-08-19 Thread Jordan Justen
Signed-off-by: Jordan Justen Cc: Timothy Arceri --- src/mesa/drivers/dri/i965/brw_link.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_link.cpp b/src/mesa/drivers/dri/i965/brw_link.cpp index 8f46728e74..8d3e79ee49 100644 --- a/src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH 25/27] glsl/shader_cache: Save fs (BlendSupport) metadata

2017-08-19 Thread Jordan Justen
Fixes many GL 4.5 CTS blend tests, such as: * GL45-CTS.blend_equation_advanced.extension_directive_enable * GL45-CTS.blend_equation_advanced.extension_directive_warn * GL45-CTS.blend_equation_advanced.blend_all.GL_MULTIPLY_KHR_all_qualifier * GL45-CTS.blend_equation_advanced.blend_specific.GL_COLO

[Mesa-dev] [PATCH 26/27] i965: Initialize disk shader cache when INTEL_SHADER_CACHE env var is set

2017-08-19 Thread Jordan Justen
We use the build-id of i965_dri.so for the timestamp, and the name from i965_pci_ids.h for the device name. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_context.c| 2 ++ src/mesa/drivers/dri/i965/brw_disk_cache.c | 45 ++ src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH 11/27] mesa/glsl: add api_enabled flag to gl_transform_feedback_info

2017-08-19 Thread Jordan Justen
From: Timothy Arceri This will be used to disable the shader cache when xfb is enabled via the api as we don't currently allow for it when generating the sha for the shader. --- src/compiler/glsl/link_varyings.cpp | 5 - src/mesa/main/mtypes.h | 3 +++ 2 files changed, 7 inserti

[Mesa-dev] [PATCH 02/27] glsl/mesa: make a copy of attribute bindings in case of cache fallback

2017-08-19 Thread Jordan Justen
From: Timothy Arceri If the shader cache falls back to doing a compile and link we need the original attribute bindings as they could have changed after the program was first linked. [jordan.l.jus...@intel.com: Use string_to_uint_map::iterate method] Signed-off-by: Jordan Justen --- src/compil

[Mesa-dev] [PATCH 17/27] i965: don't recreate program struct on cache fallback

2017-08-19 Thread Jordan Justen
From: Timothy Arceri We already have the struct and paramlist we don't want to recreate them as this is unnecessary and would mean we would need to remap anything using the old paramlist to the addresses of the new one. --- src/compiler/glsl/linker.cpp | 13 + src/mesa/driv

[Mesa-dev] [PATCH 24/27] glsl: Assign atomic counter resources on shader compile fall back path

2017-08-19 Thread Jordan Justen
Signed-off-by: Jordan Justen Cc: Timothy Arceri --- src/compiler/glsl/linker.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index 306051f1f0..671c38e8e1 100644 --- a/src/compiler/glsl/linker.cpp +++ b/src/compil

[Mesa-dev] [PATCH 07/27] i965: Add shader cache support for vertex and fragment stages

2017-08-19 Thread Jordan Justen
From: Timothy Arceri This enables the cache on vertex and fragment shaders only. [jordan.l.jus...@intel.com: reword subject] [jordan.l.jus...@intel.com: *_cached_program => brw_disk_cache_*_program] Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_state_upload.c | 2 ++ src/mesa

[Mesa-dev] [PATCH 21/27] i965: handle incompatiable binaries in shader-cache

2017-08-19 Thread Jordan Justen
From: Timothy Arceri Remove incompatiable binaries of a program before attempting to store a new one. A previous commit already handles deleting an incompatiable binary for shader variants this handles the case for an initial shader compile. Without this a variant would delete the binary then fa

[Mesa-dev] [PATCH 12/27] i965: add support for cached shaders with xfb qualifiers

2017-08-19 Thread Jordan Justen
From: Timothy Arceri For now this disables the shader cache when transform feedback is enabled via the GL API as we don't currently allow for it when generating the sha for the shader. --- src/mesa/drivers/dri/i965/brw_disk_cache.c | 8 1 file changed, 8 insertions(+) diff --git a/src/

[Mesa-dev] [PATCH 16/27] i965: don't rebuild param list after cache miss

2017-08-19 Thread Jordan Justen
From: Timothy Arceri Previously we ended up with the same param list but in a different location, which will mess up the pointers stored in the new cache object if all stages were not fully rebuilt e.g. after a fragment program cache miss. This also stops the list from being leaked on fallback.

[Mesa-dev] [PATCH 06/27] i965: add initial implementation of on disk shader cache

2017-08-19 Thread Jordan Justen
From: Timothy Arceri This uses the recently-added disk_cache.c to write out the final linked binary for vertex and fragment shader programs. This is based off the initial implementation done by Carl Worth. [jordan.l.jus...@intel.com: *_cached_program => brw_disk_cache_*_program] [jordan.l.jus..

[Mesa-dev] [PATCH 05/27] i965: add new field for storing program size

2017-08-19 Thread Jordan Justen
From: Carl Worth This will be used by the on disk shader cache. Signed-off-by: Timothy Arceri [jordan.l.jus...@intel.com: Only add to brw_stage_prog_data] Signed-off-by: Jordan Justen --- src/intel/compiler/brw_compiler.h | 2 ++ src/mesa/drivers/dri/i965/brw_cs.c | 2 ++ src/mesa/drivers/

[Mesa-dev] [PATCH 10/27] i965: Add shader cache support for compute

2017-08-19 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_cs.c | 25 --- src/mesa/drivers/dri/i965/brw_cs.h | 3 +++ src/mesa/drivers/dri/i965/brw_disk_cache.c | 36 +++- src/mesa/drivers/dri/i965/brw_state.h| 3 ++- src

[Mesa-dev] [PATCH 14/27] i965: add shader cache support for pull param pointers

2017-08-19 Thread Jordan Justen
From: Timothy Arceri --- src/mesa/drivers/dri/i965/brw_disk_cache.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_disk_cache.c b/src/mesa/drivers/dri/i965/brw_disk_cache.c index 4a6f3f340e..793f946af2 100644 --- a

[Mesa-dev] [PATCH 09/27] i965: add shader cache support for tess stages

2017-08-19 Thread Jordan Justen
From: Timothy Arceri [jordan.l.jus...@intel.com: *_cached_program => brw_disk_cache_*_program] Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_disk_cache.c | 49 ++ src/mesa/drivers/dri/i965/brw_tcs.c| 24 ++- src/mesa/drivers/dri/i

[Mesa-dev] [PATCH 18/27] main: Add _mesa_build_fallback_shader_program

2017-08-19 Thread Jordan Justen
This routine will handle fallback shader compilation. Based on Tim's "i965: add cache fallback support" patch. Tim's commit message was: "This is fairly simple, if we have no IR we compile the fallback shaders then copy the other fallback data such as attibute bindings to a temp shader pr

[Mesa-dev] [PATCH 04/27] glsl: make a copy of the shader source for use with cache fallback

2017-08-19 Thread Jordan Justen
From: Timothy Arceri A number of things can happen that change the shader source after it is compiled or linked. For example: - Source changed after it is first compiled - Source changed after linking - Shader detached after linking In order to be able to fallback to a full rebuild on a cache m

[Mesa-dev] [PATCH 08/27] i965: add shader cache support for geometry shaders

2017-08-19 Thread Jordan Justen
From: Timothy Arceri [jordan.l.jus...@intel.com: *_cached_program => brw_disk_cache_*_program] Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_disk_cache.c | 25 + src/mesa/drivers/dri/i965/brw_gs.c | 23 +++ 2 files changed, 40

[Mesa-dev] [PATCH 01/27] i965: Don't rely on nir for uses_texture_gather on gen <= 7

2017-08-19 Thread Jordan Justen
When a program is restored from the shader cache, prog->nir will be NULL, but prog->info will be restored. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_wm.c | 4 ++-- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 12 ++-- 2 files changed, 8 insertion

[Mesa-dev] [PATCH 13/27] i965: add image param shader cache support

2017-08-19 Thread Jordan Justen
From: Timothy Arceri --- src/mesa/drivers/dri/i965/brw_disk_cache.c | 31 +- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_disk_cache.c b/src/mesa/drivers/dri/i965/brw_disk_cache.c index 1156fc0b8f..4a6f3f340e 100644 ---

[Mesa-dev] [PATCH 03/27] glsl/mesa: make a copy of FragData bindings in case of cache fallback

2017-08-19 Thread Jordan Justen
From: Timothy Arceri If the shader cache falls back to doing a compile and link we need the original FragData bindings as they could have changed after the program was first linked. [jordan.l.jus...@intel.com: Use string_to_uint_map::iterate method] Signed-off-by: Jordan Justen --- src/compile

[Mesa-dev] [PATCH 15/27] i965: don't precompile or rebuild resource list on cache fallback

2017-08-19 Thread Jordan Justen
From: Timothy Arceri --- src/mesa/drivers/dri/i965/brw_link.cpp | 22 -- src/mesa/main/shaderobj.c | 2 +- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_link.cpp b/src/mesa/drivers/dri/i965/brw_link.cpp index e91

[Mesa-dev] [PATCH 00/27] i965 disk shader cache

2017-08-19 Thread Jordan Justen
git://people.freedesktop.org/~jljusten/mesa i965-shader-cache-v1 The series adds support for a disk shader cache for i965, but it does not enable it by default. To enable the i965 shader cache you need to set the environment variable INTEL_SHADER_CACHE=1. I don't see any regressions on Skylake wi

[Mesa-dev] [PATCH 1/2] i965: Issue performance warnings when growing the program cache

2017-08-19 Thread Kenneth Graunke
This involves a bunch of unnecessary copying, a batch flush, and state re-emission. --- src/mesa/drivers/dri/i965/brw_program_cache.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_program_cache.c b/src/mesa/drivers/dri/i965/brw_program_cache.c index 4dcfd5234

[Mesa-dev] [PATCH 2/2] i965: Bump the initial program cache size from 4kB to 16kB.

2017-08-19 Thread Kenneth Graunke
Our initial size of 4kB is way too small to do anything useful, so we end up growing it at least a few times. We may as well start it larger. Some data points: - Dinoshade (from Mesa Demos): hit 8kB. - Chromium 60: hit 16kB after browsing a few things in Google Docs. - GFXBench4 TRex/Manhattan 3