https://bugs.freedesktop.org/show_bug.cgi?id=101930
Michel Dänzer changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
https://bugs.freedesktop.org/show_bug.cgi?id=101941
Bug ID: 101941
Summary: Getting different output depending on attribute
declaration order
Product: Mesa
Version: git
Hardware: All
OS: Linux (All)
From: Dave Airlie
On SI this was causing a hang in
dEQP-VK.pipeline.render_to_image.core.2d_array.mipmap.r16g16_sint_s8_uint
This was due to not handling the tile mode index for depth like
I fixed previously for new GPUs.
Fixes: 01d0c5a9 (radv: fix stencil regression since new addrlib import)
S
On 07/26/2017 08:14 PM, Michel Dänzer wrote:
From: Michel Dänzer
Fixes a drawable leak.
Fixes: bbc29393d3be ("st/mesa: create framebuffer iface hash table per
st manager")
Tested-by: Nick Sarnie
Signed-off-by: Michel Dänzer
---
src/mesa/state_tracker/st_manager.c | 2
On Wed, Jul 26, 2017 at 5:26 PM, Timothy Arceri
wrote:
> On 27/07/17 04:53, Jason Ekstrand wrote:
>
>> On July 26, 2017 8:48:18 AM Samuel Pitoiset
>> wrote:
>>
>> Hi guys,
>>>
>>> I didn't review the radeonsi and radv patches, but I have sent comments
>>> on other parts.
>>>
>>> More generally:
https://bugs.freedesktop.org/show_bug.cgi?id=101930
--- Comment #4 from Michel Dänzer ---
https://patchwork.freedesktop.org/patch/169225/ fixes it for Nick.
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug._
From: Michel Dänzer
Fixes a drawable leak.
Fixes: bbc29393d3be ("st/mesa: create framebuffer iface hash table per
st manager")
Tested-by: Nick Sarnie
Signed-off-by: Michel Dänzer
---
src/mesa/state_tracker/st_manager.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
https://bugs.freedesktop.org/show_bug.cgi?id=101930
--- Comment #3 from Nick Sarnie ---
Hi all,
I also have this issue, and I have bisected it to the commit Emil mentions, but
I can confirm that the suggested fix doesn't work.
Thanks,
Sarnex
--
You are receiving this mail because:
You are the
On 27/07/17 01:48, Samuel Pitoiset wrote:
Hi guys,
I didn't review the radeonsi and radv patches, but I have sent comments
on other parts.
More generally:
- I wonder if some intermediate patches can break Mesa, would be nice to
avoid that (especially for bisecting) Can you double check?
E
On 26/07/17 09:15 PM, Nicolai Hähnle wrote:
> On 26.07.2017 08:29, Michel Dänzer wrote:
>> On 25/07/17 05:28 PM, Nicolai Hähnle wrote:
>>> On 22.07.2017 14:00, Daniel Stone wrote:
Given that, I'm fairly inclined to punt those until we have the grand
glorious allocator, rather than tr
On 27/07/17 11:00, Timothy Arceri wrote:
On 27/07/17 01:34, Samuel Pitoiset wrote:
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
From: Andres Rodriguez
These are used by EXT_external_objects to present UUIDs for the device
and the driver.
Signed-off-by: Andres Rodriguez
Reviewed-by: T
On 27/07/17 01:34, Samuel Pitoiset wrote:
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
From: Andres Rodriguez
These are used by EXT_external_objects to present UUIDs for the device
and the driver.
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/get.c | 1
Reviewed-by: Bruce Cherniak
> On Jul 26, 2017, at 4:38 PM, Tim Rowley wrote:
>
> gcc prior to 4.9 didn't implement , causing a startup crash
> in the swr knob parameter reading code.
>
> CC:
> ---
> .../swr/rasterizer/codegen/templates/gen_knobs.cpp | 21 +
> 1 file chang
On 27/07/17 01:22, Samuel Pitoiset wrote
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
Include no_error variants as well.
v2 (Timothy Arceri):
- reduced code churn by squashing some changes into
previous commits
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa
On 27/07/17 04:53, Jason Ekstrand wrote:
On July 26, 2017 8:48:18 AM Samuel Pitoiset
wrote:
Hi guys,
I didn't review the radeonsi and radv patches, but I have sent comments
on other parts.
More generally:
- I wonder if some intermediate patches can break Mesa, would be nice to
avoid that (
On 27/07/17 01:11, Samuel Pitoiset wrote:
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
From: Andres Rodriguez
V2 (Timothy Arceri):
- formating fixes
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/dd.h | 9 +++
src/mesa/main/externalobject
On 27/07/17 00:39, Samuel Pitoiset wrote:
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
From: Andres Rodriguez
V2 (Timothy Arceri):
- fix copy and paste error with error message
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/externalobjects.c | 52
+++
On 27/07/17 00:36, Samuel Pitoiset wrote:
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
From: Andres Rodriguez
Used by EXT_external_objects and EXT_external_objects_fd
V2 (Timothy Arceri):
- Throw GL_OUT_OF_MEMORY error if CreateMemoryObjectsEXT()
fails.
- C99 tidy ups
- remove voi
Cc: Samuel Pitoiset
---
src/mesa/main/bufferobj.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
index 720569d..2660e13 100644
--- a/src/mesa/main/bufferobj.c
+++ b/src/mesa/main/bufferobj.c
@@ -443,11 +443,10 @@ co
The shader that is used to copy vertex data out of the vs/gs shaders to
the user-specified buffer (streamout or SO shader) was not using the
correct offsets.
Adjust the offsets that are used just for the SO shader:
- Make sure that position is handled in the same special way
as in the vs/gs shad
gcc prior to 4.9 didn't implement , causing a startup crash
in the swr knob parameter reading code.
CC:
---
.../swr/rasterizer/codegen/templates/gen_knobs.cpp | 21 +
1 file changed, 21 insertions(+)
diff --git a/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_knob
On 27 July 2017 at 00:06, Nicolai Hähnle wrote:
> On 26.07.2017 05:42, Dave Airlie wrote:
>>
>> From: Dave Airlie
>>
>> This seems like a workaround, but we don't see the bug on CIK/VI.
>>
>> On SI with the dEQP-VK.memory.pipeline_barrier.host_read_transfer_dst.*
>> tests, when one tests complete
https://bugs.freedesktop.org/show_bug.cgi?id=77449
Bug 77449 depends on bug 98239, which changed state.
Bug 98239 Summary: saints row 3: performance is limited by flushes
https://bugs.freedesktop.org/show_bug.cgi?id=98239
What|Removed |Added
Patches 1 & 2 are :
Reviewed-by: Lionel Landwerlin
I'm not knowledgeable enough for the last one :(
On 26/07/17 00:34, Kenneth Graunke wrote:
I want to use it in brw_clear.c.
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 10 +-
src/mesa/drivers/dri/i965/intel_mipmap_tree.h |
On July 25, 2017 8:16:42 PM "Mun, Gwan-gyeong" wrote:
Hi Jason,
You are right, as you commented, compilers can eliminate these redundancies
easy.
However I think we don't need to generate redundant codes.
The approach we generally take with generators like this is to not really
care too much
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_blorp.c| 2 +-
src/mesa/drivers/dri/i965/brw_context.c | 1 -
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 13 +++
src/mesa/drivers/dri/i965/intel_mipmap_tree.c| 49 +++-
src
Imported miptrees represent single images in buffer objects that
themselves may contain multiple images (full mipmaps or arrays).
In such case there may be an offset which consists of pointer
to a tile and x,y coordinates giving the start position within that
tile.
Until now callers got only the i
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 54 ++--
src/mesa/drivers/dri/i965/intel_fbo.h| 14 +++---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c| 28 ++--
src/mesa/drivers/dri/i965/intel_mipmap_tree.h|
Image offset is really a triple: aligned byte offset, intra-tile
x and intra-tile y. Taking intra-tile offsets into account in the
caller side of emit_miptree_blit() and then applying tile-aligned
byte offset in emit_miptree_blit() is confusing. Now both are
handled in single location: get_blit_int
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_misc_state.c| 20 +++---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 38 +++
src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 4 ---
3 files changed, 19 insertions(+), 43 deletions(-)
diff -
Signed-off-by: Topi Pohjolainen
---
src/intel/blorp/blorp_blit.c | 19 --
src/intel/isl/isl.c| 44 +++
src/intel/isl/isl.h| 29 +++--
src/mesa/drivers/dri/i965/intel_blit.c | 47 +
Offsets to tiled images consist of two parts: tile offset and
intra-tile x,y coordinates giving the start position within
the tile.
Until now these have been split into different parts of
miptree: intel_mipmap_tree::offset giving the tile offset and
intel_mipmap_tree::level[0].level_x/y giving the
https://bugs.freedesktop.org/show_bug.cgi?id=101933
--- Comment #1 from Martin Peres ---
Indeed, we stumbled on this yesterday but got distracted with something else.
Thanks for reporting the issue Dylan!
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA
On July 26, 2017 8:48:18 AM Samuel Pitoiset wrote:
Hi guys,
I didn't review the radeonsi and radv patches, but I have sent comments
on other parts.
More generally:
- I wonder if some intermediate patches can break Mesa, would be nice to
avoid that (especially for bisecting) Can you double ch
So that means Reviewed-and-tested-by: Zhang, Boyuan ?
Christian.
Am 26.07.2017 um 20:29 schrieb Zhang, Boyuan:
The code looks good to me. I also did a few local vaapi-enc tests and confirmed
that patch works fine.
Regards,
Boyuan
-Original Message-
From: Liu, Leo
Sent: July-26-17 12:
The code looks good to me. I also did a few local vaapi-enc tests and confirmed
that patch works fine.
Regards,
Boyuan
-Original Message-
From: Liu, Leo
Sent: July-26-17 12:01 PM
To: Andy Furniss; Koenig, Christian; Julien Isorce;
mesa-dev@lists.freedesktop.org; Zhang, Boyuan
Subject:
On 26.07.2017 19:42, Marek Olšák wrote:
On Wed, Jul 26, 2017 at 7:05 PM, Alex Deucher wrote:
On Wed, Jul 26, 2017 at 8:15 AM, Nicolai Hähnle wrote:
On 26.07.2017 08:29, Michel Dänzer wrote:
On 25/07/17 05:28 PM, Nicolai Hähnle wrote:
On 22.07.2017 14:00, Daniel Stone wrote:
I don't hav
https://bugs.freedesktop.org/show_bug.cgi?id=101933
Bug ID: 101933
Summary: autotools: wayland-protocols used even if not found
Product: Mesa
Version: git
Hardware: Other
OS: All
Status: NEW
Severity: norm
On Wed, Jul 26, 2017 at 8:15 AM, Nicolai Hähnle wrote:
> On 26.07.2017 08:29, Michel Dänzer wrote:
>>
>> On 25/07/17 05:28 PM, Nicolai Hähnle wrote:
>>>
>>> On 22.07.2017 14:00, Daniel Stone wrote:
I don't have any great solution off the top of my head, but I'd be
inclined to b
https://bugs.freedesktop.org/show_bug.cgi?id=101930
--- Comment #2 from network...@rkmail.ru ---
(In reply to Emil Velikov from comment #1)
> There was a leak introduced with bbc29393d3beaf6344c7188547b4ff61b63946ae
> which was be resolved by 914f11e75b8ebe8a0faab76ce25fe185ab580eee.
>
> Can you
On 25 July 2017 at 16:39, Marek Olšák wrote:
> From: Marek Olšák
>
> This fixes the black Feral launcher window.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101867
Marek, as you get to push this/similar patch please don't forget the
stable/Fixes tag.
The "offending" commit did lan
On Wed, Jul 26, 2017 at 4:00 PM, Nicolai Hähnle wrote:
> On 25.07.2017 17:39, Marek Olšák wrote:
>>
>> From: Marek Olšák
>>
>> This fixes the black Feral launcher window.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101867
>> ---
>> src/mesa/state_tracker/st_manager.c | 6 ++
On 07/25/2017 06:04 PM, Andy Furniss wrote:
Christian König wrote:
Leo and Boyuan can you take a quick look as well? On first glance
looks totally sane to me.
This reminds me .
I don't know what's special about my setup, but I haven't been able to
use gst + vce properly since March.
https://bugs.freedesktop.org/show_bug.cgi?id=101930
--- Comment #1 from Emil Velikov ---
There was a leak introduced with bbc29393d3beaf6344c7188547b4ff61b63946ae which
was be resolved by 914f11e75b8ebe8a0faab76ce25fe185ab580eee.
Can you give that a try?
--
You are receiving this mail because:
On 25.07.2017 18:51, Samuel Pitoiset wrote:
This should probably go to stable too.
It's not strictly a bug fix, but I guess it's small enough for 17.2.
Reviewed-by: Nicolai Hähnle
Reviewed-by: Samuel Pitoiset
On 07/25/2017 05:36 PM, Marek Olšák wrote:
From: Marek Olšák
---
src/mesa/
Hi guys,
I didn't review the radeonsi and radv patches, but I have sent comments
on other parts.
More generally:
- I wonder if some intermediate patches can break Mesa, would be nice to
avoid that (especially for bisecting) Can you double check?
- I don't see any piglit tests... or did I m
https://bugs.freedesktop.org/show_bug.cgi?id=101930
Bug ID: 101930
Summary: High memory usage in KDE
Product: Mesa
Version: git
Hardware: Other
OS: All
Status: NEW
Severity: normal
Priority: medi
Reviewed-by: Samuel Pitoiset
On 07/26/2017 01:47 PM, Timothy Arceri wrote:
From: Andres Rodriguez
These are just basic implementations.
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/formatquery.c | 17 +
src/mesa/main/mtypes.h | 3 ++
Reviewed-by: Samuel Pitoiset
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
From: Andres Rodriguez
v2: respective changes for new gallium interface
v3: fix UUID size asserts
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/dd.h | 15 ++
Trace needs to be updated as well.
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
From: Andres Rodriguez
v2: remove unnecessary returns
Signed-off-by: Andres Rodriguez
Reviewed-by: Marek Olšák
---
src/gallium/drivers/ddebug/dd_screen.c | 17 +
src/gallium/include/pipe/p_de
On Tue, Jul 25, 2017 at 10:16 PM, Chih-Wei Huang
wrote:
> 2017-07-26 1:24 GMT+08:00 Rob Herring :
>> On Tue, Jul 25, 2017 at 10:15 AM, Emil Velikov
>> wrote:
>>> On 25 July 2017 at 03:46, Chih-Wei Huang wrote:
On Tue 11 Jul 2017, Rob Herring wrote:
>> From: Marek Olšák
>>
>> A
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
From: Andres Rodriguez
These are used by EXT_external_objects to present UUIDs for the device
and the driver.
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/get.c | 177 ++
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
From: Andres Rodriguez
v2: use PIPE_CAP_MEMOBJ to guard the extension
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/extensions_table.h | 2 ++
src/mesa/main/mtypes.h | 2 ++
src/mesa/sta
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
From: Andres Rodriguez
This can be used to guard support for EXT_memory_object and related
extensions.
v2: update gallium docs
Signed-off-by: Andres Rodriguez
Reviewed-by: Marek Olšák
---
src/gallium/docs/source/screen.rst | 1
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
Include no_error variants as well.
v2 (Timothy Arceri):
- reduced code churn by squashing some changes into
previous commits
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/bufferobj.c | 62 +
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
From: Andres Rodriguez
Use a memory object instead of user memory.
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/dd.h | 12 +
src/mesa/state_tracker/st_cb_bufferobjects.c | 66 +++
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
From: Andres Rodriguez
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/externalobjects.c | 52
src/mesa/main/teximage.c| 75 +
src/mes
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
From: Andres Rodriguez
V2 (Timothy Arceri):
- formating fixes
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/dd.h | 9 +++
src/mesa/main/externalobjects.c | 129
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
From: Dave Airlie
v2: pass dedicated flag
Signed-off-by: Andres Rodriguez
Reviewed-by: Marek Olšák
---
src/mesa/Makefile.sources| 2 +
src/mesa/state_tracker/st_cb_memoryobjects.c | 66
src/
Trace needs to be updated as well.
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
From: Dave Airlie
v2: fix comment regarding fd ownership, define pipe_memory_object
v3: remove stray return
Reviewed-by: Marek Olšák
---
src/gallium/drivers/ddebug/dd_screen.c | 40
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
From: Andres Rodriguez
V2 (Timothy Arceri):
- fix copy and paste error with error message
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/externalobjects.c | 52 -
src/m
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
From: Andres Rodriguez
Used by EXT_external_objects and EXT_external_objects_fd
V2 (Timothy Arceri):
- Throw GL_OUT_OF_MEMORY error if CreateMemoryObjectsEXT()
fails.
- C99 tidy ups
- remove void cast (Constantine Kharlamov)
Signed-off
Acked-by: Samuel Pitoiset
On 07/26/2017 01:46 PM, Timothy Arceri wrote:
From: Andres Rodriguez
Includes implementation stubs.
Signed-off-by: Andres Rodriguez
Acked-by: Timothy Arceri
---
src/mapi/glapi/gen/EXT_external_objects.xml| 234 ++
src/mapi/glapi/gen/EXT_
Using VRAM address as bindless handles is not a good idea because
we have to use LLVMIntToPTr and the LLVM CSE pass can't optimize
because it has no information about the pointer.
Instead, use slots indexes like the existing descriptors. Note
that we use fixed 16-dword slots for both samplers and
Currently, when the array is full it is resized but it can grow
over and over because we don't try to re-use descriptor slots.
The idea is to maintain two simple lists which keep track of
which slots is used and which ones have been deleted. When the
array is resized, previously deleted slots can
A new pair of user SGPR is needed for loading the bindless
descriptors from shaders. Because the descriptors are global for
all stages, there is no need to add separate indices for GFX9.
v2: - fix declaring new bindless parameter
Signed-off-by: Samuel Pitoiset
---
src/gallium/drivers/radeonsi/s
Looks like it's useless to initialize that field when CE is
unused. This will also allow to declare more than 64 elements
for the array of bindless descriptors.
Signed-off-by: Samuel Pitoiset
---
src/gallium/drivers/radeonsi/si_descriptors.c | 7 ---
1 file changed, 4 insertions(+), 3 deleti
The number of bindless descriptors is dynamic and we definitely
have to support more than 256 slots.
Signed-off-by: Samuel Pitoiset
---
src/gallium/drivers/radeonsi/si_state.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_state.h
To share common code between rw buffers and bindless descriptors.
Signed-off-by: Samuel Pitoiset
---
src/gallium/drivers/radeonsi/si_descriptors.c | 57 +++
1 file changed, 31 insertions(+), 26 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c
b/sr
On 26.07.2017 05:42, Dave Airlie wrote:
From: Dave Airlie
This seems like a workaround, but we don't see the bug on CIK/VI.
On SI with the dEQP-VK.memory.pipeline_barrier.host_read_transfer_dst.*
tests, when one tests complete, the first flush at the start of the next
test causes a VM fault as
On 25.07.2017 17:39, Marek Olšák wrote:
From: Marek Olšák
This fixes the black Feral launcher window.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101867
---
src/mesa/state_tracker/st_manager.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/mesa/state_tracker/st_man
On 25.07.2017 18:51, Samuel Pitoiset wrote:
This should probably go to stable too.
It's not technically a bug, but I suppose it's fine.
Either way, the patch is
Reviewed-by: Nicolai Hähnle
Reviewed-by: Samuel Pitoiset
On 07/25/2017 05:36 PM, Marek Olšák wrote:
From: Marek Olšák
---
Both patches:
Reviewed-by: Nicolai Hähnle
On 25.07.2017 18:34, Marek Olšák wrote:
This will also go to stable.
Marek
On Tue, Jul 25, 2017 at 5:36 PM, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_pipe.c | 2 +-
src/gallium/drivers/radeonsi/si_pipe.h | 9
On 25.07.2017 18:30, Marek Olšák wrote:
From: Marek Olšák
Cc: 17.2
---
src/mesa/state_tracker/st_manager.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/state_tracker/st_manager.c
b/src/mesa/state_tracker/st_manager.c
index ede5439..78093ac 100644
--- a/src/m
Thanks for the fix, it is better than mine. :-)
Tested-by: Samuel Pitoiset
On 07/26/2017 03:03 PM, Marek Olšák wrote:
From: Marek Olšák
This fixes corruption with bindless textures in Dawn Of War 3.
The do_update_surf_dirtiness mechanism was complicated and dirty_level_mask
was only updated
From: Marek Olšák
This fixes corruption with bindless textures in Dawn Of War 3.
The do_update_surf_dirtiness mechanism was complicated and dirty_level_mask
was only updated after the first draw call. The problem is bindless textures
are checked for decompression every draw call and we would onl
Reviewed-by: Marek Olšák
Marek
On Wed, Jul 26, 2017 at 1:56 PM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> Avoids an unnecessary move introduce by "radeonsi/gfx9: always wrap GS
> and TCS in an if-block (v2)"
> ---
> src/gallium/drivers/radeonsi/si_shader.c | 18 +-
> 1
Reviewed-by: Marek Olšák
Marek
On Wed, Jul 26, 2017 at 1:56 PM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> With merged ESGS shaders, the GS part of a wave may be empty, and the
> hardware gets confused if any GS messages are sent from that wave. Since
> S_SENDMSG is executed even when EX
On 26.07.2017 08:29, Michel Dänzer wrote:
On 25/07/17 05:28 PM, Nicolai Hähnle wrote:
On 22.07.2017 14:00, Daniel Stone wrote:
I don't have any great solution off the top of my head, but I'd be
inclined to bundle stride in with placement. TTBOMK (from having
looked at radv), buffers shared cro
On Wed, Jul 26, 2017 at 8:29 AM, Michel Dänzer wrote:
> On 25/07/17 05:28 PM, Nicolai Hähnle wrote:
>> On 22.07.2017 14:00, Daniel Stone wrote:
>>>
>>> I don't have any great solution off the top of my head, but I'd be
>>> inclined to bundle stride in with placement. TTBOMK (from having
>>> looked
From: Nicolai Hähnle
Avoids an unnecessary move introduce by "radeonsi/gfx9: always wrap GS
and TCS in an if-block (v2)"
---
src/gallium/drivers/radeonsi/si_shader.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
From: Nicolai Hähnle
With merged ESGS shaders, the GS part of a wave may be empty, and the
hardware gets confused if any GS messages are sent from that wave. Since
S_SENDMSG is executed even when EXEC = 0, we have to wrap even
non-monolithic GS shaders in an if-block, so that the entire shader an
From: Andres Rodriguez
v2: fix an indentation error
v3: don't enable for r600
Signed-off-by: Andres Rodriguez
Reviewed-by: Marek Olšák
Reviewed-by: Timothy Arceri
---
src/gallium/drivers/radeonsi/si_pipe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/driver
From: Andres Rodriguez
This is required for interop use cases. The same device must report
identical UUIDs through the GL and Vulkan APIs so that users can
identify when it is safe to perform a memory object import.
v2: use ac helpers to calculate the uuid
Signed-off-by: Andres Rodriguez
Revie
From: Andres Rodriguez
These need to match for interop compatibility queries.
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/amd/vulkan/radv_device.c | 9 -
src/amd/vulkan/radv_private.h | 1 +
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/amd
From: Andres Rodriguez
v2: remove unnecessary returns
Signed-off-by: Andres Rodriguez
Reviewed-by: Marek Olšák
---
src/gallium/drivers/ddebug/dd_screen.c | 17 +
src/gallium/include/pipe/p_defines.h | 1 +
src/gallium/include/pipe/p_screen.h| 13 +
3 files c
From: Andres Rodriguez
These are just basic implementations.
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/formatquery.c | 17 +
src/mesa/main/mtypes.h | 3 +++
src/mesa/main/texparam.c| 27 +++
3 files changed,
From: Andres Rodriguez
v2: move from r600_common to radeonsi
Signed-off-by: Andres Rodriguez
Reviewed-by: Marek Olšák
---
src/gallium/drivers/radeonsi/si_pipe.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/gallium/drivers/radeonsi/si_pipe.c
b/src/gallium/drivers/ra
From: Andres Rodriguez
We need vulkan and gl to produce the same UUIDs. Therefore we should
keep the mechanism to compute these in a common location to guarantee
they are updated in lockstep.
Signed-off-by: Andres Rodriguez
Reviewed-by: Marek Olšák
---
src/amd/common/ac_gpu_info.c | 27 ++
From: Andres Rodriguez
These are used by EXT_external_objects to present UUIDs for the device
and the driver.
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/get.c | 177
1 file changed, 177 insertions(+)
diff
From: Andres Rodriguez
v2: respective changes for new gallium interface
v3: fix UUID size asserts
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/dd.h | 15 +++
src/mesa/main/get.c | 17 +
src/mesa/main
Include no_error variants as well.
v2 (Timothy Arceri):
- reduced code churn by squashing some changes into
previous commits
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/bufferobj.c | 62 ---
src/mesa/main/buffero
From: Andres Rodriguez
This can be used to guard support for EXT_memory_object and related
extensions.
v2: update gallium docs
Signed-off-by: Andres Rodriguez
Reviewed-by: Marek Olšák
---
src/gallium/docs/source/screen.rst | 1 +
src/gallium/drivers/etnaviv/etnaviv_screen.c
From: Andres Rodriguez
v2: use PIPE_CAP_MEMOBJ to guard the extension
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/extensions_table.h | 2 ++
src/mesa/main/mtypes.h | 2 ++
src/mesa/state_tracker/st_extensions.c | 5 +
3 files changed
From: Andres Rodriguez
Plumbing for using memory objects as texture storage.
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
Reviewed-by: Marek Olšák
---
src/mesa/state_tracker/st_cb_texture.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
diff
From: Andres Rodriguez
Use a memory object instead of user memory.
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/dd.h | 12 +
src/mesa/state_tracker/st_cb_bufferobjects.c | 66 +---
2 files changed, 61 inser
From: Dave Airlie
v2: also consider gfx9 metadata
v3: ref/unref memobj->buf
v4: add refcount comment
Signed-off-by: Andres Rodriguez
Reviewed-by: Marek Olšák
---
src/gallium/drivers/radeon/r600_pipe_common.h | 7 ++
src/gallium/drivers/radeon/r600_texture.c | 115 +++
From: Andres Rodriguez
Plumbing for importing memobj backed textures.
Signed-off-by: Andres Rodriguez
Reviewed-by: Marek Olšák
---
src/gallium/drivers/radeon/r600_texture.c | 63 ++-
1 file changed, 36 insertions(+), 27 deletions(-)
diff --git a/src/gallium/driver
From: Andres Rodriguez
V2 (Timothy Arceri):
- formating fixes
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/dd.h | 9 +++
src/mesa/main/externalobjects.c | 129
src/mesa/main/texstorage.c | 77 +
From: Andres Rodriguez
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/externalobjects.c | 52
src/mesa/main/teximage.c| 75 +
src/mesa/main/teximage.h| 10 ++
3 files changed
1 - 100 of 118 matches
Mail list logo
