Re: [Mesa-dev] [PATCH 02/12] i965/urb: Trigger upload_urb on NEW_BLORP

2017-07-01 Thread Kenneth Graunke
On Monday, June 26, 2017 4:22:35 PM PDT Ian Romanick wrote: > From: Jason Ekstrand > > It's a bit rare, but blorp can trigger a urb reconfiguration. When that > happens, we need to re-upload the URB config. Fortunately, this isn't as > bad as it looks because gen7_upload_urb will not re-emit th

Re: [Mesa-dev] [PATCH 03/12] i965: Don't recalculate partial_clear inside brw_fast_clear_depth

2017-07-01 Thread Kenneth Graunke
On Monday, June 26, 2017 4:22:36 PM PDT Ian Romanick wrote: > From: Ian Romanick > >text data bss dec hex filename > 7155954256860 37332 7450146 71ae22 32-bit i965_dri.so before > 7155858256860 37332 7450050 71adc2 32-bit i965_dri.so after > 6789395

Re: [Mesa-dev] [PATCH] anv: merge tessellation's primitive mode in merge_tess_info()

2017-07-01 Thread Kenneth Graunke
On Wednesday, June 28, 2017 3:20:29 AM PDT Samuel Iglesias Gonsálvez wrote: > SPIR-V tessellation shaders that were created from HSLS will have > the primitive generation domain set in tessellation control shader > (hull shader in HLSL) instead of the tessellation evaluation shader. > > Signed-off

Re: [Mesa-dev] [PATCH] anv: fix reported timestampPeriod value

2017-07-01 Thread Jason Ekstrand
Rb On July 1, 2017 4:43:45 PM Lionel Landwerlin wrote: We lost some precision on a previous change due to switching to integers. Since we report a float in timestampPeriod, we want the division to happen in floats. CID: 1413021 Fixes: c77d98ef32 ("intel: common: express timestamps units in

[Mesa-dev] [PATCH] anv: fix reported timestampPeriod value

2017-07-01 Thread Lionel Landwerlin
We lost some precision on a previous change due to switching to integers. Since we report a float in timestampPeriod, we want the division to happen in floats. CID: 1413021 Fixes: c77d98ef32 ("intel: common: express timestamps units in frequency") Signed-off-by: Lionel Landwerlin --- src/intel/v

Re: [Mesa-dev] [PATCH 00/16]: Allow Gallium drivers to support driver-specific drirc options

2017-07-01 Thread Kenneth Graunke
On Friday, June 30, 2017 5:59:43 AM PDT Nicolai Hähnle wrote: > There is one change that I forgot to mention: > > The existing xmlconfig system can filter drirc settings by X screen > number. After the series, this no longer works. Or rather, the system > behaves as if we're always on screen 0.

[Mesa-dev] [Bug 101668] Counter-Strike: Global Offense - Everything is purple

2017-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101668 --- Comment #3 from Laurent carlier --- Probably a duplicate of https://bugs.freedesktop.org/show_bug.cgi?id=101561 , now fixed in llvm trunk -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for

Re: [Mesa-dev] [PATCH] i965: Remove clearing of bo->map_gtt after failure

2017-07-01 Thread Kenneth Graunke
On Saturday, July 1, 2017 3:14:00 AM PDT Chris Wilson wrote: > With the conversion to storing the result of drm_mmap to a local and not > directly to bo->map_gtt itself, we no longer should clear bo->map_gtt. > In the best the operation is redundant as we know bo->map_gtt to already > be NULL, but

[Mesa-dev] [Bug 101668] Counter-Strike: Global Offense - Everything is purple

2017-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101668 --- Comment #2 from omin...@autistici.org --- Package: libgl1-mesa-glx Version: 1:17.2~git170629170600.277621b~x~padoka0 01:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Fiji [Radeon R9 FURY / NANO Series] [1002:7

Re: [Mesa-dev] [PATCH] i965: Print access flags in INTEL_DEBUG=buf output.

2017-07-01 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glthread: get rid of unmarshal dispatch enum/table

2017-07-01 Thread Marek Olšák
Instead of passing the function pointer through the queue, passing just a call ID (uint16_t) is preferable. If the switch statement is an issue, doing a function pointer lookup from a static array should be OK. Marek On Fri, Jun 30, 2017 at 7:14 PM, Grigori Goronzy wrote: > On 2017-06-30 15:27,

Re: [Mesa-dev] [PATCH 15/19] mesa: hook up UUID queries for driver and device

2017-07-01 Thread Andres Rodriguez
On 2017-07-01 11:29 AM, Jason Ekstrand wrote: On June 30, 2017 5:58:24 PM Andres Rodriguez wrote: On 2017-06-30 07:21 PM, Jason Ekstrand wrote: On June 30, 2017 4:04:31 PM Andres Rodriguez wrote: Signed-off-by: Andres Rodriguez --- src/mesa/main/dd.h | 6 ++ src

Re: [Mesa-dev] [PATCH 18/18] nir/spirv: Rework function argument setup

2017-07-01 Thread Jason Ekstrand
On Fri, Jun 30, 2017 at 4:31 PM, Connor Abbott wrote: > On Fri, Jun 30, 2017 at 4:25 PM, Jason Ekstrand > wrote: > > On June 30, 2017 3:28:51 PM Connor Abbott wrote: > > > >> Now, that we're handling the pointers explicitly, can't we delete the > >> code in vtn_ssa_value() > >> to implicitly lo

Re: [Mesa-dev] [PATCH 2/4] ac/nir: implement 64-bit packing and unpacking

2017-07-01 Thread Bas Nieuwenhuizen
Not sure whether I'd reviewed the first series, but patches 2-4 are Reviewed-by: Bas Nieuwenhuizen On Sat, Jul 1, 2017 at 4:56 AM, Connor Abbott wrote: > From: Connor Abbott > > We implement the split opcodes, and tell NIR to lower the original ones. > The lowering to LLVM is a little more com

[Mesa-dev] [PATCH] Android: generate symlinks for all enabled gallium drivers

2017-07-01 Thread Mauro Rossi
Current post install command relies on GALLIUM_TARGET_DRIVERS variable, however variable needs to be initialized in src/gallium/Android.mk in order that all enabled gallium drivers symlinks are correctly generated. At the moment due to sorting of INC_DIRS and variable set with svga (vmwgfx) only v

[Mesa-dev] [PATCH] st/mesa: fix tessellation shaders with no support for shareable shaders

2017-07-01 Thread Marek Olšák
From: Marek Olšák Broken by: b43c887a9bf1e3fb99b0dc22bfea5db81375a06e Reported by Gert Wollny. --- src/mesa/state_tracker/st_atom_shader.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_shader.c b/src/mesa/state_tracker/st_atom_shader.c i

Re: [Mesa-dev] [PATCH 15/19] mesa: hook up UUID queries for driver and device

2017-07-01 Thread Jason Ekstrand
On June 30, 2017 5:58:24 PM Andres Rodriguez wrote: On 2017-06-30 07:21 PM, Jason Ekstrand wrote: On June 30, 2017 4:04:31 PM Andres Rodriguez wrote: Signed-off-by: Andres Rodriguez --- src/mesa/main/dd.h | 6 ++ src/mesa/main/get.c | 17 +++

Re: [Mesa-dev] [PATCH 1/4] spirv: fix OpBitcast when the src and dst bitsize are different (v2)

2017-07-01 Thread Jason Ekstrand
On June 30, 2017 19:57:01 Connor Abbott wrote: From: Connor Abbott Before, we were just implementing it with a move, which is incorrect when the source and destination have different bitsizes. To implement it properly, we need to use the 64-bit pack/unpack opcodes. Since glslang uses OpBitcas

Re: [Mesa-dev] [PATCH] swr: Limit memory held by defer deleted resources.

2017-07-01 Thread Ilia Mirkin
FWIW I added the exact same workaround in nouveau. I think I even also used 64: https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/nouveau/nouveau_fence.c#n270 Reviewed-by: Ilia Mirkin On Fri, Jun 30, 2017 at 11:24 PM, Bruce Cherniak wrote: > This patch limits the number of items

[Mesa-dev] [Bug 101668] Counter-Strike: Global Offense - Everything is purple

2017-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101668 --- Comment #1 from Ilia Mirkin --- [You can't assume that anyone upstream knows the specifics of your distro or some private repo you're using] A small recommendation: - List mesa version - List hardware (lspci -nn -d ::300 should generally

Re: [Mesa-dev] [PATCH] st/dri: add 32-bit RGBX/RGBA formats

2017-07-01 Thread Marek Olšák
Hi Rob, It would be better to have a flag passed from libEGL to st/dri saying that it's OK to expose those formats. I wouldn't like to have GLX visuals that are unusable in practice because X doesn't support that component ordering. Marek On Fri, Jun 30, 2017 at 8:31 PM, Rob Herring wrote: > A

[Mesa-dev] [Bug 101668] Counter-Strike: Global Offense - Everything is purple

2017-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101668 omin...@autistici.org changed: What|Removed |Added CC||omin...@autistici.org -- You ar

[Mesa-dev] [Bug 101668] Counter-Strike: Global Offense - Everything is purple

2017-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101668 Bug ID: 101668 Summary: Counter-Strike: Global Offense - Everything is purple Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH v2 2/3] gallium/hud: Prevent buffer overflow in hud_thread_counter_install

2017-07-01 Thread Robert Foss
On Thu, 2017-06-29 at 07:28 -0600, Brian Paul wrote: > On 06/29/2017 07:21 AM, Robert Foss wrote: > > Switch to using strncopy to avoid potential overflow of > > name array in struct hud_graph. > > > > Coverity-id: 1413761 > > > > Signed-off-by: Robert Foss > > --- > >   src/gallium/auxiliary/hu

Re: [Mesa-dev] [PATCH] st/dri: add 32-bit RGBX/RGBA formats

2017-07-01 Thread Fredrik Höglund
On Friday 30 June 2017, Rob Herring wrote: > Add support for 32-bit RGBX/RGBA formats which are required for Android. > > The original patch (commit ccdcf91104a5) was reverted (commit > c0c6ca40a25e) in mesa as it broke GLX resulting in swapped colors. Based > on further investigation by Chad Vers

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix texture image resource selection in st_render_texture()

2017-07-01 Thread Nicolai Hähnle
On 29.06.2017 00:12, Brian Paul wrote: If we're rendering to an incomplete/inconsistent (cube) texture, the different faces/levels of the texture may be stored in different resources. Before, we always used the texture object resource. Now, we use the texture image resource. In normal circumst

Re: [Mesa-dev] [PATCH 05/24] st/mesa: unify update_gp/tcp/tep code

2017-07-01 Thread Gert Wollny
Hello Marek, this patch makes most of the tesselation shaders in piglit crash because now you are passing MESA_SHADER_TESS_* to st_get_basic_variant, but this function tests for PIPE_SHADER_TESS_* when allocating new variants. Hence, the function doesn't fulfill the assert in debug mode, or it r

[Mesa-dev] [PATCH] i965: Remove clearing of bo->map_gtt after failure

2017-07-01 Thread Chris Wilson
With the conversion to storing the result of drm_mmap to a local and not directly to bo->map_gtt itself, we no longer should clear bo->map_gtt. In the best the operation is redundant as we know bo->map_gtt to already be NULL, but in the worst case we overwrite a concurrent thread that successfully

Re: [Mesa-dev] Mesa (master): build systems: uniformize git_sha1.h generation

2017-07-01 Thread Eric Engestrom
On 1 July 2017 00:18:31 BST, Brian Paul wrote: > Hi Eric, > > Shouldn't the new script file be put in the bin/ directory with the > other helper scripts? I guess you're right, not sure why I didn't do that. Feel free to move it (just make sure to ../ the --git-dir too), or I can do that when I