Re: [Mesa-dev] [PATCH] scons: add code to generate format_fallback.c file

Looks good to me, thanks! Reviewed-by: Roland Scheidegger Am 28.06.2017 um 04:58 schrieb Brian Paul: > Fixes broken SCons build since a1983223d8839a0c9 > --- > src/mesa/SConscript | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/mesa/SConscript b/src/mesa/SConscript > index f

[Mesa-dev] [PATCH 09/14] mesa: inline _mesa_finish()

--- src/mesa/main/context.c | 23 +++ src/mesa/main/context.h | 3 --- 2 files changed, 7 insertions(+), 19 deletions(-) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index b801322..2ed4ae8 100644 --- a/src/mesa/main/context.c +++ b/src/mesa/main/context.c @@

[Mesa-dev] [PATCH 11/14] mesa: add bind_frag_data_location() helper

--- src/mesa/main/shader_query.cpp | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp index 6efbc37..d571846 100644 --- a/src/mesa/main/shader_query.cpp +++ b/src/mesa/main/shader_quer

[Mesa-dev] [PATCH 14/14] mesa: add KHR_no_error support for glBlendFunc*()

--- src/mapi/glapi/gen/gl_API.xml | 4 ++-- src/mesa/main/blend.c | 25 + src/mesa/main/blend.h | 5 + 3 files changed, 32 insertions(+), 2 deletions(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index d545050..0635177

[Mesa-dev] [PATCH 08/14] mesa: add KHR_no_error support for glDisableVertexA*A*()

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/varray.c | 17 + src/mesa/main/varray.h | 6 ++ 4 files changed, 25 insertions(+), 2 deletions(-)

[Mesa-dev] [PATCH 13/14] mesa: create some glBlendFunc*() helper functions

--- src/mesa/main/blend.c | 131 +++--- 1 file changed, 81 insertions(+), 50 deletions(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index 3fa9678..b06ec33 100644 --- a/src/mesa/main/blend.c +++ b/src/mesa/main/blend.c @@ -157,20 +157,6

[Mesa-dev] [PATCH 12/14] mesa: add KHR_no_error support for glBindFragDataLocation*()

--- src/mapi/glapi/gen/ARB_blend_func_extended.xml | 2 +- src/mapi/glapi/gen/GL3x.xml| 2 +- src/mesa/main/shader_query.cpp | 24 src/mesa/main/shaderapi.h | 8 4 files changed, 34 insertions(+), 2 delet

[Mesa-dev] [PATCH 07/14] mesa: move error handling into disable_vertex_array_attrib() callers

This will let us just call disable_vertex_array_attrib() for KHR_no_error support. --- src/mesa/main/varray.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c index 7665e77..207fa78 100644 --- a/src/mesa/

[Mesa-dev] [PATCH 03/14] mesa: add KHR_no_error support for glPixelStore*()

--- src/mapi/glapi/gen/gl_API.xml | 4 ++-- src/mesa/main/pixelstore.c| 13 + src/mesa/main/pixelstore.h| 8 3 files changed, 23 insertions(+), 2 deletions(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index d878a04..4820c7f 100644 --

[Mesa-dev] [PATCH 02/14] mesa: add pixel_storei() helper

Will be used to add KHR_no_error support. --- src/mesa/main/pixelstore.c | 103 + 1 file changed, 57 insertions(+), 46 deletions(-) diff --git a/src/mesa/main/pixelstore.c b/src/mesa/main/pixelstore.c index fc81533..841ff48 100644 --- a/src/mesa/main/pi

[Mesa-dev] [PATCH 10/14] mesa: add KHR_no_error support for glGetUniformLocation()

--- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/uniforms.c | 11 +++ src/mesa/main/uniforms.h | 2 ++ 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index 17fea47..d545050 100644 --- a/src/map

[Mesa-dev] Glamor related KHR_no_error patches

Once this and Samuels latest patchset lands there should only be 3 more major calls to go. glTexParameteri() glEnable/Disable() TexParameteri is non trival to rework for no error I'm still thinking about how best to do it. glEnable/Disable is just really large, I think we will probably just pass

[Mesa-dev] [PATCH 06/14] mesa: add KHR_no_error support for glEnableVertexA*A*()

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/varray.c | 18 ++ src/mesa/main/varray.h | 7 +++ 4 files changed, 27 insertions(+), 2 deletions(-)

[Mesa-dev] [PATCH 05/14] mesa: add KHR_no_error support for glLogicOp()

--- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/blend.c | 8 src/mesa/main/blend.h | 4 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index 4820c7f..9482ab5 100644 --- a/src/mapi/gl

[Mesa-dev] [PATCH 01/14] mesa: remove redundant error check

We do the same check in the shared code in the set_tex_parameterf() call. --- src/mesa/main/texparam.c | 4 1 file changed, 4 deletions(-) diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c index 3c110de..6c908af 100644 --- a/src/mesa/main/texparam.c +++ b/src/mesa/main/texpara

[Mesa-dev] [PATCH 04/14] mesa: add logic_op() helper

--- src/mesa/main/blend.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index 881e9c8..541c248 100644 --- a/src/mesa/main/blend.c +++ b/src/mesa/main/blend.c @@ -755,6 +755,21 @@ _mesa_AlphaFunc( GLenum

[Mesa-dev] [PATCH] scons: add code to generate format_fallback.c file

Fixes broken SCons build since a1983223d8839a0c9 --- src/mesa/SConscript | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/SConscript b/src/mesa/SConscript index fa4efe1..b63e15a 100644 --- a/src/mesa/SConscript +++ b/src/mesa/SConscript @@ -79,6 +79,13 @@ format_unpack = env.Cod

Re: [Mesa-dev] [PATCH 42/42] mesa: add KHR_no_error support for glClear()

41-42: Reviewed-by: Timothy Arceri On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/clear.c | 8 src/mesa/main/clear.h | 2 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff -

Re: [Mesa-dev] [PATCH 40/42] mesa: add KHR_no_error support for glBindAttribLocation()

On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/shader_query.cpp | 11 +++ src/mesa/main/shaderapi.h | 3 +++ 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/

Re: [Mesa-dev] [PATCH 37/42] mesa: create read_buffer_err() and always inline read_buffer()

On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/buffers.c | 46 +- 1 file changed, 29 insertions(+), 17 deletions(-) diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buffers.c index d85974afe60..dfee7a

Re: [Mesa-dev] [PATCH 01/12] genxml: Silence about a billion unused parameter warnings

Quoting Dylan Baker (2017-06-27 10:04:47) > Quoting Ian Romanick (2017-06-26 16:22:34) > > From: Ian Romanick > > > > v2: Use textwrap.dedent to make the source line a lot shorter. > > Shortening (?) the line was requested by Jason. > > > > Signed-off-by: Ian Romanick > > --- > > src/intel/gen

[Mesa-dev] [Bug 101614] OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...'

https://bugs.freedesktop.org/show_bug.cgi?id=101614 Bug ID: 101614 Summary: OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...' Product: Mesa Version: 17.1 Hardware: x86

Re: [Mesa-dev] [PATCH 25/42] mesa: prepare create_render_buffers() for KHR_no_error support

On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/fbobject.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 74b38180900..d16fe6bd21a 10064

Re: [Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

On Tue, Jun 27, 2017 at 12:49 PM, Chad Versace wrote: > On Fri 16 Jun 2017, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/intel_fbo.c | 3 ++- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 7 --- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 3 ++- > > src/m

Re: [Mesa-dev] [PATCH 12/30] i965/miptree: Allocate mt earlier in update winsys

On Tue, Jun 27, 2017 at 12:19 PM, Chad Versace wrote: > On Mon 26 Jun 2017, Pohjolainen, Topi wrote: > > On Fri, Jun 16, 2017 at 03:41:34PM -0700, Jason Ekstrand wrote: > > > From: Ben Widawsky > > > > > > Allows us to continue utilizing common miptree creation using > __DRIimage > > > without c

Re: [Mesa-dev] [PATCH 27/30] i965/screen: Support import and export of surfaces with CCS

On Mon, Jun 26, 2017 at 12:50 PM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Jun 16, 2017 at 03:41:49PM -0700, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/intel_screen.c | 55 > +--- > > 1 file changed, 50 insertions(+), 5 deletion

Re: [Mesa-dev] [PATCH 1/2] vulkan/util: Introduce format utilities

> > > Drive-by: Yes, I agree that this doesn't match Vulkan particularly well. > It's a very X11 or drm_fourcc way of described formats and is nothing like > anything else we have in mesa. That doesn't mean it's strictly wrong, just > that it's awkward to people who are used to some of the other m

Re: [Mesa-dev] [PATCH 1/2] vulkan/util: Introduce format utilities

On Tue, Jun 27, 2017 at 4:29 PM, Chad Versace wrote: > On Fri 23 Jun 2017, alexandros.frant...@collabora.com wrote: > > From: Alexandros Frantzis > > > > Introduce utilities to describe, find and compare Vulkan formats based > > on their color component masks, taking into account system endianne

[Mesa-dev] [AppVeyor] mesa master #4772 failed

Build mesa 4772 failed Commit 74db56b97a by Chad Versace on 5/30/2017 7:27 PM: i965: Add a RGBX->RGBA fallback for glEGLImageTextureTarget2D()\n\nThis enables support for importing RGBX EGLImage textures on\nSkylake.\n\nChrome OS needs support for RGBX

Re: [Mesa-dev] [PATCH 3/3] i965/dri: Support R8G8B8A8 and R8G8B8X8 configs

Daniel, I have a question for you below. On Tue 27 Jun 2017, Kenneth Graunke wrote: > On Tuesday, June 27, 2017 11:00:48 AM PDT Chad Versace wrote: > > The Android framework requires support for EGLConfigs with > > HAL_PIXEL_FORMAT_RGBX_ and HAL_PIXEL_FORMAT_RGBA_. > > > > Even though all

Re: [Mesa-dev] [PATCH 23/42] mesa: prepare create_program_pipelines() for KHR_no_error support

On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/pipelineobj.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelineobj.c index 0f0d1dafffe..ca17f

Re: [Mesa-dev] [PATCH 21/42] mesa: prepare create_samplers() helper for KHR_no_error support

On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/samplerobj.c | 37 ++--- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/src/mesa/main/samplerobj.c b/src/mesa/main/samplerobj.c index d3ed4da3932..2fbaab

Re: [Mesa-dev] [PATCH 0/2] vulkan/wsi/wayland: Improve surface format support

On Fri 23 Jun 2017, alexandros.frant...@collabora.com wrote: > From: Alexandros Frantzis > > Improve the surface format support in the Wayland Vulkan WSI, by > automating the matching between wl_drm and Vulkan formats. The same > mechanism can be used to improve format support in vulkan/wsi/x11 >

Re: [Mesa-dev] [PATCH 19/42] mesa: prepare create_textures() helper for KHR_no_error support

On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/texobj.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 0fcf5839689..1b2bb50d1d3 100644 --

Re: [Mesa-dev] [PATCH 1/2] vulkan/util: Introduce format utilities

On Fri 23 Jun 2017, alexandros.frant...@collabora.com wrote: > From: Alexandros Frantzis > > Introduce utilities to describe, find and compare Vulkan formats based > on their color component masks, taking into account system endianness. > --- > src/vulkan/Makefile.sources | 2 + > src/vul

Re: [Mesa-dev] [PATCH 16/42] mesa: prepare create_buffers() helper for KHR_no_error support

On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/bufferobj.c | 45 ++--- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 6e2979f6db9..e

Re: [Mesa-dev] [PATCH 15/42] mesa: add KHR_no_error support for glBindTextureUnit()

5-15: Reviewed-by: Timothy Arceri On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/texobj.c | 8 src/mesa/main/texobj.h | 3 +++ 3 fil

Re: [Mesa-dev] [PATCH 04/42] mesa: pass the 'caller' function to create_shader()

On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/shaderapi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 7318833e9b8..bb944191813 100644 --- a/src/mesa/

Re: [Mesa-dev] [PATCH 03/42] mesa: add KHR_no_error support for glAttachShader() and glAttachObjectARB()

On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 4 ++-- src/mesa/main/shaderapi.c | 28 src/mesa/main/shaderapi.h | 7 ++- 3 files changed, 36 insertions(+), 3 deletions(-) diff --git a/

[Mesa-dev] [PATCH] intel/compiler: Don't use opt_sampler_eot() optimization on gen10+

This optimization has been removed on gen10+. Signed-off-by: Anuj Phogat --- src/intel/compiler/brw_fs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp index 43b6e34..a2a99b7 100644 --- a/src/intel/compiler/brw_

[Mesa-dev] [PATCH] swr: conditionally validate vertex buffer state

Vertex buffer state doesn't need to be validated on every call, only on dirty _NEW_VERTEX or indexed draws. Unconditional validation was introduced as part of patch 330d0607ed6, "remove pipe_index_buffer and set_index_buffer", with the expectation we'd optimize later. --- src/gallium/drivers/swr/

Re: [Mesa-dev] [PATCH 1/3] mesa: GL_TEXTURE_BORDER_COLOR exists in OpenGL 1.0, so don't depend on GL_ARB_texture_border_clamp

On Tue, Jun 27, 2017 at 3:18 PM, Ian Romanick wrote: > On 06/27/2017 11:23 AM, Ilia Mirkin wrote: >> On Tue, Jun 27, 2017 at 1:09 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> On NV20 (and probably also on earlier NV GPUs that lack >>> GL_ARB_texture_border_clamp) fixes the following pi

Re: [Mesa-dev] [PATCH 18/30] intel/isl: Add basic modifier introspection

On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/intel/Makefile.am | 1 + > src/intel/Makefile.sources | 1 + > src/intel/isl/isl.h| 22 + > src/intel/isl/isl_drm.c| 59 > ++ > 4 files changed, 83 insertions(+) >

Re: [Mesa-dev] [PATCH 17/30] i965: Add an isl_device to intel_screen

On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_context.c | 2 +- > src/mesa/drivers/dri/i965/intel_screen.c | 3 +++ > src/mesa/drivers/dri/i965/intel_screen.h | 4 > 3 files changed, 8 insertions(+), 1 deletion(-) Patch 17 is Reviewed-by: Chad Versace ___

Re: [Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_fbo.c | 3 ++- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 7 --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 3 ++- > src/mesa/drivers/dri/i965/intel_tex_image.c | 3 ++- > 4 files changed,

Re: [Mesa-dev] [PATCH 3/3] i965/dri: Support R8G8B8A8 and R8G8B8X8 configs

On Tuesday, June 27, 2017 11:00:48 AM PDT Chad Versace wrote: > The Android framework requires support for EGLConfigs with > HAL_PIXEL_FORMAT_RGBX_ and HAL_PIXEL_FORMAT_RGBA_. > > Even though all RGBX formats are disabled on gen9 by > brw_surface_formats.c, the new configs work correctly o

Re: [Mesa-dev] [PATCH v2] mesa: Add _mesa_format_fallback_rgba_to_rgbx()

On Tue 20 Jun 2017, Jason Ekstrand wrote: > From: Chad Versace > > The new function takes a mesa_format and, if the format is an alpha > format with a non-alpha variant, returns the non-alpha format. > Otherwise, it returns the original format. > > Example: > input -> output > > // Fallback

Re: [Mesa-dev] [PATCH 12/30] i965/miptree: Allocate mt earlier in update winsys

On Mon 26 Jun 2017, Pohjolainen, Topi wrote: > On Fri, Jun 16, 2017 at 03:41:34PM -0700, Jason Ekstrand wrote: > > From: Ben Widawsky > > > > Allows us to continue utilizing common miptree creation using __DRIimage > > without creating a new DRIimage (for the intel_process_dri2_buffer() > > case)

Re: [Mesa-dev] [PATCH 1/3] mesa: GL_TEXTURE_BORDER_COLOR exists in OpenGL 1.0, so don't depend on GL_ARB_texture_border_clamp

On 06/27/2017 11:23 AM, Ilia Mirkin wrote: > On Tue, Jun 27, 2017 at 1:09 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> On NV20 (and probably also on earlier NV GPUs that lack >> GL_ARB_texture_border_clamp) fixes the following piglit tests: >> >> gl-1.0-beginend-coverage gltexparameter

Re: [Mesa-dev] [RFT PATCH 2/2] nv20: enable ARB_texture_border_clamp support

On 06/27/2017 11:16 AM, Roland Scheidegger wrote: > Am 27.06.2017 um 20:10 schrieb Ian Romanick: >> On 06/27/2017 11:00 AM, Ilia Mirkin wrote: >>> On Tue, Jun 27, 2017 at 1:11 PM, Ian Romanick wrote: On 06/27/2017 02:59 AM, Timothy Arceri wrote: > Just curious. Can this extension be added

Re: [Mesa-dev] [PATCH 1/3] mesa: GL_TEXTURE_BORDER_COLOR exists in OpenGL 1.0, so don't depend on GL_ARB_texture_border_clamp

On Tue, Jun 27, 2017 at 1:09 PM, Ian Romanick wrote: > From: Ian Romanick > > On NV20 (and probably also on earlier NV GPUs that lack > GL_ARB_texture_border_clamp) fixes the following piglit tests: > > gl-1.0-beginend-coverage gltexparameter[if]{v,} > push-pop-texture-state > texwrap

Re: [Mesa-dev] [PATCH 00/30] i965: Add support for I915_FORMAT_MOD_Y_TILED_CCS

On Wed, Jun 21, 2017 at 05:51:00PM -0700, Jason Ekstrand wrote: > On Fri, Jun 16, 2017 at 3:41 PM, Jason Ekstrand > wrote: > > > This series is a rework of Ben's series to enable the CCS format modifier. > > It started as an attempt to rebase his original patches on top of my > > resolve reworks

Re: [Mesa-dev] [PATCH 19/30] intel/isl: Add a helper to convert tilings fro ISL to i915

In the subject: s/fro/from/ On Fri, Jun 16, 2017 at 03:41:41PM -0700, Jason Ekstrand wrote: > --- > src/intel/isl/isl.h | 3 +++ > src/intel/isl/isl_drm.c | 23 +++ > 2 files changed, 26 insertions(+) > > diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h > index eb

Re: [Mesa-dev] [RFT PATCH 2/2] nv20: enable ARB_texture_border_clamp support

Am 27.06.2017 um 20:10 schrieb Ian Romanick: > On 06/27/2017 11:00 AM, Ilia Mirkin wrote: >> On Tue, Jun 27, 2017 at 1:11 PM, Ian Romanick wrote: >>> On 06/27/2017 02:59 AM, Timothy Arceri wrote: Just curious. Can this extension be added to NV04 and NV10? As those are the only drivers th

Re: [Mesa-dev] [RFT PATCH 2/2] nv20: enable ARB_texture_border_clamp support

On Tue, Jun 27, 2017 at 2:10 PM, Ian Romanick wrote: > On 06/27/2017 11:00 AM, Ilia Mirkin wrote: >> On Tue, Jun 27, 2017 at 1:11 PM, Ian Romanick wrote: >>> On 06/27/2017 02:59 AM, Timothy Arceri wrote: Just curious. Can this extension be added to NV04 and NV10? As those are the only d

Re: [Mesa-dev] [PATCH 12/12] i965: Assert that blorp always handles color blits

On 06/27/2017 10:53 AM, Kenneth Graunke wrote: > On Monday, June 26, 2017 4:22:45 PM PDT Ian Romanick wrote: >> From: Ian Romanick >> >> --- >> src/mesa/drivers/dri/i965/brw_blorp.c | 2 ++ >> src/mesa/drivers/dri/i965/intel_fbo.c | 3 +++ >> 2 files changed, 5 insertions(+) >> >> diff --git a/sr

Re: [Mesa-dev] [RFT PATCH 2/2] nv20: enable ARB_texture_border_clamp support

On 06/27/2017 11:00 AM, Ilia Mirkin wrote: > On Tue, Jun 27, 2017 at 1:11 PM, Ian Romanick wrote: >> On 06/27/2017 02:59 AM, Timothy Arceri wrote: >>> Just curious. Can this extension be added to NV04 and NV10? As those are >>> the only drivers that don't currently support it. >>> >>> I have cards

[Mesa-dev] [PATCH 3/3] i965/dri: Support R8G8B8A8 and R8G8B8X8 configs

The Android framework requires support for EGLConfigs with HAL_PIXEL_FORMAT_RGBX_ and HAL_PIXEL_FORMAT_RGBA_. Even though all RGBX formats are disabled on gen9 by brw_surface_formats.c, the new configs work correctly on Broxton thanks to _mesa_format_fallback_rgbx_to_rgba(). On GLX, this

[Mesa-dev] [PATCH v2 03/13] swr/rast: gen_backends.py removal of commented debug prints

--- src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py b/src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py index 09f40fa..f65f764 100644 --- a/src/ga

[Mesa-dev] [PATCH v2 06/13] swr/rast: gen_backends.py remove extraneous semicolon

--- src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py b/src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py index 3f0790c..2fc91d1 100644 --- a/src/gall

[Mesa-dev] [PATCH v2 00/13] swr: update rasterizer

Highlights include splitting the heavily templated files into multiple chunks to speed compile (2x for a large machine), and switching the simd intrinsic usage from a macro-based header to a more c++ feeling library. No regressions on piglit or vtk tests, passes "make dist"/compile. v2: * split

[Mesa-dev] [PATCH v2 02/13] swr/rast: gen_backends.py quote cleanup

--- .../drivers/swr/rasterizer/codegen/gen_backends.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py b/src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py index d9e938a..09f40fa 100644 -

[Mesa-dev] [PATCH v2 05/13] swr/rast: Support dynamically sized vertex layout

Each shader stage state (VS, TS, GS, SO, BE/CLIP) now has a vertexAttribOffset to specify the offset to the start of the general attribute section of the incoming verts for that stage. It is up to the driver to set this up correctly based on the active stages. All the shader stages use this value i

[Mesa-dev] [PATCH v2 11/13] swr/rast: Fix missing setup of psContext.pColorBuffer

Fixes render target read access from pixel shaders. --- .../drivers/swr/rasterizer/core/backend_sample.cpp| 15 +++ .../drivers/swr/rasterizer/core/backend_singlesample.cpp | 15 +++ 2 files changed, 14 insertions(+), 16 deletions(-) diff --git a/src/gallium/drive

[Mesa-dev] [PATCH v2 13/13] swr/rast: increase number of possible draws in flight

Increases performance of some large workloads on KNL by ~30%. --- src/gallium/drivers/swr/rasterizer/codegen/knob_defs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/knob_defs.py b/src/gallium/drivers/swr/rasterizer/codegen/knob_d

[Mesa-dev] [PATCH v2 09/13] scons: allow .inl file extension

Intended for header files which are not meant to be included directly. --- scons/custom.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scons/custom.py b/scons/custom.py index 544b15d..955247c 100644 --- a/scons/custom.py +++ b/scons/custom.py @@ -281,7 +281,7 @@ def parse_s

[Mesa-dev] [PATCH v2 08/13] swr/rast: Fix unused variable warnings

--- src/gallium/drivers/swr/rasterizer/core/binner.cpp | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/binner.cpp b/src/gallium/drivers/swr/rasterizer/core/binner.cpp index 19eef9b..29d2f1c 100644 --- a/src/gallium/drivers/swr/rasterizer/core/binne

[Mesa-dev] [PATCH v2 01/13] swr/rast: generators will create target directories

--- src/gallium/drivers/swr/rasterizer/codegen/gen_common.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/gen_common.py b/src/gallium/drivers/swr/rasterizer/codegen/gen_common.py index 07b455a..7f53ec6 100644 --- a/src/gallium/drivers/swr/r

[Mesa-dev] [PATCH v2 12/13] swr/rast: move default split size from driver to rasterizer

--- src/gallium/drivers/swr/rasterizer/codegen/knob_defs.py | 2 +- src/gallium/drivers/swr/swr_screen.cpp | 4 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/knob_defs.py b/src/gallium/drivers/swr/rasterizer/codegen/

[Mesa-dev] [PATCH 2/3] i965: Add a RGBX->RGBA fallback for glEGLImageTextureTarget2D()

This enables support for importing RGBX EGLImage textures on Skylake. Chrome OS needs support for RGBX EGLImage textures because because the Android framework produces HAL_PIXEL_FORMAT_RGBX winsys surfaces, which the Chrome OS compositor consumes as dma_bufs. On hardware for which RGB

[Mesa-dev] [PATCH 1/3] mesa: Add _mesa_format_fallback_rgbx_to_rgba() [v2]

The new function takes a mesa_format and, if the format is an alpha format with a non-alpha variant, returns the non-alpha format. Otherwise, it returns the original format. Example: input -> output // Fallback exists MESA_FORMAT_R8G8B8X8_UNORM -> MESA_FORMAT_R8G8B8A8_UNORM MESA_FORMAT_RG

Re: [Mesa-dev] [PATCH 12/30] i965/miptree: Allocate mt earlier in update winsys

On Mon, Jun 26, 2017 at 09:36:34PM +0300, Pohjolainen, Topi wrote: > On Fri, Jun 16, 2017 at 03:41:34PM -0700, Jason Ekstrand wrote: > > From: Ben Widawsky > > > > Allows us to continue utilizing common miptree creation using __DRIimage > > without creating a new DRIimage (for the intel_process_d

[Mesa-dev] [PATCH 0/3 v2] i965: Add RGBX, RGBA configs, even on gen9

The Android framework requires support for EGLConfigs with HAL_PIXEL_FORMAT_RGBX_ and HAL_PIXEL_FORMAT_RGBA_. This prevents Chrome OS from updating its Android drivers, because earlier this year Intel disabled all rgbx formats for gen >=9 in brw_surface_formats.c. This patch series safely (

Re: [Mesa-dev] [RFT PATCH 2/2] nv20: enable ARB_texture_border_clamp support

On Tue, Jun 27, 2017 at 1:11 PM, Ian Romanick wrote: > On 06/27/2017 02:59 AM, Timothy Arceri wrote: >> Just curious. Can this extension be added to NV04 and NV10? As those are >> the only drivers that don't currently support it. >> >> I have cards I could test those with, but don't have an NV20.

Re: [Mesa-dev] [PATCH] i965: Fix anisotropic filtering for mag filter

On Tuesday, June 27, 2017 10:37:16 AM PDT Rafael Antognolli wrote: > From: Eero Tamminen > > Commit f8d69beed49c64f883bb8ffb28d4960306baf575 moving sampler > handling to genxml messed up change done by commit > 6a7c5257cac23cd9767aa4bc8fdab68925b11157. > > This broke rendering in SynMark CSDof a

Re: [Mesa-dev] [PATCH 12/12] i965: Assert that blorp always handles color blits

On Monday, June 26, 2017 4:22:45 PM PDT Ian Romanick wrote: > From: Ian Romanick > > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 2 ++ > src/mesa/drivers/dri/i965/intel_fbo.c | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c > b/src/mesa/drive

Re: [Mesa-dev] [PATCH] i965: Fix anisotropic filtering for mag filter

Ouch. The frustrating thing is that anisotropic filtering is so underspecified (intentionally) that it's hard to write tests that will detect these kinds of problems and also work across multiple vendors. :( Reviewed-by: Ian Romanick On 06/27/2017 10:37 AM, Rafael Antognolli wrote: > From: Eero

Re: [Mesa-dev] [PATCH mesa] build systems: uniformize git_sha1.h generation

Right you are. Thanks. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965: Fix anisotropic filtering for mag filter

From: Eero Tamminen Commit f8d69beed49c64f883bb8ffb28d4960306baf575 moving sampler handling to genxml messed up change done by commit 6a7c5257cac23cd9767aa4bc8fdab68925b11157. This broke rendering in SynMark CSDof and TexFilterAniso tests. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=

Re: [Mesa-dev] [PATCH mesa] build systems: uniformize git_sha1.h generation

On 27 June 2017 18:11:14 BST, Matt Turner wrote: > On Tue, Jun 27, 2017 at 5:47 AM, Eric Engestrom > wrote: > > Signed-off-by: Eric Engestrom > > --- > > Note: Autotools and SCons are tested, but Android isn't. > > --- > > git_sha1_gen.sh | 13 + > > src/Makefil

Re: [Mesa-dev] [PATCH 2/2] radeonsi: move instance divisors into a constant buffer

On 27.06.2017 18:59, Marek Olšák wrote: On Tue, Jun 27, 2017 at 6:50 PM, Nicolai Hähnle wrote: On 27.06.2017 17:07, Marek Olšák wrote: On Tue, Jun 27, 2017 at 9:22 AM, Nicolai Hähnle wrote: On 27.06.2017 02:14, Marek Olšák wrote: From: Marek Olšák Shader key size: 107 -> 47 Nice i

Re: [Mesa-dev] [PATCH v2 01/13] intel/blorp: Assert levels and layers are in range

On Thu, Jun 22, 2017 at 10:32:42AM -0700, Jason Ekstrand wrote: > On Thu, Jun 22, 2017 at 10:02 AM, Nanley Chery > wrote: > > > On Thu, Jun 22, 2017 at 09:59:44AM -0700, Nanley Chery wrote: > > > On Thu, Jun 22, 2017 at 09:55:50AM -0700, Nanley Chery wrote: > > > > On Wed, Jun 21, 2017 at 06:07:2

Re: [Mesa-dev] [PATCH 01/12] genxml: Silence about a billion unused parameter warnings

On 06/27/2017 10:04 AM, Dylan Baker wrote: > Quoting Ian Romanick (2017-06-26 16:22:34) >> From: Ian Romanick >> >> v2: Use textwrap.dedent to make the source line a lot shorter. >> Shortening (?) the line was requested by Jason. >> >> Signed-off-by: Ian Romanick >> --- >> src/intel/genxml/gen_p

Re: [Mesa-dev] [PATCH shader-db] Drop Orbital Explorer shader.

On Mon 26 Jun 2017, Eero Tamminen wrote: > Hi, > > On 22.06.2017 23:14, Chad Versace wrote: > > On Thu 22 Jun 2017, Chad Versace wrote: > > > On Thu 22 Jun 2017, Kenneth Graunke wrote: > > > > The author eventually emailed me and said that he considers it a > > > > "finished experiment" and said t

Re: [Mesa-dev] [RFT PATCH 2/2] nv20: enable ARB_texture_border_clamp support

On 06/27/2017 02:59 AM, Timothy Arceri wrote: > Just curious. Can this extension be added to NV04 and NV10? As those are > the only drivers that don't currently support it. > > I have cards I could test those with, but don't have an NV20. I just sent out an updated series that I tested on NV20.

Re: [Mesa-dev] [PATCH mesa] build systems: uniformize git_sha1.h generation

On Tue, Jun 27, 2017 at 5:47 AM, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > Note: Autotools and SCons are tested, but Android isn't. > --- > git_sha1_gen.sh | 13 + > src/Makefile.am | 13 + > src/SConscript

Re: [Mesa-dev] [PATCH mesa] Fix khrplatform.h not installed if EGL is disabled.

On Tuesday, 2017-06-27 19:02:22 +0300, Andres Gomez wrote: > Sound like a good inclusion for -stable (?) It's extremely unlikely to break anything, so sure, go ahead :) > > On Mon, 2017-06-12 at 12:00 +0100, Eric Engestrom wrote: > > From: Eric Le Bihan > > > > KHR/khrplatform.h is required by

[Mesa-dev] [PATCH 2/3] nv20: Fix GL_CLAMP

From: Ian Romanick v2: Force T and R wrap modes to GL_CLAMP_TO_EDGE for 1D textures. This fixes a regression in tex1d-2dborder. The test uses a 1D texture but it provides S and T texture coordinates. Since the T wrap mode would (correctly) be set to GL_CLAMP, the texture would gradually blend (

[Mesa-dev] [PATCH 3/3] nv20: Enable ARB_texture_border_clamp

From: Ilia Mirkin Fixes quite a few 'texwrap [12]d border color only' tests on NV20 (10de:0201). All told, 40 more tests pass. Signed-off-by: Ilia Mirkin --- src/mesa/drivers/dri/nouveau/nv20_state_tex.c | 29 ++- 1 file changed, 28 insertions(+), 1 deletion(-) diff -

[Mesa-dev] [PATCH 1/3] mesa: GL_TEXTURE_BORDER_COLOR exists in OpenGL 1.0, so don't depend on GL_ARB_texture_border_clamp

From: Ian Romanick On NV20 (and probably also on earlier NV GPUs that lack GL_ARB_texture_border_clamp) fixes the following piglit tests: gl-1.0-beginend-coverage gltexparameter[if]{v,} push-pop-texture-state texwrap 1d texwrap 1d proj texwrap 2d proj texwrap formats All

Re: [Mesa-dev] [PATCH] winsys/radeon: only call pb_slabs_reclaim when slabs are actually used

Reviewed-by: Marek Olšák Marek On Tue, Jun 27, 2017 at 6:19 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100242 > Fixes: fb827c055cb1 ("winsys/radeon: enable buffer allocation from slabs") > Cc: mesa-sta...@lists.freedesktop.org >

Re: [Mesa-dev] [PATCH 01/12] genxml: Silence about a billion unused parameter warnings

Quoting Ian Romanick (2017-06-26 16:22:34) > From: Ian Romanick > > v2: Use textwrap.dedent to make the source line a lot shorter. > Shortening (?) the line was requested by Jason. > > Signed-off-by: Ian Romanick > --- > src/intel/genxml/gen_pack_header.py | 9 +++-- > 1 file changed, 7 in

Re: [Mesa-dev] [PATCH 2/2] radeonsi: move instance divisors into a constant buffer

On Tue, Jun 27, 2017 at 6:50 PM, Nicolai Hähnle wrote: > On 27.06.2017 17:07, Marek Olšák wrote: >> >> On Tue, Jun 27, 2017 at 9:22 AM, Nicolai Hähnle >> wrote: >>> >>> On 27.06.2017 02:14, Marek Olšák wrote: From: Marek Olšák Shader key size: 107 -> 47 >>> >>> >>> >>> N

[Mesa-dev] [PATCH 2/2] radeonsi: set COMPUTE_DISPATCH_INITIATOR.ORDER_MODE = 1

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 91a6a40..fba02fa 100644 --- a/src/gallium/drivers/radeonsi/si_compu

[Mesa-dev] [PATCH 1/2] radeonsi: use the DISPATCH packets to force COMPUTE_START_X/Y/Z = 0

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 65f3261..91a6a40 100644 --- a/src/gallium/drivers/radeons

Re: [Mesa-dev] [PATCH 3/3] radeonsi: use #pragma pack to pack si_shader_key

On 27.06.2017 17:02, Marek Olšák wrote: On Tue, Jun 27, 2017 at 10:02 AM, Nicolai Hähnle wrote: On 27.06.2017 00:15, Marek Olšák wrote: On Thu, Jun 22, 2017 at 9:19 AM, Nicolai Hähnle wrote: On 20.06.2017 20:00, Marek Olšák wrote: From: Marek Olšák sizeof(struct si_shader_key): B

Re: [Mesa-dev] [PATCH 2/2] radeonsi: move instance divisors into a constant buffer

On 27.06.2017 17:07, Marek Olšák wrote: On Tue, Jun 27, 2017 at 9:22 AM, Nicolai Hähnle wrote: On 27.06.2017 02:14, Marek Olšák wrote: From: Marek Olšák Shader key size: 107 -> 47 Nice improvement. Divisors of 0 and 1 are encoded in the shader key. Greater instance divisors are loaded

Re: [Mesa-dev] [PATCH] winsys/radeon: only call pb_slabs_reclaim when slabs are actually used

Good catch! Reviewed-by: Samuel Pitoiset On 06/27/2017 06:19 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100242 Fixes: fb827c055cb1 ("winsys/radeon: enable buffer allocation from slabs") Cc: mesa-sta...@lists.freedesktop.org --- src

Re: [Mesa-dev] [PATCH 1/2] svga: clamp device line width to at least 1 to fix HWv8 line stippling

It looks like we could want these 2 into -stable (?) On Thu, 2017-06-15 at 11:41 -0600, Brian Paul wrote: > The line stipple fallback code for virtual HW version 8 didn't work. > > With HW version 8, we were getting zero when querying the max line > widths (AA and non-AA). This means we were set

[Mesa-dev] [PATCH] winsys/radeon: only call pb_slabs_reclaim when slabs are actually used

From: Nicolai Hähnle Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100242 Fixes: fb827c055cb1 ("winsys/radeon: enable buffer allocation from slabs") Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deleti

  1   2   >