https://bugs.freedesktop.org/show_bug.cgi?id=101334
--- Comment #19 from John ---
Is there anything else I can provide to help?
Thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
m
On 06/22/2017 03:56 PM, Timothy Arceri wrote:
> ---
> src/mesa/main/uniform_query.cpp | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp
> index 1570770..9683fa8 100644
> --- a/src/mesa/main/uniform_quer
On 06/23/2017 04:58 AM, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> Pass the correct src coordinates to CopyTexSubImage()
> when creating the temporary texture, and also take care to adjust
> flipX/Y if the original src coordinates were flipped compared to
> the new temporary t
Thanks. It can only be reproduced with process isolation enabled in
piglit, which is not something I test.
Marek
On Fri, Jun 23, 2017 at 9:16 PM, Cherniak, Bruce
wrote:
>
>> On Jun 22, 2017, at 2:23 AM, Michel Dänzer wrote:
>>
>> On 13/06/17 01:55 AM, Marek Olšák wrote:
>>> From: Marek Olšák
>
Am 23.06.2017 19:26, schrieb Andy Furniss:
Am 23.06.2017 14:56, schrieb Dieter Nützel:
Hello Andy,
do you have a screenshot handy? I get maybe the same artifacts on
Unigine Valley (in the trees?) on my RX580 but without _this_ patch
applied. I have other 'new' one from 'Patchwork Mesa' in.
V
On 23/06/17 18:28, srol...@vmware.com wrote:
From: Roland Scheidegger
If lp_setup_bind_framebuffer() is never called, then setup fb x1/y1 was not
correctly initialized. This can happen if there's never a fb set - both
cso and llvmpipe would consider setting this with no cbufs and no zsbuf a
red
From: Ian Romanick
Apparently, the sampler has some sort of precision issues for
non-normalized texture coordinates with linear filtering. This caused
some small precision issues in scaled blits. Work around this by using
normalized coordinates. There is some extra work necessary because Gen6
Marek Olšák wrote:
Hi guys,
Can you please re-apply the problematic commit and test whether
R600_DEBUG=noce fixes the corruption?
It doesn't help valley, it does make the specific artifact I posted
disappear, but there are still others on different scenes.
> On Jun 22, 2017, at 2:23 AM, Michel Dänzer wrote:
>
> On 13/06/17 01:55 AM, Marek Olšák wrote:
>> From: Marek Olšák
>
> This broke piglit spec@glsl-1.20@execution@clipping@fixed-clip-enables
> on my Kaveri:
I am seeing this same regression on llvmpipe and swr renderers. Anyone else?
(bisec
https://bugs.freedesktop.org/show_bug.cgi?id=99467
--- Comment #27 from Mike Mestnik
---
I've created a PPA for getting doom running on Southern Island GPUs and have
included these two patches.
https://launchpad.net/~cheako/+archive/ubuntu/doom2016
The target release is Artful, but I plan on u
Hi guys,
Can you please re-apply the problematic commit and test whether
R600_DEBUG=noce fixes the corruption?
Thanks,
Marek
On Fri, Jun 23, 2017 at 7:47 PM, Marek Olšák wrote:
> I reverted the commit.
>
> Marek
>
> On Fri, Jun 23, 2017 at 7:26 PM, Andy Furniss wrote:
>> Dieter Nützel wrote:
>
Signed-off-by: Karol Herbst
Reviewed-by: Nicolai Hähnle
Reviewed-by: Roland Scheidegger
---
src/gallium/auxiliary/tgsi/tgsi_build.c| 1 +
src/gallium/include/pipe/p_shader_tokens.h | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_build.c
Signed-off-by: Karol Herbst
Reviewed-by: Nicolai Hähnle
---
src/gallium/auxiliary/tgsi/tgsi_dump.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_dump.c
b/src/gallium/auxiliary/tgsi/tgsi_dump.c
index f6eba7424b..b58e64511c 100644
--- a/src/gallium/auxili
Signed-off-by: Karol Herbst
Reviewed-by: Nicolai Hähnle
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
index 2d183004f0..38a8b8667c 100644
v4: initialize field with NULL
Signed-off-by: Karol Herbst
Reviewed-by: Pierre Moreau
---
src/gallium/drivers/nouveau/codegen/nv50_ir.cpp | 1 +
src/gallium/drivers/nouveau/codegen/nv50_ir.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir.cpp
v4: add comment about intermediate rounding step to MAD
Signed-off-by: Karol Herbst
Reviewed-by: Nicolai Hähnle
Reviewed-by: Roland Scheidegger
---
src/gallium/docs/source/tgsi.rst | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/gallium/docs/source/tgsi.rst
Signed-off-by: Karol Herbst
Reviewed-by: Pierre Moreau
---
src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp
b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp
index
Only implemented for glsl->tgsi. Other converters just set precise to 0.
v2: remove precise paramter from ureg_tex_insn and ureg_memory_insn
Signed-off-by: Karol Herbst
Reviewed-by: Nicolai Hähnle
---
src/gallium/auxiliary/tgsi/tgsi_build.c | 3 +++
src/gallium/auxiliary/tgsi/tgsi_ureg.
fixes
missrendering in TombRaider
KHR-GL44.gpu_shader5.precise_qualifier
KHR-GL45.gpu_shader5.precise_qualifier
v4: disable opt only for MAD, it's fine for SAD
Signed-off-by: Karol Herbst
Reviewed-by: Pierre Moreau
---
src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 5 ++
v2: use str_match_no_case to fix _SAT_PRECISE detection
v4: usd is_digit_alpha_underscore to match end of mods
Signed-off-by: Karol Herbst
Reviewed-by: Nicolai Hähnle
---
src/gallium/auxiliary/tgsi/tgsi_text.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git
Running Tomb Raider on Nouveau I found some flicker caused by ignoring precise
modifiers on variables inside Nouveau.
This series add precise/invariant handling to TGSI, which can be then used by
drivers to disable certain unsafe optimisations which may otherwise alter
calculations, which depend o
all subexpression inside an ir_assignment needs to be tagged as precise.
v2: make precise handling more global inside the visitor
Signed-off-by: Karol Herbst
Reviewed-by: Nicolai Hähnle
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 13 +
1 file changed, 13 insertions(+)
diff --
OpAtomicCompareExchangeWeak is only available in OpenCL, not Vulkan. As
such, we probably don't want to handle it yet as no one uses spirv_to_nir
for OpenCL. The assert on AtomicCompareExchange is, however, a bug we
should fix now.
--Jason
On Wed, Jun 21, 2017 at 8:59 AM, James Legg
wrote:
>
Samuel Iglesias Gonsálvez writes:
> On Thu, 2017-06-22 at 16:25 -0700, Francisco Jerez wrote:
>> Samuel Iglesias Gonsálvez writes:
>>
>> > Signed-off-by: Samuel Iglesias Gonsálvez
>> > ---
>> > src/intel/compiler/brw_eu_defines.h | 2 +
>> > src/intel/compiler/brw_shader.cpp
I reverted the commit.
Marek
On Fri, Jun 23, 2017 at 7:26 PM, Andy Furniss wrote:
> Dieter Nützel wrote:
>>
>> Addendum:
>>
>> Only wild shot in the dark...
>>
>> Could it be the LLVM (gfx9) thing, too?
>
>
> I think it's just this commit, with more confidence as sees it as well.
>
> I was a bit
From: Roland Scheidegger
If lp_setup_bind_framebuffer() is never called, then setup fb x1/y1 was not
correctly initialized. This can happen if there's never a fb set - both
cso and llvmpipe would consider setting this with no cbufs and no zsbuf a
redundant change and therefore it would never get
Dieter Nützel wrote:
Addendum:
Only wild shot in the dark...
Could it be the LLVM (gfx9) thing, too?
I think it's just this commit, with more confidence as sees it as well.
I was a bit off llvm head when I first saw it, updated to head in case
it changed things - hit the assert bug, found an
https://bugs.freedesktop.org/show_bug.cgi?id=99467
--- Comment #26 from Sven Arvidsson ---
The compiler patches have been merged:
https://cgit.freedesktop.org/mesa/mesa/commit/?id=1bd0acab21c250b263604a52ca6694941a6f02e0
Is further changes needed for radv?
--
You are receiving this mail becaus
Push this format to the pipe driver unchanged.
Signed-off-by: Lucas Stach
---
include/GL/internal/dri_interface.h | 1 +
src/gallium/state_trackers/dri/dri2.c | 7 +++
2 files changed, 8 insertions(+)
diff --git a/include/GL/internal/dri_interface.h
b/include/GL/internal/dri_interface.h
LGTM. Great find.
Reviewed-by: Jose Fonseca
From: srol...@vmware.com
Sent: Friday, June 23, 2017 16:33
To: Jose Fonseca; Brian Paul; mesa-dev@lists.freedesktop.org
Cc: Roland Scheidegger
Subject: [PATCH 2/2] llvmpipe: fix using 32bit rasterization mistakenly,
On 23 June 2017 at 16:58, Lucas Stach wrote:
> Am Freitag, den 23.06.2017, 16:54 +0100 schrieb Daniel Stone:
>> On 23 June 2017 at 16:36, Lucas Stach wrote:
>> > This trivially adds support for the image offset query, which is needed
>> > for the zwp_linux_dmabuf based EGL platform wayland implem
Am Freitag, den 23.06.2017, 16:54 +0100 schrieb Daniel Stone:
> On 23 June 2017 at 16:36, Lucas Stach wrote:
> > This trivially adds support for the image offset query, which is needed
> > for the zwp_linux_dmabuf based EGL platform wayland implementation.
> >
> > Signed-off-by: Lucas Stach
>
>
On 23 June 2017 at 16:36, Lucas Stach wrote:
> This trivially adds support for the image offset query, which is needed
> for the zwp_linux_dmabuf based EGL platform wayland implementation.
>
> Signed-off-by: Lucas Stach
So, whilst the patch is mostly good, it will break VC4 in the
meantime, as i
From: Alexandros Frantzis
Improve the surface format support in the Wayland Vulkan WSI, by
automating the matching between wl_drm and Vulkan formats. The same
mechanism can be used to improve format support in vulkan/wsi/x11
(in a future patchset).
Alexandros Frantzis (2):
vulkan/util: Introdu
From: Alexandros Frantzis
Introduce utilities to describe, find and compare Vulkan formats based
on their color component masks, taking into account system endianness.
---
src/vulkan/Makefile.sources | 2 +
src/vulkan/util/vk_format_util.c | 173 +++
sr
From: Alexandros Frantzis
Express the WL_DRM_FORMATs in terms of vk_format_util_spec and use the
format utilities to find compatible Vulkan formats.
---
src/vulkan/wsi/wsi_common_wayland.c | 178 ++--
1 file changed, 91 insertions(+), 87 deletions(-)
diff --git a
This fixes failures to import the scanout buffer with screen resolutions
that don't satisfy teh RS alignment restrictions, like 1680x1050.
Signed-off-by: Lucas Stach
---
src/gallium/drivers/etnaviv/etnaviv_resource.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --gi
The current way of importing the resource from renderonly after allocation
is opaque and is taking away control from the driver, which it needs in
order to implement more advanced scenarios, than the simple linear
scanout with matching stride alignments.
Signed-off-by: Lucas Stach
---
src/galliu
Hi all,
this series implements modifiers support for etnaviv. It is not meant for
merging yet, as it depends on unreleased libdrm changes and the renderonly
changes probably need some rework of the VC4 code, but I want to get
feedback before I go any further.
This series has been tested in variou
There is no point in keeping this indirection. Makes the code easier to
follow.
Signed-off-by: Lucas Stach
---
src/gallium/drivers/etnaviv/etnaviv_resource.c | 14 --
src/gallium/drivers/etnaviv/etnaviv_screen.c | 19 ---
src/gallium/drivers/etnaviv/etnaviv_screen.h
The layer stride information is used in various parts of the driver,
so it needs to be present regardless if the driver allocated the
buffer itself or merely imported it from an external source.
Signed-off-by: Lucas Stach
---
src/gallium/drivers/etnaviv/etnaviv_resource.c | 2 ++
1 file changed,
This reworks the logic in etna_update_sampler_source to select the
newest resource view for updating the texture view. This should make
the logic easier to follow and fixes texture updates from imported
dma-bufs.
Signed-off-by: Lucas Stach
---
src/gallium/drivers/etnaviv/etnaviv_texture.c | 23 +
This implements resource import with modifier, deriving the correct
internal layout from the modifier and constructing a render compatible
base resource if needed.
This removes the special cases for DDX and renderonly scanout allocated
buffers, as the linear modifier is enough to trigger correct h
If we import a dma-buf with a sampler/pixel pipe incompatible modifier,
the imported buffer will end up in an external resource view. As
resource_changed signals the change of the imported resource, we need
to update the external view seqno, instead of the base resource seqno.
Signed-off-by: Lucas
Simply advertise all supported modifiers, independent of the format.
Special formats, like compressed, which don't support all those modifiers
are already culled from the dmabuf format list, as we don't support
the render target binding for them.
Signed-off-by: Lucas Stach
---
src/gallium/driver
The resource struct is already allocated at this point and should be
free properly.
Signed-off-by: Lucas Stach
---
src/gallium/drivers/etnaviv/etnaviv_resource.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_resource.c
b/src/gallium
This allows to create buffers with a specific tiling layout, which is primarily
used by GBM to allocate the EGL back buffers with the correct tiling/modifier
for use with the scanout engines.
Signed-off-by: Lucas Stach
---
src/gallium/drivers/etnaviv/etnaviv_resource.c | 97 +
This allows the state trackers to know the tiling layout of the
resource and pass this through the various userspace protocols.
Signed-off-by: Lucas Stach
---
src/gallium/drivers/etnaviv/etnaviv_resource.c | 30 +-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --g
For both,
Reviewed-by: Brian Paul
On 06/23/2017 09:33 AM, srol...@vmware.com wrote:
From: Roland Scheidegger
We use the bounding box (triangle extents) to figure out if 32bit rasterization
could potentially overflow. However, we used the bounding box which already got
rounded up to 0 for ne
From: Alexandros Frantzis
Improve the surface format support in the Wayland Vulkan WSI, by
automating the matching between wl_drm and Vulkan formats. The same
mechanism can be used to improve format support in vulkan/wsi/x11
(in a future patchset).
Alexandros Frantzis (2):
vulkan/util: Introdu
This trivially adds support for the image offset query, which is needed
for the zwp_linux_dmabuf based EGL platform wayland implementation.
Signed-off-by: Lucas Stach
---
src/gallium/state_trackers/dri/dri2.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/gallium/state_trackers/dr
From: Roland Scheidegger
We use the bounding box (triangle extents) to figure out if 32bit rasterization
could potentially overflow. However, we used the bounding box which already got
rounded up to 0 for negative coords for this, which is incorrect, leading to
overflows and hence bogus rendering
From: Roland Scheidegger
This is pretty useful for debugging rasterization issues, so turn it on
based on DEBUG (the actual existence of the fields is also conditionalized
on DEBUG, lines fill it out the same too).
---
src/gallium/drivers/llvmpipe/lp_setup_tri.c | 2 +-
1 file changed, 1 inserti
On 2017-06-23 13:48, Andy Furniss wrote:
Marek Olšák wrote:
From: Marek Olšák
The kernel sort of does the same thing with fences.
v2: do emit partial flushes on SI
Bugzilla seems to be down currently so replying here.
On R9 285 with current agd5f 4.13-wip kernel I get some slight
artifacts
Addendum:
Only wild shot in the dark...
Could it be the LLVM (gfx9) thing, too?
In a rush.
Dieter
Am 23.06.2017 14:56, schrieb Dieter Nützel:
Hello Andy,
do you have a screenshot handy?
I get maybe the same artifacts on Unigine Valley (in the trees?) on my
RX580 but without _this_ patch app
Hello Andy,
do you have a screenshot handy?
I get maybe the same artifacts on Unigine Valley (in the trees?) on my
RX580 but without _this_ patch applied.
I have other 'new' one from 'Patchwork Mesa' in.
Dieter
Am 23.06.2017 13:48, schrieb Andy Furniss:
Marek Olšák wrote:
From: Marek Olšák
From: Ville Syrjälä
Pass the correct src coordinates to CopyTexSubImage()
when creating the temporary texture, and also take care to adjust
flipX/Y if the original src coordinates were flipped compared to
the new temporary texture src coordinates.
This fixes all the flip_src_x/y tests in
piglit.
Marek Olšák wrote:
From: Marek Olšák
The kernel sort of does the same thing with fences.
v2: do emit partial flushes on SI
Bugzilla seems to be down currently so replying here.
On R9 285 with current agd5f 4.13-wip kernel I get some slight
artifacts on Unigine Valley since this.
Valley is
On Thu, 2017-06-22 at 16:25 -0700, Francisco Jerez wrote:
> Samuel Iglesias Gonsálvez writes:
>
> > Signed-off-by: Samuel Iglesias Gonsálvez
> > ---
> > src/intel/compiler/brw_eu_defines.h | 2 +
> > src/intel/compiler/brw_shader.cpp| 5 +
> > src/intel/compiler/brw_vec
Hi Rob,
Is there any test other than _flatland_ on android with which we can confirm
explicit sync support can be verified?
Regards,
Yogesh.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-d
When using cmpswap on an image, it was being trunctated to
lvm.amdgcn.image.atomic.cmpswa, with the coords type missing entirely.
v2: Add stable CC
CC:
Reviewed-by: Grazvydas Ignotas
---
src/amd/common/ac_nir_to_llvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd
---
src/amd/common/ac_nir_to_llvm.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index 3a26668..b32a9f5 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++ b/src/amd/common/ac_nir_to_llvm.c
@@
We were hitting the
unreachable("Invalid image opcode")
near the end of vtn_handle_image when parsing SpvOpAtomicCompareExchange
and SpvOpAtomicCompareExchangeWeak opcodes.
v2: Add stable CC
CC:
---
src/compiler/spirv/spirv_to_nir.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a
Please ignore this patch, I have a better solution that will be
included in the v2 of the patch series.
Sam
On Thu, 2017-06-15 at 13:15 +0200, Samuel Iglesias Gonsálvez wrote:
> We emit scratch read/write to resolve reladdr and when moving
> varyings to scratch memory, however these instructions
Before resolving a rendertarget or a depth/stencil resource into a
texture, flush both the color cache and the depth cache together.
It is unclear whether this is necessary for the following stall to
work properly, or whether the depth flush just adds enough time
for the color cache flush to finis
On Thu, 2017-06-22 at 17:02 -0700, Francisco Jerez wrote:
> Samuel Iglesias Gonsálvez writes:
>
> > Hello,
> >
> > As mentioned in the patch series that implemented Ivybridge support
> > ARB_gpu_shader_fp64 [0], the only missing feature in that series
> > was
> > register spilling of 64-bit data
On 23.06.2017 01:16, Andres Gomez wrote:
Nicolai, this depends on:
https://cgit.freedesktop.org/mesa/mesa/commit/src/mesa?id=944455217b67cb524efef9e628baf09416db5524
Which didn't make it for -stable. Should we cherry-pick that too?
Ah right, forgot about that. No, just drop the patch for stabl
67 matches
Mail list logo
