Re: [Mesa-dev] [PATCH 5/9] i965: Move an 'i' declaration into its 'for' loop

2017-05-28 Thread Martin Peres
On 27/05/17 01:15, Chad Versace wrote: > In intel_update_dri2_buffers(). > Trivial cleanup. > --- > src/mesa/drivers/dri/i965/brw_context.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_context.c > b/src/mesa/drivers/dri/i965/brw_conte

Re: [Mesa-dev] [PATCH 2/9] i965/dri: Combine declaration and assignment in intelCreateBuffer

2017-05-28 Thread Martin Peres
On 27/05/17 01:15, Chad Versace wrote: > Trivial cleanup. > --- > src/mesa/drivers/dri/i965/intel_screen.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_screen.c > b/src/mesa/drivers/dri/i965/intel_screen.c > index 5de6f18b84..24123e79

Re: [Mesa-dev] [PATCH 0/9] i965: A few tiny trivial cleanups

2017-05-28 Thread Tapani Pälli
LGTM Reviewed-by: Tapani Pälli On 05/27/2017 01:15 AM, Chad Versace wrote: I was hacking on the i965/DRI glue, and on brw_surface_formats.c, and I found several little cleanups to make the code nicer. All these patches are super small. Chad Versace (9): i965/dri: Rewrite comment for intelCr

Re: [Mesa-dev] [PATCH 0/2] egl/android: A few trivial cleanups

2017-05-28 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 05/27/2017 01:09 AM, Chad Versace wrote: Chad Versace (2): egl/android: Align channel masks in HAL_PIXEL_FORMAT table egl/android: Drop unused 'format' param in get_back_bo() src/egl/drivers/dri2/platform_android.c | 12 ++-- 1 file changed, 6 inse

Re: [Mesa-dev] soft fp64 on evergreen

2017-05-28 Thread Dave Airlie
>>> I also notice some really large times in the GLSL->TGSI pass copy >>> propogation on mul/div tests with matrices, tests take a fair while to >>> complete. >>> >> >> Unrelated to this I have noticed on some profiles when using nvc0 >> that the GLSL->TGSI passes are quite painful on compile times

Re: [Mesa-dev] soft fp64 on evergreen

2017-05-28 Thread Dave Airlie
On 26 May 2017 at 20:43, tournier.elie wrote: > Hi, > > First of all sorry for the mess in my repo. ;) > > On 26 May 2017 at 11:16, Thomas Helland wrote: >> 2017-05-26 8:13 GMT+02:00 Dave Airlie : >>> Hi Elie, >>> >>> Thanks for the fp64 work. >>> >>> I've pulled the latest branch from your repo

[Mesa-dev] [Bug 101223] Mesa fails to build with clang

2017-05-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101223 Bug ID: 101223 Summary: Mesa fails to build with clang Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority

Re: [Mesa-dev] [PATCH] svga: fix git_sha1.h include path in Android.mk

2017-05-28 Thread Mauro Rossi
2017-05-28 21:02 GMT+02:00 Rob Herring : > On Sun, May 28, 2017 at 1:31 PM, Mauro Rossi > wrote: > > > > > > 2017-05-28 16:46 GMT+02:00 Rob Herring : > >> > >> On Fri, May 26, 2017 at 10:15 AM, Mauro Rossi > >> wrote: > >> > Fixes the following building error: > >> > > >> > external/mesa/src/gal

Re: [Mesa-dev] [PATCH] svga: fix git_sha1.h include path in Android.mk

2017-05-28 Thread Mauro Rossi
2017-05-28 21:02 GMT+02:00 Rob Herring : > On Sun, May 28, 2017 at 1:31 PM, Mauro Rossi > wrote: > > > > > > 2017-05-28 16:46 GMT+02:00 Rob Herring : > >> > >> On Fri, May 26, 2017 at 10:15 AM, Mauro Rossi > >> wrote: > >> > Fixes the following building error: > >> > > >> > external/mesa/src/gal

[Mesa-dev] [PATCH] radv: Reserve space for descriptor and push constant user SGPR setting.

2017-05-28 Thread Bas Nieuwenhuizen
flush_compute_state doesn't reserve a large chunk, so these need their own reservation. Signed-off-by: Bas Nieuwenhuizen Fixes: f4e499ec791 "radv: add initial non-conformant radv vulkan driver" --- src/amd/vulkan/radv_cmd_buffer.c | 8 1 file changed, 8 insertions(+) diff --git a/src/

Re: [Mesa-dev] [PATCH] svga: fix git_sha1.h include path in Android.mk

2017-05-28 Thread Rob Herring
On Sun, May 28, 2017 at 1:31 PM, Mauro Rossi wrote: > > > 2017-05-28 16:46 GMT+02:00 Rob Herring : >> >> On Fri, May 26, 2017 at 10:15 AM, Mauro Rossi >> wrote: >> > Fixes the following building error: >> > >> > external/mesa/src/gallium/drivers/svga/svga_screen.c:26:10: >> > fatal error: 'git_sh

Re: [Mesa-dev] [PATCH] svga: fix git_sha1.h include path in Android.mk

2017-05-28 Thread Mauro Rossi
2017-05-28 16:46 GMT+02:00 Rob Herring : > On Fri, May 26, 2017 at 10:15 AM, Mauro Rossi > wrote: > > Fixes the following building error: > > > > external/mesa/src/gallium/drivers/svga/svga_screen.c:26:10: > > fatal error: 'git_sha1.h' file not found > > ^ > > 1 error generated. > > ---

[Mesa-dev] [PATCH] glsl: Change the parser to use the string buffer

2017-05-28 Thread Thomas Helland
V2: Pointed out by Timothy running the CI - Fix pp.c reralloc size issue and comment V3 - Use vprintf instead of printf where we should - Fixes failing make-check tests --- src/compiler/glsl/glcpp/glcpp-parse.y | 85 ++- src/compiler/glsl/glcpp/glcpp.h

Re: [Mesa-dev] [PATCH] glsl: Change the parser to use the string buffer

2017-05-28 Thread Thomas Helland
2017-05-28 15:19 GMT+02:00 Thomas Helland : > V2: Failure found by Timothy running it through CI >- Fix pp.c reralloc size issue and comment There is still something here that doesn't work as intended. Some tests are failing I'll report once I find the cause. > --- > src/compiler/glsl/glcpp

[Mesa-dev] [Bug 101199] nouveau_screen.c: undefined reference to `nouveau_drm_del'

2017-05-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101199 --- Comment #5 from Ilia Mirkin --- (In reply to Andrey from comment #4) > This is an issue with the Mesa build system. The configure script should > choose right libdrm from PKG_CONFIG_PATH specified. The configure script does pick the right l

[Mesa-dev] [PATCH V3] util: Add a string buffer implementation

2017-05-28 Thread Thomas Helland
Based on Vladislav Egorovs work on the preprocessor, but split out to a util functionality that should be universal. Setup, teardown, memory handling and general layout is modeled around the hash_table and the set, to make it familiar for everyone. A notable change is that this implementation is a

Re: [Mesa-dev] [PATCH] svga: fix git_sha1.h include path in Android.mk

2017-05-28 Thread Rob Herring
On Fri, May 26, 2017 at 10:15 AM, Mauro Rossi wrote: > Fixes the following building error: > > external/mesa/src/gallium/drivers/svga/svga_screen.c:26:10: > fatal error: 'git_sha1.h' file not found > ^ > 1 error generated. > --- > src/gallium/drivers/svga/Android.mk | 4 +++- > 1 file ch

[Mesa-dev] [Bug 101214] xdriinfo and libglvnd Screen 0: not direct rendering capable

2017-05-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101214 LoneVVolf changed: What|Removed |Added CC||emil.l.veli...@gmail.com -- You are receiv

[Mesa-dev] [Bug 101214] xdriinfo and libglvnd Screen 0: not direct rendering capable

2017-05-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101214 LoneVVolf changed: What|Removed |Added CC||jwrdego...@fedoraproject.or

Re: [Mesa-dev] [PATCH 3/5] r600: remove libamd_common dependency

2017-05-28 Thread Rob Herring
On Fri, May 26, 2017 at 10:32 AM, Emil Velikov wrote: > From: Emil Velikov > > Seemingly nothing in r600 depends on it any more. > > This is the second step to unwrapping the amdgpu dependency out of r600. > > Reported-by: udovdh on #dri-devel > Cc: Nicolai Hähnle > Cc: Marek Olšák > Signed-off

Re: [Mesa-dev] [PATCH 0/9][RFC] GLSL preprocessor/parser improvements

2017-05-28 Thread Thomas Helland
2017-05-22 20:02 GMT+02:00 Thomas Helland : > 2017-05-22 3:41 GMT+02:00 Timothy Arceri : >> I suspect you forgot to test with a debug build, there is issues with the >> string buffer changes somewhere. >> >> ralloc.c:203: reralloc_size: Assertion `ralloc_parent(ptr) == ctx' failed. >> >> #0 0x000

[Mesa-dev] [PATCH] glsl: Change the parser to use the string buffer

2017-05-28 Thread Thomas Helland
V2: Failure found by Timothy running it through CI - Fix pp.c reralloc size issue and comment --- src/compiler/glsl/glcpp/glcpp-parse.y | 85 ++- src/compiler/glsl/glcpp/glcpp.h | 8 ++-- src/compiler/glsl/glcpp/pp.c | 39 +++- 3 files

[Mesa-dev] [PATCH] util: Add a string buffer implementation

2017-05-28 Thread Thomas Helland
Based on Vladislav Egorovs work on the preprocessor, but split out to a util functionality that should be universal. Setup, teardown, memory handling and general layout is modeled around the hash_table and the set, to make it familiar for everyone. A notable change is that this implementation is a