Re: [Mesa-dev] [PATCH 16/16] i965: Enable tiled memcpy tex image path on non-LLC

2017-05-24 Thread Chris Wilson
On Wed, May 24, 2017 at 01:04:58PM -0700, Matt Turner wrote: I found the performance of the Y-detiling to be atrocious into WC (due to the access pattern jumping 64 bytes and so neatly sabotaging the WCB). I did a very rough sketch for using a temporary page to detile into: https://cgit.freedeskt

Re: [Mesa-dev] [PATCH 12/16] i965: Use write-combine mappings where available

2017-05-24 Thread Chris Wilson
On Wed, May 24, 2017 at 01:04:54PM -0700, Matt Turner wrote: > Write-combine mappings give much better performance on writes than > uncached access through the GTT. > --- > src/mesa/drivers/dri/i965/brw_bufmgr.c | 69 > ++ > 1 file changed, 69 insertions(+) > > di

Re: [Mesa-dev] [PATCH 11/16] i965: Replace brw_bo_map_unsynchronized with MAP_ASYNC

2017-05-24 Thread Chris Wilson
On Wed, May 24, 2017 at 01:04:53PM -0700, Matt Turner wrote: > This way we can let brw_bo_map() choose the best mapping type. > > Part of the patch inlines map_gtt() into brw_bo_map_gtt() (and removes > map_gtt()). brw_bo_map_gtt() just wrapped map_gtt() with locking and a > call to set_domain().

Re: [Mesa-dev] [PATCH 07/16] i965: Rename brw_bo_map() -> brw_bo_map_cpu()

2017-05-24 Thread Chris Wilson
On Wed, May 24, 2017 at 01:04:49PM -0700, Matt Turner wrote: > I'm going to make a new function named brw_bo_map() in a later patch > that is responsible for choosing the mapping type, so this patch clears > the way. map_cpu was chosen when we only had the two types of cpu (wb, linear) or gtt (wc,

Re: [Mesa-dev] [PATCH 5/5] mesa: add KHR_no_error support for glBindImageTextures()

2017-05-24 Thread Timothy Arceri
On 24/05/17 07:45, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_multi_bind.xml | 2 +- src/mesa/main/shaderimage.c | 43 +++ src/mesa/main/shaderimage.h | 4 3 files changed, 48 insertions(+), 1

[Mesa-dev] [PATCH 2/2] glsl: disable array splitting for AoA

2017-05-24 Thread Timothy Arceri
While it produces functioning code the pass creates worse code for arrays of arrays. See the comment added in this patch for more detail. --- src/compiler/glsl/opt_array_splitting.cpp | 26 ++ 1 file changed, 26 insertions(+) diff --git a/src/compiler/glsl/opt_array_splitt

[Mesa-dev] [PATCH 1/2] nir: NULL check lower_copies_to_load_store()

2017-05-24 Thread Timothy Arceri
Allows us to disable array spliting for arrays of arrays without regressing tests such as: ES31-CTS.functional.shaders.arrays_of_arrays.return.explicit.struct_3x1x3_fragment --- src/compiler/nir/nir_lower_vars_to_ssa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compil

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

2017-05-24 Thread Jean Hertel
From: Emil Velikov Sended: 24 May 2017 04:53 >I was looking at it yesterday, and should have most of it done some time today. > >The TOC "...release notes" solution (as illustrated by the 17.0.4 >ones) seem fine, so until we come with a better idea I'll just go with >it. > >-Emil OK, I will u

Re: [Mesa-dev] [PATCH 00/16] i965: Write-combine mappings and other performance improvements for non-LLC

2017-05-24 Thread Kenneth Graunke
On Wednesday, May 24, 2017 1:04:42 PM PDT Matt Turner wrote: > The series aims to improve performance on non-LLC platforms like Braswell and > Broxton. > > Unsynchronized mappings were not actually unsynchronized on non-LLC platforms, > hurting Unigine Valley performance quite a lot. That's fixed.

[Mesa-dev] [PATCH] mapi: Enable assembly language API acceleration for PPC64LE

2017-05-24 Thread Ben Crocker
Signed-off-by: Ben Crocker --- configure.ac | 12 +++ src/mapi/Makefile.sources| 3 + src/mapi/entry.c | 12 ++- src/mapi/entry_ppc64le_tls.h | 150 +++ src/mapi/entry_ppc64le_tsd.h | 208 +++

Re: [Mesa-dev] Mesa 17.1.1 release candidate

2017-05-24 Thread Chuck Atkins
> > We don't do release tarballs for the stable RC. Although it has been > asked a few times in the past. > There's nothing stopping us though - will check if we can start doing so. > With most codes, I would normally be happy with just using the git tag but most of the issues I run into tend to b

[Mesa-dev] [PATCH 11/16] i965: Replace brw_bo_map_unsynchronized with MAP_ASYNC

2017-05-24 Thread Matt Turner
This way we can let brw_bo_map() choose the best mapping type. Part of the patch inlines map_gtt() into brw_bo_map_gtt() (and removes map_gtt()). brw_bo_map_gtt() just wrapped map_gtt() with locking and a call to set_domain(). map_gtt() is called by brw_bo_map_unsynchronized() to avoid the call to

[Mesa-dev] [PATCH 15/16] i965: Enable tiled memcpy get tex image path on non-LLC

2017-05-24 Thread Matt Turner
--- src/mesa/drivers/dri/i965/intel_tex_image.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c b/src/mesa/drivers/dri/i965/intel_tex_image.c index 59d5fa4..75b5d6e 100644 --- a/src/mesa/drivers/dri/i965/intel_tex_image.c +++ b/src

[Mesa-dev] [PATCH 14/16] i965: Enable tiled memcpy pixel read path on non-LLC

2017-05-24 Thread Matt Turner
--- src/mesa/drivers/dri/i965/intel_pixel_read.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_pixel_read.c b/src/mesa/drivers/dri/i965/intel_pixel_read.c index eb3f66f..5085683 100644 --- a/src/mesa/drivers/dri/i965/intel_pixel_read.c +++ b

[Mesa-dev] [PATCH 12/16] i965: Use write-combine mappings where available

2017-05-24 Thread Matt Turner
Write-combine mappings give much better performance on writes than uncached access through the GTT. --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 69 ++ 1 file changed, 69 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 10/16] i965: Add and use brw_bo_map()

2017-05-24 Thread Matt Turner
We can encapsulate the logic for choosing the mapping type. This will also help when we add WC mappings. --- src/mesa/drivers/dri/i965/brw_bufmgr.c| 30 +-- src/mesa/drivers/dri/i965/brw_bufmgr.h| 5 ++-- src/mesa/drivers/dri/i965/brw_performance_query.

[Mesa-dev] [PATCH 05/16] i965: Pass the map-mode along to intel_mipmap_tree_map_raw()

2017-05-24 Thread Matt Turner
From: Chris Wilson Since we can distinguish when mapping between READ and WRITE, we can pass along the map mode to avoid stalls and flushes where possible. Reviewed-by: Kenneth Graunke Reviewed-by: Matt Turner --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 29 +++

[Mesa-dev] [PATCH 09/16] i965: Drop MAP_READ from some write-only mappings

2017-05-24 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_performance_query.c | 2 +- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 +- src/mesa/drivers/dri/i965/intel_screen.c | 2 +- src/mesa/drivers/dri/i965/intel_tex_subimage.c| 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a

[Mesa-dev] [PATCH 16/16] i965: Enable tiled memcpy tex image path on non-LLC

2017-05-24 Thread Matt Turner
--- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c b/src/mesa/drivers/dri/i965/intel_tex_subimage.c index 7acb3d3..2aead41 100644 --- a/src/mesa/drivers/dri/i965/intel_tex_subimage

[Mesa-dev] [PATCH 02/16] i965: Remove brw_bo's virtual member

2017-05-24 Thread Matt Turner
Just return the map from brw_map_bo_* --- src/mesa/drivers/dri/i965/brw_bufmgr.c| 49 +-- src/mesa/drivers/dri/i965/brw_bufmgr.h| 19 ++--- src/mesa/drivers/dri/i965/brw_context.h | 2 + src/mesa/drivers/dri/i965/brw_performance_query.c |

[Mesa-dev] [PATCH 13/16] i965: Explicitly disallow tiled memcpy path on Gen4 with swizzling.

2017-05-24 Thread Matt Turner
From: Chris Wilson The manual detiling paths are not prepared to handle Gen4-G45 with swizzling enabled, so explicitly disable them. (They're already disabled because these platforms don't have LLC but the next patch will enable this path). Reviewed-by: Matt Turner --- src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH 01/16] i965: Remove unused brw_bo_map__* functions

2017-05-24 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_bufmgr.c | 105 - src/mesa/drivers/dri/i965/brw_bufmgr.h | 4 -- 2 files changed, 109 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c index 2f17934..6ea6978 100644 --- a/

[Mesa-dev] [PATCH 08/16] i965: Pass flags to brw_bo_map_*

2017-05-24 Thread Matt Turner
brw_bo_map_cpu() took a write_enable arg, but it wasn't always clear whether we were also planning to read from the buffer. I kept everything semantically identical by passing only MAP_READ or MAP_READ | MAP_WRITE depending on the write_enable argument. The other flags are not used yet, but MAP_AS

[Mesa-dev] [PATCH 03/16] i965: Remove unused 'use_resource_streamer' field

2017-05-24 Thread Matt Turner
Missing in the resource streamer removal of commit 951f56cd43bc. --- src/mesa/drivers/dri/i965/brw_context.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h index b99d2a9..f902265 100644 --- a/src/mesa/drivers/dr

[Mesa-dev] [PATCH 07/16] i965: Rename brw_bo_map() -> brw_bo_map_cpu()

2017-05-24 Thread Matt Turner
I'm going to make a new function named brw_bo_map() in a later patch that is responsible for choosing the mapping type, so this patch clears the way. --- src/mesa/drivers/dri/i965/brw_bufmgr.c| 9 + src/mesa/drivers/dri/i965/brw_bufmgr.h| 4 ++-- src/mesa/drivers/dr

[Mesa-dev] [PATCH 04/16] i965: Add a cache_coherent field to brw_bo

2017-05-24 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_bufmgr.c| 1 + src/mesa/drivers/dri/i965/brw_bufmgr.h| 5 + src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 +++ 3 files changed, 9 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c i

[Mesa-dev] [PATCH 06/16] i965: Rename *_virtual -> map_*

2017-05-24 Thread Matt Turner
I think these are better names, and it reduces the delta between upstream and Chris Wilson's brw-batch branch. --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 56 +- src/mesa/drivers/dri/i965/brw_bufmgr.h | 6 ++-- 2 files changed, 31 insertions(+), 31 deletions(-) d

[Mesa-dev] [PATCH 00/16] i965: Write-combine mappings and other performance improvements for non-LLC

2017-05-24 Thread Matt Turner
The series aims to improve performance on non-LLC platforms like Braswell and Broxton. Unsynchronized mappings were not actually unsynchronized on non-LLC platforms, hurting Unigine Valley performance quite a lot. That's fixed. We also start using write-combining, a feature available since Linux v

[Mesa-dev] [PATCH v4 1/4] gallium: Add TGSI shader token for ARB_post_depth_coverage

2017-05-24 Thread Lyude
Signed-off-by: Lyude Changes since v2: - Add missing string to tgsi_strings.c Changes since v3: - Reorder patch to be before we add the cap for this, since we can't have a cap for a TGSI property that doesn't exist yet - Document the actual property seperately from the cap (whoops) Signed-off-

[Mesa-dev] [PATCH v4 3/4] st/mesa: Add support for ARB_post_depth_coverage

2017-05-24 Thread Lyude
Changes since v3: - Add logic to the GL plumbing to implicitly enable early_fragment_tests for the fragment shader when post_depth_coverage is enabled. Signed-off-by: Lyude --- src/mesa/state_tracker/st_extensions.c | 1 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 7 ++- 2 files cha

[Mesa-dev] [PATCH v4 4/4] nv50/ir, nvc0: Add support for ARB_post_depth_coverage

2017-05-24 Thread Lyude
This adds support for the GL_arb_post_depth_coverage extension on nvc0 GPUs, GM200+ and up. Similar to what we do for early fragment testing, we only call the method for updating the post depth coverage status for fragment programs when it changes. Signed-off-by: Lyude --- docs/relnotes/17.2.0.h

[Mesa-dev] [PATCH v4 2/4] gallium: Add a cap to check if the driver supports ARB_post_depth_coverage

2017-05-24 Thread Lyude
Signed-off-by: Lyude Changes since v1: - Correct documentation in screen.rst for new cap Changes since v2: - Fix bogus documentation Changes since v3: - Reorder patch to be after we add the TGSI property, since we can't have a cap for a property that doesn't exist yet. - Document the cap sepera

[Mesa-dev] [PATCH v4 0/4] ARB_post_depth_coverage for nvc0

2017-05-24 Thread Lyude
This is a patch series to add support for ARB_post_depth_coverage in nvc0, along with the required bits for gallium, tgsi, and mesa's state tracker. Lyude (4): gallium: Add TGSI shader token for ARB_post_depth_coverage gallium: Add a cap to check if the driver supports ARB_post_depth_cover

Re: [Mesa-dev] [PATCH v3 3/4] st/mesa: Add support for ARB_post_depth_coverage

2017-05-24 Thread Marek Olšák
On Wed, May 24, 2017 at 2:52 AM, Lyude wrote: > Signed-off-by: Lyude > --- > src/mesa/state_tracker/st_extensions.c | 1 + > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 +- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/state_tracker/st_extensions.c > b/s

Re: [Mesa-dev] [PATCH] drirc: set force_glsl_version for Alchemist's Awakening

2017-05-24 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, May 24, 2017 at 1:01 AM, Samuel Pitoiset wrote: > A bunch of shaders are missing a version directive. This fixes > the following compilation error and allows the game to launch. > > 0:43(28): error: cannot initialize uniform typeColor in GLSL 1.10 (GLSL 1.

[Mesa-dev] [Bug 99467] [radv] DOOM 2016 + wine. Green screen everywhere (but can be started)

2017-05-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99467 --- Comment #25 from Pavel Bordukov --- (In reply to Marcin Bujar from comment #24) > FYI on archlinux if you apply the following two patches to mesa 17.1 and > recompile with llvm 4.0 from official repo the game works perfectly, no > green scree

[Mesa-dev] [PATCH] radv: Flip CCW in tess.

2017-05-24 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_pipeline.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 3282652ddd4..01303d90da5 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd/vulkan/radv_pipeline.c @

[Mesa-dev] [PATCH] spirv: Flip the tessellation winding order

2017-05-24 Thread Jason Ekstrand
It's not SPIR-V that's backwards from GLSL, it's Vulkan that's backwards from GL. Let's make NIR consistent with the source language and do the flipping inside the Vulkan driver instead. Cc: Kenneth Graunke Cc: Dave Airlie --- src/compiler/spirv/spirv_to_nir.c | 9 ++--- src/intel/vulkan/

[Mesa-dev] [PATCH] radv: Also signal fence if vkAcquireNextImageKHR returns VK_SUBOPTIMAL_KHR.

2017-05-24 Thread Bas Nieuwenhuizen
It is a successful return. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_wsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_wsi.c b/src/amd/vulkan/radv_wsi.c index 3a8617fd8fa..5e866126b91 100644 --- a/src/amd/vulkan/radv_wsi.c +++ b/src/amd/

Re: [Mesa-dev] [PATCH] configure.ac: update libdrm amdgpu version requirement

2017-05-24 Thread Alex Deucher
On Wed, May 24, 2017 at 12:05 PM, Leo Liu wrote: > VCN decode has a new interface, and that depends on the latest libdrm > > Signed-off-by: Leo Liu Reviewed-by: Alex Deucher > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.

Re: [Mesa-dev] [PATCH 06/24] i965/cnl: Add gen10 specific function declarations

2017-05-24 Thread Anuj Phogat
On Mon, May 22, 2017 at 11:23 AM, Anuj Phogat wrote: > On Mon, May 22, 2017 at 10:07 AM, Rafael Antognolli > wrote: >> On Fri, May 12, 2017 at 04:38:10PM -0700, Anuj Phogat wrote: >>> These declarations will help the code start compiling >>> once we wire up the makefiles for gen10. Later patches

Re: [Mesa-dev] [PATCH V2] intel/compiler: Make use of IS_INTEGER_DWORD macro

2017-05-24 Thread Anuj Phogat
On Wed, May 24, 2017 at 10:06 AM, Matt Turner wrote: > On Wed, May 24, 2017 at 9:21 AM, Anuj Phogat wrote: >> This patch makes non-functional changes. >> >> V2: Rename IS_DWORD to IS_INTEGER_DWORD > > > To be honest, I don't like IS_DWORD/IS_INTEGER_DWORD -- for the same > reason Alejandro noted.

Re: [Mesa-dev] [PATCH V2] intel/compiler: Make use of IS_INTEGER_DWORD macro

2017-05-24 Thread Matt Turner
On Wed, May 24, 2017 at 9:21 AM, Anuj Phogat wrote: > This patch makes non-functional changes. > > V2: Rename IS_DWORD to IS_INTEGER_DWORD To be honest, I don't like IS_DWORD/IS_INTEGER_DWORD -- for the same reason Alejandro noted. It's not clear what it means exactly, and in most cases it would

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

2017-05-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #25 from Ben Crocker --- (In reply to Ray Strode from comment #24) ... > Yea, I guess thinking about it more, even if we can get scalar fetch to work > with sufficient twiddling, that twiddling probably introduces extra > operations

[Mesa-dev] [PATCH V2] intel/compiler: Make use of IS_INTEGER_DWORD macro

2017-05-24 Thread Anuj Phogat
This patch makes non-functional changes. V2: Rename IS_DWORD to IS_INTEGER_DWORD Signed-off-by: Anuj Phogat --- src/intel/compiler/brw_eu_defines.h | 3 +++ src/intel/compiler/brw_eu_emit.c | 24 +++- src/intel/compiler/brw_fs.cpp

Re: [Mesa-dev] [PATCH] intel/compiler: Make use of IS_DWORD macro

2017-05-24 Thread Anuj Phogat
On Tue, May 23, 2017 at 10:59 PM, Alejandro Piñeiro wrote: > On 23/05/17 22:51, Anuj Phogat wrote: >> This patch makes non-functional changes. >> >> Signed-off-by: Anuj Phogat >> --- >> src/intel/compiler/brw_eu_defines.h | 3 +++ >> src/intel/compiler/brw_eu_emit.c

[Mesa-dev] [PATCH] configure.ac: update libdrm amdgpu version requirement

2017-05-24 Thread Leo Liu
VCN decode has a new interface, and that depends on the latest libdrm Signed-off-by: Leo Liu --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 1da67f5..b57be07 100644 --- a/configure.ac +++ b/configure.ac @@ -74,7 +74,7 @@ AC_S

Re: [Mesa-dev] [RFC PATCH 52/65] radeonsi: implement ARB_bindless_texture

2017-05-24 Thread Samuel Pitoiset
On 05/24/2017 01:25 PM, Marek Olšák wrote: On Fri, May 19, 2017 at 6:52 PM, Samuel Pitoiset wrote: This implements the Gallium interface. Decompression of resident textures/images will follow in the next patches. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descripto

Re: [Mesa-dev] [PATCH v3 1/4] gallium: Add a cap to check if the driver supports ARB_post_depth_coverage

2017-05-24 Thread Ilia Mirkin
On Tue, May 23, 2017 at 8:52 PM, Lyude wrote: > Signed-off-by: Lyude > > Changes since v1: > - Correct documentation in screen.rst for new cap > Changes since v2: > - Fix bogus documentation > > Signed-off-by: Lyude > --- > src/gallium/docs/source/screen.rst | 3 +++ > src/galli

Re: [Mesa-dev] [RFC PATCH 05/65] mesa: refuse to update sampler parameters when a handle is allocated

2017-05-24 Thread Samuel Pitoiset
On 05/24/2017 12:20 PM, Nicolai Hähnle wrote: On 19.05.2017 18:52, Samuel Pitoiset wrote: The ARB_bindless_texture spec says: "The error INVALID_OPERATION is generated by SamplerParameter* if identifies a sampler object referenced by one or more texture handles." Signed-off-by

Re: [Mesa-dev] [PATCH] configure.ac: Add --with-wayland-scanner-path

2017-05-24 Thread Emil Velikov
Hi Jussi, On 23 May 2017 at 09:13, Jussi Kukkonen wrote: > Modify wayland-scanner lookup: Use the path given by pkg-config > but offer an option to override the path with > "--with-wayland-scanner-path=PATH". The latter is useful for > cross-compile situations. > > AC_PATH_PROG is no longer used

Re: [Mesa-dev] [RFC PATCH 47/65] st/mesa: enable ARB_bindless_texture

2017-05-24 Thread Nicolai Hähnle
Patches 44 & 47: Reviewed-by: Nicolai Hähnle On 19.05.2017 18:52, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extens

Re: [Mesa-dev] [RFC PATCH 25/65] gallium: add ARB_bindless_texture interface

2017-05-24 Thread Nicolai Hähnle
On 19.05.2017 18:52, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/gallium/include/pipe/p_context.h | 16 1 file changed, 16 insertions(+) diff --git a/src/gallium/include/pipe/p_context.h b/src/gallium/include/pipe/p_context.h index 4b75386a65..83eb1c9b08 1

Re: [Mesa-dev] [RFC PATCH 43/65] st/mesa: add infrastructure for storing bound texture/image handles

2017-05-24 Thread Nicolai Hähnle
On 19.05.2017 18:52, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_context.c | 2 + src/mesa/state_tracker/st_context.h | 11 ++ src/mesa/state_tracker/st_texture.c | 77 + src/mesa/state_tracker/st_texture.h |

Re: [Mesa-dev] [RFC PATCH 33/65] st/glsl_to_tgsi: add support for bindless images

2017-05-24 Thread Nicolai Hähnle
On 19.05.2017 18:52, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 78 -- 1 file changed, 63 insertions(+), 15 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/s

Re: [Mesa-dev] [RFC PATCH 16/65] glsl: add ir_variable::is_bindless()

2017-05-24 Thread Nicolai Hähnle
On 19.05.2017 18:52, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/ir.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/compiler/glsl/ir.h b/src/compiler/glsl/ir.h index 91e665cc1b..c816a327c1 100644 --- a/src/compiler/glsl/ir.h +++ b/src/com

Re: [Mesa-dev] [PATCH v3 1/4] gallium: Add a cap to check if the driver supports ARB_post_depth_coverage

2017-05-24 Thread Marek Olšák
On Wed, May 24, 2017 at 2:52 AM, Lyude wrote: > Signed-off-by: Lyude > > Changes since v1: > - Correct documentation in screen.rst for new cap > Changes since v2: > - Fix bogus documentation > > Signed-off-by: Lyude > --- > src/gallium/docs/source/screen.rst | 3 +++ > src/galli

Re: [Mesa-dev] [Intel-gfx] [RFC v3] drm/i915: Select engines via class and instance in execbuffer2

2017-05-24 Thread Tvrtko Ursulin
On 18/05/2017 18:00, Chris Wilson wrote: On Thu, May 18, 2017 at 05:20:38PM +0100, Tvrtko Ursulin wrote: On 18/05/2017 14:37, Chris Wilson wrote: On Thu, May 18, 2017 at 02:06:35PM +0100, Tvrtko Ursulin wrote: But this problem in general can also be solved separately from class-instance add

Re: [Mesa-dev] [RFC PATCH 52/65] radeonsi: implement ARB_bindless_texture

2017-05-24 Thread Marek Olšák
On Fri, May 19, 2017 at 6:52 PM, Samuel Pitoiset wrote: > This implements the Gallium interface. Decompression of resident > textures/images will follow in the next patches. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 340 >

Re: [Mesa-dev] Mesa 17.1.1 release candidate

2017-05-24 Thread Emil Velikov
On 22 May 2017 at 19:45, Chuck Atkins wrote: >> The candidate for the Mesa 17.1.1 is now available. > > > Excellent! > > >> From build perspective - SWR now ships it's final generated header, thus >> Python/mako is no longer required. > > > Just what I was looking for, thanks! > > Is a source tarb

Re: [Mesa-dev] [RFC PATCH 45/65] st/mesa: do not release sampler views for resident textures

2017-05-24 Thread Marek Olšák
On Wed, May 24, 2017 at 1:06 PM, Marek Olšák wrote: > On Wed, May 24, 2017 at 10:50 AM, Samuel Pitoiset > wrote: >> >> >> On 05/23/2017 10:11 PM, Marek Olšák wrote: >>> >>> I don't think this change is necessary. Releasing sampler views >>> doesn't release textures. >> >> >> This issued has been

Re: [Mesa-dev] [RFC PATCH 45/65] st/mesa: do not release sampler views for resident textures

2017-05-24 Thread Marek Olšák
On Wed, May 24, 2017 at 10:50 AM, Samuel Pitoiset wrote: > > > On 05/23/2017 10:11 PM, Marek Olšák wrote: >> >> I don't think this change is necessary. Releasing sampler views >> doesn't release textures. > > > This issued has been reported by Feral directly. It happens in the following > scenario

Re: [Mesa-dev] [RFC PATCH 21/65] mesa: associate uniform storage to bindless samplers/images

2017-05-24 Thread Nicolai Hähnle
Patch 3, 4, 7-21: Reviewed-by: Nicolai Hähnle On 19.05.2017 18:52, Samuel Pitoiset wrote: When a bindless sampler/image is bound to a texture/image unit, we have to overwrite the constant value by the resident handle directly in the constant buffer before the next draw. One solution is to ke

Re: [Mesa-dev] [RFC PATCH 22/65] mesa: handle bindless uniforms bound to texture/image units

2017-05-24 Thread Nicolai Hähnle
Something else just occurred to me. Do you have a test case where an array of bindless sampler uniforms is set at once with glUniform1iv? That should have a 32- vs. 64-bit mismatch when the user-supplied array is directly memcpy()'d to uni->storage. I think you need to fix that mismatch. On th

Re: [Mesa-dev] [RFC PATCH 23/65] mesa: get rid of a workaround for bindless in _mesa_get_uniform()

2017-05-24 Thread Nicolai Hähnle
On 19.05.2017 18:52, Samuel Pitoiset wrote: The ARB_bindless_texture spec says: "When a sampler or image uniform's value is queried via any of the GetUniform* commands, the returned value will reflect the most recently set value through either UniformHandle* or Uniform1i*, con

Re: [Mesa-dev] [RFC PATCH 22/65] mesa: handle bindless uniforms bound to texture/image units

2017-05-24 Thread Nicolai Hähnle
On 19.05.2017 18:52, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/uniform_query.cpp | 122 ++-- 1 file changed, 116 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp inde

Re: [Mesa-dev] [PATCH v13 07/36] egl: implement eglQueryDmaBufModifiersEXT

2017-05-24 Thread Emil Velikov
On 23 May 2017 at 18:02, Daniel Stone wrote: > Hi Varad, > > On 23 May 2017 at 14:19, Varad Gautam wrote: >> On Mon, 2017-05-22 at 14:03 +0100, Emil Velikov wrote: >>> On 19 May 2017 at 10:37, Daniel Stone wrote: >>> > + if (external_only != NULL) { >>> > + for (i = 0; i < *count && i < m

Re: [Mesa-dev] [RFC PATCH 11/65] mesa: add infrastructure for bindless samplers/images bound to units

2017-05-24 Thread Nicolai Hähnle
On 24.05.2017 12:28, Nicolai Hähnle wrote: On 19.05.2017 18:52, Samuel Pitoiset wrote: Yes, ARB_bindless_texture allows to do this. In other words, in a situation like: layout (bindless_sampler) uniform sampler2D tex; The 'tex' sampler uniform can be either set with glUniform1() (old-style bou

Re: [Mesa-dev] [RFC PATCH 11/65] mesa: add infrastructure for bindless samplers/images bound to units

2017-05-24 Thread Nicolai Hähnle
On 19.05.2017 18:52, Samuel Pitoiset wrote: Yes, ARB_bindless_texture allows to do this. In other words, in a situation like: layout (bindless_sampler) uniform sampler2D tex; The 'tex' sampler uniform can be either set with glUniform1() (old-style bound samplers) or with glUniformHandleui() (re

Re: [Mesa-dev] [RFC PATCH 06/65] mesa: refuse to update tex parameters when a handle is allocated

2017-05-24 Thread Nicolai Hähnle
On 19.05.2017 18:52, Samuel Pitoiset wrote: The ARB_bindless_texture spec says: "The ARB_bindless_texture spec says: "The error INVALID_OPERATION is generated by TexImage*, CopyTexImage*, CompressedTexImage*, TexBuffer*, TexParameter*, as well as other functions defined in ter

Re: [Mesa-dev] [RFC PATCH 05/65] mesa: refuse to update sampler parameters when a handle is allocated

2017-05-24 Thread Nicolai Hähnle
On 19.05.2017 18:52, Samuel Pitoiset wrote: The ARB_bindless_texture spec says: "The error INVALID_OPERATION is generated by SamplerParameter* if identifies a sampler object referenced by one or more texture handles." Signed-off-by: Samuel Pitoiset --- src/mesa/main/samplerobj

Re: [Mesa-dev] [RFC PATCH 02/65] mesa: implement ARB_bindless_texture

2017-05-24 Thread Nicolai Hähnle
[snip] +static GLuint64 +get_texture_handle(struct gl_context *ctx, struct gl_texture_object *texObj, + struct gl_sampler_object *sampObj) +{ + struct gl_texture_handle_object *handleObj; + struct hash_entry *entry; + GLuint64 handle; + + handleObj = CALLOC_STRUCT(gl_t

Re: [Mesa-dev] [PATCH v3 01/15] st/dri: refactor multi-planar YUV import path

2017-05-24 Thread Varad Gautam
Hi Lucas, On Tue, May 23, 2017 at 9:10 PM, Lucas Stach wrote: > Hi Varad, > > Am Dienstag, den 23.05.2017, 14:40 +0530 schrieb Varad Gautam: >> Hi Lucas, >> >> On Mon, May 22, 2017 at 11:16 PM, Lucas Stach wrote: >> > Am Mittwoch, den 10.05.2017, 23:15 +0530 schrieb Varad Gautam: >> >> From: Var

Re: [Mesa-dev] [RFC PATCH 00/65] ARB_bindless_texture for RadeonSI

2017-05-24 Thread Samuel Pitoiset
On 05/24/2017 12:02 AM, Marek Olšák wrote: On Tue, May 23, 2017 at 12:33 AM, Dieter Nützel wrote: Hello Samuel, running this on radeonsi/RX580. Didn't saw better numbers for Wine/TS2017 (TrainSimulator 2017) ever before. But didn't feaguered if it (can) use bindless (with Wine/stagging). Do

Re: [Mesa-dev] [RFC PATCH 46/65] st/mesa: disable per-context seamless cubemap when using texture handles

2017-05-24 Thread Samuel Pitoiset
On 05/23/2017 10:21 PM, Marek Olšák wrote: What if a texture is used both as bindless and non-bindless? Wouldn't HandleAllocated be true all the time? Instead perhaps st_convert_sampler needs to know whether the current use is bindless, not whether there is an existing handle somewhere in the c

Re: [Mesa-dev] [RFC PATCH 45/65] st/mesa: do not release sampler views for resident textures

2017-05-24 Thread Samuel Pitoiset
On 05/23/2017 10:11 PM, Marek Olšák wrote: I don't think this change is necessary. Releasing sampler views doesn't release textures. This issued has been reported by Feral directly. It happens in the following scenario: 1) create a texture 2) get a texture handle 3) make it resident 4) bin

Re: [Mesa-dev] [PATCH] configure.ac: Add --with-wayland-scanner-path

2017-05-24 Thread Jussi Kukkonen
On 23 May 2017 at 11:13, Jussi Kukkonen wrote: > > Modify wayland-scanner lookup: Use the path given by pkg-config > but offer an option to override the path with > "--with-wayland-scanner-path=PATH". The latter is useful for > cross-compile situations. > > AC_PATH_PROG is no longer used (if the s

[Mesa-dev] [Bug 86195] Lightswork video editor segfaults

2017-05-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86195 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 99467] [radv] DOOM 2016 + wine. Green screen everywhere (but can be started)

2017-05-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99467 --- Comment #24 from Marcin --- FYI on archlinux if you apply the following two patches to mesa 17.1 and recompile with llvm 4.0 from official repo the game works perfectly, no green screen or black textures: https://github.com/airlied/mesa/comm

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

2017-05-24 Thread Emil Velikov
On 23 May 2017 at 11:50, Jean Hertel wrote: > Hello, > > Any update on this? > Is someone validating the github repository? > I was looking at it yesterday, and should have most of it done some time today. The TOC "...release notes" solution (as illustrated by the 17.0.4 ones) seem fine, so until

Re: [Mesa-dev] [PATCH 2/2] gallium: Add renderonly-based support for pl111+vc4.

2017-05-24 Thread Christian Gmeiner
2017-05-11 1:06 GMT+02:00 Eric Anholt : > This follows the model of imx (display) and etnaviv (render): pl111 is a > display-only device, so when asked to do GL for it, we see if we have a > vc4 renderer, make the vc4 screen, and have vc4 call back to pl111 to do > scanout allocations. > > The diff

Re: [Mesa-dev] [PATCH 1/2] etnaviv: Only use renderonly_get_handle for GEM handles.

2017-05-24 Thread Christian Gmeiner
2017-05-11 1:06 GMT+02:00 Eric Anholt : > Note that for requests for Prime FDs or flink names, we return handles to > the etanviv BO, not the scanout BO. This is at least better than previous > behavior of returning GEM handles for a request for an FD or flink name. > > And add an assert that rend