Re: [Mesa-dev] [PATCH 1/3] aubinator: fix double free

2017-05-23 Thread Iago Toral
All 3 patches are: Reviewed-by: Iago Toral Quiroga On Wed, 2017-05-24 at 02:19 +0100, Lionel Landwerlin wrote: > Free previously allocated filename outside the for loop. > > CID: 1405014 > Signed-off-by: Lionel Landwerlin > --- >  src/intel/tools/aubinator_error_decode.c | 2 +- >  1 file chang

Re: [Mesa-dev] [PATCH] intel/compiler: Make use of IS_DWORD macro

2017-05-23 Thread Alejandro Piñeiro
On 23/05/17 22:51, Anuj Phogat wrote: > This patch makes non-functional changes. > > Signed-off-by: Anuj Phogat > --- > src/intel/compiler/brw_eu_defines.h | 3 +++ > src/intel/compiler/brw_eu_emit.c | 24 > +++- > src/intel/compiler/brw_fs.cpp

[Mesa-dev] [PATCH 2/3] genxml: Add Gen9 CACHE_MODE_1 definitons.

2017-05-23 Thread Kenneth Graunke
These were already in gen8.xml but not gen9.xml. There are a few new fields and a couple that have changed. These are all documented in the Skylake PRM, Volume 2c Command Reference: Registers, Part 1. --- src/intel/genxml/gen9.xml | 30 ++ 1 file changed, 30 insertion

[Mesa-dev] [PATCH 3/3] anv: Port over CACHE_MODE_1 optimization fix enables from brw.

2017-05-23 Thread Kenneth Graunke
Ben and I haven't observed these to help anything, but they enable hardware optimizations for particular cases. It's probably best to enable them ahead of time, before we run into such a case. --- src/intel/vulkan/genX_state.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src

[Mesa-dev] [PATCH 1/3] i965: Set the "Float Blend Optimization Enable" bit on Gen9+.

2017-05-23 Thread Kenneth Graunke
This is woefully undocumented. It's some kind of optimization that avoids unnecessary render target reads when blending with a floating point render target, using independent alpha blending modes. The internal documentation indicates that this bit exists on Cherryview as well, but the other drive

[Mesa-dev] [PATCH 3/3] aubinator: report error on unknown device id

2017-05-23 Thread Lionel Landwerlin
Since we're going to stop aubinator without a valid device id, better report an error. This also silences a Coverity warning. CID: 1405004 Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator_error_decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/t

[Mesa-dev] [PATCH 2/3] aubinator: be consistent on exit code

2017-05-23 Thread Lionel Landwerlin
We're using both exit(1) & exit(EXIT_FAILURE), settle for one, same for success. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator_error_decode.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/intel/tools/aubinator_error_decode.c b/src/intel/tool

[Mesa-dev] [PATCH 0/3] Aubinator cleanups

2017-05-23 Thread Lionel Landwerlin
Hi, (hopefully right list this time) Mark kindly pointed me at some coverity issues in aubinator. Here are some cleanups. Cheers, Lionel Landwerlin (3): aubinator: fix double free aubinator: be consistent on exit code aubinator: report error on unknown device id src/intel/tools/aubinator

[Mesa-dev] [PATCH 1/3] aubinator: fix double free

2017-05-23 Thread Lionel Landwerlin
Free previously allocated filename outside the for loop. CID: 1405014 Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator_error_decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/aubinator_error_decode.c b/src/intel/tools/aubinator_error_deco

Re: [Mesa-dev] [PATCH 2/5] i965: use mmap64 for Android

2017-05-23 Thread Rob Herring
On Tue, May 23, 2017 at 5:12 PM, Ian Romanick wrote: > On 05/23/2017 12:49 PM, Rob Herring wrote: >> Simplify the handling of mmap for Android by using mmap64 instead. mmap64 >> may have not existed for Android when this was written, but it's been >> around since 2013. >> >> Signed-off-by: Rob Her

[Mesa-dev] [PATCH v3 3/4] st/mesa: Add support for ARB_post_depth_coverage

2017-05-23 Thread Lyude
Signed-off-by: Lyude --- src/mesa/state_tracker/st_extensions.c | 1 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index f3db702..7674156 1

[Mesa-dev] [PATCH v3 4/4] nv50/ir, nvc0: Add support for ARB_post_depth_coverage

2017-05-23 Thread Lyude
This adds support for the GL_arb_post_depth_coverage extension on nvc0 GPUs, GM200+ and up. Similar to what we do for early fragment testing, we only call the method for updating the post depth coverage status for fragment programs when it changes. Signed-off-by: Lyude --- docs/relnotes/17.2.0.h

[Mesa-dev] [PATCH v3 1/4] gallium: Add a cap to check if the driver supports ARB_post_depth_coverage

2017-05-23 Thread Lyude
Signed-off-by: Lyude Changes since v1: - Correct documentation in screen.rst for new cap Changes since v2: - Fix bogus documentation Signed-off-by: Lyude --- src/gallium/docs/source/screen.rst | 3 +++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + src/gallium/drivers/

[Mesa-dev] [PATCH v3 2/4] gallium: Add TGSI shader token for ARB_post_depth_coverage

2017-05-23 Thread Lyude
Signed-off-by: Lyude Changes since v2: - Add missing string to tgsi_strings.c Signed-off-by: Lyude --- src/gallium/auxiliary/tgsi/tgsi_strings.c | 1 + src/gallium/include/pipe/p_shader_tokens.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_strings.c b

[Mesa-dev] [PATCH v3 0/4] ARB_post_depth_coverage for nvc0

2017-05-23 Thread Lyude
This is a patch series to add support for ARB_post_depth_coverage in nvc0, along with the required bits for gallium, tgsi, and mesa's state tracker. Lyude (4): gallium: Add a cap to check if the driver supports ARB_post_depth_coverage gallium: Add TGSI shader token for ARB_post_depth_cover

Re: [Mesa-dev] [PATCH 1/2] mesa: remove redundant modulus operation

2017-05-23 Thread Timothy Arceri
On 24/05/17 10:25, Timothy Arceri wrote: > On 24/05/17 08:07, Ian Romanick wrote On 05/23/2017 05:01 AM, Timothy Arceri wrote: The if check above means we can only get here if size is less than 4. --- src/mesa/program/prog_parameter.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

Re: [Mesa-dev] [PATCH 1/2] mesa: remove redundant modulus operation

2017-05-23 Thread Timothy Arceri
On 24/05/17 08:07, Ian Romanick wrote: On 05/23/2017 05:01 AM, Timothy Arceri wrote: The if check above means we can only get here if size is less than 4. --- src/mesa/program/prog_parameter.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/prog_par

Re: [Mesa-dev] [PATCH] Revert "gallium: remove unused PIPE_CC_GCC_VERSION"

2017-05-23 Thread Timothy Arceri
On 24/05/17 02:25, Brian Paul wrote: On 05/22/2017 05:30 PM, Timothy Arceri wrote: Hi Brain, It's been 7 months since this landed. Why not just send this out with those patches when you are ready to upsteam? Coming soon... This is a simple revert and I don't think I really need an R-b, but

Re: [Mesa-dev] [RFC] ARB_gl_spirv and NIR backend for radeonsi

2017-05-23 Thread Timothy Arceri
On 23/05/17 22:18, Brian Paul wrote: On 05/22/2017 07:15 PM, Timothy Arceri wrote: On 23/05/17 10:44, Marek Olšák wrote: On Tue, May 23, 2017 at 12:07 AM, Timothy Arceri wrote: On 23/05/17 05:02, Marek Olšák wrote: On Sun, May 21, 2017 at 12:48 PM, Nicolai Hähnle wrote: Hi all, I've bee

[Mesa-dev] [PATCH 1/7] Revert "gallium: remove unused PIPE_CC_GCC_VERSION"

2017-05-23 Thread Brian Paul
This reverts commit e60928f4c4bd4484821d83f2b16a910ea9f5f9d9. PIPE_CC_GCC_VERSION is used by some of our in-house code which hasn't been upstreamed yet. --- src/gallium/include/pipe/p_config.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_config.h b/src/gallium/i

[Mesa-dev] [PATCH 6/7] svga: init local vars to silence uninitialized use warnings

2017-05-23 Thread Brian Paul
Reviewed-by: Sinclair Yeh --- src/gallium/drivers/svga/svga_msg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/svga/svga_msg.c b/src/gallium/drivers/svga/svga_msg.c index e3f72b6..e0346de 100755 --- a/src/gallium/drivers/svga/svga_msg.c +++ b/src/

[Mesa-dev] [PATCH 7/7] svga: move logging initialization code into new function

2017-05-23 Thread Brian Paul
Plus a few other minor clean-ups. Reviewed-by: Sinclair Yeh --- src/gallium/drivers/svga/svga_screen.c | 53 -- src/gallium/drivers/svga/svga_screen.h | 2 -- 2 files changed, 31 insertions(+), 24 deletions(-) diff --git a/src/gallium/drivers/svga/svga_screen.c

[Mesa-dev] [PATCH 5/7] svga: log the process command line to the vmware.log file

2017-05-23 Thread Brian Paul
This is useful for Piglit when thousands of tests are run and we want to determine which test triggered a device error. v2: only log command line info if the new SVGA_EXTRA_LOGGING env var is set Reviewed-by: Charmaine Lee --- docs/envvars.html | 2 ++ src/gallium/drivers/

[Mesa-dev] [PATCH 4/7] svga: Limit svga message capability to newer compilers

2017-05-23 Thread Brian Paul
From: Sinclair Yeh The assembly code used by the SVGA message feature doesn't build properly with older compilers, so limit it to only gcc 5.3.0 and newer. Also modified the stubs to avoid "unused variable" warnings. Reviewed-by: Charmaine Lee Reviewed-by: Brian Paul --- src/gallium/drivers/

[Mesa-dev] [PATCH 2/7] svga: Add the ability to log messages to vmware.log on the host.

2017-05-23 Thread Brian Paul
From: Sinclair Yeh For now this capability only exists in the SVGA driver but can be exported later if other modules, e.g. winsys, wants to use it for logging. Reviewed-by: Brian Paul --- src/gallium/drivers/svga/Makefile.sources | 2 + src/gallium/drivers/svga/svga_msg.c | 411 +++

[Mesa-dev] [PATCH 3/7] svga: Fix MSVC build.

2017-05-23 Thread Brian Paul
This let us compile the code with MSVC, but it no-ops the log function. Reviewed-by: Jose Fonseca --- src/gallium/drivers/svga/svga_msg.c | 34 -- 1 file changed, 32 insertions(+), 2 deletions(-) mode change 100644 => 100755 src/gallium/drivers/svga/svga_msg.c d

[Mesa-dev] [PATCH V2] intel/isl: Add the maximum surface size limit

2017-05-23 Thread Anuj Phogat
V2: Use 2^31 bytes (2GB) surface size limit on pre-gen9 and 2^38 bytes for gen9+. Signed-off-by: Anuj Phogat --- src/intel/isl/isl.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 32aa698..812d106 100644 --- a/src/i

Re: [Mesa-dev] [PATCH 11/16] anv: Stop setting BO flags in bo_init_new

2017-05-23 Thread Jason Ekstrand
On Tue, May 23, 2017 at 2:35 PM, Nanley Chery wrote: > On Thu, May 18, 2017 at 02:00:58PM -0700, Jason Ekstrand wrote: > > The idea behind doing this was to make it easier to set various flags. > > However, we have enough custom flag settings floating around the driver > > that this is more of a

[Mesa-dev] [PATCH] drirc: set force_glsl_version for Alchemist's Awakening

2017-05-23 Thread Samuel Pitoiset
A bunch of shaders are missing a version directive. This fixes the following compilation error and allows the game to launch. 0:43(28): error: cannot initialize uniform typeColor in GLSL 1.10 (GLSL 1.20 required) Signed-off-by: Samuel Pitoiset --- src/mesa/drivers/dri/common/drirc | 4 1

Re: [Mesa-dev] [PATCH 05/16] anv/image: Get rid of the memset(aux, 0, sizeof(aux)) hack

2017-05-23 Thread Nanley Chery
On Thu, May 18, 2017 at 02:00:52PM -0700, Jason Ekstrand wrote: > Up until now, we've been memsetting the auxiliary surface to 0 at > BindImageMemory time to ensure that it is properly initialized. > However, this isn't correct because apps are allowed to freely alias > memory between different ima

Re: [Mesa-dev] [PATCH v2 4/16] anv: Handle color layout transitions from the UNINITIALIZED layout

2017-05-23 Thread Nanley Chery
On Tue, May 23, 2017 at 03:34:31PM -0700, Jason Ekstrand wrote: > This causes dEQP-VK.api.copy_and_blit.resolve_image.partial.* to start > failing due to test bugs. See CL 1031 for a test fix. > --- > src/intel/vulkan/anv_blorp.c | 57 > ++ > src/intel/v

[Mesa-dev] [Bug 101088] `gallium: remove pipe_index_buffer and set_index_buffer` causes glitches and crash in gallium nine

2017-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101088 Axel Davy changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH 15/16] anv: Require vertex buffers to come from a 32-bit heap

2017-05-23 Thread Nanley Chery
On Thu, May 18, 2017 at 02:01:02PM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_device.c | 12 > 1 file changed, 12 insertions(+) > Patches 9 and 15 are Reviewed-by: Nanley Chery > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index 8eed

[Mesa-dev] [PATCH v2 4/16] anv: Handle color layout transitions from the UNINITIALIZED layout

2017-05-23 Thread Jason Ekstrand
This causes dEQP-VK.api.copy_and_blit.resolve_image.partial.* to start failing due to test bugs. See CL 1031 for a test fix. --- src/intel/vulkan/anv_blorp.c | 57 ++ src/intel/vulkan/anv_private.h | 6 src/intel/vulkan/genX_cmd_buffer.c | 37 ++

Re: [Mesa-dev] [PATCH 12/16] anv: Make supports_48bit_addresses a heap property

2017-05-23 Thread Nanley Chery
On Thu, May 18, 2017 at 02:00:59PM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_device.c | 6 -- > src/intel/vulkan/anv_private.h | 11 ++- > 2 files changed, 14 insertions(+), 3 deletions(-) > This patch is Reviewed-by: Nanley Chery > diff --git a/src/intel/vulkan/a

Re: [Mesa-dev] [PATCH 14/16] anv: Advertise both 32-bit and 48-bit heaps when we have enough memory

2017-05-23 Thread Nanley Chery
On Fri, May 19, 2017 at 04:12:37PM -0700, Jason Ekstrand wrote: > On Fri, May 19, 2017 at 2:53 PM, Gustaw Smolarczyk > wrote: > > > 2017-05-18 23:01 GMT+02:00 Jason Ekstrand : > > > --- > > > src/intel/vulkan/anv_device.c | 42 ++ > > ++-- > > > 1 file changed

Re: [Mesa-dev] [PATCH 14/16] anv: Advertise both 32-bit and 48-bit heaps when we have enough memory

2017-05-23 Thread Nanley Chery
On Fri, May 19, 2017 at 10:53:12AM -0700, Jason Ekstrand wrote: > On Thu, May 18, 2017 at 2:01 PM, Jason Ekstrand > wrote: > > > --- > > src/intel/vulkan/anv_device.c | 42 ++ > > ++-- > > 1 file changed, 36 insertions(+), 6 deletions(-) > > > > diff --git a/s

Re: [Mesa-dev] [PATCH 3/5] Android: generate an error if building on Android 4.4 or earlier

2017-05-23 Thread Ian Romanick
It seems like this patch should go first in the series. With that changed, this patch is Reviewed-by: Ian Romanick On 05/23/2017 12:49 PM, Rob Herring wrote: > Android 4.4 or earlier is no longer supported, so exit with an error if we > try building on it. > > Signed-off-by: Rob Herring > ---

Re: [Mesa-dev] [PATCH 5/5] util: remove unneeded Android ifdef from ralloc.c

2017-05-23 Thread Ian Romanick
As long as it still builds, this change looks good to me. Reviewed-by: Ian Romanick On 05/23/2017 12:49 PM, Rob Herring wrote: > SIZE_MAX has been defined in stdint.h on Android since 2013, so this ifdef > is no longer needed. > > Signed-off-by: Rob Herring > --- > src/util/ralloc.c | 5 -

Re: [Mesa-dev] [PATCH 2/5] i965: use mmap64 for Android

2017-05-23 Thread Ian Romanick
On 05/23/2017 12:49 PM, Rob Herring wrote: > Simplify the handling of mmap for Android by using mmap64 instead. mmap64 > may have not existed for Android when this was written, but it's been > around since 2013. > > Signed-off-by: Rob Herring > --- > src/mesa/drivers/dri/i965/libdrm_macros.h | 1

Re: [Mesa-dev] [PATCH 2/2] intel/isl: Add the maximum surface size limit

2017-05-23 Thread Anuj Phogat
On Tue, May 23, 2017 at 2:37 PM, Anuj Phogat wrote: > This limit was first introduced in Skylake PRM. But looking at > the huge limit of 2^38 bytes (~275 GB), I think it is safe to > apply it to all the previous generations as well. My assumption is wrong. Pre-gen9 has a limit of 2 GB for surface

Re: [Mesa-dev] [PATCH 1/2] mesa: remove redundant modulus operation

2017-05-23 Thread Ian Romanick
On 05/23/2017 05:01 AM, Timothy Arceri wrote: > The if check above means we can only get here if size is less than 4. > --- > src/mesa/program/prog_parameter.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/program/prog_parameter.c > b/src/mesa/program/pro

Re: [Mesa-dev] [RFC PATCH 00/65] ARB_bindless_texture for RadeonSI

2017-05-23 Thread Marek Olšák
On Tue, May 23, 2017 at 12:33 AM, Dieter Nützel wrote: > Hello Samuel, > > running this on radeonsi/RX580. > Didn't saw better numbers for Wine/TS2017 (TrainSimulator 2017) ever before. > But didn't feaguered if it (can) use bindless (with Wine/stagging). Do we > have a knob to toggle bindless on

Re: [Mesa-dev] [PATCH 13/16] anv: Refactor memory type setup

2017-05-23 Thread Nanley Chery
On Thu, May 18, 2017 at 02:01:00PM -0700, Jason Ekstrand wrote: > This makes us walk over the heaps one at a time and add the types for > LLC and !LLC to each heap. > --- > src/intel/vulkan/anv_device.c | 76 > +++ > 1 file changed, 40 insertions(+), 36 del

Re: [Mesa-dev] [PATCH v2 1/4] gallium: Add a cap to check if the driver supports ARB_post_depth_coverage

2017-05-23 Thread Marek Olšák
On Tue, May 23, 2017 at 9:10 PM, Lyude wrote: > Signed-off-by: Lyude > > Changes since v1: > - Correct documentation in screen.rst for new cap > > Signed-off-by: Lyude > --- > src/gallium/docs/source/screen.rst | 2 ++ > src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + > s

[Mesa-dev] [PATCH 2/5] mesa: add set_image_binding() helper

2017-05-23 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/shaderimage.c | 70 ++--- 1 file changed, 34 insertions(+), 36 deletions(-) diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c index 0b8cfe2468a..ad9fdb0e9bc 100644 --- a/src/mesa/main/sh

[Mesa-dev] [PATCH 3/5] mesa: add bind_image_texture() helper

2017-05-23 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/shaderimage.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c index ad9fdb0e9bc..19011d80b9e 100644 --- a/src/mesa/main/shaderimage.c +++ b/src/m

[Mesa-dev] [PATCH 5/5] mesa: add KHR_no_error support for glBindImageTextures()

2017-05-23 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_multi_bind.xml | 2 +- src/mesa/main/shaderimage.c | 43 +++ src/mesa/main/shaderimage.h | 4 3 files changed, 48 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/ARB_

[Mesa-dev] [PATCH 4/5] mesa: add KHR_no_error support for glBindImageTexture()

2017-05-23 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_shader_image_load_store.xml | 2 +- src/mesa/main/shaderimage.c| 15 +++ src/mesa/main/shaderimage.h| 5 + 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/src

[Mesa-dev] [PATCH 1/5] mesa: remove unused layered parameter from validate_bind_image_texture()

2017-05-23 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/shaderimage.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c index 45b72c9b4ff..0b8cfe2468a 100644 --- a/src/mesa/main/shaderimage.c +++ b/src/mesa/main/shaderim

[Mesa-dev] [PATCH 2/2] intel/isl: Add the maximum surface size limit

2017-05-23 Thread Anuj Phogat
This limit was first introduced in Skylake PRM. But looking at the huge limit of 2^38 bytes (~275 GB), I think it is safe to apply it to all the previous generations as well. Signed-off-by: Anuj Phogat --- src/intel/isl/isl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/isl/i

[Mesa-dev] [PATCH 1/2] intel/isl: Use uint64_t to store total surface size

2017-05-23 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/intel/isl/isl.c | 3 ++- src/intel/isl/isl.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index f89f351..32aa698 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -1362,7 +1362,8 @@

Re: [Mesa-dev] [PATCH 2/2] mesa: remove unrequired double calc

2017-05-23 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Tue, May 23, 2017 at 2:01 PM, Timothy Arceri wrote: > type_size() will already handle this correctly for us. > --- > src/mesa/program/ir_to_mesa.cpp | 12 ++-- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/src/mes

[Mesa-dev] [PATCH V2] i965: Rename brw_format variable names to isl_format

2017-05-23 Thread Anuj Phogat
This patch makes non functional changes. Renaming is just to make the code more readable. V2: update the types to "enum isl_format" Signed-off-by: Anuj Phogat Cc: Jason Ekstrand --- src/mesa/drivers/dri/i965/brw_context.c | 5 +++-- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 6

Re: [Mesa-dev] [PATCH 11/16] anv: Stop setting BO flags in bo_init_new

2017-05-23 Thread Nanley Chery
On Thu, May 18, 2017 at 02:00:58PM -0700, Jason Ekstrand wrote: > The idea behind doing this was to make it easier to set various flags. > However, we have enough custom flag settings floating around the driver > that this is more of a nuisance than a help. > --- > src/intel/vulkan/anv_allocator.c

Re: [Mesa-dev] [PATCH 10/16] anv: Set image memory types based on the type count

2017-05-23 Thread Nanley Chery
On Thu, May 18, 2017 at 02:00:57PM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_device.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > This patch is Reviewed-by: Nanley Chery > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index 8bf

[Mesa-dev] [PATCH] intel/compiler: Make use of IS_DWORD macro

2017-05-23 Thread Anuj Phogat
This patch makes non-functional changes. Signed-off-by: Anuj Phogat --- src/intel/compiler/brw_eu_defines.h | 3 +++ src/intel/compiler/brw_eu_emit.c | 24 +++- src/intel/compiler/brw_fs.cpp| 3 +-- src/intel/compiler/brw_fs_

Re: [Mesa-dev] [PATCH 3/4] st/mesa: Add support for ARB_post_depth_coverage

2017-05-23 Thread Lyude Paul
Oh! Okay, I went to go add implicit enablement of early fragment tests with this extension into mesa's GL plumbing and it looks like I misspoke, we do already have something for this, from src/compiler/glsl/linker.cpp: static void link_fs_inout_layout_qualifiers(struct gl_shader_program *prog,    

Re: [Mesa-dev] [PATCH] winsys/amdgpu: align VA allocations to fragment size

2017-05-23 Thread Marek Olšák
On Tue, May 23, 2017 at 6:43 PM, Christian König wrote: > From: Christian König > > BOs larger than the minimum fragment size should have their VA > alignet to at least the fragment size for optimal performance. > > Signed-off-by: Christian König > --- > src/amd/common/ac_gpu_info.c

Re: [Mesa-dev] [RFC PATCH 47/65] st/mesa: enable ARB_bindless_texture

2017-05-23 Thread Marek Olšák
For patches 32-36, 38-41, 47: Reviewed-by: Marek Olšák Marek On Fri, May 19, 2017 at 6:52 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/mesa/state_tracker/st_extensions.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/state_tracker/st_extensions.c

Re: [Mesa-dev] [RFC PATCH 46/65] st/mesa: disable per-context seamless cubemap when using texture handles

2017-05-23 Thread Marek Olšák
What if a texture is used both as bindless and non-bindless? Wouldn't HandleAllocated be true all the time? Instead perhaps st_convert_sampler needs to know whether the current use is bindless, not whether there is an existing handle somewhere in the context. Marek On Fri, May 19, 2017 at 6:52 PM

Re: [Mesa-dev] [RFC PATCH 45/65] st/mesa: do not release sampler views for resident textures

2017-05-23 Thread Marek Olšák
I don't think this change is necessary. Releasing sampler views doesn't release textures. Marek On Fri, May 19, 2017 at 6:52 PM, Samuel Pitoiset wrote: > When a texture is referenced by one or more texture handles, > it might be resident and we shouldn't release the sampler views. > > Signed-off

Re: [Mesa-dev] [PATCH] i965: Rename brw_format variable names to isl_format

2017-05-23 Thread Jason Ekstrand
Bonus points if you also update the types to "enum isl_format" On May 23, 2017 9:53:12 AM Anuj Phogat wrote: This patch makes non functional changes. Renaming is just to make the code more readable. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_context.c | 4 ++-- s

Re: [Mesa-dev] [PATCH 4/5] nouveau: drop Android 4.4 and earlier support

2017-05-23 Thread Rob Herring
On Tue, May 23, 2017 at 2:49 PM, Rob Herring wrote: > Support for Android 4.4 and earlier has already been removed from mesa. > Remove this remaining piece from nouveau, too. > > Signed-off-by: Rob Herring > --- > .../drivers/nouveau/codegen/unordered_set.h| 32 > ++

Re: [Mesa-dev] [PATCH 4/5] nouveau: drop Android 4.4 and earlier support

2017-05-23 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Tue, May 23, 2017 at 3:49 PM, Rob Herring wrote: > Support for Android 4.4 and earlier has already been removed from mesa. > Remove this remaining piece from nouveau, too. > > Signed-off-by: Rob Herring > --- > .../drivers/nouveau/codegen/unordered_set.h| 32

[Mesa-dev] [PATCH 0/5] Android ifdef clean-ups

2017-05-23 Thread Rob Herring
This is a series of clean-ups of Android related ifdefs. They are either pre-Lollipop things no longer needed or things fixed in Android since before Lollipop. Rob Herring (5): gallium/os: use mmap64 for Android i965: use mmap64 for Android Android: generate an error if building on Android

[Mesa-dev] [PATCH 2/5] i965: use mmap64 for Android

2017-05-23 Thread Rob Herring
Simplify the handling of mmap for Android by using mmap64 instead. mmap64 may have not existed for Android when this was written, but it's been around since 2013. Signed-off-by: Rob Herring --- src/mesa/drivers/dri/i965/libdrm_macros.h | 17 ++--- 1 file changed, 2 insertions(+), 15

[Mesa-dev] [PATCH 3/5] Android: generate an error if building on Android 4.4 or earlier

2017-05-23 Thread Rob Herring
Android 4.4 or earlier is no longer supported, so exit with an error if we try building on it. Signed-off-by: Rob Herring --- Android.mk | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Android.mk b/Android.mk index ab6bf6adbd48..de37f4600f30 100644 --- a/Android.mk +++ b/Android.mk @@ -32

[Mesa-dev] [PATCH 1/5] gallium/os: use mmap64 for Android

2017-05-23 Thread Rob Herring
Simplify the handling of mmap for Android by using mmap64 instead. mmap64 may have not existed for Android when this was written, but it's been around since 2013. Signed-off-by: Rob Herring --- src/gallium/auxiliary/os/os_mman.h | 19 ++- 1 file changed, 2 insertions(+), 17 delet

[Mesa-dev] [PATCH 4/5] nouveau: drop Android 4.4 and earlier support

2017-05-23 Thread Rob Herring
Support for Android 4.4 and earlier has already been removed from mesa. Remove this remaining piece from nouveau, too. Signed-off-by: Rob Herring --- .../drivers/nouveau/codegen/unordered_set.h| 32 ++ 1 file changed, 2 insertions(+), 30 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 5/5] util: remove unneeded Android ifdef from ralloc.c

2017-05-23 Thread Rob Herring
SIZE_MAX has been defined in stdint.h on Android since 2013, so this ifdef is no longer needed. Signed-off-by: Rob Herring --- src/util/ralloc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/util/ralloc.c b/src/util/ralloc.c index 7bf192e0db78..cf2662f1db6e 100644 --- a/src/util/ra

Re: [Mesa-dev] [PATCH 3/4] st/mesa: Add support for ARB_post_depth_coverage

2017-05-23 Thread Lyude Paul
On Tue, 2017-05-23 at 15:24 -0400, Ilia Mirkin wrote: > On Tue, May 23, 2017 at 3:19 PM, Ilia Mirkin > wrote: > > On Tue, May 23, 2017 at 3:00 PM, Lyude wrote: > > > Signed-off-by: Lyude > > > --- > > >  src/mesa/state_tracker/st_extensions.c | 1 + > > >  src/mesa/state_tracker/st_glsl_to_tg

Re: [Mesa-dev] [PATCH 3/4] st/mesa: Add support for ARB_post_depth_coverage

2017-05-23 Thread Lyude Paul
On Tue, 2017-05-23 at 15:19 -0400, Ilia Mirkin wrote: > On Tue, May 23, 2017 at 3:00 PM, Lyude wrote: > > Signed-off-by: Lyude > > --- > >  src/mesa/state_tracker/st_extensions.c | 1 + > >  src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 +- > >  2 files changed, 6 insertions(+), 1 deletion

Re: [Mesa-dev] [PATCH 3/4] st/mesa: Add support for ARB_post_depth_coverage

2017-05-23 Thread Ilia Mirkin
On Tue, May 23, 2017 at 3:19 PM, Ilia Mirkin wrote: > On Tue, May 23, 2017 at 3:00 PM, Lyude wrote: >> Signed-off-by: Lyude >> --- >> src/mesa/state_tracker/st_extensions.c | 1 + >> src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 +- >> 2 files changed, 6 insertions(+), 1 deletion(-) >>

Re: [Mesa-dev] [PATCH 08/16] anv: Determine the type of mapping based on type metadata

2017-05-23 Thread Nanley Chery
On Thu, May 18, 2017 at 02:00:55PM -0700, Jason Ekstrand wrote: > Before, we were just comparing the type index to 0. Now we actually > look the type up in the table and check its properties to determine what > kind of mapping we want to do. > --- > src/intel/vulkan/anv_device.c | 12 ++-

Re: [Mesa-dev] [PATCH v2 2/4] gallium: Add TGSI shader token for ARB_post_depth_coverage

2017-05-23 Thread Roland Scheidegger
Am 23.05.2017 um 21:10 schrieb Lyude: > Signed-off-by: Lyude > --- > src/gallium/include/pipe/p_shader_tokens.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/include/pipe/p_shader_tokens.h > b/src/gallium/include/pipe/p_shader_tokens.h > index cb49e3b..1e08d97 100644 > --

Re: [Mesa-dev] [PATCH 3/4] st/mesa: Add support for ARB_post_depth_coverage

2017-05-23 Thread Ilia Mirkin
On Tue, May 23, 2017 at 3:00 PM, Lyude wrote: > Signed-off-by: Lyude > --- > src/mesa/state_tracker/st_extensions.c | 1 + > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 +- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/state_tracker/st_extensions.c > b/s

[Mesa-dev] [PATCH v2 4/4] nv50/ir, nvc0: Add support for ARB_post_depth_coverage

2017-05-23 Thread Lyude
This adds support for the GL_arb_post_depth_coverage extension on nvc0 GPUs, GM200+ and up. Similar to what we do for early fragment testing, we only call the method for updating the post depth coverage status for fragment programs when it changes. Signed-off-by: Lyude --- docs/relnotes/17.2.0.h

[Mesa-dev] [PATCH v2 2/4] gallium: Add TGSI shader token for ARB_post_depth_coverage

2017-05-23 Thread Lyude
Signed-off-by: Lyude --- src/gallium/include/pipe/p_shader_tokens.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_shader_tokens.h b/src/gallium/include/pipe/p_shader_tokens.h index cb49e3b..1e08d97 100644 --- a/src/gallium/include/pipe/p_shader_tokens.h +++ b/src

[Mesa-dev] [PATCH v2 1/4] gallium: Add a cap to check if the driver supports ARB_post_depth_coverage

2017-05-23 Thread Lyude
Signed-off-by: Lyude Changes since v1: - Correct documentation in screen.rst for new cap Signed-off-by: Lyude --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/galliu

[Mesa-dev] [PATCH v2 3/4] st/mesa: Add support for ARB_post_depth_coverage

2017-05-23 Thread Lyude
Signed-off-by: Lyude --- src/mesa/state_tracker/st_extensions.c | 1 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index f3db702..7674156 1

[Mesa-dev] [PATCH v2 0/4] ARB_post_depth_coverage for nvc0

2017-05-23 Thread Lyude
This is a patch series to add support for ARB_post_depth_coverage in nvc0, along with the required bits for gallium, tgsi, and mesa's state tracker. Only notable changes since v1 are for the first patch in this series. Lyude (4): gallium: Add a cap to check if the driver supports ARB_post_d

Re: [Mesa-dev] [PATCH 0/4] ARB_post_depth_coverage for nvc0

2017-05-23 Thread Lyude Paul
bleh, just noticed a big error on this I forgot to send. will send v2 in just a little bit. On Tue, 2017-05-23 at 15:00 -0400, Lyude wrote: > This is a patch series to add support for ARB_post_depth_coverage in > nvc0, > along with the required bits for gallium, tgsi, and mesa's state > tracker. >

[Mesa-dev] [PATCH 4/4] nv50/ir, nvc0: Add support for ARB_post_depth_coverage

2017-05-23 Thread Lyude
This adds support for the GL_arb_post_depth_coverage extension on nvc0 GPUs, GM200+ and up. Similar to what we do for early fragment testing, we only call the method for updating the post depth coverage status for fragment programs when it changes. Signed-off-by: Lyude --- docs/relnotes/17.2.0.h

[Mesa-dev] [PATCH 3/4] st/mesa: Add support for ARB_post_depth_coverage

2017-05-23 Thread Lyude
Signed-off-by: Lyude --- src/mesa/state_tracker/st_extensions.c | 1 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index f3db702..7674156 1

[Mesa-dev] [PATCH 0/4] ARB_post_depth_coverage for nvc0

2017-05-23 Thread Lyude
This is a patch series to add support for ARB_post_depth_coverage in nvc0, along with the required bits for gallium, tgsi, and mesa's state tracker. Lyude (4): gallium: Add a cap to check if the driver supports ARB_post_depth_coverage gallium: Add TGSI shader token for ARB_post_depth_cover

[Mesa-dev] [PATCH 1/4] gallium: Add a cap to check if the driver supports ARB_post_depth_coverage

2017-05-23 Thread Lyude
Signed-off-by: Lyude --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/llvmpipe/lp_screen.c

[Mesa-dev] [PATCH 2/4] gallium: Add TGSI shader token for ARB_post_depth_coverage

2017-05-23 Thread Lyude
Signed-off-by: Lyude --- src/gallium/include/pipe/p_shader_tokens.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_shader_tokens.h b/src/gallium/include/pipe/p_shader_tokens.h index cb49e3b..1e08d97 100644 --- a/src/gallium/include/pipe/p_shader_tokens.h +++ b/src

Re: [Mesa-dev] [PATCH 06/16] anv: Predicate 48bit support on gen >= 8

2017-05-23 Thread Nanley Chery
On Thu, May 18, 2017 at 02:00:53PM -0700, Jason Ekstrand wrote: > This doesn't matter right now since it only affects whether or not we > set the kernel bit but, if we ever do anything else based on it, we'll > want it to be correct per-gen. > --- > src/intel/vulkan/anv_device.c | 7 ++- > 1 f

[Mesa-dev] [Bug 101136] problems with mesa 17.2.0-devel

2017-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101136 --- Comment #2 from Grigory --- Today there were video driver updates, no changes were made. I still hope that this problem will be solved -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [RFC PATCH 29/65] tgsi: add new Bindless flag to tgsi_instruction_texture

2017-05-23 Thread Marek Olšák
BTW patch 25 needs gallium docs, which you already know. Other than that, patches 24-28 and 31 are: Reviewed-by: Marek Olšák Marek On Tue, May 23, 2017 at 2:29 PM, Samuel Pitoiset wrote: > > > On 05/22/2017 07:06 PM, Marek Olšák wrote: >> >> On Fri, May 19, 2017 at 6:52 PM, Samuel Pitoiset >>

Re: [Mesa-dev] [PATCH 1/3] gallium: add PIPE_CAP_ALLOW_MAPPED_BUFFERS_DURING_EXECUTION

2017-05-23 Thread Marek Olšák
On Tue, May 23, 2017 at 6:52 PM, Rob Clark wrote: > On Mon, May 15, 2017 at 10:41 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> for skipping mapped-buffer checking in every GL draw call >> --- >> src/gallium/docs/source/screen.rst | 1 + >> src/gallium/drivers/etnaviv/etnaviv_

Re: [Mesa-dev] [PATCH v13 07/36] egl: implement eglQueryDmaBufModifiersEXT

2017-05-23 Thread Daniel Stone
Hi Varad, On 23 May 2017 at 14:19, Varad Gautam wrote: > On Mon, 2017-05-22 at 14:03 +0100, Emil Velikov wrote: >> On 19 May 2017 at 10:37, Daniel Stone wrote: >> > + if (external_only != NULL) { >> > + for (i = 0; i < *count && i < max; i++) >> > + external_only[i] = EGL_TRUE; >>

[Mesa-dev] [PATCH] i965: Rename brw_format variable names to isl_format

2017-05-23 Thread Anuj Phogat
This patch makes non functional changes. Renaming is just to make the code more readable. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_context.c | 4 ++-- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 6 +++--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c| 4 ++

Re: [Mesa-dev] [PATCH 1/3] gallium: add PIPE_CAP_ALLOW_MAPPED_BUFFERS_DURING_EXECUTION

2017-05-23 Thread Rob Clark
On Mon, May 15, 2017 at 10:41 AM, Marek Olšák wrote: > From: Marek Olšák > > for skipping mapped-buffer checking in every GL draw call > --- > src/gallium/docs/source/screen.rst | 1 + > src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + > src/gallium/drivers/freedreno/freedre

[Mesa-dev] [PATCH] winsys/amdgpu: align VA allocations to fragment size

2017-05-23 Thread Christian König
From: Christian König BOs larger than the minimum fragment size should have their VA alignet to at least the fragment size for optimal performance. Signed-off-by: Christian König --- src/amd/common/ac_gpu_info.c | 1 + src/amd/common/ac_gpu_info.h | 1 + src/g

Re: [Mesa-dev] [PATCH] Revert "gallium: remove unused PIPE_CC_GCC_VERSION"

2017-05-23 Thread Brian Paul
On 05/22/2017 05:30 PM, Timothy Arceri wrote: Hi Brain, It's been 7 months since this landed. Why not just send this out with those patches when you are ready to upsteam? Coming soon... This is a simple revert and I don't think I really need an R-b, but I thought I'd give a heads-up. -Bria

Re: [Mesa-dev] [PATCH v3 01/15] st/dri: refactor multi-planar YUV import path

2017-05-23 Thread Lucas Stach
Hi Varad, Am Dienstag, den 23.05.2017, 14:40 +0530 schrieb Varad Gautam: > Hi Lucas, > > On Mon, May 22, 2017 at 11:16 PM, Lucas Stach wrote: > > Am Mittwoch, den 10.05.2017, 23:15 +0530 schrieb Varad Gautam: > >> From: Varad Gautam > >> > >> we currently ignore the plane count when converting

Re: [Mesa-dev] [PATCH] tgsi: remove unused tgsi_is_passthrough_shader()

2017-05-23 Thread tournier.elie
On 23 May 2017 at 14:31, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset Reviewed-by: Elie Tournier > --- > src/gallium/auxiliary/tgsi/tgsi_scan.c | 76 > -- > src/gallium/auxiliary/tgsi/tgsi_scan.h | 3 -- > 2 files changed, 79 deletions(-) > > diff -

[Mesa-dev] [Bug 101071] compiling glsl fails with undefined reference to `pthread_create'

2017-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101071 --- Comment #8 from war...@o2.pl --- hmm, I just revert this commit on current 17.1 and itfails with OP problem. how it that? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.

  1   2   >