Re: [Mesa-dev] [PATCH 1/3] radeonsi: move building llvm.SI.load.const into ac_build_buffer_load

2017-05-21 Thread Nicolai Hähnle
On 19.05.2017 17:54, Marek Olšák wrote: From: Marek Olšák --- src/amd/common/ac_llvm_build.c | 50 src/amd/common/ac_llvm_build.h | 3 +- src/amd/common/ac_nir_to_llvm.c | 2 +- src/gallium/drivers/radeonsi/si_shader.c | 23 ++

[Mesa-dev] [PATCH 10/10] mesa: add KHR_no_error support for glBindBufferRange()

2017-05-21 Thread Timothy Arceri
--- src/mapi/glapi/gen/GL3x.xml | 2 +- src/mesa/main/bufferobj.c | 103 src/mesa/main/bufferobj.h | 3 ++ 3 files changed, 70 insertions(+), 38 deletions(-) diff --git a/src/mapi/glapi/gen/GL3x.xml b/src/mapi/glapi/gen/GL3x.xml index 10c157e..

[Mesa-dev] [PATCH 08/10] mesa: convert mesa_bind_buffer_range_transform_feedback() to a validate function

2017-05-21 Thread Timothy Arceri
This allows some tidy up and also makes it so we can add KHR_no_error support. --- src/mesa/main/bufferobj.c | 12 +++ src/mesa/main/transformfeedback.c | 42 --- src/mesa/main/transformfeedback.h | 12 +-- 3 files changed, 35 insertions(

[Mesa-dev] [PATCH 07/10] mesa: create _mesa_bind_buffer_range_xfb() helper

2017-05-21 Thread Timothy Arceri
--- src/mesa/main/transformfeedback.h | 20 1 file changed, 20 insertions(+) diff --git a/src/mesa/main/transformfeedback.h b/src/mesa/main/transformfeedback.h index c83f917..475f5f1 100644 --- a/src/mesa/main/transformfeedback.h +++ b/src/mesa/main/transformfeedback.h @@ -1

[Mesa-dev] [PATCH 09/10] mesa: create bind_buffer_range() helper

2017-05-21 Thread Timothy Arceri
This will help us add KHR_no_error support. --- src/mesa/main/bufferobj.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 2d3e0f2..5aae579 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/buffe

[Mesa-dev] [PATCH 06/10] mesa: split bind_atomic_buffer() in two

2017-05-21 Thread Timothy Arceri
This will help us add KHR_no_error support. --- src/mesa/main/bufferobj.c | 54 +-- 1 file changed, 29 insertions(+), 25 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 132391b..aa253ef 100644 --- a/src/mesa/main/bu

[Mesa-dev] [PATCH 04/10] mesa: split bind_buffer_range_uniform_buffer() in two

2017-05-21 Thread Timothy Arceri
This will help us implement KHR_no_error support. --- src/mesa/main/bufferobj.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 461d697..2c5d56b 100644 --- a/src/mesa/main/bufferobj.c

[Mesa-dev] [PATCH 03/10] mesa: add KHR_no_error support for glVertexArrayVertexBuffer()

2017-05-21 Thread Timothy Arceri
Reviewed-by: Nicolai Hähnle --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/varray.c | 13 + src/mesa/main/varray.h | 4 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/AR

[Mesa-dev] [PATCH 02/10] mesa: add KHR_no_error support for glBindVertexBuffer()

2017-05-21 Thread Timothy Arceri
Reviewed-by: Nicolai Hähnle --- src/mapi/glapi/gen/ARB_vertex_attrib_binding.xml | 2 +- src/mesa/main/varray.c | 17 ++--- src/mesa/main/varray.h | 3 +++ 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/src/mapi/gl

[Mesa-dev] [PATCH 01/10] mesa: split vertex_array_vertex_buffer() in two

2017-05-21 Thread Timothy Arceri
This will allow us to skip the error checkes when adding KHR_no_error support. Reviewed-by: Nicolai Hähnle --- src/mesa/main/varray.c | 95 -- 1 file changed, 53 insertions(+), 42 deletions(-) diff --git a/src/mesa/main/varray.c b/src/mesa/main/va

[Mesa-dev] [PATCH 05/10] mesa: split bind_buffer_range_shader_storage_buffer() in two

2017-05-21 Thread Timothy Arceri
This will help us implement KHR_no_error support. --- src/mesa/main/bufferobj.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 2c5d56b..132391b 100644 --- a/src/mesa/main/buffero

Re: [Mesa-dev] [PATCH] i965/fs: don't do IR validation in release mode

2017-05-21 Thread Connor Abbott
On Sun, May 21, 2017 at 11:46 PM, Connor Abbott wrote: > Surprisingly, profiling shows that this takes quite a lot of time. So > turn it off when building in release mode, just like all the other > validation passes we do. > > Difference at 95.0% confidence > -82.5956 +/- 11.46 > -

Re: [Mesa-dev] [PATCH] travis: Disable scons tests, since the gallium unit tests fail.

2017-05-21 Thread Rhys Kidd
On 21 May 2017 at 19:33, Roland Scheidegger wrote: > I suppose the s3tc problems should go away rather sooner than later, but > isn't it possible to just disable the formats tests? > Yes, see USE_TXC_DXTN that was introduced in 29322daef2b77c4d869d2945fa1226e6b433c68 to address this issue with a

[Mesa-dev] [PATCH] i965/fs: don't do IR validation in release mode

2017-05-21 Thread Connor Abbott
Surprisingly, profiling shows that this takes quite a lot of time. So turn it off when building in release mode, just like all the other validation passes we do. Difference at 95.0% confidence -82.5956 +/- 11.46 -7.68394% +/- 1.06613% (Student's t, pooled s = 15.8735) Sign

[Mesa-dev] [PATCH] vc4: Remove dead code in vc4_dump_surface_msaa()

2017-05-21 Thread Rhys Kidd
Coverity caught the use of dead code copy-paste for found_colors[] and num_found_colors. CID: 1341850 Signed-off-by: Rhys Kidd --- src/gallium/drivers/vc4/vc4_resource.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/gallium/drivers/vc4/vc4_resource.c b/src/gallium/drivers/vc4/vc4

Re: [Mesa-dev] [PATCH 8/9] ralloc: Use strnlen() inside of strncat()

2017-05-21 Thread Timothy Arceri
Reviewed-by: Timothy Arceri I've pushed all the ones that had a previous r-b and added mine. On 22/05/17 06:49, Thomas Helland wrote: From: Vladislav Egorov If the str is long or isn't null-terminated, strlen() could take a lot of time or even crash. I don't know why was it used in the first

Re: [Mesa-dev] [PATCH 0/9][RFC] GLSL preprocessor/parser improvements

2017-05-21 Thread Timothy Arceri
I suspect you forgot to test with a debug build, there is issues with the string buffer changes somewhere. ralloc.c:203: reralloc_size: Assertion `ralloc_parent(ptr) == ctx' failed. #0 0x770eb91f in raise () from /lib64/libc.so.6 #1 0x770ed51a in abort () from /lib64/libc.so.

Re: [Mesa-dev] [PATCH 2/9] util: Add tests for the string buffer

2017-05-21 Thread Timothy Arceri
On 22/05/17 06:49, Thomas Helland wrote: More tests could probably be added, but this should cover concatenation, resizing, clearing, formatted printing, and checking the length, so it should be quite complete. --- configure.ac| 1 + src/util/Makefile.am

Re: [Mesa-dev] [PATCH 4/9] glcpp: Avoid unnecessary strcmp()

2017-05-21 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 22/05/17 06:49, Thomas Helland wrote: From: Vladislav Egorov strcmp() is slow. Initiate comparison with "__LINE__" or "__FILE__" only if the identifier starts with '_', which is rare. Reviewed-by: Ian Romanick --- src/compiler/glsl/glcpp/glcpp-parse.y | 14 +

Re: [Mesa-dev] [PATCH 1/9] util: Add a string buffer implementation

2017-05-21 Thread Timothy Arceri
On 22/05/17 08:28, Timothy Arceri wrote: On 22/05/17 06:49, Thomas Helland wrote: Based on Vladislav Egorov's work on the preprocessor, but split out to a util functionality that should be universal. Setup, teardown, memory handling and general layout is modeled around the hash_table and the s

Re: [Mesa-dev] [PATCH v2 3/3] drirc: Add allow_glsl_builtin_variable_redeclaration for Dying Light and Dead Island Definitive Edition

2017-05-21 Thread Anthony Jagers
These override environment variables, where are they placed? I tried to use VAR=val %command% in the steam launch options. All I got was a red pop up asking for a 3.3 driver when I had 3.0. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https

Re: [Mesa-dev] [PATCH 6/9] glcpp: Skip unnecessary line continuations removal

2017-05-21 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 22/05/17 06:49, Thomas Helland wrote: From: Vladislav Egorov Overwhelming majority of shaders don't use line continuations. In my shader-db only shaders from the Talos Principle and Serious Sam used them, less than 1% out of all shaders. Optimize for this case,

Re: [Mesa-dev] [PATCH 1/9] util: Add a string buffer implementation

2017-05-21 Thread Timothy Arceri
+ uint32_t num_args, ...); +bool +_mesa_string_buffer_append_len(struct _mesa_string_buffer *str, + char *c, uint32_t len); + +static inline bool +_mesa_string_buffer_append_char(struct _mesa_string_buffer *str, char c) +{ + assert(st

Re: [Mesa-dev] [PATCH 7/9] glcpp: Avoid unnecessary call to strlen

2017-05-21 Thread Timothy Arceri
On 22/05/17 06:49, Thomas Helland wrote: Length of the token was already calculated by flex and stored in yyleng, no need to implicitly call strlen() via linear_strdup(). --- src/compiler/glsl/glcpp/glcpp-lex.l | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/

Re: [Mesa-dev] [PATCH 1/9] util: Add a string buffer implementation

2017-05-21 Thread Grazvydas Ignotas
On Sun, May 21, 2017 at 11:49 PM, Thomas Helland wrote: > Based on Vladislav Egorov's work on the preprocessor, but split > out to a util functionality that should be universal. Setup, teardown, > memory handling and general layout is modeled around the hash_table > and the set, to make it familia

Re: [Mesa-dev] [RFC PATCH 25/65] gallium: add ARB_bindless_texture interface

2017-05-21 Thread Roland Scheidegger
Clearly, you forgot the doc bits... Roland Am 19.05.2017 um 18:52 schrieb Samuel Pitoiset: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/include/pipe/p_context.h | 16 > 1 file changed, 16 insertions(+) > > diff --git a/src/gallium/include/pipe/p_context.h > b/src/gall

Re: [Mesa-dev] [PATCH] android: radeon(s): fix libdrm_amdgpu shared dependencies

2017-05-21 Thread Mauro Rossi
2017-05-21 18:27 GMT+02:00 Emil Velikov : > Hi Mauro, > > There is a similar issue when building with autotools. There's a few > ways to address this so let's see what the devs prefer. > > Another temporary workaround is to build radeonsi alongside the other > radeon drivers. > > -Emil > Just FYI

Re: [Mesa-dev] [PATCH] travis: Disable scons tests, since the gallium unit tests fail.

2017-05-21 Thread Roland Scheidegger
I suppose the s3tc problems should go away rather sooner than later, but isn't it possible to just disable the formats tests? Roland Am 18.05.2017 um 23:27 schrieb Eric Anholt: > Every push a developer does to a travis-enabled github comes back as fail, > because the unit tests are already failin

[Mesa-dev] [Bug 101088] `gallium: remove pipe_index_buffer and set_index_buffer` causes glitches and crash in gallium nine

2017-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101088 --- Comment #4 from Axel Davy --- Should be fixed by https://lists.freedesktop.org/archives/mesa-dev/2017-May/156453.html Please confirm. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [PATCH] st/nine: Fix a regression and syntax cleanup

2017-05-21 Thread Axel Davy
A few cleanups and in particular initializing properly the new pipe_draw_info fields. This should fix the regression caused by 330d0607ed60fd3edca192e54b4246310f06652f Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101088 Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/devi

[Mesa-dev] [PATCH 2/5] radv: Specify semantics of HTILE layout helpers.

2017-05-21 Thread Bas Nieuwenhuizen
And correct implementation to specify only what we support. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_cmd_buffer.c | 4 src/amd/vulkan/radv_image.c | 9 ++--- src/amd/vulkan/radv_private.h| 10 ++ 3 files changed, 20 insertions(+), 3 deletions(-) diff

[Mesa-dev] [PATCH 4/5] radv: Use correct clear words for HTILE.

2017-05-21 Thread Bas Nieuwenhuizen
Did some RE'ing what several HTILE words give when read from a descriptor with HTILE compression enabled. Seems to align with -pro usage for D16 too. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_cmd_buffer.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) d

[Mesa-dev] [PATCH 5/5] radv: Add compute HTILE fast clear.

2017-05-21 Thread Bas Nieuwenhuizen
Not really what the fast depth clear does, no matter whether you use EXPCLEAR or not. Seems the fast clear using the DB HW always touches the main buffer. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_meta_clear.c | 94 +++- 1 file changed, 93 inser

[Mesa-dev] [PATCH 1/5] radv: Don't use a separate can_expclear.

2017-05-21 Thread Bas Nieuwenhuizen
We never use EXPCLEAR clears. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_cmd_buffer.c | 19 +++ src/amd/vulkan/radv_device.c | 21 +++-- src/amd/vulkan/radv_image.c | 7 --- src/amd/vulkan/radv_meta_clear.c | 2 +- src/amd/vulkan/radv_

[Mesa-dev] [PATCH 3/5] radv: Add queue masks for htile usage determination.

2017-05-21 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_cmd_buffer.c | 25 + src/amd/vulkan/radv_image.c | 12 src/amd/vulkan/radv_meta_clear.c | 18 -- src/amd/vulkan/radv_private.h| 6 -- 4 files changed, 41 insertions(+), 20 d

Re: [Mesa-dev] [PATCH 1/9] util: Add a string buffer implementation

2017-05-21 Thread Timothy Arceri
On 22/05/17 06:49, Thomas Helland wrote: Based on Vladislav Egorov's work on the preprocessor, but split out to a util functionality that should be universal. Setup, teardown, memory handling and general layout is modeled around the hash_table and the set, to make it familiar for everyone. A not

[Mesa-dev] [PATCH v2] drirc: Add allow_glsl_builtin_variable_redeclaration for Dead Island Riptide Definitive Edition

2017-05-21 Thread Benedikt Schemmer
From: Benedikt Schemmer This patch sets the allow_glsl_builtin_variable_redeclaration for Dead Island Riptide Definitive Edition. Tested with Mesa git as of today and Dying Light, Dead Island Definitive Edition and Dead Island Riptide Definite Edition v2: set only required option and match

[Mesa-dev] [PATCH] ac/surface: Fix HTILE for radv.

2017-05-21 Thread Bas Nieuwenhuizen
We always compute HTILE size using addrlib, even when not TC compatible. Signed-off-by: Bas Nieuwenhuizen --- src/amd/common/ac_surface.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c index 51e15d07d3c..877d592ab81

[Mesa-dev] [PATCH 7/9] glcpp: Avoid unnecessary call to strlen

2017-05-21 Thread Thomas Helland
Length of the token was already calculated by flex and stored in yyleng, no need to implicitly call strlen() via linear_strdup(). --- src/compiler/glsl/glcpp/glcpp-lex.l | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/glcpp/glcpp-lex.l b/src/compiler/glsl/g

[Mesa-dev] [PATCH 9/9] glcpp: Use Bloom filter before identifier search

2017-05-21 Thread Thomas Helland
From: Vladislav Egorov Absolute majority of identifiers in shaders are not macro references. Many shaders don't use preprocessing macros at all. Almost all queries to parser->defines hash-table will be unsuccessful. Note that all predefined macros start either with "GL_" or with "__". Moreover, e

[Mesa-dev] [PATCH 8/9] ralloc: Use strnlen() inside of strncat()

2017-05-21 Thread Thomas Helland
From: Vladislav Egorov If the str is long or isn't null-terminated, strlen() could take a lot of time or even crash. I don't know why was it used in the first place, maybe for platforms without strnlen(), but strnlen() is already used inside of ralloc_strndup(), so this change should not addition

[Mesa-dev] [PATCH 4/9] glcpp: Avoid unnecessary strcmp()

2017-05-21 Thread Thomas Helland
From: Vladislav Egorov strcmp() is slow. Initiate comparison with "__LINE__" or "__FILE__" only if the identifier starts with '_', which is rare. Reviewed-by: Ian Romanick --- src/compiler/glsl/glcpp/glcpp-parse.y | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH 5/9] glcpp: Use string_buffer for line continuation removal

2017-05-21 Thread Thomas Helland
Migrate removal of line continuations to string_buffer. Before this it used ralloc_strncat() to append strings, which internally each time calculates strlen() of its argument. Its argument is entire shader, so it multiple time scans the whole shader text. Signed-off-by: Vladislav Egorov V2: Adap

[Mesa-dev] [PATCH 6/9] glcpp: Skip unnecessary line continuations removal

2017-05-21 Thread Thomas Helland
From: Vladislav Egorov Overwhelming majority of shaders don't use line continuations. In my shader-db only shaders from the Talos Principle and Serious Sam used them, less than 1% out of all shaders. Optimize for this case, don't do any copying if no line continuation was found. --- src/compiler

[Mesa-dev] [PATCH 1/9] util: Add a string buffer implementation

2017-05-21 Thread Thomas Helland
Based on Vladislav Egorov's work on the preprocessor, but split out to a util functionality that should be universal. Setup, teardown, memory handling and general layout is modeled around the hash_table and the set, to make it familiar for everyone. A notable change is that this implementation is

[Mesa-dev] [PATCH 2/9] util: Add tests for the string buffer

2017-05-21 Thread Thomas Helland
More tests could probably be added, but this should cover concatenation, resizing, clearing, formatted printing, and checking the length, so it should be quite complete. --- configure.ac| 1 + src/util/Makefile.am| 3 +- src/util/te

[Mesa-dev] [PATCH 3/9] glsl: Change the parser to use the string buffer

2017-05-21 Thread Thomas Helland
--- src/compiler/glsl/glcpp/glcpp-parse.y | 85 ++- src/compiler/glsl/glcpp/glcpp.h | 8 ++-- src/compiler/glsl/glcpp/pp.c | 38 +++- 3 files changed, 63 insertions(+), 68 deletions(-) diff --git a/src/compiler/glsl/glcpp/glcpp-parse.y

[Mesa-dev] [PATCH 0/9][RFC] GLSL preprocessor/parser improvements

2017-05-21 Thread Thomas Helland
This patch series contains some of the work done by Vladislav in the beginning of March, that seems to have been forgotten. For reference, that series, with review comments, can be found here: https://lists.freedesktop.org/archives/mesa-dev/2017-January/139892.html I've adressed some of the revie

Re: [Mesa-dev] [PATCH 1/2] anv: automake: list shared libraries after the static ones

2017-05-21 Thread Eduardo Lima Mitev
Looks good. Series is: Reviewed-by: Eduardo Lima Mitev On 05/19/2017 07:43 PM, Emil Velikov wrote: > From: Emil Velikov > > The compiler can discard the shared ones from the link chain, since > there is no user (the static libraries) before it on the command line. > > Cc: mesa-sta...@lists.fr

Re: [Mesa-dev] [PATCH 1/2] util/disk_cache: add new driver_flags param to cache keys

2017-05-21 Thread Eduardo Lima Mitev
Both patches look good to me. Series is: Reviewed-by: Eduardo Lima Mitev On 05/20/2017 03:36 AM, Timothy Arceri wrote: > This will be used for things such as adding driver specific environment > variables to the key. Allowing us to set environment vars that change > the shader and not have the d

Re: [Mesa-dev] [RFC] ARB_gl_spirv and NIR backend for radeonsi

2017-05-21 Thread Rob Clark
On Sun, May 21, 2017 at 11:17 AM, Timothy Arceri wrote: > > >> >> 3. NIR vs. TGSI >> --- >> It is *not* a goal for this project to use NIR for normal GLSL shaders. >> We'll keep the TGSI backend at least for now. But it makes sense to think >> ahead. >> >> A minor disadvantage of NIR

[Mesa-dev] [Bug 99116] Wine program showing only a blackscreen when using mesa

2017-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99116 --- Comment #12 from JL --- Created attachment 131428 --> https://bugs.freedesktop.org/attachment.cgi?id=131428&action=edit nball replay output with patch applied I can confirm nball works after applying the patch. apitrace shows lots of error

Re: [Mesa-dev] [PATCH] android: radeon(s): fix libdrm_amdgpu shared dependencies

2017-05-21 Thread Emil Velikov
Hi Mauro, There is a similar issue when building with autotools. There's a few ways to address this so let's see what the devs prefer. Another temporary workaround is to build radeonsi alongside the other radeon drivers. -Emil ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH v2 00/15] ac/surface, radv: use shared surface computation code

2017-05-21 Thread Emil Velikov
Hi Nicolai, On 18 May 2017 at 10:53, Nicolai Hähnle wrote: > Hi all, > > This is v2 of the second half of a series I sent earlier, to move > radv to a shared code base for surface computations. I integrated > patches by Dave that should fix radv issues. The series is also at > https://cgit.freede

Re: [Mesa-dev] [RFC] ARB_gl_spirv and NIR backend for radeonsi

2017-05-21 Thread Timothy Arceri
Questions = 1. How do we get good test coverage? A natural candidate would be to add a SPIR-V execution mode for the piglit shader_runner. That is, use build scripts to extract shaders from shader_test files and feed them through glslang to get s

Re: [Mesa-dev] [RFC] ARB_gl_spirv and NIR backend for radeonsi

2017-05-21 Thread Timothy Arceri
3. NIR vs. TGSI --- It is *not* a goal for this project to use NIR for normal GLSL shaders. We'll keep the TGSI backend at least for now. But it makes sense to think ahead. A minor disadvantage of NIR is that the GLSL-to-NIR path is not as solid as the GLSL-to-TGSI path yet, b

Re: [Mesa-dev] i965/gen4: Depth buffer setup cleanup

2017-05-21 Thread Pohjolainen, Topi
On Sat, May 20, 2017 at 10:29:51PM +0300, Topi Pohjolainen wrote: > First this series removes logic considering separate stencil > gen < 6 only code paths (where we always use combined > depth-stencil). > > Then patch 5 simplifies the workaround we need for aligning > depth buffer. On gen < 6 the

[Mesa-dev] [PATCH v4 1/4] dri: Extend __DRIbackgroundCallableExtensionRec to include a callback that checks for thread safety

2017-05-21 Thread Gregory Hainaut
DRI-drivers could call Xlib functions, for example to allocate a new back buffer. When glthread is enabled, the driver runs mostly on a separate thread. Therefore we need to guarantee the thread safety between libX11 calls from the applications (not aware of the extra thread) and the ones from the

[Mesa-dev] [PATCH v4 4/4] glthread/gallium: require safe_glthread to start glthread

2017-05-21 Thread Gregory Hainaut
Print an error message for the user if the requirement isn't met, or we're not thread safe. v2: based on Nicolai feedbacks Check the DRI extension version v3: based on Emil feedbacks improve commit and error messages. use backgroundCallable variable to improve readability Signed-off-by: Gregory H

[Mesa-dev] [PATCH v4 2/4] glx: implement __DRIbackgroundCallableExtension.isThreadSafe

2017-05-21 Thread Gregory Hainaut
v2: bump version v3: Add code comment s/IsGlThread/IsThread/ (and variation) v4: DRI3 doesn't hit X through GL call so it is always safe Signed-off-by: Gregory Hainaut --- src/glx/dri2_glx.c | 15 ++- src/glx/dri3_glx.c | 12 +++- 2 files changed, 25 insertions(+), 2 deleti

[Mesa-dev] [PATCH v6 2/3] mesa/glthread: add tracking of PBO binding

2017-05-21 Thread Gregory Hainaut
In gl core, buffer must be reserved first by CreateBuffers/GenBuffers to be valid. v4: update comments based on Nicolai review Signed-off-by: Gregory Hainaut --- src/mesa/main/marshal.c | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH v4 0/4] Disable glthread if libX11 isn't thread-safe

2017-05-21 Thread Gregory Hainaut
Hello Mesa developers, Following the discussion from https://lists.freedesktop.org/archives/mesa-dev/2017-April/153137.html A check was added to ensure that X11 display can be locked. It should be enough to ensure thread safety between X11 and glthread. I also did the check on DRI3 as I'm not 10

[Mesa-dev] [PATCH v6 0/3] asynchronous pbo transfer with glthread

2017-05-21 Thread Gregory Hainaut
Hello Mesa developers, Please find a new version to handle invalid buffer handles. Allow to handle this kind of case: genBuffer(&pbo); BindBuffer(pbo) DeleteBuffer(pbo); BindBuffer(rand_pbo) TexSubImage2D(user_memory_pointer); // Data transfer will be synchronous There are various

[Mesa-dev] [PATCH v6 1/3] mesa/glthread: track buffer creation/destruction

2017-05-21 Thread Gregory Hainaut
It would be used in next commit to allow asynchronous PBO transfer. The tracking saves the buffer name into a hash. Saving pointer will be more complex as the buffer is created in BindBuffer due to IsBuffer insanity. Perf wise DeleteBuffers is now synchronous for robustness. v5: properly delete

[Mesa-dev] [PATCH v6 3/3] mapi/glthread: generate asynchronous code for PBO transfer

2017-05-21 Thread Gregory Hainaut
Improve speed on PCSX2 v2: Add ppbo/ubpo status in XML file Disable variable parameter (as the pointer would be a fixed offset) v3: split buffer tracking into separate patches. use 'goto fallback_to_sync' when asynchronous transfer isn't supported v4: add Nicolai comment to explain why ppbo isn'

[Mesa-dev] [PATCH v4 3/4] egl: implement __DRIbackgroundCallableExtension.isThreadSafe

2017-05-21 Thread Gregory Hainaut
v2: bump version v3: Add code comment s/IsGlThread/IsThread/ (and variation) Include X11/Xlibint.h protected by ifdef Signed-off-by: Gregory Hainaut --- src/egl/drivers/dri2/egl_dri2.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/src/egl/drive

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2017-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Javier Jardón changed: What|Removed |Added CC||jjar...@gnome.org -- You are receiving

Re: [Mesa-dev] [RFC] ARB_gl_spirv and NIR backend for radeonsi

2017-05-21 Thread Rob Clark
On Sun, May 21, 2017 at 6:48 AM, Nicolai Hähnle wrote: > Hi all, > > I've been looking into ARB_gl_spirv for radeonsi. I don't fancy re-inventing > the ~8k LOC of src/compiler/spirv, and there's already a perfectly fine > SPIR-V -> NIR -> LLVM compiler pipeline in radv, so I looked into re-using >

Re: [Mesa-dev] [PATCH] mesa: add APPLE_vertex_array_object stubs

2017-05-21 Thread Emil Velikov
On 19 May 2017 at 03:50, Timothy Arceri wrote: > APPLE_vertex_array_object support was removed in 7927d0378fc7. > However it turns out we can't remove the functions because this > can cause issues when libglapi is used together with "DRI drivers built prior to said commit." ... as things can go b

[Mesa-dev] [RFC] ARB_gl_spirv and NIR backend for radeonsi

2017-05-21 Thread Nicolai Hähnle
Hi all, I've been looking into ARB_gl_spirv for radeonsi. I don't fancy re-inventing the ~8k LOC of src/compiler/spirv, and there's already a perfectly fine SPIR-V -> NIR -> LLVM compiler pipeline in radv, so I looked into re-using that. It's not entirely straightforward because radeonsi and

[Mesa-dev] [Bug 101136] problems with mesa 17.2.0-devel

2017-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101136 --- Comment #1 from Grigory --- glxinfo | grep OpenGL OpenGL vendor string: X.Org OpenGL renderer string: Gallium 0.4 on AMD ARUBA (DRM 2.46.0 / 4.8.0-52-generic, LLVM 4.0.1) OpenGL core profile version string: 4.1 (Core Profile) Mesa 17.2.0-dev

[Mesa-dev] [Bug 101136] problems with mesa 17.2.0-devel

2017-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101136 Bug ID: 101136 Summary: problems with mesa 17.2.0-devel Product: Mesa Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: