[Mesa-dev] [PATCH] r600/eg: add support for tracing IBs after a hang.

2017-05-08 Thread Dave Airlie
From: Dave Airlie This is a poor man's version of radeonsi ddebug stuff, this should get hooked into that infrastructure, and grow more stuff, but for now, just create R600_TRACE var that points to a file that you want to dump the last IB to. Signed-off-by: Dave Airlie --- src/gallium/drivers/

Re: [Mesa-dev] [v2 36/39] i965: Add isl based miptree creator

2017-05-08 Thread Pohjolainen, Topi
On Mon, May 08, 2017 at 04:23:40PM -0700, Jason Ekstrand wrote: > On Wed, May 3, 2017 at 2:22 AM, Topi Pohjolainen > wrote: > > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 91 > > +++ > > 1 file changed, 91 insertions(+)

Re: [Mesa-dev] i965: Use isl for hiz and stencil

2017-05-08 Thread Pohjolainen, Topi
On Mon, May 08, 2017 at 04:51:35PM -0700, Jason Ekstrand wrote: > On Wed, May 3, 2017 at 2:22 AM, Topi Pohjolainen > wrote: > > > Patches 1-17 are revision that > > > > - rework hiz on gen6 to use on-demand offset calculator allowing > > one to drop dependency to miptree structure and > >

Re: [Mesa-dev] [v2 37/39] intel/isl/gen7/hack: Use stencil vertical alignment of 8 instead of 4

2017-05-08 Thread Pohjolainen, Topi
On Mon, May 08, 2017 at 03:31:55PM -0700, Jason Ekstrand wrote: > On Wed, May 3, 2017 at 2:22 AM, Topi Pohjolainen > wrote: > > > Signed-off-by: Topi Pohjolainen > > --- > > src/intel/isl/isl_gen7.c | 6 +- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/src/intel/is

Re: [Mesa-dev] (no subject)

2017-05-08 Thread Tapani Pälli
Hi; Take a look at Piglit test "ext_image_dma_buf_import-sample_yuv", (https://cgit.freedesktop.org/piglit). Test creates EGLImage from dma buf, binds to a texture and then samples this in a shader with samplerExternalOES type from GL_OES_EGL_image_external extension. On 05/09/2017 01:57 AM

Re: [Mesa-dev] [PATCH v2 05/27] configure: enable the surfaceless platform by default

2017-05-08 Thread nickolaib2...@gmail.com
,z,ц Sent from my ASUS Original Message From:Tapani Pälli Sent:Mon, 08 May 2017 07:33:03 +0200 To:Emil Velikov ,mesa-dev@lists.freedesktop.org Cc:mesa-sta...@lists.freedesktop.org Subject:Re: [Mesa-dev] [PATCH v2 05/27] configure: enable the surfaceless platform by default >Y

[Mesa-dev] [PATCH 2/5] mesa: replace _mesa_problem() with unreachable() in _mesa_light()

2017-05-08 Thread Timothy Arceri
All drivers but the old nouveau dri driver return after this anyway. --- src/mesa/main/light.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/light.c b/src/mesa/main/light.c index 87a06db..245692a 100644 --- a/src/mesa/main/light.c +++ b/src/mesa/main/light.c @

[Mesa-dev] [PATCH 4/5] mesa: replace _mesa_problem() with unreachable() in mipmap.c

2017-05-08 Thread Timothy Arceri
--- src/mesa/main/mipmap.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/mipmap.c b/src/mesa/main/mipmap.c index 8745dd9..fc36d40 100644 --- a/src/mesa/main/mipmap.c +++ b/src/mesa/main/mipmap.c @@ -750,21 +750,21 @@ do_row(GLenum datatype, GLuint comps,

[Mesa-dev] [PATCH 5/5] mesa: replace _mesa_problem() with unreachable() in pack.c

2017-05-08 Thread Timothy Arceri
--- src/mesa/main/pack.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/pack.c b/src/mesa/main/pack.c index 760c46a..94a6d28 100644 --- a/src/mesa/main/pack.c +++ b/src/mesa/main/pack.c @@ -453,22 +453,21 @@ extract_uint_indexes(GLuint n, GLuint indexe

[Mesa-dev] [PATCH 1/5] mesa: replace _mesa_problem() with assert() in hash table

2017-05-08 Thread Timothy Arceri
There should be no way the OpenGL test suites don't hit the assert() should we do something to cause this code path to be taken. --- src/mesa/main/hash.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/hash.c b/src/mesa/main/hash.c index a3772bd..7129616 1006

[Mesa-dev] [PATCH 3/5] mesa: replace _mesa_problem() with unreachable() in _mesa_convert_colors()

2017-05-08 Thread Timothy Arceri
--- src/mesa/main/image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/image.c b/src/mesa/main/image.c index a039b51..ad6b378 100644 --- a/src/mesa/main/image.c +++ b/src/mesa/main/image.c @@ -574,21 +574,21 @@ _mesa_convert_colors(GLenum srcType, const GLvoid

[Mesa-dev] RFC Remove _mesa_problem() from paths where execution path is not altered

2017-05-08 Thread Timothy Arceri
There is still more that can be removed I just though I'd get comments before going too far. This is a follow on from [1][2]. Besides patch 1 we are just replacing it with an unreachable() when the path doesn't try to work around the problem i.e return early. _mesa_problem() is still useful in s

[Mesa-dev] [PATCH 04.5/13] mesa: replace _mesa_problem() with unreachable()

2017-05-08 Thread Timothy Arceri
--- src/mesa/main/accum.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/accum.c b/src/mesa/main/accum.c index d81e1ba..c0a3e7e 100644 --- a/src/mesa/main/accum.c +++ b/src/mesa/main/accum.c @@ -419,21 +419,21 @@ accum(struct gl_context *ctx, GLenum op, GLfloat v

Re: [Mesa-dev] [PATCH] nir: Embed the shader_info in the nir_shader again

2017-05-08 Thread Timothy Arceri
On 09/05/17 03:54, Jason Ekstrand wrote: Commit e1af20f18a86f52a9640faf2d4ff8a71b0a4fa9b changed the shader_info from being embedded into being just a pointer. The idea was that sharing the shader_info between NIR and GLSL would be easier if it were a pointer pointing to the same shader_info s

Re: [Mesa-dev] [PATCH] mesa: add KHR_no_error support for glUseProgram

2017-05-08 Thread Timothy Arceri
On 08/05/17 19:36, Nicolai Hähnle wrote: On 08.05.2017 02:25, Timothy Arceri wrote: V3: use always_inline attribute (Suggested by Nicolai) Cc: Nicolai Hähnle --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/shaderapi.c | 75 +-- src/mesa/m

Re: [Mesa-dev] [PATCH] st/xvmc: deal with drivers wanting different texture formats

2017-05-08 Thread Ilia Mirkin
On Sun, May 7, 2017 at 9:48 PM, Ilia Mirkin wrote: > Previously, texture formats were being used unconditionally without > checking. However nv30 supports neither RGBX8 nor R4A4/A4R4 formats. Add > sufficient fallbacks so that the nv30 driver can have working OSD. > > Tested on a NV44A/PCI. > > Si

Re: [Mesa-dev] i965: Use isl for hiz and stencil

2017-05-08 Thread Jason Ekstrand
On Wed, May 3, 2017 at 2:22 AM, Topi Pohjolainen wrote: > Patches 1-17 are revision that > > - rework hiz on gen6 to use on-demand offset calculator allowing > one to drop dependency to miptree structure and > - rework all auxiliary surfaces to be created against isl directly. > > Patches

Re: [Mesa-dev] [v2 38/39] i965/miptree: Represent w-tiled stencil surfaces with isl

2017-05-08 Thread Jason Ekstrand
On Wed, May 3, 2017 at 2:22 AM, Topi Pohjolainen wrote: > leaving y-tiled (r8stencil) copies still as they were. > > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 24 +++ > src/mesa/drivers/dri/i965/brw_tex_layout.c| 57 > ---

[Mesa-dev] [PATCH] egl: fold Android logger into main/ (v2)

2017-05-08 Thread Mauro Rossi
Fixes the folloing building error: external/mesa/src/egl/drivers/dri2/platform_android.c:1492:19: error: use of undeclared identifier 'droid_log' _eglSetLogProc(droid_log); ^ 1 error generated. Fixes: 0372097 "egl: fold Android logger into main/" --- src/egl/drivers/dri2/pla

Re: [Mesa-dev] [v2 36/39] i965: Add isl based miptree creator

2017-05-08 Thread Jason Ekstrand
On Wed, May 3, 2017 at 2:22 AM, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 91 > +++ > 1 file changed, 91 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c > b/src/mesa/driv

Re: [Mesa-dev] [v2 21/39] intel/isl/gen6/hack: Use hiz vertical alignment of 16 instead of 8

2017-05-08 Thread Jason Ekstrand
On Wed, May 3, 2017 at 2:22 AM, Topi Pohjolainen wrote: > Looking PRMs (SNB, IVB) it also looks to me that the height of hiz > buffer would need to be half the height of depth. How this is taken > into account in i965 legacy or isl is unclear to me also. > > Signed-off-by: Topi Pohjolainen > ---

Re: [Mesa-dev] [PATCH 1/3] intel: gen decoder: don't check for size_t negative values

2017-05-08 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] intel: compiler: remove duplicated code

2017-05-08 Thread Matt Turner
On Mon, May 8, 2017 at 3:02 PM, Lionel Landwerlin wrote: > CID: 1399470: (Control flow issues) > > Signed-off-by: Lionel Landwerlin > Cc: Matt Turner > --- > src/intel/compiler/brw_eu_validate.c | 12 > 1 file changed, 12 deletions(-) > > diff --git a/src/intel/compiler/brw_eu_vali

Re: [Mesa-dev] [PATCH 3/3] intel: compiler: prevent integer overflow

2017-05-08 Thread Matt Turner
On Mon, May 8, 2017 at 3:02 PM, Lionel Landwerlin wrote: > CID: 1399477, 1399478 (Integer handling issues) > > Signed-off-by: Lionel Landwerlin > Cc: Matt Turner > --- > src/intel/compiler/brw_eu_validate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/intel/c

[Mesa-dev] (no subject)

2017-05-08 Thread Volker Vogelhuber
I'm currently trying to render a V4L2 image with OpenGL on an Intel Apollo Lake using Linux 4.10 and Mesa 13. Supprisingly I noticed that importing a DMABUF with format DRM_FORMAT_YUYV into OpenGL using eglCreateImage/glEGLImageTargetTexture2DOES worked out of the box. But I noticed that there se

Re: [Mesa-dev] [v2 37/39] intel/isl/gen7/hack: Use stencil vertical alignment of 8 instead of 4

2017-05-08 Thread Jason Ekstrand
On Wed, May 3, 2017 at 2:22 AM, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/intel/isl/isl_gen7.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/intel/isl/isl_gen7.c b/src/intel/isl/isl_gen7.c > index 18687b5..cf5b377 100644 > --- a/sr

Re: [Mesa-dev] [PATCH] st/dri: Add fence extension to SW path

2017-05-08 Thread Gurchetan Singh
Chrome is going to use EGLSync a lot to synchronize between EGL/KMS (along with the flush image external extension). VM's are used for testing, so adding this path would be helpful. On Fri, May 5, 2017 at 5:54 PM, Emil Velikov wrote: > Hi Gurchetan, > > On 5 May 2017 at 20:56, Gurchetan Singh

[Mesa-dev] [PATCH] st/dri: Add fence extension to SW path

2017-05-08 Thread Gurchetan Singh
Use the same fence implementation for drisw.c as dri2.c by making dri2FenceExtension an external variable. Since the fence implementation is not dri2.c specific, put it in a separate file. This is desirable for synchronization in virtual machines. v2: Don't depend on dri2.c for extensions (Emil) -

Re: [Mesa-dev] [v2 26/39] i965: Prepare image validation for isl based miptrees

2017-05-08 Thread Jason Ekstrand
On Wed, May 3, 2017 at 2:22 AM, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c > b/src/mesa/drivers/dri/i965/inte

[Mesa-dev] [Bug 100151] Front buffer drawing mode shows black window with gallium software rasterizers

2017-05-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100151 --- Comment #10 from Anton Starikov --- Addition: I made mistake during testing: softpipe works, both llvm AND swr (aka OpenSWR) - don't. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [PATCH 0/3] intel: More coverity fixes

2017-05-08 Thread Lionel Landwerlin
Going through a few more warnings that seem relevant. Cheers, Lionel Landwerlin (3): intel: gen decoder: don't check for size_t negative values intel: compiler: remove duplicated code intel: compiler: prevent integer overflow src/intel/common/gen_decoder.c | 2 +- src/intel/compile

[Mesa-dev] [PATCH 2/3] intel: compiler: remove duplicated code

2017-05-08 Thread Lionel Landwerlin
CID: 1399470: (Control flow issues) Signed-off-by: Lionel Landwerlin Cc: Matt Turner --- src/intel/compiler/brw_eu_validate.c | 12 1 file changed, 12 deletions(-) diff --git a/src/intel/compiler/brw_eu_validate.c b/src/intel/compiler/brw_eu_validate.c index f231ea038b4..2db7c5a9

[Mesa-dev] [PATCH 1/3] intel: gen decoder: don't check for size_t negative values

2017-05-08 Thread Lionel Landwerlin
We should get either 0 or 1 here. CID: 1373562 (Control flow issues) Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 15bba3274ed..2414734

[Mesa-dev] [PATCH 3/3] intel: compiler: prevent integer overflow

2017-05-08 Thread Lionel Landwerlin
CID: 1399477, 1399478 (Integer handling issues) Signed-off-by: Lionel Landwerlin Cc: Matt Turner --- src/intel/compiler/brw_eu_validate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/compiler/brw_eu_validate.c b/src/intel/compiler/brw_eu_validate.c index 2d

Re: [Mesa-dev] [PATCH] mesa/vbo: fix invalid min/max indexes

2017-05-08 Thread Rob Clark
On Mon, May 8, 2017 at 5:29 PM, Ilia Mirkin wrote: > On Mon, May 8, 2017 at 5:27 PM, Rob Clark wrote: >> On Mon, May 8, 2017 at 4:57 PM, Marek Olšák wrote: >>> I personally find the assertions unnecessary because the bug has been >>> discovered and fixed by this patch, and this code is unlikely

Re: [Mesa-dev] [PATCH] mesa: remove never used gl_shader_compiler_options::EmitNoFunctions

2017-05-08 Thread tournier.elie
On 8 May 2017 at 21:54, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset Reviewed-by: Elie Tournier > --- > src/mesa/main/mtypes.h | 1 - > src/mesa/state_tracker/st_extensions.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/src/mesa/main/mtypes.h b/src/mesa/

Re: [Mesa-dev] [PATCH] mesa/vbo: fix invalid min/max indexes

2017-05-08 Thread Ilia Mirkin
On Mon, May 8, 2017 at 5:27 PM, Rob Clark wrote: > On Mon, May 8, 2017 at 4:57 PM, Marek Olšák wrote: >> I personally find the assertions unnecessary because the bug has been >> discovered and fixed by this patch, and this code is unlikely to >> change. Anyway: >> >> Reviewed-by: Marek Olšák > >

Re: [Mesa-dev] [PATCH] mesa/vbo: fix invalid min/max indexes

2017-05-08 Thread Rob Clark
On Mon, May 8, 2017 at 4:57 PM, Marek Olšák wrote: > I personally find the assertions unnecessary because the bug has been > discovered and fixed by this patch, and this code is unlikely to > change. Anyway: > > Reviewed-by: Marek Olšák I don't suppose there is something like debug_assert() (ie.

Re: [Mesa-dev] [PATCH] mesa/vbo: fix invalid min/max indexes

2017-05-08 Thread Rob Clark
On Mon, May 8, 2017 at 4:58 PM, Dieter Nützel wrote: > Hello Rob, > > FWIW this is > Tested-by: Dieter Nützel > > on radeonsi/RX580 (my first on new GREAT hardware) ;-) > But 'glmark2 -b ideas' worked for me on radeonsi without this. > thanks.. actually radeonsi never looks at info->min/max_inde

Re: [Mesa-dev] [PATCH] mesa/vbo: fix invalid min/max indexes

2017-05-08 Thread Dieter Nützel
Hello Rob, FWIW this is Tested-by: Dieter Nützel on radeonsi/RX580 (my first on new GREAT hardware) ;-) But 'glmark2 -b ideas' worked for me on radeonsi without this. Greetings, Dieter Am 08.05.2017 22:37, schrieb Rob Clark: Fixes: c3f37e9b ("st/mesa: use min_index and max_index directly from

Re: [Mesa-dev] [PATCH] mesa/vbo: fix invalid min/max indexes

2017-05-08 Thread Marek Olšák
I personally find the assertions unnecessary because the bug has been discovered and fixed by this patch, and this code is unlikely to change. Anyway: Reviewed-by: Marek Olšák Marek On Mon, May 8, 2017 at 10:37 PM, Rob Clark wrote: > Fixes: c3f37e9b ("st/mesa: use min_index and max_index direc

[Mesa-dev] [PATCH] mesa: remove never used gl_shader_compiler_options::EmitNoFunctions

2017-05-08 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/mesa/main/mtypes.h | 1 - src/mesa/state_tracker/st_extensions.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 2500e5fee3..03b9baa95e 100644 --- a/src/mesa/main/mtypes.h +++ b/src/m

[Mesa-dev] [PATCH] mesa/vbo: fix invalid min/max indexes

2017-05-08 Thread Rob Clark
Fixes: c3f37e9b ("st/mesa: use min_index and max_index directly from vbo") Signed-off-by: Rob Clark --- I haven't had a chance to piglit this yet, but it does fix the regression w/ 'glmark2 -b ideas'. src/mesa/vbo/vbo_exec_array.c | 22 -- 1 file changed, 16 insertions(+), 6

Re: [Mesa-dev] [PATCH 2/2] st/mesa: use min_index and max_index directly from vbo

2017-05-08 Thread Marek Olšák
On Mon, May 8, 2017 at 8:46 PM, Rob Clark wrote: > On Mon, May 8, 2017 at 1:52 PM, Marek Olšák wrote: >> On Mon, May 8, 2017 at 7:28 PM, Rob Clark wrote: >>> This commit breaks 'glmark2 -b ideas' on a3xx.. probably a2xx too. >>> (a4xx/a5xx, and from the looks of it, radeon, ignore min/max_index

Re: [Mesa-dev] [PATCH 2/2] st/mesa: use min_index and max_index directly from vbo

2017-05-08 Thread Marek Olšák
On Mon, May 8, 2017 at 7:58 PM, Ilia Mirkin wrote: > On Mon, May 8, 2017 at 1:52 PM, Marek Olšák wrote: >> On Mon, May 8, 2017 at 7:28 PM, Rob Clark wrote: >>> This commit breaks 'glmark2 -b ideas' on a3xx.. probably a2xx too. >>> (a4xx/a5xx, and from the looks of it, radeon, ignore min/max_ind

Re: [Mesa-dev] [v2 25/39] i965: Prepare blit engine for isl based miptrees

2017-05-08 Thread Jason Ekstrand
On Wed, May 3, 2017 at 2:22 AM, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_blit.c | 37 > +- > src/mesa/drivers/dri/i965/intel_blit.h | 13 > 2 files changed, 41 insertions(+), 9 deletions(-) > >

Re: [Mesa-dev] [v2 22/39] i965/miptree: Add support for resolving offsets using isl

2017-05-08 Thread Jason Ekstrand
I *think* most of this patch goes away if we have a new ISL_DIM_LAYOUT_GEN6_BACK_TO_BACK because we won't be pushing the isl_dev in everywhere. That said, it'd be nice if you would split out the bit which adds the isl_surf with a commit message something like this: i965: Add an isl_surf to intel_

Re: [Mesa-dev] [PATCH 02/13] mesa/dri: always link against shared glapi

2017-05-08 Thread Aaron Watry
On Mon, May 8, 2017 at 9:30 AM, Emil Velikov wrote: > On 8 May 2017 at 11:05, Emil Velikov wrote: > > On 8 May 2017 at 10:24, Grazvydas Ignotas wrote: > >> That indeed helps, thanks. > >> I guess it becomes "--with-dri-driverdir is broken by this commit" then. > >> > > I'm not setting with-dri-

Re: [Mesa-dev] [PATCH 3/3] st/mesa: move the logic of all_varyings_in_vbos into st_update_array

2017-05-08 Thread Nicolai Hähnle
On 08.05.2017 19:09, Marek Olšák wrote: From: Marek Olšák The function was pretty slow. This brings a substantial decrease in draw call overhead when min/max index bounds are not needed: Before: DrawElements (1 VBO) w/ no state change: 5.75 million After: DrawElements (1 VBO) w/ no

Re: [Mesa-dev] [v2 18/39] intel/isl/gen6: Add offsetting support for back-to-back layouts

2017-05-08 Thread Jason Ekstrand
On Wed, May 3, 2017 at 2:22 AM, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/intel/blorp/blorp_blit.c | 2 +- > src/intel/isl/isl.c | 29 +--- > src/intel/isl/isl.h | 14 ++-- > src/intel/isl/isl_gen6.c

Re: [Mesa-dev] [PATCH 2/2] st/mesa: use min_index and max_index directly from vbo

2017-05-08 Thread Rob Clark
On Mon, May 8, 2017 at 1:52 PM, Marek Olšák wrote: > On Mon, May 8, 2017 at 7:28 PM, Rob Clark wrote: >> This commit breaks 'glmark2 -b ideas' on a3xx.. probably a2xx too. >> (a4xx/a5xx, and from the looks of it, radeon, ignore min/max_index..) >> Nouveau also uses min/max_index, so wouldn't be

Re: [Mesa-dev] [PATCH 5/5] mesa: Set new renderbuffers to RGBA4 on all GLES contexts.

2017-05-08 Thread Eric Anholt
Eric Anholt writes: > Before we were doing RGBA4 on GLES3 only, but as of GLES2 2.0.22 it should > be RGBA4 as well. Fixes DEQP > functional.state_query.rbo.renderbuffer_internal_format. Note to potential reviewers: This patch hasn't been reviewed yet, while 1-4 had. signature.asc Description

Re: [Mesa-dev] [PATCH RFC 4/4] dri: Turn of a couple of glx extensions for gnome-shell on vmwgfx.

2017-05-08 Thread Thomas Hellstrom
On 05/08/2017 04:14 PM, Marek Olšák wrote: > For the series: > > Reviewed-by: Marek Olšák > > Marek Thanks for reviewing, Marek. /Thomas > > On Fri, May 5, 2017 at 4:02 PM, Thomas Hellstrom > wrote: >> Increases performance on vmwgfx since we're avoiding full buffer damage and >> since we ca

Re: [Mesa-dev] [PATCH 1/2] glsl: store the image format in glsl_struct_field

2017-05-08 Thread Jason Ekstrand
On Mon, May 8, 2017 at 3:26 AM, Nicolai Hähnle wrote: > On 08.05.2017 12:11, Nicolai Hähnle wrote: > >> On 06.05.2017 20:09, Jason Ekstrand wrote: >> >>> On May 6, 2017 7:56:02 AM Samuel Pitoiset >>> wrote: >>> >>> ARB_bindless_texture allows to declare image types inside structures, >

[Mesa-dev] [PATCH] bin/get-fixes-pick-list.sh: bring back the warning

2017-05-08 Thread Andres Gomez
We warn again if there is more than one line with the "fixes:" tag. The warning is only silenced when the commit has landed already or we output a message with the specific commit the "fixes:" tag is referring to. Signed-off-by: Andres Gomez --- bin/get-fixes-pick-list.sh | 17 +++--

Re: [Mesa-dev] [PATCH 2/2] st/mesa: use min_index and max_index directly from vbo

2017-05-08 Thread Ilia Mirkin
On Mon, May 8, 2017 at 1:52 PM, Marek Olšák wrote: > On Mon, May 8, 2017 at 7:28 PM, Rob Clark wrote: >> This commit breaks 'glmark2 -b ideas' on a3xx.. probably a2xx too. >> (a4xx/a5xx, and from the looks of it, radeon, ignore min/max_index..) >> Nouveau also uses min/max_index, so wouldn't be

Re: [Mesa-dev] [PATCH 2/2] st/mesa: use min_index and max_index directly from vbo

2017-05-08 Thread Marek Olšák
On Mon, May 8, 2017 at 7:28 PM, Rob Clark wrote: > This commit breaks 'glmark2 -b ideas' on a3xx.. probably a2xx too. > (a4xx/a5xx, and from the looks of it, radeon, ignore min/max_index..) > Nouveau also uses min/max_index, so wouldn't be surprised if this commit > causes problems there too.. >

Re: [Mesa-dev] [PATCH v3 2/2] swr: fix polygonmode for front==back

2017-05-08 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On May 4, 2017, at 10:35 AM, George Kyriazis > wrote: > > Rasterizer core only supports polygonmode front==back. Add logic for > populating fillMode for the rasterizer only for that case correctly. > Provide enum conversion between mesa enums and core enums. >

Re: [Mesa-dev] [PATCH v3 1/2] swr/rast: support polygonmode point

2017-05-08 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On May 4, 2017, at 10:35 AM, George Kyriazis > wrote: > > Add support for polygonmode point in the binner. This is done by > splitting BinPostSetupPoints from BinPoints, so the earlier call can be > called from BinTriangles. Setup has already been done at the ti

Re: [Mesa-dev] [PATCH 2/2] st/mesa: use min_index and max_index directly from vbo

2017-05-08 Thread Rob Clark
This commit breaks 'glmark2 -b ideas' on a3xx.. probably a2xx too. (a4xx/a5xx, and from the looks of it, radeon, ignore min/max_index..) Nouveau also uses min/max_index, so wouldn't be surprised if this commit causes problems there too.. Any particular need for this commit, or can I push a revert

[Mesa-dev] [Bug 100151] Front buffer drawing mode shows black window with gallium software rasterizers

2017-05-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100151 Anton Starikov changed: What|Removed |Added Version|13.0|17.0 --- Comment #9 from Anton Stariko

Re: [Mesa-dev] [PATCH 1/2] ac: fix broken elimination of duplicated VS exports

2017-05-08 Thread Marek Olšák
On Mon, May 8, 2017 at 7:00 PM, Nicolai Hähnle wrote: > On 08.05.2017 18:38, Marek Olšák wrote: >> >> From: Marek Olšák >> >> The renumbering code didn't take into account that multiple VS exports >> can have the same PARAM index. This also significantly simplifies >> the renumbering. Thankfully,

[Mesa-dev] [PATCH 3/3] st/mesa: move the logic of all_varyings_in_vbos into st_update_array

2017-05-08 Thread Marek Olšák
From: Marek Olšák The function was pretty slow. This brings a substantial decrease in draw call overhead when min/max index bounds are not needed: Before: DrawElements (1 VBO) w/ no state change: 5.75 million After: DrawElements (1 VBO) w/ no state change: 7.03 million ---

[Mesa-dev] [PATCH 1/3] st/mesa: make st_draw_vbo static

2017-05-08 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_cb_feedback.c | 2 +- src/mesa/state_tracker/st_draw.c| 2 +- src/mesa/state_tracker/st_draw.h| 12 3 files changed, 2 insertions(+), 14 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_feedback.c b/src/mesa/s

[Mesa-dev] [PATCH 2/3] st/mesa: unify common code in st_draw_vbo functions

2017-05-08 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_draw.c | 48 ++-- 1 file changed, 21 insertions(+), 27 deletions(-) diff --git a/src/mesa/state_tracker/st_draw.c b/src/mesa/state_tracker/st_draw.c index 78aabb0..15c5b80 100644 --- a/src/mesa/state_tracker/st_

[Mesa-dev] [PATCH] configure: remove unneeded bits around libunwind handling

2017-05-08 Thread Emil Velikov
From: Emil Velikov If libunwind is not found we'll fail at PKG_CHECK_MODULES, so the follow-up check won't be reached. Additionally the AM_CONDITIONAL is not used, so we can drop it. Fixes: 3bcef6aa245 ("configure.ac: honour --disable-libunwind if the .pc file is present") Signed-off-by: Emil V

Re: [Mesa-dev] [PATCH 1/2] ac: fix broken elimination of duplicated VS exports

2017-05-08 Thread Nicolai Hähnle
On 08.05.2017 18:38, Marek Olšák wrote: From: Marek Olšák The renumbering code didn't take into account that multiple VS exports can have the same PARAM index. This also significantly simplifies the renumbering. Thankfully, we have piglits for this: spec@arb_gpu_shader5@arb_gpu_shader5-int

Re: [Mesa-dev] [PATCH] docs/releasing: don't forget to update the calendar

2017-05-08 Thread Eric Engestrom
On 8 May 2017 16:06:08 BST, Emil Velikov wrote: >From: Emil Velikov > >Cc: Eric Engestrom >Suggested-by: Eric Engestrom >Signed-off-by: Emil Velikov Reviewed-by: Eric Engestrom >--- > docs/releasing.html | 8 > 1 file changed, 8 insertions(+) > >diff --git a/docs/releasing.html b/

[Mesa-dev] [PATCH 1/2] ac: fix broken elimination of duplicated VS exports

2017-05-08 Thread Marek Olšák
From: Marek Olšák The renumbering code didn't take into account that multiple VS exports can have the same PARAM index. This also significantly simplifies the renumbering. Thankfully, we have piglits for this: spec@arb_gpu_shader5@arb_gpu_shader5-interpolateatcentroid-packing spec@glsl-1

[Mesa-dev] [PATCH 2/2] radeonsi: rename si_eliminate_const_vs_outputs -> si_optimize_vs_outputs

2017-05-08 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 1be6654..e89b325 100644 --- a/src/gallium/drivers/radeonsi/si_shader.c

Re: [Mesa-dev] [PATCH v3] swr: move msaa resolve to generalized StoreTile

2017-05-08 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley mailto:timothy.o.row...@intel.com>> On May 4, 2017, at 7:33 PM, Bruce Cherniak mailto:bruce.chern...@intel.com>> wrote: v3: list piglit tests fixed by this patch. Fixed typo Tim pointed out. v2: Reword commit message to more closely adhere to community guidelines. This

Re: [Mesa-dev] [PATCH 0/4] Call for testing: Gallium set_index_buffer removal etc.

2017-05-08 Thread Marek Olšák
Alright so I think this is almost ready to go. My repository contains an update from today (mainly adding Brian's svga fixes and some fixes for Nine). These are projects I haven't heard anything from since I last mentioned them: - etnaviv - freedreno - virgl - nine I suppose they would be OK with

Re: [Mesa-dev] [PATCH v3 0/4] Disable glthread if libX11 isn't thread-safe

2017-05-08 Thread Eric Anholt
gregory hainaut writes: > On Fri, 5 May 2017 17:45:01 +0200 > Axel Davy wrote: > >> Hi, >> >> There should be very few X11 calls while rendering (basically only at >> the beginning or end of a frame). >> >> Why not just always run these calls in the main thread (and wait for >> glthread work

[Mesa-dev] [PATCH 10/11] radeonsi: dump both enabled and required descriptor slots

2017-05-08 Thread Nicolai Hähnle
From: Nicolai Hähnle This allows a meaningful dump with info == NULL (for compute shaders). --- src/gallium/drivers/radeonsi/si_debug.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_debug.c b/src/gallium/drivers/radeonsi/

[Mesa-dev] [PATCH 09/11] radeonsi: dump compute shader as part of debug dump

2017-05-08 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_debug.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_debug.c b/src/gallium/drivers/radeonsi/si_debug.c index 2e727f6..6e310bb 100644 --- a/src/gallium/drivers/radeonsi/si_debug.c +++ b/s

[Mesa-dev] [PATCH 11/11] radeonsi: dump compute descriptor lists

2017-05-08 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_debug.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_debug.c b/src/gallium/drivers/radeonsi/si_debug.c index d39b303..d08a8fc 100644 --- a/src/gallium/drivers/radeonsi/si_debug.c +++ b/sr

[Mesa-dev] [PATCH 05/11] radeonsi: more const qualifiers in shader dump functions

2017-05-08 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 20 ++-- src/gallium/drivers/radeonsi/si_shader.h | 4 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c i

[Mesa-dev] [PATCH 07/11] radeonsi: split descriptor list dumping

2017-05-08 Thread Nicolai Hähnle
From: Nicolai Hähnle Prepare for dumping CS descriptor list. --- src/gallium/drivers/radeonsi/si_debug.c | 37 +++-- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_debug.c b/src/gallium/drivers/radeonsi/si_debug.c inde

[Mesa-dev] [PATCH 04/11] ddebug: implement dd_dump_launch_grid

2017-05-08 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/ddebug/dd_context.c | 2 ++ src/gallium/drivers/ddebug/dd_draw.c| 6 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/ddebug/dd_context.c b/src/gallium/drivers/ddebug/dd_context.c index 723e90e..854ff51 100

[Mesa-dev] [PATCH 02/11] gallium/util: dump tokens in util_dump_shader_state only if type is TGSI

2017-05-08 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/auxiliary/util/u_dump_state.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/util/u_dump_state.c b/src/gallium/auxiliary/util/u_dump_state.c index 9bb9095..bf27a4e 100644 --- a/src/gallium/auxiliary/uti

[Mesa-dev] [PATCH 06/11] radeonsi: split shader dumping

2017-05-08 Thread Nicolai Hähnle
From: Nicolai Hähnle Prepare for dumping compute shaders. --- src/gallium/drivers/radeonsi/si_debug.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_debug.c b/src/gallium/drivers/radeonsi/si_debug.c index 9634

[Mesa-dev] [PATCH 08/11] radeonsi: move struct si_compute into a header

2017-05-08 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/Makefile.sources | 1 + src/gallium/drivers/radeonsi/si_compute.c | 22 +--- src/gallium/drivers/radeonsi/si_compute.h | 50 +++ 3 files changed, 52 insertions(+), 21 deletions(-) create mode 100644 s

[Mesa-dev] [PATCH 00/11] gallium, radeonsi: debug dumping of compute shader state

2017-05-08 Thread Nicolai Hähnle
Hi all, This series fills in a minor gap: launch_grid is now covered as well as regular draws with ddebug. The code in radeonsi that dumps shaders and descriptor lists makes no efforts to determine whether the graphics or the compute shaders are relevant for the currently dumped state. It should

[Mesa-dev] [PATCH 03/11] ddebug: extract dd_dump_shader

2017-05-08 Thread Nicolai Hähnle
From: Nicolai Hähnle Will be re-used for compute shaders. --- src/gallium/drivers/ddebug/dd_draw.c | 156 ++- 1 file changed, 82 insertions(+), 74 deletions(-) diff --git a/src/gallium/drivers/ddebug/dd_draw.c b/src/gallium/drivers/ddebug/dd_draw.c index 6e96c72

[Mesa-dev] [PATCH 01/11] gallium/util: add util_dump_grid_info

2017-05-08 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/auxiliary/util/u_dump.h | 3 +++ src/gallium/auxiliary/util/u_dump_state.c | 27 +++ 2 files changed, 30 insertions(+) diff --git a/src/gallium/auxiliary/util/u_dump.h b/src/gallium/auxiliary/util/u_dump.h index bce8517..3a701

[Mesa-dev] [PATCH] docs/releasing: don't forget to update the calendar

2017-05-08 Thread Emil Velikov
From: Emil Velikov Cc: Eric Engestrom Suggested-by: Eric Engestrom Signed-off-by: Emil Velikov --- docs/releasing.html | 8 1 file changed, 8 insertions(+) diff --git a/docs/releasing.html b/docs/releasing.html index 9b5a8b89d9f..e2206b539a9 100644 --- a/docs/releasing.html +++ b/do

Re: [Mesa-dev] [PATCH v3 0/4] Disable glthread if libX11 isn't thread-safe

2017-05-08 Thread Emil Velikov
On 5 May 2017 at 18:28, gregory hainaut wrote: > On Fri, 5 May 2017 18:17:22 +0100 > Emil Velikov wrote: > >> On 5 May 2017 at 17:58, gregory hainaut wrote: >> > On Fri, 5 May 2017 17:45:01 +0200 >> > Axel Davy wrote: >> > >> [...] >> > >> > Hello Axel, >> > >> > Yes it is another possibility.

Re: [Mesa-dev] [PATCH] egl: simplify the Android logger

2017-05-08 Thread Rob Herring
On Mon, May 8, 2017 at 9:41 AM, Emil Velikov wrote: > From: Emil Velikov > > Drop the unsupported pre-JellyBean macros and use a simple egl2android > mapping. With this we loose the explicit abort() provided by LOG_FATAL, > although Mesa already already calls exit(1) in case of a fatal errors. >

Re: [Mesa-dev] [PATCH 2/7] egl: fold Android logger into main/

2017-05-08 Thread Emil Velikov
On 5 May 2017 at 13:49, Emil Velikov wrote: > On 4 May 2017 at 20:17, Rob Herring wrote: >> On Thu, May 4, 2017 at 1:46 PM, Emil Velikov >> wrote: >>> From: Emil Velikov >>> >>> Will allow us to greatly simplify a lot of the code in egllog.c >> >> Okay, because on its own, this is not an impro

[Mesa-dev] [PATCH] egl: simplify the Android logger

2017-05-08 Thread Emil Velikov
From: Emil Velikov Drop the unsupported pre-JellyBean macros and use a simple egl2android mapping. With this we loose the explicit abort() provided by LOG_FATAL, although Mesa already already calls exit(1) in case of a fatal errors. Cc: Rob Herring Suggested-by: Rob Herring Signed-off-by: Emil

Re: [Mesa-dev] [PATCH] configure.ac: Also match -androideabi tuple

2017-05-08 Thread Nicolas Boichat
On Mon, May 8, 2017 at 9:19 PM, Emil Velikov wrote: > On 5 May 2017 at 23:40, Chad Versace wrote: >> On Fri 05 May 2017, Nicolas Boichat wrote: >>> From: Nicolas Boichat >>> >>> On ARM Android platforms, the host_os tuple should be linux-androideabi, >>> so let's match both -android and -android

Re: [Mesa-dev] [PATCH 02/13] mesa/dri: always link against shared glapi

2017-05-08 Thread Emil Velikov
On 8 May 2017 at 11:05, Emil Velikov wrote: > On 8 May 2017 at 10:24, Grazvydas Ignotas wrote: >> That indeed helps, thanks. >> I guess it becomes "--with-dri-driverdir is broken by this commit" then. >> > I'm not setting with-dri-driverdir, which would explain why I'm not > seeing any issues her

Re: [Mesa-dev] [PATCH 7/8] android: support creating texture from gralloc buffer

2017-05-08 Thread Rob Herring
On Sat, May 6, 2017 at 7:37 AM, Tomasz Figa wrote: > On Sat, May 6, 2017 at 2:14 AM, Rob Herring wrote: >> On Mon, May 1, 2017 at 9:55 AM, Tomasz Figa wrote: >>> On Mon, May 1, 2017 at 11:17 PM, Mauro Rossi wrote: Hi all, another try to merge android swrast patches in mesa 17.1 o

Re: [Mesa-dev] 17.1 cherry-pick request (Polarsi12 fix)

2017-05-08 Thread Marek Olšák
On Mon, May 8, 2017 at 2:29 PM, Emil Velikov wrote: > On 5 May 2017 at 00:36, Marek Olšák wrote: >> Hi Emil, >> >> Can we please get this into the 17.1 release? >> https://cgit.freedesktop.org/mesa/mesa/commit/?id=69e6eab6533ff48f72223cd21ef640242c52598b >> > Done - It is part of Mesa 17.1.0-rc4,

Re: [Mesa-dev] [PATCH RFC 4/4] dri: Turn of a couple of glx extensions for gnome-shell on vmwgfx.

2017-05-08 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Fri, May 5, 2017 at 4:02 PM, Thomas Hellstrom wrote: > Increases performance on vmwgfx since we're avoiding full buffer damage and > since we can't sync to vertical retrace anyway. > > Signed-off-by: Thomas Hellstrom > --- > src/mesa/drivers/

[Mesa-dev] [Bug 100151] Front buffer drawing mode shows black window with gallium software rasterizers

2017-05-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100151 --- Comment #8 from Anton Starikov --- Actually, I build and installed 17.0.5 for Centos-7 and issue remains here. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

Re: [Mesa-dev] [PATCH] bin/get-fixes-pick-list.sh: don't warn if more than one, go over them

2017-05-08 Thread Andres Gomez
On Mon, 2017-05-08 at 13:41 +0100, Emil Velikov wrote: > On 8 May 2017 at 11:52, Andres Gomez wrote: > > On Mon, 2017-05-08 at 10:56 +0100, Emil Velikov wrote: > > > On 6 May 2017 at 15:09, Andres Gomez wrote: > > > > If an identified commit was having more than one fix, we would warn > > > > abo

[Mesa-dev] [Bug 99638] Mesa opengles Peppa Pig and openggles2 smurfs on Radeon PowerPC and PPC64

2017-05-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99638 --- Comment #21 from intermedi...@hotmail.com --- (In reply to Ilia Mirkin from comment #13) > (In reply to Daniel Stone from comment #7) > > At a blind guess, I'm going to say that this is because Wayland's formats > > are defined as DRM's are,

Re: [Mesa-dev] [PATCH] configure.ac: Also match -androideabi tuple

2017-05-08 Thread Emil Velikov
On 5 May 2017 at 23:40, Chad Versace wrote: > On Fri 05 May 2017, Nicolas Boichat wrote: >> From: Nicolas Boichat >> >> On ARM Android platforms, the host_os tuple should be linux-androideabi, >> so let's match both -android and -androideabi (or any other >> -android* tuple) to determine if we sh

Re: [Mesa-dev] [PATCH] egl: Fix -Wint-to-pointer-cast

2017-05-08 Thread Emil Velikov
On 5 May 2017 at 20:27, Chad Versace wrote: > main/egldisplay.c: In function '_eglParseX11DisplayAttribList': > main/egldisplay.c:491:38: warning: cast to pointer from integer of different > size [-Wint-to-pointer-cast] > display->Options.Platform = (void *)value; > > The fix: cast to u

  1   2   >