Could you push it for me?
On Mon, Apr 10, 2017 at 4:06 AM, Timothy Arceri
wrote:
> Thanks.
>
> Reviewed-by: Timothy Arceri
>
>
> On 10/04/17 02:37, Bartosz Tomczyk wrote:
>
>> ---
>> src/mesa/program/arbprogparse.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/src/mesa/program/ar
Den 11 apr. 2017 20:00 skrev "Samuel Pitoiset" :
Fixes the following Clang warning.
In file included from radeon_debug.c:32:
./radeon_common_context.h:500:19: warning: duplicate 'const' declaration
specifier [-Wduplicate-decl-specifier]
extern const char const *radeonVendorString;
Signed-off-by:
I've pushed this. Thanks for getting to the bottom of the problem :)
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 04/11/2017 02:15 PM, Marek Olšák wrote:
From: Marek Olšák
New interface:
union pipe_buffer_binding {
struct pipe_resource *buffer; /**< the actual buffer */
const void *user_buffer; /**< pointer to a user buffer */
};
struct pipe_vertex_buffer
{
uint16_t stride;/**< strid
On 12/04/17 02:48, Samuel Pitoiset wrote:
Used by glsl_to_tgsi.
Signed-off-by: Samuel Pitoiset
---
src/compiler/glsl_types.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/compiler/glsl_types.cpp b/src/compiler/glsl_types.cpp
index cf0fe71d1a..6854169646 100644
-
Reviewed-by: Timothy Arceri
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 12/04/17 02:48, Samuel Pitoiset wrote:
Only ast_fully_specified_type is able to know if the underlying
type is bindless or not. Because type_specifier is a subrule of
fully_specified_type this shouldn't break anything.
This will help for handling explicit conversions like
'sampler2D tex = sam
On 12/04/17 02:48, Samuel Pitoiset wrote:
The ARB_bindless_texture spec says:
"Modify Section 4.3.4, Inputs, p. 34"
"(modify last paragraph, p. 35, allowing samplers and images as
fragment shader inputs) ... Fragment inputs can only be signed
and unsigned integers and integer vect
From: "Mun, Gwan-gyeong"
Add platform_tizen.c that supports _EGL_PLATFORM_TIZEN. It works with libtpl-egl
(Tizen Porting Layer for egl), libtbm(Tizen Buffer Manager) where back buffers
of windows are backed by GEM objects.
In Tizen a native window has a queue (tbm_surface_queue) of back buffers
From: "Mun, Gwan-gyeong"
It checks tpl-egl/libtbm/libtdm packages and defines HAVE_EGL_PLATFORM_TIZEN.
This feature is enabled by the config option '--with-egl-platforms=tizen'
Signed-off-by: Mun Gwan-gyeong
---
configure.ac | 5 +
1 file changed, 5 insertions(+)
diff --git a/configure.ac
Hello,
these commit series introduce supporting of Tizen to mesa's egl platform.
It is tested on rpi3 with Tizen Platform.
Below repository includes packaging info for tizen.
https://github.com/elongbug/mesa/tree/tizen_work
(this file includes build option for vc4 -
https://github.com/elongbu
Hello,
these commit series introduce supporting of Tizen to mesa's egl platform.
It is tested on rpi3 with Tizen Platform.
Below repository includes packaging info for tizen.
https://github.com/elongbug/mesa/tree/tizen_work
(this file includes build option for vc4 -
https://github.com/elongbu
Reviewed-by: Timothy Arceri
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Timothy Arceri
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
https://bugs.freedesktop.org/show_bug.cgi?id=99618
Bruce Cherniak changed:
What|Removed |Added
Resolution|--- |FIXED
Status|ASSIGNED
Reviewed-by: Timothy Arceri
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 12/04/17 02:48, Samuel Pitoiset wrote:
The GL_ARB_bindless_texture spec allows images to be declared as
shader inputs.
Signed-off-by: Samuel Pitoiset
---
src/compiler/glsl/ast_type.cpp | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/compiler/glsl/ast_type.cpp b/src/co
On 12/04/17 02:48, Samuel Pitoiset wrote:
Bindless images can be explicitely converted to and from uvec2
using scalar constructors.
Signed-off-by: Samuel Pitoiset
---
src/compiler/glsl/ast_to_hir.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/glsl/ast_to_h
On 12/04/17 02:48, Samuel Pitoiset wrote:
The ARB_bindless_texture spec says:
"Replace Section 4.1.X, (Images)"
"Images may be declared as shader inputs and outputs, as uniform
variables, as temporary variables, and as function parameters."
Signed-off-by: Samuel Pitoiset
---
src/
Patches 10-11:
Reviewed-by: Timothy Arceri
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 12 April 2017 at 09:16, Bas Nieuwenhuizen wrote:
> Makes more sense when we hash the layout for the pipeline cache.
For the series:
Reviewed-by: Dave Airlie
>
> Signed-off-by: Bas Nieuwenhuizen
> ---
> src/amd/common/ac_nir_to_llvm.c | 12 ++-
> src/amd/vulkan/radv_descriptor_
On 12 April 2017 at 08:48, Bas Nieuwenhuizen wrote:
> The outer result was referred to, which meant bugs.
>
> Signed-off-by: Bas Nieuwenhuizen
Oops,
Reviewed-by: Dave Airlie
> ---
> src/amd/vulkan/radv_query.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/s
On 12/04/17 02:48, Samuel Pitoiset wrote:
At this point, there is enough information to take the decision
to replace a sampler/image type by the corresponding bindless one.
Signed-off-by: Samuel Pitoiset
---
src/compiler/glsl/ast.h | 10 -
src/compiler/glsl/ast_to_hir.cpp | 93 +
Patches 2-5:
Reviewed-by: Timothy Arceri
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 12/04/17 02:48, Samuel Pitoiset wrote:
This adds bindless_sampler and bound_sampler (and respectively
bindless_image and bound_image) to the parser.
Signed-off-by: Samuel Pitoiset
---
src/compiler/glsl/ast.h | 8 +
src/compiler/glsl/ast_to_hir.cpp | 55 ++
On 12 April 2017 at 09:27, Dave Airlie wrote:
> From: Dave Airlie
>
> sync_file uses the reference count of the file, the internal
> kref was never getting moved past 1.
oops typoed my send script, thanks Bas for pointing it out.
Wrong list.
Dave.
__
Reviewed-by: Timothy Arceri
On 12/04/17 03:58, Samuel Pitoiset wrote:
Fixes the following Clang warnings.
brw_fs_channel_expressions.cpp:219:12: warning: enumeration values
'ir_unop_ballot', 'ir_unop_read_first_invocation', and
'ir_binop_read_invocation' not handled in switch [-Wswitch]
s
Reviewed-by: Timothy Arceri
On 12/04/17 03:58, Samuel Pitoiset wrote:
Fixes the following Clang warning.
main/marshal.c:209:1: warning: unused function '_mesa_unmarshal_BindBufferBase'
[-Wunused-function]
_mesa_unmarshal_BindBufferBase(struct gl_context *ctx, const struct
marshal_cmd_BindBuf
From: Dave Airlie
sync_file uses the reference count of the file, the internal
kref was never getting moved past 1.
We can reintroduce this if we decide we need it later.
Signed-off-by: Dave Airlie
---
drivers/dma-buf/sync_file.c | 13 ++---
include/linux/sync_file.h | 1 -
2 files
Since the shader code can include them.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_descriptor_set.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/amd/vulkan/radv_descriptor_set.c
b/src/amd/vulkan/radv_descriptor_set.c
index ba5d5eb75e5..c048a4c7f53 100644
--- a/src/am
Makes more sense when we hash the layout for the pipeline cache.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/common/ac_nir_to_llvm.c | 12 ++-
src/amd/vulkan/radv_descriptor_set.c | 42
src/amd/vulkan/radv_descriptor_set.h | 10 +++--
src/am
When trying to test these I notice that even without the patches clover
isn't compiling
/var/tmp/portage/media-libs/mesa-/work/mesa-/src/gallium/state_trackers/clover/llvm/codegen/common.cpp:132:54:
error: ‘Offset’ is not a member of ‘clang::LangAS’
On Wed, Apr 12, 2017 at 12:48 AM, Dave Airlie wrote:
> On 12 April 2017 at 08:19, Bas Nieuwenhuizen wrote:
>> On Wed, Apr 12, 2017 at 12:04 AM, Thomas Hindoe Paaboel Andersen
>> wrote:
>>> ---
>>> src/amd/vulkan/radv_wsi.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff -
The outer result was referred to, which meant bugs.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_query.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/amd/vulkan/radv_query.c b/src/amd/vulkan/radv_query.c
index bd293b58e69..fa5a3b6df24 100644
--- a/s
On 12 April 2017 at 08:19, Bas Nieuwenhuizen wrote:
> On Wed, Apr 12, 2017 at 12:04 AM, Thomas Hindoe Paaboel Andersen
> wrote:
>> ---
>> src/amd/vulkan/radv_wsi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/amd/vulkan/radv_wsi.c b/src/amd/vulkan/radv_wsi.c
>>
On Wed, Apr 12, 2017 at 12:27 AM, Roland Scheidegger wrote:
> As mentioned before, I'm not exactly thrilled by this (as I just happen
> to like the old interface), but could live with it for GL's performance
> sake, if others like that. I suppose though you'd have quite some code
> to adapt...
> A
As mentioned before, I'm not exactly thrilled by this (as I just happen
to like the old interface), but could live with it for GL's performance
sake, if others like that. I suppose though you'd have quite some code
to adapt...
Are those performance numbers with just this patch or all 3?
Roland
A
Patches 1 & 6 are
Reviewed-by: Bas Nieuwenhuizen
On Wed, Apr 12, 2017 at 12:03 AM, Thomas Hindoe Paaboel Andersen
wrote:
> From 1811ccf1
> ---
> src/amd/vulkan/radv_device.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
>
On Wed, Apr 12, 2017 at 12:04 AM, Thomas Hindoe Paaboel Andersen
wrote:
> ---
> src/amd/vulkan/radv_wsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_wsi.c b/src/amd/vulkan/radv_wsi.c
> index b8999f4..37cb322 100644
> --- a/src/amd/vulkan/radv_wsi.
---
src/intel/tools/aubinator_error_decode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/intel/tools/aubinator_error_decode.c
b/src/intel/tools/aubinator_error_decode.c
index 2e62369..5df8aaf 100644
--- a/src/intel/tools/aubinator_error_decode.c
+++ b/src/intel/tools
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 --
src/mesa/drivers/dri/i965/intel_pixel_draw.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
index 81e2d6e..5d5c77f 100644
--- a/src/mesa/
---
src/mesa/state_tracker/st_cb_texture.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/mesa/state_tracker/st_cb_texture.c
b/src/mesa/state_tracker/st_cb_texture.c
index 99c59f7..73f784d 100644
--- a/src/mesa/state_tracker/st_cb_texture.c
+++ b/src/mesa/state_tracker/
---
src/mesa/main/shaderapi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
index 187475f..9efb2e0 100644
--- a/src/mesa/main/shaderapi.c
+++ b/src/mesa/main/shaderapi.c
@@ -1110,7 +1110,7 @@ _mesa_link_program(struct gl_c
---
src/util/disk_cache.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c
index d9de8ef..93fb1f5 100644
--- a/src/util/disk_cache.c
+++ b/src/util/disk_cache.c
@@ -891,10 +891,8 @@ cache_put(void *job, int thread_in
---
src/intel/vulkan/anv_image.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index cf34dbe..9bf446a 100644
--- a/src/intel/vulkan/anv_image.c
+++ b/src/intel/vulkan/anv_image.c
@@ -183,7 +183,7 @@ make_surface(cons
---
src/amd/vulkan/radv_pipeline.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
index cf11362..e3eacf3 100644
--- a/src/amd/vulkan/radv_pipeline.c
+++ b/src/amd/vulkan/radv_pipeline.c
@@ -585,8 +585,7 @
From 1811ccf1
---
src/amd/vulkan/radv_device.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 5f14394..9138a00 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -749,7 +749,6 @@ void radv_GetPhysi
---
src/amd/vulkan/radv_wsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_wsi.c b/src/amd/vulkan/radv_wsi.c
index b8999f4..37cb322 100644
--- a/src/amd/vulkan/radv_wsi.c
+++ b/src/amd/vulkan/radv_wsi.c
@@ -210,7 +210,7 @@ radv_wsi_image_create(VkDevice d
A mix of fixes for static analysis warnings, recent indentation
mistakes, and unnecessary null checks before free.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Signed-off-by: Bas Nieuwenhuizen
Fixes: 8475a14302e ("radv: Implement pipeline statistics queries.")
---
src/amd/vulkan/radv_query.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/amd/vulkan/radv_query.c b/src/amd/vulkan/radv_query.c
index 07cb6404149..9f54287c363
Signed-off-by: Bas Nieuwenhuizen
Fixes: 8475a14302e ("radv: Implement pipeline statistics queries.")
---
src/amd/vulkan/radv_query.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/amd/vulkan/radv_query.c b/src/amd/vulkan/radv_query.c
index 9f54287c363..bd293b58e69 100644
--- a/src/
On Tue, Apr 11, 2017 at 12:59 PM, Daniel Vetter wrote:
> On Tue, Apr 11, 2017 at 07:59:18PM +0100, Chris Wilson wrote:
> > On Tue, Apr 11, 2017 at 09:02:51AM -0700, Kenneth Graunke wrote:
> > > If we have buffers larger than 4GB, then target_offset will need to
> > > become a 64-bit value. Delta
On Tuesday, April 11, 2017 11:59:18 AM PDT Chris Wilson wrote:
> On Tue, Apr 11, 2017 at 09:02:51AM -0700, Kenneth Graunke wrote:
> > If we have buffers larger than 4GB, then target_offset will need to
> > become a 64-bit value. Delta is only a __u32 though, so we downcast.
> >
> > Suggested by C
I suppose why not... Though if you're really concerned about a couple
bytes here for the simple case, you could probably make streamout part
of the indirect case too (or call it "extended" then) and save another 8
bytes even...
Roland
Am 11.04.2017 um 22:15 schrieb Marek Olšák:
> From: Marek Olšá
This looks ok to me (though I hope uint16_t for stride isn't a problem).
Although it doesn't save all that much...
Roland
Am 11.04.2017 um 22:15 schrieb Marek Olšák:
> From: Marek Olšák
>
> New interface:
>
> union pipe_buffer_binding {
>struct pipe_resource *buffer; /**< the actual buffe
You could remove the half_line_width in the struct wideline_stage too
while you're at it - I think the whole reason why the wideline_stage()
function existed in the first place was to have easy access to that
variable.
But either way,
Reviewed-by: Roland Scheidegger
Am 11.04.2017 um 21:58 schrieb
Reviewed-by: Roland Scheidegger
Am 11.04.2017 um 21:59 schrieb Samuel Pitoiset:
> Fixes the following Clang warnings.
>
> lp_setup_tri.c:55:1: warning: unused function 'subpixel_snap'
> [-Wunused-function]
> subpixel_snap(float a)
> ^
> lp_setup_tri.c:61:1: warning: unused function 'fixed_to_fl
So I think we need to reset both command buffer states (the enable and
the index) when we call a secondary command buffer.
With that fixed, this patch is
Reviewed-by: Bas Nieuwenhuizen
On Tue, Apr 11, 2017 at 3:30 PM, Alex Smith wrote:
> According to the Vulkan spec, VkPipelineInputAssemblySta
On 04/11/2017 07:28 PM, Ilia Mirkin wrote:
On Tue, Apr 11, 2017 at 12:48 PM, Samuel Pitoiset
wrote:
For replacing sampler/image types to the corresponding bindless
type, it's convenient to re-use get_{sampler,image}_instance()
instead of doing a one-by-one comparison.
Signed-off-by: Samuel P
Context: _mesa_add_parameter is sometimes[0] called with a
NULL name as a mean of an unnamed parameter.
Allowing NULL pointer as a name means that it must be NULL checked
each access. So far it isn't always[1] true.
Parameter name is only used for debug purpose (printf) and
to lookup the index/lo
From: Marek Olšák
pipe_draw_info::indexed is replaced with index_size. index_size == 0 means
non-indexed.
Instead of pipe_index_buffer::offset, pipe_draw_info::start is used.
For indexed indirect draws, pipe_draw_info::start is added to the indirect
start. This is the only case when "start" affe
From: Marek Olšák
For faster initialization of non-indirect draws.
---
src/gallium/include/pipe/p_state.h | 67 --
1 file changed, 35 insertions(+), 32 deletions(-)
diff --git a/src/gallium/include/pipe/p_state.h
b/src/gallium/include/pipe/p_state.h
index 95
From: Marek Olšák
New interface:
union pipe_buffer_binding {
struct pipe_resource *buffer; /**< the actual buffer */
const void *user_buffer; /**< pointer to a user buffer */
};
struct pipe_vertex_buffer
{
uint16_t stride;/**< stride to same attrib in next vertex, in bytes */
We only do on-demand renderbuffer allocation for window-system FBOs,
not user-created FBOs. So put the loop inside a conditional.
Plus, add some comments. No piglit regressions.
---
src/mesa/state_tracker/st_cb_fbo.c | 24
1 file changed, 16 insertions(+), 8 deletions(-
A few functions related to FBOs/renderbuffers should only be used with
window-system buffers, not user-created FBOs. Assert for that.
Add additional comments. No piglit regressions.
---
src/mesa/state_tracker/st_cb_fbo.c | 1 +
src/mesa/state_tracker/st_manager.c | 10 --
2 files chang
You are right, my fault.
On 04/11/2017 08:31 PM, Roland Scheidegger wrote:
subpixel_snap is very much used (fixed_to_float, not so much), so you
can't get rid of it.
If you want you can place it into a #if !defined(PIPE_ARCH_SSE) clause
though...
Roland
Am 11.04.2017 um 19:58 schrieb Samuel Pi
Fixes the following Clang warnings.
lp_setup_tri.c:55:1: warning: unused function 'subpixel_snap'
[-Wunused-function]
subpixel_snap(float a)
^
lp_setup_tri.c:61:1: warning: unused function 'fixed_to_float'
[-Wunused-function]
fixed_to_float(int a)
^
v2: - do not remove subpixel_snap() (use !PIP
On Tue, Apr 11, 2017 at 07:59:18PM +0100, Chris Wilson wrote:
> On Tue, Apr 11, 2017 at 09:02:51AM -0700, Kenneth Graunke wrote:
> > If we have buffers larger than 4GB, then target_offset will need to
> > become a 64-bit value. Delta is only a __u32 though, so we downcast.
> >
> > Suggested by Ch
Fixes the following Clang warning.
draw/draw_pipe_wide_line.c:48:38: warning: unused function 'wideline_stage'
[-Wunused-function]
static inline struct wideline_stage *wideline_stage( struct draw_stage *stage )
^
1 warning generated.
v2: - remove commented co
Entire set Reviewed-by: Bruce Cherniak
> On Apr 10, 2017, at 11:45 AM, Tim Rowley wrote:
>
> Highlights; compile time fix, simd16 work, code cleanup.
>
> Tim Rowley (12):
> swr: [rasterizer core] Reduce templates to speed compile
> swr: [rasterizer core] Multisample sample position setup cha
On Tue, Apr 11, 2017 at 11:27 AM, Chris Wilson
wrote:
> On Tue, Apr 11, 2017 at 10:58:41AM -0700, Jason Ekstrand wrote:
> > Cc: "Juan A. Suárez"
> > ---
> > src/intel/vulkan/anv_device.c | 17 +
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/src/intel/vulkan/anv_devic
Hi Bas,
it seems like this junk
+ nir_intrinsic_instr *store = nir_intrinsic_instr_create(b.shader,
nir_intrinsic_store_ssbo);
+ store->src[0] = nir_src_for_ssa(available);
+ store->src[1] = nir_src_for_ssa(&dst_buf->dest.ssa);
+ store->src[2] = nir_src_for_ssa(nir_iadd(
On Tue, Apr 11, 2017 at 09:02:51AM -0700, Kenneth Graunke wrote:
> If we have buffers larger than 4GB, then target_offset will need to
> become a 64-bit value. Delta is only a __u32 though, so we downcast.
>
> Suggested by Chris Wilson.
> ---
> src/mesa/drivers/dri/i965/intel_batchbuffer.c | 4 +
Note there's commented out code which uses it. So either get rid of that
too, plus whatever was in that stage (half_line_width), or keep it,
otherwise it's just less obvious these things aren't used.
Roland
Am 11.04.2017 um 19:58 schrieb Samuel Pitoiset:
> Fixes the following Clang warning.
>
>
subpixel_snap is very much used (fixed_to_float, not so much), so you
can't get rid of it.
If you want you can place it into a #if !defined(PIPE_ARCH_SSE) clause
though...
Roland
Am 11.04.2017 um 19:58 schrieb Samuel Pitoiset:
> Fixes the following Clang warnings.
>
> lp_setup_tri.c:55:1: warnin
Reviewed-by: Roland Scheidegger
Am 11.04.2017 um 19:58 schrieb Samuel Pitoiset:
> Fixes the following Clang warning.
>
> draw/draw_pipe_vbuf.c:102:1: warning: unused function 'overflow'
> [-Wunused-function]
> overflow( void *map, void *ptr, unsigned bytes, unsigned bufsz )
> ^
> 1 warning gene
On Tue, Apr 11, 2017 at 10:58:41AM -0700, Jason Ekstrand wrote:
> Cc: "Juan A. Suárez"
> ---
> src/intel/vulkan/anv_device.c | 17 +
> 1 file changed, 17 insertions(+)
>
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index 35ef4c4..b24c739 100644
>
v2 (Jason Ekstrand):
- Limit to 2GB instead of 4GB
v3 (Jason Ekstrand):
- Fix the build by using pAllocateInfo instead of pAllocationInfo (not
sure how that happened).
- Return vK_ERROR_OUT_OF_DEVICE_MEMORY (Thanks Ilia!)
Cc: "Juan A. Suárez"
---
src/intel/vulkan/anv_device.c | 20 +++
On 04/11/2017 11:58 AM, Samuel Pitoiset wrote:
Noticed while building my whole ARB_bindless_texture work to avoid
missing switch cases, etc. This series doesn't fix all warnings, just
the easy ones.
Please, review!
Thanks.
For 1-14, Reviewed-by: Brian Paul
-Brian
Samuel Pitoiset (15):
On Tue, Apr 11, 2017 at 11:03 AM, Ilia Mirkin wrote:
> On Tue, Apr 11, 2017 at 1:58 PM, Jason Ekstrand
> wrote:
> > Cc: "Juan A. Suárez"
> > ---
> > src/intel/vulkan/anv_device.c | 17 +
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/src/intel/vulkan/anv_device.c
> b
On Tue, Apr 11, 2017 at 1:58 PM, Jason Ekstrand wrote:
> Cc: "Juan A. Suárez"
> ---
> src/intel/vulkan/anv_device.c | 17 +
> 1 file changed, 17 insertions(+)
>
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index 35ef4c4..b24c739 100644
> --- a/sr
Cc: "Juan A. Suárez"
---
src/intel/vulkan/anv_device.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index 35ef4c4..4aa0340 100644
--- a/src/intel/vulkan/anv_device.c
+++ b/src/intel/vulkan/anv_device.c
@@ -153
On 17-04-11 17:11:55, Chris Wilson wrote:
Jump through the layers of abstraction between egl and dri in order to
feed the context priority attribute through to the backend. This
requires us to read the value from the base _egl_context, convert it to
a DRI attribute, parse it again in the generic
Fixes the following Clang warning.
In file included from radeon_debug.c:32:
./radeon_common_context.h:500:19: warning: duplicate 'const' declaration
specifier [-Wduplicate-decl-specifier]
extern const char const *radeonVendorString;
Signed-off-by: Samuel Pitoiset
---
src/mesa/drivers/dri/radeo
state_tracker/st_atom_framebuffer.c:208:27: warning: comparison of constant
4294967295 with expression of type 'uint16_t' (aka 'unsigned short') is always
false [-Wtautological-constant-out-of-range-compare]
if (framebuffer->width == UINT_MAX)
~~ ^
state_tracke
Fixes the following Clang warnings.
lp_setup_tri.c:55:1: warning: unused function 'subpixel_snap'
[-Wunused-function]
subpixel_snap(float a)
^
lp_setup_tri.c:61:1: warning: unused function 'fixed_to_float'
[-Wunused-function]
fixed_to_float(int a)
^
Signed-off-by: Samuel Pitoiset
---
src/gall
Fixes the following Clang warning.
draw/draw_pipe_vbuf.c:102:1: warning: unused function 'overflow'
[-Wunused-function]
overflow( void *map, void *ptr, unsigned bytes, unsigned bufsz )
^
1 warning generated.
Signed-off-by: Samuel Pitoiset
---
src/gallium/auxiliary/draw/draw_pipe_vbuf.c | 8 ---
Fixes the following Clang warnings.
brw_fs_channel_expressions.cpp:219:12: warning: enumeration values
'ir_unop_ballot', 'ir_unop_read_first_invocation', and
'ir_binop_read_invocation' not handled in switch [-Wswitch]
switch (expr->operation) {
^
1 warning generated.
Signed-off-by
Fixes the following Clang warning.
vmw_screen_dri.c:130:1: warning: unused function 'vmw_dri1_intersect_src_bbox'
[-Wunused-function]
vmw_dri1_intersect_src_bbox(struct drm_clip_rect *dst,
^
1 warning generated.
Signed-off-by: Samuel Pitoiset
---
src/gallium/winsys/svga/drm/vmw_screen_dri.c |
Fixes the following Clang warning.
sp_fs_exec.c:56:1: warning: unused function 'sp_exec_fragment_shader'
[-Wunused-function]
sp_exec_fragment_shader(const struct sp_fragment_shader_variant *var)
^
1 warning generated.
Signed-off-by: Samuel Pitoiset
---
src/gallium/drivers/softpipe/sp_fs_exec.c
Fixes the following Clang warnings.
tr_dump.c:137:1: warning: unused function 'trace_dump_tag' [-Wunused-function]
trace_dump_tag(const char *name)
^
tr_dump.c:168:1: warning: unused function 'trace_dump_tag_begin2'
[-Wunused-function]
trace_dump_tag_begin2(const char *name,
^
tr_dump.c:187:1: wa
Fixes the following Clang warning.
sp_tex_sample.c:802:1: warning: unused function 'get_texel_quad_2d'
[-Wunused-function]
get_texel_quad_2d(const struct sp_sampler_view *sp_sview,
^
CC sp_tile_cache.lo
1 warning generated.
Signed-off-by: Samuel Pitoiset
---
src/gallium/drivers/softpip
Fixes the following Clang warning.
sp_quad_fs.c:60:1: warning: unused function 'quad_shade_stage'
[-Wunused-function]
quad_shade_stage(struct quad_stage *qs)
^
1 warning generated.
Signed-off-by: Samuel Pitoiset
---
src/gallium/drivers/softpipe/sp_quad_fs.c | 8
1 file changed, 8 dele
Fixes the following Clang warning.
virgl_screen.c:60:12: warning: enumeration value 'PIPE_CAP_DOUBLES' not handled
in switch [-Wswitch]
switch (param) {
^
1 warning generated.
Signed-off-by: Samuel Pitoiset
---
src/gallium/drivers/virgl/virgl_screen.c | 1 +
1 file changed, 1 ins
Fixes the following Clang warnings.
main/performance_monitor.c:157:1: warning: unused function 'index_to_queryid'
[-Wunused-function]
index_to_queryid(GLuint index)
^
main/performance_monitor.c:163:1: warning: unused function 'queryid_valid'
[-Wunused-function]
queryid_valid(const struct gl_cont
Fixes the following Clang warning.
draw/draw_pipe_wide_line.c:48:38: warning: unused function 'wideline_stage'
[-Wunused-function]
static inline struct wideline_stage *wideline_stage( struct draw_stage *stage )
^
1 warning generated.
Signed-off-by: Samuel Pit
Fixes the following Clang warnings.
main/pack.c:470:1: warning: unused function 'clamp_float_to_uint'
[-Wunused-function]
clamp_float_to_uint(GLfloat f)
^
main/pack.c:477:1: warning: unused function 'clamp_half_to_uint'
[-Wunused-function]
clamp_half_to_uint(GLhalfARB h)
^
2 warnings generated.
Fixes the following Clang warning.
main/marshal.c:209:1: warning: unused function '_mesa_unmarshal_BindBufferBase'
[-Wunused-function]
_mesa_unmarshal_BindBufferBase(struct gl_context *ctx, const struct
marshal_cmd_BindBufferBase *cmd)
^
1 warning generated.
Signed-off-by: Samuel Pitoiset
---
Noticed while building my whole ARB_bindless_texture work to avoid
missing switch cases, etc. This series doesn't fix all warnings, just
the easy ones.
Please, review!
Thanks.
Samuel Pitoiset (15):
virgl: add missing PIPE_CAP_DOUBLES
mesa: remove unused _mesa_unmarshal_BindBufferBase()
mesa
Cc: "Juan A. Suárez"
---
src/intel/vulkan/anv_device.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index 35ef4c4..b24c739 100644
--- a/src/intel/vulkan/anv_device.c
+++ b/src/intel/vulkan/anv_device.c
@@ -153
1 - 100 of 187 matches
Mail list logo
