[Mesa-dev] [Bug 100303] Adding a single, meaningless if-else to a shader source leads to different image

2017-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100303 --- Comment #5 from Roland Scheidegger --- (In reply to Timothy Arceri from comment #4) > (In reply to Roland Scheidegger from comment #2) > > > > So, for some reason the compiler completely eliminated the conditional > > return in the loop ins

[Mesa-dev] [Bug 100303] Adding a single, meaningless if-else to a shader source leads to different image

2017-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100303 --- Comment #4 from Timothy Arceri --- (In reply to Roland Scheidegger from comment #2) > > So, for some reason the compiler completely eliminated the conditional > return in the loop inside the branch and figured it will just > unconditionally

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: Apply flush operations prior to executing secondaries

2017-03-25 Thread Jason Ekstrand
On March 25, 2017 2:54:41 PM Lionel Landwerlin wrote: Hey Jason, I'm wondering whether we're missing flushing some dynamic state here too. Nope, the client is required to re-emit it all at the top of the secondary. Regardless, the flushing you're adding here is definitely required : Revi

[Mesa-dev] [Bug 100303] Adding a single, meaningless if-else to a shader source leads to different image

2017-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100303 --- Comment #3 from Roland Scheidegger --- Here's a simplified example, not even the empty branch is necessary, it is sufficient if the return is inside a loop which is inside a conditional (I'm actually wondering why this isn't hit in ordinary

[Mesa-dev] [Bug 100303] Adding a single, meaningless if-else to a shader source leads to different image

2017-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100303 --- Comment #2 from Roland Scheidegger --- This is the output of glsl_compiler --dump_lir --version=100 original.frag for the getHardShadow function: ( function getHardShadow (signature float (parameters (declare (in ) vec3 ro)

[Mesa-dev] [PATCH 2/2] aubinator: enable snb/ilk through --gen

2017-03-25 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 68fd18cd68..322f0df523 100644 --- a/src/intel/tools/aubinator.c +++ b/src/intel/tools/aubinator.c @@ -1136,6 +1136

[Mesa-dev] [PATCH 1/2] intel: genxml: compress all gen files into one

2017-03-25 Thread Lionel Landwerlin
Combining all the files into a single string didn't make any difference in the size of the aubinator binary. With this change we now also embed gen4/4.5/5 descriptions, which increases the aubinator size by ~16Kb. Signed-off-by: Lionel Landwerlin --- src/intel/Makefile.genxml.am| 10 +++

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: Apply flush operations prior to executing secondaries

2017-03-25 Thread Lionel Landwerlin
Hey Jason, I'm wondering whether we're missing flushing some dynamic state here too. Regardless, the flushing you're adding here is definitely required : Reviewed-by: Lionel Landwerlin Thanks! On 24/03/17 23:31, Jason Ekstrand wrote: Cc: "13.0 17.0" --- src/intel/vulkan/genX_cmd_buffer.c

Re: [Mesa-dev] [PATCH kmscube 3/3] meson build support

2017-03-25 Thread Dylan Baker
Quoting Rob Clark (2017-03-25 13:11:46) > Figured I should figure out what this meson stuff is all about. After a > bit of hunting around to find examples to look at (and interruptions) it > took maybe ~1hr to convert (for someone who never looked at meson > before). The build speed is definitely

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-25 Thread Rob Clark
On Fri, Mar 24, 2017 at 11:47 AM, Jose Fonseca wrote: > > Like I said in another email, maybe mesademos is a good way to get our feet > wet. jfwiw, I decided to figure out what this meson stuff is all about, and converted kmscube (after adding an optional bit for video-cube, to make it *slightly*

[Mesa-dev] [PATCH kmscube 1/3] add license file

2017-03-25 Thread Rob Clark
Signed-off-by: Rob Clark --- COPYING | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 COPYING diff --git a/COPYING b/COPYING new file mode 100644 index 000..7fb42c7 --- /dev/null +++ b/COPYING @@ -0,0 +1,18 @@ +Permission is hereby granted, free of charge, to any

[Mesa-dev] [PATCH kmscube 2/3] add video cube

2017-03-25 Thread Rob Clark
Uses gstreamer for a simple decoder. If decoder can give us dma-buf's directly, we'll directly use that as a texture (zero copy), otherwise memcpy into a buffer from gbm. This should work with both hw and sw decoders. Probably room for improvement. And the interface between gl and the decoder i

[Mesa-dev] [PATCH kmscube 3/3] meson build support

2017-03-25 Thread Rob Clark
Figured I should figure out what this meson stuff is all about. After a bit of hunting around to find examples to look at (and interruptions) it took maybe ~1hr to convert (for someone who never looked at meson before). The build speed is definitely faster even after Emil's auto- tools improvemen

[Mesa-dev] [Bug 99496] Dolphin emulator: Launching Mario Kart Wii results in a blank window/black screen and freeze.

2017-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99496 Christian Lanig changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH kmscube 5/7] drm-atomic.c: remove unused variables `gpu_fence_fd`, `kms_fence_fd`

2017-03-25 Thread Rob Clark
On Wed, Mar 15, 2017 at 6:06 AM, Emil Velikov wrote: > On 14 March 2017 at 13:33, Eric Engestrom wrote: >> Signed-off-by: Eric Engestrom >> --- >> I feel like I might be missing something here; is copying the fields >> into these vars of any use when debugging? > Well places question. > > Last t

Re: [Mesa-dev] [PATCH v5 1/5] genxml: New generated header genX_bits.h (v5)

2017-03-25 Thread Dylan Baker
Oh, for what it's worth (since I wrote part of this), with the one .keys() thing changed: Reviewed-by: Dylan Baker signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listi

Re: [Mesa-dev] [PATCH v5 1/5] genxml: New generated header genX_bits.h (v5)

2017-03-25 Thread Dylan Baker
Quoting Chad Versace (2017-03-24 19:28:23) > genX_bits.h contains the sizes of bitfields in genxml instructions, > structures, and registers. It also defines some functions to query those > sizes. > > isl_surf_init() will use the new header to validate that requested > pitches fit in their destina

Re: [Mesa-dev] [PATCH v5 0/5] isl: Fix requests for exact row pitch

2017-03-25 Thread Jason Ekstrand
Sorry for all my pedantry. This looks really good now. I left a few fairly trivial comments. Series is Reviewed-by: Jason Ekstrand On March 24, 2017 7:28:29 PM Chad Versace wrote: All callers of isl_surf_init() that set 'min_pitch' wanted to request an *exact* row pitch, as evidenced by

Re: [Mesa-dev] [PATCH v5 2/5] isl: Validate the calculated row pitch (v4)

2017-03-25 Thread Jason Ekstrand
On March 24, 2017 7:29:05 PM Chad Versace wrote: Validate that isl_surf::row_pitch fits in the below bitfields, if applicable based on isl_surf::usage. RENDER_SURFACE_STATE::SurfacePitch RENDER_SURFACE_STATE::AuxiliarySurfacePitch 3DSTATE_DEPTH_BUFFER::SurfacePitch 3DSTATE_HI

Re: [Mesa-dev] [PATCH 3/3] radeonsi: use DMA for clears with unaligned size

2017-03-25 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Sat, Mar 25, 2017 at 1:06 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Only a small tail needs to be uploaded manually. > > This is only partly a performance measure (apps are expected to use > aligned access). Mostly it is preparation

Re: [Mesa-dev] [PATCH] st/mesa: move duplicated st_ws_framebuffer() function into header file

2017-03-25 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sat, Mar 25, 2017 at 4:12 AM, Brian Paul wrote: > --- > src/mesa/state_tracker/st_cb_fbo.h | 17 + > src/mesa/state_tracker/st_cb_viewport.c | 15 +-- > src/mesa/state_tracker/st_manager.c | 14 -- > 3 files cha

[Mesa-dev] [PATCH 04/10] swr: [rasterizer jitter] Clean up EngineBuilder construction

2017-03-25 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp b/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp index 79118f5..bdb8a52 100644 --- a/src

[Mesa-dev] [PATCH 08/10] swr: [rasterizer common] Use C++ thread_local keyword

2017-03-25 Thread Tim Rowley
Allows use of thread_local objects with constructors. --- src/gallium/drivers/swr/rasterizer/common/os.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/common/os.h b/src/gallium/drivers/swr/rasterizer/common/os.h index 28e7ff5..71c4da3 1

[Mesa-dev] [PATCH 06/10] swr: [rasterizer core] Don't bind single-threaded contexts

2017-03-25 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/threads.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/threads.cpp b/src/gallium/drivers/swr/rasterizer/core/threads.cpp index ea29f66..e3ad258 100644 --- a/src/gallium/drivers/swr/rasteri

[Mesa-dev] [PATCH 07/10] swr: [rasterizer core] SIMD16 Frontend WIP

2017-03-25 Thread Tim Rowley
Implement widened clipper and binner interfaces for SIMD16. --- src/gallium/drivers/swr/rasterizer/core/api.cpp| 24 src/gallium/drivers/swr/rasterizer/core/binner.cpp | 154 + src/gallium/drivers/swr/rasterizer/core/clip.cpp | 131 ++ src/gallium/dr

[Mesa-dev] [PATCH 10/10] swr: [rasterizer codegen] Fix windows build

2017-03-25 Thread Tim Rowley
From: George Kyriazis Fix codegen build break that was introduced earlier. --- src/gallium/drivers/swr/Makefile.am| 4 +-- src/gallium/drivers/swr/SConscript | 7 ++--- .../drivers/swr/rasterizer/codegen/gen_backends.py | 30 ++ .../swr/raste

[Mesa-dev] [PATCH 05/10] swr: [rasterizer core] Enable SIMD16

2017-03-25 Thread Tim Rowley
Make the AVX512 insert/extract intrinsics KNL-compatible --- src/gallium/drivers/swr/rasterizer/common/simd16intrin.h | 14 +++--- src/gallium/drivers/swr/rasterizer/core/knobs.h | 2 +- src/gallium/drivers/swr/rasterizer/core/pa_avx.cpp | 12 3 files changed,

[Mesa-dev] [PATCH 09/10] swr: [rasterizer core] Disable inline function expansion

2017-03-25 Thread Tim Rowley
Disable expansion in windows Debug builds. --- src/gallium/drivers/swr/rasterizer/common/os.h | 12 1 file changed, 12 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/common/os.h b/src/gallium/drivers/swr/rasterizer/common/os.h index 71c4da3..ef00a25 100644 --- a/src/g

[Mesa-dev] [PATCH 01/10] swr: [rasterizer codegen] Refactor codegen

2017-03-25 Thread Tim Rowley
Move common codegen functions into gen_common.py. --- src/gallium/drivers/swr/Makefile.am| 22 +-- .../drivers/swr/rasterizer/codegen/gen_archrast.py | 30 +--- .../drivers/swr/rasterizer/codegen/gen_backends.py | 30 +--- .../drivers/swr/rasterizer/codegen/gen_common.py | 162

[Mesa-dev] [PATCH 03/10] swr: [rasterizer codegen] add cmdline to archrast gen files

2017-03-25 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/codegen/gen_archrast.py | 4 .../drivers/swr/rasterizer/codegen/templates/gen_ar_event.cpp| 3 +++ .../drivers/swr/rasterizer/codegen/templates/gen_ar_event.hpp| 3 +++ .../drivers/swr/rasterizer/codegen/templates/gen_ar_eventha

[Mesa-dev] [PATCH 00/10] swr: update rasterizer

2017-03-25 Thread Tim Rowley
Highlights: codegen cleanups, simd16 work, and fixing the windows build. George Kyriazis (1): swr: [rasterizer codegen] Fix windows build Tim Rowley (9): swr: [rasterizer codegen] Refactor codegen swr: [rasterizer core] SIMD16 Frontend WIP swr: [rasterizer codegen] add cmdline to archrast

[Mesa-dev] [PATCH 02/10] swr: [rasterizer core] SIMD16 Frontend WIP

2017-03-25 Thread Tim Rowley
Fix GS and streamout. --- src/gallium/drivers/swr/rasterizer/core/clip.h | 61 ++ .../drivers/swr/rasterizer/core/frontend.cpp | 97 +- 2 files changed, 136 insertions(+), 22 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/clip.h b/src/

[Mesa-dev] [Bug 97957] Awful screen tearing in a separate X server with DRI3

2017-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97957 --- Comment #9 from Marcin Mielniczuk --- Hi, Has the patch stuck in review? The same problem appears with the modesetting driver. Besides, right now with mesa 17.0.1 when using DRI3 every movement on the screen seems blurred, both on windowed

[Mesa-dev] [Bug 100201] llvmpipe Windows scons build with Visual Studio 2015 toolchain and LLVM 4.0 fails

2017-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100201 --- Comment #3 from Alex Granni --- Created attachment 130447 --> https://bugs.freedesktop.org/attachment.cgi?id=130447&action=edit Complete MSVC 2015 build log with LLVM 4.0 of Mesa 17.0.2 -- You are receiving this mail because: You are the