[Mesa-dev] [Bug 100075] st/va raises segmentation fault while using videotestsrc with gstreamer

2017-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100075 Michel Dänzer changed: What|Removed |Added Attachment #130082|text/x-log |text/plain mime type|

[Mesa-dev] [Bug 100063] Payday 2's maximum frame rate locked to refresh rate

2017-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100063 --- Comment #3 from Michel Dänzer --- Please attach the Xorg log file and the ~/.drirc file corresponding to the problem. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.

[Mesa-dev] [PATCH 1/2] radv/ac: handle Z export using new builder.

2017-03-05 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 41 +++-- 1 file changed, 19 insertions(+), 22 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 177f58b..b3fae26 100644 --- a/

[Mesa-dev] [Bug 100075] st/va raises segmentation fault while using videotestsrc with gstreamer

2017-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100075 gurkirpal...@gmail.com changed: What|Removed |Added CC||gurkirpal...@gmail.com -- You

[Mesa-dev] [PATCH 2/2] radv/ac: introduce i1true/i1false to contxet.

2017-03-05 Thread Dave Airlie
From: Dave Airlie This uses these in a few places, and fixes one or two cases which were using da as 32-bit instead of bool. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 65 + 1 file changed, 33 insertions(+), 32 deletions(-) diff --

[Mesa-dev] [PATCH] radv: Properly handle destroying NULL devices and instances

2017-03-05 Thread Dave Airlie
From: Dave Airlie Ported from anv: 3d33a23e anv: Properly handle destroying NULL devices and instances Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 58f37c6

[Mesa-dev] [Bug 100063] Payday 2's maximum frame rate locked to refresh rate

2017-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100063 --- Comment #2 from Gregor Münch --- I experience the same problem with Dirt: Showdown. Vsync is "OFF" in game settings, but it stays stubborn at 60fps. -- You are receiving this mail because: You are the QA Contact for the bug. You are the as

[Mesa-dev] [Bug 100075] st/va raises segmentation fault while using videotestsrc with gstreamer

2017-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100075 Bug ID: 100075 Summary: st/va raises segmentation fault while using videotestsrc with gstreamer Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [PATCH] radv: add .dir-locals.el to make radv code more readable in Emacs

2017-03-05 Thread Michel Dänzer
On 06/03/17 08:33 AM, Damien Grassart wrote: > The current root .dir-locals.el doesn't match the radv coding style, > causing Emacs to highlight nearly every line and edits to use 3-space > indentation. This sets the c-file-style to "linux" since that appears > to be the radv coding style. > > Sig

Re: [Mesa-dev] [PATCH 1/2] st/dri: use local pointer to st_context_iface

2017-03-05 Thread Michel Dänzer
On 06/03/17 01:03 PM, Timothy Arceri wrote: > From: Marek Olšák Both patches are Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___

Re: [Mesa-dev] [PATCH] glapi: fix typo in count_scale

2017-03-05 Thread Matt Turner
On Sun, Mar 5, 2017 at 8:25 PM, Timothy Arceri wrote: > From: Gregory Hainaut > > 2*4=8 Best commit message... ever? > > Signed-off-by: Gregory Hainaut > Reviewed-by: Timothy Arceri Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@list

Re: [Mesa-dev] Any updates on threaded GL dispatch?

2017-03-05 Thread Timothy Arceri
On 04/03/17 04:41, gregory hainaut wrote: On Fri, 3 Mar 2017 16:46:24 +0100 Marek Olšák wrote: On Fri, Mar 3, 2017 at 10:19 AM, Timothy Arceri wrote: On 02/03/17 22:18, Marek Olšák wrote: The bad news is my involvement is currently on hold due to other projects and responsibilities. I

[Mesa-dev] [PATCH] glapi: fix typo in count_scale

2017-03-05 Thread Timothy Arceri
From: Gregory Hainaut 2*4=8 Signed-off-by: Gregory Hainaut Reviewed-by: Timothy Arceri --- src/mapi/glapi/gen/gl_API.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index f81ad1d..c94 100644 --- a/src/m

[Mesa-dev] [PATCH 2/2] st/dri: reduce dri_fill_st_options() params

2017-03-05 Thread Timothy Arceri
From: Marek Olšák --- src/gallium/state_trackers/dri/dri_screen.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/dri/dri_screen.c b/src/gallium/state_trackers/dri/dri_screen.c index c2da7e3..da0e414 100644 --- a/src/gallium/state_trackers/

[Mesa-dev] [PATCH 1/2] st/dri: use local pointer to st_context_iface

2017-03-05 Thread Timothy Arceri
From: Marek Olšák --- src/gallium/state_trackers/dri/dri_drawable.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/dri/dri_drawable.c b/src/gallium/state_trackers/dri/dri_drawable.c index edcd0e6..fd3b458 100644 --- a/src/gallium/state

[Mesa-dev] [Bug 99817] [softpipe] piglit glsl-fs-tan-1 regression

2017-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99817 --- Comment #5 from Vinson Lee --- These piglit tests have also regressed. glsl-fs-atan-2 glsl-fs-atan-3 fs-atan-float-float fs-atan-vec2-vec2 fs-atan-vec3-vec3 fs-atan-vec4-vec4 vs-atan-float-float vs-atan-vec2-vec2 vs-atan-vec3-vec3 vs-atan-v

Re: [Mesa-dev] [PATCH] util/disk_cache: fix make check

2017-03-05 Thread Michel Dänzer
On 06/03/17 11:25 AM, Timothy Arceri wrote: > Fixes make check after 11f0efec2e615f5233d which caused disk cache > to create an additional directory. make check passes with this on 64-bit, but still not on 32-bit: FAIL: glsl/tests/cache-test === Failed to create ./cache-t

Re: [Mesa-dev] [PATCH] android: fix libz dynamic library dependencies

2017-03-05 Thread Tomasz Figa
2017-03-06 4:55 GMT+09:00 Mauro Rossi : > > >> Unrelated: where do we use the "host" libmesa_util ? Can we add a note >> in src/util/Android.mk (since it's not obvious) or just remove the >> hunk if it's not used. >> >> Thanks >> Emil > > > Hi, > > My guess would be it's not used, > but it's better

[Mesa-dev] [PATCH] util/disk_cache: fix make check

2017-03-05 Thread Timothy Arceri
Fixes make check after 11f0efec2e615f5233d which caused disk cache to create an additional directory. --- src/compiler/glsl/tests/cache_test.c | 19 --- src/util/disk_cache.c| 17 - src/util/disk_cache.h| 18 ++ 3 file

Re: [Mesa-dev] [PATCH 2/2] radv: Use the new L2 writeback flag.

2017-03-05 Thread Dave Airlie
On 6 March 2017 at 11:17, Bas Nieuwenhuizen wrote: > Signed-off-by: Bas Nieuwenhuizen For both: Reviewed-by: Dave Airlie > --- > src/amd/vulkan/radv_cmd_buffer.c | 8 > src/amd/vulkan/radv_meta_clear.c | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src

[Mesa-dev] [Bug 100063] Payday 2's maximum frame rate locked to refresh rate

2017-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100063 --- Comment #1 from Michel Dänzer --- If sync-to-vblank can't be disabled in the game settings, you can override it with the environment variable vblank_mode=0. -- You are receiving this mail because: You are the QA Contact for the bug. You ar

[Mesa-dev] [Bug 100073] Shader Disk Cache 32/64 bit detection has a flaw. Missed existence of x32 ABI

2017-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100073 Timothy Arceri changed: What|Removed |Added Status|NEW |NEEDINFO Severity|critical

[Mesa-dev] [Bug 100073] Shader Disk Cache 32/64 bit detection has a flaw. Missed existence of x32 ABI

2017-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100073 --- Comment #3 from Timothy Arceri --- (In reply to Darren Salt from comment #2) > This code is intended to be generic; it SHOULD work for other pairs such as > armel and aarch64 (though breakage will happen should you have more than one > 32-bi

[Mesa-dev] [PATCH 2/2] radv: Use the new L2 writeback flag.

2017-03-05 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_cmd_buffer.c | 8 src/amd/vulkan/radv_meta_clear.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 16c3f7893b9..3ff52502ffe 100644 -

[Mesa-dev] [PATCH 1/2] radv: Add L2 writeback.

2017-03-05 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_private.h | 18 ++- src/amd/vulkan/si_cmd_buffer.c | 70 ++ 2 files changed, 54 insertions(+), 34 deletions(-) diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h inde

[Mesa-dev] [Bug 100073] Shader Disk Cache 32/64 bit detection has a flaw. Missed existence of x32 ABI

2017-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100073 --- Comment #2 from Darren Salt --- This code is intended to be generic; it SHOULD work for other pairs such as armel and aarch64 (though breakage will happen should you have more than one 32-bit ARM ABI in use on one system). As such, as it's w

[Mesa-dev] [PATCH 3/4] gallium/util: remove unused pipe_thread_destroy()

2017-03-05 Thread Timothy Arceri
--- src/gallium/auxiliary/os/os_thread.h | 5 - 1 file changed, 5 deletions(-) diff --git a/src/gallium/auxiliary/os/os_thread.h b/src/gallium/auxiliary/os/os_thread.h index 2aad3e2..2292123 100644 --- a/src/gallium/auxiliary/os/os_thread.h +++ b/src/gallium/auxiliary/os/os_thread.h @@ -61,2

[Mesa-dev] [PATCH 4/4] gallium/util: remove unused header from u_queue.c

2017-03-05 Thread Timothy Arceri
--- src/gallium/auxiliary/util/u_queue.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_queue.c b/src/gallium/auxiliary/util/u_queue.c index 9565c53..bb63a6b 100644 --- a/src/gallium/auxiliary/util/u_queue.c +++ b/src/gallium/auxiliary/util/u_queue.c @@ -20,21 +20

[Mesa-dev] [PATCH 1/4] gallium/util: remove PIPE_THREAD_ROUTINE()

2017-03-05 Thread Timothy Arceri
This was made unnecessary with fd33a6bcd7f12. This was mostly done with: find ./src -type f -exec sed -i -- \ 's:PIPE_THREAD_ROUTINE(\([^,]*\), \([^)]*\)):int\n\1(void \*\2):g' {} \; With some small manual tidy ups. --- src/gallium/auxiliary/os/os_thread.h | 5 + src/gallium/auxiliar

[Mesa-dev] [PATCH 2/4] gallium/util: replace pipe_thread_wait() with thrd_join()

2017-03-05 Thread Timothy Arceri
Replace done using: find ./src -type f -exec sed -i -- \ 's:pipe_thread_wait(\([^)]*\)):thrd_join(\1, NULL):g' {} \; --- src/gallium/auxiliary/os/os_thread.h | 5 - src/gallium/auxiliary/util/u_queue.c | 2 +- src/gallium/drivers/ddebug/dd_context.c | 2 +- src/gallium/dri

[Mesa-dev] [PATCH v2] nv50: don't assume a rast is set when validating for clears

2017-03-05 Thread Ilia Mirkin
Clears can happen before a rast is set, which can in turn cause scissors and fragprog to be validated. Make sure that we handle this case. Reported-by: Andrew Randrianasulu Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nv50/nv50_shader_state.c | 3 +++ src/gallium/drivers/nouveau

[Mesa-dev] [Bug 100069] Dirt: Showdown bad performance with enabled advanced lightning

2017-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100069 Kenneth Graunke changed: What|Removed |Added QA Contact|intel-3d-bugs@lists.freedes |dri-devel@lists.freedesktop

[Mesa-dev] [Bug 100073] Shader Disk Cache 32/64 bit detection has a flaw. Missed existence of x32 ABI

2017-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100073 --- Comment #1 from Ilia Mirkin --- Can you be specific as to what the problem is? Which situation, precisely, is mishandled? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.

[Mesa-dev] [PATCH] radv: remove duplicate initialization of alphaToOne feature

2017-03-05 Thread Damien Grassart
Fixes a GCC warning when compiling with -Wextra: radv_device.c:463:47: warning: initialized field overwritten [-Woverride-init] Signed-off-by: Damien Grassart --- src/amd/vulkan/radv_device.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_de

[Mesa-dev] [PATCH] nv50: don't assume a rast is set when validating scissors

2017-03-05 Thread Ilia Mirkin
Clears can happen before a rast is set, which can in turn cause scissors to be validated. Make sure that we handle this case. Reported-by: Andrew Randrianasulu Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nv50/nv50_state_validate.c | 7 --- 1 file changed, 4 insertions(+), 3 d

[Mesa-dev] [Bug 100073] Shader Disk Cache 32/64 bit detection has a flaw. Missed existence of x32 ABI

2017-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100073 Bug ID: 100073 Summary: Shader Disk Cache 32/64 bit detection has a flaw. Missed existence of x32 ABI Product: Mesa Version: git Hardware: All OS: All

Re: [Mesa-dev] [PATCH] gallium/targets: rework the empty targets removal

2017-03-05 Thread Andy Furniss
Emil Velikov wrote: From: Emil Velikov Earlier commit added extra tracking and we've attempted to remove the vdpau/other folder if empty. V2 of said commit dropped the pipe to /dev/null and the explicit "true" override. Sadly both of those are needed since there's no guarantee that the folder

Re: [Mesa-dev] [PATCH 1/6] radv/ac: switch to new intrinsics for pkrtz and clamp.

2017-03-05 Thread Bas Nieuwenhuizen
Series is Reviewed-by: Bas Nieuwenhuizen On Mon, Mar 6, 2017 at 12:29 AM, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_nir_to_llvm.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/src/amd/common/ac_nir_to_llv

[Mesa-dev] [PATCH] gallium/util: replace pipe_condvar with cnd_t

2017-03-05 Thread Timothy Arceri
pipe_condvar was made unnecessary with fd33a6bcd7f12. Cc: Emil Velikov --- src/gallium/auxiliary/os/os_thread.h | 8 ++-- src/gallium/auxiliary/pipebuffer/pb_bufmgr_slab.c | 2 +- src/gallium/auxiliary/util/u_queue.h | 6 +++--- src/gallium/auxiliary/util/u_ringbuff

[Mesa-dev] [PATCH] radv: add .dir-locals.el to make radv code more readable in Emacs

2017-03-05 Thread Damien Grassart
The current root .dir-locals.el doesn't match the radv coding style, causing Emacs to highlight nearly every line and edits to use 3-space indentation. This sets the c-file-style to "linux" since that appears to be the radv coding style. Signed-off-by: Damien Grassart --- src/amd/vulkan/.dir-loc

Re: [Mesa-dev] [PATCH] radv: drop Z24 support.

2017-03-05 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, Mar 6, 2017 at 12:27 AM, Dave Airlie wrote: > From: Dave Airlie > > This isn't exposed in -pro, the hw docs say it is deprecated, > so let's not bother with it. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_formats.c | 3 --- > 1 file change

[Mesa-dev] [PATCH 4/6] radv/ac: use bitfield extract new intrinsics.

2017-03-05 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index ebfb457..be97c67 100644 --- a/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [PATCH 3/6] radv/ac: move to new kill build.

2017-03-05 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 6797dc0..ebfb457 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b

[Mesa-dev] [PATCH 2/6] radv/ac: move to using new export intrinsics.

2017-03-05 Thread Dave Airlie
From: Dave Airlie This uses the new code in build to do exports. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 179 +++- 1 file changed, 86 insertions(+), 93 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_ni

[Mesa-dev] [PATCH 1/6] radv/ac: switch to new intrinsics for pkrtz and clamp.

2017-03-05 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index f861dd1..058e952 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b

[Mesa-dev] [PATCH 6/6] radv/ac: move to using common ac_get_image_intr_name.

2017-03-05 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 55 +++-- 1 file changed, 15 insertions(+), 40 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index be97c67..177f58b 100644 --- a/

[Mesa-dev] [PATCH 5/6] radeonsi/ac: move get_image_intr_name to common

2017-03-05 Thread Dave Airlie
From: Dave Airlie This code is used in radv, so move to common build code. Signed-off-by: Dave Airlie --- src/amd/common/ac_llvm_build.c | 26 ++ src/amd/common/ac_llvm_build.h | 5 src/gallium/drivers/radeonsi/si_shader.c | 46 +++-

[Mesa-dev] [PATCH] radv: drop Z24 support.

2017-03-05 Thread Dave Airlie
From: Dave Airlie This isn't exposed in -pro, the hw docs say it is deprecated, so let's not bother with it. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_formats.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c index 74

[Mesa-dev] [PATCH] swr: support layer output in geometry shaders

2017-03-05 Thread Ilia Mirkin
This makes bin/gl-3.2-layered-rendering-gl-layer-render fail only with 2DMS_ARRAY, which is expected given the lackluster MSAA support. However all the regular types pass. Signed-off-by: Ilia Mirkin --- Note - away from keys atm. Please push if you're happy with it. src/gallium/drivers/swr/swr

[Mesa-dev] [PATCH] st/omx: Set end-of-frame flag on bitstream output buffers

2017-03-05 Thread Mark Thompson
Since all output buffers are whole frames, this should always be set. Technically, setting this flag is is optional (see OpenMAX IL section 3.1.2.7.1), but some clients assume that it will be used and therefore buffer indefinitely thinking that all output buffers are fragments of the first frame w

Re: [Mesa-dev] [PATCH 3/4] radv: check for upload alloc failure

2017-03-05 Thread Bas Nieuwenhuizen
Pushed. On Sun, Mar 5, 2017 at 10:04 PM, Grazvydas Ignotas wrote: > Mainly to avoid gcc's complains about uninitialized ptr and offset use > later in that code. > > Signed-off-by: Grazvydas Ignotas > --- > src/amd/vulkan/radv_cmd_buffer.c | 7 --- > 1 file changed, 4 insertions(+), 3 deleti

Re: [Mesa-dev] [PATCH] radv/amdgpu: Add some debug flags.

2017-03-05 Thread Dave Airlie
On 6 March 2017 at 06:01, Bas Nieuwenhuizen wrote: > Signed-off-by: Bas Nieuwenhuizen Reviewed-by: Dave Airlie > --- > src/amd/vulkan/Makefile.sources| 1 + > src/amd/vulkan/radv_debug.h| 40 > ++ > src/amd/vulkan/radv_device.c

Re: [Mesa-dev] [PATCH 3/4] radv: check for upload alloc failure

2017-03-05 Thread Bas Nieuwenhuizen
On Sun, Mar 5, 2017 at 11:39 PM, Grazvydas Ignotas wrote: > On Mon, Mar 6, 2017 at 12:05 AM, Bas Nieuwenhuizen > wrote: >> On Sun, Mar 5, 2017 at 10:04 PM, Grazvydas Ignotas wrote: >>> Mainly to avoid gcc's complains about uninitialized ptr and offset use >>> later in that code. >>> >>> Signed-o

Re: [Mesa-dev] [PATCH] radv: Cache command buffers in command pool.

2017-03-05 Thread Dave Airlie
On 6 March 2017 at 08:34, Bas Nieuwenhuizen wrote: > So that we don't keep allocating BOs for the IBs and upload buffers. > > We run some risk of memory increase with e.g. a bimodal size > distribution of command buffers, but I haven't noticed a significant > increase with dota2 and talos. Looks

Re: [Mesa-dev] [PATCH 1/5] radeonsi: fix LLVM 3.9 - don't use non-matching attributes on declarations

2017-03-05 Thread Dave Airlie
On 6 March 2017 at 08:22, Marek Olšák wrote: > From: Marek Olšák > > Call site attributes are used since LLVM 4.0. For all 5, Reviewed-by: Dave Airlie > > This also reverts commit b19caecbd6f310c1663b0cfe483d113ae3bd5fe2 > "radeon/ac: fix intrinsic version check", because this is the correct

Re: [Mesa-dev] [PATCH 3/4] radv: check for upload alloc failure

2017-03-05 Thread Grazvydas Ignotas
On Mon, Mar 6, 2017 at 12:05 AM, Bas Nieuwenhuizen wrote: > On Sun, Mar 5, 2017 at 10:04 PM, Grazvydas Ignotas wrote: >> Mainly to avoid gcc's complains about uninitialized ptr and offset use >> later in that code. >> >> Signed-off-by: Grazvydas Ignotas >> --- >> src/amd/vulkan/radv_cmd_buffer.

[Mesa-dev] [PATCH] radv: Cache command buffers in command pool.

2017-03-05 Thread Bas Nieuwenhuizen
So that we don't keep allocating BOs for the IBs and upload buffers. We run some risk of memory increase with e.g. a bimodal size distribution of command buffers, but I haven't noticed a significant increase with dota2 and talos. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_cmd_buff

Re: [Mesa-dev] [PATCH V3] util/disk_cache: support caches for multiple architectures

2017-03-05 Thread Timothy Arceri
I've pushed this. We can fix it later if it's not good enough. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 5/5] gallium/radeon: don't monitor SDMA busyness on EG/Cayman

2017-03-05 Thread Marek Olšák
It looks like I'll also have to skip the SDMA counter update on SI, because it's always busy too. Consider it done. Marek On Sun, Mar 5, 2017 at 11:22 PM, Marek Olšák wrote: > From: Marek Olšák > > It's always busy. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99955 > --- > src/g

Re: [Mesa-dev] [PATCH] util/disk_cache: mark read-only arguments const

2017-03-05 Thread Timothy Arceri
Pushed thanks :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 4/5] radeonsi: drop support for LLVM 3.6 & 3.7

2017-03-05 Thread Marek Olšák
From: Marek Olšák They are too old. --- configure.ac | 4 +-- src/amd/common/ac_llvm_build.c | 30 -- src/amd/common/ac_llvm_helper.cpp | 6 ++--- src/amd/common/ac_llvm_util.c |

[Mesa-dev] [PATCH 2/5] gallivm,ac: add LP_FUNC_ATTR_CONVERGENT

2017-03-05 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_llvm_util.c | 1 + src/amd/common/ac_llvm_util.h | 1 + src/gallium/auxiliary/gallivm/lp_bld_intr.c | 1 + src/gallium/auxiliary/gallivm/lp_bld_intr.h | 1 + 4 files changed, 4 insertions(+) diff --git a/src/amd/common/ac_llvm_

[Mesa-dev] [PATCH 3/5] radeonsi: set the convergent attribute where needed

2017-03-05 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_llvm_build.c | 8 ++-- src/gallium/drivers/radeonsi/si_shader.c | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index 20c6eb8..0039e63 100644 --- a/src/amd

[Mesa-dev] [PATCH 5/5] gallium/radeon: don't monitor SDMA busyness on EG/Cayman

2017-03-05 Thread Marek Olšák
From: Marek Olšák It's always busy. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99955 --- src/gallium/drivers/radeon/r600_gpu_load.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_gpu_load.c b/src/gallium/drivers/radeon/r600_gpu_l

[Mesa-dev] [PATCH 1/5] radeonsi: fix LLVM 3.9 - don't use non-matching attributes on declarations

2017-03-05 Thread Marek Olšák
From: Marek Olšák Call site attributes are used since LLVM 4.0. This also reverts commit b19caecbd6f310c1663b0cfe483d113ae3bd5fe2 "radeon/ac: fix intrinsic version check", because this is the correct fix. --- src/amd/common/ac_llvm_build.c | 6 +++--- src/gallium/drivers/radeonsi/si_s

Re: [Mesa-dev] [PATCH] util/disk_cache: don't require 64bit atomic operations

2017-03-05 Thread Timothy Arceri
On 06/03/17 08:39, Grazvydas Ignotas wrote: On Sun, Mar 5, 2017 at 10:29 PM, Matt Turner wrote: On Sun, Mar 5, 2017 at 11:14 AM, Grazvydas Ignotas wrote: There are still some distributions trying to support unfortunate people with old or exotic CPUs that don't have 64bit atomic operations.

[Mesa-dev] [PATCH] st/omx: Fix port format enumeration

2017-03-05 Thread Mark Thompson
From OpenMAX IL section 4.3.5: "The value of nIndex is the range 0 to N-1, where N is the number of formats supported by the port. There is no need for the port to report N, as the caller can determine N by enumerating all the formats supported by the port. Each port shall support at least one fo

Re: [Mesa-dev] [PATCH 3/4] radv: check for upload alloc failure

2017-03-05 Thread Bas Nieuwenhuizen
On Sun, Mar 5, 2017 at 10:04 PM, Grazvydas Ignotas wrote: > Mainly to avoid gcc's complains about uninitialized ptr and offset use > later in that code. > > Signed-off-by: Grazvydas Ignotas > --- > src/amd/vulkan/radv_cmd_buffer.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) >

Re: [Mesa-dev] [PATCH v2] gallium/targets: don't leave an empty target directory(ies)

2017-03-05 Thread Damien Grassart
This breaks make install for me as well. Does this patch make sense for XvMC since by default it gets installed to '${libdir}' (while VDPAU goes to '${libdir}/vdpau' by default)? Should there be a check to make sure ${dest_dir} isn't ${libdir}? Thanks, -Damien On Sun, Mar 5, 2017 at 3:11 PM Andy

Re: [Mesa-dev] [PATCH v2] i965: don't require 64bit cmpxchg

2017-03-05 Thread Matt Turner
On Sun, Mar 5, 2017 at 1:23 PM, Grazvydas Ignotas wrote: > There are still some distributions trying to support unfortunate people > with old or exotic CPUs that don't have 64bit atomic operations. The > only thing preventing compile of the Intel driver for them seems to be > initialization of a d

Re: [Mesa-dev] [PATCH] util/disk_cache: don't require 64bit atomic operations

2017-03-05 Thread Grazvydas Ignotas
On Sun, Mar 5, 2017 at 10:29 PM, Matt Turner wrote: > On Sun, Mar 5, 2017 at 11:14 AM, Grazvydas Ignotas wrote: >> There are still some distributions trying to support unfortunate people >> with old or exotic CPUs that don't have 64bit atomic operations. Missing >> 64bit atomic ops can be detecte

Re: [Mesa-dev] [PATCH 0/9] Enable GL_ARB_shader_atomic_counter_ops on i965

2017-03-05 Thread Matt Turner
On Thu, Sep 1, 2016 at 11:12 AM, Ian Romanick wrote: > On 09/01/2016 11:10 AM, Ian Romanick wrote: >> This is the updated series to enable GL_ARB_shader_atomic_counter_ops on >> i965. Really only the first part of the series has changed. At Curro's >> suggestion, I added an enum to specify which

Re: [Mesa-dev] pfn_notify in clCreateContext()

2017-03-05 Thread Giuseppe Bilotta
On Fri, Feb 24, 2017 at 5:30 PM, Ilia Mirkin wrote: > I'd like to point out that when I hooked up this logic in clover > (after my triumphant addition of KHR_debug in gallium), I had no idea > how OpenCL stuff worked. I still don't. If you think passing this type > of information is inappropriate,

[Mesa-dev] [PATCH v2] i965: don't require 64bit cmpxchg

2017-03-05 Thread Grazvydas Ignotas
There are still some distributions trying to support unfortunate people with old or exotic CPUs that don't have 64bit atomic operations. The only thing preventing compile of the Intel driver for them seems to be initialization of a debug variable. v2: use call_once() instead of unsafe code, as sug

[Mesa-dev] [PATCH] android: r600: fix libmesa_amd_common dependency

2017-03-05 Thread Mauro Rossi
Adding libmesa_amd_common dependency and exporting its headers, avoids the following building error: external/mesa/src/gallium/drivers/r600/evergreen_compute.c:29:10: fatal error: 'ac_binary.h' file not found ^ 1 error generated. Fixes: 363 "automake: r600: radeonsi: correctly manag

[Mesa-dev] [PATCH 4/4] radv: use VK_NULL_HANDLE for handles

2017-03-05 Thread Grazvydas Ignotas
Avoids warnings on 32bit. Signed-off-by: Grazvydas Ignotas --- src/amd/vulkan/radv_meta_bufimage.c | 8 src/amd/vulkan/radv_wsi.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/amd/vulkan/radv_meta_bufimage.c b/src/amd/vulkan/radv_meta_bufimage.c i

[Mesa-dev] [PATCH 2/4] radv: don't use uninitialized value on failure

2017-03-05 Thread Grazvydas Ignotas
Mainly to avoid a warning. Signed-off-by: Grazvydas Ignotas --- src/amd/vulkan/radv_descriptor_set.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/amd/vulkan/radv_descriptor_set.c index ca5b280..7dade3e 100644 --- a/src/amd/vulkan

[Mesa-dev] [PATCH 3/4] radv: check for upload alloc failure

2017-03-05 Thread Grazvydas Ignotas
Mainly to avoid gcc's complains about uninitialized ptr and offset use later in that code. Signed-off-by: Grazvydas Ignotas --- src/amd/vulkan/radv_cmd_buffer.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_b

[Mesa-dev] [PATCH 0/4] Make radv warning-free again

2017-03-05 Thread Grazvydas Ignotas
Please push if these are ok. Grazvydas Ignotas (4): radv: avoid casting warnings on 32bit radv: don't use uninitialized value on failure radv: check for upload alloc failure radv: use VK_NULL_HANDLE for handles src/amd/vulkan/radv_cmd_buffer.c | 7 --- src/amd/vulkan/radv_descrip

[Mesa-dev] [PATCH 1/4] radv: avoid casting warnings on 32bit

2017-03-05 Thread Grazvydas Ignotas
Use the same helpers as for other handle<->pointer conversions. Signed-off-by: Grazvydas Ignotas --- src/amd/vulkan/radv_device.c | 5 ++--- src/amd/vulkan/radv_private.h | 3 +++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_d

[Mesa-dev] [PATCH] util/disk_cache: mark read-only arguments const

2017-03-05 Thread Grazvydas Ignotas
No functional changes. Signed-off-by: Grazvydas Ignotas --- no commit access src/util/disk_cache.c | 35 ++- src/util/disk_cache.h | 20 ++-- 2 files changed, 28 insertions(+), 27 deletions(-) diff --git a/src/util/disk_cache.c b/src/util/disk_ca

Re: [Mesa-dev] [PATCH] util/disk_cache: don't require 64bit atomic operations

2017-03-05 Thread Matt Turner
On Sun, Mar 5, 2017 at 11:14 AM, Grazvydas Ignotas wrote: > There are still some distributions trying to support unfortunate people > with old or exotic CPUs that don't have 64bit atomic operations. Missing > 64bit atomic ops can be detected at compile time, so provide a 32bit > fallback and add a

Re: [Mesa-dev] [PATCH 2/9] r600g: Add instruction encoding defines for MEM_RD

2017-03-05 Thread Dave Airlie
On 6 March 2017 at 03:26, Glenn Kennard wrote: > Signed-off-by: Glenn Kennard You might want to mark the cayman only bits in here, I think SRC_SEL_Y, LDS_REQ and COALESCED_READ are cayman only from my docs, r700 also has 1 bit at 19 in word2 for megafetch. Dave. > --- > src/gallium/drivers/r

Re: [Mesa-dev] [PATCH] i965: don't require 64bit cmpxchg

2017-03-05 Thread Matt Turner
On Sun, Mar 5, 2017 at 11:07 AM, Grazvydas Ignotas wrote: > There are still some distributions trying to support unfortunate people > with old or exotic CPUs that don't have 64bit atomic operations. The > only thing preventing compile of the Intel driver for them seems to be > initialization of a

[Mesa-dev] [PATCH] radv/amdgpu: Add some debug flags.

2017-03-05 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/Makefile.sources| 1 + src/amd/vulkan/radv_debug.h| 40 ++ src/amd/vulkan/radv_device.c | 4 ++- src/amd/vulkan/radv_private.h | 13 +---

Re: [Mesa-dev] [PATCH] android: fix libz dynamic library dependencies

2017-03-05 Thread Mauro Rossi
Unrelated: where do we use the "host" libmesa_util ? Can we add a note > in src/util/Android.mk (since it's not obvious) or just remove the > hunk if it's not used. > > Thanks > Emil > Hi, My guess would be it's not used, but it's better to check with Tomasz (added in Cc:) who added the host stat

[Mesa-dev] [Bug 100069] Dirt: Showdown bad performance with enabled advanced lightning

2017-03-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100069 Bug ID: 100069 Summary: Dirt: Showdown bad performance with enabled advanced lightning Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

[Mesa-dev] [PATCH 2/3] glsl: Use the utility function to copy symbols between symbol tables

2017-03-05 Thread Eduardo Lima Mitev
This effectively factorizes a couple of similar routines. --- src/compiler/glsl/glsl_parser_extras.cpp | 18 ++ src/compiler/glsl/linker.cpp | 16 +++- 2 files changed, 5 insertions(+), 29 deletions(-) diff --git a/src/compiler/glsl/glsl_parser_extras.cpp

[Mesa-dev] [PATCH 3/3] glsl/linker: Check that re-declared, inter-shader built-in blocks match

2017-03-05 Thread Eduardo Lima Mitev
From GLSL 4.5 spec, section "7.1 Built-In Language Variables", page 130 of the PDF states: "If multiple shaders using members of a built-in block belonging to the same interface are linked together in the same program, they must all redeclare the built-in block in the same way, as de

[Mesa-dev] [PATCH 1/3] glsl_parser_extra: Add utility to copy symbols between symbol tables

2017-03-05 Thread Eduardo Lima Mitev
Some symbols gathered in the symbols table during parsing are needed later for the compile and link stages, so they are moved along the process. Currently, only functions and non-temporary variables are copied between symbol tables. However, the built-in input and output interface blocks are also n

[Mesa-dev] [PATCH 0/3] Expand inter-shader compatibility check of built-in blocks

2017-03-05 Thread Eduardo Lima Mitev
Few weeks ago I submitted this same series, that essentially expands the existing validation of inter-shader build-in interfaces blocks, to also consider blocks that have unused members and thus were optimized out at compile time. The original concern about this series was that forcing a link e

[Mesa-dev] [PATCH] util/disk_cache: don't require 64bit atomic operations

2017-03-05 Thread Grazvydas Ignotas
There are still some distributions trying to support unfortunate people with old or exotic CPUs that don't have 64bit atomic operations. Missing 64bit atomic ops can be detected at compile time, so provide a 32bit fallback and add an appropriate cache size limit ceiling for that case. Bugzilla: ht

[Mesa-dev] [PATCH] radv: Merge fast clear flushes.

2017-03-05 Thread Bas Nieuwenhuizen
Don't flush multiple times if we clear multiple attachments. Also allows doing the depth clear in parallel with the fast color clears. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_meta_clear.c | 49 +--- 1 file changed, 36 insertions(+), 13 deletio

[Mesa-dev] [PATCH] i965: don't require 64bit cmpxchg

2017-03-05 Thread Grazvydas Ignotas
There are still some distributions trying to support unfortunate people with old or exotic CPUs that don't have 64bit atomic operations. The only thing preventing compile of the Intel driver for them seems to be initialization of a debug variable. It is very unlikely to be set simultaneously by mu

[Mesa-dev] [PATCH] gallium/targets: rework the empty targets removal

2017-03-05 Thread Emil Velikov
From: Emil Velikov Earlier commit added extra tracking and we've attempted to remove the vdpau/other folder if empty. V2 of said commit dropped the pipe to /dev/null and the explicit "true" override. Sadly both of those are needed since there's no guarantee that the folder will be empty before w

[Mesa-dev] [PATCH 6/9] r600g: Implement scratch buffer state management

2017-03-05 Thread Glenn Kennard
Signed-off-by: Glenn Kennard --- src/gallium/drivers/r600/evergreen_state.c | 24 +++ src/gallium/drivers/r600/r600_pipe.c | 3 + src/gallium/drivers/r600/r600_pipe.h | 14 src/gallium/drivers/r600/r600_shader.h | 1 + src/gallium/drivers/r600/r600_state_com

[Mesa-dev] [PATCH 8/9] r600g/sb: Add dependency tracking for scratch ops

2017-03-05 Thread Glenn Kennard
Signed-off-by: Glenn Kennard --- src/gallium/drivers/r600/r600_shader.h | 1 + src/gallium/drivers/r600/sb/sb_bc_finalize.cpp | 2 +- src/gallium/drivers/r600/sb/sb_bc_parser.cpp | 12 src/gallium/drivers/r600/sb/sb_core.cpp| 3 ++- src/gallium/drivers/r600/sb/sb

[Mesa-dev] [PATCH 9/9] r600g: Implement spilling of temp arrays

2017-03-05 Thread Glenn Kennard
Pessimistically spills arrays if GPR limit is exceeded. Signed-off-by: Glenn Kennard --- src/gallium/drivers/r600/r600_shader.c | 308 ++--- 1 file changed, 285 insertions(+), 23 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/

[Mesa-dev] [PATCH 1/9] r600g: Add scratch ring register defines

2017-03-05 Thread Glenn Kennard
Signed-off-by: Glenn Kennard --- src/gallium/drivers/r600/evergreend.h | 14 ++ src/gallium/drivers/r600/r600d.h | 8 ++-- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/evergreend.h b/src/gallium/drivers/r600/evergreend.h index 40b

[Mesa-dev] [PATCH 2/9] r600g: Add instruction encoding defines for MEM_RD

2017-03-05 Thread Glenn Kennard
Signed-off-by: Glenn Kennard --- src/gallium/drivers/r600/r700_sq.h | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/gallium/drivers/r600/r700_sq.h b/src/gallium/drivers/r600/r700_sq.h index d881012..81e0e7a 100644 --- a/src/gallium/drivers/r600/r700_sq.h +

  1   2   >