Re: [Mesa-dev] [PATCH 22/32] i965: Create correctly sized mcs for an image

2017-01-03 Thread Pohjolainen, Topi
On Mon, Jan 02, 2017 at 06:37:13PM -0800, Ben Widawsky wrote: > v2: Leave "image+mod" (Topi) > > Signed-off-by: Ben Widawsky > Acked-by: Daniel Stone > --- > src/mesa/drivers/dri/i965/intel_screen.c | 33 > > 1 file changed, 29 insertions(+), 4 deletions(-) >

Re: [Mesa-dev] [PATCH 23/32] i965/miptree: Add a return for updating of winsys

2017-01-03 Thread Pohjolainen, Topi
On Mon, Jan 02, 2017 at 06:37:14PM -0800, Ben Widawsky wrote: > There is nothing particularly useful to do currently if the update > fails, but there is no point carrying on either. As a result, this has a > behavior change. > > v2: Make the return type a bool (Topi) Reviewed-by: Topi Pohjolainen

Re: [Mesa-dev] [PATCH 19/32] i965/miptree: Allocate mcs_buf for an image's CCS_E

2017-01-03 Thread Pohjolainen, Topi
On Mon, Jan 02, 2017 at 06:37:10PM -0800, Ben Widawsky wrote: > This code will disable actually creating these buffers for the scanout, > but it puts the allocation in place. > > Primarily this patch is split out for review, it can be squashed in > later if preferred. > > assert(mt->offset == 0)

Re: [Mesa-dev] [PATCH 2/2] radv: define and implement VK_EXT_queue_global_priority

2017-01-03 Thread Bas Nieuwenhuizen
So two things I'm missing here are advertising the extension and checking the kernel driver version. To advertize the extension, an entry needs to be added to the device_extensions array. However, since that array is const global, you can't really select on kernel version or such, so you'll probab

Re: [Mesa-dev] [PATCH 0/6] Enable OpenGL 4.0 on Haswell

2017-01-03 Thread Iago Toral
On Tue, 2017-01-03 at 07:48 -0800, Kenneth Graunke wrote: > On Tuesday, January 3, 2017 2:02:19 PM PST Iago Toral wrote: > > > > On Tue, 2017-01-03 at 11:14 +, Chris Wilson wrote: > > > > > > On Tue, Jan 03, 2017 at 11:42:50AM +0100, Iago Toral Quiroga > > > wrote: > > > > > > > > > > > > E

Re: [Mesa-dev] radv: Initial implementation of VK_EXT_queue_global_priority

2017-01-03 Thread Andres Rodriguez
Hey Guys, One of my first non-trivial contributions to mesa here. Let me know if I've messed up anything, bad coding style or some patch validation script I should've run or any other kind of pitfall a newbie might make. I tried to follow the guidelines over at: http://www.mesa3d.org/devinfo.ht

[Mesa-dev] [PATCH 2/2] radv: define and implement VK_EXT_queue_global_priority

2017-01-03 Thread Andres Rodriguez
Add a new extension VK_EXT_queue_global_priority, which allows the caller to elevate a queue's priority above all other queues in the system. This extension aims to provide a mechanism for compositors to have achieve a guaranteed quality of service, even when the hardware may be loaded by a game o

[Mesa-dev] [PATCH 1/2] radv: use a winsys context per-queue, instead of per device

2017-01-03 Thread Andres Rodriguez
Queues are independent execution streams. The vulkan spec provides no ordering guarantees for different queues. By using a single context for all queues, we are forcing all commands into an unecessary FIFO ordering. This change is a preparation step to allow our-of-ordering scheduling of certain

[Mesa-dev] radv: Initial implementation of VK_EXT_queue_global_priority

2017-01-03 Thread Andres Rodriguez
This patch series implements VK_EXT_queue_global_priority, a vulkan extension that focuses on providing scheduling guarantees. For further information on the use case refer to: https://lists.freedesktop.org/archives/amd-gfx/2016-December/004068.html For some perf data on this initial implementati

Re: [Mesa-dev] [PATCH] nir: fix loop iteration count calculation for floats

2017-01-03 Thread Jason Ekstrand
Drp... Reviewed-by: Jason Ekstrand On Jan 3, 2017 7:00 PM, "Timothy Arceri" wrote: > Fixes performance regression in SynMark PSPom caused by loops with float > counters not always unrolling. > > For example: > >for (float i = 0.02; i < 0.9; i += 0.11) > ... > --- > src/compiler/nir/

[Mesa-dev] [PATCH] nir: fix loop iteration count calculation for floats

2017-01-03 Thread Timothy Arceri
Fixes performance regression in SynMark PSPom caused by loops with float counters not always unrolling. For example: for (float i = 0.02; i < 0.9; i += 0.11) ... --- src/compiler/nir/nir_loop_analyze.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/

[Mesa-dev] [Bug 97852] Unreal Engine corrupted preview viewport

2017-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97852 --- Comment #9 from Grazvydas Ignotas --- A game "Refunct" also suffers from this when "post process" setting is set to "ultra". Since this limitation is rather artificial, and multiple released programs are affected, could it be demoted to a wa

Re: [Mesa-dev] [PATCH 30/53] mesa: don't always set _NEW_PROGRAM when linking

2017-01-03 Thread Marek Olšák
On Wed, Jan 4, 2017 at 12:56 AM, Timothy Arceri wrote: > On Wed, 2017-01-04 at 00:44 +0100, Marek Olšák wrote: >> On Wed, Jan 4, 2017 at 12:36 AM, Timothy Arceri >> wrote: >> > On Tue, 2017-01-03 at 23:55 +0100, Marek Olšák wrote: >> > > On Tue, Jan 3, 2017 at 11:14 PM, Timothy Arceri >> > > wro

[Mesa-dev] [Bug 99244] hud_context.c:874:45: error: ‘W_OK’ undeclared

2017-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99244 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 30/53] mesa: don't always set _NEW_PROGRAM when linking

2017-01-03 Thread Timothy Arceri
On Wed, 2017-01-04 at 00:44 +0100, Marek Olšák wrote: > On Wed, Jan 4, 2017 at 12:36 AM, Timothy Arceri > wrote: > > On Tue, 2017-01-03 at 23:55 +0100, Marek Olšák wrote: > > > On Tue, Jan 3, 2017 at 11:14 PM, Timothy Arceri > > > wrote: > > > > On Tue, 2017-01-03 at 22:41 +0100, Marek Olšák wrot

Re: [Mesa-dev] [PATCH 30/53] mesa: don't always set _NEW_PROGRAM when linking

2017-01-03 Thread Marek Olšák
On Wed, Jan 4, 2017 at 12:36 AM, Timothy Arceri wrote: > On Tue, 2017-01-03 at 23:55 +0100, Marek Olšák wrote: >> On Tue, Jan 3, 2017 at 11:14 PM, Timothy Arceri >> wrote: >> > On Tue, 2017-01-03 at 22:41 +0100, Marek Olšák wrote: >> > > On Tue, Jan 3, 2017 at 10:14 PM, Timothy Arceri >> > > wro

Re: [Mesa-dev] [PATCH 30/53] mesa: don't always set _NEW_PROGRAM when linking

2017-01-03 Thread Timothy Arceri
On Tue, 2017-01-03 at 23:55 +0100, Marek Olšák wrote: > On Tue, Jan 3, 2017 at 11:14 PM, Timothy Arceri > wrote: > > On Tue, 2017-01-03 at 22:41 +0100, Marek Olšák wrote: > > > On Tue, Jan 3, 2017 at 10:14 PM, Timothy Arceri > > > wrote: > > > > On Tue, 2017-01-03 at 22:07 +0100, Marek Olšák wrot

Re: [Mesa-dev] [RFC] loader: Automatic PRIME detection

2017-01-03 Thread Axel Davy
On 02/01/2017 15:32, Thierry Reding wrote: On Tue, Dec 27, 2016 at 01:57:21PM +0100, Axel Davy wrote: Hi Thierry, Could you explain why in this situation default_fd would be a non-renderable device node ? This is preparatory work to allow drivers for split display/render setups to be tied toge

[Mesa-dev] [Bug 98604] [VDPAU, DRI3] Fullscreen flash video fails when hardware acceleration is enabled.

2017-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98604 --- Comment #10 from smoki --- (In reply to Chris Rankin from comment #9) > (In reply to smoki from comment #8) > > Does this still work for you with DRI2? Asking becuase DRI2 seems now > > affected also. > > I can't say, because Adobe has now "

Re: [Mesa-dev] [PATCH 30/53] mesa: don't always set _NEW_PROGRAM when linking

2017-01-03 Thread Marek Olšák
On Tue, Jan 3, 2017 at 11:14 PM, Timothy Arceri wrote: > On Tue, 2017-01-03 at 22:41 +0100, Marek Olšák wrote: >> On Tue, Jan 3, 2017 at 10:14 PM, Timothy Arceri >> wrote: >> > On Tue, 2017-01-03 at 22:07 +0100, Marek Olšák wrote: >> > > On Tue, Jan 3, 2017 at 9:57 PM, Timothy Arceri >> > > wrot

[Mesa-dev] [Bug 98604] [VDPAU, DRI3] Fullscreen flash video fails when hardware acceleration is enabled.

2017-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98604 --- Comment #9 from Chris Rankin --- (In reply to smoki from comment #8) > Does this still work for you with DRI2? Asking becuase DRI2 seems now > affected also. I can't say, because Adobe has now "upgraded" its Flash plugin to v24 and removed t

Re: [Mesa-dev] [PATCH 11/32] gbm: Introduce modifiers into surface/bo creation

2017-01-03 Thread Ben Widawsky
On 17-01-02 18:37:02, Ben Widawsky wrote: The idea behind modifiers like this is that the user of GBM will have some mechanism to query what properties the hardware supports for its BO or surface. This information is directly passed in (and stored) so that the DRI implementation can create an ima

[Mesa-dev] [Bug 98604] [VDPAU, DRI3] Fullscreen flash video fails when hardware acceleration is enabled.

2017-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98604 --- Comment #8 from smoki --- (In reply to Chris Rankin from comment #5) > I don't see your point here. AFAIK the Flash plugin knows nothing about > either DRI2 or DRI3, and it works fine with DRI2... Does this still work for you with DRI2? A

Re: [Mesa-dev] [PATCH v2 00/25] Enable Float64 capability support for Intel's Vulkan driver

2017-01-03 Thread Jason Ekstrand
14-18 and 22 are Reviewed-by: Jason Ekstrand I'd like to see the way we're enabling it for SPIR-V reworked to use the new struct Dave added. Overall, looks really good. --Jason On Tue, Jan 3, 2017 at 4:32 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > On Mon, 2017-01-02 at 10

Re: [Mesa-dev] [PATCH v2 22/25] nir/i965: use two slots from inputs_read for dvec3/dvec4 vertex input attributes

2017-01-03 Thread Jason Ekstrand
I made a few pretty trivial comments. With those addressed, Reviewed-by: Jason Ekstrand On Dec 16, 2016 8:55 AM, "Juan A. Suarez Romero" wrote: So far, input_reads was a bitmap tracking which vertex input locations were being used. In OpenGL, an attribute bigger than a vec4 (like a dvec3 or

[Mesa-dev] [Bug 99253] Radeon R7 370 / R9 270X/370X PCIe Bus Error: severity=Uncorrected (Fatal)

2017-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99253 Alex Deucher changed: What|Removed |Added QA Contact|mesa-dev@lists.freedesktop. |dri-devel@lists.freedesktop

Re: [Mesa-dev] [PATCH 30/53] mesa: don't always set _NEW_PROGRAM when linking

2017-01-03 Thread Timothy Arceri
On Tue, 2017-01-03 at 22:41 +0100, Marek Olšák wrote: > On Tue, Jan 3, 2017 at 10:14 PM, Timothy Arceri > wrote: > > On Tue, 2017-01-03 at 22:07 +0100, Marek Olšák wrote: > > > On Tue, Jan 3, 2017 at 9:57 PM, Timothy Arceri > > > wrote: > > > > On Tue, 2017-01-03 at 20:47 +0100, Marek Olšák wrote

Re: [Mesa-dev] [PATCH 3/3] radeonsi: add a workaround for the Witcher 2 black transitions

2017-01-03 Thread Edmondo Tommasina
Hi Marek This series is Tested-by: Edmondo Tommasina The black transitions in Witcher 2 are fixed for me. Thanks edmondo On Tue, Jan 3, 2017 at 8:17 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 15 +-- > 1 file chan

Re: [Mesa-dev] [PATCH 10/53] i965: stop passing gl_shader_program to brw_assign_common_binding_table_offsets()

2017-01-03 Thread Timothy Arceri
On Tue, 2017-01-03 at 17:39 +, Lionel Landwerlin wrote: > Reviewed-by: Lionel Landwerlin > > A tiny suggestion further down. > > On 03/01/17 02:43, Timothy Arceri wrote: > > We now get eventhing we need directly from gl_program so there is > > Everything? :) > > > no need for this. > > ---

[Mesa-dev] [PATCH v2 5/5] radv: Create single RADV_DEBUG env var.

2017-01-03 Thread Bas Nieuwenhuizen
Also changed RADV_SHOW_QUEUES to a no compute queue option. That would make more sense later when the compute queue is established, but the transfer queue still experimental. v2: Don't include the trace flag. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_device.c | 45 +++

[Mesa-dev] [PATCH v2 3/5] radv: Dump command buffer on hang.

2017-01-03 Thread Bas Nieuwenhuizen
v2: - Now use the filename specified by RADV_TRACE_FILE env var. - Use the same var to enable tracing. I thought we could as well always set the filename explicitly instead of having some arbitrary defaults, and at that point we don't need a separate feature enable. Signed-off-by: Bas Nieuwen

Re: [Mesa-dev] [PATCH 2/2] i965/miptree: Create a disable CCS flag

2017-01-03 Thread Ben Widawsky
On 17-01-03 13:12:43, Chad Versace wrote: On Tue 03 Jan 2017, Ben Widawsky wrote: On 17-01-03 08:21:06, Chad Versace wrote: > On Sun 01 Jan 2017, Ben Widawsky wrote: > > Cc: Topi Pohjolainen > > Cc: Chad Versace > > Signed-off-by: Ben Widawsky > > --- > > src/mesa/drivers/dri/i965/brw_blorp.

Re: [Mesa-dev] [PATCH v2 00/14] implement EGL_EXT_image_dma_buf_import_modifiers v2

2017-01-03 Thread Ben Widawsky
On 16-11-24 20:50:37, Varad Gautam wrote: This is the second revision to the EGL_EXT_image_dma_buf_import_modifiers [1] series at [2], addressing the comments received. This diverges from v1 due to some reordered/squashed changes, hence the resend. 1-4 are Reviewed-by: Ben Widawsky 5-9,12-13:

[Mesa-dev] [Bug 99253] Radeon R7 370 / R9 270X/370X PCIe Bus Error: severity=Uncorrected (Fatal)

2017-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99253 Jakob Sinclair changed: What|Removed |Added Version|unspecified |git --- Comment #1 from Jakob Sinclair

Re: [Mesa-dev] [PATCH 04/13] egl/main: add support for fourth plane tokens

2017-01-03 Thread Ben Widawsky
On 16-11-18 14:19:28, Emil Velikov wrote: On 15 November 2016 at 14:24, Varad Gautam wrote: From: Pekka Paalanen The EGL_EXT_dma_buf_import_modifiers extension adds support for a fourth plane, just like DRM KMS API does. Bump maximum dma_buf plane count to four. Signed-off-by: Pekka Paalane

Re: [Mesa-dev] [PATCH 30/53] mesa: don't always set _NEW_PROGRAM when linking

2017-01-03 Thread Marek Olšák
On Tue, Jan 3, 2017 at 10:14 PM, Timothy Arceri wrote: > On Tue, 2017-01-03 at 22:07 +0100, Marek Olšák wrote: >> On Tue, Jan 3, 2017 at 9:57 PM, Timothy Arceri >> wrote: >> > On Tue, 2017-01-03 at 20:47 +0100, Marek Olšák wrote: >> > > On Tue, Jan 3, 2017 at 3:43 AM, Timothy Arceri >> > > wrote

Re: [Mesa-dev] [PATCH 6/9] i965: Add support for tex upload using gpu

2017-01-03 Thread Anuj Phogat
On Mon, Jan 2, 2017 at 12:45 AM, Pohjolainen, Topi wrote: > On Thu, Dec 29, 2016 at 11:55:37AM -0800, Anuj Phogat wrote: >> On Tue, Dec 20, 2016 at 6:45 AM, Topi Pohjolainen >> wrote: >> > Signed-off-by: Topi Pohjolainen >> > --- >> > src/mesa/drivers/dri/i965/intel_tex.h | 8 + >> >

Re: [Mesa-dev] [PATCH 30/53] mesa: don't always set _NEW_PROGRAM when linking

2017-01-03 Thread Timothy Arceri
On Tue, 2017-01-03 at 22:07 +0100, Marek Olšák wrote: > On Tue, Jan 3, 2017 at 9:57 PM, Timothy Arceri > wrote: > > On Tue, 2017-01-03 at 20:47 +0100, Marek Olšák wrote: > > > On Tue, Jan 3, 2017 at 3:43 AM, Timothy Arceri > > > wrote: > > > > We only need to set it when linking was successful an

Re: [Mesa-dev] [PATCH 2/2] i965/miptree: Create a disable CCS flag

2017-01-03 Thread Chad Versace
On Tue 03 Jan 2017, Ben Widawsky wrote: > On 17-01-03 08:21:06, Chad Versace wrote: > > On Sun 01 Jan 2017, Ben Widawsky wrote: > > > Cc: Topi Pohjolainen > > > Cc: Chad Versace > > > Signed-off-by: Ben Widawsky > > > --- > > > src/mesa/drivers/dri/i965/brw_blorp.c | 2 +- > > > src/me

Re: [Mesa-dev] [PATCH] gallium/hud: add a path separator between dump directory and filename

2017-01-03 Thread Marek Olšák
Pushed, thanks. Marek On Sun, Jan 1, 2017 at 10:31 PM, Edmondo Tommasina wrote: > It's more user friendly and it avoids to write files in unexpected > places. > --- > src/gallium/auxiliary/hud/hud_context.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/a

Re: [Mesa-dev] [PATCH 30/53] mesa: don't always set _NEW_PROGRAM when linking

2017-01-03 Thread Marek Olšák
On Tue, Jan 3, 2017 at 9:57 PM, Timothy Arceri wrote: > On Tue, 2017-01-03 at 20:47 +0100, Marek Olšák wrote: >> On Tue, Jan 3, 2017 at 3:43 AM, Timothy Arceri >> wrote: >> > We only need to set it when linking was successful and the program >> > being linked is currently active. >> > >> > The pr

Re: [Mesa-dev] [PATCH 1/1] r600/sb: Fix loop optimization related hangs on eg

2017-01-03 Thread Marek Olšák
Pushed, thanks. Marek On Sun, Nov 20, 2016 at 2:42 PM, Heiko Przybyl wrote: > Make sure unused ops and their references are removed, prior to entering > the GCM (global code motion) pass, to stop GCM from breaking the loop > logic and thus hanging the GPU. > > Turns out, that sb has problems wit

Re: [Mesa-dev] [PATCH 30/53] mesa: don't always set _NEW_PROGRAM when linking

2017-01-03 Thread Timothy Arceri
On Tue, 2017-01-03 at 20:47 +0100, Marek Olšák wrote: > On Tue, Jan 3, 2017 at 3:43 AM, Timothy Arceri > wrote: > > We only need to set it when linking was successful and the program > > being linked is currently active. > > > > The programs_in_use mask is just used as a flag for now but in > > a

Re: [Mesa-dev] [PATCH] radeonsi: capitalize VM hex addr when dumping buffer list

2017-01-03 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Jan 3, 2017 at 6:41 PM, Samuel Pitoiset wrote: > Useful when debugging with R600_DEBUG=vm,check_vm to match > addr in both outputs. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/radeonsi/si_debug.c | 2 +- > 1 file changed, 1 insertion(+

Re: [Mesa-dev] [PATCH 30/53] mesa: don't always set _NEW_PROGRAM when linking

2017-01-03 Thread Marek Olšák
On Tue, Jan 3, 2017 at 3:43 AM, Timothy Arceri wrote: > We only need to set it when linking was successful and the program > being linked is currently active. > > The programs_in_use mask is just used as a flag for now but in > a following patch we will use it to update the CurrentProgram > array.

Re: [Mesa-dev] [PATCH] swr: remove unneeded llvm version check

2017-01-03 Thread Kyriazis, George
Reviewed-by: George Kyriazis George > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Tim Rowley > Sent: Tuesday, January 3, 2017 10:25 AM > To: Cherniak, Bruce ; mesa- > d...@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] swr: rem

Re: [Mesa-dev] [Mesa-stable] [PATCH] dri3: Fix MakeCurrent without a default framebuffer

2017-01-03 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Jan 3, 2017 at 12:41 AM, Fredrik Höglund wrote: > In OpenGL 3.0 and later it is legal to make a context current without > a default framebuffer. > > This has been broken since DRI3 support was introduced. > > Cc: "13.0 12.0" > --- > src/glx/dri3_glx.c |

[Mesa-dev] [PATCH 3/3] radeonsi: add a workaround for the Witcher 2 black transitions

2017-01-03 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c b/src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c index 996a458..efe28d1 100644

[Mesa-dev] [PATCH 2/3] radeonsi: set si_shader_context::input_decls for ranged decls correctly

2017-01-03 Thread Marek Olšák
From: Marek Olšák This has no effect because no code uses those members with ranged decls. --- src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c b/src/gallium/drivers/ra

[Mesa-dev] [PATCH 1/3] radeonsi: cleanly communicate whether si_shader_dump should check R600_DEBUG

2017-01-03 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 2 +- src/gallium/drivers/radeonsi/si_debug.c | 2 +- src/gallium/drivers/radeonsi/si_shader.c| 20 +++- src/gallium/drivers/radeonsi/si_shader.h| 2 +- src/gallium/drivers/radeonsi

Re: [Mesa-dev] [PATCH 0/2] Spirv: Set push constant base/range

2017-01-03 Thread Lionel Landwerlin
Ping? On 17/12/16 23:43, Lionel Landwerlin wrote: Hi, Up to now, load_push_constant intrinsics generated by the spirv compiler were hardcoded to have an offset of 0 and a range of 128. This series adds a function compute those offset & range. Cheers, Lionel Lionel Landwerlin (2): spirv:

Re: [Mesa-dev] [PATCH] mesa: Make CopyImage check against BaseLevel, not 0, for mipmapping.

2017-01-03 Thread Anuj Phogat
On Mon, Jan 2, 2017 at 8:01 PM, Kenneth Graunke wrote: > The intention here is to allow "base complete" instead of "mipmap > complete" as long as we're only copying from the base level (which > is usually 0, but not always). > > Signed-off-by: Kenneth Graunke > --- > src/mesa/main/copyimage.c |

Re: [Mesa-dev] [PATCH 13/53] i965: pass gl_program directly to brw_compile_tes()

2017-01-03 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 03/01/17 02:43, Timothy Arceri wrote: This is the only thing we use from gl_shader_program so pass it directly. --- src/mesa/drivers/dri/i965/brw_compiler.h | 2 +- src/mesa/drivers/dri/i965/brw_shader.cpp | 6 ++ src/mesa/drivers/dri/i965/brw_tes.c

[Mesa-dev] [PATCH] radeonsi: capitalize VM hex addr when dumping buffer list

2017-01-03 Thread Samuel Pitoiset
Useful when debugging with R600_DEBUG=vm,check_vm to match addr in both outputs. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_debug.c b/src/gallium/drivers/radeonsi/

Re: [Mesa-dev] [PATCH 11/53] i965: pass gl_program to brw_upload_ubo_surfaces()

2017-01-03 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 03/01/17 02:43, Timothy Arceri wrote: There is no need to pass gl_linked_shader anymore. --- src/mesa/drivers/dri/i965/brw_context.h | 3 +-- src/mesa/drivers/dri/i965/brw_gs_surface_state.c | 4 ++-- src/mesa/drivers/dri/i965/brw_tcs_surface_s

Re: [Mesa-dev] [PATCH 12/53] i965: stop passing gl_shader_program to brw_nir_setup_glsl_uniforms()

2017-01-03 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 03/01/17 02:43, Timothy Arceri wrote: We can now just get the data needed from the gl_shader_program_data pointer in gl_program. --- src/mesa/drivers/dri/i965/brw_cs.c | 4 ++-- src/mesa/drivers/dri/i965/brw_gs.c | 2 +- src/mesa/d

Re: [Mesa-dev] [PATCH 10/53] i965: stop passing gl_shader_program to brw_assign_common_binding_table_offsets()

2017-01-03 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin A tiny suggestion further down. On 03/01/17 02:43, Timothy Arceri wrote: We now get eventhing we need directly from gl_program so there is Everything? :) no need for this. --- src/mesa/drivers/dri/i965/brw_cs.c | 5 ++--- src/mesa/drivers/dri/i965/br

Re: [Mesa-dev] [PATCH 09/53] st/mesa/glsl/i965: move ShaderStorageBlocks to gl_program

2017-01-03 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 03/01/17 02:43, Timothy Arceri wrote: Having it here rather than in gl_linked_shader allows us to simplify the code. Also it is error prone to depend on the gl_linked_shader for programs in current use because a failed linking attempt will free infomation abou

Re: [Mesa-dev] [PATCH 08/53] st/mesa/glsl/i965: set num_ssbos directly in shader_info

2017-01-03 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 03/01/17 02:43, Timothy Arceri wrote: Here we also remove the duplicate field in gl_linked_shader and always get the value from shader_info instead. --- src/compiler/glsl/glsl_to_nir.cpp| 1 - src/compiler/glsl/link_uniforms.cpp

Re: [Mesa-dev] [PATCH 2/2] i965/miptree: Create a disable CCS flag

2017-01-03 Thread Ben Widawsky
On 17-01-03 08:21:06, Chad Versace wrote: On Sun 01 Jan 2017, Ben Widawsky wrote: Cc: Topi Pohjolainen Cc: Chad Versace Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_blorp.c | 2 +- src/mesa/drivers/dri/i965/brw_draw.c | 3 ++- src/mesa/drivers/dri/i965/int

Re: [Mesa-dev] [PATCH 2/2] i965/disasm: remove printing hstride and width in align16 DF source regions

2017-01-03 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] vec4: use DIM instruction when loading DF immediates in HSW

2017-01-03 Thread Matt Turner
On Tue, Jan 3, 2017 at 7:27 AM, Samuel Iglesias Gonsálvez wrote: > Signed-off-by: Samuel Iglesias Gonsálvez > --- > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp > b/src/mesa/drivers/dri/i9

Re: [Mesa-dev] [PATCH 06/53] st/mesa/glsl/i965: set num_ubos directly in shader_info

2017-01-03 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 03/01/17 02:43, Timothy Arceri wrote: This also removes the duplicate field in gl_linked_shader, and gets num_ubos from shader_info instead. --- src/compiler/glsl/glsl_to_nir.cpp| 1 - src/compiler/glsl/link_uniforms.cpp | 4 ++

Re: [Mesa-dev] [PATCH 07/53] st/mesa/glsl/i965: move per stage UniformBlocks to gl_program

2017-01-03 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 03/01/17 02:43, Timothy Arceri wrote: This will help allow us to store pointers to gl_program structs in the CurrentProgram array resulting in a bunch of code simplifications. --- src/compiler/glsl/link_uniforms.cpp | 4 ++-- src/compiler/glsl/

Re: [Mesa-dev] [PATCH v2 19/25] isl: fix VA64 support for double and dvecN vertex attributes

2017-01-03 Thread Jason Ekstrand
On Dec 16, 2016 8:55 AM, "Juan A. Suarez Romero" wrote: From: Samuel Iglesias Gonsálvez We use *64*_PASSTHRU formats to upload vertex attributes of 64 bits to avoid conversions. From the BDW PRM, Volume 2d, page 586 (VERTEX_ELEMENT_STATE): "When SourceElementFormat is set to one of the *6

Re: [Mesa-dev] [PATCH v2 23/25] spirv: enable SpvCapabilityFloat64 only to supported platforms

2017-01-03 Thread Jason Ekstrand
Dave recently added a spirv-specific structure for this sort of feature enabling. I think it would be better to use that rather than nir_options. On Dec 16, 2016 8:56 AM, "Juan A. Suarez Romero" wrote: > From: Samuel Iglesias Gonsálvez > > Signed-off-by: Samuel Iglesias Gonsálvez > --- > src

Re: [Mesa-dev] Patch for freedreno features

2017-01-03 Thread Jason Ekstrand
On Jan 3, 2017 9:54 AM, "Romain Failliot" wrote: 2017-01-03 10:47 GMT-05:00 Rob Clark : > Hmm, well I guess in future, git-format-patch and attach that to bz.. > but no worries this time, I went ahead and pushed it w/ --author as > Jan suggested Thanks! I'm sorry, I misunderstood, I thought you

Re: [Mesa-dev] [PATCH v2 17/25] spirv: add support for doubles to OpSpecConstant

2017-01-03 Thread Jason Ekstrand
On Fri, Dec 16, 2016 at 6:49 AM, Juan A. Suarez Romero wrote: > From: Samuel Iglesias Gonsálvez > > Signed-off-by: Samuel Iglesias Gonsálvez > --- > src/amd/vulkan/radv_pipeline.c| 5 +++- > src/compiler/spirv/nir_spirv.h| 5 +++- > src/compiler/spirv/spirv_to_nir.c | 51

Re: [Mesa-dev] [PATCH 05/53] st/mesa/glsl/i965: move ImageUnits and ImageAccess fields to gl_program

2017-01-03 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 03/01/17 02:43, Timothy Arceri wrote: Having it here rather than in gl_linked_shader allows us to simplify the code. Also it is error prone to depend on the gl_linked_shader for programs in current use because a failed linking attempt will free infomation abou

[Mesa-dev] [PATCH] swr: remove unneeded llvm version check

2017-01-03 Thread Tim Rowley
Old test caused breakage with llvm-svn (4.0.0svn), and not needed as the minimum required llvm version for swr is 3.6. --- src/gallium/drivers/swr/swr_shader.cpp | 4 1 file changed, 4 deletions(-) diff --git a/src/gallium/drivers/swr/swr_shader.cpp b/src/gallium/drivers/swr/swr_shader.cpp

Re: [Mesa-dev] [PATCH 1/2] i965: Replace bool aux disable with enum

2017-01-03 Thread Chad Versace
On Sun 01 Jan 2017, Ben Widawsky wrote: > As CCS buffers are passed to KMS, it becomes useful to be able to > determine exactly what type of aux buffers are disabled. This was > previously not entirely needed (though the code was a little more > confusing), however it becomes very desirable after a

Re: [Mesa-dev] [PATCH 2/2] i965/miptree: Create a disable CCS flag

2017-01-03 Thread Chad Versace
On Sun 01 Jan 2017, Ben Widawsky wrote: > Cc: Topi Pohjolainen > Cc: Chad Versace > Signed-off-by: Ben Widawsky > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 2 +- > src/mesa/drivers/dri/i965/brw_draw.c | 3 ++- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 21 +

Re: [Mesa-dev] Patch for freedreno features

2017-01-03 Thread Romain Failliot
2017-01-03 10:47 GMT-05:00 Rob Clark : > Hmm, well I guess in future, git-format-patch and attach that to bz.. > but no worries this time, I went ahead and pushed it w/ --author as > Jan suggested Thanks! I'm sorry, I misunderstood, I thought you preferred the patch to be in the mailing list (but

Re: [Mesa-dev] [PATCH 0/6] Enable OpenGL 4.0 on Haswell

2017-01-03 Thread Kenneth Graunke
On Tuesday, January 3, 2017 2:02:19 PM PST Iago Toral wrote: > On Tue, 2017-01-03 at 11:14 +, Chris Wilson wrote: > > On Tue, Jan 03, 2017 at 11:42:50AM +0100, Iago Toral Quiroga wrote: > > > > > > Enabling GL 4.0 in gen7 requires a bit of work because some > > > hardware and kernel > > > comb

Re: [Mesa-dev] Patch for freedreno features

2017-01-03 Thread Rob Clark
On Mon, Jan 2, 2017 at 1:18 PM, Romain Failliot wrote: > 2017-01-01 16:15 GMT-05:00 Rob Clark : >> well, I was trying to not loose authorship/etc from the patch >> (although tbh I've lost track of who the original author was).. >> http://www.mesa3d.org/devinfo.html#submitting has some suggestions.

Re: [Mesa-dev] [PATCH v2 14/25] nir: add nir_type_conversion_op()

2017-01-03 Thread Jason Ekstrand
On Tue, Jan 3, 2017 at 4:31 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > On Mon, 2017-01-02 at 10:34 -0800, Jason Ekstrand wrote: > > I've left some inline comments but this patch has gotten me thinking > > about the larger question of how we want to do conversion operations > >

Re: [Mesa-dev] [PATCH 0/6] Enable OpenGL 4.0 on Haswell

2017-01-03 Thread Kenneth Graunke
On Tuesday, January 3, 2017 11:42:50 AM PST Iago Toral Quiroga wrote: > Enabling GL 4.0 in gen7 requires a bit of work because some hardware and > kernel > combinations may not support all the features. Specifically, we need to know > if the kernel can do pipelined register writes. Unfortunately,

Re: [Mesa-dev] [PATCH 04/53] i965: get InfoLog and LinkStatus via the pointer in gl_program

2017-01-03 Thread Lionel Landwerlin
Thanks, I didn't pull -r :) Reviewed-by: Lionel Landwerlin On 03/01/17 11:44, Timothy Arceri wrote: On Tue, 2017-01-03 at 11:39 +, Lionel Landwerlin wrote: Did you left out accesses to prog-> and shader_prog-> on purpose in : brw_tcs.c brw_tes.c brw_vs.c brw_wm.c ? This patch should real

[Mesa-dev] [Bug 99253] Radeon R7 370 / R9 270X/370X PCIe Bus Error: severity=Uncorrected (Fatal)

2017-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99253 jordan changed: What|Removed |Added CC||jordanca...@gmail.com -- You are receiving thi

[Mesa-dev] [Bug 99253] Radeon R7 370 / R9 270X/370X PCIe Bus Error: severity=Uncorrected (Fatal)

2017-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99253 Bug ID: 99253 Summary: Radeon R7 370 / R9 270X/370X PCIe Bus Error: severity=Uncorrected (Fatal) Product: Mesa Version: unspecified Hardware: x86-64 (AMD64)

Re: [Mesa-dev] [PATCH 0/6] Enable OpenGL 4.0 on Haswell

2017-01-03 Thread Iago Toral
On Tue, 2017-01-03 at 11:14 +, Chris Wilson wrote: > On Tue, Jan 03, 2017 at 11:42:50AM +0100, Iago Toral Quiroga wrote: > > > > Enabling GL 4.0 in gen7 requires a bit of work because some > > hardware and kernel > > combinations may not support all the features. Specifically, we > > need to k

Re: [Mesa-dev] [PATCH v2 06/25] spirv: fix SpvOpSpecConstantOp with SpvOpVectorShuffle working with double-based vecs

2017-01-03 Thread Samuel Iglesias Gonsálvez
On Mon, 2017-01-02 at 10:10 -0800, Jason Ekstrand wrote: > > > On Fri, Dec 16, 2016 at 6:48 AM, Juan A. Suarez Romero ia.com> wrote: > > From: Samuel Iglesias Gonsálvez > > > > We need to pick two 32-bit values per component to perform the > > right shuffle operation. > > > > Signed-off-by: S

Re: [Mesa-dev] [PATCH v2 00/25] Enable Float64 capability support for Intel's Vulkan driver

2017-01-03 Thread Samuel Iglesias Gonsálvez
On Mon, 2017-01-02 at 10:20 -0800, Jason Ekstrand wrote: > 1-5 and 7-11 are > > Reviewed-by: Jason Ekstrand > > I left a few trivial comments on them but nothing substantial. > OK, I will fix them. Thanks for the review, Sam > On Fri, Dec 16, 2016 at 6:48 AM, Juan A. Suarez Romero > wrote:

Re: [Mesa-dev] [PATCH v2 13/25] nir: add nir_get_nir_type_for_glsl_type()

2017-01-03 Thread Samuel Iglesias Gonsálvez
On Mon, 2017-01-02 at 10:16 -0800, Jason Ekstrand wrote: > On Fri, Dec 16, 2016 at 6:48 AM, Juan A. Suarez Romero ia.com> wrote: > > From: Samuel Iglesias Gonsálvez > > > > Signed-off-by: Samuel Iglesias Gonsálvez > > --- > >  src/compiler/nir/nir.h | 19 +++ > >  1 file changed,

Re: [Mesa-dev] [PATCH v2 14/25] nir: add nir_type_conversion_op()

2017-01-03 Thread Samuel Iglesias Gonsálvez
On Mon, 2017-01-02 at 10:34 -0800, Jason Ekstrand wrote: > I've left some inline comments but this patch has gotten me thinking > about the larger question of how we want to do conversion operations > in NIR.  Ian already has patches for int64 but float16, int8, and > int16 are all coming.  If we k

[Mesa-dev] [PATCH 1/2] vec4: use DIM instruction when loading DF immediates in HSW

2017-01-03 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp b/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp index 065e317..98e023a 100644 --- a/src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH 2/2] i965/disasm: remove printing hstride and width in align16 DF source regions

2017-01-03 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/mesa/drivers/dri/i965/brw_disasm.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c b/src/mesa/drivers/dri/i965/brw_disasm.c index 6de52b3..167067a 100644 --- a/src/mesa/drivers/dri/i96

Re: [Mesa-dev] [PATCH 0/3] error handling

2017-01-03 Thread Christian König
Am 03.01.2017 um 11:47 schrieb Nayan Deshmukh: Hi Christian, Can you please push the patches for me. Done. Christian. Regards, Nayan Nayan Deshmukh (3): vl/compositor: implement error handling st/vdpau: error handling st/va: error handling src/gallium/auxiliary/vl/vl_composito

Re: [Mesa-dev] [PATCH 04/53] i965: get InfoLog and LinkStatus via the pointer in gl_program

2017-01-03 Thread Timothy Arceri
On Tue, 2017-01-03 at 11:39 +, Lionel Landwerlin wrote: > Did you left out accesses to prog-> and shader_prog-> on purpose in : > brw_tcs.c > brw_tes.c > brw_vs.c > brw_wm.c ? This patch should really have been squashed with this one I pushed today [1]. I only just noticed after I pushed it th

Re: [Mesa-dev] [PATCH 04/53] i965: get InfoLog and LinkStatus via the pointer in gl_program

2017-01-03 Thread Lionel Landwerlin
Did you left out accesses to prog-> and shader_prog-> on purpose in : brw_tcs.c brw_tes.c brw_vs.c brw_wm.c ? On 03/01/17 02:43, Timothy Arceri wrote: --- src/mesa/drivers/dri/i965/brw_cs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH 02/53] i965: stop depending on gl_shader_program for brw_compute_vue_map() params

2017-01-03 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 03/01/17 02:43, Timothy Arceri wrote: This removes another dependency on gl_shader_program from the codegen functions, this will help allow us to use gl_program for the CurrentProgram array rather than gl_shader_program. --- src/mesa/drivers/dri/i965/brw_gs.c

Re: [Mesa-dev] [PATCH 03/53] i965: get shared_size from shader_info rather than gl_shader_program

2017-01-03 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 03/01/17 02:43, Timothy Arceri wrote: --- src/mesa/drivers/dri/i965/brw_cs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_cs.c b/src/mesa/drivers/dri/i965/brw_cs.c index e4d82cf..522ddb9 100644 --- a/

Re: [Mesa-dev] [PATCH 01/53] i965: pass gl_program to the brw_*_debug_recompile() functions

2017-01-03 Thread Lionel Landwerlin
Looks fine to me : Reviewed-by: Lionel Landwerlin On 03/01/17 02:43, Timothy Arceri wrote: Rather then passing gl_shader_program. The only field use was Name which is the same as the Id field in gl_program. For wm and vs we also make the functions static and move them before the codegen func

Re: [Mesa-dev] [PATCH 0/6] Enable OpenGL 4.0 on Haswell

2017-01-03 Thread Chris Wilson
On Tue, Jan 03, 2017 at 11:42:50AM +0100, Iago Toral Quiroga wrote: > Enabling GL 4.0 in gen7 requires a bit of work because some hardware and > kernel > combinations may not support all the features. Specifically, we need to know > if the kernel can do pipelined register writes. Unfortunately, th

[Mesa-dev] [Bug 99237] Impossible to create transparent X11/EGL windows while respecting EGL_NATIVE_VISUAL_ID

2017-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99237 Daniel Stone changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH 2/3] st/vdpau: error handling

2017-01-03 Thread Nayan Deshmukh
handle the cases when vl_compositor_set_csc_matrix(), vl_compositor_init_state() and vl_compositor_init() fail Signed-off-by: Nayan Deshmukh Reviewed-by: Christian König --- src/gallium/state_trackers/vdpau/device.c | 8 +- src/gallium/state_trackers/vdpau/mixer.c | 43 +++

[Mesa-dev] [PATCH 1/3] vl/compositor: implement error handling

2017-01-03 Thread Nayan Deshmukh
pipe_buffer_map and pipe_buffer_create may return NULL Signed-off-by: Nayan Deshmukh Reviewed-by: Christian König --- src/gallium/auxiliary/vl/vl_compositor.c | 13 +++-- src/gallium/auxiliary/vl/vl_compositor.h | 2 +- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/sr

[Mesa-dev] [PATCH 3/3] st/va: error handling

2017-01-03 Thread Nayan Deshmukh
handle the cases when vl_compositor_set_csc_matrix(), vl_compositor_init_state() and vl_compositor_init() fail Signed-off-by: Nayan Deshmukh Reviewed-by: Christian König --- src/gallium/state_trackers/va/context.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff -

[Mesa-dev] [PATCH 0/3] error handling

2017-01-03 Thread Nayan Deshmukh
Hi Christian, Can you please push the patches for me. Regards, Nayan Nayan Deshmukh (3): vl/compositor: implement error handling st/vdpau: error handling st/va: error handling src/gallium/auxiliary/vl/vl_compositor.c | 13 -- src/gallium/auxiliary/vl/vl_compositor.h | 2 +- sr

[Mesa-dev] [PATCH 2/6] i965: make intel_batchbuffer_emit_dword() take a batchbuffer as argument

2017-01-03 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 6 +++--- src/mesa/drivers/dri/i965/intel_batchbuffer.h | 18 +- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c b/src/mesa/drivers/dri/i965/intel_batchbuffer.c inde

  1   2   >