On 12/20/2016 09:10 PM, Chad Versace wrote:
On Mon 19 Dec 2016, Tapani Pälli wrote:
On 12/17/2016 03:58 AM, Chad Versace wrote:
Happy Christmas to everyone who's busy squashing dEQP bugs.
I wrote a new GBM backend for dEQP. I even submitted it to dEQP's
upstream Gerrit. Pyry, dEQP's maintain
On 12/20/2016 08:58 PM, Chad Versace wrote:
On Tue 20 Dec 2016, Tapani Pälli wrote:
This makes better guarantee that the values we return are
in sync what the underlying drawable currently has.
Together with dEQP change bug #98327 this fixes following test:
dEQP-EGL.functional.resize.surfa
https://bugs.freedesktop.org/show_bug.cgi?id=99055
--- Comment #20 from Kenneth Graunke ---
(In reply to Eero Tamminen from comment #17)
> (In reply to Kenneth Graunke from comment #15)
> > Renaming the binaries or editing scripts installed with the game is liable
> > to break when new updates fo
On Tue, 2016-12-20 at 15:14 -0800, Jason Ekstrand wrote:
> I did have a couple of "real" comments on this one that I'd like to
> at least see a reply to. Does look pretty good though.
>
> On Sun, Dec 18, 2016 at 9:47 PM, Timothy Arceri bora.com> wrote:
> > From: Thomas Helland
> >
> > V2: Do a
From: Roland Scheidegger
This code uses a vector shift which has to be emulated on x86 unless
there's AVX2. Luckily in some cases we can actually avoid the shift
altogether, so do that.
Also make sure we hit the fast lp_build_conv() path when applicable,
albeit that's quite the hack...
That said,
From: Roland Scheidegger
Using bit replication. This path now resembles something which might make
sense. (The logic was mostly copied from llvmpipe fs backend.)
I am not convinced though it is actually faster than SoA sampling (actually
I'm quite certain it's always a loss with AVX).
With SoA it
From: Roland Scheidegger
simd instruction sets usually have comparisons for equal, not unequal.
So use a different comparison against the mask itself - which also means
we don't need a all-zero as well as a all-one (for the pxor) reg.
Also add code to avoid scalar expansion of i1 values which we
From: Roland Scheidegger
If we only feed one source vector at a time, we cannot use pack intrinsics
(as we only have a 64bit destination dst vector). lp_bld_conv_auto is
specifically designed to alter the length and number of destination vectors,
so this works just fine (if we use single source v
Hi Alex and Marek,
> >
> > Reviewed-by: Marek Olšák
> >
> > Has it ever been tested with Mesa?
>
> It was tested when the code was originally written and the hybrid stack
> (including
> mesa MM) has been tested recently. I don't have a
> polaris12 card at the moment.
Just now I verified it aga
https://bugs.freedesktop.org/show_bug.cgi?id=99076
Jordan Justen changed:
What|Removed |Added
Resolution|WONTFIX |NOTOURBUG
--
You are receiving this mai
https://bugs.freedesktop.org/show_bug.cgi?id=99076
Randy changed:
What|Removed |Added
Resolution|--- |WONTFIX
Status|NEW
Hi, Kenneth
The patch https://android-review.googlesource.com/#/c/291429/ for GLES3.1 has
been merged to dEQP master branch, so expect the GLES3 change should be merged
also.
In this case, we don't need this change in Mesa.
Thanks,
Randy
-Original Message-
From: Kenneth Graunke [mail
This makes much more sense and should be more performant in some
critical paths such as SSO validation which is called at draw time.
Previously the CurrentProgram array could have contained multiple
pointers to the same struct which was confusing and we would often
need to fish out the information
On Wednesday, December 21, 2016 9:05:27 AM PST Randy Xu wrote:
> From the OGLES 3.2 spec, Section 8.5 Texture Image Specification, page 158:
> "An INVALID_OPERATION error is generated if a combination of
> values for format, type, and internalformat is specified that is
> not listed as a valid
On Tue, Dec 20, 2016 at 5:06 PM, Timothy Arceri <
timothy.arc...@collabora.com> wrote:
> On Tue, 2016-12-20 at 16:31 -0800, Jason Ekstrand wrote:
> > On Sun, Dec 18, 2016 at 9:47 PM, Timothy Arceri > bora.com> wrote:
> > > V2:
> > > - tidy ups suggested by Connor.
> > > - tidy up cloning logic an
On Tue, 2016-12-20 at 16:31 -0800, Jason Ekstrand wrote:
> On Sun, Dec 18, 2016 at 9:47 PM, Timothy Arceri bora.com> wrote:
> > V2:
> > - tidy ups suggested by Connor.
> > - tidy up cloning logic and handle copy propagation
> > based of suggestion by Connor.
> > - use nir_ssa_def_rewrite_uses to
From the OGLES 3.2 spec, Section 8.5 Texture Image Specification, page 158:
"An INVALID_OPERATION error is generated if a combination of
values for format, type, and internalformat is specified that is
not listed as a valid combination in tables 8.2 or 8.3."
It means that TexImage3D should ret
Am 20.12.2016 um 22:12 schrieb Giuseppe Bilotta:
> On Tue, Dec 20, 2016 at 2:17 AM, Matt Turner wrote:
>> On Mon, Dec 19, 2016 at 5:12 PM, Giuseppe Bilotta
>> wrote:
>>> Just one question though —not knowing much of the shader language, can
>>> I expect expm1 to be available?
>>
>> No, expm1 does
On Tue, 2016-12-20 at 16:34 -0800, Jason Ekstrand wrote:
> On Tue, Dec 20, 2016 at 3:36 PM, Timothy Arceri bora.com> wrote:
> > On Tue, 2016-12-20 at 15:14 -0800, Jason Ekstrand wrote:
> > > I did have a couple of "real" comments on this one that I'd like
> > to
> > > at least see a reply to. Doe
Thanks, Chad
I will update the patch per your suggestion.
-Original Message-
From: Chad Versace [mailto:chadvers...@chromium.org]
Sent: Wednesday, December 21, 2016 5:05 AM
To: Xu, Randy
Cc: Ian Romanick ; mesa-dev@lists.freedesktop.org;
mesa-sta...@lists.freedesktop.org
Subject: Re:
On Tue, Dec 20, 2016 at 3:36 PM, Timothy Arceri <
timothy.arc...@collabora.com> wrote:
> On Tue, 2016-12-20 at 15:14 -0800, Jason Ekstrand wrote:
> > I did have a couple of "real" comments on this one that I'd like to
> > at least see a reply to. Does look pretty good though.
> >
> > On Sun, Dec
On Sun, Dec 18, 2016 at 9:47 PM, Timothy Arceri <
timothy.arc...@collabora.com> wrote:
> V2:
> - tidy ups suggested by Connor.
> - tidy up cloning logic and handle copy propagation
> based of suggestion by Connor.
> - use nir_ssa_def_rewrite_uses to fix up lcssa phis
> suggested by Connor.
> -
On Tue, 2016-12-20 at 15:14 -0800, Jason Ekstrand wrote:
> I did have a couple of "real" comments on this one that I'd like to
> at least see a reply to. Does look pretty good though.
>
> On Sun, Dec 18, 2016 at 9:47 PM, Timothy Arceri bora.com> wrote:
> > From: Thomas Helland
> >
> > V2: Do a
I did have a couple of "real" comments on this one that I'd like to at
least see a reply to. Does look pretty good though.
On Sun, Dec 18, 2016 at 9:47 PM, Timothy Arceri <
timothy.arc...@collabora.com> wrote:
> From: Thomas Helland
>
> V2: Do a "depth first search" to convert to LCSSA
>
> V3:
I made a bunch more comments but they're all cosmetic. The one
non-cosmetic thing I'd like to see changed before we merge is that we fix
the case where the break is in the else. Feel free to grab the tip of my
jenkins_vulkan branch and squash it in if you like the approach I took. Or
you can do
On Fri, Dec 2, 2016 at 5:31 PM, Emil Velikov wrote:
> From: Emil Velikov
>
> drmGetDevices2() provides us with enough flexibility to build heuristics
> upon. Opening a random node on the other hand will wake up the device,
> regardless if it's the one we're intereseted or not.
>
> Cc: Michel Dänz
Vedran Miletić writes:
> Presently errors from frontend are handled only if they occur in
> clang::CompilerInvocation::CreateFromArgs(). This patch uses
> clang::DiagnosticsEngine to detect errors such as invalid values for
> Clang frontend arguments.
>
> Fixes Piglit's cl/program/build/fail/inva
From: Boyuan Zhang
Signed-off-by: Boyuan Zhang
---
src/gallium/state_trackers/vdpau/vdpau_private.h | 4
1 file changed, 4 insertions(+)
diff --git a/src/gallium/state_trackers/vdpau/vdpau_private.h
b/src/gallium/state_trackers/vdpau/vdpau_private.h
index bcd4bb1..2780265 100644
--- a/sr
From: Boyuan Zhang
Signed-off-by: Boyuan Zhang
---
src/gallium/auxiliary/util/u_video.h | 1 +
src/gallium/include/pipe/p_video_enums.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/gallium/auxiliary/util/u_video.h
b/src/gallium/auxiliary/util/u_video.h
index 7e743de..88af8f6 1
From: Boyuan Zhang
Signed-off-by: Boyuan Zhang
---
src/gallium/drivers/radeon/radeon_uvd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/radeon/radeon_uvd.c
b/src/gallium/drivers/radeon/radeon_uvd.c
index d5d654a..228c20d 100644
--- a/src/gallium/drivers/radeon/radeon
From: Boyuan Zhang
Signed-off-by: Boyuan Zhang
---
src/gallium/state_trackers/va/va_private.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/state_trackers/va/va_private.h
b/src/gallium/state_trackers/va/va_private.h
index e9ccdbf..08e52fd 100644
--- a/src/gallium/state_tracke
On Tue, 2016-12-20 at 09:44 -0800, Jason Ekstrand wrote:
> On Mon, Dec 19, 2016 at 8:18 PM, Timothy Arceri bora.com> wrote:
> > Unless an if statement contains nested returns we can simply add
> > any following instructions to the branch without the return.
> >
> > V2: fix handling if_nested_retu
"Juan A. Suarez Romero" writes:
> On Mon, 2016-12-19 at 13:58 -0800, Francisco Jerez wrote:
>> Iago Toral Quiroga writes:
>>
>> > From: "Juan A. Suarez Romero"
>> >
>> > Our current data flow analysis does not take into account that
>> > channels
>> > on 64-bit operands are 64-bit. This is a
Am 20.12.2016 um 15:13 schrieb Jose Fonseca:
> On 12/12/16 00:11, srol...@vmware.com wrote:
>> From: Roland Scheidegger
>>
>> We should do transpose, not extract/insert, at least with "sufficient"
>> amount
>> of channels (for 4 channels, extract/insert shuffles generated
>> otherwise look
>> trul
On Tue, Dec 20, 2016 at 2:17 AM, Matt Turner wrote:
> On Mon, Dec 19, 2016 at 5:12 PM, Giuseppe Bilotta
> wrote:
>> Just one question though —not knowing much of the shader language, can
>> I expect expm1 to be available?
>
> No, expm1 doesn't exist in GLSL.
This is extremely bothersome. Both th
On Mon 19 Dec 2016, Xu, Randy wrote:
> Hi, Chad & Ian
>
> Thanks for your suggestion, and I understand and agree your point,
> while the texsubimage_error_check (in teximage.c) calls
> _mesa_error_check_format_and_type first, and if error happens, it will
> return immediately (in 2175) and not cal
On Tuesday, December 20, 2016 12:08:06 PM PST Jonathan Gray wrote:
> Can someone push this to master?
Pushed:
To ssh://git.freedesktop.org/git/mesa/mesa
ab8ea1b..62b8bcd master -> master
Have you thought about applying for commit access?
signature.asc
Description: This is a digitally signe
On Tuesday, December 20, 2016 5:20:43 PM PST Pohjolainen, Topi wrote:
> On Tue, Dec 20, 2016 at 03:05:14PM +, Ben Widawsky wrote:
> > On 16-12-20 16:45:30, Topi Pohjolainen wrote:
> > > If gl-state remains intact api_validate.c::_mesa_valid_to_render()
> > > and brw_try_draw_prims() skip checki
typo on the subject: "Eliminate"
On 20/12/16 00:45, Timothy Arceri wrote:
> Reviewed-by: Timothy Arceri
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
Bah... Forgot this:
Reviewed-by: Jason Ekstrand
On Dec 20, 2016 13:12, "Jason Ekstrand" wrote:
> On Dec 19, 2016 13:27, "Kenneth Graunke" wrote:
>
> BaseVertex, BaseInstance, DrawID, and some edge flag conditions need
> vertex buffer and elements structs. We can't bail early in this case.
>
On Dec 19, 2016 13:27, "Kenneth Graunke" wrote:
BaseVertex, BaseInstance, DrawID, and some edge flag conditions need
vertex buffer and elements structs. We can't bail early in this case.
Gen4-7 already do this properly. Gen8+ did not.
Thanks to Ilia Mirkin for helping track this down.
Cc: me
On Mon 19 Dec 2016, Tapani Pälli wrote:
>
>
> On 12/17/2016 03:58 AM, Chad Versace wrote:
> > Happy Christmas to everyone who's busy squashing dEQP bugs.
> >
> > I wrote a new GBM backend for dEQP. I even submitted it to dEQP's
> > upstream Gerrit. Pyry, dEQP's maintainer, told me over beer ear
On Tue, Dec 20, 2016 at 1:34 PM, Marek Olšák wrote:
> For the series:
>
> Reviewed-by: Marek Olšák
>
> Has it ever been tested with Mesa?
It was tested when the code was originally written and the hybrid
stack (including mesa MM) has been tested recently. I don't have a
polaris12 card at the mo
On Tue 20 Dec 2016, Tapani Pälli wrote:
> This makes better guarantee that the values we return are
> in sync what the underlying drawable currently has.
>
> Together with dEQP change bug #98327 this fixes following test:
>
>dEQP-EGL.functional.resize.surface_size.grow
>
> Signed-off-by: Tap
For the series:
Reviewed-by: Marek Olšák
Has it ever been tested with Mesa?
Marek
On Mon, Dec 19, 2016 at 11:45 PM, Alex Deucher wrote:
> From: Junwei Zhang
>
> v2: use gfxip names for llvm 4.0+
> v3: use tonga for llvm <= 3.8
>
> Signed-off-by: Junwei Zhang
> Reviewed-by: Nicolai Hähnle
>
For the series:
Reviewed-by: Marek Olšák
Marek
On Mon, Dec 19, 2016 at 8:09 PM, Axel Davy wrote:
> Add documentation to explicit what can be expected and what is allowed
> when using several contexts.
>
> Signed-off-by: Axel Davy
> ---
> src/gallium/docs/source/context.rst | 23 +
On Mon, Dec 19, 2016 at 8:18 PM, Timothy Arceri <
timothy.arc...@collabora.com> wrote:
> Unless an if statement contains nested returns we can simply add
> any following instructions to the branch without the return.
>
> V2: fix handling if_nested_return value when there is a sibling if/loop
> tha
On Tue, Dec 20, 2016 at 12:49 AM, Gustaw Smolarczyk
wrote:
> 2016-12-20 6:32 GMT+01:00 Jason Ekstrand :
> > This sequence shows up The Talos Principal, at least under Vulkan,
> > and prevents loop analysis from properly computing trip counts in a
> > few loops.
> > ---
> > src/compiler/nir/nir_o
On 12/20/2016 11:59 AM, Jan Vesely wrote:
> On Fri, 2016-12-16 at 13:43 -0800, Francisco Jerez wrote:
>> Vedran Miletić writes:
>>
>>> Current implementation of event handling keeps an extra reference to
>>> the hardware event, in addition to the reference returned via the OpenCL
>>> API. This add
Presently errors from frontend are handled only if they occur in
clang::CompilerInvocation::CreateFromArgs(). This patch uses
clang::DiagnosticsEngine to detect errors such as invalid values for
Clang frontend arguments.
Fixes Piglit's cl/program/build/fail/invalid-version-declaration.cl
test.
Si
On Tue, Dec 20, 2016 at 6:49 AM, Andreas Boll
wrote:
> 2016-12-19 23:45 GMT+01:00 Alex Deucher :
>> From: Junwei Zhang
>>
>> v2: use gfxip names for llvm 4.0+
>> v3: use tonga for llvm <= 3.8
>>
>> Signed-off-by: Junwei Zhang
>> Reviewed-by: Nicolai Hähnle
>> Acked-by: Christian König
>> ---
>
On Tue, Dec 20, 2016 at 03:05:14PM +, Ben Widawsky wrote:
> On 16-12-20 16:45:30, Topi Pohjolainen wrote:
> > If gl-state remains intact api_validate.c::_mesa_valid_to_render()
> > and brw_try_draw_prims() skip checking if textures and shader
> > images need resolves.
> > This can lead to a cas
On 16-12-20 16:45:30, Topi Pohjolainen wrote:
If gl-state remains intact api_validate.c::_mesa_valid_to_render()
and brw_try_draw_prims() skip checking if textures and shader
images need resolves.
This can lead to a case where a surface is left unresolved due to
driver writing it internally using
This series introduces new use of brw_blorp_blit_miptrees()/
brw_blorp_copy_miptrees(). Initial intention was to enable compression
on SKL already at the time of upload. That, however, didn't help
benchmarks but quite contrary regressed performance in some of
them (Synmark OglDrvRer for one).
There
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/intel_tex.h | 8 +
src/mesa/drivers/dri/i965/intel_tex_subimage.c | 194 +
2 files changed, 202 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_tex.h
b/src/mesa/drivers/dri/i965/intel_tex
If gl-state remains intact api_validate.c::_mesa_valid_to_render()
and brw_try_draw_prims() skip checking if textures and shader
images need resolves.
This can lead to a case where a surface is left unresolved due to
driver writing it internally using blorp. Blorp doesn't trash
global gl state but
Current estimate doesn't consider space needed for surface states
and it only calculates for one shader stage. Each stage can have
its own sampler and surface state configuration.
While this is only matter of runtime dynamics we don't seem to hit
it currently. However, this becomes visible with bl
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/intel_tex_image.c| 24 +++-
src/mesa/drivers/dri/i965/intel_tex_subimage.c | 19 +--
2 files changed, 12 insertions(+), 31 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/common/meta_tex_subimage.c | 9 +++--
src/mesa/main/glformats.c | 15 +++
src/mesa/main/glformats.h | 4
3 files changed, 22 insertions(+), 6 deletions(-)
diff --git a/src/mesa/drivers
Blorp clears already have an equivalent.
Signed-off-by: Topi Pohjolainen
---
src/intel/blorp/blorp_blit.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c
index 8abe3a8..9dcd33f 100644
--- a/src/intel/blorp/blorp_blit.c
+++ b/src/i
instead of _mesa_meta_pbo_TexSubImage().
While the newly introduced intel_texsubimage_gpu_copy() is capable
of handling all the cases _mesa_meta_pbo_TexSubImage() can, it
is also capable of handling everything intel_texsubimage_tiled_memcpy()
does. And in addition part of the cases left to _mesa_s
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/intel_tex_subimage.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c
b/src/mesa/drivers/dri/i965/intel_tex_subimage.c
index f999a93..741637a 100644
--- a/src/mesa/drivers/dri
and move it to brw_draw.c where it will be eventually used.
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_context.c | 174 +--
src/mesa/drivers/dri/i965/brw_draw.c| 178
src/mesa/drivers/dri/i965/brw_draw.h|
On 12/12/16 00:11, srol...@vmware.com wrote:
From: Roland Scheidegger
We should do transpose, not extract/insert, at least with "sufficient" amount
of channels (for 4 channels, extract/insert shuffles generated otherwise look
truly terrifying). Albeit we shouldn't fallback to that so often in a
On 12/12/16 00:11, srol...@vmware.com wrote:
From: Roland Scheidegger
soa fetch so far always assumed that data was aligned. However, we want to
use this for vertex fetch, and data might not be aligned there, so handle
it in this path too (basically just pass through alignment through to other
On 12/12/16 00:12, srol...@vmware.com wrote:
From: Roland Scheidegger
Now that there's some SoA fetch which never falls back, we should usually get
results which are better or at least not worse (something like rgba32f will
stay the same). I suppose though it might be worse in some cases where
On 12/12/16 00:12, srol...@vmware.com wrote:
From: Roland Scheidegger
This previously always fell back to AoS conversion. Even for 4-float formats
(which is the optimal case by far for that fallback case) this was suboptimal,
since it meant the conversion couldn't be done with 256bit vectors. W
On 12/12/16 00:12, srol...@vmware.com wrote:
From: Roland Scheidegger
This can now handle rgtc (unorm) too - this path no longer handles plain
formats, but that's unnecessary they now all have their proper SoA unpack
(this will still be dog-slow though due to the actual fetch being per-pixel
ut
2016-12-19 23:45 GMT+01:00 Alex Deucher :
> From: Junwei Zhang
>
> v2: use gfxip names for llvm 4.0+
> v3: use tonga for llvm <= 3.8
>
> Signed-off-by: Junwei Zhang
> Reviewed-by: Nicolai Hähnle
> Acked-by: Christian König
> ---
snip
> diff --git a/src/gallium/drivers/radeon/r600_pipe_common.
On Fri, 2016-12-16 at 13:43 -0800, Francisco Jerez wrote:
> Vedran Miletić writes:
>
> > Current implementation of event handling keeps an extra reference to
> > the hardware event, in addition to the reference returned via the OpenCL
> > API. This additional reference is internal and should not
Hi,
I think it fixed one of the segfaults with closed vkreplay window, but
it still segfaults. For details, see backtrace here:
https://github.com/LunarG/VulkanTools/issues/124
- Eero
On 20.12.2016 05:59, Arda Coskunses wrote:
Without this check driver crash when application
Now that the i965 backend doesn't depend on this field we can
make it more generic and short circuit a bunch of code paths.
The new field will be used in a following patch for another
clean-up.
---
src/compiler/glsl/link_varyings.cpp| 5 +++-
src/compiler/glsl/linker.cpp |
---
src/compiler/glsl/linker.cpp| 60 ++---
src/mesa/drivers/dri/i965/brw_tcs.c | 6 ++--
src/mesa/main/shaderapi.c | 15 +++---
3 files changed, 37 insertions(+), 44 deletions(-)
diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/
We also move EarlyFragmentTests out of the gl_shader_info struct
as it is now only used by gl_shader.
---
src/compiler/glsl/glsl_parser_extras.cpp | 2 +-
src/compiler/glsl/linker.cpp | 4 ++--
src/mesa/main/mtypes.h | 12 ++--
src/mesa/main/shaderapi.
We also move NumProgramResourceList at the same time.
GLES does interface validation on SSO at runtime so we need to move
this to be able to switch to storing gl_program pointers in
CurrentProgram.
---
src/compiler/glsl/linker.cpp | 20 +--
src/mesa/main/mtypes.h |
This makes much more sense and should be more performant in some
critical paths such as SSO validation which is called at draw time.
Previously the CurrentProgram array could have contained multiple
pointers to the same struct which was confusing and we would often
need to fish out the information
We no longer need to pass gl_shader_program.
Reviewed-by: Nicolai Hähnle
---
src/mesa/state_tracker/st_atom_storagebuf.c | 30 ++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/src/mesa/state_tracker/st_atom_storagebuf.c
b/src/mesa/state_tracker/st_at
This is only used by gl_linked_shader as a temp during linking
so use a temp there instead.
---
src/compiler/glsl/glsl_parser_extras.cpp | 2 +-
src/compiler/glsl/linker.cpp | 12 +---
src/mesa/main/mtypes.h | 2 +-
3 files changed, 7 insertions(+), 9 deleti
We only need to set it when linking was successful and the program
being linked is currently active.
The programs_in_use mask is just used as a flag for now but in
a following patch we will use it to update the CurrentProgram
array.
---
src/mesa/main/shaderapi.c | 22 +-
1 fil
This change also removes the now duplicate NumImages field.
Reviewed-by: Nicolai Hähnle
---
src/compiler/glsl/link_uniforms.cpp| 2 +-
src/compiler/glsl/linker.cpp | 7 ---
src/mesa/main/mtypes.h | 7 ---
src/mesa/main/shaderapi.c
These are rewritten to do what the function name suggests, that is
_mesa_shader_program_use() sets the use of all stage and
_mesa_program_use() sets the use of a single stage.
This patch is split out to make review easier but will be squashed into
mesa: use gl_program for CurrentProgram rather tha
---
src/compiler/glsl/linker.cpp | 35 +++
src/mesa/main/mtypes.h | 10 --
src/mesa/main/shaderapi.c| 6 ++
src/mesa/main/shaderobj.c| 2 --
4 files changed, 17 insertions(+), 36 deletions(-)
diff --git a/src/compiler/glsl/linker.cpp b/s
This will help allow us to simplify the handling of samplers by
storing them in a single location rather than duplicating them in
both gl_linked_shader and gl_program.
---
src/compiler/glsl/link_uniforms.cpp | 7 ---
src/mesa/main/mtypes.h| 14 --
src/mes
This is only used by gl_linked_shader as a temp during linking
so use a temp there instead.
---
src/compiler/glsl/glsl_parser_extras.cpp | 2 +-
src/compiler/glsl/linker.cpp | 8 +++-
src/mesa/main/mtypes.h | 3 +--
3 files changed, 5 insertions(+), 8 deletions(-)
This is only used by gl_shader not gl_linked_shader so move it
there.
---
src/compiler/glsl/glsl_parser_extras.cpp | 2 +-
src/compiler/glsl/linker.cpp | 2 +-
src/mesa/main/mtypes.h | 3 ++-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/compiler/
We now get everything we need from the gl_program param.
Reviewed-by: Nicolai Hähnle
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
b/src/mesa/state_tracker/st_glsl_to_tg
There is no reason for this to be in the shared gl_shader_info or
to copy it to gl_program at the end of linking (its already there).
---
src/compiler/glsl/glsl_parser_extras.cpp | 2 +-
src/compiler/glsl/linker.cpp | 2 +-
src/mesa/main/mtypes.h | 3 ++-
src/mesa/mai
There are some line wrapping violations here but those lines will get
deleted in the following patch.
---
src/compiler/glsl/glsl_to_nir.cpp | 2 --
src/compiler/glsl/linker.cpp| 32 +++
src/mesa/drivers/dri/i965/brw_vs.c | 2 +-
src/mesa/main/mtypes.h
Here we remove the single use of this field in gl_linked_shader
which allows us to move the field out of gl_shader_info
While we are at it we rewrite link_xfb_stride_layout_qualifiers()
to be more clear.
---
src/compiler/glsl/glsl_parser_extras.cpp | 2 +-
src/compiler/glsl/link_varyings.cpp
This is only used by gl_linked_shader as a temp during linking
so use a temp there instead.
---
src/compiler/glsl/glsl_parser_extras.cpp | 2 +-
src/compiler/glsl/linker.cpp | 8 +++-
src/mesa/main/mtypes.h | 9 +
3 files changed, 9 insertions(+), 10 delet
---
src/compiler/glsl/link_varyings.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/compiler/glsl/link_varyings.cpp
b/src/compiler/glsl/link_varyings.cpp
index da51fd8..398e1da 100644
--- a/src/compiler/glsl/link_varyings.cpp
+++ b/src/compiler/glsl/link_varyings.cpp
@@ -120,6 +120,7
---
src/mesa/main/mtypes.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
index 9f84735..1a56382 100644
--- a/src/mesa/main/mtypes.h
+++ b/src/mesa/main/mtypes.h
@@ -2352,8 +2352,6 @@ struct gl_linked_shader
struct exec_list *packed_varying
---
src/compiler/glsl/link_varyings.cpp | 6 --
src/compiler/glsl/linker.cpp| 14 --
src/mesa/main/mtypes.h | 7 ---
3 files changed, 4 insertions(+), 23 deletions(-)
diff --git a/src/compiler/glsl/link_varyings.cpp
b/src/compiler/glsl/link_varyings.cpp
---
src/compiler/glsl/linker.cpp| 25 -
src/mesa/drivers/dri/i965/brw_tcs.c | 6 ++
src/mesa/main/shaderapi.c | 6 +-
3 files changed, 15 insertions(+), 22 deletions(-)
diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp
ind
---
src/mesa/drivers/dri/i965/brw_vs.c | 11 +--
src/mesa/drivers/dri/i965/brw_wm.c | 13 ++---
2 files changed, 11 insertions(+), 13 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_vs.c
b/src/mesa/drivers/dri/i965/brw_vs.c
index c08be1f..dfa40ac 100644
--- a/src/mesa/dri
This is the only thing we use from gl_shader_program so pass it directly.
---
src/mesa/drivers/dri/i965/brw_compiler.h | 2 +-
src/mesa/drivers/dri/i965/brw_shader.cpp | 6 ++
src/mesa/drivers/dri/i965/brw_tes.c | 2 +-
3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/me
Also move out of the shared gl_shader_info.
---
src/compiler/glsl/glsl_parser_extras.cpp | 2 +-
src/compiler/glsl/linker.cpp | 3 +--
src/mesa/main/mtypes.h | 3 +--
src/mesa/main/shaderapi.c| 1 -
4 files changed, 3 insertions(+), 6 deletions(-)
dif
Making this point to a gl_program struct rather than a gl_shader_program
struct will allow use to later also make the CurrentProgram array hold
gl_program structs which in turn will allow for code simpilifcation.
---
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 8 ++--
src/mesa/main/api
There is no need to loop over active samplers the code above this
would have already exited if the sampler was inactive, or errored
if the count was larger than the uniforms array size.
---
src/mesa/main/uniform_query.cpp | 33 +++--
1 file changed, 11 insertions(+), 22
This is never used in gl_linked_shader other than as a temp
during linking so just use a temp instead.
---
src/compiler/glsl/glsl_parser_extras.cpp | 3 +--
src/compiler/glsl/linker.cpp | 21 -
src/mesa/main/mtypes.h | 3 ++-
3 files changed, 11
1 - 100 of 144 matches
Mail list logo
