On 11/22/2016 09:15 AM, Xu, Randy wrote:
Hi, Tapani
Can you share your detailed CTS result summary and logs? We will double check
it.
Btw, we do the CTS test on SKL GT2 and android-ia.
Sure, I'll send you the log file. I'm running on Android-IA as well.
Thanks,
Randy
-Original Messa
This has been unused since 943b69cddd
---
src/compiler/glsl/glsl_parser_extras.cpp | 1 -
src/mesa/main/ff_fragment_shader.cpp | 1 -
src/mesa/main/mtypes.h | 1 -
3 files changed, 3 deletions(-)
diff --git a/src/compiler/glsl/glsl_parser_extras.cpp
b/src/compiler/glsl/glsl
For the series:
Reviewed-by: Bas Nieuwenhuizen
On Tue, Nov 22, 2016 at 7:34 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> For the hw resolve there is no need to emit any sort
> of texture coordinates, so drop them all in the meta path.
>
> Signed-off-by: Dave Airlie
> ---
> src/amd/vulkan/ra
Reviewed-by: Bas Nieuwenhuizen
On Tue, Nov 22, 2016 at 5:44 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> I've started working on a shader-db alike for Vulkan,
> it's based on vktrace and it records pipelines, this
> adds support to dump the shader stats exactly like
> radeonsi does, so I can
On Tue, Nov 22, 2016 at 3:15 PM, Liu, Zhiquan wrote:
> Hi Tomasz,
>
> Thanks for you commends.
>> >
>>
>> Looks like this patch has already landed, but please let me try to
>> confirm some things here anyway. Would you mind keeping me on CC for
>> any future patches for the EGL/Android module? (I
On 11/22/2016 08:39 AM, Xu, Randy wrote:
Hi ,Tapani
With this pbuffer patch, only three EGL dEQP failure remained on Android
platform , they are under investigation now
dEQP-EGL.functional.image.create#gles2_renderbuffer_depth16_depth_buffer fail due to
"=== with config {glformat=rgbad2
From: Dave Airlie
This fixes a bunch of crashes in CTS tests looking for this.
Signed-off-by: Dave Airlie
---
src/amd/common/ac_nir_to_llvm.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index 17cefea..741a0
From: Dave Airlie
For the hw resolve there is no need to emit any sort
of texture coordinates, so drop them all in the meta path.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_meta_resolve.c | 49 ++
1 file changed, 2 insertions(+), 47 deletions(-)
dif
From: Dave Airlie
The sample id is packed into bits 8-12, so adjust
things properly.
Signed-off-by: Dave Airlie
---
src/amd/common/ac_nir_to_llvm.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to
From: Dave Airlie
This cleans up the ddxy emission along the same lines as
radeonsi. It also means we don't use LDS on VI chips we
use the dspermute interface, it also removes some duplicated
code.
Signed-off-by: Dave Airlie
---
src/amd/common/ac_nir_to_llvm.c | 136 +--
On 11/22/2016 08:08 AM, Tapani Pälli wrote:
On 11/22/2016 08:02 AM, Tomasz Figa wrote:
On Tue, Nov 22, 2016 at 2:44 PM, Tapani Pälli
wrote:
On 11/21/2016 04:15 PM, Emil Velikov wrote:
On 21 November 2016 at 07:23, Tomasz Figa wrote:
Hi,
On Wed, Nov 16, 2016 at 11:11 AM, Liu Zhiquan
Hi Tomasz,
Thanks for you commends.
> >
>
> Looks like this patch has already landed, but please let me try to
> confirm some things here anyway. Would you mind keeping me on CC for
> any future patches for the EGL/Android module? (I believe
> scripts/get_reviewer.pl should already include me
On 11/22/2016 08:02 AM, Tomasz Figa wrote:
On Tue, Nov 22, 2016 at 2:44 PM, Tapani Pälli wrote:
On 11/21/2016 04:15 PM, Emil Velikov wrote:
On 21 November 2016 at 07:23, Tomasz Figa wrote:
Hi,
On Wed, Nov 16, 2016 at 11:11 AM, Liu Zhiquan
wrote:
@@ -775,14 +837,6 @@ droid_add_config
On Tue, Nov 22, 2016 at 2:44 PM, Tapani Pälli wrote:
>
>
> On 11/21/2016 04:15 PM, Emil Velikov wrote:
>>
>> On 21 November 2016 at 07:23, Tomasz Figa wrote:
>>>
>>> Hi,
>>>
>>> On Wed, Nov 16, 2016 at 11:11 AM, Liu Zhiquan
>>> wrote:
@@ -775,14 +837,6 @@ droid_add_configs_for_visuals(_EGLD
On 11/21/2016 04:15 PM, Emil Velikov wrote:
On 21 November 2016 at 07:23, Tomasz Figa wrote:
Hi,
On Wed, Nov 16, 2016 at 11:11 AM, Liu Zhiquan wrote:
mesa android path didn't support pbuffer, so add pbuffer support to
fix most deqp and cts pbuffer test cases fail;
add single buffer config
Jordan pointed out that this patch is bogus. Please disregard.
On Mon, Nov 21, 2016 at 8:26 PM, Jason Ekstrand
wrote:
> This is required by compute shaders.
>
> Cc: "13.0"
> Cc: Jordan Justen
> ---
> src/intel/vulkan/anv_cmd_buffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
From: Dave Airlie
I've started working on a shader-db alike for Vulkan,
it's based on vktrace and it records pipelines, this
adds support to dump the shader stats exactly like
radeonsi does, so I can reuse the shader-db scripts it
uses.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_device
This is required by compute shaders.
Cc: "13.0"
Cc: Jordan Justen
---
src/intel/vulkan/anv_cmd_buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_cmd_buffer.c
b/src/intel/vulkan/anv_cmd_buffer.c
index d882c18..c6122db 100644
--- a/src/intel/vulkan
Cc: "13.0"
Cc: Jordan Justen
---
src/intel/vulkan/genX_cmd_buffer.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index eded1c9..6af2a18 100644
--- a/src/intel/vulkan/genX_cmd_buffer.c
+
This can happen even if the binding table isn't changed. For instance, you
could have dynamic offsets with your descriptor set. This fixes the new
stress.lots-of-surface-state.cs.dynamic cricible test.
Cc: "13.0"
Cc: Jordan Justen
---
src/intel/vulkan/genX_cmd_buffer.c | 23 +-
If we try to allocate a binding table and fail, we have to get a new
binding table block, re-emit STATE_BASE_ADDRESS, and then try again. We
already handle this correctly for 3D and blorp but it never got handled for
CS. This fixes the new stress.lots-of-surface-state.cs.static crucible test.
Cc
IMO we should wrap all these with:
#ifdef DEBUG
Including the existing SourceChecksum declaration of SourceChecksum in
gl_shader.
With those changes series is:
Reviewed-by: Timothy Arceri
On Tue, 2016-11-22 at 02:20 +0100, Marek Olšák wrote:
> From: Marek Olšák
>
> for debugging
> ---
> sr
---
src/intel/tools/decoder.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/intel/tools/decoder.c b/src/intel/tools/decoder.c
index 6bd02bf..55488eb 100644
--- a/src/intel/tools/decoder.c
+++ b/src/intel/tools/decoder.c
@@ -612,8 +612,8 @@ gen_group_get_length(struct
This series is,
Acked-by: Edward O'Callaghan
On 11/22/2016 12:19 PM, Bas Nieuwenhuizen wrote:
> No sense in repeatedly determining it. Also, it might be dependent
> on the device as shaders get compiled differently for SI/CIK/VI etc.
>
> Signed-off-by: Bas Nieuwenhuizen
> ---
> src/amd/vulkan/
From: Marek Olšák
for debugging
---
src/mesa/main/ff_fragment_shader.cpp | 1 +
src/mesa/main/shaderobj.c| 1 +
2 files changed, 2 insertions(+)
diff --git a/src/mesa/main/ff_fragment_shader.cpp
b/src/mesa/main/ff_fragment_shader.cpp
index e00eac5..2497108 100644
--- a/src/mesa/mai
From: Marek Olšák
for debugging
---
src/compiler/glsl/linker.cpp | 8
src/mesa/main/mtypes.h | 1 +
2 files changed, 9 insertions(+)
diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp
index 61a029c..9678a74 100644
--- a/src/compiler/glsl/linker.cpp
+++ b/src
From: Marek Olšák
---
src/mesa/main/imports.c | 22 --
src/mesa/main/imports.h | 3 ---
src/mesa/main/shaderapi.c | 3 ++-
3 files changed, 2 insertions(+), 26 deletions(-)
diff --git a/src/mesa/main/imports.c b/src/mesa/main/imports.c
index 808b8f6..de4dd0e 100644
---
From: Marek Olšák
---
src/gallium/auxiliary/Makefile.sources| 2 --
src/gallium/drivers/radeonsi/si_state_shaders.c | 2 +-
src/util/Makefile.sources | 2 ++
src/{gallium/auxiliary/util/u_hash.c => util/crc32.c} | 4 ++--
src/{gallium/auxilia
Invalidates the cache when someone switches cards.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_device.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 04c0bdc..8595973 100644
--- a/src/amd
We want to also invalidate the cache when LLVM gets changed. As the
specific LLVM revision is not fixed at build time, we will need to
check at runtime. Computing a checksum for LLVM is going to be very
expensive, so just use the mtime.
Tested on my computer that the returned DSO for the LLVM symb
No sense in repeatedly determining it. Also, it might be dependent
on the device as shaders get compiled differently for SI/CIK/VI etc.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_device.c | 18 ++
src/amd/vulkan/radv_pipeline_cache.c | 8
src/amd/v
This series is,
Reviewed-by: Edward O'Callaghan
On 11/22/2016 08:41 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/gallium/drivers/radeon/r600_pipe_common.c | 1 +
> src/gallium/drivers/radeon/r600_pipe_common.h | 1 +
> src/gallium/drivers/radeonsi/si_state_shaders.c | 5 +
>
Reviewed-by: Tim Rowley
mailto:timothy.o.row...@intel.com>>
On Nov 20, 2016, at 12:20 PM, Ilia Mirkin
mailto:imir...@alum.mit.edu>> wrote:
This may ultimately be possible to support, but for now it's not hooked
up and the swr core only supports this output from GS.
This normally wouldn't matte
Reviewed-by: Tim Rowley
mailto:timothy.o.row...@intel.com>>
On Nov 20, 2016, at 10:32 AM, Ilia Mirkin
mailto:imir...@alum.mit.edu>> wrote:
The former calculations were for min/max y. The width/height don't take
translate into account.
Signed-off-by: Ilia Mirkin mailto:imir...@alum.mit.edu>>
--
The following series implements what is needed on clover's
side for OpenCL image support. This seems to work with some
basic applications with radeonsi. Although, I have not yet
included the patch to enable by default until the LLVM bugs
this can potentially trigger with more complex kernels are
re
Signed-off-by: Edward O'Callaghan
---
src/gallium/state_trackers/clover/api/memory.cpp | 9 -
src/gallium/state_trackers/clover/core/memory.cpp | 13 +
src/gallium/state_trackers/clover/core/memory.hpp | 10 ++
3 files changed, 31 insertions(+), 1 deletion(-)
diff -
Signed-off-by: Edward O'Callaghan
---
src/gallium/state_trackers/clover/api/memory.cpp | 13 +
src/gallium/state_trackers/clover/core/memory.cpp | 14 ++
src/gallium/state_trackers/clover/core/memory.hpp | 11 +++
3 files changed, 34 insertions(+), 4 deletions(-)
Signed-off-by: Edward O'Callaghan
---
src/gallium/state_trackers/clover/api/memory.cpp | 9 -
src/gallium/state_trackers/clover/core/memory.cpp | 13 +
src/gallium/state_trackers/clover/core/memory.hpp | 10 ++
3 files changed, 31 insertions(+), 1 deletion(-)
diff -
Signed-off-by: Edward O'Callaghan
---
src/gallium/state_trackers/clover/api/memory.cpp | 17 -
src/gallium/state_trackers/clover/core/memory.cpp | 14 ++
src/gallium/state_trackers/clover/core/memory.hpp | 11 +++
3 files changed, 41 insertions(+), 1 deletion(
Reviewed-by: Bruce Cherniak
> On Nov 19, 2016, at 11:09 PM, Ilia Mirkin wrote:
>
> Currently a sequence like draw/map/draw/map will cause the second map to
> not wait for the second draw. This is because the first map will clear
> the resource business bit, and the second draw won't reset it si
Reviewed-by: Bruce Cherniak
> On Nov 20, 2016, at 4:25 PM, Ilia Mirkin wrote:
>
> Multiple buffers may reference client arrays. When this happens, we
> might reach for scratch space multiple times, which could cause later
> arrays to invalidate the pointers allocated for the earlier ones.
>
>
Reviewed-by: Tim Rowley
mailto:timothy.o.row...@intel.com>>
On Nov 19, 2016, at 10:11 AM, Ilia Mirkin
mailto:imir...@alum.mit.edu>> wrote:
This is the same value that llvmpipe uses. Since swr uses the same
sampler logic, makes sense for this value to also be the same. Most
applications don't ca
Nice,
Reviewed-by: Elie Tournier
2016-11-21 18:56 GMT+01:00 Emil Velikov :
> From: Emil Velikov
>
> Mention the script - why/how to use alongside a useful trick to make it
> work interactively (thanks Rob!).
>
> Signed-off-by: Emil Velikov
> ---
> Based on top of the "git tips" from earlier
On Tue, Nov 8, 2016 at 1:21 PM, Jason Ekstrand wrote:
> Most of the 3-D engine Kaby Lake is identical to Sky Lake. However, there
> are a few small differences that we need to be able to detect.
>
> Signed-off-by: Jason Ekstrand
I noticed this patch has never landed.
___
On 22 November 2016 3:37:32 am AEDT, Emil Velikov
wrote:
>From: Timothy Arceri
>
>v2: [Emil Velikov]
> - Add the shorthand git send-email -vX
> - Move to submittingpatches.html
> - Add to the TOC.
>
>Cc: Timothy Arceri
>Signed-off-by: Emil Velikov
>Reviewed-by: Brian Paul (v1)
>---
>Tim any
From: Boyuan Zhang
The gop_size in rate control is the budget window for internal rate
control calculation, and shouldn't always equal to idr period. Define
a coefficient to let budget window contains a number of idr period for
proper rate control calculation. Adjust the number of i/p frame remai
From: Boyuan Zhang
The gop_size in rate control is the budget window for internal rate
control calculation, and shouldn't always equal to idr period. Define
a coefficient to let budget window contains a number of idr period for
proper rate control calculation. Adjust the number of i/p frame remai
Brian Paul writes:
> [resending, original msg didn't appear on list]
>
> It seems a bit silly to have two linked list utilities.
>
> git-grep indicates that list.h is used more than simple_list.h so maybe
> we can switch uses of the later to the former. In fact, I've already
> found a few file
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
b/src/gallium/drivers/radeonsi/si_shader.c
index abe30e5..6228a68 100644
--- a/src/gallium/drivers/radeonsi/si_shader.c
+++ b/src/
From: Marek Olšák
---
src/gallium/drivers/radeon/r600_pipe_common.c | 1 +
src/gallium/drivers/radeon/r600_pipe_common.h | 1 +
src/gallium/drivers/radeonsi/si_state_shaders.c | 5 +
3 files changed, 7 insertions(+)
diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c
b/src/galli
Pushed, thanks.
Marek
On Mon, Nov 21, 2016 at 3:24 PM, Edward O'Callaghan
wrote:
> Reviewed-by: Edward O'Callaghan
>
> On 11/22/2016 01:20 AM, Mun Gwan-gyeong wrote:
>> When the uploading of shader fails on si_shader_binary_upload(),
>> it returns -ENOMEM. We should handle si_shader_binary_uplo
Reviewed-by: Tim Rowley
mailto:timothy.o.row...@intel.com>>
On Nov 17, 2016, at 10:56 PM, Ilia Mirkin
mailto:imir...@alum.mit.edu>> wrote:
There's no guarantee that mip width/height will be a multiple of the
compressed block size. Doing a divide by the block size first yields
different results
Reviewed-by: Tim Rowley
mailto:timothy.o.row...@intel.com>>
On Nov 17, 2016, at 10:56 PM, Ilia Mirkin
mailto:imir...@alum.mit.edu>> wrote:
The minification should happen before alignment, not after. See similar
logic on ComputeLODOffsetY. The current logic requires unnecessarily
large textures
Do you want to review input attachments too? This series relies on it.
On Nov 21, 2016 9:55 AM, "Jordan Justen" wrote:
> Series Reviewed-by: Jordan Justen
>
> On 2016-11-19 11:40:02, Jason Ekstrand wrote:
> > This little series builds on top of the input attachment series I sent
> out
> > earl
On Mon, Nov 21, 2016 at 9:01 AM, Nicolai Hähnle wrote:
> On 16.11.2016 19:38, Marek Olšák wrote:
>>
>> From: Marek Olšák
>>
>> Fixed piglits:
>> - arb_cull_distance/clip-cull-3
>> - arb_cull_distance/clip-cull-4
>
>
> Cc: stable for this and the previous patch?
It won't apply without some of the
From: Emil Velikov
Mention the script - why/how to use alongside a useful trick to make it
work interactively (thanks Rob!).
Signed-off-by: Emil Velikov
---
Based on top of the "git tips" from earlier.
---
docs/submittingpatches.html | 18 ++
1 file changed, 18 insertions(+)
d
On Mon, Nov 21, 2016 at 9:32 AM, Nicolai Hähnle wrote:
> On 16.11.2016 19:38, Marek Olšák wrote:
>>
>> Patches 1-10 are random improvements.
>>
>> Patches 11-14 are cleanups.
>>
>> Patches 15-20 add support for optimized shader variants compiled
>> asynchronously (without stalling rendering).
>>
>
Series Reviewed-by: Jordan Justen
On 2016-11-19 11:40:02, Jason Ekstrand wrote:
> This little series builds on top of the input attachment series I sent out
> earlier this week and adds support for fast clears in Vulkan. I've tested
> it on both Sky Lake and Haswell and it has no regressions ove
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/swr/swr_shader.cpp | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/swr/swr_shader.cpp
b/src/gallium/drivers/swr/swr_shader.cpp
index 428c9b3..294a568 100644
--- a/src/gallium/drivers/swr/swr_shader.c
This fixes gl-coord-replace-doesnt-eliminate-frag-tex-coords
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/swr/swr_shader.cpp | 3 ++-
src/gallium/drivers/swr/swr_shader.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/swr/swr_shader.cpp
b/src/ga
We were previously not marking the "regular" flat outputs as flat when
flatshading was enabled.
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/swr/swr_state.cpp | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/swr/swr_state.cpp
b/src/gallium/driv
Fixes a few things:
- sprite coords only apply to generic varyings, and are a bitmask
- back color only applies in 2-sided lighting mode
- handle some odd situations between only some front/back colors being
there. This is only semi-legal in GL, but we shouldn't start
crashing.
Signed-off
The way that dual-source blending is described for GLES2 is very odd,
and we end up with a shader that both has this property set *and* has a
color1 value to be used as the second source. While changing the state
tracker is an option, it seems more reliable to verify that the
broadcast is only done
On 2016-11-19 11:40:08, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/anv_blorp.c | 102
> -
> src/intel/vulkan/anv_private.h | 3 ++
> src/intel/vulkan/genX_cmd_buffer.c | 100 ++--
> 3 files changed, 176 insertions
When writing texture or sampler information into descriptor sets, also store
the related information for border color workaround on Gen7.5.
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_descriptor_set.c | 60 ++-
1 file changed, 59 insertions(+), 1 del
---
src/intel/vulkan/anv_private.h | 4 +++-
src/intel/vulkan/genX_state.c | 21 +
2 files changed, 24 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
index 7d7380a..8231f6b 100644
--- a/src/intel/vulkan/anv_private.h
This additional buffer stores workaround border colors & mask based of the
format's number of channels for integer formats on Gen7.5.
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_descriptor_set.c | 16
src/intel/vulkan/anv_private.h| 13 +
2 file
This replicates the following commit from our GL driver :
commit c25e5300cba7628b58df93ead14ebc3cc32f338c
Author: Kenneth Graunke
Date: Fri Jan 20 03:33:40 2012 -0800
i965: Fix border color on Sandybridge and Ivybridge.
On Haswell, it fixes:
dEQP-VK.pipeline.sampler.view_type.*.format
This additional buffer will store workaround border colors for integer
formats on Gen7.5.
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_descriptor_set.c | 42 +++
src/intel/vulkan/anv_private.h| 9
2 files changed, 51 insertions(+)
d
This pass wraps sampler instructions with some logic to deal with border
colors with integer formats on Gen7.5.
Fixes most of :
dEQP-VK.pipeline.sampler.view_type.*.format.*int.address_modes.all_mode_clamp_to_border_*
Remaining 11 failures :
HSW:
dEQP-VK.pipeline.sampler.view_type.*
Hi,
This is another attempt at fixing the border colors on Haswell. Patch 1 is
probably a genuine fix, the rest implements a workaround for the integer
formats.
The idea is the following, store the border colors and wrapping information
for all the samplers as well as some additional information
This additional buffer will store workaround border colors for integer
formats on Gen7.5.
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_descriptor_set.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/intel/vulkan/anv_descriptor_set.c
b/src/intel/vulkan/a
On 21 November 2016 at 17:21, Nicolai Hähnle wrote:
> On 21.11.2016 17:37, Emil Velikov wrote:
>>
>> From: Timothy Arceri
>>
>> v2: [Emil Velikov]
>> - Add the shorthand git send-email -vX
>> - Move to submittingpatches.html
>> - Add to the TOC.
>>
>> Cc: Timothy Arceri
>> Signed-off-by: Emil
On 19 November 2016 at 01:38, Tobias Droste wrote:
> Patches 1-11 and 13-16 are only rebased, no change in functionality and have
> a reviewed by.
>
> Patch 12 is changed based on review of Emil (I used "HAVE_GALLIUM_LLVM"
> instead of "USE_MESA_LLVM").
> Patch 17 is changed based on review of E
Reviewed-by: Tim Rowley
mailto:timothy.o.row...@intel.com>>
On Nov 17, 2016, at 6:51 PM, Ilia Mirkin
mailto:imir...@alum.mit.edu>> wrote:
The non-fast-clear path was never updated after clear colors were passed
in as floats. Remove the now-harmful conversion from unorm8.
Signed-off-by: Ilia Mi
On 21.11.2016 17:37, Emil Velikov wrote:
From: Timothy Arceri
v2: [Emil Velikov]
- Add the shorthand git send-email -vX
- Move to submittingpatches.html
- Add to the TOC.
Cc: Timothy Arceri
Signed-off-by: Emil Velikov
Reviewed-by: Brian Paul (v1)
---
Tim any objections on merging this ?
From: Timothy Arceri
v2: [Emil Velikov]
- Add the shorthand git send-email -vX
- Move to submittingpatches.html
- Add to the TOC.
Cc: Timothy Arceri
Signed-off-by: Emil Velikov
Reviewed-by: Brian Paul (v1)
---
Tim any objections on merging this ? IMHO these are quite useful.
---
docs/subm
On 18 November 2016 at 19:49, Kyriazis, George
wrote:
>
>
>> -Original Message-
>> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On
>> Behalf Of Emil Velikov
>> Sent: Friday, November 18, 2016 5:24 AM
>> To: Kyriazis, George
>> Cc: ML mesa-dev
>> Subject: Re: [Mesa-dev]
On Thu, 2016-11-17 at 16:17 +1100, Timothy Arceri wrote:
> On Mon, 2016-11-14 at 19:15 +0200, Andres Gomez wrote:
...
> > diff --git a/src/compiler/glsl/ast_type.cpp
> > b/src/compiler/glsl/ast_type.cpp
> > index 803d952..064c63b 100644
> > --- a/src/compiler/glsl/ast_type.cpp
> > +++ b/src/compile
On Thu, 2016-11-17 at 16:56 +1100, Timothy Arceri wrote:
> On Mon, 2016-11-14 at 19:15 +0200, Andres Gomez wrote:
...
> > diff --git a/src/compiler/glsl/glsl_parser.yy
> > b/src/compiler/glsl/glsl_parser.yy
> > index 50f7097..9f18c15 100644
> > --- a/src/compiler/glsl/glsl_parser.yy
> > +++ b/src/
On Thu, 2016-11-17 at 16:47 +1100, Timothy Arceri wrote:
> On Mon, 2016-11-14 at 19:15 +0200, Andres Gomez wrote:
> > The point mode value in an ast_type_qualifier can only be true if the
> > flag is already set since this layout-id-qualifier can only be or not
> > be present in a shader.
> >
> >
On Thu, 2016-11-17 at 16:45 +1100, Timothy Arceri wrote:
> I might have asked you this before. Is there a reason why we can't call
> merge_qualifier from merge_into_in_qualifier() like we do
> in merge_into_out_qualifier() to take care of some of these for us?
> Since there is duplicate code.
Ans
Hi Jonas,
On 21 November 2016 at 05:56, Jonas Ådahl wrote:
> On Thu, Nov 10, 2016 at 10:38:51AM +, Daniel Stone wrote:
>> On 10 November 2016 at 06:08, Jonas Ådahl wrote:
>> > On Mon, Oct 24, 2016 at 08:42:59PM +0100, Daniel Stone wrote:
>> That relies on the compositor releasing buffers in
On Mon, Nov 21, 2016 at 8:15 AM, Emil Velikov wrote:
> On 21 November 2016 at 07:23, Tomasz Figa wrote:
>> Hi,
>>
>> On Wed, Nov 16, 2016 at 11:11 AM, Liu Zhiquan wrote:
>>> mesa android path didn't support pbuffer, so add pbuffer support to
>>> fix most deqp and cts pbuffer test cases fail;
>>>
We're missing the close() to the matching open().
CID 1373407
v2: Fixes from Emil Velikov's review
Update the teardown in reverse order of the setup/init.
Signed-off-by: Mun Gwan-gyeong
---
src/util/disk_cache.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git
Thank you for the reviews, Emil.
Tim will check-in the series, since he has check-in privileges.
George
> -Original Message-
> From: Emil Velikov [mailto:emil.l.veli...@gmail.com]
> Sent: Saturday, November 19, 2016 4:23 PM
> To: Kyriazis, George
> Cc: ML mesa-dev
> Subject: Re: [Mesa-
On 20 November 2016 at 13:59, Mun Gwan-gyeong wrote:
> We're missing the close() to the matching open().
>
> CID 1373407
>
> Signed-off-by: Mun Gwan-gyeong
> ---
> src/util/disk_cache.c | 11 +--
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/src/util/disk_cache.c b/s
On 21 November 2016 at 14:36, Tomasz Figa wrote:
> On Mon, Nov 21, 2016 at 11:15 PM, Emil Velikov
> wrote:
>> On 21 November 2016 at 07:23, Tomasz Figa wrote:
>>> Hi,
>>>
>>> On Wed, Nov 16, 2016 at 11:11 AM, Liu Zhiquan wrote:
mesa android path didn't support pbuffer, so add pbuffer supp
On Mon, Nov 21, 2016 at 11:15 PM, Emil Velikov wrote:
> On 21 November 2016 at 07:23, Tomasz Figa wrote:
>> Hi,
>>
>> On Wed, Nov 16, 2016 at 11:11 AM, Liu Zhiquan wrote:
>>> mesa android path didn't support pbuffer, so add pbuffer support to
>>> fix most deqp and cts pbuffer test cases fail;
>>
Reviewed-by: Iago Toral Quiroga
On Sun, 2016-11-20 at 22:59 +0900, Mun Gwan-gyeong wrote:
> We're missing the close() to the matching open().
>
> CID 1373407
>
> Signed-off-by: Mun Gwan-gyeong
> ---
> src/util/disk_cache.c | 11 +--
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
When the uploading of shader fails on si_shader_binary_upload(),
it returns -ENOMEM. We should handle si_shader_binary_upload() failure path
on si_create_compute_state().
CID 1394027
v2: Fixes from Edward O'Callaghan's review
a) Update explicitly return value check with "si_shader_binary_upload(
Reviewed-by: Edward O'Callaghan
On 11/22/2016 01:20 AM, Mun Gwan-gyeong wrote:
> When the uploading of shader fails on si_shader_binary_upload(),
> it returns -ENOMEM. We should handle si_shader_binary_upload() failure path
> on si_create_compute_state().
>
> CID 1394027
>
> v2: Fixes from Edwa
On 21 November 2016 at 07:23, Tomasz Figa wrote:
> Hi,
>
> On Wed, Nov 16, 2016 at 11:11 AM, Liu Zhiquan wrote:
>> mesa android path didn't support pbuffer, so add pbuffer support to
>> fix most deqp and cts pbuffer test cases fail;
>> add single buffer config to support pbuffer, and create image
On Mon, Nov 21, 2016 at 10:39 PM, Emil Velikov wrote:
> On 21 November 2016 at 06:50, Tomasz Figa wrote:
>> On Thu, Nov 10, 2016 at 5:48 PM, Tapani Pälli wrote:
>>>
>>>
>>> On 11/10/2016 09:55 AM, Tomasz Figa wrote:
There is an interface that can be used to query YUV buffers for their
On 17 November 2016 at 13:59, Eric Engestrom wrote:
> On Friday, 2016-11-11 16:31:16 +, Emil Velikov wrote:
>> From: Emil Velikov
>>
>> Just fetch and store it once, rather than doing the
>> xcb_setup_roots_iterator + get_xcb_screen dance five times.
>>
>> Signed-off-by: Emil Velikov
>> ---
From: Emil Velikov
Signed-off-by: Emil Velikov
Reviewed-by: Eric Engestrom
---
src/gallium/auxiliary/vl/vl_winsys_dri.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri.c
b/src/gallium/auxiliary/vl/vl_winsys_dri.c
index 9ecc216
From: Emil Velikov
Just fetch and store it once, rather than doing the
xcb_setup_roots_iterator + get_xcb_screen dance five times.
v2: Call xcb_disconnect() on error (Eric)
Signed-off-by: Emil Velikov
Reviewed-by: Eric Engestrom (v1)
---
src/egl/drivers/dri2/egl_dri2.h | 2 +-
src/
From: Emil Velikov
Identical throughout dri2, dri3 and drisw. Next patch will add more
common code, so rather than duplicating it factor out the function.
Note: this also sets eglError on failure. Something that's quite
inconsistent throughout the codebase.
v2: Call xcb_disconnect() on error (E
On 21 November 2016 at 06:50, Tomasz Figa wrote:
> On Thu, Nov 10, 2016 at 5:48 PM, Tapani Pälli wrote:
>>
>>
>> On 11/10/2016 09:55 AM, Tomasz Figa wrote:
>>>
>>> There is an interface that can be used to query YUV buffers for their
>>> internal format. Specifically, if gralloc:lock_ycbcr() is g
Hi, Lionel Landwerlin
Thanks for reviewing. As I do not have the permission of mesa git, I
can not push it.
If you have permission for git push, can you push this patch?
Best regards,
Gwan-gyeong.
2016-11-21 20:20 GMT+09:00 Lionel Landwerlin :
> Thanks!
>
> Reviewed-by: Lionel Landwerlin
>
>
1 - 100 of 112 matches
Mail list logo
