[Mesa-dev] [PATCH 2/3] i965: Make split_virtual_grfs() call compact_virtual_grfs().

2016-10-23 Thread Kenneth Graunke
Post-splitting, VGRFs have a maximum size (MAX_VGRF_SIZE). This is required by the register allocator, as we have to create classes for each size of VGRF. We can (and do) allocate virtual registers larger than MAX_VGRF_SIZE, but we must ensure that they are splittable. split_virtual_grfs() asser

[Mesa-dev] [PATCH 1/3] i965: Drop unnecessary switch statement in nir_setup_outputs()

2016-10-23 Thread Kenneth Graunke
TCS and FS are skipped above. CS has no output variables. All remaining cases take the same path. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir

[Mesa-dev] [PATCH 3/3] i965: Don't use nir_assign_var_locations for VS/TES/GS outputs.

2016-10-23 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs.cpp | 13 - src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 46 ++-- src/mesa/drivers/dri/i965/brw_nir.c | 13 +++-- src/mesa/drivers/dri/i965/brw_nir.h | 1 - 4 files changed, 12

[Mesa-dev] [Bug 98243] dEQP mismatched UBO precision qualifiers

2016-10-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98243 Samuel Iglesias changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] Delayed rendering in st/vdpau

2016-10-23 Thread Thomas Hellstrom
Hi, Christian, I remember some time ago you briefly explained what the delayed rendering in st/vdpau is all about, but I can't seem to find that email. Could you point me to a description or briefly detail what it is all about, and also why it doesn't seem to be needed when vdpau uses filters? T

Re: [Mesa-dev] [PATCH v2] egl: add check that eglCreateContext gets a valid config

2016-10-23 Thread Tapani Pälli
On 10/21/2016 05:36 PM, Eric Engestrom wrote: On Thursday, 2016-10-20 19:46:19 +0100, Emil Velikov wrote: On 20 October 2016 at 18:20, Tapani Pälli wrote: Fixes following dEQP test: dEQP-EGL.functional.negative_api.create_context v2: don't break EGL_KHR_no_config_context (Eric Engestrom

Re: [Mesa-dev] [PATCH 8/9] Revert "glsl: allow layout qualifier overrides with ARB_shading_language_420pack"

2016-10-23 Thread Timothy Arceri
Patches 7 and 8 are: Reviewed-by: Timothy Arceri On Sat, 2016-10-22 at 23:09 +0300, Andres Gomez wrote: > This reverts commit aaa69c79cd584db4d9c6ea7794e93d29f3d54572. > > The commit was erroneous because the ast_layout_expression class is > meant to hold a list used for an after check that all

Re: [Mesa-dev] [PATCH 3/9] glsl: ignore all but the rightmost layout qualifier name from the rightmost layout qualifier

2016-10-23 Thread Timothy Arceri
On Sat, 2016-10-22 at 23:09 +0300, Andres Gomez wrote: >  > +   | layout_qualifier BUFFER ';' > ; >   >  layout_in_defaults: > layout_qualifier layout_in_defaults > { > -  $$ = NULL; > +  $$ = $1; >    if (!state->has_420pack_or_es31()) { >   _mesa_glsl_error(&@1,

Re: [Mesa-dev] [PATCH 9/9] glsl: simplified ast_type_qualifier::merge_[in|out]_qualifier API

2016-10-23 Thread Timothy Arceri
I'm not sure we can do this see my last commets to patch 3. On Sat, 2016-10-22 at 23:09 +0300, Andres Gomez wrote: > Since we modified the way in which multiple repetitions of the same > layout-qualifier-name in a single declaration collapse into the > ast_type_qualifier class, we can simplify the

Re: [Mesa-dev] [PATCH 6/9] glsl: push layout-qualifier-name values from variable declarations to global

2016-10-23 Thread Timothy Arceri
On Sat, 2016-10-22 at 23:09 +0300, Andres Gomez wrote: > After the previous modifications in the merging of the > layout-qualifier-name values, we no longer push the final value in a > declaration to the global values. > > This regression happens because we don't call for merging on the > right-mo

Re: [Mesa-dev] [PATCH 5/9] glsl: allow multiple layout-qualifier in single declaration if enhanced layouts

2016-10-23 Thread Timothy Arceri
Again I think this is just because the spec is written against the 4.3 spec. I don't think this extension is intended to enable this feature. On Sat, 2016-10-22 at 23:09 +0300, Andres Gomez wrote: > From the ARB_enhanced_layouts spec: > > "Additions to Chapter 4 "Variables and Types" of the

Re: [Mesa-dev] [PATCH 4/9] glsl: simplified error checking for duplicated layout-qualifiers

2016-10-23 Thread Timothy Arceri
Patches 2 and 4 are: Reviewed-by: Timothy Arceri On Sat, 2016-10-22 at 23:09 +0300, Andres Gomez wrote: > Tthe GLSL parser has been simplified to check for the needed > GL_ARB_shading_language_420pack extension just when merging the > qualifiers in the proper cases. > > Signed-off-by: Andres Go

Re: [Mesa-dev] [PATCH 2/9] glsl: merge layouts into the default one as the last step in interface blocks

2016-10-23 Thread Timothy Arceri
On Sat, 2016-10-22 at 23:09 +0300, Andres Gomez wrote: > Consider this example: > > " #version 150 core >   #extension GL_ARB_shading_language_420pack: require >   #extension GL_ARB_explicit_attrib_location: require > >   layout(location=0) out vec4 o; >   layout(binding=2) la

Re: [Mesa-dev] [PATCH v2 0/9] deal with multiple appearances of the same layout-qualifier-name in a single declaration

2016-10-23 Thread Timothy Arceri
On Sat, 2016-10-22 at 23:09 +0300, Andres Gomez wrote: > In the case of layout-qualifier-names that can appear multiple times > in different declarations of the same shader or, even, the same > program, but that have to consistently hold the same value we are > using the ast_layout_expression class

Re: [Mesa-dev] [PATCH] glsl: Add pthread libs to cache_test

2016-10-23 Thread Timothy Arceri
On Sat, 2016-10-22 at 20:07 -0400, Rhys Kidd wrote: > Fixes the following compile error: > >   CCLD glsl/tests/cache-test > glsl/.libs/libglsl.a(libmesautil_la-mesa-sha1.o): In function > `call_once': > /mesa/src/util/../../include/c11/threads_posix.h:96: undefined > reference to `pthread_once

[Mesa-dev] [Bug 98308] llvmpipe crashes with glxgears (LTO related)

2016-10-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98308 --- Comment #14 from Marc Dietrich --- ok, applying only -fanitize=address in src/gallium/drivers/llvmpipe only, also fixes the problem. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bu

[Mesa-dev] [PATCH 1/4 v2] gallium/util: Add align_calloc

2016-10-23 Thread Axel Davy
Add implementation for align_calloc, which is align_malloc + memset. v2: add if (ptr) before memset. Fix indentation. Signed-off-by: Axel Davy --- src/gallium/auxiliary/util/u_memory.h | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/auxiliary/util/u_memory.h b/src/galli

Re: [Mesa-dev] [PATCH 3/3] i965/gen8: Don't enable alpha test and alpha to coverage if draw bufer zero is integer type

2016-10-23 Thread Kenneth Graunke
On Friday, October 21, 2016 2:18:00 PM PDT Anuj Phogat wrote: > We follow this rule at multiple places in i965 driver. This patch > doesn't fix any testcase. > > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/gen8_blend_state.c | 15 +-- > 1 file changed, 9 insertions(+