Re: [Mesa-dev] [PATCH] intel/blorp: Inline get_vs_entry_size into emit_urb_config

2016-08-29 Thread Pohjolainen, Topi
On Mon, Aug 29, 2016 at 09:00:33AM -0700, Jason Ekstrand wrote: > Topi asked to have the prefix removed because there's nothing gen7 about > it. However, now that everything is in a single file, there is no good > reason to have it split out into a helper function anyway. Let's just put > the con

Re: [Mesa-dev] [PATCH] glsl: Initialize outputs[] array in lower_blend_equation_advanced.

2016-08-29 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Mon, 2016-08-29 at 19:16 -0700, Kenneth Graunke wrote: > Caught by Coverity.  Likely fixes real issues if an output component > is not present. > > CID: 1372278 > Signed-off-by: Kenneth Graunke > --- >  src/compiler/glsl/lower_blend_equation_advanced.cpp | 2 +

Re: [Mesa-dev] [PATCH] mesa: fix format conversion bug in get_tex_rgba_uncompressed()

2016-08-29 Thread Jason Ekstrand
Seems reasonable, Reviewed-by: Jason Ekstrand On Aug 29, 2016 11:43 AM, "Brian Paul" wrote: > We need to set the need_convert flag with each loop iteration, not > just when the rgba pointer is null. > > Bug reported by Markus Müller on mesa-users list. > Fixes new piglit arb_texture_float-get

Re: [Mesa-dev] [PATCH 10/13] nir: add helper for cloning loops

2016-08-29 Thread Jason Ekstrand
I don't think anyone is trying to throw away phi's... I think what Connor is proposing is more a better interface to this cloning operation than anything else. Instead of having a separate list of phi's, you can just pre-populate the remap table before doing the clone. For the first loop iteratio

Re: [Mesa-dev] [PATCH 08/13] nir: add control flow helpers for loop unrolling

2016-08-29 Thread Connor Abbott
On Mon, Aug 29, 2016 at 11:57 PM, Timothy Arceri wrote: > On Mon, 2016-08-29 at 20:42 -0400, Connor Abbott wrote: >> I already noted in patch 12/13 that you can get rid of your use of >> stitch_blocks(). I also don't get why you need a special >> nir_cf_loop_list_extract() here... why >> >> On Mon

Re: [Mesa-dev] [PATCH 12/13] nir: add a loop unrolling pass

2016-08-29 Thread Connor Abbott
On Tue, Aug 30, 2016 at 12:40 AM, Matt Turner wrote: > On Mon, Aug 29, 2016 at 9:06 PM, Timothy Arceri > wrote: >> Can't the phi have more than one source from before the loop? e.g >> >>int i = 0; >>if (somthing) >> i = 1; >>else >> i = 2; >> >>for ( ; i < 5; i++) >>

Re: [Mesa-dev] [PATCH] automake: egl: Android: Add libEGL dependencies

2016-08-29 Thread Tapani Pälli
On 08/30/2016 07:59 AM, Tapani Pälli wrote: On 08/29/2016 07:11 PM, Emil Velikov wrote: On 29 August 2016 at 05:37, Tapani Pälli wrote: On 08/26/2016 03:58 PM, Emil Velikov wrote: On 26 August 2016 at 08:50, Tapani Pälli wrote: Reviewed-by: Tapani Pälli What happened with my sugg

Re: [Mesa-dev] [PATCH] clover: Introduce CLOVER_COMPILER_OPTIONS

2016-08-29 Thread Edward O'Callaghan
On 08/30/2016 09:20 AM, Vedran Miletić wrote: > Options specified via the CLOVER_COMPILER_OPTIONS shell variable are > appended to the compiler options specified by the OpenCL program (if > any). > > Signed-off-by: Vedran Miletić Reviewed-by: Edward O'Callaghan > --- > docs/envvars.html

Re: [Mesa-dev] [PATCH] automake: egl: Android: Add libEGL dependencies

2016-08-29 Thread Tapani Pälli
On 08/29/2016 07:11 PM, Emil Velikov wrote: On 29 August 2016 at 05:37, Tapani Pälli wrote: On 08/26/2016 03:58 PM, Emil Velikov wrote: On 26 August 2016 at 08:50, Tapani Pälli wrote: Reviewed-by: Tapani Pälli What happened with my suggestion about getting things fixed as opposed to

Re: [Mesa-dev] [PATCH 12/13] nir: add a loop unrolling pass

2016-08-29 Thread Matt Turner
On Mon, Aug 29, 2016 at 9:06 PM, Timothy Arceri wrote: > Can't the phi have more than one source from before the loop? e.g > >int i = 0; >if (somthing) > i = 1; >else > i = 2; > >for ( ; i < 5; i++) > do_stuff(i); In fact, no. :) NIR's control flow avoids so-calle

Re: [Mesa-dev] [PATCH 10/13] nir: add helper for cloning loops

2016-08-29 Thread Timothy Arceri
On Mon, 2016-08-29 at 21:06 -0400, Connor Abbott wrote: > So, you've noticed that your method of handling phi's while cloning > doesn't handle phi's that point to other phi's in the same block. > Particularly, something like: > > a = phi(b, ...) > b = phi(a, ...) > > which is supposed to swap a a

Re: [Mesa-dev] [PATCH 12/13] nir: add a loop unrolling pass

2016-08-29 Thread Timothy Arceri
On Tue, 2016-08-30 at 14:16 +1000, Timothy Arceri wrote: > On Tue, 2016-08-30 at 14:06 +1000, Timothy Arceri wrote: > > > > On Mon, 2016-08-29 at 20:34 -0400, Connor Abbott wrote: > > > > > > > > > On Mon, Aug 29, 2016 at 12:59 AM, Timothy Arceri > > > wrote: > > > > > > > > > > > > > > > >

Re: [Mesa-dev] [PATCH 12/13] nir: add a loop unrolling pass

2016-08-29 Thread Timothy Arceri
On Tue, 2016-08-30 at 14:06 +1000, Timothy Arceri wrote: > On Mon, 2016-08-29 at 20:34 -0400, Connor Abbott wrote: > > > > On Mon, Aug 29, 2016 at 12:59 AM, Timothy Arceri > > wrote: > > > > > > > > > --- > > >  src/compiler/Makefile.sources  |   1 + > > >  src/compiler/nir/nir.h   

Re: [Mesa-dev] [PATCH 12/13] nir: add a loop unrolling pass

2016-08-29 Thread Timothy Arceri
On Mon, 2016-08-29 at 20:34 -0400, Connor Abbott wrote: > On Mon, Aug 29, 2016 at 12:59 AM, Timothy Arceri > wrote: > > > > --- > >  src/compiler/Makefile.sources  |   1 + > >  src/compiler/nir/nir.h |   2 + > >  src/compiler/nir/nir_opt_loop_unroll.c | 394 > > +++

Re: [Mesa-dev] [PATCH 08/13] nir: add control flow helpers for loop unrolling

2016-08-29 Thread Timothy Arceri
On Mon, 2016-08-29 at 20:42 -0400, Connor Abbott wrote: > I already noted in patch 12/13 that you can get rid of your use of > stitch_blocks(). I also don't get why you need a special > nir_cf_loop_list_extract() here... why > > On Mon, Aug 29, 2016 at 12:59 AM, Timothy Arceri > wrote: > > > > T

[Mesa-dev] [PATCH] glsl: Initialize outputs[] array in lower_blend_equation_advanced.

2016-08-29 Thread Kenneth Graunke
Caught by Coverity. Likely fixes real issues if an output component is not present. CID: 1372278 Signed-off-by: Kenneth Graunke --- src/compiler/glsl/lower_blend_equation_advanced.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/lower_blend_equation_adva

Re: [Mesa-dev] [PATCH v2] egl: return corresponding offset of EGLImage instead of 0.

2016-08-29 Thread Weng, Chuanbo
Hi Dave and all, This version is based on Dave's review comments. Could you please review it? Thanks! -Original Message- From: Weng, Chuanbo Sent: Friday, August 26, 2016 1:51 AM To: mesa-dev@lists.freedesktop.org; airl...@gmail.com Cc: emil.l.veli...@gmail.com; Weng, Chu

Re: [Mesa-dev] [PATCH 02/13] nir: limit copy propagation inside loops

2016-08-29 Thread Connor Abbott
On Mon, Aug 29, 2016 at 2:30 AM, Timothy Arceri wrote: > On Mon, 2016-08-29 at 01:30 -0400, Connor Abbott wrote: >> On Mon, Aug 29, 2016 at 12:54 AM, Timothy Arceri >> wrote: >> > >> > Don't do copy propagation inside loops until after we try >> > unrolling them. >> > >> > This helps avoid propag

Re: [Mesa-dev] [PATCH 10/13] nir: add helper for cloning loops

2016-08-29 Thread Connor Abbott
So, you've noticed that your method of handling phi's while cloning doesn't handle phi's that point to other phi's in the same block. Particularly, something like: a = phi(b, ...) b = phi(a, ...) which is supposed to swap a and b each iteration. Here's a better strategy which should be simpler th

Re: [Mesa-dev] [PATCH 08/13] nir: add control flow helpers for loop unrolling

2016-08-29 Thread Connor Abbott
I already noted in patch 12/13 that you can get rid of your use of stitch_blocks(). I also don't get why you need a special nir_cf_loop_list_extract() here... why On Mon, Aug 29, 2016 at 12:59 AM, Timothy Arceri wrote: > This makes stitch_blocks() available for use else where, and adds > a new he

Re: [Mesa-dev] [PATCH 12/13] nir: add a loop unrolling pass

2016-08-29 Thread Connor Abbott
On Mon, Aug 29, 2016 at 12:59 AM, Timothy Arceri wrote: > --- > src/compiler/Makefile.sources | 1 + > src/compiler/nir/nir.h | 2 + > src/compiler/nir/nir_opt_loop_unroll.c | 394 > + > 3 files changed, 397 insertions(+) > create mod

Re: [Mesa-dev] [PATCH] aubinator: fix if indentation and add brackets to multiline body

2016-08-29 Thread Kenneth Graunke
On Tuesday, August 30, 2016 9:53:35 AM PDT Timothy Arceri wrote: > Fixes misleading indentation warning in gcc. > > Cc: Kristian Høgsberg Kristensen > Cc: Kenneth Graunke > --- > src/intel/tools/disasm.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/src/intel/

[Mesa-dev] [PATCH] aubinator: fix if indentation and add brackets to multiline body

2016-08-29 Thread Timothy Arceri
Fixes misleading indentation warning in gcc. Cc: Kristian Høgsberg Kristensen Cc: Kenneth Graunke --- src/intel/tools/disasm.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/intel/tools/disasm.c b/src/intel/tools/disasm.c index a1cb191..fcb61c4 100644 --- a/src/i

[Mesa-dev] [PATCH] anv: initialise and increment send_sbc

2016-08-29 Thread Dave Airlie
From: Dave Airlie At least set this to not be uninitialised memory. Signed-off-by: Dave Airlie --- src/intel/vulkan/anv_wsi_x11.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/anv_wsi_x11.c b/src/intel/vulkan/anv_wsi_x11.c index 7c6ef97..7e9ff7d 100644 --- a/src/intel/

[Mesa-dev] [PATCH] clover: Introduce CLOVER_COMPILER_OPTIONS

2016-08-29 Thread Vedran Miletić
Options specified via the CLOVER_COMPILER_OPTIONS shell variable are appended to the compiler options specified by the OpenCL program (if any). Signed-off-by: Vedran Miletić --- docs/envvars.html | 2 ++ src/gallium/state_trackers/clover/llvm/invocation.cpp |

Re: [Mesa-dev] [PATCH 1/2] util: import the slab allocator from gallium

2016-08-29 Thread Marek Olšák
On Mon, Aug 29, 2016 at 10:40 PM, Dave Airlie wrote: >> >> There are also some cosmetic changes. > > Did I miss 0/2? is there some future use for this in mesa? > > I assume there is, just wanting more info :) It was for an experiment that turned out to be a disaster. There is no other use. Marek

[Mesa-dev] [PATCH 1/2] i965: Fix missing dirty bits related to is_drawing_points/lines.

2016-08-29 Thread Kenneth Graunke
calculate_attr_overrides() uses is_drawing_points(), which depends on tessellation and geometry program state. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen6_clip_state.c | 4 src/mesa/drivers/dri/i965/gen7_sf_state.c | 13 ++--- src/mesa/drivers/dri/i965/gen8_

[Mesa-dev] [PATCH 2/2] i965: Use gs_prog_data in is_drawing_points/lines().

2016-08-29 Thread Kenneth Graunke
State upload code should use prog_data rather than poking at core Mesa shader data structures wherever possible. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen6_clip_state.c | 16 src/mesa/drivers/dri/i965/gen6_sf_state.c | 8 +--- src/mesa/drivers/dri/i

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: fix format conversion bug in get_tex_rgba_uncompressed()

2016-08-29 Thread Anuj Phogat
On Mon, Aug 29, 2016 at 11:44 AM, Brian Paul wrote: > > We need to set the need_convert flag with each loop iteration, not > just when the rgba pointer is null. > > Bug reported by Markus Müller on mesa-users list. > Fixes new piglit arb_texture_float-get-tex3d test. > > Cc: > --- > src/mesa/ma

Re: [Mesa-dev] [PATCH mesa] Introduce .editorconfig

2016-08-29 Thread Serge Martin
On Monday 29 August 2016 22:30:58 Eric Engestrom wrote: > A few weeks ago, Jose Fonseca suggested [0] we use .editorconfig files > to try and enforce the formatting of the code, to which Michel Dänzer > suggested [1] we start by importing the existing .dir-locals.el > settings. The first draft was

[Mesa-dev] [PATCH mesa] Introduce .editorconfig

2016-08-29 Thread Eric Engestrom
A few weeks ago, Jose Fonseca suggested [0] we use .editorconfig files to try and enforce the formatting of the code, to which Michel Dänzer suggested [1] we start by importing the existing .dir-locals.el settings. The first draft was discussed in the RFC [2]. These .editorconfig are a first step,

Re: [Mesa-dev] [PATCH 1/2] util: import the slab allocator from gallium

2016-08-29 Thread Dave Airlie
> > There are also some cosmetic changes. Did I miss 0/2? is there some future use for this in mesa? I assume there is, just wanting more info :) Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listi

Re: [Mesa-dev] [PATCH 07/20] radeonsi: fix cubemaps viewed as 2D

2016-08-29 Thread Dave Airlie
On 30 August 2016 at 01:28, Marek Olšák wrote: > From: Marek Olšák > > This fixes: GL43-CTS.texture_view.view_sampling Reviewed-by: Dave Airlie > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/gallium/drivers/radeonsi/si_state.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --g

Re: [Mesa-dev] [PATCH 10/20] radeonsi: fix Gather4 with integer formats

2016-08-29 Thread Dave Airlie
On 30 August 2016 at 01:28, Marek Olšák wrote: > From: Marek Olšák > > The closed compiler does the same thing. > > This fixes: GL45-CTS.texture_gather.*-int-* (18 tests) Also reused in radv, and works there to fix a bunch of gather int tests. Reviewed-by: Dave Airlie > --- > src/gallium/driv

Re: [Mesa-dev] [PATCH 09/20] radeonsi: fix a crash in imageSize for cubemap arrays

2016-08-29 Thread Dave Airlie
On 30 August 2016 at 01:28, Marek Olšák wrote: > From: Marek Olšák > > Sometimes it was f32, other times it was i32. Now it's always i32. I think this is pretty much what radv does in the same situation. Reviewed-by: Dave Airlie > > This fixes: > GL45-CTS.texture_cube_map_array.image_texture_s

Re: [Mesa-dev] [PATCH 19/20] gallium/radeon: set VPORT_ZMIN/MAX registers correctly

2016-08-29 Thread Bas Nieuwenhuizen
On Mon, Aug 29, 2016 at 5:28 PM, Marek Olšák wrote: > From: Marek Olšák > > Calculate depth ranges from viewport states and > pipe_rasterizer_state::clip_halfz. > > The evergreend.h change is required to silence a warning. > > This fixes this recently updated piglit: arb_depth_clamp/depth-clamp-r

Re: [Mesa-dev] [PATCH] spirv: replace assert with unreachable

2016-08-29 Thread Jason Ekstrand
On Aug 29, 2016 12:06 PM, "Matt Turner" wrote: > > On Sun, Aug 28, 2016 at 7:13 PM, Timothy Arceri > wrote: > > Fixes uninitialised warning for coord_components. > > --- > > src/compiler/spirv/spirv_to_nir.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/compi

Re: [Mesa-dev] [PATCH] clover: probe pipe for the value of CL_DEVICE_ADDRESS_BITS

2016-08-29 Thread Vedran Miletić
On 08/29/2016 09:30 PM, Jan Vesely wrote: On Mon, 2016-08-29 at 20:13 +0200, Vedran Miletić wrote: Clover presently reports 32 as CL_DEVICE_ADDRESS_BITS, which is not correct for AMD SI and newer chip generations. This patch introduces the PIPE_COMPUTE_CAP_ADDRESS_BITS pipe capability queried by

Re: [Mesa-dev] [PATCH] clover: probe pipe for the value of CL_DEVICE_ADDRESS_BITS

2016-08-29 Thread Jan Vesely
On Mon, 2016-08-29 at 20:13 +0200, Vedran Miletić wrote: > Clover presently reports 32 as CL_DEVICE_ADDRESS_BITS, which is not > correct for AMD SI and newer chip generations. This patch introduces > the PIPE_COMPUTE_CAP_ADDRESS_BITS pipe capability queried by Clover > to r600 pipe and sets the val

Re: [Mesa-dev] [PATCH 11/20] radeonsi: fix texture format reinterpretation with DCC

2016-08-29 Thread Marek Olšák
On Mon, Aug 29, 2016 at 8:29 PM, Bas Nieuwenhuizen wrote: > Hi Marek, > > I don't think this accounts for the fast clear bits? unorm->uint and > snorm<->sint should have compatible clear values, but otherwise we may > need to eliminate the fast clears. That's a good point. I propose that this pa

Re: [Mesa-dev] [PATCH] spirv: replace assert with unreachable

2016-08-29 Thread Matt Turner
On Sun, Aug 28, 2016 at 7:13 PM, Timothy Arceri wrote: > Fixes uninitialised warning for coord_components. > --- > src/compiler/spirv/spirv_to_nir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compiler/spirv/spirv_to_nir.c > b/src/compiler/spirv/spirv_to_nir.c >

Re: [Mesa-dev] [PATCH 4/7] glsl: add core plumbing for GL_ANDROID_extension_pack_es31a

2016-08-29 Thread Ilia Mirkin
On Mon, Aug 29, 2016 at 2:45 PM, Matt Turner wrote: > On Sun, Aug 28, 2016 at 7:10 PM, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> src/compiler/glsl/glsl_parser_extras.cpp | 57 >> +++- >> src/compiler/glsl/glsl_parser_extras.h | 2 ++ >> src/mesa/

Re: [Mesa-dev] [PATCH 4/7] glsl: add core plumbing for GL_ANDROID_extension_pack_es31a

2016-08-29 Thread Matt Turner
On Sun, Aug 28, 2016 at 7:10 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/compiler/glsl/glsl_parser_extras.cpp | 57 > +++- > src/compiler/glsl/glsl_parser_extras.h | 2 ++ > src/mesa/main/extensions_table.h | 2 ++ > src/mesa/main/mtyp

[Mesa-dev] [PATCH] mesa: fix format conversion bug in get_tex_rgba_uncompressed()

2016-08-29 Thread Brian Paul
We need to set the need_convert flag with each loop iteration, not just when the rgba pointer is null. Bug reported by Markus Müller on mesa-users list. Fixes new piglit arb_texture_float-get-tex3d test. Cc: --- src/mesa/main/texgetimage.c | 14 -- 1 file changed, 8 insertions(+),

Re: [Mesa-dev] [PATCH 11/20] radeonsi: fix texture format reinterpretation with DCC

2016-08-29 Thread Bas Nieuwenhuizen
Hi Marek, I don't think this accounts for the fast clear bits? unorm->uint and snorm<->sint should have compatible clear values, but otherwise we may need to eliminate the fast clears. Yours sincerely, Bas Nieuwenhuizen On Mon, Aug 29, 2016 at 5:28 PM, Marek Olšák wrote: > From: Marek Olšák >

Re: [Mesa-dev] [PATCH 6/7] mesa: add a GLES3.2 enums section, and expose new MS line width params

2016-08-29 Thread Ilia Mirkin
On Sun, Aug 28, 2016 at 10:10 PM, Ilia Mirkin wrote: > This also exposes them for ARB_ES3_2_compatibility. > > Signed-off-by: Ilia Mirkin > --- > src/mesa/main/context.h | 10 ++ > src/mesa/main/get.c | 26 -- > src/mesa/main/get_hash_g

Re: [Mesa-dev] [PATCH v2 1/2] gallium: add cap to export device pointer size

2016-08-29 Thread Ilia Mirkin
On Mon, Aug 29, 2016 at 2:19 PM, Jan Vesely wrote: > On Mon, 2016-08-29 at 14:47 +0200, Marek Olšák wrote: >> On Sun, Aug 28, 2016 at 7:57 PM, Jan Vesely >> wrote: >> > >> > v2: document the new cap >> > >> > Signed-off-by: Jan Vesely >> > --- >> > src/gallium/docs/source/screen.rst

Re: [Mesa-dev] [PATCH v2 1/2] gallium: add cap to export device pointer size

2016-08-29 Thread Jan Vesely
On Mon, 2016-08-29 at 14:47 +0200, Marek Olšák wrote: > On Sun, Aug 28, 2016 at 7:57 PM, Jan Vesely > wrote: > > > > v2: document the new cap > > > > Signed-off-by: Jan Vesely > > --- > >  src/gallium/docs/source/screen.rst | 1 + > >  src/gallium/drivers/ilo/ilo_screen.c   |

Re: [Mesa-dev] [PATCH 1/3] noop: simplify some functions

2016-08-29 Thread Marek Olšák
On Mon, Aug 29, 2016 at 7:23 PM, Emil Velikov wrote: > On 29 August 2016 at 16:29, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/gallium/drivers/noop/noop_state.c | 56 >> +-- >> 1 file changed, 7 insertions(+), 49 deletions(-) >> >> diff --git a/src/

Re: [Mesa-dev] [PATCH] i915g: Fix typo in i915_translate_instruction()

2016-08-29 Thread Eric Anholt
Echelon9 writes: > From: Rhys Kidd > > Noticed this error in a debug message whilst reviewing > https://bugs.freedesktop.org/show_bug.cgi?id=97477 > > This patch doesn't go towards fixing that bug, but at > least may clarify future debug output. > > Signed-off-by: Rhys Kidd Reviewed and pushed

Re: [Mesa-dev] [PATCH 0/2] r600g: Pair of small code clean ups with TGSI

2016-08-29 Thread Eric Anholt
Rhys Kidd writes: > Having run Mesa through Clang on Eric Anholt's Travis harness, these small > code clean ups improve readability of TGSI code in r600g and may avoid > future problems. > > Series also can be found at: > https://github.com/Echelon9/mesa/tree/fix/r600g-cleanup-tgsi-opcodes > > I

[Mesa-dev] [PATCH] clover: probe pipe for the value of CL_DEVICE_ADDRESS_BITS

2016-08-29 Thread Vedran Miletić
Clover presently reports 32 as CL_DEVICE_ADDRESS_BITS, which is not correct for AMD SI and newer chip generations. This patch introduces the PIPE_COMPUTE_CAP_ADDRESS_BITS pipe capability queried by Clover to r600 pipe and sets the value to 32 for AMD EG/NI chips and 64 for SI and newer (chips older

Re: [Mesa-dev] [PATCH] svga: s/unsigned/enum pipe_shader_type/

2016-08-29 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Monday, August 29, 2016 9:16:09 AM To: mesa-dev@lists.freedesktop.org Cc: Neha Bhende; Charmaine Lee Subject: [PATCH] svga: s/unsigned/enum pipe_shader_type/ --- src/gallium/drivers/svga/svga_draw.c

Re: [Mesa-dev] [PATCH 1/3] noop: simplify some functions

2016-08-29 Thread Emil Velikov
On 29 August 2016 at 16:29, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/noop/noop_state.c | 56 > +-- > 1 file changed, 7 insertions(+), 49 deletions(-) > > diff --git a/src/gallium/drivers/noop/noop_state.c > b/src/gallium/drivers/noop/

[Mesa-dev] [PATCH] svga: s/unsigned/enum pipe_shader_type/

2016-08-29 Thread Brian Paul
--- src/gallium/drivers/svga/svga_draw.c| 4 ++-- src/gallium/drivers/svga/svga_pipe_sampler.c| 2 +- src/gallium/drivers/svga/svga_sampler_view.h| 2 +- src/gallium/drivers/svga/svga_shader.c | 3 ++- src/gallium/drivers/svga/svga_shader.h | 5 +++-- src

Re: [Mesa-dev] [PATCH v2] configure.ac: add llvm inteljitevents component if enabled

2016-08-29 Thread Emil Velikov
On 26 August 2016 at 19:24, Tim Rowley wrote: > Needed to successfully link llvmpipe or swr when using shared llvm libs > built with inteljitevents enabled. > > v2: Make adding inteljitevents component global rather than just > llvmpipe/swr, since libgallium will have a symbol dependency. Cc: Rev

Re: [Mesa-dev] [PATCH] automake: egl: Android: Add libEGL dependencies

2016-08-29 Thread Emil Velikov
On 29 August 2016 at 05:37, Tapani Pälli wrote: > > > On 08/26/2016 03:58 PM, Emil Velikov wrote: >> >> On 26 August 2016 at 08:50, Tapani Pälli wrote: >>> >>> Reviewed-by: Tapani Pälli >>> >> What happened with my suggestion about getting things fixed as opposed >> to adding tape over things, n

[Mesa-dev] [PATCH] intel/blorp: Inline get_vs_entry_size into emit_urb_config

2016-08-29 Thread Jason Ekstrand
Topi asked to have the prefix removed because there's nothing gen7 about it. However, now that everything is in a single file, there is no good reason to have it split out into a helper function anyway. Let's just put the contents in emit_urb_config and call it a day. --- src/intel/blorp/blorp_g

Re: [Mesa-dev] [PATCH 06/31] i965/blorp: Use gen6_upload_urb

2016-08-29 Thread Jason Ekstrand
On Sun, Aug 28, 2016 at 10:29 PM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Aug 19, 2016 at 09:55:43AM -0700, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/genX_blorp_exec.c | 6 ++ > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/s

Re: [Mesa-dev] [PATCH 2/3] noop: set missing functions

2016-08-29 Thread Ilia Mirkin
On Mon, Aug 29, 2016 at 11:49 AM, Marek Olšák wrote: > On Mon, Aug 29, 2016 at 5:43 PM, Ilia Mirkin wrote: >> On Mon, Aug 29, 2016 at 11:29 AM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> --- >>> src/gallium/drivers/noop/noop_pipe.c | 51 >>> +++ >>> src/

Re: [Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

2016-08-29 Thread Ilia Mirkin
On Fri, Aug 26, 2016 at 7:58 AM, Kai Wasserbäch wrote: > diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_state.c > b/src/gallium/drivers/nouveau/nvc0/nvc0_state.c > index b9ac9f4..48aaa46 100644 > --- a/src/gallium/drivers/nouveau/nvc0/nvc0_state.c > +++ b/src/gallium/drivers/nouveau/nvc0/nvc0

Re: [Mesa-dev] [PATCH] st/mesa: expose OES_geometry_shader and OES_texture_cube_map_array

2016-08-29 Thread Marek Olšák
On Mon, Aug 29, 2016 at 5:41 PM, Ilia Mirkin wrote: > On Mon, Aug 29, 2016 at 11:35 AM, Marek Olšák wrote: >> On Sat, Aug 27, 2016 at 11:53 PM, Ilia Mirkin wrote: >>> Signed-off-by: Ilia Mirkin >>> --- >>> docs/features.txt | 4 ++-- >>> docs/relnotes/12.1.0.html

Re: [Mesa-dev] [PATCH 2/3] noop: set missing functions

2016-08-29 Thread Marek Olšák
On Mon, Aug 29, 2016 at 5:43 PM, Ilia Mirkin wrote: > On Mon, Aug 29, 2016 at 11:29 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/gallium/drivers/noop/noop_pipe.c | 51 >> +++ >> src/gallium/drivers/noop/noop_state.c | 24 + >> 2

Re: [Mesa-dev] [PATCH] st/mesa: expose OES_geometry_shader and OES_texture_cube_map_array

2016-08-29 Thread Ilia Mirkin
On Mon, Aug 29, 2016 at 11:35 AM, Marek Olšák wrote: > On Sat, Aug 27, 2016 at 11:53 PM, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> docs/features.txt | 4 ++-- >> docs/relnotes/12.1.0.html | 4 ++-- >> src/mesa/state_tracker/st_extensions.c |

Re: [Mesa-dev] [PATCH 2/3] noop: set missing functions

2016-08-29 Thread Ilia Mirkin
On Mon, Aug 29, 2016 at 11:29 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/noop/noop_pipe.c | 51 > +++ > src/gallium/drivers/noop/noop_state.c | 24 + > 2 files changed, 75 insertions(+) > > diff --git a/src/gallium/d

[Mesa-dev] [PATCH 13/20] gallium/radeon: rename the num-cs-flushes query to num-ctx-flushes

2016-08-29 Thread Marek Olšák
From: Marek Olšák num-cs-flushes will mean compute shader flushes --- src/gallium/drivers/radeon/r600_query.c | 8 src/gallium/drivers/radeon/r600_query.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/gallium/driver

[Mesa-dev] [PATCH 05/20] radeonsi: return correct eviction stats for NVX_gpu_memory_info

2016-08-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c index b1da22f..32486c8 100644 --- a/src/gallium/drivers/

[Mesa-dev] [Bug 97250] Mesa/Clover: openCV library bugs on CL_MEM_USE_HOST_PTR

2016-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97250 Vedran Miletić changed: What|Removed |Added CC||ved...@miletic.net -- You are receivin

[Mesa-dev] [PATCH 03/20] gallium/radeon: use the current ctx for CMASK elimination in resource_get_handle

2016-08-29 Thread Marek Olšák
From: Marek Olšák For coherency with the current context. --- src/gallium/drivers/radeon/r600_texture.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index e7be768..912

[Mesa-dev] [PATCH 2/2] gallium: switch drivers to the slab allocator in src/util

2016-08-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/Makefile.sources | 2 - src/gallium/auxiliary/util/u_slab.c| 171 - src/gallium/auxiliary/util/u_slab.h| 96 src/gallium/drivers/freedreno/freedreno_context.c | 6 +- sr

Re: [Mesa-dev] [PATCH] st/mesa: expose OES_geometry_shader and OES_texture_cube_map_array

2016-08-29 Thread Marek Olšák
On Sat, Aug 27, 2016 at 11:53 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > docs/features.txt | 4 ++-- > docs/relnotes/12.1.0.html | 4 ++-- > src/mesa/state_tracker/st_extensions.c | 14 ++ > 3 files changed, 18 insertions(+), 4 del

[Mesa-dev] [PATCH 3/3] noop: implement resource_get_handle

2016-08-29 Thread Marek Olšák
From: Marek Olšák X+DRI3 locks up if the returned handle is invalid. --- src/gallium/drivers/noop/noop_pipe.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/noop/noop_pipe.c b/src/gallium/drivers/noop/noop_pipe.c index 25e0c1f..3013019

[Mesa-dev] [PATCH 2/3] noop: set missing functions

2016-08-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/noop/noop_pipe.c | 51 +++ src/gallium/drivers/noop/noop_state.c | 24 + 2 files changed, 75 insertions(+) diff --git a/src/gallium/drivers/noop/noop_pipe.c b/src/gallium/drivers/noop/noop_pipe.c index b

[Mesa-dev] [PATCH 1/3] noop: simplify some functions

2016-08-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/noop/noop_state.c | 56 +-- 1 file changed, 7 insertions(+), 49 deletions(-) diff --git a/src/gallium/drivers/noop/noop_state.c b/src/gallium/drivers/noop/noop_state.c index 0c0ad9f..01538bfe27 100644 --- a/src/gallium/d

[Mesa-dev] [PATCH 15/20] radeonsi: don't emit CS_PARTIAL_FLUSH if compute is not used

2016-08-29 Thread Marek Olšák
From: Marek Olšák for less noise in the HUD --- src/gallium/drivers/radeonsi/si_compute.c| 1 + src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_state_draw.c | 4 +++- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeons

[Mesa-dev] [PATCH 20/20] gallium/radeon: remove VPORT_ZMIN/ZMAX from init config states

2016-08-29 Thread Marek Olšák
From: Marek Olšák It's part of the viewport state now. --- src/gallium/drivers/r600/evergreen_state.c | 14 +- src/gallium/drivers/r600/r600_state.c | 6 -- src/gallium/drivers/radeonsi/si_state.c| 6 -- 3 files changed, 1 insertion(+), 25 deletions(-) diff --git

[Mesa-dev] [PATCH 1/2] util: import the slab allocator from gallium

2016-08-29 Thread Marek Olšák
From: Marek Olšák There are also some cosmetic changes. --- src/util/Makefile.sources | 2 + src/util/slab.c | 180 ++ src/util/slab.h | 62 3 files changed, 244 insertions(+) create mode 100644 src/util/slab.c

[Mesa-dev] [PATCH 19/20] gallium/radeon: set VPORT_ZMIN/MAX registers correctly

2016-08-29 Thread Marek Olšák
From: Marek Olšák Calculate depth ranges from viewport states and pipe_rasterizer_state::clip_halfz. The evergreend.h change is required to silence a warning. This fixes this recently updated piglit: arb_depth_clamp/depth-clamp-range --- src/gallium/drivers/r600/evergreen_state.c| 1 + sr

[Mesa-dev] [PATCH 10/20] radeonsi: fix Gather4 with integer formats

2016-08-29 Thread Marek Olšák
From: Marek Olšák The closed compiler does the same thing. This fixes: GL45-CTS.texture_gather.*-int-* (18 tests) --- src/gallium/drivers/radeonsi/si_shader.c | 99 +++- 1 file changed, 96 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_sh

[Mesa-dev] [PATCH 18/20] gallium/radeon: unify viewport emission code

2016-08-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_viewport.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_viewport.c b/src/gallium/drivers/radeon/r600_viewport.c index 5c998c8..2d68783 100644 --- a/src/g

[Mesa-dev] [PATCH 06/20] radeonsi: always use the same function signature for llvm.SI.export

2016-08-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index a5b566e..2863faa 100644 --- a/src/gallium/drivers/radeonsi/si_shad

[Mesa-dev] [PATCH 14/20] radeonsi: add HUD queries for counting VS/PS/CS partial flushes

2016-08-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 3 +++ src/gallium/drivers/radeon/r600_query.c | 21 + src/gallium/drivers/radeon/r600_query.h | 3 +++ src/gallium/drivers/radeonsi/si_state_draw.c | 8 4 files changed, 35 inserti

[Mesa-dev] [PATCH 16/20] radeonsi: fix variable naming in si_emit_cache_flush

2016-08-29 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_draw.c | 62 ++-- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index ddcb904..0a91291 100644 --- a/s

[Mesa-dev] [PATCH 17/20] radeonsi: also do VS_PARTIAL_FLUSH before updating VGT ring pointers

2016-08-29 Thread Marek Olšák
From: Marek Olšák ported from Vulkan --- src/gallium/drivers/radeonsi/si_state_shaders.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c index 394afaa..b4f19fe 100644 --- a/src/gallium/dr

[Mesa-dev] [PATCH 11/20] radeonsi: fix texture format reinterpretation with DCC

2016-08-29 Thread Marek Olšák
From: Marek Olšák DCC is limited in how texture formats can be reinterpreted using texture views. If we get a view format that is incompatible with the initial texture format with respect to DCC, disable DCC. There is a new piglit which tests all format combinations. What works and what doesn't

[Mesa-dev] [PATCH 08/20] radeonsi: fix gl_PatchVerticesIn for tessellation evaluation shader

2016-08-29 Thread Marek Olšák
From: Marek Olšák This fixes: GL45-CTS.tessellation_shader.tessellation_control_to_tessellation_evaluation .gl_PatchVerticesIn --- src/gallium/drivers/radeonsi/si_shader.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/ga

[Mesa-dev] [PATCH 04/20] gallium/radeon: also eliminate DCC fast clear in resource_get_handle

2016-08-29 Thread Marek Olšák
From: Marek Olšák just do what the comment says --- src/gallium/drivers/radeon/r600_texture.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index 912d123..7bdceb1 100644 --- a/src/ga

[Mesa-dev] [PATCH 02/20] gallium/radeon: use the current ctx for DCC decompression in resource_get_handle

2016-08-29 Thread Marek Olšák
From: Marek Olšák For coherency with the current context. --- src/gallium/drivers/radeon/r600_texture.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index fb3068a..e7be768 100644 -

[Mesa-dev] [PATCH 09/20] radeonsi: fix a crash in imageSize for cubemap arrays

2016-08-29 Thread Marek Olšák
From: Marek Olšák Sometimes it was f32, other times it was i32. Now it's always i32. This fixes: GL45-CTS.texture_cube_map_array.image_texture_size.texture_size_compute_sh --- src/gallium/drivers/radeonsi/si_shader.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/gal

[Mesa-dev] [PATCH 01/20] gallium/radeon: derive buffer placement and flags only at initialization

2016-08-29 Thread Marek Olšák
From: Marek Olšák Invalidated buffers don't have to go through it. Split r600_init_resource into r600_init_resource_fields and r600_alloc_resource. --- src/gallium/drivers/r600/r600_state_common.c| 5 +- src/gallium/drivers/radeon/r600_buffer_common.c | 84 ++--- src/ga

[Mesa-dev] [PATCH 12/20] radeonsi: fix a badly implemented GS bug workaround

2016-08-29 Thread Marek Olšák
From: Marek Olšák Limit it to geometry shaders and Hawaii. --- src/gallium/drivers/radeonsi/si_state_draw.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c inde

[Mesa-dev] [PATCH 07/20] radeonsi: fix cubemaps viewed as 2D

2016-08-29 Thread Marek Olšák
From: Marek Olšák This fixes: GL43-CTS.texture_view.view_sampling Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeonsi/si_state.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index

[Mesa-dev] [PATCH 00/20] Plenty of RadeonSI fixes

2016-08-29 Thread Marek Olšák
Hi, This series contains mostly fixes, i.e. for DCC, cubemaps, tessellation, texture views, Gather4, viewport depth range, etc. There are also some new HUD queries. Please review. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https:/

Re: [Mesa-dev] [PATCH] android: fix build issues with genxml, isl

2016-08-29 Thread Jason Ekstrand
On Sun, Aug 28, 2016 at 6:33 PM, Mauro Rossi wrote: > > While you're at it, I've got another build-breaking branch here: > > > > https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/blorp-vulkan > > > > It's almost reviewed so I'll be pushing soon. If you could provide a > > squash-in, that wo

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2016-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Vedran Miletić changed: What|Removed |Added Depends on||91969 Referenced Bugs: https://bugs.f

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2016-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Vedran Miletić changed: What|Removed |Added Depends on||97340, 95308 Referenced Bugs: https:/

Re: [Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

2016-08-29 Thread Brian Paul
On 08/27/2016 11:18 AM, Jan Vesely wrote: On Fri, 2016-08-26 at 17:25 +0100, Eric Engestrom wrote: On Fri, Aug 26, 2016 at 04:21:14PM +0200, Kai Wasserbäch wrote: Hey Eric, Eric Engestrom wrote on 26.08.2016 15:49: On Fri, Aug 26, 2016 at 03:14:57PM +0200, Kai Wasserbäch wrote: Brian Paul

[Mesa-dev] [Bug 97260] [bisected] R9 290 low performance in Linux 4.7

2016-08-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97260 Vedran Miletić changed: What|Removed |Added CC||ved...@miletic.net -- You are receivin

Re: [Mesa-dev] [PATCH] radeonsi: add support for cull distances. (v1.1)

2016-08-29 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Aug 29, 2016 at 4:16 AM, Dave Airlie wrote: > From: Dave Airlie > > This should be all that is required for cull distances to work > on radeonsi. > > v1.1: whitespace cleanup, add docs fix clipdist_mask usage. > > Signed-off-by: Dave Airlie > --- > docs

Re: [Mesa-dev] [PATCH 0/2] r600g: Pair of small code clean ups with TGSI

2016-08-29 Thread James Harvey
Hi Rhys, I ran piglit on my Evergreen HD5850 with your patches. No regressions here. Tested-by: James Harvey Thanks, James On 08/27/2016 09:05 AM, Rhys Kidd wrote: Having run Mesa through Clang on Eric Anholt's Travis harness, these small code clean ups improve readability of TGSI code in

  1   2   >