Re: [Mesa-dev] [PATCH] egl/dri2: dri2_initialize: Do not reference-count TestOnly display

2016-08-21 Thread Nicolas Boichat
Hi Emil, On Tue, Aug 16, 2016 at 1:17 AM, Emil Velikov wrote: > Hi Nicolas, > > On 4 August 2016 at 02:51, Nicolas Boichat wrote: >> On Thu, Aug 4, 2016 at 9:38 AM, Michel Dänzer wrote: >>> On 04.08.2016 09:53, Nicolas Boichat wrote: On Thu, Aug 4, 2016 at 12:22 AM, Martin Peres wrot

[Mesa-dev] [Bug 97429] Per-pixel fog isn't done

2016-08-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97429 Jason Ekstrand changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH mesa] st/va: add missing mutex_unlock

2016-08-21 Thread Eric Engestrom
Fixes: c59628d11b134fc01638 ("st/va: enable dual instances encode by sync surface") Signed-off-by: Eric Engestrom --- src/gallium/state_trackers/va/surface.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/surface.c b/src/gallium/state_tracke

Re: [Mesa-dev] [PATCH 1/2] st/va: enable dual instances encode by sync surface

2016-08-21 Thread Andy Furniss
Andy Furniss wrote: Boyuan Zhang wrote: This patch improves the performance of Vaapi Encode by enabling dual instances encoding. flush function is not called after each end_frame call. radeon/vce will do flush whenever 2 frames are submitted for encoding. Implement sync surface function to flush

Re: [Mesa-dev] [PATCH 1/2] st/va: enable dual instances encode by sync surface

2016-08-21 Thread Andy Furniss
Boyuan Zhang wrote: This patch improves the performance of Vaapi Encode by enabling dual instances encoding. flush function is not called after each end_frame call. radeon/vce will do flush whenever 2 frames are submitted for encoding. Implement sync surface function to flush only if the frame

Re: [Mesa-dev] [PATCH] nir: avoid segfault when ssa src not found

2016-08-21 Thread Jason Ekstrand
Seems reasonable. R-B On Aug 21, 2016 1:32 AM, "Timothy Arceri" wrote: > Without this the following line will segfault and we don't get to > see the results of the validate_assert() above. > --- > src/compiler/nir/nir_validate.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/c

[Mesa-dev] [Bug 97429] Per-pixel fog isn't done

2016-08-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97429 Bug ID: 97429 Summary: Per-pixel fog isn't done Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium

[Mesa-dev] [PATCH] nir: avoid segfault when ssa src not found

2016-08-21 Thread Timothy Arceri
Without this the following line will segfault and we don't get to see the results of the validate_assert() above. --- src/compiler/nir/nir_validate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/nir/nir_validate.c b/src/compiler/nir/nir_validate.c index d9801b5..9d1566c 1006

Re: [Mesa-dev] [RFC PATCH] dri: add a way to request that modes have matching color/zs depths

2016-08-21 Thread Marek Olšák
On Sat, Aug 20, 2016 at 10:13 PM, Ilia Mirkin wrote: > Some GPUs, notably nv3x/nv4x can't render to mismatched color/zs > framebuffer depths. Fallbacks can be done by the driver, with shadow > surfaces, but no reason to encourage applications to select non-matching > glx visuals. > > Signed-off-by

[Mesa-dev] [Bug 97427] clear-repeat demo doesn't change update region on window resize

2016-08-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97427 Bug ID: 97427 Summary: clear-repeat demo doesn't change update region on window resize Product: Mesa Version: git Hardware: Other OS: All Status

[Mesa-dev] [Bug 97426] glScissor gives vertically inverted result

2016-08-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97426 Bug ID: 97426 Summary: glScissor gives vertically inverted result Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [PATCH v2 10/16] mesa: Add draw time validation for advanced blending modes.

2016-08-21 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/mesa/main/context.c | 51 + 1 file changed, 51 insertions(+) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index 4ff0979..e63d8a6 100644 --- a/src/mesa/main/context.c +++ b/src/mesa/main/conte

[Mesa-dev] [PATCH v2 13/16] i965: Disable hardware blending if advanced blending is in use.

2016-08-21 Thread Kenneth Graunke
We'll do blending in the shader in this case, so just disable the hardware blending. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_cc.c | 2 +- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 4 ++-- src/mesa/drivers/dri/i965/gen6_cc.c | 3 ++- sr

[Mesa-dev] [PATCH v2 12/16] glsl: Add a lowering pass to handle advanced blending modes.

2016-08-21 Thread Kenneth Graunke
Many GPUs cannot handle GL_KHR_blend_equation_advanced natively, and need to emulate it in the pixel shader. This lowering pass implements all the necessary math for advanced blending. It fetches the existing framebuffer value using the MESA_shader_framebuffer_fetch built-in variables, and the pr

[Mesa-dev] [PATCH v2 15/16] mesa: Implement GL_KHR_blend_equation_advanced_coherent.

2016-08-21 Thread Kenneth Graunke
This adds the extension enable (so drivers can advertise it) and the extra boolean state flag, GL_BLEND_ADVANCED_COHERENT_KHR, which can be set to request coherent blending. Signed-off-by: Kenneth Graunke Reviewed-by: Francisco Jerez --- src/mesa/main/blend.c| 2 ++ src/mesa/main/e

[Mesa-dev] [PATCH v2 04/16] glsl: add basic KHR_blend_equation_advanced infrastructure

2016-08-21 Thread Kenneth Graunke
From: Ilia Mirkin Signed-off-by: Ilia Mirkin Reviewed-by: Kenneth Graunke Reviewed-by: Francisco Jerez --- src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/compiler/glsl/glsl_parser_extras.cpp

[Mesa-dev] [PATCH v2 16/16] i965: Implement GL_KHR_blend_equation_advanced_coherent on Gen9+.

2016-08-21 Thread Kenneth Graunke
We always use a coherent read, and ignore the "opt out" enable flag. Signed-off-by: Kenneth Graunke Reviewed-by: Francisco Jerez --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/

[Mesa-dev] [PATCH v2 14/16] i965: Enable GL_KHR_blend_equation_advanced on G45 and later.

2016-08-21 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke Reviewed-by: Francisco Jerez --- src/mesa/drivers/dri/i965/brw_link.cpp | 2 ++ src/mesa/drivers/dri/i965/intel_extensions.c | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_link.cpp b/src/mesa/drivers/dri

[Mesa-dev] [PATCH v2 07/16] mesa: Allow advanced blending enums in glBlendEquation[i].

2016-08-21 Thread Kenneth Graunke
Don't allow them in glBlendEquationSeparate[i], though, as required by the spec. Signed-off-by: Kenneth Graunke Reviewed-by: Francisco Jerez --- src/mesa/main/blend.c | 64 +++ 1 file changed, 54 insertions(+), 10 deletions(-) diff --git a/src/me

[Mesa-dev] [PATCH v2 11/16] compiler: Add a new STATE_VAR_ADVANCED_BLENDING_MODE built-in uniform.

2016-08-21 Thread Kenneth Graunke
This will be used for emulating GL_KHR_advanced_blend_equation features in shader code. We'll pass in the blending mode that's in use, and use that in (effectively) a switch statement in the shader. v2: Use the new _AdvancedBlendMode field. Signed-off-by: Kenneth Graunke Reviewed-by: Francisco

[Mesa-dev] [PATCH v2 09/16] mesa: Restyle _mesa_check_blend_func_error().

2016-08-21 Thread Kenneth Graunke
I'm about to add more error conditions to this function, so I wanted to move the current spec citation above the code that checks it. Indenting it required reformatting, so I tried to move it to our newer style. While there, I also decided to drop some GL type usage, and drop the unnecessary "_me

[Mesa-dev] [PATCH v2 03/16] mesa: add KHR_blend_equation_advanced enable and extension string

2016-08-21 Thread Kenneth Graunke
From: Ilia Mirkin Signed-off-by: Ilia Mirkin Reviewed-by: Kenneth Graunke --- src/mesa/main/extensions_table.h | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index ee4f1af..e8c825

[Mesa-dev] [PATCH v2 06/16] glsl: Merge blend_support qualifiers when linking.

2016-08-21 Thread Kenneth Graunke
Since each qualifier represents a blending mode the shader can be used with, we take the union of all possible modes when linking. Signed-off-by: Kenneth Graunke Reviewed-by: Francisco Jerez --- src/compiler/glsl/linker.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/glsl

[Mesa-dev] [PATCH v2 05/16] glsl: process blend_support_* qualifiers

2016-08-21 Thread Kenneth Graunke
From: Ilia Mirkin v2 (Ken): Add a BLEND_NONE enum value (no qualifiers in use). v3 (Ken): Rename gl_blend_support_qualifier to gl_advanced_blend_mode. Signed-off-by: Ilia Mirkin Reviewed-by: Kenneth Graunke Reviewed-by: Francisco Jerez --- src/compiler/glsl/ast.h | 5

[Mesa-dev] [PATCH v2 02/16] glapi: add KHR_blend_equation_advanced dispatch

2016-08-21 Thread Kenneth Graunke
From: Ilia Mirkin v2 (Ken): Fix enum values, drop _mesa_BlendBarrierKHR stub as Curro has already implemented it. v3 (Ken): Rework for _mesa_BlendBarrierKHR -> _mesa_BlendBarrier rename. Signed-off-by: Ilia Mirkin Signed-off-by: Kenneth Graunke Reviewed-by: Francisco Jerez --- src/

[Mesa-dev] [PATCH v2 08/16] mesa: Track the current advanced blending mode.

2016-08-21 Thread Kenneth Graunke
This will be useful for a number of things: - Checking the current advanced blending mode against the shader's blend_support_* qualifiers. - Disabling hardware blending when emulating advanced blending. - Uploading the current advanced blending mode as a state var. Signed-off-by: Kenneth Graunke

[Mesa-dev] [PATCH v2 01/16] mesa: Rename _mesa_BlendBarrierMESA to _mesa_BlendBarrier.

2016-08-21 Thread Kenneth Graunke
Note that _mesa_BlendBarrierMESA is not currently hooked up in the glapi XML, so we can just rename it. We'll hook it up for the KHR_blend_equation_advanced extension shortly. We may as well use the ES 3.2 core name with no suffixes. Signed-off-by: Kenneth Graunke --- src/mesa/main/barrier.c |