Re: [Mesa-dev] [PATCH v2 3/4] gallium/winsys/kms: Move display target handle lookup to separate function (v2)

On Fri, Aug 12, 2016 at 8:03 AM, Jordan Justen wrote: > On 2016-08-08 01:55:18, Tomasz Figa wrote: >>On Fri, Aug 5, 2016 at 2:37 AM, Jordan Justen >>wrote: >> >> On 2016-08-02 03:46:27, Tomasz Figa wrote: >> > +kms_sw_displaytarget_lookup(struct kms_sw_winsys *kms_sw, >> >

Re: [Mesa-dev] [PATCH 2/2] nir/algebraic: Optimize common array indexing sequence

On Thu, 2016-08-11 at 20:54 +0200, Thomas Helland wrote: > 2016-08-11 18:19 GMT+02:00 Ian Romanick : > > > > ping > > > > On 07/19/2016 10:37 PM, Ian Romanick wrote: > > > > > > From: Ian Romanick > > > > > > Some shaders include code that looks like: > > > > > >    uniform int i; > > >    un

Re: [Mesa-dev] [PATCH 2/2] anv: GetDeviceImageFormatProperties: fix TRANSFER formats

On Aug 11, 2016 10:25 AM, "Lionel Landwerlin" wrote: > > We let the user believe we support some transfer formats which we don't. > This can lead to crashes when actually trying to use those formats for > example on dEQP-VK.api.copy_and_blit.image_to_image.* tests. > > Let all formats we can rende

Re: [Mesa-dev] [PATCH 2/2] nir/algebraic: Optimize common array indexing sequence

On Aug 11, 2016 6:16 PM, "Ian Romanick" wrote: > > On 08/11/2016 11:54 AM, Thomas Helland wrote: > > 2016-08-11 18:19 GMT+02:00 Ian Romanick : > >> ping > >> > >> On 07/19/2016 10:37 PM, Ian Romanick wrote: > >>> From: Ian Romanick > >>> > >>> Some shaders include code that looks like: > >>> > >>

Re: [Mesa-dev] [PATCH 2/2] nir/algebraic: Optimize common array indexing sequence

On 08/11/2016 11:54 AM, Thomas Helland wrote: > 2016-08-11 18:19 GMT+02:00 Ian Romanick : >> ping >> >> On 07/19/2016 10:37 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> Some shaders include code that looks like: >>> >>>uniform int i; >>>uniform vec4 bones[...]; >>> >>>foo(bon

Re: [Mesa-dev] [PATCH V2 2/2] i965: Change 8X MSAA sample mapping

On Aug 11, 2016 5:34 PM, "Anuj Phogat" wrote: > > Thanks for the review. Can you also review the piglit patch? > "multisample_blit_scaled: Change 8X MSAA sample mapping" Done > > On Thu, Aug 11, 2016 at 3:56 PM, Jason Ekstrand wrote: > > This looks good. Thanks! I think we should probably squ

Re: [Mesa-dev] [PATCH] anv: Use macro to avoid code duplication for sample positions

On Aug 11, 2016 5:12 PM, "Anuj Phogat" wrote: > > On Thu, Aug 11, 2016 at 4:06 PM, Jason Ekstrand wrote: > > Thanks! > > > > Reviewed-by: Jason Ekstrand > > > > On Thu, Aug 11, 2016 at 10:39 AM, Anuj Phogat wrote: > >> > >> Suggested-by: Jason Ekstrand > >> Signed-off-by: Anuj Phogat > >> ---

Re: [Mesa-dev] [PATCH 2/3] glsl: Tidy stream handling in merge_qualifier().

On Friday, August 12, 2016 9:44:42 AM PDT Timothy Arceri wrote: > On Thu, 2016-08-11 at 13:43 -0700, Kenneth Graunke wrote: > > The previous commit fixed xfb_buffer handling, which was largely copy > > and pasted from the stream handling. The difference is that stream > > was set in input_layout_m

Re: [Mesa-dev] [PATCH V2 2/2] i965: Change 8X MSAA sample mapping

Thanks for the review. Can you also review the piglit patch? "multisample_blit_scaled: Change 8X MSAA sample mapping" On Thu, Aug 11, 2016 at 3:56 PM, Jason Ekstrand wrote: > This looks good. Thanks! I think we should probably squash it in to the > other one because there's technically a regre

Re: [Mesa-dev] [PATCH 0/5] isl: Update the format table and add asserts

On Tue, Jul 26, 2016 at 10:04:21PM -0700, Jason Ekstrand wrote: > The real objective of this series is patch 5 which prevents us from > accidentally creating a surface state with a format unsupported by the > hardware. This turns some of the new Vulkan CTS tests from a hang into an > informative c

Re: [Mesa-dev] [PATCH 3/5] isl/formats: Update the table with more samplable formats

On Thu, Aug 11, 2016 at 11:34:38AM -0700, Nanley Chery wrote: > On Tue, Jul 26, 2016 at 10:04:24PM -0700, Jason Ekstrand wrote: > > There were a lot of formats where support was added on Haswell or later but > > we never updated the format table. > > --- > > src/intel/isl/isl_format.c | 30 +++

Re: [Mesa-dev] Question about tesselation shader out varyings and transform feedback

On Thu, 2016-08-11 at 17:10 +0200, Alejandro Piñeiro wrote: > On 05/08/16 12:20, Alejandro Piñeiro wrote: > > > > On 05/08/16 01:53, Timothy Arceri wrote: > > > > > > On Thu, 2016-08-04 at 18:36 +0200, Alejandro Piñeiro wrote: > > > > > > > > Hi, > > > > > > > > these days I have been trying to

Re: [Mesa-dev] [PATCH] anv: Use macro to avoid code duplication for sample positions

On Thu, Aug 11, 2016 at 4:06 PM, Jason Ekstrand wrote: > Thanks! > > Reviewed-by: Jason Ekstrand > > On Thu, Aug 11, 2016 at 10:39 AM, Anuj Phogat wrote: >> >> Suggested-by: Jason Ekstrand >> Signed-off-by: Anuj Phogat >> --- >> src/intel/vulkan/genX_multisample.h | 95 >> ++

Re: [Mesa-dev] [PATCH 0/5] isl: Update the format table and add asserts

On Thu, Aug 11, 2016 at 04:22:04PM -0700, Jason Ekstrand wrote: > On Thu, Aug 11, 2016 at 12:55 PM, Nanley Chery > wrote: > > > On Tue, Jul 26, 2016 at 10:04:21PM -0700, Jason Ekstrand wrote: > > > The real objective of this series is patch 5 which prevents us from > > > accidentally creating a s

Re: [Mesa-dev] [PATCH 2/3] glsl: Tidy stream handling in merge_qualifier().

On Thu, 2016-08-11 at 13:43 -0700, Kenneth Graunke wrote: > The previous commit fixed xfb_buffer handling, which was largely copy > and pasted from the stream handling.  The difference is that stream > was set in input_layout_mask, so it worked. > > However, that's totally rubbish: stream is only

Re: [Mesa-dev] [PATCH 1/5] i965/surface_formats: Don't advertise 8 or 16-bit RGB formats

On Thu, Aug 11, 2016 at 04:23:51PM -0700, Jason Ekstrand wrote: > On Thu, Aug 11, 2016 at 11:26 AM, Nanley Chery > wrote: > > > On Tue, Jul 26, 2016 at 10:04:22PM -0700, Jason Ekstrand wrote: > > > We have implicitly been not advertising these formats since we had them > > > turned off in the for

[Mesa-dev] [PATCH] radeonsi: initialize and finalize the LLVM function pass manager

From: Marek Olšák we should do that allegedly --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c index d75311e..e04e26a 100644 ---

Re: [Mesa-dev] [PATCH 3/5] isl/formats: Update the table with more samplable formats

On Thu, Aug 11, 2016 at 12:14 PM, Nanley Chery wrote: > On Tue, Jul 26, 2016 at 10:04:24PM -0700, Jason Ekstrand wrote: > > There were a lot of formats where support was added on Haswell or later > but > > we never updated the format table. > > --- > > src/intel/isl/isl_format.c | 30 +++

Re: [Mesa-dev] [PATCH 1/5] i965/surface_formats: Don't advertise 8 or 16-bit RGB formats

On Thu, Aug 11, 2016 at 11:26 AM, Nanley Chery wrote: > On Tue, Jul 26, 2016 at 10:04:22PM -0700, Jason Ekstrand wrote: > > We have implicitly been not advertising these formats since we had them > > turned off in the format capabilities table. We are about to update that > > table and this prev

Re: [Mesa-dev] [PATCH 02/16] st_glsl_to_tgsi: use calloc the way it's meant to be used

Reviewed-by: Marek Olšák Marek On Wed, Aug 10, 2016 at 9:23 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp > b/src/mesa/s

Re: [Mesa-dev] [PATCH 01/16] tgsi/scan: add tgsi_scan_arrays

This patch: Reviewed-by: Marek Olšák Marek On Wed, Aug 10, 2016 at 9:23 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/auxiliary/tgsi/tgsi_scan.c | 76 > ++ > src/gallium/auxiliary/tgsi/tgsi_scan.h | 17 > 2 files changed, 93

Re: [Mesa-dev] [PATCH 0/5] isl: Update the format table and add asserts

On Thu, Aug 11, 2016 at 12:55 PM, Nanley Chery wrote: > On Tue, Jul 26, 2016 at 10:04:21PM -0700, Jason Ekstrand wrote: > > The real objective of this series is patch 5 which prevents us from > > accidentally creating a surface state with a format unsupported by the > > hardware. This turns some

Re: [Mesa-dev] [PATCH] anv: Use macro to avoid code duplication for sample positions

Thanks! Reviewed-by: Jason Ekstrand On Thu, Aug 11, 2016 at 10:39 AM, Anuj Phogat wrote: > Suggested-by: Jason Ekstrand > Signed-off-by: Anuj Phogat > --- > src/intel/vulkan/genX_multisample.h | 95 ++ > + > src/intel/vulkan/genX_pipeline_util.h | 35 ++

Re: [Mesa-dev] [PATCH v2 3/4] gallium/winsys/kms: Move display target handle lookup to separate function (v2)

On 2016-08-08 01:55:18, Tomasz Figa wrote: >On Fri, Aug 5, 2016 at 2:37 AM, Jordan Justen >wrote: > > On 2016-08-02 03:46:27, Tomasz Figa wrote: > > +kms_sw_displaytarget_lookup(struct kms_sw_winsys *kms_sw, > > +unsigned int kms_handle) > >

Re: [Mesa-dev] [PATCH V2 2/2] i965: Change 8X MSAA sample mapping

This looks good. Thanks! I think we should probably squash it in to the other one because there's technically a regression between the two. Both are Reviewed-by: Jason Ekstrand On Thu, Aug 11, 2016 at 12:28 PM, Anuj Phogat wrote: > This is required following the change in 8X sample position

Re: [Mesa-dev] [PATCH] anv/x11: Add support for Xlib platform

On Thu, Aug 11, 2016 at 3:26 PM, Kevin Strasser wrote: > Some applications continue to use the Xlib client library and expect that > VK_KHR_xlib_surface will be available in the driver. Service these > applications by converting the Display pointer to xcb_connection_t and use > the existing xcb c

[Mesa-dev] [PATCH] anv/x11: Add support for Xlib platform

Some applications continue to use the Xlib client library and expect that VK_KHR_xlib_surface will be available in the driver. Service these applications by converting the Display pointer to xcb_connection_t and use the existing xcb code in the driver. Signed-off-by: Kevin Strasser Cc: Jason Ekst

Re: [Mesa-dev] [PATCH 1/2] anv: pipeline: gen7: fix assert in debug mode

Reviewed-by: Jason Ekstrand On Thu, Aug 11, 2016 at 10:25 AM, Lionel Landwerlin wrote: > SampleMask is only 8bits long on gen7. > > Signed-off-by: Lionel Landwerlin > Cc: Jason Ekstrand > --- > src/intel/vulkan/genX_pipeline_util.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a

[Mesa-dev] [PATCH 19/32] i965/blorp/gen7-8: Emit depth stencil state with CC and BLEND

All three go together on SNB so let's keep them together for gen7+ as well. --- src/mesa/drivers/dri/i965/gen7_blorp.c | 4 ++-- src/mesa/drivers/dri/i965/gen8_blorp.c | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_blorp.c b/src/mesa/drivers

[Mesa-dev] [PATCH 28/32] i965/blorp: Add a helper for emitting surface states

The new helper emits surface states and the binding table in one go. It's nice to have it pulled out of the main blorp_exec function. --- src/mesa/drivers/dri/i965/genX_blorp_exec.c | 52 - 1 file changed, 28 insertions(+), 24 deletions(-) diff --git a/src/mesa/driver

[Mesa-dev] [PATCH 15/32] i965/blorp: Make gen6 VS and GS disable helpers static

--- src/mesa/drivers/dri/i965/blorp_priv.h | 8 src/mesa/drivers/dri/i965/gen6_blorp.c | 4 ++-- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/blorp_priv.h b/src/mesa/drivers/dri/i965/blorp_priv.h index 5fafe38..730665e 100644 --- a/src/mesa/dr

[Mesa-dev] [PATCH 13/32] i965: Stop including brw_defines.h in brw_state.h

--- src/mesa/drivers/dri/i965/brw_meta_util.c | 1 + src/mesa/drivers/dri/i965/brw_state.h | 1 - src/mesa/drivers/dri/i965/gen6_blorp.c| 1 + src/mesa/drivers/dri/i965/gen7_blorp.c| 1 + 4 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_meta_u

[Mesa-dev] [PATCH 26/32] i965/blorp: Add genxml-based dynamic state emit functions

--- src/mesa/drivers/dri/i965/genX_blorp_exec.c | 82 + 1 file changed, 73 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/genX_blorp_exec.c b/src/mesa/drivers/dri/i965/genX_blorp_exec.c index 0652930..e512b95 100644 --- a/src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 12/32] i965/state: Move is_drawing_lines/points to gen6_clip_state.c

--- src/mesa/drivers/dri/i965/brw_state.h | 55 ++--- src/mesa/drivers/dri/i965/gen6_clip_state.c | 54 +++- src/mesa/drivers/dri/i965/gen6_sf_state.c | 4 +-- src/mesa/drivers/dri/i965/gen7_sf_state.c | 2 +- 4 files changed, 59 insertio

[Mesa-dev] [PATCH 20/32] i965/blorp/gen6-7: Move surfaces and samplers closer together

This mimics what we do on gen8. --- src/mesa/drivers/dri/i965/gen6_blorp.c | 4 ++-- src/mesa/drivers/dri/i965/gen7_blorp.c | 17 - 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_blorp.c b/src/mesa/drivers/dri/i965/gen6_blorp.c ind

[Mesa-dev] [PATCH 29/32] i965/blorp: Add genxml-based vertex setup helpers

--- src/mesa/drivers/dri/i965/genX_blorp_exec.c | 213 +++- 1 file changed, 212 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/genX_blorp_exec.c b/src/mesa/drivers/dri/i965/genX_blorp_exec.c index 922da45..f345454 100644 --- a/src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 32/32] i965/blorp: Remove no longer used state setup helpers

Now that we're using genxml for everything, we no longer need the hand-rolled state emit helpers. --- src/mesa/drivers/dri/i965/Makefile.sources | 1 - src/mesa/drivers/dri/i965/blorp_priv.h | 79 src/mesa/drivers/dri/i965/brw_blorp_emit.c | 577 - 3 files c

[Mesa-dev] [PATCH 18/32] i965/blorp/gen6: Move constant disables higher up

This is what gen7-8 do and it's a bit cleaner. --- src/mesa/drivers/dri/i965/gen6_blorp.c | 29 +++-- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_blorp.c b/src/mesa/drivers/dri/i965/gen6_blorp.c index d27c550..3fa8090 10064

[Mesa-dev] [PATCH 14/32] i965: Roll intel_reg.h into brw_defines.h

More than half of the stuff in intel_reg.h had nothing whatsoever to do with registers and really belongs in brw_defines.h anyway. --- src/mesa/drivers/dri/i965/Makefile.sources | 1 - src/mesa/drivers/dri/i965/brw_defines.h| 273 +++ src/mesa/drivers/dri/i965/brw

[Mesa-dev] [PATCH 31/32] i965/blorp: Use genxml for gen8-9 state setup

--- src/mesa/drivers/dri/i965/Makefile.am | 10 +- src/mesa/drivers/dri/i965/Makefile.sources | 7 +- src/mesa/drivers/dri/i965/blorp.c | 4 +- src/mesa/drivers/dri/i965/blorp_priv.h | 3 + src/mesa/drivers/dri/i965/gen8_blorp.c | 578

[Mesa-dev] [PATCH 23/32] i965/blorp: Stop setting point and line rasterization rules

Blorp never uses points or lines and the default values of 0 are perfectly fine. Explicitly setting them is just noise. --- src/mesa/drivers/dri/i965/gen6_blorp.c | 2 -- src/mesa/drivers/dri/i965/gen7_blorp.c | 2 -- src/mesa/drivers/dri/i965/gen8_blorp.c | 4 +--- 3 files changed, 1 insertion(+

[Mesa-dev] [PATCH 30/32] i965/blorp: Use genxml for gen7 state setup

--- src/mesa/drivers/dri/i965/Makefile.am | 10 +- src/mesa/drivers/dri/i965/Makefile.sources | 6 +- src/mesa/drivers/dri/i965/blorp.c | 5 +- src/mesa/drivers/dri/i965/blorp_priv.h | 4 + src/mesa/drivers/dri/i965/gen7_blorp.c | 540

[Mesa-dev] [PATCH 27/32] i965/blorp: Add genxml-based sampler state emit function

--- src/mesa/drivers/dri/i965/genX_blorp_exec.c | 49 ++--- 1 file changed, 38 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i965/genX_blorp_exec.c b/src/mesa/drivers/dri/i965/genX_blorp_exec.c index e512b95..156d8ac 100644 --- a/src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH 10/32] genxml: Add a uint MOCS field to VERTEX_BUFFER_STATE

--- src/intel/genxml/gen6.xml | 1 + src/intel/genxml/gen7.xml | 1 + src/intel/genxml/gen75.xml | 1 + src/intel/genxml/gen8.xml | 1 + src/intel/genxml/gen9.xml | 1 + 5 files changed, 5 insertions(+) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml index 6241665..52d0ecb

[Mesa-dev] [PATCH 25/32] i965: Move gen6_blorp.c to a file that gets recompiled per-gen

At the moment, it's only used for gen6 but that will change soon. We use the genX prefix for recompiled things in the Vulkan driver. It isn't great, but it seems to have worked ok. --- src/mesa/drivers/dri/i965/Makefile.am | 14 +- src/mesa/drivers/dri/i965/Makefile.sources | 5 +- src

[Mesa-dev] [PATCH 22/32] i965/blorp/gen8: Move viewport setup to after wm state

This matches gen6 and gen7. --- src/mesa/drivers/dri/i965/gen8_blorp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/gen8_blorp.c b/src/mesa/drivers/dri/i965/gen8_blorp.c index 5085923..2e90438 100644 --- a/src/mesa/drivers/dri/i965/gen8_blorp.c +

[Mesa-dev] [PATCH 16/32] i965/blorp: Move the non-static blorp state setup helpers to another file

We're about to start replacing blorp state setup code with packing structs and we want to feel free to delete files as we go. --- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri/i965/brw_blorp_emit.c | 577 + src/mesa/drivers/dri/i965/gen6_blorp

[Mesa-dev] [PATCH 17/32] i965/blorp: Don't clear an empty region

--- src/mesa/drivers/dri/i965/brw_blorp.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index f12c1f8..ccc7136 100644 --- a/src/mesa/drivers/dri/i965/brw_blorp.c +++ b/src/mesa/drivers/dri/i965/brw_blorp.c @@

[Mesa-dev] [PATCH 24/32] i965/blorp/gen6: Use genxml packing structs for state setup

--- src/mesa/drivers/dri/i965/Makefile.am | 1 + src/mesa/drivers/dri/i965/gen6_blorp.c | 685 - 2 files changed, 256 insertions(+), 430 deletions(-) diff --git a/src/mesa/drivers/dri/i965/Makefile.am b/src/mesa/drivers/dri/i965/Makefile.am index 0a5222e..77ad1

[Mesa-dev] [PATCH 07/32] genxml/gen6: Make SAMPLER_STATE look a bit more like gen7

--- src/intel/genxml/gen6.xml | 45 ++--- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml index 3fe7377..2499b46 100644 --- a/src/intel/genxml/gen6.xml +++ b/src/intel/genxml/gen6.xml @@ -

[Mesa-dev] [PATCH 08/32] genxml: Make VERTEX_ELEMENT_STATE::Valid a bool

--- src/intel/genxml/gen6.xml | 2 +- src/intel/genxml/gen7.xml | 2 +- src/intel/genxml/gen75.xml | 2 +- src/intel/genxml/gen8.xml | 2 +- src/intel/genxml/gen9.xml | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml in

[Mesa-dev] [PATCH 21/32] i965/blorp/gen6-7: Move multisample setup to right after samplers

This mimics gen8 blorp --- src/mesa/drivers/dri/i965/gen6_blorp.c | 9 + src/mesa/drivers/dri/i965/gen7_blorp.c | 10 +- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_blorp.c b/src/mesa/drivers/dri/i965/gen6_blorp.c index b252d78..

[Mesa-dev] [PATCH 09/32] genxml: Make a couple of VERTEX_BUFFER_STATE fields boolean

--- src/intel/genxml/gen6.xml | 2 +- src/intel/genxml/gen7.xml | 4 ++-- src/intel/genxml/gen75.xml | 4 ++-- src/intel/genxml/gen8.xml | 2 +- src/intel/genxml/gen9.xml | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xm

[Mesa-dev] [PATCH 11/32] genxml/gen9: Make 3DSTATE_SBE::AttributeActiveComponentFormat an array

--- src/intel/genxml/gen9.xml | 35 +++- src/intel/vulkan/genX_pipeline_util.h | 38 +++ 2 files changed, 6 insertions(+), 67 deletions(-) diff --git a/src/intel/genxml/gen9.xml b/src/intel/genxml/gen9.xml index 51a2420..547d

[Mesa-dev] [PATCH 03/32] genxml/gen6: Fix the length of 3DSTATE_WM

--- src/intel/genxml/gen6.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml index 6ece749..1be0ede 100644 --- a/src/intel/genxml/gen6.xml +++ b/src/intel/genxml/gen6.xml @@ -1365,12 +1365,12 @@ - +

[Mesa-dev] [PATCH 00/32] i965/blorp: Use genxml for state setup

This patch series is the next on the way towards generalizing blorp for usin in Vulkan. At this point, I'd say the project is about 80% complete. This series only applies on top of the last two blorp isl series which are still undergoing review. Patches 1-11 make minor genxml improvements. Some

[Mesa-dev] [PATCH 05/32] genxml/gen6: Make "Depth Clear Value" a uint

The actual data storred is in float, UNORM24, or UNORM16 depending on the actual depth format. --- src/intel/genxml/gen6.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml index ae317a13..06b441b 100644 --- a/src/intel/genx

[Mesa-dev] [PATCH 02/32] genxml/gen6: Add a Surface Base Address field to HIER_DEPTH_BUFFER

--- src/intel/genxml/gen6.xml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml index 0f2be24..6ece749 100644 --- a/src/intel/genxml/gen6.xml +++ b/src/intel/genxml/gen6.xml @@ -1007,14 +1007,15 @@ - +

[Mesa-dev] [PATCH 01/32] genxml/gen6: Add uint MOCS fields for most things

--- src/intel/genxml/gen6.xml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml index cf94efc..0f2be24 100644 --- a/src/intel/genxml/gen6.xml +++ b/src/intel/genxml/gen6.xml @@ -1883,20 +1883,26 @@ + +

[Mesa-dev] [PATCH 06/32] genxml: Add a uint MOCS field to DEPTH_BUFFER packets

This is easier than dealing with structs all the time --- src/intel/genxml/gen6.xml | 2 ++ src/intel/genxml/gen7.xml | 2 ++ src/intel/genxml/gen75.xml | 2 ++ src/intel/genxml/gen8.xml | 2 ++ src/intel/genxml/gen9.xml | 2 ++ 5 files changed, 10 insertions(+) diff --git a/src/intel/genxml/

[Mesa-dev] [PATCH 04/32] genxml/gen6: Add the 3D_Prim_Topo_Type enum

--- src/intel/genxml/gen6.xml | 24 1 file changed, 24 insertions(+) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml index 1be0ede..ae317a13 100644 --- a/src/intel/genxml/gen6.xml +++ b/src/intel/genxml/gen6.xml @@ -447,6 +447,30 @@ + +

[Mesa-dev] [PATCH 1/3] glsl: Fix inout qualifier handling in GLSL 4.40.

inout variables have q.in and q.out set. We were trying to set xfb_buffer = 1 for shader output variables (and inadvertantly setting it on inout parameters, too). But input_layout_mask doesn't have xfb_buffer set, so it was seen as in invalid input qualifier. This meant that all 'inout' paramete

[Mesa-dev] [PATCH 3/3] glsl: Fix invariant matching in GLSL 4.30 and GLSL ES 1.00.

Old languages (GLSL <= 4.20 and GLSL ES 1.00) require "invariant" to be specified on both inputs and outputs, and match when linking. New languages only allow outputs to be qualified as "invariant" and remove the "invariant must match" restriction when linking varyings (because no input can have t

[Mesa-dev] [PATCH 2/3] glsl: Tidy stream handling in merge_qualifier().

The previous commit fixed xfb_buffer handling, which was largely copy and pasted from the stream handling. The difference is that stream was set in input_layout_mask, so it worked. However, that's totally rubbish: stream is only valid on geometry shader outputs. Presumably this was to hack aroun

[Mesa-dev] [Bug 97307] glsl/glcpp/tests/glcpp-test regression

https://bugs.freedesktop.org/show_bug.cgi?id=97307 Bug ID: 97307 Summary: glsl/glcpp/tests/glcpp-test regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: All Status: NEW Keywords: bisected,

[Mesa-dev] [PATCH 3/4] gallium/winsys: re-number winsys priority flags

From: Marek Olšák free 60..63, move CP_DMA up --- src/gallium/drivers/radeon/radeon_winsys.h | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_winsys.h b/src/gallium/drivers/radeon/radeon_winsys.h index e4d669f.

[Mesa-dev] [PATCH 2/4] gallium/radeon: mark shader rings as highest-priority buffers

From: Marek Olšák and rename the enum --- src/gallium/drivers/r600/evergreen_state.c| 4 ++-- src/gallium/drivers/r600/r600_state.c | 4 ++-- src/gallium/drivers/radeon/radeon_winsys.h| 2 +- src/gallium/drivers/radeonsi/si_debug.c | 2 +- src/gallium/drivers/radeonsi/si_de

[Mesa-dev] [PATCH 4/4] gallium/radeon: assign the highest priority to scratch; make rings second

From: Marek Olšák just FYI, the kernel receives priority/4 --- src/gallium/drivers/radeon/radeon_winsys.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_winsys.h b/src/gallium/drivers/radeon/radeon_winsys.h index 8a98ebf..c65b9a4 1006

[Mesa-dev] [PATCH 1/4] gallium/radeon: set SHADER_RW_BUFFER priority for streamout buffers

From: Marek Olšák --- src/gallium/drivers/radeon/r600_streamout.c | 4 ++-- src/gallium/drivers/radeonsi/si_descriptors.c | 6 -- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_streamout.c b/src/gallium/drivers/radeon/r600_streamout.c index

Re: [Mesa-dev] [PATCH 0/5] isl: Update the format table and add asserts

On Tue, Jul 26, 2016 at 10:04:21PM -0700, Jason Ekstrand wrote: > The real objective of this series is patch 5 which prevents us from > accidentally creating a surface state with a format unsupported by the > hardware. This turns some of the new Vulkan CTS tests from a hang into an > informative c

[Mesa-dev] [Bug 97291] Incorrect packing of struct

https://bugs.freedesktop.org/show_bug.cgi?id=97291 --- Comment #4 from Matias N. Goldberg --- OK I'm fully re-powered and thinking straight now: I've built Mesa from scratch. Tried commits git-edfc17a (current head of branch 12.0) and commit 17f1c49b9ad05af4f6482f6fa950e5dcc1a779d1 (current head

[Mesa-dev] [PATCH V2 1/2] i965: Change 8x multisample positions

There are no standard sample positions defined in OpenGL and OpenGL ES specs. Implementations have the freedom to pick the positions which give plausible results. But the Vulkan 1.0 spec does define standard sample positions for different sample counts. Defined positions in Vulkan for all the sampl

[Mesa-dev] [PATCH V2 2/2] i965: Change 8X MSAA sample mapping

This is required following the change in 8X sample positions. Fixes the recently modified multisample-scaled-blit piglit tests. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 10 +- src/mesa/drivers/dri/i965/gen6_multisample_state.c | 2 +- 2 files c

Re: [Mesa-dev] [PATCH 3/5] isl/formats: Update the table with more samplable formats

On Tue, Jul 26, 2016 at 10:04:24PM -0700, Jason Ekstrand wrote: > There were a lot of formats where support was added on Haswell or later but > we never updated the format table. > --- > src/intel/isl/isl_format.c | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletion

Re: [Mesa-dev] [PATCH 2/2] nir/algebraic: Optimize common array indexing sequence

2016-08-11 18:19 GMT+02:00 Ian Romanick : > ping > > On 07/19/2016 10:37 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Some shaders include code that looks like: >> >>uniform int i; >>uniform vec4 bones[...]; >> >>foo(bones[i * 3], bones[i * 3 + 1], bones[i * 3 + 2]); >> >> CSE w

[Mesa-dev] [Bug 97285] Darkness in Dota 2 after Patch "Make Gallium's BlitFramebuffer follow the GL 4.4 sRGB rules"

https://bugs.freedesktop.org/show_bug.cgi?id=97285 --- Comment #11 from Marek Olšák --- The patch looks good to me. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] i965: Change 8x multisample positions

On Thu, Aug 11, 2016 at 10:53 AM, Jason Ekstrand wrote: > > > On Thu, Aug 11, 2016 at 10:41 AM, Anuj Phogat wrote: >> >> There are no standard sample positions defined in OpenGL and OpenGL >> ES specs. Implementations have the freedom to pick the positions >> which give plausible results. But the

Re: [Mesa-dev] [PATCH 3/5] isl/formats: Update the table with more samplable formats

On Tue, Jul 26, 2016 at 10:04:24PM -0700, Jason Ekstrand wrote: > There were a lot of formats where support was added on Haswell or later but > we never updated the format table. > --- > src/intel/isl/isl_format.c | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletion

[Mesa-dev] [PATCH 1/2] mesa: Document that _mesa_enum_to_string() returns non-null

It always returns non-null, even if the number is an invalid enum. Cc: Haixia Shi Reviewed-by: Ian Romanick Change-Id: I26e8843c96130be972e66f48a49e362442e1bf97 --- src/mapi/glapi/gen/gl_enums.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_enu

[Mesa-dev] [PATCH 0/3] mesa: Fix a dEQP test (v2)

Fixes test dEQP-GLES3.functional.negative_api.buffer.framebuffer_texture2d. I tested this patch for regressions on Skylake with: % ./deqp-gles3 --deqp-case= 'dEQP-GLES3.functional.negative_api.*' % ./deqp-gles3 --deqp-case='dEQP-GLES3.functional.fbo.color.texcube.*' This patch series lives at

[Mesa-dev] [PATCH 2/2] mesa: Fix glFramebufferTexture* error codes (v2)

If check_textarget() determined that textarget was incorrect, it emitted GL_INVALID_OPERATION. This is the correct behavior when target and textarget are mismatched but textarget is a valid textarget enum. When textarget is not a valid textarget enum, the GL spec requires that GL_INVALID_ENUM be

Re: [Mesa-dev] [PATCH 1/5] i965/surface_formats: Don't advertise 8 or 16-bit RGB formats

On Tue, Jul 26, 2016 at 10:04:22PM -0700, Jason Ekstrand wrote: > We have implicitly been not advertising these formats since we had them > turned off in the format capabilities table. We are about to update that > table and this prevents a change in behavior. The only change in behavior > create

Re: [Mesa-dev] [PATCH 2/3] mesa: Add _mesa_enum_to_string2()

On Thu, Aug 11, 2016 at 10:42 AM, Chad Versace wrote: > On 08/11/2016 10:24 AM, Ian Romanick wrote: >> >> On 08/11/2016 10:11 AM, Chad Versace wrote: >>> >>> The new function is identical to _mesa_enum_to_string(), except that it >>> returns false if the given number is an invalid enum. Bundling >

Re: [Mesa-dev] [PATCH 3/3] mesa: Fix glFramebufferTexture* error codes

On 08/11/2016 10:22 AM, Ilia Mirkin wrote: On Thu, Aug 11, 2016 at 1:11 PM, Chad Versace wrote: If check_textarget() determined that textarget was incorrect, it emitted GL_INVALID_OPERATION. This is the correct behavior when textarget is a valid GLenum but an invalid parameter to the current v

Re: [Mesa-dev] [PATCH] i965: Change 8x multisample positions

On Thu, Aug 11, 2016 at 10:41 AM, Anuj Phogat wrote: > There are no standard sample positions defined in OpenGL and OpenGL > ES specs. Implementations have the freedom to pick the positions > which give plausible results. But the Vulkan 1.0 spec does define > standard sample positions for differe

Re: [Mesa-dev] [PATCH] anv/device: Add limits for InterpolationOffset

On Fri, Jul 29, 2016 at 2:30 PM, Anuj Phogat wrote: > > > On Fri, Jul 29, 2016 at 12:32 PM, Anuj Phogat wrote: >> >> >> >> On Thu, Jul 28, 2016 at 6:31 PM, Jason Ekstrand >> wrote: >>> >>> On Jul 28, 2016 7:37 PM, "Anuj Phogat" wrote: >>> > >>> > Fixes the vulkan cts regression in test >>> > dE

Re: [Mesa-dev] [PATCH] glsl: look for frag data bindings with [0] tacked onto the end for arrays

I'll rebase and feed it through Jenkins (I was given a branch of late). On Thu, Aug 11, 2016 at 1:38 PM, Ian Romanick wrote: > Or not. :( The patch no longer applies, and I wasn't able to trivially > make it apply. I suspect one of Timothy's recent patches is to blame. > > On 08/11/2016 10:06 A

Re: [Mesa-dev] [PATCH 2/3] mesa: Add _mesa_enum_to_string2()

On 08/11/2016 10:24 AM, Ian Romanick wrote: On 08/11/2016 10:11 AM, Chad Versace wrote: The new function is identical to _mesa_enum_to_string(), except that it returns false if the given number is an invalid enum. Bundling validation and lookup into a single function allows us to do both with a

[Mesa-dev] [PATCH] i965: Change 8x multisample positions

There are no standard sample positions defined in OpenGL and OpenGL ES specs. Implementations have the freedom to pick the positions which give plausible results. But the Vulkan 1.0 spec does define standard sample positions for different sample counts. Defined positions in Vulkan for all the sampl

[Mesa-dev] [PATCH] anv: Use macro to avoid code duplication for sample positions

Suggested-by: Jason Ekstrand Signed-off-by: Anuj Phogat --- src/intel/vulkan/genX_multisample.h | 95 +++ src/intel/vulkan/genX_pipeline_util.h | 35 ++--- src/intel/vulkan/genX_state.c | 68 +++-- 3 files changed, 106 inserti

Re: [Mesa-dev] [PATCH] glsl: look for frag data bindings with [0] tacked onto the end for arrays

Or not. :( The patch no longer applies, and I wasn't able to trivially make it apply. I suspect one of Timothy's recent patches is to blame. On 08/11/2016 10:06 AM, Ian Romanick wrote: > This seems okay... let me run it through our CI first. I should have > results later today. I'm going to st

Re: [Mesa-dev] [PATCH 1/3] mesa: Document that _mesa_enum_to_string() returns non-null

On 08/11/2016 10:30 AM, Ian Romanick wrote: On 08/11/2016 10:22 AM, Ian Romanick wrote: On 08/11/2016 10:11 AM, Chad Versace wrote: It always returns non-null, even if the number is an invalid enum. Cc: Haixia Shi Change-Id: I26e8843c96130be972e66f48a49e362442e1bf97 --- src/mapi/glapi/gen/gl

Re: [Mesa-dev] [PATCH 2/3] mesa: Add _mesa_enum_to_string2()

On 08/11/2016 10:11 AM, Chad Versace wrote: > The new function is identical to _mesa_enum_to_string(), except that it > returns false if the given number is an invalid enum. Bundling > validation and lookup into a single function allows us to do both with > a single lookup into the enum table. > >

Re: [Mesa-dev] [PATCH 3/3] mesa: Fix glFramebufferTexture* error codes

On Thu, Aug 11, 2016 at 1:11 PM, Chad Versace wrote: > If check_textarget() determined that textarget was incorrect, it emitted > GL_INVALID_OPERATION. This is the correct behavior when textarget is > a valid GLenum but an invalid parameter to the current variant of > glFramebufferTexture*(). > >

Re: [Mesa-dev] [PATCH 1/3] mesa: Document that _mesa_enum_to_string() returns non-null

On 08/11/2016 10:22 AM, Ian Romanick wrote: > On 08/11/2016 10:11 AM, Chad Versace wrote: >> It always returns non-null, even if the number is an invalid enum. >> >> Cc: Haixia Shi >> Change-Id: I26e8843c96130be972e66f48a49e362442e1bf97 >> --- >> src/mapi/glapi/gen/gl_enums.py | 4 >> 1 file

Re: [Mesa-dev] [PATCH 3/3] mesa: Fix glFramebufferTexture* error codes

On 08/11/2016 10:11 AM, Chad Versace wrote: > If check_textarget() determined that textarget was incorrect, it emitted > GL_INVALID_OPERATION. This is the correct behavior when textarget is > a valid GLenum but an invalid parameter to the current variant of > glFramebufferTexture*(). > > However,

[Mesa-dev] [PATCH 2/2] anv: GetDeviceImageFormatProperties: fix TRANSFER formats

We let the user believe we support some transfer formats which we don't. This can lead to crashes when actually trying to use those formats for example on dEQP-VK.api.copy_and_blit.image_to_image.* tests. Let all formats we can render to or sample from as meta implements transfers using attachment

[Mesa-dev] [PATCH 1/2] anv: pipeline: gen7: fix assert in debug mode

SampleMask is only 8bits long on gen7. Signed-off-by: Lionel Landwerlin Cc: Jason Ekstrand --- src/intel/vulkan/genX_pipeline_util.h | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/vulkan/genX_pipeline_util.h b/src/intel/vulkan/genX_pipeline_util.h index 64b89cd..d56eeb8 1006

Re: [Mesa-dev] [PATCH 1/3] mesa: Document that _mesa_enum_to_string() returns non-null

On 08/11/2016 10:11 AM, Chad Versace wrote: > It always returns non-null, even if the number is an invalid enum. > > Cc: Haixia Shi > Change-Id: I26e8843c96130be972e66f48a49e362442e1bf97 > --- > src/mapi/glapi/gen/gl_enums.py | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/mapi

[Mesa-dev] [PATCH 3/3] mesa: Fix glFramebufferTexture* error codes

If check_textarget() determined that textarget was incorrect, it emitted GL_INVALID_OPERATION. This is the correct behavior when textarget is a valid GLenum but an invalid parameter to the current variant of glFramebufferTexture*(). However, when textarget is not a GLenum at all, then the GL spec

  1   2   >