[Mesa-dev] c99 vs v90

2016-08-02 Thread Enrico Weigelt, metux IT consult
Hi folks, do we still need to support pre-c99 compilers or could we drop that compat stuff ? --mtx ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2] i965: use mt->offset in intel_miptree_map_movntdqa().

2016-08-02 Thread Kenneth Graunke
On Tuesday, August 2, 2016 5:03:32 PM PDT Haixia Shi wrote: > We need to include mt->offset in the calculation of src pointer because its > value may be non-zero, for example in a cubemap texture. > > Signed-off-by: Haixia Shi > Cc: Jason Ekstrand > Cc: kenneth.w.grau...@intel.com > Cc: Chad Ver

Re: [Mesa-dev] [PATCH v2 7/7] egl/android: Make drm_gralloc headers optional (v2)

2016-08-02 Thread Tomasz Figa
On Wed, Aug 3, 2016 at 5:12 AM, Rob Herring wrote: > On Tue, Aug 2, 2016 at 6:07 AM, Tomasz Figa wrote: >> Make the code at least compile when being built without drm_gralloc >> headers. >> >> v2: Replaced #ifdefs with stubs for gralloc_drm_get_gem_handle() >> and GRALLOC_MODULE_PERFORM_GET_D

Re: [Mesa-dev] [PATCH v2 3/7] egl/android: Fix support for pbuffers (v2)

2016-08-02 Thread Tomasz Figa
Hi Rob, On Wed, Aug 3, 2016 at 2:32 AM, Rob Herring wrote: > On Tue, Aug 2, 2016 at 6:07 AM, Tomasz Figa wrote: >> From: Nicolas Boichat >> >> Existing image loader code supports creating images only for window >> surfaces. Moreover droid_create_surface() passes wrong surface type to >> dri2_ge

[Mesa-dev] non-shared glapi still needed ?

2016-08-02 Thread Enrico Weigelt, metux IT consult
Hi folks, is there still a real need for having non-shared glapi ? Otherwise, should we remove it ? --mtx ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 25/95] i965/vec4: fix base offset for nir_registers with doubles

2016-08-02 Thread Francisco Jerez
Iago Toral Quiroga writes: > --- > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp > b/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp > index cf35f2e..fde7b60 100644 > --- a/src/me

Re: [Mesa-dev] [PATCH] nir: Always print non-identity swizzles.

2016-08-02 Thread Jason Ekstrand
Seems reasonable to be too. Rb if you'd like On Aug 2, 2016 8:25 PM, "Timothy Arceri" wrote: > Reviewed-by: Timothy Arceri > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > _

Re: [Mesa-dev] [PATCH 33/95] i965/vec4: implement d2b

2016-08-02 Thread Francisco Jerez
Iago Toral Quiroga writes: > --- > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp > b/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp > index 1525a3d..4014020 100644 > --- a/src/mesa/d

Re: [Mesa-dev] [PATCH] nir: Always print non-identity swizzles.

2016-08-02 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 28/95] i965/vec4: fix register allocation for 64-bit undef sources

2016-08-02 Thread Francisco Jerez
Iago Toral Quiroga writes: > --- > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp > b/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp > index 7b8e30d..65fa057 100644 > --- a/src/mesa/dri

Re: [Mesa-dev] [PATCH 09/95] i965/vec4: add support for printing DF immediates

2016-08-02 Thread Francisco Jerez
Iago Toral Quiroga writes: > From: Connor Abbott > Reviewed-by: Francisco Jerez > --- > src/mesa/drivers/dri/i965/brw_vec4.cpp | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp > b/src/mesa/drivers/dri/i965/brw_vec4.cpp > index 162b481..bf6701

Re: [Mesa-dev] [PATCH 13/95] i965: add brw_vecn_grf()

2016-08-02 Thread Francisco Jerez
Iago Toral Quiroga writes: > From: Connor Abbott > Reviewed-by: Francisco Jerez > --- > src/mesa/drivers/dri/i965/brw_reg.h | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_reg.h > b/src/mesa/drivers/dri/i965/brw_reg.h > index 38cf8e3..e4c3e7a 1006

Re: [Mesa-dev] [PATCH 16/95] i965/vec4: We only support 32-bit integer ALU operations for now

2016-08-02 Thread Francisco Jerez
Iago Toral Quiroga writes: > Add asserts so we remember to address this when we enable 64-bit > integer support, as suggested by Connor and Jason. Reviewed-by: Francisco Jerez > --- > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 70 > ++ > 1 file changed, 52 inser

Re: [Mesa-dev] [PATCH 15/95] i965/disasm: align16 DF source regions have a width of 2

2016-08-02 Thread Francisco Jerez
Reviewed-by: Francisco Jerez Iago Toral Quiroga writes: > --- > src/mesa/drivers/dri/i965/brw_disasm.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c > b/src/mesa/drivers/dri/i965/brw_disasm.c > index d74d5d5..c8bdeab 100644

Re: [Mesa-dev] [PATCH 17/95] i965/vec4: add dst_null_df()

2016-08-02 Thread Francisco Jerez
Reviewed-by: Francisco Jerez Iago Toral Quiroga writes: > --- > src/mesa/drivers/dri/i965/brw_vec4.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4.h > b/src/mesa/drivers/dri/i965/brw_vec4.h > index 3043147..afcf31e 100644 > --- a/src/mesa/dri

Re: [Mesa-dev] [PATCH 0/3] Destroy Present event contexts

2016-08-02 Thread Michel Dänzer
On 02.08.2016 23:01, Leo Liu wrote: > On 08/01/2016 10:20 PM, Michel Dänzer wrote: >> On 28.07.2016 18:34, Michel Dänzer wrote: >>> Running XTS (the X test suite) on Xephyr using glamor running on Xorg, >>> I stumbled upon an issue: >>> >>> * XTS causes Xephyr to keep resetting and starting new ser

Re: [Mesa-dev] [PATCH] nir: add missing x swizzle in nir_print()

2016-08-02 Thread Matt Turner
On Tue, Aug 2, 2016 at 5:28 PM, Timothy Arceri wrote: > Currently we only print the swizzle if the components are not > used in order. This means x is not printed when it is the only > component used. By checking if the last component is used we > can print the swizzle for this case. I agree. I'v

[Mesa-dev] [PATCH] nir: add missing x swizzle in nir_print()

2016-08-02 Thread Timothy Arceri
Currently we only print the swizzle if the components are not used in order. This means x is not printed when it is the only component used. By checking if the last component is used we can print the swizzle for this case. --- src/compiler/nir/nir_print.c | 10 +- 1 file changed, 9 inserti

Re: [Mesa-dev] [PATCH v2] i965: use mt->offset in intel_miptree_map_movntdqa().

2016-08-02 Thread Chad Versace
On 08/02/2016 05:03 PM, Haixia Shi wrote: We need to include mt->offset in the calculation of src pointer because its value may be non-zero, for example in a cubemap texture. Signed-off-by: Haixia Shi Cc: Jason Ekstrand Cc: kenneth.w.grau...@intel.com Cc: Chad Versace Change-Id: I461ad5b2046

[Mesa-dev] [PATCH v2] i965: use mt->offset in intel_miptree_map_movntdqa().

2016-08-02 Thread Haixia Shi
We need to include mt->offset in the calculation of src pointer because its value may be non-zero, for example in a cubemap texture. Signed-off-by: Haixia Shi Cc: Jason Ekstrand Cc: kenneth.w.grau...@intel.com Cc: Chad Versace Change-Id: I461ad5b204626d5a1c45611fc6b63735dcf29f63 --- src/mesa/

Re: [Mesa-dev] [PATCH] i965: use mt->offset in intel_miptree_map_movntdqa().

2016-08-02 Thread Chad Versace
On 08/02/2016 04:35 PM, Chad Versace wrote: On 08/02/2016 04:17 PM, Haixia Shi wrote: We need to include mt->offset in the calculation of src pointer because its value may be non-zero, for example in a cubemap texture. Signed-off-by: Haixia Shi Cc: Jason Ekstrand Cc: kenneth.w.grau...@intel.c

Re: [Mesa-dev] [PATCH] i965: use mt->offset in intel_miptree_map_movntdqa().

2016-08-02 Thread Chad Versace
On 08/02/2016 04:17 PM, Haixia Shi wrote: We need to include mt->offset in the calculation of src pointer because its value may be non-zero, for example in a cubemap texture. Signed-off-by: Haixia Shi Cc: Jason Ekstrand Cc: kenneth.w.grau...@intel.com Cc: Chad Versace Change-Id: I461ad5b2046

Re: [Mesa-dev] [PATCH 0/3] RadeonSI GLSL "lit" tests

2016-08-02 Thread Marek Olšák
On Tue, Aug 2, 2016 at 9:23 PM, Nicolai Hähnle wrote: > > > On 02.08.2016 21:06, Marek Olšák wrote: >> >> On Tue, Aug 2, 2016 at 3:40 PM, Nicolai Hähnle wrote: >>> >>> On 31.07.2016 22:29, Marek Olšák wrote: Inspired by LLVM, I created a small test suite that looks like "lit"

[Mesa-dev] [PATCH] i965: use mt->offset in intel_miptree_map_movntdqa().

2016-08-02 Thread Haixia Shi
We need to include mt->offset in the calculation of src pointer because its value may be non-zero, for example in a cubemap texture. Signed-off-by: Haixia Shi Cc: Jason Ekstrand Cc: kenneth.w.grau...@intel.com Cc: Chad Versace Change-Id: I461ad5b204626d5a1c45611fc6b63735dcf29f63 --- src/mesa/

Re: [Mesa-dev] [PATCH v2 4/7] egl/android: Refactor image creation to separate flink and prime paths (v2)

2016-08-02 Thread Chad Versace
On 08/02/2016 04:07 AM, Tomasz Figa wrote: This patch splits current dri2_create_image_android_native_buffer() into main entry point and two additional functions, one for creating an image from flink name and one for handling prime FDs using the generic DMA-buf path. This makes the code cleaner a

Re: [Mesa-dev] [PATCH v2 2/7] egl/android: Respect buffer mask in droid_image_get_buffers (v2)

2016-08-02 Thread Chad Versace
On 08/02/2016 04:07 AM, Tomasz Figa wrote: Drivers can request different set of buffers depending on the buffer mask they pass to the get_buffers callback. This patch makes droid_image_get_buffers() respect this mask. v2: Return error only in case of real error condition and ignore requests

Re: [Mesa-dev] [PATCH 6/7] radeonsi: program multi draw and indirect draw count parameters

2016-08-02 Thread Nicolai Hähnle
Bas pointed out some things that mean this patch (and the next) probably need to be reworked. The tests were probably not thorough enough. Nicolai On 02.08.2016 21:41, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_state_draw.c | 23 ++- 1

Re: [Mesa-dev] [PATCH v2 1/7] egl/android: Remove unused variables in droid_get_buffers_with_format()

2016-08-02 Thread Chad Versace
On 08/02/2016 04:07 AM, Tomasz Figa wrote: Fix compilation warnings due to unused variables left after some earlier code changes. Signed-off-by: Tomasz Figa --- src/egl/drivers/dri2/platform_android.c | 3 --- 1 file changed, 3 deletions(-) Reviewed-by: Chad Versace ___

Re: [Mesa-dev] [PATCH v2 7/7] egl/android: Make drm_gralloc headers optional (v2)

2016-08-02 Thread Rob Herring
On Tue, Aug 2, 2016 at 6:07 AM, Tomasz Figa wrote: > Make the code at least compile when being built without drm_gralloc > headers. > > v2: Replaced #ifdefs with stubs for gralloc_drm_get_gem_handle() > and GRALLOC_MODULE_PERFORM_GET_DRM_FD. > Removed explicit render node probing code. > >

[Mesa-dev] [PATCH 5/7] radeonsi: add has_draw_indirect_multi flag

2016-08-02 Thread Nicolai Hähnle
From: Nicolai Hähnle Prefer to use DRAW_(INDEX)_INDIRECT_MULTI when available in the firmware. Versions for SI and CI already added as provided by the firmware team, but keep in mind that they won't currently be used since the radeon kernel module has no interface to query the firmware version.

[Mesa-dev] [PATCH 7/7] radeonsi: enable MULTI_DRAW_INDIRECT_(PARAMS) pipe caps

2016-08-02 Thread Nicolai Hähnle
From: Nicolai Hähnle This enables GL_ARB_indirect_parameters as well as a properly accelerated implementation of GL_ARB_multi_draw_indirect. Enabling the feature requires a sufficiently uptodate firmware -- those have already been released a long time ago, although this does mean that the featur

[Mesa-dev] [PATCH 2/7] radeonsi: unify emitting PKT3_SET_BASE for indirect draws

2016-08-02 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_state_draw.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index 24fa682..afb9bbf 100644 --- a/sr

Re: [Mesa-dev] [PATCH v2 6/7] egl/android: Add support for YV12 pixel format (v2)

2016-08-02 Thread Rob Herring
On Tue, Aug 2, 2016 at 6:07 AM, Tomasz Figa wrote: > This patch adds support for YV12 pixel format to the Android platform > backend. Only creating EGL images is supported, it is not added to the > list of available visuals. > > v2: Use const array defined just for YV12 instead of trying to be ove

Re: [Mesa-dev] [PATCH v2 5/7] egl/android: Make get_fourcc() accept HAL formats

2016-08-02 Thread Rob Herring
On Tue, Aug 2, 2016 at 6:07 AM, Tomasz Figa wrote: > There are DRI_IMAGE_FOURCC macros, for which there are no corresponding > DRI_IMAGE_FORMAT macros. To support such formats we need to make the > lookup function take the native format directly. As a side effect, it > simplifies all existing call

Re: [Mesa-dev] [PATCH v2 4/7] egl/android: Refactor image creation to separate flink and prime paths (v2)

2016-08-02 Thread Rob Herring
On Tue, Aug 2, 2016 at 6:07 AM, Tomasz Figa wrote: > This patch splits current dri2_create_image_android_native_buffer() into > main entry point and two additional functions, one for creating an image > from flink name and one for handling prime FDs using the generic DMA-buf > path. This makes the

Re: [Mesa-dev] [PATCH v2 2/7] egl/android: Respect buffer mask in droid_image_get_buffers (v2)

2016-08-02 Thread Rob Herring
On Tue, Aug 2, 2016 at 6:07 AM, Tomasz Figa wrote: > Drivers can request different set of buffers depending on the buffer > mask they pass to the get_buffers callback. This patch makes > droid_image_get_buffers() respect this mask. > > v2: Return error only in case of real error condition and igno

Re: [Mesa-dev] [PATCH v2 1/7] egl/android: Remove unused variables in droid_get_buffers_with_format()

2016-08-02 Thread Rob Herring
On Tue, Aug 2, 2016 at 6:07 AM, Tomasz Figa wrote: > Fix compilation warnings due to unused variables left after some earlier > code changes. > > Signed-off-by: Tomasz Figa Tested-by: Rob Herring ___ mesa-dev mailing list mesa-dev@lists.freedesktop.or

[Mesa-dev] [PATCH 1/7] winsys/amdgpu: query ME/PFP/CE firmware versions

2016-08-02 Thread Nicolai Hähnle
From: Nicolai Hähnle The radeon kernel module doesn't have the firmware query interface, so the corresponding values will remain 0. --- src/gallium/drivers/radeon/r600_pipe_common.c | 3 +++ src/gallium/drivers/radeon/radeon_winsys.h| 3 +++ src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c |

[Mesa-dev] [PATCH 4/7] radeonsi: transpose indirect/index draw dispatch

2016-08-02 Thread Nicolai Hähnle
From: Nicolai Hähnle This allows better code sharing for indirect draw calls. --- src/gallium/drivers/radeonsi/si_state_draw.c | 76 1 file changed, 31 insertions(+), 45 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/ra

[Mesa-dev] [PATCH 3/7] radeonsi: move index buffer calculations in si_emit_draw_packets up

2016-08-02 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_state_draw.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index afb9bbf..6b8ab9f 100644 --- a/src/ga

[Mesa-dev] [PATCH 6/7] radeonsi: program multi draw and indirect draw count parameters

2016-08-02 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_state_draw.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index a918f85..46dd5c7 100644 --- a/src/

Re: [Mesa-dev] [PATCH v2] swr: build swr with -fno-strict-aliasing

2016-08-02 Thread Matt Turner
Thanks! Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/3] RadeonSI GLSL "lit" tests

2016-08-02 Thread Nicolai Hähnle
On 02.08.2016 21:06, Marek Olšák wrote: On Tue, Aug 2, 2016 at 3:40 PM, Nicolai Hähnle wrote: On 31.07.2016 22:29, Marek Olšák wrote: Inspired by LLVM, I created a small test suite that looks like "lit" tests, except that the input is GLSL and it verifies asm. The motivation was to verify

Re: [Mesa-dev] [PATCH 0/3] RadeonSI GLSL "lit" tests

2016-08-02 Thread Marek Olšák
On Tue, Aug 2, 2016 at 3:40 PM, Nicolai Hähnle wrote: > On 31.07.2016 22:29, Marek Olšák wrote: >> >> Inspired by LLVM, I created a small test suite that looks like "lit" >> tests, except that the input is GLSL and it verifies asm. >> >> The motivation was to verify that we generate optimal code w

[Mesa-dev] [PATCH v2] swr: build swr with -fno-strict-aliasing

2016-08-02 Thread Tim Rowley
swr rasterizer contains numerous data transfers between vectors and ordinary C types. Fixing for strict aliasing will take time. --- src/gallium/drivers/swr/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/swr/Makefile.am b/src/gallium/drivers/swr/Makefile.am i

Re: [Mesa-dev] [PATCH 00/12] RadeonSI: Prevent IB submissions with illegal memory usage

2016-08-02 Thread Marek Olšák
On Tue, Aug 2, 2016 at 5:15 PM, Nicolai Hähnle wrote: > On 29.07.2016 23:42, Marek Olšák wrote: >> >> This series ensures that memory usage of gfx IBs is below the kernel- >> exposed memory limits in most cases. >> >> It's not possible to prevent CS ioctl failures completely because it >> depends

Re: [Mesa-dev] [PATCH] i965: Rework the unlit centroid workaround.

2016-08-02 Thread Jason Ekstrand
On Aug 2, 2016 12:36 PM, "Matt Turner" wrote: > > On Mon, Aug 1, 2016 at 8:59 PM, Kenneth Graunke wrote: > > Previously, for every input, we moved the dispatch mask to the flag > > register, then emitted two predicated PLN instructions, one with > > centroid barycentric coordinates (for normal pi

Re: [Mesa-dev] [PATCH] configure.ac/swr: build swr with -fno-strict-aliasing

2016-08-02 Thread Rowley, Timothy O
> On Aug 2, 2016, at 1:00 PM, Matt Turner wrote: > > On Tue, Aug 2, 2016 at 10:53 AM, Tim Rowley > wrote: >> swr rasterizer contains numerous data transfers between vectors >> and ordinary C types. Fixing for strict aliasing will take time. > > Oh, sorry! I forgot about swr. > >> --- >> con

Re: [Mesa-dev] [PATCH] configure.ac/swr: build swr with -fno-strict-aliasing

2016-08-02 Thread Matt Turner
On Tue, Aug 2, 2016 at 10:53 AM, Tim Rowley wrote: > swr rasterizer contains numerous data transfers between vectors > and ordinary C types. Fixing for strict aliasing will take time. Oh, sorry! I forgot about swr. > --- > configure.ac| 7 +++ > src/gallium/drivers/

Re: [Mesa-dev] [PATCH 09/21] i965/fs: Rework representation of fragment output locations in NIR.

2016-08-02 Thread Kenneth Graunke
On Sunday, July 31, 2016 12:22:40 PM PDT Francisco Jerez wrote: > Kenneth Graunke writes: > > > On Friday, July 22, 2016 8:59:03 PM PDT Francisco Jerez wrote: > >> The problem with the current approach is that driver output locations > >> are represented as a linear offset within the nir_outputs

[Mesa-dev] [PATCH] configure.ac: add llvm inteljitevents component if enabled

2016-08-02 Thread Tim Rowley
Needed to successfully link llvmpipe or swr when using shared llvm libs. --- configure.ac | 5 + 1 file changed, 5 insertions(+) diff --git a/configure.ac b/configure.ac index fb4a12a..edbc95b 100644 --- a/configure.ac +++ b/configure.ac @@ -2497,6 +2497,11 @@ dnl in LLVM_LIBS. if test "x$

[Mesa-dev] [PATCH] configure.ac/swr: build swr with -fno-strict-aliasing

2016-08-02 Thread Tim Rowley
swr rasterizer contains numerous data transfers between vectors and ordinary C types. Fixing for strict aliasing will take time. --- configure.ac| 7 +++ src/gallium/drivers/swr/Makefile.am | 1 + 2 files changed, 8 insertions(+) diff --git a/configure.ac b/configure.

Re: [Mesa-dev] [PATCH] i965: Rework the unlit centroid workaround.

2016-08-02 Thread Matt Turner
On Mon, Aug 1, 2016 at 8:59 PM, Kenneth Graunke wrote: > Previously, for every input, we moved the dispatch mask to the flag > register, then emitted two predicated PLN instructions, one with > centroid barycentric coordinates (for normal pixels), and one with > pixel barycentric coordinates (for

Re: [Mesa-dev] [PATCH v2 3/7] egl/android: Fix support for pbuffers (v2)

2016-08-02 Thread Rob Herring
On Tue, Aug 2, 2016 at 6:07 AM, Tomasz Figa wrote: > From: Nicolas Boichat > > Existing image loader code supports creating images only for window > surfaces. Moreover droid_create_surface() passes wrong surface type to > dri2_get_dri_config(), resulting in incorrect configs being returned for >

Re: [Mesa-dev] [PATCH 12/12] gallium/radeon/winsyses: decrease max_alloc_size to 1/3 of largest heap

2016-08-02 Thread Christian König
Am 02.08.2016 um 14:57 schrieb Alex Deucher: On Tue, Aug 2, 2016 at 4:55 AM, Marek Olšák wrote: On Tue, Aug 2, 2016 at 3:13 AM, Michel Dänzer wrote: On 01.08.2016 16:35, Michel Dänzer wrote: On 30.07.2016 06:42, Marek Olšák wrote: From: Marek Olšák This is controversial, but I don't see a

[Mesa-dev] [PATCH 2/2] anv/blit2d: Add support for RGB destinations

2016-08-02 Thread Jason Ekstrand
This fixes 104 of the new image_clearing and copy_and_blit Vulkan CTS tests. Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/intel/vulkan/anv_meta_blit2d.c | 210 - 1 file changed, 208 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_meta_bli

[Mesa-dev] [PATCH 1/2] anv/blit2d: Add a format parameter to bind_dst and create_iview

2016-08-02 Thread Jason Ekstrand
Signed-off-by: Jasosn Ekstrand Cc: "12.0" --- src/intel/vulkan/anv_meta_blit2d.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_meta_blit2d.c b/src/intel/vulkan/anv_meta_blit2d.c index 9d4c2fc..30bc6ed 100644 --- a/src/intel/vulkan/anv_

Re: [Mesa-dev] [PATCH] ast: Updated AST_NUM_OPERATORS for coherence with ast_operators

2016-08-02 Thread Andres Gomez
On Tue, 2016-08-02 at 17:04 +0100, Eric Engestrom wrote: > On Tue, Aug 02, 2016 at 12:20:54PM +0300, Andres Gomez wrote: [snip] > > I'm not sure I'm understanding what you mean. > > > > If you mean to remove the #define and add the value as and additional > > element to the enum, the existence o

[Mesa-dev] [PATCH mesa] glx/dri3: remove never-used field

2016-08-02 Thread Eric Engestrom
This field was added in 2d94601582e4f0fcaf8c ("Add DRI3+Present loader"), which was a v2. Guessing it was used in v1 and Keith forgot to remove it in v2. Signed-off-by: Eric Engestrom --- Fair warning: This patch will conflict with Jan Ziak's "[PATCH] dri: use 'bool' instead of 'int' for boolean

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead of 'int' for boolean variables

2016-08-02 Thread Eric Engestrom
On Tue, Aug 02, 2016 at 05:32:16PM +0200, Jan Ziak wrote: > Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> Much better with the s/0/false/;s/1/true/ :) Reviewed-by: Eric Engestrom > --- > src/egl/drivers/dri2/egl_dri2.h | 19 ++- > src/egl/

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

2016-08-02 Thread Eric Engestrom
On Mon, Aug 01, 2016 at 03:43:17PM +0200, ⚛ wrote: > On Mon, Aug 1, 2016 at 2:46 PM, Eric Engestrom > wrote: > > On Sun, Jul 31, 2016 at 05:49:02PM +0200, Jan Ziak wrote: > >> Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> > > > > This is a good change, and with a coup

[Mesa-dev] [PATCH] dir-locals.el: show-trailing-whitespace and whitespace support

2016-08-02 Thread Andres Gomez
Signed-off-by: Andres Gomez --- .dir-locals.el | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.dir-locals.el b/.dir-locals.el index 4b53931..9c89a63 100644 --- a/.dir-locals.el +++ b/.dir-locals.el @@ -1,4 +1,5 @@ -((prog-mode +((nil . ((show-trailing-whitespace . t)

Re: [Mesa-dev] [PATCH] ast: Updated AST_NUM_OPERATORS for coherence with ast_operators

2016-08-02 Thread Eric Engestrom
On Tue, Aug 02, 2016 at 12:20:54PM +0300, Andres Gomez wrote: > On Mon, 2016-08-01 at 14:02 +0100, Eric Engestrom wrote: > > On Sun, Jul 31, 2016 at 07:07:34PM +0300, Andres Gomez wrote: > > [snip] > > > > diff --git a/src/compiler/glsl/ast.h b/src/compiler/glsl/ast.h > > > index 157895d..89f531c

Re: [Mesa-dev] [PATCH] vbo: fix format string compiler warning for 32-bit machines

2016-08-02 Thread Brian Paul
On 08/02/2016 08:40 AM, Jan Ziak wrote: Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- src/mesa/vbo/vbo_exec_array.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c in

Re: [Mesa-dev] [PATCH] vbo: fix debug message format string in case of 32-bit machines

2016-08-02 Thread Brian Paul
On 08/02/2016 08:45 AM, ⚛ wrote: On Tue, Aug 2, 2016 at 4:13 PM, Brian Paul wrote: In bufferobj.c, it looks like we're just using %d or %s and casting the arguments to int. But in other places, we're using %ld and casting to long. That's not going to accurately report 64-bit values, but I gues

[Mesa-dev] [PATCH] dri: use 'bool' instead of 'int' for boolean variables

2016-08-02 Thread Jan Ziak
Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- src/egl/drivers/dri2/egl_dri2.h | 19 ++- src/egl/drivers/dri2/platform_drm.c | 6 +++--- src/egl/drivers/dri2/platform_wayland.c | 20 ++-- src/egl/drivers/dri2/platf

Re: [Mesa-dev] [PATCH 00/12] RadeonSI: Prevent IB submissions with illegal memory usage

2016-08-02 Thread Nicolai Hähnle
On 29.07.2016 23:42, Marek Olšák wrote: This series ensures that memory usage of gfx IBs is below the kernel- exposed memory limits in most cases. It's not possible to prevent CS ioctl failures completely because it depends on whether continuous free space for all buffers is available, i.e. it d

Re: [Mesa-dev] [PATCH] vbo: fix debug message format string in case of 32-bit machines

2016-08-02 Thread
On Tue, Aug 2, 2016 at 4:13 PM, Brian Paul wrote: > In bufferobj.c, it looks like we're just using %d or %s and casting the > arguments to int. But in other places, we're using %ld and casting to long. > That's not going to accurately report 64-bit values, but I guess that hasn't > been a concern

Re: [Mesa-dev] [PATCH 12/12] gallium/radeon/winsyses: decrease max_alloc_size to 1/3 of largest heap

2016-08-02 Thread Nicolai Hähnle
On 02.08.2016 10:55, Marek Olšák wrote: On Tue, Aug 2, 2016 at 3:13 AM, Michel Dänzer wrote: On 01.08.2016 16:35, Michel Dänzer wrote: On 30.07.2016 06:42, Marek Olšák wrote: From: Marek Olšák This is controversial, but I don't see a better way out of this. Tonga has 2 GB of VRAM and 2 GB

[Mesa-dev] [PATCH] vbo: fix format string compiler warning for 32-bit machines

2016-08-02 Thread Jan Ziak
Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- src/mesa/vbo/vbo_exec_array.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index f371890..ae6a3da 100644 --- a/src/mesa/v

Re: [Mesa-dev] [PATCH 08/12] gallium/radeon/winsyses: print CS submission error number

2016-08-02 Thread Nicolai Hähnle
On 29.07.2016 23:42, Marek Olšák wrote: From: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 2 +- src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/wins

Re: [Mesa-dev] [PATCH 7/8] winsys/radeon: implement cs_get_next_fence

2016-08-02 Thread Nicolai Hähnle
Patches 1-7: Reviewed-by: Nicolai Hähnle On 02.08.2016 12:27, Marek Olšák wrote: From: Marek Olšák --- src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 30 +-- src/gallium/winsys/radeon/drm/radeon_drm_cs.h | 1 + 2 files changed, 29 insertions(+), 2 deletions(-) dif

Re: [Mesa-dev] [PATCH 8/8] gallium/radeon: use unflushed fences for deferred flushes

2016-08-02 Thread Nicolai Hähnle
On 02.08.2016 12:27, Marek Olšák wrote: From: Marek Olšák +23% Bioshock Infinite performance. --- src/gallium/drivers/radeon/r600_pipe_common.c | 45 ++- 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/g

Re: [Mesa-dev] [PATCH 0/3] Destroy Present event contexts

2016-08-02 Thread Leo Liu
On 08/01/2016 10:20 PM, Michel Dänzer wrote: On 28.07.2016 18:34, Michel Dänzer wrote: Running XTS (the X test suite) on Xephyr using glamor running on Xorg, I stumbled upon an issue: * XTS causes Xephyr to keep resetting and starting new server generations * glamor creates a new GLX context

Re: [Mesa-dev] [PATCH] vbo: fix debug message format string in case of 32-bit machines

2016-08-02 Thread Brian Paul
On 08/01/2016 04:35 PM, Jan Ziak wrote: Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- src/mesa/vbo/vbo_exec_array.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index 90f1

Re: [Mesa-dev] [PATCH] radeonsi: skip unnecessary si_update_shaders calls

2016-08-02 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 02.08.2016 12:34, Marek Olšák wrote: From: Marek Olšák Small decrease in draw call overhead. --- src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_state.c | 6 ++ src/gallium/drivers/radeonsi/si_state_draw.c

Re: [Mesa-dev] [PATCH 3/3] radeonsi: print the command line to VM fault reports

2016-08-02 Thread Nicolai Hähnle
Patch 2 & 3: Reviewed-by: Nicolai Hähnle On 30.07.2016 17:22, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_debug.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_debug.c b/src/gallium/drivers/radeonsi/si_debug.c index e030

Re: [Mesa-dev] [PATCH 2/2] radeonsi: print the command line to VM fault reports (v2)

2016-08-02 Thread Nicolai Hähnle
Obviously, the R-b applies to this rebased series as well. Nicolai On 01.08.2016 23:55, Marek Olšák wrote: From: Marek Olšák v2: rebase on top of Brian's commit --- src/gallium/drivers/radeonsi/si_debug.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

2016-08-02 Thread Nicolai Hähnle
On 01.08.2016 15:21, Jan Ziak wrote: Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- src/egl/drivers/dri2/egl_dri2.h | 19 ++- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 3 ++- src/glx/dri3_priv.h | 5 +++-- src/l

Re: [Mesa-dev] [PATCH] ddebug: don't use fmemopen on non-Linux OS

2016-08-02 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 31.07.2016 22:57, Marek Olšák wrote: From: Marek Olšák Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97140 --- src/gallium/drivers/ddebug/dd_draw.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/ddebug/dd_draw.c b/src/gal

Re: [Mesa-dev] [PATCH 4/4] radeonsi: don't set the last parameter component of llvm.AMDGPU.cube

2016-08-02 Thread Nicolai Hähnle
The series is Reviewed-by: Nicolai Hähnle On 31.07.2016 22:34, Marek Olšák wrote: From: Marek Olšák LLVM doesn't use it. --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_s

Re: [Mesa-dev] [PATCH 0/3] RadeonSI GLSL "lit" tests

2016-08-02 Thread Nicolai Hähnle
On 31.07.2016 22:29, Marek Olšák wrote: Inspired by LLVM, I created a small test suite that looks like "lit" tests, except that the input is GLSL and it verifies asm. The motivation was to verify that we generate optimal code when starting from GLSL. [PATCH 1/3] radeonsi: add environment vari

Re: [Mesa-dev] [PATCH] nir: fix validation message

2016-08-02 Thread Jason Ekstrand
On Aug 2, 2016 2:46 AM, "Timothy Arceri" wrote: > > Looks like a copy and paste error from f752effa087 Agreed. Rb > Cc: Jason Ekstrand > --- > src/compiler/nir/nir_validate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/compiler/nir/nir_validate.c b/src/comp

Re: [Mesa-dev] [PATCH 12/12] gallium/radeon/winsyses: decrease max_alloc_size to 1/3 of largest heap

2016-08-02 Thread Alex Deucher
On Tue, Aug 2, 2016 at 4:55 AM, Marek Olšák wrote: > On Tue, Aug 2, 2016 at 3:13 AM, Michel Dänzer wrote: >> On 01.08.2016 16:35, Michel Dänzer wrote: >>> On 30.07.2016 06:42, Marek Olšák wrote: From: Marek Olšák This is controversial, but I don't see a better way out of this. >>>

[Mesa-dev] [PATCH v2 5/7] egl/android: Make get_fourcc() accept HAL formats

2016-08-02 Thread Tomasz Figa
There are DRI_IMAGE_FOURCC macros, for which there are no corresponding DRI_IMAGE_FORMAT macros. To support such formats we need to make the lookup function take the native format directly. As a side effect, it simplifies all existing calls to this function, because they all called get_format() fir

[Mesa-dev] [PATCH v2 4/7] egl/android: Refactor image creation to separate flink and prime paths (v2)

2016-08-02 Thread Tomasz Figa
This patch splits current dri2_create_image_android_native_buffer() into main entry point and two additional functions, one for creating an image from flink name and one for handling prime FDs using the generic DMA-buf path. This makes the code cleaner and also prepares for disabling flink path mor

[Mesa-dev] [PATCH v2 1/7] egl/android: Remove unused variables in droid_get_buffers_with_format()

2016-08-02 Thread Tomasz Figa
Fix compilation warnings due to unused variables left after some earlier code changes. Signed-off-by: Tomasz Figa --- src/egl/drivers/dri2/platform_android.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c i

[Mesa-dev] [PATCH v2 3/7] egl/android: Fix support for pbuffers (v2)

2016-08-02 Thread Tomasz Figa
From: Nicolas Boichat Existing image loader code supports creating images only for window surfaces. Moreover droid_create_surface() passes wrong surface type to dri2_get_dri_config(), resulting in incorrect configs being returned for pbuffers. This patch fixes these issues. In addition, the conf

[Mesa-dev] [PATCH v2 6/7] egl/android: Add support for YV12 pixel format (v2)

2016-08-02 Thread Tomasz Figa
This patch adds support for YV12 pixel format to the Android platform backend. Only creating EGL images is supported, it is not added to the list of available visuals. v2: Use const array defined just for YV12 instead of trying to be overly generic. Signed-off-by: Tomasz Figa Signed-off-by:

[Mesa-dev] [PATCH v2 7/7] egl/android: Make drm_gralloc headers optional (v2)

2016-08-02 Thread Tomasz Figa
Make the code at least compile when being built without drm_gralloc headers. v2: Replaced #ifdefs with stubs for gralloc_drm_get_gem_handle() and GRALLOC_MODULE_PERFORM_GET_DRM_FD. Removed explicit render node probing code. Signed-off-by: Tomasz Figa --- src/egl/Android.mk

[Mesa-dev] [PATCH v2 2/7] egl/android: Respect buffer mask in droid_image_get_buffers (v2)

2016-08-02 Thread Tomasz Figa
Drivers can request different set of buffers depending on the buffer mask they pass to the get_buffers callback. This patch makes droid_image_get_buffers() respect this mask. v2: Return error only in case of real error condition and ignore requests of unavailable buffers. Signed-off-by: Tomas

[Mesa-dev] [PATCH v2 0/7] egl/android: Improve the Android EGL backend

2016-08-02 Thread Tomasz Figa
Hi, This series is a collection of various fixes and extensions we came up with during our attempt to use Mesa for Android. Fixes included in this series: - fixed multiple issues with handling pbuffers in the backend, - made the implementation of DRI image loader .getBuffers callback conform

[Mesa-dev] [PATCH v2 1/4] gallium/winsys/kms: Fix double refcount when importing from prime FD (v2)

2016-08-02 Thread Tomasz Figa
Currently the code creates a display target struct with refcount field initialized to 1 and then the caller again increments it, leading to a leaked reference. Let's remove the unnecessary increment. v2: Split from one big patch into four fixing one thing at a time. Signed-off-by: Tomasz Figa CC

[Mesa-dev] [PATCH v2 0/4] gallium/winsys/kms: Fix issues with prime import

2016-08-02 Thread Tomasz Figa
Current prime import code in kms-dri Gallium winsys backend has several issues: - It leaks imported buffers, because of duplicate reference count increment at import time. - It does not check whether an already imported (or local) buffer is not being imported, which is problematic because p

[Mesa-dev] [PATCH v2 4/4] gallium/winsys/kms: Look up the GEM handle after importing a prime FD (v2)

2016-08-02 Thread Tomasz Figa
drmPrimeHandleToFD() will return the same GEM handle every time the same buffer is imported, even from a different prime FD. Since GEM handles are not reference counted, we need to make sure that each GEM handle is referenced only by one display target struct, by looking it up in kms_sw->bo_list fi

[Mesa-dev] [PATCH v2 2/4] gallium/winsys/kms: Fully initialize kms_sw_dt at prime import time (v2)

2016-08-02 Thread Tomasz Figa
Currently kms_sw_displaytarget_add_from_prime() allocates the struct and fills in only some of the fields, resulting in a half-baked struct that needs to be further completed by the caller. To make this a bit more consistent, pass width, height and stride to this function and fill in everything the

[Mesa-dev] [PATCH v2 3/4] gallium/winsys/kms: Move display target handle lookup to separate function (v2)

2016-08-02 Thread Tomasz Figa
As a preparation to use the lookup in more than once place, move the code that looks up given KMS/GEM handle to a separate function. This change should not introduce any functional changes. v2: Split into separate patch. Move lookup code into separate function. Signed-off-by: Tomasz Figa CC:

[Mesa-dev] [PATCH] radeonsi: skip unnecessary si_update_shaders calls

2016-08-02 Thread Marek Olšák
From: Marek Olšák Small decrease in draw call overhead. --- src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_state.c | 6 ++ src/gallium/drivers/radeonsi/si_state_draw.c| 20 +--- src/gallium/drivers/radeonsi/si_state_shader

Re: [Mesa-dev] [PATCH 0/8] RadeonSI: Unflushed fences for better Bioshock performance

2016-08-02 Thread Marek Olšák
On Tue, Aug 2, 2016 at 12:27 PM, Marek Olšák wrote: > Hi, > > Most interested people already know what this is, so I'm just gonna share the > performance numbers here. > > This series makes Bioshock Infinite 23% faster. Along with the CPU overhead > optimizations that are in the master branch al

[Mesa-dev] [PATCH 5/8] gallium/radeon: add cs_get_next_fence winsys callback

2016-08-02 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/radeon_winsys.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_winsys.h b/src/gallium/drivers/radeon/radeon_winsys.h index 3be4738..e7787d3 100644 --- a/src/gallium/drivers/radeon/radeon_winsys.h +++

  1   2   >