Re: [Mesa-dev] [PATCH 2/2] i965/fs: indirect addressing with doubles is not supported in CHV/BSW

2016-06-16 Thread Kenneth Graunke
On Wednesday, June 15, 2016 9:25:45 AM PDT Samuel Iglesias Gonsálvez wrote: > From the Cherryview's PRM, Volume 7, 3D Media GPGPU Engine, Register Region > Restrictions, page 844: > > "When source or destination datatype is 64b or operation is integer DWord >multiply, indirect addressing mus

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Fix single-precision to double-precision conversions for CHV/BSW

2016-06-16 Thread Kenneth Graunke
On Wednesday, June 15, 2016 9:25:44 AM PDT Samuel Iglesias Gonsálvez wrote: > From: Iago Toral Quiroga > > From the Cherryview PRM, Volume 7, 3D Media GPGPU Engine, > Register Region Restrictions: > >"When source or destination is 64b (...), regioning in Align1 > must follow these rules:

[Mesa-dev] [PATCH] mesa: remove remaining tabs in api_validate.c

2016-06-16 Thread Timothy Arceri
--- src/mesa/main/api_validate.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c index c7625c3..4ef86b8 100644 --- a/src/mesa/main/api_validate.c +++ b/src/mesa/main/api_validate.c @@ -54,7 +54

Re: [Mesa-dev] [PATCH 2/2] i965: Support "unlimited" compute shader scratch space.

2016-06-16 Thread Kenneth Graunke
On Thursday, June 16, 2016 8:16:43 PM PDT Ian Romanick wrote: > How well tested is this? I suspect nothing hits the 2Mb limit, but do > we have any tests or apps that even hit the 12k limit? I forgot to update the commit message to include the info from the bug: "Fixes Piglit's spec/arb_compute_

Re: [Mesa-dev] [PATCH 1/2] i965: Reorganize prog_data->total_scratch code a bit.

2016-06-16 Thread Ian Romanick
I like this organization much better. This patch is Reviewed-by: Ian Romanick On 06/16/2016 07:58 PM, Kenneth Graunke wrote: > Cc: "12.0" > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 35 +++ > 1 file changed, 19 insertions(+)

Re: [Mesa-dev] [PATCH 2/2] i965: Support "unlimited" compute shader scratch space.

2016-06-16 Thread Ian Romanick
How well tested is this? I suspect nothing hits the 2Mb limit, but do we have any tests or apps that even hit the 12k limit? On 06/16/2016 07:58 PM, Kenneth Graunke wrote: > Ivybridge and Baytrail have a pretty harsh limit of 12kB scratch space > per thread. However, we can exceed this limit wit

Re: [Mesa-dev] [PATCH] glcpp: Only expose ARB_enhanced_layouts if it's supported.

2016-06-16 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 06/16/2016 06:15 PM, Dylan Baker wrote: > This fixes the following piglit tests: > spec/arb_enhanced_layouts/preprocessor/disabled-defined-core.* > > Signed-off-by: Dylan Baker > --- > src/compiler/glsl/glcpp/glcpp-parse.y | 4 +++- > 1 file changed,

Re: [Mesa-dev] [PATCH v2 04/11] glsl: Pack integer and double varyings as flat even if interpolation mode is none

2016-06-16 Thread Ian Romanick
On 06/16/2016 12:07 PM, Ian Romanick wrote: > From: Ian Romanick > > v2: Also update varying_matches::compute_packing_class(). Suggested by > Timothy Arceri. > > Signed-off-by: Ian Romanick > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96358 > Cc: "12.0" > Cc: Gregory Hainaut > Cc

[Mesa-dev] [PATCH 1/2] i965: Reorganize prog_data->total_scratch code a bit.

2016-06-16 Thread Kenneth Graunke
Cc: "12.0" Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs.cpp | 35 +++ 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 8774f25..cadf905 100644

[Mesa-dev] [PATCH 2/2] i965: Support "unlimited" compute shader scratch space.

2016-06-16 Thread Kenneth Graunke
Ivybridge and Baytrail have a pretty harsh limit of 12kB scratch space per thread. However, we can exceed this limit with some clever tricks and gain effectively unlimited scratch space. Later platforms have a 2MB limit, which is much more reasonable, but we may as well apply the same trick there

Re: [Mesa-dev] Mesa 11.2.2 and Mesa 12.0.0rc3 GLES 3.1 issues with i965 driver

2016-06-16 Thread Ian Romanick
On 06/16/2016 06:36 AM, Mike Gorchak wrote: > Hi, > >> You're supposed to get at these functions with eglGetProcAddress() and > such > > A'm afraid EGL v1.4 spec forbids obtaining core functions through > eglGetProcAddress(), they should be visible at dynamic linker level. Unless you have the EG

Re: [Mesa-dev] Mesa 11.2.2 and Mesa 12.0.0rc3 GLES 3.1 issues with i965 driver

2016-06-16 Thread Ian Romanick
On 06/15/2016 11:23 AM, Mike Gorchak wrote: > Hello, > > Just found that latest Mesa 11.2.2 and 12.0.0rc3 exposes version 3.1 of > OpenGL ES instead of 3.0 if i965 DRI driver is used on Intel Gen8 > (Broadwell) or Gen9 (AppolloLake/Broxton) hardware. > > At the same time some of GLES 3.1 function

[Mesa-dev] [PATCH] swr: push/pop DEBUG macro around llvm includes

2016-06-16 Thread Tim Rowley
llvm redefines DEBUG; adding push/pop prevents a undefined reference to debug_refcnt_state in llvm-3.7+. --- src/gallium/drivers/swr/swr_shader.cpp | 9 ++--- src/gallium/drivers/swr/swr_state.cpp | 6 +- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/

[Mesa-dev] [PATCH] glcpp: Only expose ARB_enhanced_layouts if it's supported.

2016-06-16 Thread Dylan Baker
This fixes the following piglit tests: spec/arb_enhanced_layouts/preprocessor/disabled-defined-core.* Signed-off-by: Dylan Baker --- src/compiler/glsl/glcpp/glcpp-parse.y | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/glcpp/glcpp-parse.y b/src/compiler/

Re: [Mesa-dev] Trouble with missing git_sha1.h when building from a fresh tree

2016-06-16 Thread Emil Velikov
On 16 June 2016 at 21:14, Haixia Shi wrote: > Emil > > I looked at commit 3689ef32 which started the problem, and it seems that > patch removed the line "touch git_sha1.h.tmp". Previously my workflow was > "working" because the touch command ensures there's always going to be an > empty header fil

Re: [Mesa-dev] Trouble with missing git_sha1.h when building from a fresh tree

2016-06-16 Thread Haixia Shi
Emil I looked at commit 3689ef32 which started the problem, and it seems that patch removed the line "touch git_sha1.h.tmp". Previously my workflow was "working" because the touch command ensures there's always going to be an empty header file. Was this intentional? For the new git_sha1.h rules,

Re: [Mesa-dev] virgl and vc4 problem on Android

2016-06-16 Thread Emil Velikov
On 16 June 2016 at 17:56, Rob Herring wrote: > On Thu, Jun 16, 2016 at 11:44 AM, Rob Clark wrote: >> On Wed, Jun 15, 2016 at 8:34 PM, Rob Herring wrote: >>> In the process of adding RGBX (XB24) format to mesa for Android, I >>> started seeing a new problem that makes the UI stop updating. It >>>

[Mesa-dev] [PATCH] swr: switch from overriding -march to selecting features

2016-06-16 Thread Tim Rowley
--- configure.ac| 11 +++ src/gallium/drivers/swr/Makefile.am | 4 ++-- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index c492e15..cc9bc47 100644 --- a/configure.ac +++ b/configure.ac @@ -2400,8 +2400,8 @@ if test -n "

Re: [Mesa-dev] Trouble with missing git_sha1.h when building from a fresh tree

2016-06-16 Thread Emil Velikov
On 16 June 2016 at 20:47, Emil Velikov wrote: > On 16 June 2016 at 20:42, Haixia Shi wrote: >> Bisect shows the problem started at commit >> 3689ef32afdafbb030069e560aac0e563fc29048 >> Author: Emil Velikov >> Date: Mon May 30 12:32:05 2016 +0100 >> >> automake: rework the git_sha1.h rule,

Re: [Mesa-dev] virgl and vc4 problem on Android

2016-06-16 Thread Rob Herring
On Thu, Jun 16, 2016 at 2:20 PM, Rob Clark wrote: > On Thu, Jun 16, 2016 at 2:57 PM, Rob Herring wrote: >> On Thu, Jun 16, 2016 at 12:09 PM, Rob Clark wrote: >>> On Thu, Jun 16, 2016 at 12:56 PM, Rob Herring wrote: On Thu, Jun 16, 2016 at 11:44 AM, Rob Clark wrote: > On Wed, Jun 15, 2

Re: [Mesa-dev] Trouble with missing git_sha1.h when building from a fresh tree

2016-06-16 Thread Emil Velikov
On 16 June 2016 at 20:42, Haixia Shi wrote: > Bisect shows the problem started at commit > 3689ef32afdafbb030069e560aac0e563fc29048 > Author: Emil Velikov > Date: Mon May 30 12:32:05 2016 +0100 > > automake: rework the git_sha1.h rule, include in tarball > > As we'll need the file in th

Re: [Mesa-dev] Trouble with missing git_sha1.h when building from a fresh tree

2016-06-16 Thread Emil Velikov
Hi Haixia Shi, On 16 June 2016 at 19:46, Haixia Shi wrote: > Posting a question in case someone already know the issue. > > I'm observing "missing git_sha1.h" errors sometime after Emil's git_sha1.h > patches by May 31st. This is not fixed at TOT with the latest patches on > Makefile.am. > > The

Re: [Mesa-dev] Trouble with missing git_sha1.h when building from a fresh tree

2016-06-16 Thread Haixia Shi
Bisect shows the problem started at commit 3689ef32afdafbb030069e560aac0e563fc29048 Author: Emil Velikov Date: Mon May 30 12:32:05 2016 +0100 automake: rework the git_sha1.h rule, include in tarball As we'll need the file in the release tarball, rework the rule so that the file is

Re: [Mesa-dev] [PATCH 01/64] i965: Drop Max3DTextureLevels to 512 on Sandy Bridge and prior

2016-06-16 Thread Ian Romanick
On 06/16/2016 11:50 AM, Jason Ekstrand wrote: > > > On Thu, Jun 16, 2016 at 11:43 AM, Ian Romanick > wrote: > > On 06/11/2016 09:02 AM, Jason Ekstrand wrote: > > The RenderTargetViewExtent field of RENDER_SURFACE_STATE is supposed to > be > > set to the

Re: [Mesa-dev] virgl and vc4 problem on Android

2016-06-16 Thread Rob Clark
On Thu, Jun 16, 2016 at 2:57 PM, Rob Herring wrote: > On Thu, Jun 16, 2016 at 12:09 PM, Rob Clark wrote: >> On Thu, Jun 16, 2016 at 12:56 PM, Rob Herring wrote: >>> On Thu, Jun 16, 2016 at 11:44 AM, Rob Clark wrote: On Wed, Jun 15, 2016 at 8:34 PM, Rob Herring wrote: > In the process

Re: [Mesa-dev] [Mesa-stable] [PATCH] swr: fix -march flag for AVX

2016-06-16 Thread Chuck Atkins
After some architecture testing, it looks like we can drop the march options and just enable the specific instruction sets via: libswrAVX: -mavx libswrAVX2: -mavx2 -mfma -mbmi2 -mf16c The benefit of course is that with these flags swr works on AMD cpu's with AVX and AVX2 instructions enabled. Th

Re: [Mesa-dev] [PATCH v2 03/11] mesa: Strip arrayness from interface block names in some IO validation

2016-06-16 Thread Ilia Mirkin
On Thu, Jun 16, 2016 at 3:06 PM, Ian Romanick wrote: > From: Ian Romanick > > Outputs from the vertex shader need to be able to match > per-vertex-arrayed inputs of later stages. Acomplish this by stripping > one level of arrayness from the names and types of outputs going to a > per-vertex-arra

[Mesa-dev] [PATCH v2 04/11] glsl: Pack integer and double varyings as flat even if interpolation mode is none

2016-06-16 Thread Ian Romanick
From: Ian Romanick v2: Also update varying_matches::compute_packing_class(). Suggested by Timothy Arceri. Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96358 Cc: "12.0" Cc: Gregory Hainaut Cc: Ilia Mirkin --- src/compiler/glsl/ir.h

[Mesa-dev] [PATCH v2 03/11] mesa: Strip arrayness from interface block names in some IO validation

2016-06-16 Thread Ian Romanick
From: Ian Romanick Outputs from the vertex shader need to be able to match per-vertex-arrayed inputs of later stages. Acomplish this by stripping one level of arrayness from the names and types of outputs going to a per-vertex-arrayed stage. v2: Add missing checks for TESS_EVAL->GEOMETRY. Noti

Re: [Mesa-dev] virgl and vc4 problem on Android

2016-06-16 Thread Rob Herring
On Thu, Jun 16, 2016 at 12:09 PM, Rob Clark wrote: > On Thu, Jun 16, 2016 at 12:56 PM, Rob Herring wrote: >> On Thu, Jun 16, 2016 at 11:44 AM, Rob Clark wrote: >>> On Wed, Jun 15, 2016 at 8:34 PM, Rob Herring wrote: In the process of adding RGBX (XB24) format to mesa for Android, I st

Re: [Mesa-dev] [PATCH 21/64] isl/state: Set the IntegerSurfaceFormat bit on Haswell

2016-06-16 Thread Jason Ekstrand
On Thu, Jun 16, 2016 at 11:26 AM, Chad Versace wrote: > On Sat 11 Jun 2016, Jason Ekstrand wrote: > > This fixes 688 Vulkan CTS tests on Haswell. > > Whoo! Bugfixes! > > The PRM states that, on HSW, you also need to program > SAMPLER_BORDER_COLOR_STATE correctly for integer formats. I suspect tha

Re: [Mesa-dev] [PATCH 01/64] i965: Drop Max3DTextureLevels to 512 on Sandy Bridge and prior

2016-06-16 Thread Jason Ekstrand
On Thu, Jun 16, 2016 at 11:43 AM, Ian Romanick wrote: > On 06/11/2016 09:02 AM, Jason Ekstrand wrote: > > The RenderTargetViewExtent field of RENDER_SURFACE_STATE is supposed to > be > > set to the depth of a 3-D texture when rendering. Unfortunatley, that >

[Mesa-dev] Trouble with missing git_sha1.h when building from a fresh tree

2016-06-16 Thread Haixia Shi
Posting a question in case someone already know the issue. I'm observing "missing git_sha1.h" errors sometime after Emil's git_sha1.h patches by May 31st. This is not fixed at TOT with the latest patches on Makefile.am. The problem only happens if src/git_sha1.h doesn't exist already. I just need

Re: [Mesa-dev] [PATCH 04/64] i965/fs: Use a default Y coordinate of 0 for TXF on gen9+

2016-06-16 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 06/11/2016 09:02 AM, Jason Ekstrand wrote: > Previously, we were incrementing length but not actually putting anything > in the Y coordinate. This meant that 1-D TXF operations had a garbage > array index. If the surface is emitted as 1-D non-array, t

Re: [Mesa-dev] [PATCH 01/64] i965: Drop Max3DTextureLevels to 512 on Sandy Bridge and prior

2016-06-16 Thread Ian Romanick
On 06/11/2016 09:02 AM, Jason Ekstrand wrote: > The RenderTargetViewExtent field of RENDER_SURFACE_STATE is supposed to be > set to the depth of a 3-D texture when rendering. Unfortunatley, that Unfortunately > field is only 9 bits on Sandy Bri

Re: [Mesa-dev] [PATCH 21/64] isl/state: Set the IntegerSurfaceFormat bit on Haswell

2016-06-16 Thread Chad Versace
On Sat 11 Jun 2016, Jason Ekstrand wrote: > This fixes 688 Vulkan CTS tests on Haswell. Whoo! Bugfixes! The PRM states that, on HSW, you also need to program SAMPLER_BORDER_COLOR_STATE correctly for integer formats. I suspect that the CTS tests may be passing by luck. See this encouraging commen

Re: [Mesa-dev] [PATCH 17/64] isl/state: Refactor the setup of clear colors

2016-06-16 Thread Chad Versace
On Thu 16 Jun 2016, Jason Ekstrand wrote: > On Thu, Jun 16, 2016 at 11:05 AM, Chad Versace > wrote: > > > On Sat 11 Jun 2016, Jason Ekstrand wrote: > > > This commit switches clear colors to use #if's instead of a C if. This > > > lets us properly handle SNB where the clear color field doesn't e

[Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

2016-06-16 Thread Nayan Deshmukh
v2: fix a typo and add a newline to code Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c | 53 +--- src/gallium/state_trackers/vdpau/vdpau_private.h | 6 +++ 2 files changed, 54 insertions(+), 5 deletions(-) diff --git a/src/gallium/state_

Re: [Mesa-dev] [PATCH 20/64] isl/format: Mark R9G9B9E5 as containing 9-bit unsigned float channels

2016-06-16 Thread Chad Versace
Patches 18,19,20 are Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 17/64] isl/state: Refactor the setup of clear colors

2016-06-16 Thread Jason Ekstrand
On Thu, Jun 16, 2016 at 11:05 AM, Chad Versace wrote: > On Sat 11 Jun 2016, Jason Ekstrand wrote: > > This commit switches clear colors to use #if's instead of a C if. This > > lets us properly handle SNB where the clear color field doesn't exist. > > --- > > src/intel/isl/isl_surface_state.c |

Re: [Mesa-dev] [PATCH 17/64] isl/state: Refactor the setup of clear colors

2016-06-16 Thread Chad Versace
On Sat 11 Jun 2016, Jason Ekstrand wrote: > This commit switches clear colors to use #if's instead of a C if. This > lets us properly handle SNB where the clear color field doesn't exist. > --- > src/intel/isl/isl_surface_state.c | 44 > +++ > 1 file changed,

Re: [Mesa-dev] [PATCH 16/64] isl/state: Refactor the per-gen isl_to_gen_h/valign tables

2016-06-16 Thread Chad Versace
On Sat 11 Jun 2016, Jason Ekstrand wrote: > This moves the #if's around so that halign and valign have different sets > of #if conditions. This also prepares us for SNB because isl_to_gen_halign > is not defined at all on gen6. > --- > src/intel/isl/isl_surface_state.c | 14 -- > 1 fi

Re: [Mesa-dev] [PATCH 14/64] isl/state: Put pitch calculations together

2016-06-16 Thread Chad Versace
On Sat 11 Jun 2016, Jason Ekstrand wrote: > --- > src/intel/isl/isl_surface_state.c | 42 > +++ > 1 file changed, 20 insertions(+), 22 deletions(-) Patch 14 is Reviewed-by: Chad Versace ___ mesa-dev mailing list me

Re: [Mesa-dev] [PATCH 15/64] isl/state: Return an extent3d from the halign/valign helper

2016-06-16 Thread Chad Versace
On Thu 16 Jun 2016, Jason Ekstrand wrote: > On Thu, Jun 16, 2016 at 10:39 AM, Chad Versace > wrote: > > > On Sat 11 Jun 2016, Jason Ekstrand wrote: > > > --- > > > src/intel/isl/isl_surface_state.c | 28 > > > 1 file changed, 8 insertions(+), 20 deletions(-) > > > >

Re: [Mesa-dev] [PATCH 11/64] isl/state: Remove some unused fields

2016-06-16 Thread Chad Versace
On Thu 16 Jun 2016, Jason Ekstrand wrote: > On Thu, Jun 16, 2016 at 10:14 AM, Chad Versace > wrote: > > > On Sat 11 Jun 2016, Jason Ekstrand wrote: > > > They're already zero-initialized and we have no plans of doing anything > > > more interesting with them. > > > --- > > > src/intel/isl/isl_su

Re: [Mesa-dev] [PATCH 1/1] r600: Enable FMA on chips that support it

2016-06-16 Thread Jan Vesely
On Thu, 2016-06-16 at 00:47 +0200, Glenn Kennard wrote: > On Wed, 15 Jun 2016 20:13:13 +0200, Jan Vesely u> wrote: > > > > > Signed-off-by: Jan Vesely > > --- > > Untested (I don't have the required hw) > > > >  src/gallium/drivers/r600/r600_pipe.c   | 5 - > >  src/gallium/drivers/r600/r60

Re: [Mesa-dev] [PATCH 15/64] isl/state: Return an extent3d from the halign/valign helper

2016-06-16 Thread Jason Ekstrand
On Thu, Jun 16, 2016 at 10:39 AM, Chad Versace wrote: > On Sat 11 Jun 2016, Jason Ekstrand wrote: > > --- > > src/intel/isl/isl_surface_state.c | 28 > > 1 file changed, 8 insertions(+), 20 deletions(-) > > > > diff --git a/src/intel/isl/isl_surface_state.c > b/src/i

Re: [Mesa-dev] [PATCH 15/64] isl/state: Return an extent3d from the halign/valign helper

2016-06-16 Thread Chad Versace
On Sat 11 Jun 2016, Jason Ekstrand wrote: > --- > src/intel/isl/isl_surface_state.c | 28 > 1 file changed, 8 insertions(+), 20 deletions(-) > > diff --git a/src/intel/isl/isl_surface_state.c > b/src/intel/isl/isl_surface_state.c > index 50570aa..1e94e60 100644 > ---

Re: [Mesa-dev] [PATCH 13/64] isl/state: Put all dimension setup together and towards the top

2016-06-16 Thread Chad Versace
On Sat 11 Jun 2016, Jason Ekstrand wrote: > --- > src/intel/isl/isl_surface_state.c | 154 > ++ > 1 file changed, 74 insertions(+), 80 deletions(-) > > diff --git a/src/intel/isl/isl_surface_state.c > b/src/intel/isl/isl_surface_state.c > index 0f21e34..0ada3

Re: [Mesa-dev] [PATCH v4] gallium: add API for setting window rectangles

2016-06-16 Thread Brian Paul
On 06/15/2016 06:24 PM, Ilia Mirkin wrote: Window rectangles apply to all framebuffer operations, either in inclusive or exclusive mode. They may also be specified as part of a blit operation. In exclusive mode, any fragment inside any of the specified rectangles will be discarded. In inclusive

Re: [Mesa-dev] [PATCH 11/64] isl/state: Remove some unused fields

2016-06-16 Thread Chad Versace
On Thu 16 Jun 2016, Chad Versace wrote: > On Sat 11 Jun 2016, Jason Ekstrand wrote: > > They're already zero-initialized and we have no plans of doing anything > > more interesting with them. > > --- > > src/intel/isl/isl_surface_state.c | 9 - > > 1 file changed, 9 deletions(-) > > > >

[Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-16 Thread Brian Paul
To match what's done in the automake build. v2: Use git rev-parse to get a 10-character hash ID Fix Python imports --- src/SConscript | 49 - src/mesa/SConscript | 45 ++--- 2 files changed, 50 insert

Re: [Mesa-dev] [PATCH 11/64] isl/state: Remove some unused fields

2016-06-16 Thread Jason Ekstrand
On Thu, Jun 16, 2016 at 10:14 AM, Chad Versace wrote: > On Sat 11 Jun 2016, Jason Ekstrand wrote: > > They're already zero-initialized and we have no plans of doing anything > > more interesting with them. > > --- > > src/intel/isl/isl_surface_state.c | 9 - > > 1 file changed, 9 deletio

Re: [Mesa-dev] [PATCH 11/64] isl/state: Remove some unused fields

2016-06-16 Thread Chad Versace
On Sat 11 Jun 2016, Jason Ekstrand wrote: > They're already zero-initialized and we have no plans of doing anything > more interesting with them. > --- > src/intel/isl/isl_surface_state.c | 9 - > 1 file changed, 9 deletions(-) > @@ -261,12 +258,6 @@ isl_genX(surf_fill_state_s)(const st

Re: [Mesa-dev] [PATCH 10/64] isl/state: Don't use designated initializers for the surface state

2016-06-16 Thread Chad Versace
On Sat 11 Jun 2016, Jason Ekstrand wrote: > While designated initializers are nice, they also force us to put some > things in the initializer and some things later. Surface state setup is > complicated enough that this really hurs readability in the long run. typo:

[Mesa-dev] [PATCH 1/2] vl: add a bicubic interpolation filter

2016-06-16 Thread Nayan Deshmukh
This is a shader based bicubic interpolater which uses cubic Hermite spline algorithm. Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/vl/vl_bicubic_filter.c | 370 +++ src/gallium/auxiliary/vl/vl_bicubic_filte

[Mesa-dev] [PATCH 2/2] st/vdpau: use bicubic filter for scaling

2016-06-16 Thread Nayan Deshmukh
Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c | 52 +--- src/gallium/state_trackers/vdpau/vdpau_private.h | 6 +++ 2 files changed, 53 insertions(+), 5 deletions(-) diff --git a/src/gallium/state_trackers/vdpau/mixer.c b/src/gallium/stat

[Mesa-dev] [PATCH 0/2] implement bicubic interpolation

2016-06-16 Thread Nayan Deshmukh
Hi, This series aims to implement bicubic interpolation using cubic Hermite spline algorithm. Please Review! Thanks, Nayan. Nayan Deshmukh (2): vl: add a bicubic interpolation filter st/vdpau: use bicubic filter for scaling src/gallium/auxiliary/Makefile.sources | 2 + src/gal

Re: [Mesa-dev] virgl and vc4 problem on Android

2016-06-16 Thread Rob Clark
On Thu, Jun 16, 2016 at 12:56 PM, Rob Herring wrote: > On Thu, Jun 16, 2016 at 11:44 AM, Rob Clark wrote: >> On Wed, Jun 15, 2016 at 8:34 PM, Rob Herring wrote: >>> In the process of adding RGBX (XB24) format to mesa for Android, I >>> started seeing a new problem that makes the UI stop updating

Re: [Mesa-dev] [PATCH 08/64] i965/blorp: Only set src_z for gen8+ 3D textures

2016-06-16 Thread Chad Versace
On Sat 11 Jun 2016, Jason Ekstrand wrote: > Otherwise, we end up with a bogus value in the third component. On gen6-7 > where we always use 2D textures, this can cause problems if the > SurfaceArray bit is set in the SURFACE_STATE. Enlighten me. Why does blorp use 3D surfaces on gen >= 8 but not

Re: [Mesa-dev] [PATCH 07/64] i965/gen7, 8: Set SURFACE_IS_ARRAY for all non-3D texture types

2016-06-16 Thread Chad Versace
On Sat 11 Jun 2016, Jason Ekstrand wrote: > There's no real reason why we shouldn't set this bit. It does affect how > the sampler operates a bit but since you can have a 2D non-array view of a > 2D_ARRAY texture that distinction is very weak. Also, this is what ISL > will do and we would like th

Re: [Mesa-dev] virgl and vc4 problem on Android

2016-06-16 Thread Rob Herring
On Thu, Jun 16, 2016 at 11:44 AM, Rob Clark wrote: > On Wed, Jun 15, 2016 at 8:34 PM, Rob Herring wrote: >> In the process of adding RGBX (XB24) format to mesa for Android, I >> started seeing a new problem that makes the UI stop updating. It >> happens about when the splash screen is stopped and

Re: [Mesa-dev] [PATCH 03/11] mesa: Strip arrayness from interface block names in some IO validation

2016-06-16 Thread Ian Romanick
On 06/14/2016 08:34 PM, Timothy Arceri wrote: > On Tue, 2016-06-14 at 19:01 -0700, Ian Romanick wrote: >> From: Ian Romanick >> >> Outputs from the vertex shader need to be able to match >> per-vertex-arrayed inputs of later stages. Acomplish this by >> stripping >> one level of arrayness from th

Re: [Mesa-dev] virgl and vc4 problem on Android

2016-06-16 Thread Rob Clark
On Wed, Jun 15, 2016 at 8:34 PM, Rob Herring wrote: > In the process of adding RGBX (XB24) format to mesa for Android, I > started seeing a new problem that makes the UI stop updating. It > happens about when the splash screen is stopped and the lock screen is > displayed. The display flickers on

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-16 Thread Brian Paul
On 06/16/2016 10:31 AM, Eric Engestrom wrote: On Thu, Jun 16, 2016 at 09:48:54AM -0600, Brian Paul wrote: On 06/16/2016 07:35 AM, Eric Engestrom wrote: That fixed truncation can give non-unique hashes. Switching to rev-parse (suggested above) fixes this. rev-parse --short produces a 7-char ha

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-16 Thread Eric Engestrom
On Thu, Jun 16, 2016 at 09:48:54AM -0600, Brian Paul wrote: > On 06/16/2016 07:35 AM, Eric Engestrom wrote: > > That fixed truncation can give non-unique hashes. Switching to rev-parse > > (suggested above) fixes this. > > rev-parse --short produces a 7-char hash. No it doesn't, not in the genera

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-16 Thread Brian Paul
On 06/16/2016 07:35 AM, Eric Engestrom wrote: On Wed, Jun 15, 2016 at 11:58:29AM -0600, Brian Paul wrote: To match what's done in the automake build. --- src/SConscript | 43 +++ src/mesa/SConscript | 43 ++-

Re: [Mesa-dev] [PATCH v2] swr: automake: don't ship LLVM version specific generated sources

2016-06-16 Thread Chuck Atkins
So, I can confirm that with this patch applied to the rc3 tag, I can generate a tarball on Arch with make dist, and then use said tarball to build with SWR enabled on fedora. So: Tested-by: Chuck Atkins - Chuck On Tue, Jun 14, 2016 at 1:14 PM, Emil Velikov wrote: > On 14 June 2016 at 18:06,

[Mesa-dev] [Bug 96543] N-Ball editor shows only a blackscreen

2016-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96543 --- Comment #2 from Fabian Maurer --- Interesting, with this option it works in my system, too. Is this the expected behaviour? Since it worked on windows without that parameter, but on my linux pc I got a blackscreen, I assumed it should work wi

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-16 Thread Emil Velikov
On 15 June 2016 at 18:58, Brian Paul wrote: > To match what's done in the automake build. Considering the grief that it caused for autoconf builds I've deliberately left scons as-is the moment. There's even one more corner case that I will send a patch out in a moment. -Emil

Re: [Mesa-dev] [RFC] New dma_buf -> EGLImage EGL extension - Final spec published!

2016-06-16 Thread Rob Clark
So, if we wanted to extend this to support the fourcc-modifiers that we have on the kernel side for compressed/tiled/etc formats, what would be the right approach? A new version of the existing extension or a new EGL_EXT_image_dma_buf_import2 extension, or ?? BR, -R On Mon, Feb 25, 2013 at 6:54

Re: [Mesa-dev] [PATCH] mesa/glsl: stop using GL shader type internally

2016-06-16 Thread Jose Fonseca
On 05/06/16 04:17, Timothy Arceri wrote: Instead use the internal gl_shader_stage enum everywhere. This makes things more consistent and gets rid of unnecessary conversions. Ideally it would be nice to remove the Type field from gl_shader altogether but currently it is used to differentiate betw

Re: [Mesa-dev] [PATCH] i965: remove remaining tabs in brw_link.cpp

2016-06-16 Thread Jason Ekstrand
Thanks, Acked-by: Jason Ekstrand On Jun 15, 2016 11:13 PM, "Timothy Arceri" wrote: > --- > src/mesa/drivers/dri/i965/brw_link.cpp | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_link.cpp > b/src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-16 Thread Eric Engestrom
On Wed, Jun 15, 2016 at 11:58:29AM -0600, Brian Paul wrote: > To match what's done in the automake build. > --- > src/SConscript | 43 +++ > src/mesa/SConscript | 43 ++- > 2 files changed, 45 insertions(+), 41 de

Re: [Mesa-dev] Mesa 11.2.2 and Mesa 12.0.0rc3 GLES 3.1 issues with i965 driver

2016-06-16 Thread Mike Gorchak
Hi, > You're supposed to get at these functions with eglGetProcAddress() and such A'm afraid EGL v1.4 spec forbids obtaining core functions through eglGetProcAddress(), they should be visible at dynamic linker level. Anyway, thanks! On Wed, Jun 15, 2016 at 3:06 PM, Ilia Mirkin wrote: > On We

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-16 Thread Jose Fonseca
On 15/06/16 18:58, Brian Paul wrote: To match what's done in the automake build. --- src/SConscript | 43 +++ src/mesa/SConscript | 43 ++- 2 files changed, 45 insertions(+), 41 deletions(-) diff --git a/src

Re: [Mesa-dev] [PATCH v2] mesa: replace 1.F with 1.0F

2016-06-16 Thread Eric Engestrom
On Wed, Jun 15, 2016 at 11:19:28PM +0530, Nayan Deshmukh wrote: > Hi Eric, > > Could you please push both the patches as I don't have the push access. > > Thanks, > Nayan. I don't have push access either. Emil will probably be happy to do it for you though, seeing as this was his idea :) Cheers

Re: [Mesa-dev] [PATCH 7/7] util: Fix ralloc to use malloc instead of calloc

2016-06-16 Thread Juha-Pekka Heikkila
On 14.06.2016 18:03, Jason Ekstrand wrote: On Tue, Jun 14, 2016 at 7:59 AM, Juha-Pekka Heikkila mailto:juhapekka.heikk...@gmail.com>> wrote: ralloc originally had had idea of using malloc but somehow had slipped in calloc. Without these changes rzalloc did double job of zeroing the

[Mesa-dev] [Bug 96552] Request for new account for contribution in mesa driver development

2016-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96552 --- Comment #5 from Rahul --- Yes sure .. I will do .. Thanks On Thu, Jun 16, 2016 at 5:44 PM, wrote: > Timothy Arceri changed bug 96552 > > What Removed Added > Resolution --- WONTFIX > S

[Mesa-dev] [PATCH] st/mesa: Remove tautological check (v2)

2016-06-16 Thread francians
From: Francesco Ansanelli --- src/mesa/state_tracker/st_cb_fbo.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_cb_fbo.c b/src/mesa/state_tracker/st_cb_fbo.c index a53b95a..950ec3e 100644 --- a/src/mesa/state_tracker/st_cb_fbo.c +++ b/src/mesa/s

[Mesa-dev] [Bug 96552] Request for new account for contribution in mesa driver development

2016-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96552 Timothy Arceri changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

Re: [Mesa-dev] [PATCH 1/1] r600: Enable FMA on chips that support it

2016-06-16 Thread Marek Olšák
On Thu, Jun 16, 2016 at 12:47 AM, Glenn Kennard wrote: > On Wed, 15 Jun 2016 20:13:13 +0200, Jan Vesely > wrote: > >> Signed-off-by: Jan Vesely >> --- >> Untested (I don't have the required hw) >> >> src/gallium/drivers/r600/r600_pipe.c | 5 - >> src/gallium/drivers/r600/r600_shader.c | 2

[Mesa-dev] [Bug 96552] Request for new account for contribution in mesa driver development

2016-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96552 --- Comment #3 from Rahul --- I guess i got you .. Thanks, Rahul -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing lis

[Mesa-dev] [Bug 96552] Request for new account for contribution in mesa driver development

2016-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96552 --- Comment #2 from Rahul --- Do you mean git pull origin - Rahul -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing li

[Mesa-dev] [Bug 96552] Request for new account for contribution in mesa driver development

2016-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96552 --- Comment #1 from Timothy Arceri --- Please see the steps at http://mesa3d.org/repository.html specifically step 3. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug._

[Mesa-dev] [Bug 96552] Request for new account for contribution in mesa driver development

2016-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96552 Bug ID: 96552 Summary: Request for new account for contribution in mesa driver development Product: Mesa Version: unspecified Hardware: x86-64 (AMD64) OS: L

[Mesa-dev] [Bug 96309] Request for new account

2016-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96309 Rahul changed: What|Removed |Added CC||talente...@gmail.com -- You are receiving this

[Mesa-dev] [Bug 96550] 12.0.0-rc3: mesa_dri_drivers.so linking fails with: relocation R_X86_64_32S against `V4F_COUNT' can not be used when making a shared object

2016-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96550 Bug ID: 96550 Summary: 12.0.0-rc3: mesa_dri_drivers.so linking fails with: relocation R_X86_64_32S against `V4F_COUNT' can not be used when making a shared object Product: M