Re: [Mesa-dev] [PATCH 31/31] vbo: Use a bitmask to track the active arrays in vbo_save*.

2016-06-06 Thread Matt Turner
On Mon, Jun 6, 2016 at 10:31 PM, wrote: > From: Mathias Fröhlich > > The use of a bitmask makes functions iterating only active > attributes less visible in profiles. > > v2: Use _mesa_bit_scan{,64} instead of open coding. > > Reviewed-by: Brian Paul > Signed-off-by: Mathias Fröhlich > --- >

Re: [Mesa-dev] [PATCH] glsl: initialise pointer to NULL

2016-06-06 Thread Iago Toral
On Mon, 2016-06-06 at 16:45 +0200, Jakob Sinclair wrote: > On 2016-06-06 15:48, Iago Toral wrote: > > Reviewed-by: Iago Toral Quiroga > > > > I don't have push access so I would be very happy if you could push this > patch for me. Thanks! Sure, I have just pushed it. Iago ___

Re: [Mesa-dev] radeonfb: BAR 0: can't reserve [mem 0x98000000-0x9fffffff pref]

2016-06-06 Thread Mathieu Malaterre
Hi Alex, On Mon, Jun 6, 2016 at 7:20 PM, Alex Deucher wrote: > On Mon, Jun 6, 2016 at 1:16 PM, Marek Olšák wrote: >> [+ dri-devel] >> >> On Mon, Jun 6, 2016 at 8:42 AM, Mathieu Malaterre wrote: >>> Hi, >>> >>> Before reporting a possible invalid bug report. Does anyone knows why >>> radeaonfb i

[Mesa-dev] [PATCH 28/31] mesa: Use bitmask/ffs to iterate the enabled textures.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/main/texstate.c | 30 +++--

[Mesa-dev] [PATCH 31/31] vbo: Use a bitmask to track the active arrays in vbo_save*.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich The use of a bitmask makes functions iterating only active attributes less visible in profiles. v2: Use _mesa_bit_scan{,64} instead of open coding. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_save.h | 2 ++ src/mesa/vbo/vbo_save_a

[Mesa-dev] [PATCH 21/31] mesa: Use bitmask/ffs to iterate color material attributes.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/main/light.c | 11 ++- src

[Mesa-dev] [PATCH 25/31] i965: Use bitmask/ffs to iterate used vertex attributes.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/i965/brw_draw.c | 9 --

[Mesa-dev] [PATCH 23/31] radeon/r200: Use bitmask/ffs to iterate enabled clip planes.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/r200/r200_state.c | 19

[Mesa-dev] [PATCH 24/31] i965: Use bitmask/ffs to iterate enabled clip planes.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/i965/brw_curbe.c | 20

[Mesa-dev] [PATCH 26/31] mesa: Use bitmask/ffs to iterate SamplersUsed

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/main/uniforms.c | 41 +

[Mesa-dev] [PATCH 22/31] mesa: Use bitmask/ffs to iterate enabled clip planes.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/common/meta.c | 21 ++-

[Mesa-dev] [PATCH 27/31] mesa: Use designated bool value to check texture unit completeness.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich The change helps to use the bitmask/ffs in the next change. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/main/texstate.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c i

[Mesa-dev] [PATCH 30/31] vbo: Use a bitmask to track the active arrays in vbo_exec*.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich The use of a bitmask makes functions iterating only active attributes less visible in profiles. v2: Use _mesa_bit_scan{,64} instead of open coding. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_exec.h | 1 + src/mesa/vbo/vbo_exec_a

[Mesa-dev] [PATCH 29/31] mesa: Use bitmask/ffs to iterate the active_samplers bitmask.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/main/uniform_query.cpp | 7 --- 1

[Mesa-dev] [PATCH 13/31] mesa: Use bitmask/ffs to iterate enabled lights for ff shader keys.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces a loop that iterates all lights and test which of them is enabled by a loop only iterating over the bits set in the enabled bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/main/f

[Mesa-dev] [PATCH 17/31] mesa: Switch to bitmask based enabled lights in gen_matypes.c

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/x86/gen_matypes.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/x86/gen_matypes.c b/src/mesa/x86/gen_matypes.c index 18ffb72..fc06dc7 100644 --- a/src/mesa/x86/gen_maty

[Mesa-dev] [PATCH 19/31] mesa: Use bitmask/ffs to build ff vertex shader keys.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. The bitmask used here for iteration is a combination of different enabled masks present for texture units. v2: Use _mesa_bit_scan{,64} instead of open coding. Rev

[Mesa-dev] [PATCH 09/31] mesa: Remove the now unused CoordsReplace array.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Now that all users are converted, remove the array. Reviewed-by: Brian Paul Reviewed-by: Ian Romanick Signed-off-by: Mathias Fröhlich --- src/mesa/main/mtypes.h | 1 - src/mesa/main/points.c | 5 - src/mesa/main/texenv.c | 2 -- 3 files changed, 8 deletions(-) dif

[Mesa-dev] [PATCH 05/31] gallium: Convert the state_tracker to use CoordsReplaceBits.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Switch over to use the CoordsReplaceBits bitmask. Reviewed-by: Brian Paul Reviewed-by: Ian Romanick Signed-off-by: Mathias Fröhlich --- src/mesa/state_tracker/st_atom_rasterizer.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/mesa/stat

[Mesa-dev] [PATCH 18/31] mesa: Remove the linked list of enabled lights

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Clean up after conversion to bitmasks. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/main/context.c | 11 +-- src/mesa/main/enable.c | 4 src/mesa/main/light.c | 4 src/mesa/main/mtypes.h | 4 4 files changed, 1 inser

[Mesa-dev] [PATCH 11/31] mesa: Track enabled lights in a bitmask

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich This enables some optimizations afterwards. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/main/enable.c | 2 ++ src/mesa/main/light.c | 1 + src/mesa/main/mtypes.h | 2 ++ 3 files changed, 5 insertions(+) diff --git a/src/mesa/main/enable.c b/sr

[Mesa-dev] [PATCH 03/31] mesa: Add gl_point_attrib::CoordReplaceBits bitfield.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich The aim is to replace the CoordReplace array by a bitfield. Until all drivers are converted, establish the bitfield in parallel to the CoordReplace array. v2: Fix bitmask logic. Reviewed-by: Brian Paul Reviewed-by: Ian Romanick Signed-off-by: Mathias Fröhlich --- src/

[Mesa-dev] [PATCH 20/31] mesa: Use bitmask/ffs to build ff fragment shader keys.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. The bitmask used here for iteration is a combination of different enabled masks present for texture units. v2: Use _mesa_bit_scan{,64} instead of open coding. Rev

[Mesa-dev] [PATCH 12/31] mesa: Use bitmask/ffs to iterate enabled lights

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces loops that iterate all lights and test which of them is enabled by a loop only iterating over the bits set in the enabled bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/main/lig

[Mesa-dev] [PATCH 14/31] tnl: Use bitmask/ffs to iterate enabled lights

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces loops that iterate all lights and test which of them is enabled by a loop only iterating over the bits set in the enabled bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/tnl/t_vb

[Mesa-dev] [PATCH 06/31] r200: convert r200 to use CoordsReplaceBits.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Switch over to use the CoordsReplaceBits bitmask. Reviewed-by: Brian Paul Reviewed-by: Ian Romanick Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/r200/r200_state.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dr

[Mesa-dev] [PATCH 08/31] i965: Convert i965 to use CoordsReplaceBits.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Switch over to use the CoordsReplaceBits bitmask. Reviewed-by: Brian Paul Reviewed-by: Ian Romanick Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/i965/brw_sf.c| 7 +-- src/mesa/drivers/dri/i965/brw_vs.c| 6 +- src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 07/31] i915: Convert i915 to use CoordsReplaceBits.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Switch over to use the CoordsReplaceBits bitmask. Reviewed-by: Brian Paul Reviewed-by: Ian Romanick Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/i915/i915_state.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/mes

[Mesa-dev] [PATCH 15/31] nouveau: Use bitmask/ffs to iterate enabled lights

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces a loop that iterates all lights and test which of them is enabled by a loop only iterating over the bits set in the enabled bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/driver

[Mesa-dev] [PATCH 10/31] mesa: Rename CoordReplaceBits back to CoordReplace.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich It used to be called like that and fits better with 80 columns. Reviewed-by: Brian Paul Reviewed-by: Ian Romanick Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/i915/i915_state.c | 2 +- src/mesa/drivers/dri/i965/brw_sf.c | 2 +- src/mesa/driv

[Mesa-dev] [PATCH 16/31] radeon/r200: Use bitmask/ffs to iterate enabled lights

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces a loop that iterates all lights and test which of them is enabled by a loop only iterating over the bits set in the enabled bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/driver

[Mesa-dev] [PATCH 02/31] mesa: Make use of _mesa_bit_scan{,64}.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/main/arrayobj.c | 5 ++--- src/mesa/main/buffers.c | 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c index 897dac6..fb3c752 100644 --- a/src/mesa/main/a

[Mesa-dev] [PATCH 01/31] mesa: Provide _mesa_bit_scan{, 64} similar to gallium.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich The function is yet unused but will be used with the next changes. Signed-off-by: Mathias Fröhlich --- src/mesa/main/imports.h | 24 1 file changed, 24 insertions(+) diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h index d96d666..3

[Mesa-dev] [PATCH 04/31] swrast: Convert swrast to use CoordsReplaceBits.

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Switch over to use the CoordsReplaceBits bitmask. Reviewed-by: Brian Paul Reviewed-by: Ian Romanick Signed-off-by: Mathias Fröhlich --- src/mesa/swrast/s_points.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/swrast/s_points.c b/src/m

[Mesa-dev] [PATCH 00/31] Make more use of bitmasks v2

2016-06-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi all, following a series with performance improvements for cpu/draw bound applications. This part makes more use of the bitmask/ffs technique for iterating a set of enabled items. The gains are not huge but they are noticable for some of my favourite workloads. Changes

[Mesa-dev] [PATCH 5/5] mesa/subroutines: drop the old subroutine index uploads.

2016-06-06 Thread Dave Airlie
From: Dave Airlie We used to upload the indices when they changed, now we rely on the drivers calling the correct hook to have the values updated from the context storage. Signed-off-by: Dave Airlie --- src/mesa/main/shaderapi.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/mesa

[Mesa-dev] shader subroutine per-context uniform support

2016-06-06 Thread Dave Airlie
So when I implemented shader subroutines, I ignored part of the spec, because nobody really cares or uses this extension. But since CTS has a test for this feature I thought I'd implement it a bit better now (still not perfect). So the spec says that the values in the subroutine uniforms are stor

[Mesa-dev] [PATCH 4/5] st/mesa: use the new subroutine index upload API.

2016-06-06 Thread Dave Airlie
From: Dave Airlie This plugs the new API into the gallium state tracker. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_atom_constbuf.c | 19 +++ src/mesa/state_tracker/st_cb_bitmap.c | 2 +- src/mesa/state_tracker/st_cb_drawpixels.c | 4 ++-- 3 files changed, 1

[Mesa-dev] [PATCH 3/5] i965: use new subroutine index uploader.

2016-06-06 Thread Dave Airlie
From: Dave Airlie This plugs the subroutine index updates into the i965 backend, where it loads constants. Signed-off-by: Dave Airlie --- src/mesa/drivers/dri/i965/brw_gs_surface_state.c | 2 ++ src/mesa/drivers/dri/i965/brw_tcs_surface_state.c | 2 ++ src/mesa/drivers/dri/i965/brw_tes_surfac

[Mesa-dev] [PATCH 2/5] mesa: add api to write subroutine indicies to the program storage.

2016-06-06 Thread Dave Airlie
From: Dave Airlie This writes the subroutine indicies to the program storage for a stage. This API is intended to be used by drivers to update the uniform storage before uploading to the hw. This isn't the most thread safe effort, but it will be significantly more multi-context safe. Signed-off

[Mesa-dev] [PATCH 1/5] mesa/subroutines: start adding per-context subroutine index support

2016-06-06 Thread Dave Airlie
From: Dave Airlie One piece of ARB_shader_subroutine I ignored was the fact that it needs to store the subroutine index data per context and not per shader program. There is one CTS test that tests this: GL45-CTS.shader_subroutine.multiple_contexts However the test only does a write to context

[Mesa-dev] [PATCH] glsl/ast: don't allow subroutine uniform comparisons

2016-06-06 Thread Dave Airlie
From: Dave Airlie This fixes: GL45-CTS.shader_subroutine.subroutines_cannot_be_assigned_float_int_values_or_be_compared though I'm not 100% sure why this is illegal from the spec, but it makes us pass the test, and I really can't see a use case for this. Signged-off-by: Dave Airlie --- src/co

Re: [Mesa-dev] [PATCH] i965/gen8: fix cull distance emission for tessellation shaders.

2016-06-06 Thread Kristian Høgsberg
Reviewed-by: Kristian Høgsberg On Mon, Jun 6, 2016 at 5:29 PM, Dave Airlie wrote: > From: Dave Airlie > > This fixes some cases of: > GL45-CTS.cull_distance.functional > on Skylake. > > Cc: "12.0" > Signed-off-by: Dave Airlie > --- > src/mesa/drivers/dri/i965/gen8_ds_state.c | 8 +--- >

Re: [Mesa-dev] [PATCH v2] glx: fix crash with bad fbconfig

2016-06-06 Thread Tapani Pälli
ping On 05/31/2016 12:53 PM, Tapani Pälli wrote: From: Daniel Czarnowski GLX documentation states: glXCreateNewContext can generate the following errors: (...) GLXBadFBConfig if config is not a valid GLXFBConfig Function checks if the given config is a valid config and sets pr

Re: [Mesa-dev] Mesa (master): 29 new commits

2016-06-06 Thread Michel Dänzer
On 06.06.2016 23:12, Marek Olšák wrote: > On Tue, May 10, 2016 at 10:20 AM, Michel Dänzer wrote: >> On 10.05.2016 13:00, Nicolai Hähnle wrote: >>> On 30.04.2016 05:26, Michel Dänzer wrote: On 28.04.2016 10:54, Michel Dänzer wrote: > On 23.04.2016 07:24, Marek Olšák wrote: >> On Fri, A

[Mesa-dev] [PATCH] gk104/ir: fix conditions for adding a texbar

2016-06-06 Thread Ilia Mirkin
Sometimes a register source can actually be double- or even quad-wide. We must make sure that the inserted texbars take that width into account. Based on an earlier patch by Samuel Pitoiset. Signed-off-by: Ilia Mirkin Cc: "12.0 11.2" --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc

[Mesa-dev] [PATCH] glsl: handle unconditional returns inside a loop

2016-06-06 Thread Lars Hamre
Unrolls the loop with a count of 1 if it contains an unconditional return statement. Fixes the following piglit test: /spec/glsl-1.10/execution/fs-loop-return from crashing at this assert: tgsi/tgsi_exec.c:5952:tgsi_exec_machine_run: Assertion `mach->ContStackTop == 0' failed. Signed-off-by: L

Re: [Mesa-dev] [PATCH 1/5] mesa: hook up core bits of GL_ARB_shader_group_vote

2016-06-06 Thread Ilia Mirkin
On Mon, Jun 6, 2016 at 6:00 PM, Ian Romanick wrote: > On 05/29/2016 11:01 AM, Ilia Mirkin wrote: >> diff --git a/src/compiler/glsl/ir_validate.cpp >> b/src/compiler/glsl/ir_validate.cpp >> index 757f17c..bd69cd2 100644 >> --- a/src/compiler/glsl/ir_validate.cpp >> +++ b/src/compiler/glsl/ir_valid

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread Timothy Arceri
On Mon, 2016-06-06 at 12:33 +0200, ⚛ wrote: > On Mon, Jun 6, 2016 at 12:29 PM, Timothy Arceri > wrote: > > > > I'm pretty sure someone told you this already. But you need to > > remove > > that symbol and just use your name. Note the symbol also seems to > > be > > casing your name to be removed

[Mesa-dev] [PATCH] i965/gen8: fix cull distance emission for tessellation shaders.

2016-06-06 Thread Dave Airlie
From: Dave Airlie This fixes some cases of: GL45-CTS.cull_distance.functional on Skylake. Cc: "12.0" Signed-off-by: Dave Airlie --- src/mesa/drivers/dri/i965/gen8_ds_state.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen8_ds_state.c

Re: [Mesa-dev] CI job for Android builds

2016-06-06 Thread Rob Herring
On Fri, Jun 3, 2016 at 8:26 PM, Emil Velikov wrote: > On 4 June 2016 at 01:33, Rob Herring wrote: >> On Fri, Jun 3, 2016 at 7:19 PM, Emil Velikov >> wrote: >>> On 17 May 2016 at 23:29, Rob Herring wrote: On Tue, May 17, 2016 at 5:21 PM, Rob Clark wrote: > On Tue, May 17, 2016 at 6:14

Re: [Mesa-dev] [PATCH 1/3] docs/devinfo: Add closing paragraph tag

2016-06-06 Thread Nanley Chery
On Mon, Jun 06, 2016 at 02:47:54PM -0700, Ian Romanick wrote: > This matches what we've been doing since you reworked the extension > string handling. This series is > > Reviewed-by: Ian Romanick Thanks! - Nanley > > On 06/03/2016 11:04 AM, Nanley Chery wrote: > > From: Nanley Chery > > >

[Mesa-dev] [Bug 95529] [regression, bisected] Image corruption in Chrome

2016-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95529 --- Comment #5 from Nicolai Hähnle --- Hi Vladislav, thanks for the trace, that was very helpful. There is a candidate fix at https://lists.freedesktop.org/archives/mesa-dev/2016-June/119594.html -- You are receiving this mail because: You are

Re: [Mesa-dev] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-06-06 Thread Ilia Mirkin
On Mon, Jun 6, 2016 at 6:32 PM, Nicolai Hähnle wrote: > On 06.06.2016 23:58, Ilia Mirkin wrote: >> >> On Mon, Jun 6, 2016 at 5:37 PM, Nicolai Hähnle wrote: >>> >>> On 05.06.2016 08:24, Ilia Mirkin wrote: In the case where we can't guess the base level size, just use the first

Re: [Mesa-dev] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-06-06 Thread Nicolai Hähnle
On 06.06.2016 23:58, Ilia Mirkin wrote: On Mon, Jun 6, 2016 at 5:37 PM, Nicolai Hähnle wrote: On 05.06.2016 08:24, Ilia Mirkin wrote: In the case where we can't guess the base level size, just use the first image's dims. The width0/height0/depth0 on stObj may not have been set at this point.

Re: [Mesa-dev] Mesa (master): Revert "egl: Check if API is supported when using eglBindAPI."

2016-06-06 Thread Ian Romanick
On 06/06/2016 02:10 AM, Michel Dänzer wrote: > On 04.06.2016 00:10, Marek Olšák wrote: >> On Fri, Jun 3, 2016 at 4:33 PM, Dieter Nützel wrote: >>> Am 03.06.2016 11:47, schrieb Michel Dänzer: On 03.06.2016 18:34, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: > > Module: Mesa > Branc

Re: [Mesa-dev] [PATCH 3/4] gallium/radeon: add support for sharing textures with DCC between processes

2016-06-06 Thread Nicolai Hähnle
Thanks. In the v2 versions, patch 2 & 3 are also Reviewed-by: Nicolai Hähnle On 06.06.2016 17:21, Marek Olšák wrote: From: Marek Olšák v2: use a function for calculating WORD1 of bo metadata --- src/gallium/drivers/radeon/r600_pipe_common.h | 4 +++ src/gallium/drivers/radeon/r600_textur

Re: [Mesa-dev] [PATCH 1/5] mesa: hook up core bits of GL_ARB_shader_group_vote

2016-06-06 Thread Ian Romanick
On 05/29/2016 11:01 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/compiler/glsl/builtin_functions.cpp| 22 > ++ > src/compiler/glsl/glcpp/glcpp-parse.y | 3 +++ > src/compiler/glsl/glsl_parser_extras.cpp | 1 + > src/comp

Re: [Mesa-dev] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-06-06 Thread Ilia Mirkin
On Mon, Jun 6, 2016 at 5:37 PM, Nicolai Hähnle wrote: > On 05.06.2016 08:24, Ilia Mirkin wrote: >> >> In the case where we can't guess the base level size, just use the first >> image's dims. The width0/height0/depth0 on stObj may not have been set >> at this point. Observed in a trace that set up

Re: [Mesa-dev] [PATCH 1/3] docs/devinfo: Add closing paragraph tag

2016-06-06 Thread Ian Romanick
This matches what we've been doing since you reworked the extension string handling. This series is Reviewed-by: Ian Romanick On 06/03/2016 11:04 AM, Nanley Chery wrote: > From: Nanley Chery > > Signed-off-by: Nanley Chery > --- > docs/devinfo.html | 1 + > 1 file changed, 1 insertion(+) >

Re: [Mesa-dev] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-06-06 Thread Nicolai Hähnle
On 05.06.2016 08:24, Ilia Mirkin wrote: In the case where we can't guess the base level size, just use the first image's dims. The width0/height0/depth0 on stObj may not have been set at this point. Observed in a trace that set up levels 2..9 of a 2d texture, and set the base level to 2, with hei

[Mesa-dev] [PATCH 1/2] anv/entrypoints: Emit #if guards for all platforms

2016-06-06 Thread Jason Ekstrand
--- src/intel/vulkan/anv_entrypoints_gen.py | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index 7a47372..546829f 100644 --- a/src/intel/vulkan/anv_entrypoints

[Mesa-dev] [PATCH 2/2] anv/entrypoints: Stop using the C preprocessor

2016-06-06 Thread Jason Ekstrand
Now that we emit guards for everything, we can just generate the files and trust build flags to keep us safe. This should also fix the tarball problems. --- src/intel/vulkan/Makefile.am | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/intel/vulkan/Makefile.a

[Mesa-dev] [PATCH] st/mesa: use base level size as "guess" when available

2016-06-06 Thread Nicolai Hähnle
From: Nicolai Hähnle When an applications specifies mip levels _before_ setting a mipmap texture filter, we will initially guess a single texture level. When the second level image is created, we try to allocate the full texture -- however, we get the base level size guess wrong if that size is o

[Mesa-dev] [PATCH] radeonsi: Reinitialize all descriptors in CE preamble.

2016-06-06 Thread Bas Nieuwenhuizen
This fixes a problem with the CE preamble and restoring only stuff in the preamble when needed. To illustrate suppose we have two graphics IB's 1 and 2, which are submitted in that order. Furthermore suppose IB 1 does not use CE ram, but IB 2 does, and we have a context switch at the start of IB

Re: [Mesa-dev] [PATCH 9/9] radeonsi: keep track of dirty descriptor sets

2016-06-06 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Fri, Jun 3, 2016 at 7:01 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Reduces CPU load for draw calls that change none or few of the descriptors. > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 39 > --

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread Mike Lothian
I only have /var/log/portage/elog/ the file(s) you specified don't exist on my system On Mon, 6 Jun 2016 at 21:13 ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > On Mon, Jun 6, 2016 at 9:01 PM, Mike Lothian wrote: > > > > I'm running Gentoo too, it didn't take significantly longer to compile > GCC 6.1 tha

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread
On Mon, Jun 6, 2016 at 9:01 PM, Mike Lothian wrote: > > I'm running Gentoo too, it didn't take significantly longer to compile GCC > 6.1 than any other version of GCC > > I use portage to compile mesa Ok. What is the output of a command like: $ ls --sort=time /var/log/portage/media-libs:mesa-*.

Re: [Mesa-dev] [PATCH] glsl/ast: don't crash when func_name is NULL

2016-06-06 Thread Dave Airlie
On 7 June 2016 at 00:17, Iago Toral wrote: > I guess this makes sense: > Reviewed-by: Iago Toral Quiroga > Out of curiosity, in which case do we get here and can't find a function > name? The test does something illegal earlier, but we keep parsing it, the case we end up here is with id->oper be

Re: [Mesa-dev] [PATCH 1/2] radeonsi: simplify PRIMGROUP_SIZE computation for tessellation

2016-06-06 Thread Nicolai Hähnle
On 03.06.2016 17:14, Marek Olšák wrote: From: Marek Olšák Ported from Vulkan. --- src/gallium/drivers/radeonsi/si_state_draw.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state

Re: [Mesa-dev] [PATCH] nv50/ir: use round toward 0 when converting doubles to integers

2016-06-06 Thread Ilia Mirkin
On Mon, Jun 6, 2016 at 3:25 PM, Samuel Pitoiset wrote: > Like floats, we should use the round toward 0 mode instead of the > nearest one (which is the default) for doubles to integers. > > This fixes all arb_gpu_shader_fp64 piglits which convert doubles to > integers (16 tests). > > Signed-off-by:

Re: [Mesa-dev] [PATCH 3/5] anv/descriptor_set: Ensure that bindings are always in increasing order

2016-06-06 Thread Michael Schellenberger Costa
Hi Jason, Am 06/06/2016 um 20:26 schrieb Jason Ekstrand: > Since applications are allowed to specify some set of bindings which need > not be dense they also need not be in order. That sentence reads strange. "Need not be" sounds like must not. Dont you mean "Do not need to be"? --Michael For

Re: [Mesa-dev] [PATCH 4/5] anv/pipeline: Store the (set, binding, index) tripple in the bind map

2016-06-06 Thread Michael Schellenberger Costa
Hi Jason Am 06/06/2016 um 20:26 schrieb Jason Ekstrand: > This way the the bind map (which we're caching) is mostly independent of double the here > the pipeline layout. The only coupling remaining is that we pull the array > size of a binding out of the layout. However, that size is also specif

[Mesa-dev] [PATCH] nv50/ir: use round toward 0 when converting doubles to integers

2016-06-06 Thread Samuel Pitoiset
Like floats, we should use the round toward 0 mode instead of the nearest one (which is the default) for doubles to integers. This fixes all arb_gpu_shader_fp64 piglits which convert doubles to integers (16 tests). Signed-off-by: Samuel Pitoiset Cc: "11.2 12.0" --- src/gallium/drivers/nouveau/

[Mesa-dev] [Bug 94512] X segfaults with glx-tls enabled in a x32 environment

2016-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94512 --- Comment #7 from EoD --- Created attachment 124376 --> https://bugs.freedesktop.org/attachment.cgi?id=124376&action=edit LD_DEBUG=libs startx (In reply to Emil Velikov from comment #6) > Based of the backtrace there is no information if mes

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread Mike Lothian
I'm running Gentoo too, it didn't take significantly longer to compile GCC 6.1 than any other version of GCC I use portage to compile mesa On Mon, 6 Jun 2016, 5:58 p.m. ⚛, <0xe2.0x9a.0...@gmail.com> wrote: > On Mon, Jun 6, 2016 at 3:39 PM, Mike Lothian wrote: > > > > This doesn't seem to affect

[Mesa-dev] [PATCH 5/5] anv/pipeline_cache: Allow for an zero-sized cache

2016-06-06 Thread Jason Ekstrand
This gets ANV_ENABLE_PIPELINE_CACHE=false working again. Signed-off-by: Jason Ekstrand Cc: Kristian Høgsberg Kristensen --- src/intel/vulkan/anv_pipeline_cache.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_pipeline_cache.c b/src/intel/vulkan/anv

[Mesa-dev] [PATCH 1/5] anv/descriptor_set: Set array_size to zero for non-existant descriptors

2016-06-06 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: Kristian Høgsberg Kristensen --- src/intel/vulkan/anv_descriptor_set.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c index f7a9cb0..3924d04 100644 --- a/src/intel/vulkan/anv_des

[Mesa-dev] [PATCH 2/5] anv/descriptor_set: Add a type field in debug builds

2016-06-06 Thread Jason Ekstrand
This allows for some extra validation and makes it easier to see what's going on when poking around in gdb. Signed-off-by: Jason Ekstrand Cc: Kristian Høgsberg Kristensen --- src/intel/vulkan/anv_descriptor_set.c | 5 + src/intel/vulkan/anv_private.h| 5 + 2 files changed, 10 in

[Mesa-dev] [PATCH 4/5] anv/pipeline: Store the (set, binding, index) tripple in the bind map

2016-06-06 Thread Jason Ekstrand
This way the the bind map (which we're caching) is mostly independent of the pipeline layout. The only coupling remaining is that we pull the array size of a binding out of the layout. However, that size is also specified in the shader and should always match so it's not really coupled. This ren

[Mesa-dev] [PATCH 3/5] anv/descriptor_set: Ensure that bindings are always in increasing order

2016-06-06 Thread Jason Ekstrand
Since applications are allowed to specify some set of bindings which need not be dense they also need not be in order. For most things, this doesn't matter, but it could result getting the wrong dynamic offsets. This adds a quick-and-dirty sort to ensure that everything is always in increasing ord

Re: [Mesa-dev] [PATCH 1/2] glsl: Make opt_copy_propagation actually propagate into loops.

2016-06-06 Thread Matt Turner
Both are Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] radeonfb: BAR 0: can't reserve [mem 0x98000000-0x9fffffff pref]

2016-06-06 Thread Alex Deucher
On Mon, Jun 6, 2016 at 1:16 PM, Marek Olšák wrote: > [+ dri-devel] > > On Mon, Jun 6, 2016 at 8:42 AM, Mathieu Malaterre wrote: >> Hi, >> >> Before reporting a possible invalid bug report. Does anyone knows why >> radeaonfb is not configured the same way radeon is ? For instance on a >> PowerPC m

[Mesa-dev] [Bug 96410] [Perf] Pre validate _mesa_sampler_uniforms_pipeline_are_valid like _mesa_sampler_uniforms_are_valid

2016-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96410 Bug ID: 96410 Summary: [Perf] Pre validate _mesa_sampler_uniforms_pipeline_are_valid like _mesa_sampler_uniforms_are_valid Product: Mesa Version: git Ha

Re: [Mesa-dev] radeonfb: BAR 0: can't reserve [mem 0x98000000-0x9fffffff pref]

2016-06-06 Thread Marek Olšák
[+ dri-devel] On Mon, Jun 6, 2016 at 8:42 AM, Mathieu Malaterre wrote: > Hi, > > Before reporting a possible invalid bug report. Does anyone knows why > radeaonfb is not configured the same way radeon is ? For instance on a > PowerPC machine, when Open Firmware Frame Buffer is used (OFfb), I > ca

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-06-06 Thread Ilia Mirkin
On Mon, Jun 6, 2016 at 12:52 PM, Brian Paul wrote: > On 06/06/2016 10:05 AM, Ilia Mirkin wrote: >> >> On Mon, Jun 6, 2016 at 11:37 AM, Brian Paul wrote: >>> >>> On 06/05/2016 12:24 AM, Ilia Mirkin wrote: In the case where we can't guess the base level size, just use the first

Re: [Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-06 Thread
On Mon, Jun 6, 2016 at 3:39 PM, Mike Lothian wrote: > > This doesn't seem to affect me using GCC 6.1 and gold I don't have GCC 6.1 installed at the moment, and it takes quite long to install it on Gentoo. Can you please send me the output of the following command? $ cd mesa/src/mapi $ make clea

[Mesa-dev] [Bug 96408] [PERF] SSO: dirty all stages when only one is updated. Trigger extra validations.

2016-06-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96408 Bug ID: 96408 Summary: [PERF] SSO: dirty all stages when only one is updated. Trigger extra validations. Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-06-06 Thread Brian Paul
On 06/06/2016 10:05 AM, Ilia Mirkin wrote: On Mon, Jun 6, 2016 at 11:37 AM, Brian Paul wrote: On 06/05/2016 12:24 AM, Ilia Mirkin wrote: In the case where we can't guess the base level size, just use the first image's dims. The width0/height0/depth0 on stObj may not have been set at this poin

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-06-06 Thread Ilia Mirkin
On Mon, Jun 6, 2016 at 11:37 AM, Brian Paul wrote: > On 06/05/2016 12:24 AM, Ilia Mirkin wrote: >> >> In the case where we can't guess the base level size, just use the first >> image's dims. The width0/height0/depth0 on stObj may not have been set >> at this point. Observed in a trace that set up

Re: [Mesa-dev] [PATCH] radeonsi: Save and restore entire CE RAM.

2016-06-06 Thread Bas Nieuwenhuizen
On Mon, Jun 6, 2016 at 5:14 PM, Nicolai Hähnle wrote: > On 06.06.2016 00:28, Bas Nieuwenhuizen wrote: >> >> This fixes a problem with the CE preamble and restoring only stuff in the >> preamble when needed. >> >> To illustrate suppose we have two graphics IB's 1 and 2, which are >> submitted in >

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-06-06 Thread Brian Paul
On 06/05/2016 12:24 AM, Ilia Mirkin wrote: In the case where we can't guess the base level size, just use the first image's dims. The width0/height0/depth0 on stObj may not have been set at this point. Observed in a trace that set up levels 2..9 of a 2d texture, and set the base level to 2, with

Re: [Mesa-dev] [PATCH 0/3] R600-GCN: Use hw MSAA resolve for non-trivial resolves

2016-06-06 Thread Nicolai Hähnle
Patches 1 & 3: Reviewed-by: Nicolai Hähnle On 05.06.2016 17:07, Marek Olšák wrote: Hi, The shader-based resolve is slow. With this series, one scene with 8xMSAA in HL2: Lost Coast goes from 8-9 FPS to 32 FPS on Evergreen & Wine/Nine. Please review. Marek __

Re: [Mesa-dev] [PATCH] st/mesa: check shader image format support before using PBO download

2016-06-06 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Jun 6, 2016 at 4:29 PM, Nicolai Hähnle wrote: > Makes sense. > > Reviewed-by: Nicolai Hähnle > > > On 06.06.2016 00:59, Ilia Mirkin wrote: >> >> ARB_shader_image_load_store only requires a very fixed list of formats >> to be supported, while textures may

Re: [Mesa-dev] [PATCH 2/4] gallium/radeon: don't discard DCC if an external user can write to it

2016-06-06 Thread Marek Olšák
On Mon, Jun 6, 2016 at 5:12 PM, Bas Nieuwenhuizen wrote: > On Mon, Jun 6, 2016 at 4:21 PM, Nicolai Hähnle wrote: >> On 06.06.2016 16:16, Nicolai Hähnle wrote: >>> >>> Patches 1 & 2: >>> >>> Reviewed-by: Nicolai Hähnle >> >> >> Hold off on patch #2 - how does this work together with shader image

[Mesa-dev] [PATCH 3/4] gallium/radeon: add support for sharing textures with DCC between processes

2016-06-06 Thread Marek Olšák
From: Marek Olšák v2: use a function for calculating WORD1 of bo metadata --- src/gallium/drivers/radeon/r600_pipe_common.h | 4 +++ src/gallium/drivers/radeon/r600_texture.c | 16 +--- src/gallium/drivers/radeonsi/si_state.c | 35 ++- 3 files changed,

Re: [Mesa-dev] [PATCH] radeonsi: Save and restore entire CE RAM.

2016-06-06 Thread Nicolai Hähnle
On 06.06.2016 00:28, Bas Nieuwenhuizen wrote: This fixes a problem with the CE preamble and restoring only stuff in the preamble when needed. To illustrate suppose we have two graphics IB's 1 and 2, which are submitted in that order. Furthermore suppose IB 1 does not use CE ram, but IB 2 does,

Re: [Mesa-dev] [PATCH 2/4] gallium/radeon: don't discard DCC if an external user can write to it

2016-06-06 Thread Bas Nieuwenhuizen
On Mon, Jun 6, 2016 at 4:21 PM, Nicolai Hähnle wrote: > On 06.06.2016 16:16, Nicolai Hähnle wrote: >> >> Patches 1 & 2: >> >> Reviewed-by: Nicolai Hähnle > > > Hold off on patch #2 - how does this work together with shader image writes? > Then we're in an ugly situation where the other process co

[Mesa-dev] [PATCH 2/4] gallium/radeon: don't discard DCC if an external user can write to it

2016-06-06 Thread Marek Olšák
From: Marek Olšák We don't import textures with DCC now, but soon we will. v2: if we can't disable DCC for image writes, at least decompress DCC at bind time --- src/gallium/drivers/radeon/r600_pipe_common.h | 2 +- src/gallium/drivers/radeon/r600_texture.c | 31 +++

Re: [Mesa-dev] [PATCH] glsl: initialise pointer to NULL

2016-06-06 Thread Jakob Sinclair
On 2016-06-06 15:48, Iago Toral wrote: Reviewed-by: Iago Toral Quiroga I don't have push access so I would be very happy if you could push this patch for me. Thanks! -- Mvh Jakob Sinclair On Sat, 2016-06-04 at 01:09 +0200, Jakob Sinclair wrote: Could cause issues if you tried to read fro

  1   2   >