[Mesa-dev] [Bug 96176] Cannot build non-intel drivers without python3.

https://bugs.freedesktop.org/show_bug.cgi?id=96176 Bug ID: 96176 Summary: Cannot build non-intel drivers without python3. Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: All Status: NEW Keywords: b

Re: [Mesa-dev] [PATCH] glsl: add GL_EXT_clip_cull_distance define, add helpers

Reviewed-by: Tobias Klausmann On 25.05.2016 01:59, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- This addresses the feedback I got after pushing the enablement patch. docs/relnotes/11.3.0.html | 1 + src/compiler/glsl/builtin_variables.cpp | 10 -- src/compile

Re: [Mesa-dev] [PATCH] mesa: Add .gitignore entries for make check binaries

On Tue, May 24, 2016 at 9:07 PM, Kristian Høgsberg wrote: > From: Kristian Høgsberg Kristensen > > Signed-off-by: Kristian Høgsberg Kristensen > --- > src/compiler/.gitignore | 4 > src/compiler/nir/tests/.gitignore| 1 + > src/mesa/drivers/dri/i965/.gitignore | 3 +++ > s

Re: [Mesa-dev] [PATCH 0/2] scons 2.5.0 support

> Sure. Unfortunately, the series does not apply cleanly on ToT master: > > % git am p[12].txt > Applying: scons: whitespace cleanup > Using index info to reconstruct a base tree... > error: patch failed: src/gallium/state_trackers/wgl/SConscript:12 > error: src/gallium/state_trackers/wgl/SConscri

[Mesa-dev] [PATCH] mesa: Add .gitignore entries for make check binaries

From: Kristian Høgsberg Kristensen Signed-off-by: Kristian Høgsberg Kristensen --- src/compiler/.gitignore | 4 src/compiler/nir/tests/.gitignore| 1 + src/mesa/drivers/dri/i965/.gitignore | 3 +++ src/util/.gitignore | 1 + src/util/tests/hash_table/.giti

Re: [Mesa-dev] [PATCH] i965/draw: Use the correct buffer index for interleaved VBO sizes

On Tue, May 24, 2016 at 7:48 PM, Kristian Høgsberg wrote: > On Tue, May 24, 2016 at 5:01 PM, Jason Ekstrand > wrote: > > The buffer_range_* arrays are indexed by buffer index not element index. > > Reviewed-by: Kristian Høgsberg > Thanks! > > --- > > src/mesa/drivers/dri/i965/brw_draw_uploa

[Mesa-dev] [PATCH] mesa/bufferobj: use mapping range in BufferSubData.

From: Dave Airlie According to GL4.5 spec: An INVALID_OPERATION error is generated if any part of the speci- fied buffer range is mapped with MapBufferRange or MapBuffer (see sec- tion 6.3), unless it was mapped with MAP_PERSISTENT_BIT set in the Map- BufferRange access flags. So we should use t

Re: [Mesa-dev] [PATCH v3] mesa: Enable GL_KHR_robustness

On Tue, May 24, 2016 at 8:19 PM, Ilia Mirkin wrote: > On Tue, May 24, 2016 at 10:41 PM, Kristian Høgsberg > wrote: >> From: Kristian Høgsberg Kristensen >> >> GL_KHR_robustness adds the GL_CONTEXT_LOST error and five new entry >> points that we already implement. This patch adds a new dispatch

Re: [Mesa-dev] [PATCH 00/29] Make more use of bitmasks

Hi Brian, On Tuesday, May 24, 2016 11:29:56 Brian Paul wrote: > On 05/24/2016 12:41 AM, mathias.froehl...@gmx.net wrote: > > From: Mathias Fröhlich > > > > Hi all, > > > > following a series with performance improvements > > for cpu/draw bound applications. This part makes > > more use of the bit

Re: [Mesa-dev] [PATCH 01/29] mesa: Add gl_point_attrib::CoordReplaceBits bitfield.

On Tuesday, May 24, 2016 17:42:17 Roland Scheidegger wrote: > Am 24.05.2016 um 08:41 schrieb mathias.froehl...@gmx.net: > > From: Mathias Fröhlich > > > > The aim is to replace the CoordReplace array by > > a bitfield. Until all drivers are converted, > > establish the bitfield in paralell to the

Re: [Mesa-dev] [PATCH] gallium/radeon: add the kernel version into the renderer string

On 25.05.2016 09:09, Mike Lothian wrote: > Do you need the DRM version number if you'll be displaying the kernel > version anyway? Yes, because the DRM version depends on the kernel driver being used. The patch is Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer |

Re: [Mesa-dev] [PATCH v3] mesa: Enable GL_KHR_robustness

On Tue, May 24, 2016 at 10:41 PM, Kristian Høgsberg wrote: > From: Kristian Høgsberg Kristensen > > GL_KHR_robustness adds the GL_CONTEXT_LOST error and five new entry > points that we already implement. This patch adds a new dispatch > table that returns GL_CONTEXT_LOST from all entry points an

[Mesa-dev] [PATCH 11/12] i965: enable ARB_enhanced_layouts for gen8+

--- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index feea6ca..5d831e5 100644 --- a/src/mesa/drivers/dri/i965/intel_extensions.c +++ b/src/mesa/drivers/

[Mesa-dev] [PATCH 09/12] i965: add indirect packing support for tcs and tes

--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 33 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 51da3bd..a19ece7 100644 --- a/src/mesa/drivers/dri/i965/brw_

[Mesa-dev] [PATCH 10/12] i965: add indirect packing support to gs load inputs

--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index a19ece7..16fd7d6 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp +++ b

[Mesa-dev] [PATCH 01/12] nir: add new intrinsic field for storing component offset

This offset is used for packing. --- src/compiler/nir/nir.h| 6 ++ src/compiler/nir/nir_intrinsics.h | 8 src/compiler/nir/nir_lower_io.c | 8 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 7

[Mesa-dev] [PATCH 12/12] docs: mark ARB_enhanced_layouts as DONE for i965

--- docs/GL3.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 2dff3cd..edc04a1 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -193,11 +193,11 @@ GL 4.4, GLSL 4.40: GL_MAX_VERTEX_ATTRIB_STRIDE DONE (all drive

[Mesa-dev] [PATCH 07/12] i965: add component packing support for tcs

--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index e0d88c6..51da3bd 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp +++ b/src/m

[Mesa-dev] [PATCH 08/12] i965: add support for packing arrays

Here we add a new param to the type_size functions in order to pass in the size of a varying once packing is taken into account. --- src/compiler/nir/nir.h | 6 +++-- src/compiler/nir/nir_lower_io.c| 35 +- src/mesa/drivers/dri/i965/

[Mesa-dev] [PATCH 04/12] i965: enable component packing for vs and fs

--- src/mesa/drivers/dri/i965/brw_fs.cpp | 17 +++-- src/mesa/drivers/dri/i965/brw_fs.h | 5 +++-- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 29 - 3 files changed, 34 insertions(+), 17 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.c

[Mesa-dev] [PATCH 03/12] glsl/nir: add new num_packed_components field

This will be used to store the total number of components used at this location when packing via ARB_enhanced_layouts. --- src/compiler/glsl/ir.h | 5 +++ src/compiler/glsl/link_varyings.cpp | 74 - src/compiler/glsl/linker.cpp| 2 + src/c

[Mesa-dev] [PATCH 06/12] i965: add component packing support for tes

--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 38 +++- 1 file changed, 33 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index ce61898..e0d88c6 100644 --- a/src/mesa/drivers/dri/i965/brw_

[Mesa-dev] [PATCH 05/12] i965: add component packing support for gs

--- src/mesa/drivers/dri/i965/brw_fs.h | 2 +- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 21 + 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h index d5d7a77..b5a4fc8 100644 --- a/sr

[Mesa-dev] [PATCH 02/12] nir: use the same driver location for packed varyings

--- src/compiler/nir/nir.h| 4 ++-- src/compiler/nir/nir_lower_io.c | 25 - src/mesa/drivers/dri/i965/brw_nir.c | 12 +++- src/mesa/state_tracker/st_glsl_to_nir.cpp | 3 +++ 4 files changed, 36 insertions(+), 8 deletions(-) dif

[Mesa-dev] ARB_enhanced_layouts packing support for i965 Gen8+

There are a number of packing tests already in piglit but I have a few more on the way. This series does not add support for doubles as there is currently a doubles bug with explicit locations that I've pointed out to the Igalia guys. Samuel is working on a fix for this after which I will finish u

Re: [Mesa-dev] [PATCH 2/2] tgsi: print TGSI_PROPERTY_NEXT_SHADER value as string, not an integer

Series is Reviewed-by: Ilia Mirkin On Tue, May 24, 2016 at 8:43 PM, Brian Paul wrote: > Print "GEOM" instead of "2", for example. > > v2: also update the text parsing code, per Ilia. > --- > src/gallium/auxiliary/tgsi/tgsi_dump.c | 3 +++ > src/gallium/auxiliary/tgsi/tgsi_text.c | 22

Re: [Mesa-dev] [PATCH v2] mesa: Add support for GL_CONTEXT_LOST

On Tue, May 24, 2016 at 7:47 PM, Ilia Mirkin wrote: > > On May 24, 2016 10:25 PM, "Kristian Høgsberg" wrote: >> >> On Tue, May 24, 2016 at 5:22 PM, Ilia Mirkin wrote: >> > Sorry to be pedantic, but you're enabling the ext for gles1.1, but the >> > new >> > entrypoint appear to only apply to gles

Re: [Mesa-dev] [PATCH] i965/draw: Use the correct buffer index for interleaved VBO sizes

On Tue, May 24, 2016 at 5:01 PM, Jason Ekstrand wrote: > The buffer_range_* arrays are indexed by buffer index not element index. Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_draw_upload.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/sr

Re: [Mesa-dev] [PATCH v2] mesa: Add support for GL_CONTEXT_LOST

On May 24, 2016 10:25 PM, "Kristian Høgsberg" wrote: > > On Tue, May 24, 2016 at 5:22 PM, Ilia Mirkin wrote: > > Sorry to be pedantic, but you're enabling the ext for gles1.1, but the new > > entrypoint appear to only apply to gles2. I think you also want a es1="1.1" > > or something along those

[Mesa-dev] [PATCH v3] mesa: Enable GL_KHR_robustness

From: Kristian Høgsberg Kristensen GL_KHR_robustness adds the GL_CONTEXT_LOST error and five new entry points that we already implement. This patch adds a new dispatch table that returns GL_CONTEXT_LOST from all entry points and implements the GL_LOSE_CONTEXT_ON_RESET by setting that table when

Re: [Mesa-dev] [PATCH v2] mesa: Add support for GL_CONTEXT_LOST

On Tue, May 24, 2016 at 5:22 PM, Ilia Mirkin wrote: > Sorry to be pedantic, but you're enabling the ext for gles1.1, but the new > entrypoint appear to only apply to gles2. I think you also want a es1="1.1" > or something along those lines. The extension requires 2.0, so maybe we should instead o

Re: [Mesa-dev] [PATCH v2] mesa: Add support for GL_CONTEXT_LOST

On Tue, May 24, 2016 at 6:04 PM, Matt Turner wrote: > On Tue, May 24, 2016 at 4:58 PM, Kristian Høgsberg wrote: >> diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c >> b/src/mesa/drivers/dri/i965/intel_extensions.c >> index feea6ca..b8d7517 100644 >> --- a/src/mesa/drivers/dri/i965/intel

Re: [Mesa-dev] [PATCH] egl: Additional attribute validation for eglCreatePbufferSurface

On Tue, May 17, 2016 at 06:39:02PM +0100, Plamena Manolova wrote: > eglCreatePbufferSurface should generate an EGL_BAD_MATCH error if: > 1: The EGL_TEXTURE_FORMAT attribute is EGL_NO_TEXTURE and EGL_TEXTURE_TARGET > is something other than EGL_NO_TEXTURE > 2: EGL_TEXTURE_FORMAT is something other t

Re: [Mesa-dev] [PATCH 01/11] i965/compute: Fix uniform init issue when SIMD8 is skipped

On Tuesday, May 24, 2016 1:37:46 AM PDT Jordan Justen wrote: > In d8347f12ead89c5a58f69ce9283a54ac8487159c, we added support for > skipping SIMD8 generation when the program local size is too large for > SIMD8 to be usable. This change was missed in that commit. > > This bug would impact gen7 plat

Re: [Mesa-dev] [PATCH v2] mesa: Add support for GL_CONTEXT_LOST

On Tue, May 24, 2016 at 4:58 PM, Kristian Høgsberg wrote: > diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c > b/src/mesa/drivers/dri/i965/intel_extensions.c > index feea6ca..b8d7517 100644 > --- a/src/mesa/drivers/dri/i965/intel_extensions.c > +++ b/src/mesa/drivers/dri/i965/intel_exten

Re: [Mesa-dev] [PATCH 12/21] i965/fs: Clean up remaining uses of dispatch_width in the generator.

Jason Ekstrand writes: > Does this mean we can delete the field from brw_fs_generator? > Almost, there is still one use left in fire_fb_write() (for the dual source blend last-rt hack) which we will be able to get rid of eventually, but it cannot simply be replaced with inst->exec_size because it

Re: [Mesa-dev] [PATCH 18/21] i965/fs: Allow specifying arbitrary execution sizes up to 32 to FIND_LIVE_CHANNEL.

Kenneth Graunke writes: > On Tuesday, May 24, 2016 5:27:59 PM PDT Francisco Jerez wrote: >> Jason Ekstrand writes: >> >> > On Tue, May 24, 2016 at 12:18 AM, Francisco Jerez >> > wrote: >> > >> >> Due to a Gen7-specific hardware bug native 32-wide instructions get >> >> the lower 16 bits of the

Re: [Mesa-dev] [PATCH] i965/urb: fixes division by zero

On Tue, May 17, 2016 at 11:50:28AM -0700, Matt Turner wrote: > On Mon, May 16, 2016 at 4:27 PM, Ardinartsev Nikita > wrote: > > Fixes regression introduced by af5ca43f2676bff7499f93277f908b681cb821d0 > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95419 > > Thank you very much for the

[Mesa-dev] [PATCH 1/2] tgsi: s/6/PIPE_SHADER_TYPES/ for tgsi_processor_type_names array size

--- src/gallium/auxiliary/tgsi/tgsi_strings.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_strings.h b/src/gallium/auxiliary/tgsi/tgsi_strings.h index 031d322..9a9362e 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_strings.h +++ b/src/gallium/a

[Mesa-dev] [PATCH 2/2] tgsi: print TGSI_PROPERTY_NEXT_SHADER value as string, not an integer

Print "GEOM" instead of "2", for example. v2: also update the text parsing code, per Ilia. --- src/gallium/auxiliary/tgsi/tgsi_dump.c | 3 +++ src/gallium/auxiliary/tgsi/tgsi_text.c | 22 ++ 2 files changed, 25 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_dump.

Re: [Mesa-dev] [PATCH 18/21] i965/fs: Allow specifying arbitrary execution sizes up to 32 to FIND_LIVE_CHANNEL.

On Tuesday, May 24, 2016 5:27:59 PM PDT Francisco Jerez wrote: > Jason Ekstrand writes: > > > On Tue, May 24, 2016 at 12:18 AM, Francisco Jerez > > wrote: > > > >> Due to a Gen7-specific hardware bug native 32-wide instructions get > >> the lower 16 bits of the execution mask applied incorrectly

Re: [Mesa-dev] [PATCH 18/21] i965/fs: Allow specifying arbitrary execution sizes up to 32 to FIND_LIVE_CHANNEL.

Jason Ekstrand writes: > On Tue, May 24, 2016 at 12:18 AM, Francisco Jerez > wrote: > >> Due to a Gen7-specific hardware bug native 32-wide instructions get >> the lower 16 bits of the execution mask applied incorrectly to both >> halves of the instruction, so the MOV trick we currently use woul

Re: [Mesa-dev] [PATCH v2] mesa: Add support for GL_CONTEXT_LOST

On 05/24/2016 04:58 PM, Kristian Høgsberg wrote: > From: Kristian Høgsberg Kristensen > > As per GL_KHR_robustness, we have to return GL_CONTEXT_LOST from all > entry points when we lose a context. We do this by creating a new > dispatch table and setting that when we learn that we've lost the >

Re: [Mesa-dev] [PATCH 20/21] i965/ir: Make BROADCAST emit an unmasked single-channel move.

Jason Ekstrand writes: > On Tue, May 24, 2016 at 12:18 AM, Francisco Jerez > wrote: > >> Alternatively we could have extended the current semantics to 32-wide >> mode by changing brw_broadcast() to emit multiple indexed MOV >> instructions in the generator copying the selected value to all >> de

Re: [Mesa-dev] [PATCH v2] mesa: Add support for GL_CONTEXT_LOST

Sorry to be pedantic, but you're enabling the ext for gles1.1, but the new entrypoint appear to only apply to gles2. I think you also want a es1="1.1" or something along those lines. On May 24, 2016 8:02 PM, "Kristian Høgsberg" wrote: > From: Kristian Høgsberg Kristensen > > As per GL_KHR_robust

Re: [Mesa-dev] [PATCH 21/21] i965/fs: Expose arbitrary channel execution groups to the IR.

Jason Ekstrand writes: > On Tue, May 24, 2016 at 12:18 AM, Francisco Jerez > wrote: > >> This generalizes the current fs_inst::force_sechalf flag to allow >> specifying channel enable groups other than 0 or 8. At some point it >> will likely make sense to fix the vec4 generator to support arbit

Re: [Mesa-dev] [PATCH] gallium/radeon: add the kernel version into the renderer string

Do you need the DRM version number if you'll be displaying the kernel version anyway? On Wed, 25 May 2016 at 00:09 Marek Olšák wrote: > From: Marek Olšák > > Example: > Gallium 0.4 on AMD TONGA (DRM 3.2.0 / 4.5.0, LLVM 3.9.0) > > My kernel version is pretty long already (4.5.0-amd-01025-g32791c

[Mesa-dev] [PATCH] docs: add missing GL_OES/EXT_gpu_shader5 enablement note

Signed-off-by: Ilia Mirkin --- docs/relnotes/11.3.0.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/11.3.0.html b/docs/relnotes/11.3.0.html index 8d6caa2..e6ed538 100644 --- a/docs/relnotes/11.3.0.html +++ b/docs/relnotes/11.3.0.html @@ -61,6 +61,7 @@ Note: some of the new

[Mesa-dev] [PATCH v2] mesa: Add support for GL_CONTEXT_LOST

From: Kristian Høgsberg Kristensen As per GL_KHR_robustness, we have to return GL_CONTEXT_LOST from all entry points when we lose a context. We do this by creating a new dispatch table and setting that when we learn that we've lost the context. With the GL_CONTEXT_LOST reporting in place we can

[Mesa-dev] [PATCH] glsl: add GL_EXT_clip_cull_distance define, add helpers

Signed-off-by: Ilia Mirkin --- This addresses the feedback I got after pushing the enablement patch. docs/relnotes/11.3.0.html | 1 + src/compiler/glsl/builtin_variables.cpp | 10 -- src/compiler/glsl/glcpp/glcpp-parse.y | 2 ++ src/compiler/glsl/glsl_parser_extras.h

[Mesa-dev] [PATCH] i965/draw: Use the correct buffer index for interleaved VBO sizes

The buffer_range_* arrays are indexed by buffer index not element index. --- src/mesa/drivers/dri/i965/brw_draw_upload.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw_upload.c b/src/mesa/drivers/dri/i965/brw_draw_upload.c index 334916

[Mesa-dev] [PATCH 2/2] tgsi: print TGSI_PROPERTY_NEXT_SHADER value as string, not an integer

Print "GEOM" instead of "2", for example. --- src/gallium/auxiliary/tgsi/tgsi_dump.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_dump.c b/src/gallium/auxiliary/tgsi/tgsi_dump.c index 0d8bd1b..d59b7ff 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_dump.c ++

[Mesa-dev] [PATCH 1/2] tgsi: s/6/PIPE_SHADER_TYPES/ for tgsi_processor_type_names array size

--- src/gallium/auxiliary/tgsi/tgsi_strings.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_strings.h b/src/gallium/auxiliary/tgsi/tgsi_strings.h index 031d322..9a9362e 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_strings.h +++ b/src/gallium/a

Re: [Mesa-dev] [PATCH 2/2] tgsi: print TGSI_PROPERTY_NEXT_SHADER value as string, not an integer

Please adjust the parser to read this in as well. On Tue, May 24, 2016 at 7:45 PM, Brian Paul wrote: > Print "GEOM" instead of "2", for example. > --- > src/gallium/auxiliary/tgsi/tgsi_dump.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/gallium/auxiliary/tgsi/tgsi_dump.c > b/

[Mesa-dev] [PATCH] glsl: split out libstandalone

From: Rob Clark Split standalone glsl_compiler into a libstandalone.la and a thin main.cpp. This way drivers can re-use the glsl standalone frontend in their own standalone compilers. Signed-off-by: Rob Clark --- v2: fix scons build and fix automake hack src/compiler/Makefile.glsl.am| 1

Re: [Mesa-dev] [PATCH 20/21] i965/ir: Make BROADCAST emit an unmasked single-channel move.

On Tue, May 24, 2016 at 12:18 AM, Francisco Jerez wrote: > Alternatively we could have extended the current semantics to 32-wide > mode by changing brw_broadcast() to emit multiple indexed MOV > instructions in the generator copying the selected value to all > destination registers, but it seemed

Re: [Mesa-dev] [PATCH] i965: Add missing types to type_sz().

Reviewed-by: Jordan Justen On 2016-05-24 15:12:25, Matt Turner wrote: > Coverity warns in multiple places about the potential for division by > zero, caused by this function's default case. > > Cc: Francisco Jerez > --- > src/mesa/drivers/dri/i965/brw_reg.h | 6 +- > 1 file changed, 5 inse

Re: [Mesa-dev] [PATCH 00/21] i965: Scalar back-end support for SIMD32, part 2.

I sent a few fairly minor comments that I'd like to see addressed. Other than those, Reviewed-by: Jason Ekstrand On Tue, May 24, 2016 at 12:18 AM, Francisco Jerez wrote: > This should be enough to get the FS generator emitting 32-wide code > for at least compute shaders. Most of the work in

Re: [Mesa-dev] [PATCH 21/21] i965/fs: Expose arbitrary channel execution groups to the IR.

On Tue, May 24, 2016 at 12:18 AM, Francisco Jerez wrote: > This generalizes the current fs_inst::force_sechalf flag to allow > specifying channel enable groups other than 0 or 8. At some point it > will likely make sense to fix the vec4 generator to support arbitrary > execution groups and then

[Mesa-dev] [PATCH] mesa/program_interface_query: fix transform feedback varyings.

From: Dave Airlie The spec says gl_NextBuffer and gl_SkipComponents need to be returned to userspace in the program interface queries. We currently throw those away, this requires a complete piglit run to make sure no drivers fallover due to the extra varyings. This fixes: GL45-CTS.program_inte

[Mesa-dev] [PATCH] gallium/radeon: add the kernel version into the renderer string

From: Marek Olšák Example: Gallium 0.4 on AMD TONGA (DRM 3.2.0 / 4.5.0, LLVM 3.9.0) My kernel version is pretty long already (4.5.0-amd-01025-g32791c1) and adding "kernel" into the string would make too it long for glxinfo to display. --- src/gallium/drivers/radeon/r600_pipe_common.c | 12 +

Re: [Mesa-dev] [PATCH 18/21] i965/fs: Allow specifying arbitrary execution sizes up to 32 to FIND_LIVE_CHANNEL.

On Tue, May 24, 2016 at 12:18 AM, Francisco Jerez wrote: > Due to a Gen7-specific hardware bug native 32-wide instructions get > the lower 16 bits of the execution mask applied incorrectly to both > halves of the instruction, so the MOV trick we currently use wouldn't > work. Instead emit multip

Re: [Mesa-dev] [PATCH] mesa/extensions: Fix ES1 extension reporting

Reviewed-by: Ian Romanick On 05/24/2016 03:39 PM, Nanley Chery wrote: > From: Nanley Chery > > Commit eda15abd84af575d3bde432e2163e30d743a7c87 , unintentionally > advertised these extensions in ES1 contexts. Undo this error. > > Signed-off-by: Nanley Chery > --- > src/mesa/main/extensions_ta

[Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

According to the EGL specifications before binding an API we must check whether it's supported first. If not eglBindAPI should return EGL_FALSE and generate a EGL_BAD_PARAMETER error. Signed-off-by: Plamena Manolova --- src/egl/main/eglapi.c | 65 +

Re: [Mesa-dev] [PATCH] mesa/extensions: Fix ES1 extension reporting

Reviewed-by: Ilia Mirkin On Tue, May 24, 2016 at 6:39 PM, Nanley Chery wrote: > From: Nanley Chery > > Commit eda15abd84af575d3bde432e2163e30d743a7c87 , unintentionally > advertised these extensions in ES1 contexts. Undo this error. > > Signed-off-by: Nanley Chery > --- > src/mesa/main/extens

[Mesa-dev] [PATCH] mesa/extensions: Fix ES1 extension reporting

From: Nanley Chery Commit eda15abd84af575d3bde432e2163e30d743a7c87 , unintentionally advertised these extensions in ES1 contexts. Undo this error. Signed-off-by: Nanley Chery --- src/mesa/main/extensions_table.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/m

Re: [Mesa-dev] [PATCH 12/21] i965/fs: Clean up remaining uses of dispatch_width in the generator.

Does this mean we can delete the field from brw_fs_generator? On Tue, May 24, 2016 at 12:18 AM, Francisco Jerez wrote: > Most of these are bugs because the intended execution size of an > instruction and the dispatch width of the shader aren't necessarily > the same (especially in SIMD32 program

Re: [Mesa-dev] [PATCH 01/21] i965/eu: Define alternative interface for setting compression and group controls.

On Tue, May 24, 2016 at 2:05 AM, Michael Schellenberger < mschellenbergerco...@googlemail.com> wrote: > Hi curro, > > Am 24.05.2016 um 09:18 schrieb Francisco Jerez: > > This implements some simple helper functions that can be used to > > specify the group of channel enable signals and compression

Re: [Mesa-dev] [PATCH 01/21] i965/eu: Define alternative interface for setting compression and group controls.

On Tue, May 24, 2016 at 2:05 AM, Michael Schellenberger < mschellenbergerco...@googlemail.com> wrote: > Hi curro, > > Am 24.05.2016 um 09:18 schrieb Francisco Jerez: > > This implements some simple helper functions that can be used to > > specify the group of channel enable signals and compression

[Mesa-dev] [PATCH] i965: Add missing types to type_sz().

Coverity warns in multiple places about the potential for division by zero, caused by this function's default case. Cc: Francisco Jerez --- src/mesa/drivers/dri/i965/brw_reg.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_reg.h b/src/mesa

Re: [Mesa-dev] [PATCH] mesa: Add support for GL_CONTEXT_LOST

On Tue, May 24, 2016 at 2:30 PM, Kristian Høgsberg wrote: > diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c > b/src/mesa/drivers/dri/i965/intel_extensions.c > index feea6ca..b8d7517 100644 > --- a/src/mesa/drivers/dri/i965/intel_extensions.c > +++ b/src/mesa/drivers/dri/i965/intel_exten

[Mesa-dev] [PATCH] nir/algebraic: support for power-of-two optimizations

From: Rob Clark Some optimizations, like converting integer multiply/divide into left/ right shifts, have additional constraints on the search expression. Like requiring that a variable is a constant power of two. Support these cases by allowing a fxn name to be appended to the search var expres

[Mesa-dev] [PATCH] mesa: Add support for GL_CONTEXT_LOST

From: Kristian Høgsberg Kristensen As per GL_KHR_robustness, we have to return GL_CONTEXT_LOST from all entry points when we lose a context. We do this by creating a new dispatch table and setting that when we learn that we've lost the context. With the GL_CONTEXT_LOST reporting in place we can

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

On Tue, May 24, 2016 at 3:41 PM, Rob Clark wrote: > On Mon, May 16, 2016 at 3:16 PM, Jason Ekstrand wrote: >> On Mon, May 16, 2016 at 9:09 AM, Rob Clark wrote: >>> >>> On Mon, May 16, 2016 at 10:45 AM, Jason Ekstrand >>> wrote: >>> > >>> > On May 16, 2016 7:29 AM, "Rob Clark" wrote: >>> >> >>>

Re: [Mesa-dev] [PATCH 1/6] isl: Remove useless qualifier from return type.

On Tue, May 24, 2016 at 1:23 PM, Matt Turner wrote: > --- > src/intel/isl/isl_surface_state.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/isl/isl_surface_state.c > b/src/intel/isl/isl_surface_state.c > index dd88531..cc9c94a 100644 > --- a/src/intel/isl/isl

Re: [Mesa-dev] [PATCH 09/14] mesa_glinterop: fix GL interop *_VERSION comments

On Tue, May 24, 2016 at 10:16 PM, Emil Velikov wrote: > On 24 May 2016 at 17:38, Marek Olšák wrote: >> On Tue, May 24, 2016 at 4:32 PM, Emil Velikov >> wrote: >>> From: Emil Velikov >>> >>> Using the macro to set the version is wrong and ill-advised. Please don't >>> do it. >>> >>> Cc: Marek O

Re: [Mesa-dev] [PATCH 0/2] scons 2.5.0 support

On 05/24/2016 02:05 PM, Giuseppe Bilotta wrote: On Tue, May 24, 2016 at 6:13 PM, Brian Paul wrote: For both, Reviewed-by: Brian Paul Do you need me to push these for you? Well, AFAIK I don't have write access to the mesa git tree so yes please ;-) (Possibly with the extra commit lines with

[Mesa-dev] [PATCH 6/6] i965: Mark fallthrough in switch statement.

--- src/mesa/drivers/dri/i965/brw_eu_emit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c index d31943d..20fdfc1 100644 --- a/src/mesa/drivers/dri/i965/brw_eu_emit.c +++ b/src/mesa/drivers/dri/i965/brw_eu_emit

[Mesa-dev] [PATCH 2/6] isl: Mark default cases unreachable.

--- src/intel/isl/isl_surface_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c index cc9c94a..e96d3b0 100644 --- a/src/intel/isl/isl_surface_state.c +++ b/src/intel/isl/isl_surface_state.c @@ -166

[Mesa-dev] [PATCH 5/6] i965: Assert that a depth_mt exists when using HiZ.

--- src/mesa/drivers/dri/i965/brw_misc_state.c | 1 + src/mesa/drivers/dri/i965/gen6_depth_state.c | 1 + src/mesa/drivers/dri/i965/gen7_misc_state.c | 1 + src/mesa/drivers/dri/i965/gen8_depth_state.c | 1 + 4 files changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_misc_stat

[Mesa-dev] [PATCH 4/6] nir: Strengthen assertion that 'out' is nonnull.

--- src/compiler/nir/nir_lower_clamp_color_outputs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_lower_clamp_color_outputs.c b/src/compiler/nir/nir_lower_clamp_color_outputs.c index 68bfbed..ab211a4 100644 --- a/src/compiler/nir/nir_lower_clamp_color_o

[Mesa-dev] [PATCH 1/6] isl: Remove useless qualifier from return type.

--- src/intel/isl/isl_surface_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c index dd88531..cc9c94a 100644 --- a/src/intel/isl/isl_surface_state.c +++ b/src/intel/isl/isl_surface_state.c @@ -90,7 +9

[Mesa-dev] [PATCH 3/6] spriv: Mark default cases unreachable().

--- src/compiler/spirv/vtn_alu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/spirv/vtn_alu.c b/src/compiler/spirv/vtn_alu.c index 8b9a63c..5730ca4 100644 --- a/src/compiler/spirv/vtn_alu.c +++ b/src/compiler/spirv/vtn_alu.c @@ -356,6 +356,7 @@ vtn_handle_alu(struct vtn_build

Re: [Mesa-dev] [PATCH 09/14] mesa_glinterop: fix GL interop *_VERSION comments

On 24 May 2016 at 17:38, Marek Olšák wrote: > On Tue, May 24, 2016 at 4:32 PM, Emil Velikov > wrote: >> From: Emil Velikov >> >> Using the macro to set the version is wrong and ill-advised. Please don't >> do it. >> >> Cc: Marek Olšák >> Signed-off-by: Emil Velikov >> --- >> Marek, now things

Re: [Mesa-dev] [PATCH 0/2] scons 2.5.0 support

On Tue, May 24, 2016 at 6:13 PM, Brian Paul wrote: > For both, > Reviewed-by: Brian Paul > > Do you need me to push these for you? Well, AFAIK I don't have write access to the mesa git tree so yes please ;-) (Possibly with the extra commit lines with the full Bugzilla link that Emil posted for

Re: [Mesa-dev] [PATCH] glsl/distance: make sure we use clip dist varying slot for lowered var.

Reviewed-by: Ilia Mirkin On Tue, May 24, 2016 at 4:03 PM, Dave Airlie wrote: > From: Dave Airlie > > When lowering, we always want to use the clip dist varying. > > Signed-off-by: Dave Airlie > --- > src/compiler/glsl/lower_distance.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a

[Mesa-dev] [PATCH] glsl/distance: make sure we use clip dist varying slot for lowered var.

From: Dave Airlie When lowering, we always want to use the clip dist varying. Signed-off-by: Dave Airlie --- src/compiler/glsl/lower_distance.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/glsl/lower_distance.cpp b/src/compiler/glsl/lower_distance.cpp index 49a71c2..c215

[Mesa-dev] [PATCH] swr: [rasterizer] Correctly select optimized primitive assembly.

Indexed primitives were always using cut-aware primitive assembly, whether primitive_restart was enabled or not. Correctly pass down primitive_restart and select optimized PA when possible. --- src/gallium/drivers/swr/rasterizer/core/api.cpp|2 ++ .../drivers/swr/rasterizer/core/frontend.

[Mesa-dev] [PATCH] glapi/glx: Add overflow checks to the client-side indirect code

Coverity complains that the computed sizes can lead to negative lengths passed to memcpy. If that happens we've been handed invalid arguments anyway, so just bomb out. The funky "0%s" is because the size string for the variable-length part of the request is of the form "+ safe_pad() ...", and a un

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

On Mon, May 16, 2016 at 3:16 PM, Jason Ekstrand wrote: > On Mon, May 16, 2016 at 9:09 AM, Rob Clark wrote: >> >> On Mon, May 16, 2016 at 10:45 AM, Jason Ekstrand >> wrote: >> > >> > On May 16, 2016 7:29 AM, "Rob Clark" wrote: >> >> >> >> On Sat, May 14, 2016 at 4:03 PM, Jason Ekstrand >> >> wr

Re: [Mesa-dev] [PATCH 7/7] i965: Enable OES_copy_image (and EXT) on Gen8+ and Baytrail.

On Fri, May 20, 2016 at 6:35 PM, Kenneth Graunke wrote: > For now, only enable it on platforms that actually support ETC2. > > At this point, Broadwell is only failing 5 (out of 8358) dEQP tests: > dEQP-GLES31.functional.copy_image.non_compressed.viewclass_32_bits. >srgb8_alpha8_r11f_g11f_b10f

Re: [Mesa-dev] [PATCH] i965/gen7: Fix gl_HelperInvocation

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 05/10] mesa: Additional SSO validation using program_interface_query data

On 05/20/2016 06:03 PM, Timothy Arceri wrote: > On Fri, 2016-05-20 at 00:26 -0700, Ian Romanick wrote: >> From: Ian Romanick >> >> Fixes the following dEQP tests on SKL: >> >> dEQP- >> GLES31.functional.separate_shader.validation.varying.mismatch_qualifi >> er_vertex_smooth_fragment_flat >> dEQP-

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

On 05/23/2016 07:45 AM, Marek Olšák wrote: > I think it would be better to put stuff like this only into the > renderer string of drivers which use LLVM. The majority of drivers > don't care about the LLVM version. Yes. In fact, I *really* don't want the LLVM version to show up in the glxinfo fro

Re: [Mesa-dev] [PATCH 04/10] mesa: Check isES before calling validate_io

On 05/20/2016 05:46 PM, Timothy Arceri wrote: > On Fri, 2016-05-20 at 00:25 -0700, Ian Romanick wrote: >> From: Ian Romanick >> >> There's going to be a second validate_io function, and checking the >> same >> thing twice is silly. > > I think we should just do this check > in _mesa_validate_prog

Re: [Mesa-dev] [PATCH 0/7] i965, anv: Use ISL for querying surface format capabilities

On Tue, May 24, 2016 at 1:47 PM, Nanley Chery wrote: > On Mon, May 23, 2016 at 02:07:41PM -0700, Jason Ekstrand wrote: >> On Mon, May 23, 2016 at 10:41 AM, Nanley Chery >> wrote: >> >> > On Fri, May 20, 2016 at 06:12:34PM -0700, Jason Ekstrand wrote: >> > > This little series effectively moves th

Re: [Mesa-dev] [PATCH 0/7] i965, anv: Use ISL for querying surface format capabilities

On Mon, May 23, 2016 at 02:07:41PM -0700, Jason Ekstrand wrote: > On Mon, May 23, 2016 at 10:41 AM, Nanley Chery > wrote: > > > On Fri, May 20, 2016 at 06:12:34PM -0700, Jason Ekstrand wrote: > > > This little series effectively moves the surface format table from > > > brw_surface_formats.c into

Re: [Mesa-dev] [PATCH 00/29] Make more use of bitmasks

On 05/24/2016 12:41 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Hi all, following a series with performance improvements for cpu/draw bound applications. This part makes more use of the bitmask/ffs technique for iterating a set of enabled items. The gains are not huge but they

Re: [Mesa-dev] [PATCH 0/6] update swr rasterizer

Reviewed-by: Bruce Cherniak minus the knob.h change to disable cut-aware primitive assembler. New change for that coming today. > On May 20, 2016, at 2:08 PM, Rowley, Timothy O > wrote: > > Bruce, is cut-aware needed for primitive restart? > >> On May 20, 2016, at 11:58 AM, Rowley, Timothy

Re: [Mesa-dev] [PATCH 02/14] Revert "mesa: Build EGL without X11 headers after interop patchset"

On Tue, May 24, 2016 at 03:32:44PM +0100, Emil Velikov wrote: > From: Emil Velikov > > This reverts commit 4e2c9a04354b6b133845b8b93c0c5d34261a91d0. > > The solution was incomplete and fragile. An alternative one is coming > shortly. Tested-by: Tom Stellard > --- > include/GL/mesa_glinterop.

  1   2   >