[Mesa-dev] [PATCH 28/29] vbo: Use a bitmask to track the active arrays in vbo_exec*.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich The use of a bitmask makes functions iterating only active attributes less visible in profiles. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_exec.h | 1 + src/mesa/vbo/vbo_exec_api.c | 149 +++ src/mesa/vbo/vbo_exec

[Mesa-dev] [PATCH 27/29] mesa: Use bitmask/ffs to iterate the active_samplers bitmask.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. Signed-off-by: Mathias Fröhlich --- src/mesa/main/uniform_query.cpp | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/uni

[Mesa-dev] [PATCH 25/29] mesa: Use designated bool value to check texture unit completeness.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich The change helps to use the bitmask/ffs in the next change. Signed-off-by: Mathias Fröhlich --- src/mesa/main/texstate.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index 9ee5c69..3543369 100

[Mesa-dev] [PATCH 23/29] i965: Use bitmask/ffs to iterate used vertex attributes.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/i965/brw_draw.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/

[Mesa-dev] [PATCH 26/29] mesa: Use bitmask/ffs to iterate the enabled textures.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. Signed-off-by: Mathias Fröhlich --- src/mesa/main/texstate.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git

[Mesa-dev] [PATCH 29/29] vbo: Use a bitmask to track the active arrays in vbo_save*.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich The use of a bitmask makes functions iterating only active attributes less visible in profiles. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_save.h | 2 ++ src/mesa/vbo/vbo_save_api.c | 70 ++-- src/mesa/vbo/vbo_save

[Mesa-dev] [PATCH 22/29] i965: Use bitmask/ffs to iterate enabled clip planes.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/i965/brw_curbe.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --g

[Mesa-dev] [PATCH 24/29] mesa: Use bitmask/ffs to iterate SamplersUsed

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. Signed-off-by: Mathias Fröhlich --- src/mesa/main/uniforms.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-)

[Mesa-dev] [PATCH 20/29] mesa: Use bitmask/ffs to iterate enabled clip planes.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/common/meta.c | 23 +++ src/mesa/main/matrix.c | 19 ++-- src/mesa/main/rastpos.

[Mesa-dev] [PATCH 21/29] radeon/r200: Use bitmask/ffs to iterate enabled clip planes.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/r200/r200_state.c | 24 src/mesa/drivers/dri/radeon/radeon_state.c | 24 +++

[Mesa-dev] [PATCH 19/29] mesa: Use bitmask/ffs to iterate color material attributes.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. Signed-off-by: Mathias Fröhlich --- src/mesa/main/light.c | 12 +++- src/mesa/tnl/t_vb_light.c | 11 +++ 2 files changed, 14 insertions(+), 9

[Mesa-dev] [PATCH 18/29] mesa: Use bitmask/ffs to build ff fragment shader keys.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. The bitmask used here for iteration is a combination of different enabled masks present for texture units. Signed-off-by: Mathias Fröhlich --- src/mesa/main/ff_f

[Mesa-dev] [PATCH 15/29] mesa: Switch to bitmask based enabled lights in gen_matypes.c

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/x86/gen_matypes.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/x86/gen_matypes.c b/src/mesa/x86/gen_matypes.c index 18ffb72..fc06dc7 100644 --- a/src/mesa/x86/gen_matypes.c +++ b/src/mesa/x86/

[Mesa-dev] [PATCH 03/29] gallium: Convert the state_tracker to use CoordsReplaceBits.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Switch over to use the CoordsReplaceBits bitmask. Signed-off-by: Mathias Fröhlich --- src/mesa/state_tracker/st_atom_rasterizer.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_rasterizer.c b/src/mesa/state_tra

[Mesa-dev] [PATCH 07/29] mesa: Remove the now unused CoordsReplace array.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Now that all users are converted, remove the array. Signed-off-by: Mathias Fröhlich --- src/mesa/main/mtypes.h | 1 - src/mesa/main/points.c | 5 - src/mesa/main/texenv.c | 2 -- 3 files changed, 8 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mty

[Mesa-dev] [PATCH 04/29] r200: convert r200 to use CoordsReplaceBits.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Switch over to use the CoordsReplaceBits bitmask. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/r200/r200_state.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/r200/r200_state.c b/src/mesa/drivers/dri/r200/r20

[Mesa-dev] [PATCH 09/29] mesa: Track enabled lights in a bitmask

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich This enables some optimizations afterwards. Signed-off-by: Mathias Fröhlich --- src/mesa/main/enable.c | 2 ++ src/mesa/main/light.c | 1 + src/mesa/main/mtypes.h | 2 ++ 3 files changed, 5 insertions(+) diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c inde

[Mesa-dev] [PATCH 10/29] mesa: Use bitmask/ffs to iterate enabled lights

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces loops that iterate all lights and test which of them is enabled by a loop only iterating over the bits set in the enabled bitmask. Signed-off-by: Mathias Fröhlich --- src/mesa/main/light.c | 55 ++--- src/mesa/main/r

[Mesa-dev] [PATCH 13/29] nouveau: Use bitmask/ffs to iterate enabled lights

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces a loop that iterates all lights and test which of them is enabled by a loop only iterating over the bits set in the enabled bitmask. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/nouveau/nouveau_state.c | 10 + src/mesa/drivers/dri/nouveau/nv

[Mesa-dev] [PATCH 08/29] mesa: Rename CoordReplaceBits back to CoordReplace.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich It used to be called like that and fits better with 80 columns. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/i915/i915_state.c | 2 +- src/mesa/drivers/dri/i965/brw_sf.c | 2 +- src/mesa/drivers/dri/i965/brw_vs.c | 2 +- src/mesa/dri

[Mesa-dev] [PATCH 16/29] mesa: Remove the linked list of enabled lights

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Clean up after conversion to bitmasks. Signed-off-by: Mathias Fröhlich --- src/mesa/main/context.c | 11 +-- src/mesa/main/enable.c | 4 src/mesa/main/light.c | 4 src/mesa/main/mtypes.h | 4 4 files changed, 1 insertion(+), 22 deletions(-)

[Mesa-dev] [PATCH 01/29] mesa: Add gl_point_attrib::CoordReplaceBits bitfield.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich The aim is to replace the CoordReplace array by a bitfield. Until all drivers are converted, establish the bitfield in paralell to the CoordReplace array. Signed-off-by: Mathias Fröhlich --- src/mesa/main/attrib.c| 2 +- src/mesa/main/ffvertex_prog.c | 2 +- sr

[Mesa-dev] [PATCH 17/29] mesa: Use bitmask/ffs to build ff vertex shader keys.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. The bitmask used here for iteration is a combination of different enabled masks present for texture units. Signed-off-by: Mathias Fröhlich --- src/mesa/main/ffve

[Mesa-dev] [PATCH 12/29] tnl: Use bitmask/ffs to iterate enabled lights

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces loops that iterate all lights and test which of them is enabled by a loop only iterating over the bits set in the enabled bitmask. --- src/mesa/tnl/t_vb_light.c| 2 +- src/mesa/tnl/t_vb_lighttmp.h | 27 --- 2 files changed, 21 insertio

[Mesa-dev] [PATCH 05/29] i915: Convert i915 to use CoordsReplaceBits.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Switch over to use the CoordsReplaceBits bitmask. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/i915/i915_state.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i915/i915_state.c b/src/mesa/drivers/

[Mesa-dev] [PATCH 00/29] Make more use of bitmasks

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi all, following a series with performance improvements for cpu/draw bound applications. This part makes more use of the bitmask/ffs technique for iterating a set of enabled items. The gains are not huge but they are noticable for some of my favourite workloads. Please r

[Mesa-dev] [PATCH 06/29] i965: Convert i965 to use CoordsReplaceBits.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Switch over to use the CoordsReplaceBits bitmask. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/i965/brw_sf.c| 7 +-- src/mesa/drivers/dri/i965/brw_vs.c| 6 +- src/mesa/drivers/dri/i965/gen6_sf_state.c | 2 +- 3 files changed, 3 inserti

[Mesa-dev] [PATCH 14/29] radeon/r200: Use bitmask/ffs to iterate enabled lights

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces a loop that iterates all lights and test which of them is enabled by a loop only iterating over the bits set in the enabled bitmask. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/r200/r200_state.c | 40 ++-- src/mesa/driver

[Mesa-dev] [PATCH 11/29] mesa: Use bitmask/ffs to iterate enabled lights for building ff shader keys.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces a loop that iterates all lights and test which of them is enabled by a loop only iterating over the bits set in the enabled bitmask. Signed-off-by: Mathias Fröhlich --- src/mesa/main/ffvertex_prog.c | 28 +++- 1 file changed, 15 insertion

[Mesa-dev] [PATCH 02/29] swrast: Convert swrast to use CoordsReplaceBits.

2016-05-23 Thread Mathias . Froehlich
From: Mathias Fröhlich Switch over to use the CoordsReplaceBits bitmask. Signed-off-by: Mathias Fröhlich --- src/mesa/swrast/s_points.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/swrast/s_points.c b/src/mesa/swrast/s_points.c index 3163b04..8212850 100644

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-23 Thread Giuseppe Bilotta
On Tue, May 24, 2016 at 1:03 AM, Vedran Miletic wrote: > > What is the state of MESA_LLVM_VERSION_STRING if you build Mesa on a system > without LLVM? I set it to the empty string. -- Giuseppe "Oblomov" Bilotta ___ mesa-dev mailing list mesa-dev@lists

[Mesa-dev] [PATCH] docs/egl: Android platform can also be build using autotools

2016-05-23 Thread Nicolas Boichat
We added support for Android build using autotools (configure), update the documentation to reflect that. Signed-off-by: Nicolas Boichat --- docs/egl.html | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/egl.html b/docs/egl.html index bc21c6c..fb94f8c 100644 --- a

[Mesa-dev] [PATCH] automake: egl: Android: Add libEGL dependencies

2016-05-23 Thread Nicolas Boichat
platform_android.c needs to link with cutils, hardware, and sync libraries, as well as drm_gralloc libs. Also add appropriate tests in configure.ac. Signed-off-by: Nicolas Boichat --- configure.ac| 6 ++ src/egl/Makefile.am | 3 +++ 2 files changed, 9 insertions(+) diff --git a/con

Re: [Mesa-dev] [PATCH] i965/fs: Fix off-by-one region overlap comparison in copy propagation.

2016-05-23 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On 24/05/16 05:34, Francisco Jerez wrote: > This was introduced in cf375ae54a01462f192202d609436e5fbec8 but > the blame is mine because the pseudocode I sent in my review comment > for the original patch suggesting to do things this way already had > the

Re: [Mesa-dev] [PATCH 2/2] i965: deindent blorp code.

2016-05-23 Thread Pohjolainen, Topi
On Tue, May 24, 2016 at 10:00:07AM +1000, Dave Airlie wrote: > From: Dave Airlie > > gcc6 warns about this. Thanks for doing this, it has been on my list, just kept forgetting it. Reviewed-by: Topi Pohjolainen > > Signed-off-by: Dave Airlie > --- > src/mesa/drivers/dri/i965/gen7_blorp.c |

[Mesa-dev] [PATCH] nvc0: enable 32 textures on kepler+

2016-05-23 Thread Ilia Mirkin
For fermi, this likely will require use of linked tsc mode. However on bindless architectures, we can have as many as we want. As it stands, the AUX_TEX_INFO has 32 teture handles reserved. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nvc0/nvc0_context.h | 2 +- src/gallium/driver

[Mesa-dev] [PATCH] i965/gen7: Fix gl_HelperInvocation

2016-05-23 Thread Jordan Justen
It appears that UV immediates aren't working on Ivy Bridge. In this case, a signed version will work, and this fixes the piglit tests/spec/glsl-4.50/execution/helper-invocation.shader_test test. Signed-off-by: Jordan Justen Cc: Matt Turner --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 +- 1

Re: [Mesa-dev] [PATCH] mesa: remove separate enable for KHR_robust_buffer_access_behavior

2016-05-23 Thread Jason Ekstrand
Fine with me Acked-by: Jason Ekstrand On Mon, May 23, 2016 at 7:44 PM, Ilia Mirkin wrote: > This extension appears to be a strict subset of the ARB version. Also > remove it from GL3.txt since it doesn't seem relevant. > > Signed-off-by: Ilia Mirkin > --- > > Let me know if you think I'm miss

Re: [Mesa-dev] [PATCH] nir/spirv: Make unhandled decorations a warning rather than unreachable()

2016-05-23 Thread Jason Ekstrand
On Mon, May 23, 2016 at 7:49 PM, Matt Turner wrote: > On Mon, May 23, 2016 at 6:43 PM, Jason Ekstrand > wrote: > > This prevents SPIR-V -> NIR from dying if we get a decoration we don't > know > > about. Compiling incorrect code is probably a better failure mode than > > dying horribly. > > > >

[Mesa-dev] [PATCH] i965/fs: Fix off-by-one region overlap comparison in copy propagation.

2016-05-23 Thread Francisco Jerez
This was introduced in cf375ae54a01462f192202d609436e5fbec8 but the blame is mine because the pseudocode I sent in my review comment for the original patch suggesting to do things this way already had the off-by-one error. This may have caused copy propagation to be unnecessarily strict while

[Mesa-dev] [PATCH] docs: true up nvc0 status - images, etc

2016-05-23 Thread Ilia Mirkin
Images aren't supported on maxwell, but neither is tessellation. Don't overly confuse matters by trying to expose those subtleties in the GL3.txt file/relnotes. Signed-off-by: Ilia Mirkin --- docs/GL3.txt | 10 +- docs/relnotes/11.3.0.html | 13 - 2 files changed

[Mesa-dev] [PATCH] st/mesa: enable ARB_ES3_1_compatibility when ES 3.1 would be exposed

2016-05-23 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- docs/GL3.txt | 2 +- docs/relnotes/11.3.0.html | 1 + src/mesa/state_tracker/st_extensions.c | 22 ++ 3 files changed, 24 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 4a9cf0

Re: [Mesa-dev] [PATCH] nir/spirv: Make unhandled decorations a warning rather than unreachable()

2016-05-23 Thread Matt Turner
On Mon, May 23, 2016 at 6:43 PM, Jason Ekstrand wrote: > This prevents SPIR-V -> NIR from dying if we get a decoration we don't know > about. Compiling incorrect code is probably a better failure mode than > dying horribly. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95573 We want

[Mesa-dev] [PATCH] mesa: remove separate enable for KHR_robust_buffer_access_behavior

2016-05-23 Thread Ilia Mirkin
This extension appears to be a strict subset of the ARB version. Also remove it from GL3.txt since it doesn't seem relevant. Signed-off-by: Ilia Mirkin --- Let me know if you think I'm missing something. From the KHR spec: 3) How does this extension differ from ARB_robust_buffer_acce

[Mesa-dev] [PATCH] nir/spirv: Make unhandled decorations a warning rather than unreachable()

2016-05-23 Thread Jason Ekstrand
This prevents SPIR-V -> NIR from dying if we get a decoration we don't know about. Compiling incorrect code is probably a better failure mode than dying horribly. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95573 --- src/compiler/spirv/spirv_to_nir.c | 6 -- src/compiler/spirv/v

[Mesa-dev] [PATCH] glsl: add EXT_clip_cull_distance support based on ARB_cull_distance

2016-05-23 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/compiler/glsl/builtin_variables.cpp | 12 +++ src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 2 ++ src/compiler/glsl/linker.cpp | 35 ++-- src/mesa/main/extensions_tab

[Mesa-dev] [PATCH V2] glsl: add support for doubles in GL 4.4+

2016-05-23 Thread Timothy Arceri
We disable varying packing in GL 4.4+ as we can no longer assume varying have the same interpolation qualifiers. However doubles used as fs inputs must always be qualified as "flat" and backends expect doubles to have been packed as floats so we enable packing for them. V2: fix comments and only c

[Mesa-dev] [PATCH 4/3] glsl: add GL_EXT_geometry_point_size support

2016-05-23 Thread Ilia Mirkin
This mirrors existing GL_OES_geometry_point_size support. Signed-off-by: Ilia Mirkin --- src/compiler/glsl/builtin_variables.cpp | 3 ++- src/compiler/glsl/glcpp/glcpp-parse.y| 2 ++ src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 2 ++ src/mesa/ma

Re: [Mesa-dev] [PATCH v3 08/16] i965/surface_formats: Update the VB column for new formats added on BYT

2016-05-23 Thread Jason Ekstrand
On Mon, May 23, 2016 at 3:51 PM, Kenneth Graunke wrote: > On Friday, May 20, 2016 4:53:19 PM PDT Jason Ekstrand wrote: > > Bay Trail and Haswell added a bunch of new vertex formats. There was > also > > the addition of 64-bit passthrough formats for BDW+. > > --- > > src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH 2/3] glsl: allow invocations to be specified in ES 3.20 + exts

2016-05-23 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/compiler/glsl/builtin_variables.cpp | 3 ++- src/compiler/glsl/glsl_parser.yy| 6 -- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/builtin_variables.cpp b/src/compiler/glsl/builtin_variables.cpp index ff8a7e2..e082

[Mesa-dev] [PATCH 3/3] glsl: expose gl_Layer in fs for ES 3.20 + exts

2016-05-23 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/compiler/glsl/builtin_variables.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/builtin_variables.cpp b/src/compiler/glsl/builtin_variables.cpp index e082572..d78ac88 100644 --- a/src/compiler/glsl/builtin_variable

[Mesa-dev] [PATCH 1/3] glsl: add GL_EXT_geometry_shader extension support

2016-05-23 Thread Ilia Mirkin
From: Kenneth Graunke [imirkin: add FramebufferTextureEXT entrypoint] Signed-off-by: Ilia Mirkin --- src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 6 +- src/mapi/glapi/gen/es_EXT.xml| 11 +++ src/mesa/main/extensions_table.h

Re: [Mesa-dev] [PATCH] st/va: use drm render node for wayland display type

2016-05-23 Thread Emil Velikov
On 17 May 2016 at 20:16, Leo Liu wrote: > With xwayland, vainfo use VA_DISPLAY_WAYLAND as default and it fails > and fails when specify display with `vainfo --display wayland`. > In fact wayland support for libva uses drm path to connect device, > and should use drm pipe loader to create screen.

Re: [Mesa-dev] [RFC PATCH] GBM: Add map/unmap functions

2016-05-23 Thread Rob Clark
On Mon, May 23, 2016 at 8:12 PM, Emil Velikov wrote: > On 23 May 2016 at 22:19, Rob Clark wrote: >> On Mon, May 23, 2016 at 5:16 PM, Mark Janes wrote: >>> I run a buildtest in our CI to help Intel engineers avoid breaking the >>> builds for other Mesa targets. >>> >>> With this commit, it produc

Re: [Mesa-dev] [RFC PATCH] GBM: Add map/unmap functions

2016-05-23 Thread Rob Herring
On Mon, May 23, 2016 at 7:12 PM, Emil Velikov wrote: > On 23 May 2016 at 22:19, Rob Clark wrote: >> On Mon, May 23, 2016 at 5:16 PM, Mark Janes wrote: >>> I run a buildtest in our CI to help Intel engineers avoid breaking the >>> builds for other Mesa targets. >>> >>> With this commit, it produc

Re: [Mesa-dev] [PATCH 1/2] Unify OpenGL and OpenCL version string suffix

2016-05-23 Thread Emil Velikov
On 23 May 2016 at 22:11, Giuseppe Bilotta wrote: > Hello Emil, > > On Mon, May 23, 2016 at 11:20 AM, Emil Velikov > wrote: >> It seems like this won't work if one builds --enable-clover --disable-dri. > > Argh, I hadn't considered this possibility. > >> The following should keep mesa and gallium

Re: [Mesa-dev] [PATCH 2/2] i965: deindent blorp code.

2016-05-23 Thread Matt Turner
On Mon, May 23, 2016 at 5:00 PM, Dave Airlie wrote: > From: Dave Airlie > > gcc6 warns about this. > > Signed-off-by: Dave Airlie > --- > src/mesa/drivers/dri/i965/gen7_blorp.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH 1/2] glsl: reindent line in ast_function.cpp

2016-05-23 Thread Matt Turner
On Mon, May 23, 2016 at 5:00 PM, Dave Airlie wrote: > From: Dave Airlie > > This fixes a warning with gcc -Wmisleading-indentation. > > Signed-off-by: Dave Airlie Both are Acked-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.or

Re: [Mesa-dev] [RFC PATCH] GBM: Add map/unmap functions

2016-05-23 Thread Emil Velikov
On 23 May 2016 at 22:19, Rob Clark wrote: > On Mon, May 23, 2016 at 5:16 PM, Mark Janes wrote: >> I run a buildtest in our CI to help Intel engineers avoid breaking the >> builds for other Mesa targets. >> >> With this commit, it produces: >> >> make[2]: Entering directory '/home/majanes/src/mesa

[Mesa-dev] [PATCH 2/2] i965: deindent blorp code.

2016-05-23 Thread Dave Airlie
From: Dave Airlie gcc6 warns about this. Signed-off-by: Dave Airlie --- src/mesa/drivers/dri/i965/gen7_blorp.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_blorp.c b/src/mesa/drivers/dri/i965/gen7_blorp.c index 3584864..

[Mesa-dev] [PATCH 1/2] glsl: reindent line in ast_function.cpp

2016-05-23 Thread Dave Airlie
From: Dave Airlie This fixes a warning with gcc -Wmisleading-indentation. Signed-off-by: Dave Airlie --- src/compiler/glsl/ast_function.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_function.cpp b/src/compiler/glsl/ast_function.cpp index 6c12565

Re: [Mesa-dev] [PATCH v3 13/16] glsl: Add an option to clamp block indices when lowering UBO/SSBOs

2016-05-23 Thread Timothy Arceri
On Mon, 2016-05-23 at 16:07 -0700, Kenneth Graunke wrote: > On Friday, May 20, 2016 4:53:24 PM PDT Jason Ekstrand wrote: > > > > This prevents array overflow when the block is actually an array of > > UBOs or > > SSBOs.  On some hardware such as i965, such overflows can cause GPU > > hangs. > > >

Re: [Mesa-dev] [PATCH 00/31] i965: Scalar back-end support for SIMD32, part 1.

2016-05-23 Thread Francisco Jerez
Jason Ekstrand writes: > On Fri, May 20, 2016 at 10:47 PM, Francisco Jerez > wrote: > >> The purpose of this series is to improve the back-end infrastructure >> so that lowering of most IR instructions that are too wide to execute >> natively (which is far more common than usual in SIMD32 dispat

Re: [Mesa-dev] [PATCH] glsl: Use correct mode for split components.

2016-05-23 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2016-04-20 06:42:01, Bas Nieuwenhuizen wrote: > The mode should stay the same as the original struct. In > particular, shared should not be changed to temporary. > > Signed-off-by: Bas Nieuwenhuizen > --- > src/compiler/glsl/opt_structure_splitting.cpp | 2 +- > 1

Re: [Mesa-dev] [PATCH 00/31] i965: Scalar back-end support for SIMD32, part 1.

2016-05-23 Thread Jason Ekstrand
On Fri, May 20, 2016 at 10:47 PM, Francisco Jerez wrote: > The purpose of this series is to improve the back-end infrastructure > so that lowering of most IR instructions that are too wide to execute > natively (which is far more common than usual in SIMD32 dispatch mode) > happens semi-automatic

Re: [Mesa-dev] [PATCH v3 13/16] glsl: Add an option to clamp block indices when lowering UBO/SSBOs

2016-05-23 Thread Kenneth Graunke
On Friday, May 20, 2016 4:53:24 PM PDT Jason Ekstrand wrote: > This prevents array overflow when the block is actually an array of UBOs or > SSBOs. On some hardware such as i965, such overflows can cause GPU hangs. > > Reviewed-by: Ian Romanick > --- > src/compiler/glsl/ir_optimization.h

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-23 Thread Vedran Miletic
On 05/23/2016 09:21 AM, Giuseppe Bilotta wrote: Code generation (kernel compilation) may sometimes hit LLVM-specific bugs. Adding the used LLVM version to the version string may make bug triaging easier. (This was inspired by a similar patch recently proposed for pocl.) Signed-off-by: Giuseppe B

Re: [Mesa-dev] [PATCH v3 08/16] i965/surface_formats: Update the VB column for new formats added on BYT

2016-05-23 Thread Kenneth Graunke
On Friday, May 20, 2016 4:53:19 PM PDT Jason Ekstrand wrote: > Bay Trail and Haswell added a bunch of new vertex formats. There was also > the addition of 64-bit passthrough formats for BDW+. > --- > src/mesa/drivers/dri/i965/brw_surface_formats.c | 32 +++ +- > 1 file changed

Re: [Mesa-dev] [PATCH] st/mesa: use transfer_inline_write for memcpy TexSubImage path

2016-05-23 Thread Marek Olšák
On Mon, May 23, 2016 at 10:31 PM, Miklós Máté wrote: > On 05/20/2016 05:42 PM, Ilia Mirkin wrote: >> >> On Fri, May 20, 2016 at 11:39 AM, Rob Herring wrote: >>> >>> On Mon, May 9, 2016 at 6:38 AM, Marek Olšák wrote: From: Marek Olšák This allows drivers to use their own fast

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-23 Thread Vedran Miletic
On 05/24/2016 12:46 AM, Marek Olšák wrote: On Mon, May 23, 2016 at 10:47 PM, Giuseppe Bilotta wrote: On Mon, May 23, 2016 at 4:45 PM, Marek Olšák wrote: I think it would be better to put stuff like this only into the renderer string of drivers which use LLVM. The majority of drivers don't car

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-23 Thread Marek Olšák
On Mon, May 23, 2016 at 10:47 PM, Giuseppe Bilotta wrote: > On Mon, May 23, 2016 at 4:45 PM, Marek Olšák wrote: >> I think it would be better to put stuff like this only into the >> renderer string of drivers which use LLVM. The majority of drivers >> don't care about the LLVM version. > > Hm, th

Re: [Mesa-dev] [PATCH] glsl: fix explicit location validation for doubles

2016-05-23 Thread Anuj Phogat
On Sun, May 22, 2016 at 8:11 PM, Timothy Arceri wrote: > Previously we would fail to find a match for the second half of a > dvec4 as 'i' would get incremented to 1 before we added the var to > the array at component 0. > --- > src/compiler/glsl/link_varyings.cpp | 4 +++- > 1 file changed, 3 ins

Re: [Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-05-23 Thread Manolova, Plamena
Hi Brian, On Mon, May 23, 2016 at 9:51 PM, Brian Paul wrote: > Hi Plamena, > > Some style nitpicks below. Feel free to take 'em or leave 'em. > I'm not too involved in EGL. > > > > On 05/23/2016 10:27 AM, Plamena Manolova wrote: > >> According to the EGL specifications before binding an API >>

Re: [Mesa-dev] [RFC PATCH] GBM: Add map/unmap functions

2016-05-23 Thread Mark Janes
Rob Clark writes: > On Mon, May 23, 2016 at 5:16 PM, Mark Janes wrote: >> I run a buildtest in our CI to help Intel engineers avoid breaking the >> builds for other Mesa targets. >> >> With this commit, it produces: >> >> make[2]: Entering directory '/home/majanes/src/mesa/src/gbm' >> CCLD

Re: [Mesa-dev] [PATCH] mesa: raise error for glEnable(GL_VERTEX_ARRAY), etc. in core profile

2016-05-23 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Mon, May 23, 2016 at 5:15 PM, Brian Paul wrote: > Otherwise, if the call executes normally we'll hit an assertion later > in the VBO code when we draw something. Note that these cases were > already handled correctly for the glIsEnabled() function (and the API > chec

Re: [Mesa-dev] [PATCH 2/4] glsl: rewrite clip/cull distance lowering pass

2016-05-23 Thread Ilia Mirkin
On Mon, May 23, 2016 at 5:12 PM, Dave Airlie wrote: > On 24 May 2016 at 06:56, Ilia Mirkin wrote: >> On Thu, May 19, 2016 at 11:47 PM, Dave Airlie wrote: >>> From: Dave Airlie >>> >>> The last version of this broke clipping, and I had to spend >>> sometime getting this working properly. >>> >>>

Re: [Mesa-dev] [RFC PATCH] GBM: Add map/unmap functions

2016-05-23 Thread Rob Clark
On Mon, May 23, 2016 at 5:16 PM, Mark Janes wrote: > I run a buildtest in our CI to help Intel engineers avoid breaking the > builds for other Mesa targets. > > With this commit, it produces: > > make[2]: Entering directory '/home/majanes/src/mesa/src/gbm' > CCLD libgbm.la > backends/dri/.li

Re: [Mesa-dev] [RFC PATCH] GBM: Add map/unmap functions

2016-05-23 Thread Mark Janes
I run a buildtest in our CI to help Intel engineers avoid breaking the builds for other Mesa targets. With this commit, it produces: make[2]: Entering directory '/home/majanes/src/mesa/src/gbm' CCLD libgbm.la backends/dri/.libs/gbm_dri.o: In function `mtx_init': /home/majanes/src/mesa/src/g

Re: [Mesa-dev] [PATCH 2/2] mesa: log buffer ID numbers in decimal, not hexidecimal

2016-05-23 Thread Anuj Phogat
On Mon, May 23, 2016 at 2:01 PM, Brian Paul wrote: > Err, "hexadecimal". Will fixe before pushing. > > > On 05/23/2016 03:00 PM, Brian Paul wrote: >> >> All the other error messages use decimal. Let's be consistent. >> --- >> src/mesa/main/bufferobj.c | 4 ++-- >> 1 file changed, 2 insertions

[Mesa-dev] [PATCH] mesa: raise error for glEnable(GL_VERTEX_ARRAY), etc. in core profile

2016-05-23 Thread Brian Paul
Otherwise, if the call executes normally we'll hit an assertion later in the VBO code when we draw something. Note that these cases were already handled correctly for the glIsEnabled() function (and the API checks were copied from there). Tested with new piglit gl-3.1-enable-vertex-array test. v

Re: [Mesa-dev] [PATCH] mesa: raise error for glEnable(GL_VERTEX_ARRAY), etc. in core profile

2016-05-23 Thread Brian Paul
On 05/23/2016 03:03 PM, Ilia Mirkin wrote: On Mon, May 23, 2016 at 4:35 PM, Brian Paul wrote: Otherwise, if the call executes normally we'll hit an assertion later in the VBO code when we draw something. Note that these cases were already handled correctly for the glIsEnabled() function (and t

Re: [Mesa-dev] [PATCH 2/4] glsl: rewrite clip/cull distance lowering pass

2016-05-23 Thread Dave Airlie
On 24 May 2016 at 06:56, Ilia Mirkin wrote: > On Thu, May 19, 2016 at 11:47 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> The last version of this broke clipping, and I had to spend >> sometime getting this working properly. >> >> I had to introduce a third pass to count the clip/cull totals

Re: [Mesa-dev] [PATCH 1/2] Unify OpenGL and OpenCL version string suffix

2016-05-23 Thread Giuseppe Bilotta
Hello Emil, On Mon, May 23, 2016 at 11:20 AM, Emil Velikov wrote: > It seems like this won't work if one builds --enable-clover --disable-dri. Argh, I hadn't considered this possibility. > The following should keep mesa and gallium code separate, can we try that one > ? > - move the git_sha1.

Re: [Mesa-dev] [PATCH] mesa: raise error for glEnable(GL_VERTEX_ARRAY), etc. in core profile

2016-05-23 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Monday, May 23, 2016 1:35 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; mesa-sta...@lists.freedesktop.org Subject: [PATCH] mesa: raise error for glEnable(GL_VERTEX_ARRAY), etc. in core profile

Re: [Mesa-dev] [PATCH] mesa: raise error for glEnable(GL_VERTEX_ARRAY), etc. in core profile

2016-05-23 Thread Ilia Mirkin
On Mon, May 23, 2016 at 4:35 PM, Brian Paul wrote: > Otherwise, if the call executes normally we'll hit an assertion later > in the VBO code when we draw something. Note that these cases were > already handled correctly for the glIsEnabled() function (and the API > checks were copied from there).

Re: [Mesa-dev] [PATCH 2/7] i965: Unset alpha blend for R10G10B10_SNORM_A2_UNORM

2016-05-23 Thread Nanley Chery
On Sat, May 21, 2016 at 08:50:13AM +0200, Eduardo Lima Mitev wrote: > On 05/21/2016 03:12 AM, Jason Ekstrand wrote: > > From: Nanley Chery > > > > This format does not support alpha blending, according to the SNB PRM. > > > > In general, it helps (at least review) to add a quote or reference to

Re: [Mesa-dev] [PATCH 0/7] i965, anv: Use ISL for querying surface format capabilities

2016-05-23 Thread Jason Ekstrand
On Mon, May 23, 2016 at 10:41 AM, Nanley Chery wrote: > On Fri, May 20, 2016 at 06:12:34PM -0700, Jason Ekstrand wrote: > > This little series effectively moves the surface format table from > > brw_surface_formats.c into ISL. Previously, it got built into > > libi965_compiler.la because we need

Re: [Mesa-dev] [PATCH 2/2] mesa: log buffer ID numbers in decimal, not hexidecimal

2016-05-23 Thread Brian Paul
Err, "hexadecimal". Will fixe before pushing. On 05/23/2016 03:00 PM, Brian Paul wrote: All the other error messages use decimal. Let's be consistent. --- src/mesa/main/bufferobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/m

[Mesa-dev] [PATCH 2/2] mesa: log buffer ID numbers in decimal, not hexidecimal

2016-05-23 Thread Brian Paul
All the other error messages use decimal. Let's be consistent. --- src/mesa/main/bufferobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 34d81aa..33bc574 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/m

[Mesa-dev] [PATCH 1/2] mesa: use enum name in bind_buffer_object() error message

2016-05-23 Thread Brian Paul
--- src/mesa/main/bufferobj.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 22073dd..34d81aa 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -1020,7 +1020,8 @@ bind_buffer_object(struct gl

Re: [Mesa-dev] [PATCH 2/2] mesa: allow GL_FRAMEBUFFER_DEFAULT_LAYERS to be queried with ES geometry

2016-05-23 Thread Anuj Phogat
On Mon, May 23, 2016 at 10:02 AM, Ilia Mirkin wrote: > When we have the geometry extensions, enable querying of the new param. > > Signed-off-by: Ilia Mirkin > --- > src/mesa/main/fbobject.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/main/fbobject.c b/s

Re: [Mesa-dev] [PATCH 2/4] glsl: rewrite clip/cull distance lowering pass

2016-05-23 Thread Ilia Mirkin
On Thu, May 19, 2016 at 11:47 PM, Dave Airlie wrote: > From: Dave Airlie > > The last version of this broke clipping, and I had to spend > sometime getting this working properly. > > I had to introduce a third pass to count the clip/cull totals, > all due to one messy corner case. We have a pigli

Re: [Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-05-23 Thread Brian Paul
Hi Plamena, Some style nitpicks below. Feel free to take 'em or leave 'em. I'm not too involved in EGL. On 05/23/2016 10:27 AM, Plamena Manolova wrote: According to the EGL specifications before binding an API we must check whether it's supported first. If not eglBindAPI should return EGL_FAL

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-23 Thread Giuseppe Bilotta
On Mon, May 23, 2016 at 4:45 PM, Marek Olšák wrote: > I think it would be better to put stuff like this only into the > renderer string of drivers which use LLVM. The majority of drivers > don't care about the LLVM version. Hm, that might be a good point. Is there a way to programmatically (at so

[Mesa-dev] [PATCH] [rfc] mesa/program_resource: return -1 for index if no location.

2016-05-23 Thread Dave Airlie
From: Dave Airlie The GL4.5 spec quote seems clear on this: "The value -1 will be returned by either command if an error occurs, if name does not identify an active variable on programInterface, or if name identifies an active variable that does not have a valid location assigned, as described ab

Re: [Mesa-dev] [PATCH 1/4] glsl: make max array trackers ints and use -1 as base.

2016-05-23 Thread Ilia Mirkin
On Thu, May 19, 2016 at 11:47 PM, Dave Airlie wrote: > From: Dave Airlie > > This fixes a bug that breaks cull distances. The problem > is the max array accessors can't tell the difference between > an never accessed unsized array and an accessed at location 0 > unsized array. This leads to conve

[Mesa-dev] [PATCH] mesa: raise error for glEnable(GL_VERTEX_ARRAY), etc. in core profile

2016-05-23 Thread Brian Paul
Otherwise, if the call executes normally we'll hit an assertion later in the VBO code when we draw something. Note that these cases were already handled correctly for the glIsEnabled() function (and the API checks were copied from there). Tested with new piglit gl-3.1-enable-vertex-array test. C

Re: [Mesa-dev] [PATCH] st/mesa: use transfer_inline_write for memcpy TexSubImage path

2016-05-23 Thread Miklós Máté
On 05/20/2016 05:42 PM, Ilia Mirkin wrote: On Fri, May 20, 2016 at 11:39 AM, Rob Herring wrote: On Mon, May 9, 2016 at 6:38 AM, Marek Olšák wrote: From: Marek Olšák This allows drivers to use their own fast path for texture uploads. --- src/mesa/state_tracker/st_cb_texture.c | 43

Re: [Mesa-dev] [PATCH 0/7] i965, anv: Use ISL for querying surface format capabilities

2016-05-23 Thread Nanley Chery
On Fri, May 20, 2016 at 06:12:34PM -0700, Jason Ekstrand wrote: > This little series effectively moves the surface format table from > brw_surface_formats.c into ISL. Previously, it got built into > libi965_compiler.la because we needed to share it between drivers and > didn't have a better place

Re: [Mesa-dev] [PATCH 2/2] Add LLVM version to Mesa version strings

2016-05-23 Thread Serge Martin
On Monday 23 May 2016 09:21:51 Giuseppe Bilotta wrote: > Code generation (kernel compilation) may sometimes hit LLVM-specific > bugs. Adding the used LLVM version to the version string may make bug > triaging easier. (This was inspired by a similar patch recently > proposed for pocl.) > > Signed-o

  1   2   >