[Mesa-dev] [PATCH 3/3] nir: Add interp_var_at_offset flipping.

2016-05-17 Thread Kenneth Graunke
--- src/compiler/nir/nir_lower_wpos_ytransform.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/compiler/nir/nir_lower_wpos_ytransform.c b/src/compiler/nir/nir_lower_wpos_ytransform.c index 41f8554..6536498 100644 --- a/src/compiler/nir/nir_lower_wpos_ytransform.c

[Mesa-dev] [PATCH 1/3] nir: Fix wpos_ytransform lowering state_slot swizzle.

2016-05-17 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/compiler/nir/nir_lower_wpos_ytransform.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/nir/nir_lower_wpos_ytransform.c b/src/compiler/nir/nir_lower_wpos_ytransform.c index 1d53530..5546788 100644 --- a/src/compiler/nir/nir_lower_wpos_yt

[Mesa-dev] [PATCH 2/3] nir: Fix fddy swizzles in nir_lower_wpos_ytransform().

2016-05-17 Thread Kenneth Graunke
The original value might have been swizzled. That's taken care of in the fmul source - we don't want to reswizzle it again. Fixes validation failures in glsl-derivs-varyings on a branch of mine which uses this pass in i965. Signed-off-by: Kenneth Graunke --- src/compiler/nir/nir_lower_wpos_ytr

Re: [Mesa-dev] [PATCH 8/8] glsl/linker: Ensure the first stage of an SSO pipeline has input locs assigned

2016-05-17 Thread Ian Romanick
On 05/17/2016 04:40 PM, Timothy Arceri wrote: > On Tue, 2016-05-17 at 15:11 -0700, Ian Romanick wrote: >> From: Ian Romanick >> >> Previously an SSO pipeline containing only a tessellation control >> shader >> and a tessellation evaluation shader would not get locations assigned >> for the TCS inp

[Mesa-dev] [Bug 95395] glsl: NULL type value in add_uniform() leads to SIGSEGV

2016-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95395 Jonathan Gray changed: What|Removed |Added Resolution|--- |NOTOURBUG Status|NEW

Re: [Mesa-dev] [PATCH] spirv: add missing switch case in vtn_handle_texture()

2016-05-17 Thread Jason Ekstrand
On Tue, May 17, 2016 at 6:30 PM, Brian Paul wrote: > To silence warning: > spirv/spirv_to_nir.c:1397:4: warning: enumeration value > 'nir_texop_txf_ms_mcs' not handled in switch [-Wswitch] > switch (instr->op) { > ^ > --- > src/compiler/spirv/spirv_to_nir.c | 1 + > 1 file changed, 1 ins

[Mesa-dev] [PATCH] spirv: add missing switch case in vtn_handle_texture()

2016-05-17 Thread Brian Paul
To silence warning: spirv/spirv_to_nir.c:1397:4: warning: enumeration value 'nir_texop_txf_ms_mcs' not handled in switch [-Wswitch] switch (instr->op) { ^ --- src/compiler/spirv/spirv_to_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/comp

[Mesa-dev] [PATCH] nv50/ir: treat addresses as local

2016-05-17 Thread Ilia Mirkin
Address registers are always loaded right before use. Don't treat them as "global", which will cause them to be put into the function's linkage, and will make the register allocator hold onto that register until the end of the function. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/

Re: [Mesa-dev] [PATCH] i965: Fix brw_regs_equal() for NaN and positive/negative zero.

2016-05-17 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965: Fix brw_regs_equal() for NaN and positive/negative zero.

2016-05-17 Thread Kenneth Graunke
We'd like the comparisons to mean "the exact same bits". Comparing doubles won't do that for NaN values or positive vs. negative zero. Cc: Matt Turner Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_reg.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sr

[Mesa-dev] [PATCH 2/2] i965: Pass the compression mode to brw_reg_from_fs_reg().

2016-05-17 Thread Kenneth Graunke
Curro is planning to eliminate p->compressed, so let's avoid using it here and just pass in the value directly. Signed-off-by: Kenneth Graunke Cc: curroje...@riseup.net --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --gi

[Mesa-dev] [PATCH 1/2] i965: Move compression control decisions into a helper function.

2016-05-17 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke Cc: curroje...@riseup.net --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 61 ++ 1 file changed, 34 insertions(+), 27 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator

Re: [Mesa-dev] [PATCH v2 19/19] swr: [rasterizer] utility functions for shared libs

2016-05-17 Thread Rowley, Timothy O
These utility functions are used by code not in the open source view of the swr rasterizer. > On May 17, 2016, at 6:11 PM, Ian Romanick wrote: > > None of this appears to be used either. > > On 05/17/2016 03:36 PM, Tim Rowley wrote: >> --- >> src/gallium/drivers/swr/rasterizer/core/utils.h

Re: [Mesa-dev] [PATCH v2 13/19] swr: [rasterizer common] add OSX to unix portability sections

2016-05-17 Thread Rowley, Timothy O
> On May 17, 2016, at 6:10 PM, Ian Romanick wrote: > > On 05/17/2016 03:36 PM, Tim Rowley wrote: >> --- >> src/gallium/drivers/swr/rasterizer/common/os.h | 9 - >> src/gallium/drivers/swr/rasterizer/common/rdtsc_buckets.cpp | 2 +- >> 2 files changed, 9 insertions(+), 2 deleti

Re: [Mesa-dev] [PATCH v2 04/19] swr: [rasterizer core] utility function for getenv

2016-05-17 Thread Rowley, Timothy O
This utility function is used by code not in the open source view of the swr rasterizer. Microsoft’s documentation for getenv seems to suggest that their implementation has limitations: https://msdn.microsoft.com/en-us/library/tehxacec.aspx (under “Remarks”). -Tim > On May 17, 2016, at 6:08

Re: [Mesa-dev] [PATCH v2 12/19] swr: [rasterizer] rename _aligned_malloc to AlignedMalloc

2016-05-17 Thread Rowley, Timothy O
Mesa has a number of utility functions that would be nice to use, but the swr/rasterizer directory is intended to be usable standalone, so it has some duplication of common utilities. -Tim > On May 17, 2016, at 6:07 PM, Ian Romanick wrote: > > Gallium already has os_malloc_aligned (in > src/g

Re: [Mesa-dev] [PATCH 8/8] glsl/linker: Ensure the first stage of an SSO pipeline has input locs assigned

2016-05-17 Thread Timothy Arceri
On Tue, 2016-05-17 at 15:11 -0700, Ian Romanick wrote: > From: Ian Romanick > > Previously an SSO pipeline containing only a tessellation control > shader > and a tessellation evaluation shader would not get locations assigned > for the TCS inputs.  This would lead to assertion failures in some >

Re: [Mesa-dev] [PATCH 7/8] glsl/linker: Don't include interface name for built-in blocks

2016-05-17 Thread Timothy Arceri
On Tue, 2016-05-17 at 15:11 -0700, Ian Romanick wrote: > From: Ian Romanick > > Commit 11096ec introduced a regression in some piglit tests (e.g., > arb_program_interface_query-resource-query).  I did not notice this > regression because other (unrelated) problems caused failed > assertions > in

[Mesa-dev] [PATCH] anv/device: Fix viewportBoundsRange

2016-05-17 Thread Nanley Chery
From: Nanley Chery Align with the spec requirement that the range must be at least [−2 × maxViewportDimensions, 2 × maxViewportDimensions − 1]. Our hardware supports this. Fixes dEQP-VK.api.info.device.properties Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94896 Signed-off-by: Nanley

Re: [Mesa-dev] [PATCH v2 19/19] swr: [rasterizer] utility functions for shared libs

2016-05-17 Thread Ian Romanick
None of this appears to be used either. On 05/17/2016 03:36 PM, Tim Rowley wrote: > --- > src/gallium/drivers/swr/rasterizer/core/utils.h| 65 > +- > .../drivers/swr/rasterizer/jitter/jit_api.h| 1 + > 2 files changed, 64 insertions(+), 2 deletions(-) > > diff -

Re: [Mesa-dev] [PATCH v2 13/19] swr: [rasterizer common] add OSX to unix portability sections

2016-05-17 Thread Ian Romanick
On 05/17/2016 03:36 PM, Tim Rowley wrote: > --- > src/gallium/drivers/swr/rasterizer/common/os.h | 9 - > src/gallium/drivers/swr/rasterizer/common/rdtsc_buckets.cpp | 2 +- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/swr/rasterizer

Re: [Mesa-dev] [PATCH v2 04/19] swr: [rasterizer core] utility function for getenv

2016-05-17 Thread Ian Romanick
This doesn't appear to be used anywhere. Maybe I missed it in some late patch? As far as I can tell, getenv works on Windows (core Mesa uses it all over the place), so the added value isn't clear to me. On 05/17/2016 03:36 PM, Tim Rowley wrote: > --- > src/gallium/drivers/swr/rasterizer/core/ut

Re: [Mesa-dev] [PATCH v2 12/19] swr: [rasterizer] rename _aligned_malloc to AlignedMalloc

2016-05-17 Thread Ian Romanick
Gallium already has os_malloc_aligned (in src/gallium/auxiliary/os/os_memory_stdc.h) for this purpose. Does this duplication add anything? On 05/17/2016 03:36 PM, Tim Rowley wrote: > --- > src/gallium/drivers/swr/rasterizer/common/os.h | 19 +-- > src/gallium/drivers/swr/ra

Re: [Mesa-dev] [PATCH] egl: Add OpenGL_ES to API string regardless of GLES version

2016-05-17 Thread Ian Romanick
On 05/17/2016 09:59 AM, Ben Widawsky wrote: > On Thu, May 12, 2016 at 06:21:38PM +0100, Plamena Manolova wrote: >> According to the EGL specifications eglQueryString(EGL_CLIENT_APIS) >> should return a string containing a combination of "OpenGL", "OpenGL_ES" >> and "OpenVG", any other values would

[Mesa-dev] [PATCH v2] docs: add swr to GL3.txt

2016-05-17 Thread Tim Rowley
--- docs/GL3.txt | 82 ++-- 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 921a529..7e86f5e 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -33,7 +33,7 @@ are exposed in the 3.0 context as ex

[Mesa-dev] [PATCH v2] swr: fix swr linkage so that static llvm works

2016-05-17 Thread Tim Rowley
--- src/gallium/drivers/swr/Makefile.am | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/Makefile.am b/src/gallium/drivers/swr/Makefile.am index 6915aae..72d0ac4 100644 --- a/src/gallium/drivers/swr/Makefile.am +++ b/src/gallium/drivers

[Mesa-dev] [PATCH v2 13/19] swr: [rasterizer common] add OSX to unix portability sections

2016-05-17 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/common/os.h | 9 - src/gallium/drivers/swr/rasterizer/common/rdtsc_buckets.cpp | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/common/os.h b/src/gallium/drivers/swr/rasterizer/com

[Mesa-dev] [PATCH v2 12/19] swr: [rasterizer] rename _aligned_malloc to AlignedMalloc

2016-05-17 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/common/os.h | 19 +-- src/gallium/drivers/swr/rasterizer/core/api.cpp | 16 src/gallium/drivers/swr/rasterizer/core/arena.h | 4 ++-- src/gallium/drivers/swr/rasterizer/core/frontend.cpp | 8 src/gal

[Mesa-dev] [PATCH v2 11/19] swr: [rasterizer jitter] rename MEMCPY function to MEMCOPY

2016-05-17 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/jitter/scripts/gen_llvm_ir_macros.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/scripts/gen_llvm_ir_macros.py b/src/gallium/drivers/swr/rasterizer/jitter/scripts/gen_llvm_ir_macros.py index

[Mesa-dev] [PATCH v2 17/19] swr: [rasterizer core] apply KNOB_TOSS_DRAW to more functions

2016-05-17 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/api.cpp | 20 1 file changed, 20 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/core/api.cpp b/src/gallium/drivers/swr/rasterizer/core/api.cpp index 9d6f250..8e0c1e1 100644 --- a/src/gallium/drivers/swr/rasterizer/co

[Mesa-dev] [PATCH v2 19/19] swr: [rasterizer] utility functions for shared libs

2016-05-17 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/utils.h| 65 +- .../drivers/swr/rasterizer/jitter/jit_api.h| 1 + 2 files changed, 64 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/utils.h b/src/gallium/drivers/swr/rasterizer/core/

[Mesa-dev] [PATCH v2 14/19] swr: [rasterizer core] clang override for _mm_undefined*

2016-05-17 Thread Tim Rowley
Not supported in older xcode versions. --- src/gallium/drivers/swr/rasterizer/core/utils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/utils.h b/src/gallium/drivers/swr/rasterizer/core/utils.h index 1c4780a..bf53c69 100644 --- a/src/

[Mesa-dev] [PATCH v2 03/19] swr: [rasterizer common] portable threadviz buckets

2016-05-17 Thread Tim Rowley
Output with slashes instead of backslashes for unix/linux. --- src/gallium/drivers/swr/rasterizer/common/rdtsc_buckets.cpp | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/common/rdtsc_buckets.cpp b/src/gallium/drivers/swr/raste

[Mesa-dev] [PATCH v2 00/19] swr: update rasterizer

2016-05-17 Thread Tim Rowley
Mostly small cleanups this round. v2: remove definition of offsetof more descriptive commit messages split threads.cpp cygwin/style changes into two commits Tim Rowley (19): swr: [rasterizer core] use parens to disambiguate operator precedence swr: [rasterizer common] foreground win32 a

[Mesa-dev] [PATCH v2 18/19] swr: [rasterizer jitter] fix assert in AVX implementation of MASKLOADD

2016-05-17 Thread Tim Rowley
llvm changed the mask type to vector of ints with 3.8. --- src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp b/src/gallium/drivers/swr/rasterizer/jitter

[Mesa-dev] [PATCH v2 10/19] swr: [rasterizer common] guard definition of __cdecl/__stdcall

2016-05-17 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/common/os.h | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/common/os.h b/src/gallium/drivers/swr/rasterizer/common/os.h index 4076812..1d68585 100644 --- a/src/gallium/drivers/swr/rasterizer/common/os.h +++ b/src/g

[Mesa-dev] [PATCH v2 09/19] swr: [rasterizer common] include cstddef for offsetof

2016-05-17 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/common/os.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/swr/rasterizer/common/os.h b/src/gallium/drivers/swr/rasterizer/common/os.h index 7bfc66f..4076812 100644 --- a/src/gallium/drivers/swr/rasterizer/common/os.h +++ b/src/galli

[Mesa-dev] [PATCH v2 16/19] swr: [rasterizer jitter] add instancing to non-gather fetch path

2016-05-17 Thread Tim Rowley
--- .../drivers/swr/rasterizer/jitter/fetch_jit.cpp| 42 +++--- 1 file changed, 37 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp b/src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp index 42b1c3e..58cafb5 100644 --- a/

[Mesa-dev] [PATCH v2 15/19] swr: [rasterizer core] move MultisampleTrait static from header to cpp

2016-05-17 Thread Tim Rowley
Move a MultisampleTrait static from header to cpp as clang seemed to get confused with some specializations in the header vs some in cpp. --- src/gallium/drivers/swr/rasterizer/core/format_types.h | 2 ++ src/gallium/drivers/swr/rasterizer/core/multisample.cpp | 5 +++-- src/gallium/drivers/swr/r

[Mesa-dev] [PATCH v2 07/19] swr: [rasterizer core] code style cleanup

2016-05-17 Thread Tim Rowley
--- .../drivers/swr/rasterizer/core/threads.cpp| 46 +++--- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/threads.cpp b/src/gallium/drivers/swr/rasterizer/core/threads.cpp index 6fa5c04..17bf616 100644 --- a/src/gal

[Mesa-dev] [PATCH v2 02/19] swr: [rasterizer common] foreground win32 assert dialog

2016-05-17 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/common/swr_assert.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/common/swr_assert.cpp b/src/gallium/drivers/swr/rasterizer/common/swr_assert.cpp index 0bffd2c..49587d0 100644 --- a/src/gallium/driv

[Mesa-dev] [PATCH v2 05/19] swr: [rasterizer core] move variable query outside loop

2016-05-17 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/frontend.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/frontend.cpp b/src/gallium/drivers/swr/rasterizer/core/frontend.cpp index c13280e..6bb9b12 100644 --- a/src/gallium/drivers/swr/ra

[Mesa-dev] [PATCH v2 08/19] swr: [rasterizer core] removed tabs that snuck in

2016-05-17 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/pa.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/pa.h b/src/gallium/drivers/swr/rasterizer/core/pa.h index eb8403c..c98ea14 100644 --- a/src/gallium/drivers/swr/rasterizer/core/pa.h

[Mesa-dev] [PATCH v2 04/19] swr: [rasterizer core] utility function for getenv

2016-05-17 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/utils.h | 17 + 1 file changed, 17 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/core/utils.h b/src/gallium/drivers/swr/rasterizer/core/utils.h index e3c534d..1c4780a 100644 --- a/src/gallium/drivers/swr/rasterizer/core/

[Mesa-dev] [PATCH v2 01/19] swr: [rasterizer core] use parens to disambiguate operator precedence

2016-05-17 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/frontend.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/frontend.cpp b/src/gallium/drivers/swr/rasterizer/core/frontend.cpp index 0834610..c13280e 100644 --- a/src/gallium/drivers/swr/rast

[Mesa-dev] [PATCH v2 06/19] swr: [rasterizer core] add dummy code for cygwin build

2016-05-17 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/threads.cpp | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/core/threads.cpp b/src/gallium/drivers/swr/rasterizer/core/threads.cpp index 0b57a3f..6fa5c04 100644 --- a/src/gallium/drivers/swr/rasteri

Re: [Mesa-dev] CI job for Android builds

2016-05-17 Thread Rob Herring
On Tue, May 17, 2016 at 5:21 PM, Rob Clark wrote: > On Tue, May 17, 2016 at 6:14 PM, Jose Fonseca wrote: >> On 17/05/16 22:43, Rob Clark wrote: >>> >>> On Tue, May 17, 2016 at 5:13 PM, Rob Herring >>> wrote: I'm in the process of setting up a CI job to track Android builds of mesa

Re: [Mesa-dev] CI job for Android builds

2016-05-17 Thread Jose Fonseca
On 17/05/16 23:21, Rob Clark wrote: On Tue, May 17, 2016 at 6:14 PM, Jose Fonseca wrote: On 17/05/16 22:43, Rob Clark wrote: On Tue, May 17, 2016 at 5:13 PM, Rob Herring wrote: I'm in the process of setting up a CI job to track Android builds of mesa master (ATM merging in a branch of comm

Re: [Mesa-dev] CI job for Android builds

2016-05-17 Thread Rob Clark
On Tue, May 17, 2016 at 6:14 PM, Jose Fonseca wrote: > On 17/05/16 22:43, Rob Clark wrote: >> >> On Tue, May 17, 2016 at 5:13 PM, Rob Herring >> wrote: >>> >>> I'm in the process of setting up a CI job to track Android builds of >>> mesa master (ATM merging in a branch of commits needed to build

Re: [Mesa-dev] CI job for Android builds

2016-05-17 Thread Jose Fonseca
On 17/05/16 22:43, Rob Clark wrote: On Tue, May 17, 2016 at 5:13 PM, Rob Herring wrote: I'm in the process of setting up a CI job to track Android builds of mesa master (ATM merging in a branch of commits needed to build which are not yet upstream). It is mostly working now though I'm still twe

[Mesa-dev] [PATCH 3/8] glsl/linker: Silence unused parameter warning

2016-05-17 Thread Ian Romanick
From: Ian Romanick The use of the parameter was removed in d6b92028. glsl/link_varyings.cpp:1390:39: warning: unused parameter ‘separate_shader’ [-Wunused-parameter] bool separate_shader) ^ Signed-off-by: Ian Romanick -

[Mesa-dev] [PATCH 8/8] glsl/linker: Ensure the first stage of an SSO pipeline has input locs assigned

2016-05-17 Thread Ian Romanick
From: Ian Romanick Previously an SSO pipeline containing only a tessellation control shader and a tessellation evaluation shader would not get locations assigned for the TCS inputs. This would lead to assertion failures in some piglit tests, such as arb_program_interface_query-resource-query. T

[Mesa-dev] [PATCH 2/8] glsl/linker: Silence unused parameter warning

2016-05-17 Thread Ian Romanick
From: Ian Romanick The parameter appears to have been unused since the function was added in commit 12ba6cfb. Remove it. glsl/linker.cpp:2886:60: warning: unused parameter ‘prog’ [-Wunused-parameter] match_explicit_outputs_to_inputs(struct gl_shader_program *prog,

[Mesa-dev] [PATCH 5/8] glsl/linker: Fix trivial typos in comments

2016-05-17 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/glsl/link_varyings.cpp | 10 +- src/compiler/glsl/linker.cpp| 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp inde

[Mesa-dev] [PATCH 1/8] i965: Silence unused parameter warnings

2016-05-17 Thread Ian Romanick
From: Ian Romanick The only place that actually used the type parameter was the GS visitor, and it was always passed glsl_type::int. Just remove the parameter. brw_vec4_vs_visitor.cpp:38:61: warning: unused parameter ‘type’ [-Wunused-parameter] const

[Mesa-dev] [PATCH 4/8] glsl/linker: Fix some formatting to match current coding conventions

2016-05-17 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/glsl/link_varyings.cpp | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index 1c59456..69b82d5 100644 --- a/src/compiler/g

[Mesa-dev] [PATCH 7/8] glsl/linker: Don't include interface name for built-in blocks

2016-05-17 Thread Ian Romanick
From: Ian Romanick Commit 11096ec introduced a regression in some piglit tests (e.g., arb_program_interface_query-resource-query). I did not notice this regression because other (unrelated) problems caused failed assertions in those same tests on my system... so they crashed before getting to th

[Mesa-dev] [PATCH 6/8] glsl: Assert that inputs have a location assigned

2016-05-17 Thread Ian Romanick
From: Ian Romanick This catches a problem previously undetected until deep in the backend. Signed-off-by: Ian Romanick --- src/compiler/glsl/ir_set_program_inouts.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/glsl/ir_set_program_inouts.cpp b/src/compiler/glsl/ir_set_p

Re: [Mesa-dev] [PATCH] st/va: use drm render node for wayland display type

2016-05-17 Thread Alex Deucher
On Tue, May 17, 2016 at 3:16 PM, Leo Liu wrote: > With xwayland, vainfo use VA_DISPLAY_WAYLAND as default and it fails > and fails when specify display with `vainfo --display wayland`. > In fact wayland support for libva uses drm path to connect device, > and should use drm pipe loader to create

Re: [Mesa-dev] [PATCH 3/3] nir/validate: dump annotated shader with error msgs

2016-05-17 Thread Jason Ekstrand
I did a quick skim. LGTM. Series is Acked-by: Jason Ekstrand On Mon, May 16, 2016 at 4:46 PM, Connor Abbott wrote: > On Mon, May 16, 2016 at 12:54 PM, Rob Clark wrote: > > From: Rob Clark > > > > Log all the errors, and at the end dump the shader w/ error annotations > > to make it easier

Re: [Mesa-dev] [PATCH] i965/fs: Add an allow_spilling flag to brw_compile_fs

2016-05-17 Thread Jason Ekstrand
On Tue, May 17, 2016 at 2:34 PM, Ian Romanick wrote: > On 05/16/2016 02:33 PM, Jason Ekstrand wrote: > > This allows us to disable spilling for blorp shaders since blorp state > > setup doesn't handle spilling. Without this, blorp faisl hard if you run >

Re: [Mesa-dev] [PATCH 2/2] i965: Make brw_reg_from_fs_reg() halve exec_size when compressed.

2016-05-17 Thread Kenneth Graunke
On Tuesday, May 17, 2016 12:48:08 PM PDT Francisco Jerez wrote: > Kenneth Graunke writes: > > > In a5d7e144eaf43fee37e6ff9e2de194407087632b, Connor generalized the > > exec_size halving code to handle more cases. As part of this, he made > > it not halve anything if the region accessed falls com

Re: [Mesa-dev] CI job for Android builds

2016-05-17 Thread Rob Clark
On Tue, May 17, 2016 at 5:13 PM, Rob Herring wrote: > I'm in the process of setting up a CI job to track Android builds of > mesa master (ATM merging in a branch of commits needed to build which > are not yet upstream). It is mostly working now though I'm still > tweaking the setup a bit. It is bu

Re: [Mesa-dev] [PATCH] docs: add swr to GL3.txt

2016-05-17 Thread Ian Romanick
On 05/16/2016 09:05 AM, Tim Rowley wrote: > --- > docs/GL3.txt | 68 > ++-- > 1 file changed, 34 insertions(+), 34 deletions(-) > > diff --git a/docs/GL3.txt b/docs/GL3.txt > index 1ac6235..187e948 100644 > --- a/docs/GL3.txt > +++ b/docs/G

Re: [Mesa-dev] [PATCH] i965/fs: Add an allow_spilling flag to brw_compile_fs

2016-05-17 Thread Ian Romanick
On 05/16/2016 02:33 PM, Jason Ekstrand wrote: > This allows us to disable spilling for blorp shaders since blorp state > setup doesn't handle spilling. Without this, blorp faisl hard if you run ^ fails > with INTEL_DEBUG=spill. > > Cc: Cu

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add new polaris10 pci ids

2016-05-17 Thread Nicolai Hähnle
For the series: Reviewed-by: Nicolai Hähnle On 17.05.2016 16:20, Alex Deucher wrote: Signed-off-by: Alex Deucher --- include/pci_ids/radeonsi_pci_ids.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/pci_ids/radeonsi_pci_ids.h b/include/pci_ids/radeonsi_pci_ids.h inde

[Mesa-dev] [PATCH 2/2] radeonsi: add new polaris11 pci ids

2016-05-17 Thread Alex Deucher
Signed-off-by: Alex Deucher --- include/pci_ids/radeonsi_pci_ids.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/pci_ids/radeonsi_pci_ids.h b/include/pci_ids/radeonsi_pci_ids.h index 94e4fac..20c1583 100644 --- a/include/pci_ids/radeonsi_pci_ids.h +++ b/include/pci_ids/radeonsi_

[Mesa-dev] [PATCH 1/2] radeonsi: add new polaris10 pci ids

2016-05-17 Thread Alex Deucher
Signed-off-by: Alex Deucher --- include/pci_ids/radeonsi_pci_ids.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/pci_ids/radeonsi_pci_ids.h b/include/pci_ids/radeonsi_pci_ids.h index 4df8e9d..94e4fac 100644 --- a/include/pci_ids/radeonsi_pci_ids.h +++ b/include/pci_ids/rad

[Mesa-dev] CI job for Android builds

2016-05-17 Thread Rob Herring
I'm in the process of setting up a CI job to track Android builds of mesa master (ATM merging in a branch of commits needed to build which are not yet upstream). It is mostly working now though I'm still tweaking the setup a bit. It is built on AOSP master branch as well. Build errors/warnings are

Re: [Mesa-dev] [PATCH 03/39] llvmpipe: Fix overflow for 32 bits available memory computation

2016-05-17 Thread Roland Scheidegger
Am 17.05.2016 um 20:16 schrieb Rob Herring: > On Tue, May 17, 2016 at 11:35 AM, Axel Davy wrote: >> On 16/05/2016 23:28, Rob Herring wrote: >>> >>> On Sun, May 15, 2016 at 5:45 AM, Axel Davy wrote: And cap to 2 GB on 32 bits. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=

Re: [Mesa-dev] [android-x86-devel] [PATCH] android: fix building error in libmesa_st_mesa

2016-05-17 Thread Rob Clark
On Tue, May 17, 2016 at 4:48 PM, Mauro Rossi wrote: > Fixes the following building error due to libmesa_nir dependency: > > In file included from > external/mesa/src/mesa/state_tracker/st_glsl_to_nir.cpp:44:0: > external/mesa/src/compiler/nir/nir.h:42:25: fatal error: nir_opcodes.h: No > such fi

Re: [Mesa-dev] [android-x86-devel] [PATCH] android: fix building error in libmesa_st_mesa

2016-05-17 Thread Rob Herring
+Rob C On Tue, May 17, 2016 at 3:48 PM, Mauro Rossi wrote: > Fixes the following building error due to libmesa_nir dependency: > > In file included from > external/mesa/src/mesa/state_tracker/st_glsl_to_nir.cpp:44:0: > external/mesa/src/compiler/nir/nir.h:42:25: fatal error: nir_opcodes.h: No >

Re: [Mesa-dev] [RFC PATCH] clover: add LLVM version to device and platform version

2016-05-17 Thread Giuseppe Bilotta
On Sun, May 15, 2016 at 10:54 PM, Giuseppe Bilotta wrote: > On Sun, May 15, 2016 at 9:35 AM, Vedran Miletić wrote: > >> How about also adding Mesa git version, like "OpenGL core profile >> version string" has now? > > That's probably a good idea. Conversely, would it be sensible to add > the LLVM

[Mesa-dev] [PATCH] android: fix building error in libmesa_st_mesa

2016-05-17 Thread Mauro Rossi
Fixes the following building error due to libmesa_nir dependency: In file included from external/mesa/src/mesa/state_tracker/st_glsl_to_nir.cpp:44:0: external/mesa/src/compiler/nir/nir.h:42:25: fatal error: nir_opcodes.h: No such file or directory #include "nir_opcodes.h"

Re: [Mesa-dev] [PATCH] Treewide: Remove Elements() macro

2016-05-17 Thread Jan Vesely
On Tue, 2016-05-17 at 14:13 -0600, Brian Paul wrote: > On 05/17/2016 01:36 PM, Jan Vesely wrote: > > > > On Tue, 2016-05-17 at 08:02 -0600, Brian Paul wrote: > > > > > > On 05/17/2016 07:25 AM, Jan Vesely wrote: > > > > > > > > > > > > Signed-off-by: Jan Vesely > > > > --- > > > > > > > > gre

[Mesa-dev] [PATCH 05/13] winsys/amdgpu: add IB buffer in amdgpu_get_new_ib

2016-05-17 Thread Nicolai Hähnle
From: Nicolai Hähnle Adding the buffer when we start using it for the IB makes the logic for chaining a bit simpler. Reviewed-by: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 234 +++--- 1 file changed, 113 insertions(+), 121 deletions(-) diff --git a/sr

[Mesa-dev] [PATCH v2 00/13] winsys/amdgpu: adjust IB sizes and implement IB chaining

2016-05-17 Thread Nicolai Hähnle
Hi, I'm re-sending an updated version of the bulk of the IB size adjustment series. This is rebased on top of recent changes to master, and (like the first version) applies on top of the multithreaded submission patch which is not in master yet. There are fairly trivial rebase fixes throughout th

[Mesa-dev] [PATCH 04/13] gallium/radeon: use cs_check_space throughout

2016-05-17 Thread Nicolai Hähnle
From: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/gallium/drivers/r300/r300_blit.c | 2 +- src/gallium/drivers/r300/r300_render.c| 2 +- src/gallium/drivers/r600/r600_hw_context.c| 6 ++ src/gallium/drivers/radeon/r600_pipe_common.c | 2 +- src/gallium/drivers/radeo

[Mesa-dev] [PATCH 03/13] radeon/winsys: add cs_check_space

2016-05-17 Thread Nicolai Hähnle
From: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/gallium/drivers/radeon/radeon_winsys.h| 9 + src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 7 +++ src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 7 +++ 3 files changed, 23 insertions(+) diff --git a/src/gallium/driver

[Mesa-dev] [PATCH 13/13] winsys/amdgpu: decay max_ib_size over time

2016-05-17 Thread Nicolai Hähnle
From: Nicolai Hähnle So that memory use will eventually decrease again after a temporary peak. Reviewed-by: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm

[Mesa-dev] [PATCH 06/13] winsys/amdgpu: extract IB big buffer allocation for re-use

2016-05-17 Thread Nicolai Hähnle
From: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 46 +++ 1 file changed, 29 insertions(+), 17 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c index c828650.

[Mesa-dev] [PATCH 01/13] winsys/amdgpu: add amdgpu_cs_has_user_fence

2016-05-17 Thread Nicolai Hähnle
From: Nicolai Hähnle v2: style change Reviewed-by: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c index a6a380d..df

[Mesa-dev] [PATCH 07/13] winsys/amdgpu: add amdgpu_ib and amdgpu_cs_from_ib helper functions

2016-05-17 Thread Nicolai Hähnle
From: Nicolai Hähnle The latter function allows getting the containing amdgpu_cs from any IB (including non-main ones). Reviewed-by: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 4 src/gallium/winsys/amdgpu/drm/amdgpu_cs.h | 40 +-- 2 files chan

[Mesa-dev] [PATCH 09/13] radeonsi/sid: add packet definitions for IB chaining

2016-05-17 Thread Nicolai Hähnle
From: Nicolai Hähnle While we're at it, add packet printing in si_debug. Reviewed-by: Marek Olšák --- src/gallium/drivers/radeonsi/si_debug.c | 7 +++ src/gallium/drivers/radeonsi/sid.h | 8 2 files changed, 15 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_debug

[Mesa-dev] [PATCH 02/13] winsys/amdgpu: simplify interface of amdgpu_get_new_ib

2016-05-17 Thread Nicolai Hähnle
From: Nicolai Hähnle We'll want to have an amdgpu_cs pointer for future changes. Reviewed-by: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 26 +- src/gallium/winsys/amdgpu/drm/amdgpu_cs.h | 2 +- 2 files changed, 14 insertions(+), 14 deletions(-) diff -

[Mesa-dev] [PATCH 10/13] radeon/winsys: introduce radeon_winsys_cs_chunk

2016-05-17 Thread Nicolai Hähnle
From: Nicolai Hähnle We will chain multiple chunks together and will keep pointers to the older chunks to support IB dumping. Reviewed-by: Marek Olšák --- src/gallium/drivers/r300/r300_cs.h | 12 +++--- src/gallium/drivers/r600/r600_hw_context.c | 3 +- src/gallium/drivers/r60

[Mesa-dev] [PATCH 08/13] winsys/amdgpu: start with smaller IBs, growing as necessary

2016-05-17 Thread Nicolai Hähnle
From: Nicolai Hähnle This avoids allocating giant IBs from the outset, especially for CE and DMA. Since we now limit max_dw only by the size that the buffer happens to be (which, due to the buffer cache, can be even larger than the rounded-up size we request), the new function amdgpu_ib_max_subm

[Mesa-dev] [PATCH 12/13] winsys/amdgpu: implement IB chaining on the gfx ring

2016-05-17 Thread Nicolai Hähnle
From: Nicolai Hähnle As a consequence, CE IB size never triggers a flush anymore. Reviewed-by: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 126 +- src/gallium/winsys/amdgpu/drm/amdgpu_cs.h | 1 + 2 files changed, 109 insertions(+), 18 deletions(-)

[Mesa-dev] [PATCH 11/13] winsys/amdgpu: consolidate IB size management in amdgpu_ib_finalize

2016-05-17 Thread Nicolai Hähnle
From: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c index b8b9bb5..1250f67 100644

Re: [Mesa-dev] [PATCH 04/10] i965/fs: Make emit_spill/unspill static functions taking builder as argument.

2016-05-17 Thread Jason Ekstrand
On Tue, May 17, 2016 at 12:24 PM, Francisco Jerez wrote: > Jason Ekstrand writes: > > > On Mon, May 16, 2016 at 9:22 PM, Francisco Jerez > > wrote: > > > >> This seems cleaner than exposing an implementation detail of > >> brw_fs_reg_allocate.cpp to the world, and will give the caller control >

[Mesa-dev] [PATCH] include/GL: fix the interop header for a --disable-glx build

2016-05-17 Thread Rob Herring
Including glx.h brings in X11 headers. Avoid the include of glx.h and just forward declare the necessary symbols. Signed-off-by: Rob Herring --- I haven't seen any progress and this and builds are still broken. Here's a fix as Emil suggested. Rob include/GL/mesa_glinterop.h | 5 - 1 file

Re: [Mesa-dev] [PATCH] Treewide: Remove Elements() macro

2016-05-17 Thread Brian Paul
On 05/17/2016 01:36 PM, Jan Vesely wrote: On Tue, 2016-05-17 at 08:02 -0600, Brian Paul wrote: On 05/17/2016 07:25 AM, Jan Vesely wrote: Signed-off-by: Jan Vesely --- grep '[^a-z]Elements(' -r * returns only one hit: src/mesa/vbo/vbo_minmax_index.c: * glDraw[Range]Elements() calls. src/g

Re: [Mesa-dev] [PATCH 03/39] llvmpipe: Fix overflow for 32 bits available memory computation

2016-05-17 Thread Axel Davy
On 17/05/2016 20:16, Rob Herring wrote: On Tue, May 17, 2016 at 11:35 AM, Axel Davy wrote: On 16/05/2016 23:28, Rob Herring wrote: On Sun, May 15, 2016 at 5:45 AM, Axel Davy wrote: And cap to 2 GB on 32 bits. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=94561 Signed-off-by: Axel Davy

Re: [Mesa-dev] [PATCH 2/2] i965: Make brw_reg_from_fs_reg() halve exec_size when compressed.

2016-05-17 Thread Francisco Jerez
Kenneth Graunke writes: > In a5d7e144eaf43fee37e6ff9e2de194407087632b, Connor generalized the > exec_size halving code to handle more cases. As part of this, he made > it not halve anything if the region accessed falls completely in a > single register. > > Unfortunately, it started producing so

Re: [Mesa-dev] [PATCH] glxcmds: glXGetFBConfigs, fix screen bounds

2016-05-17 Thread Adam Jackson
On Tue, 2016-05-17 at 08:35 +0200, Jiri Slaby wrote: > Bounds of screen are 0 (inclusive) and ScreenCount(dpy) (exclusive). > The upper bound was too ScreenCount(dpy) (inclusive). > > This causes a crash invoked by java3d which passes down an invalid > screen: > 6  0x7f0e5198ba70 in () at /li

Re: [Mesa-dev] [PATCH 2/2] i965: Make brw_reg_from_fs_reg() halve exec_size when compressed.

2016-05-17 Thread Matt Turner
Both are Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] Treewide: Remove Elements() macro

2016-05-17 Thread Jan Vesely
On Tue, 2016-05-17 at 08:02 -0600, Brian Paul wrote: > On 05/17/2016 07:25 AM, Jan Vesely wrote: > > > > Signed-off-by: Jan Vesely > > --- > > > > grep '[^a-z]Elements(' -r * returns only one hit: > > src/mesa/vbo/vbo_minmax_index.c: * glDraw[Range]Elements() calls. > > > >   src/gallium/auxili

Re: [Mesa-dev] [PATCH 1/1] r600g,sb: Don't use standard macro name

2016-05-17 Thread Jan Vesely
On Tue, 2016-05-17 at 13:50 -0500, Nicolai Hähnle wrote: > Reviewed-by: Nicolai Hähnle > > Do you need me to apply this for you? thanks. I accidentally pushed it without adding your review tag. I suppose rewriting history is not a good idea, sorry about that. Jan > > On 17.05.2016 12:32, Jan

Re: [Mesa-dev] [PATCH 04/10] i965/fs: Make emit_spill/unspill static functions taking builder as argument.

2016-05-17 Thread Francisco Jerez
Jason Ekstrand writes: > On Mon, May 16, 2016 at 9:22 PM, Francisco Jerez > wrote: > >> This seems cleaner than exposing an implementation detail of >> brw_fs_reg_allocate.cpp to the world, and will give the caller control >> over the instruction execution flags (e.g. force_writemask_all) that >

Re: [Mesa-dev] [PATCH 08/10] i965/fs: Calculate the (un)spill block size correctly.

2016-05-17 Thread Francisco Jerez
Jason Ekstrand writes: > On Mon, May 16, 2016 at 9:23 PM, Francisco Jerez > wrote: > >> Currently the spilling code attempts to guess the scratch message >> block size from the dispatch width of the shader, which is plain wrong >> for SIMD-lowered instructions (frequently but not exclusively >>

  1   2   >