Re: [Mesa-dev] Mesa (master): 34 new commits

2016-04-19 Thread Michel Dänzer
On 20.04.2016 01:32, Bas Nieuwenhuizen wrote: > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=464cef5b06e65aa740704e4adac68b7f5fee1b88 > Author: Bas Nieuwenhuizen > Date: Sat Mar 19 15:16:50 2016 +0100 > > radeonsi: enable TGSI support cap for compute shaders This change brok

Re: [Mesa-dev] [PATCH 05/13] nir/lower_double_ops: lower trunc()

2016-04-19 Thread Iago Toral
On Tue, 2016-04-19 at 15:32 -0700, Jason Ekstrand wrote: > > > On Tue, Apr 12, 2016 at 1:05 AM, Samuel Iglesias Gonsálvez > wrote: > From: Iago Toral Quiroga > > At least i965 hardware does not have native support for > truncating doubles. > --- >

Re: [Mesa-dev] [PATCH 4/4] radeonsi: Print a message when scratch allocation fails.

2016-04-19 Thread eocallaghan
On 2016-04-20 11:46, Nicolai Hähnle wrote: On 19.04.2016 17:50, Bas Nieuwenhuizen wrote: Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 5 - src/gallium/drivers/radeonsi/si_state_shaders.c | 5 - 2 files changed, 8 insertions(+), 2 deletions(-

Re: [Mesa-dev] [PATCH 04/13] nir: add a pass to lower some double operations

2016-04-19 Thread Samuel Iglesias Gonsálvez
On 19/04/16 23:52, Jason Ekstrand wrote: > On Tue, Apr 12, 2016 at 1:05 AM, Samuel Iglesias Gonsálvez < > sigles...@igalia.com> wrote: > >> From: Connor Abbott >> >> v2: Move to compiler/nir (Iago) >> >> Signed-off-by: Iago Toral Quiroga >> --- >> src/compiler/Makefile.sources | 1 +

[Mesa-dev] [PATCH] Update Doxygen for Windows users

2016-04-19 Thread Elie TOURNIER
Now Windows users have the same doxygen files than *nix users Not tested (I don't have a windows) Signed-off-by: Elie TOURNIER --- doxygen/doxy.bat | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doxygen/doxy.bat b/doxygen/doxy.bat index e566ca3..408964e 100644 --- a/doxygen/doxy.bat

Re: [Mesa-dev] [PATCH 04/13] nir: add a pass to lower some double operations

2016-04-19 Thread Jason Ekstrand
On Tue, Apr 19, 2016 at 6:45 PM, Connor Abbott wrote: > On Tue, Apr 12, 2016 at 4:05 AM, Samuel Iglesias Gonsálvez > wrote: > > From: Connor Abbott > > > > v2: Move to compiler/nir (Iago) > > > > Signed-off-by: Iago Toral Quiroga > > --- > > src/compiler/Makefile.sources | 1 + > >

[Mesa-dev] [Bug 94957] dEQP failures on llvmpipe

2016-04-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94957 --- Comment #9 from Roland Scheidegger --- So, the r32i/ui failures are actually due to an overflow. One example I've seen samples a rgb8 unorm texture, scales to int range, converts to int and outputs this. The problem is that rescaling to 2^31

Re: [Mesa-dev] [PATCH 03/13] isl: Don't use designated initializers in the header

2016-04-19 Thread Jason Ekstrand
On Tue, Apr 19, 2016 at 8:12 PM, Jason Ekstrand wrote: > > On Apr 19, 2016 6:10 PM, "Emil Velikov" wrote: > > > > On 19 April 2016 at 23:18, Chad Versace wrote: > > > On Tue 19 Apr 2016, Emil Velikov wrote: > > >> On 16 April 2016 at 20:45, Jason Ekstrand > wrote: > > >> > C++ doesn't support

Re: [Mesa-dev] [PATCH 03/13] isl: Don't use designated initializers in the header

2016-04-19 Thread Jason Ekstrand
On Apr 19, 2016 6:10 PM, "Emil Velikov" wrote: > > On 19 April 2016 at 23:18, Chad Versace wrote: > > On Tue 19 Apr 2016, Emil Velikov wrote: > >> On 16 April 2016 at 20:45, Jason Ekstrand wrote: > >> > C++ doesn't support designated initializers and g++ in particular doesn't > >> > handle them

Re: [Mesa-dev] [PATCH] egl: android: add dma-buf fd support

2016-04-19 Thread Rob Herring
On Tue, Apr 19, 2016 at 8:43 PM, Rob Clark wrote: > On Tue, Apr 19, 2016 at 9:03 PM, Emil Velikov > wrote: >> Hi Rob, >> >> Please bear in mind that there's a fair bit of comments, but before >> all don't mix refactoring and new code. Please ? >> >> On 15 April 2016 at 17:03, Rob Herring wrote

Re: [Mesa-dev] [PATCH] egl: android: add dma-buf fd support

2016-04-19 Thread Rob Herring
On Tue, Apr 19, 2016 at 8:03 PM, Emil Velikov wrote: > Hi Rob, > > Please bear in mind that there's a fair bit of comments, but before > all don't mix refactoring and new code. Please ? Okay. > On 15 April 2016 at 17:03, Rob Herring wrote: >> Add support for creating images from Android native

Re: [Mesa-dev] [PATCH] loader: add a libdrm case for loader_get_device_name_for_fd

2016-04-19 Thread Jonathan Gray
On Tue, Apr 19, 2016 at 07:00:18PM +0100, Emil Velikov wrote: > On 19 April 2016 at 04:03, Jonathan Gray wrote: > > Any objections to this? > > > Absolutely none. I simply missed it. > > > On Mon, Dec 21, 2015 at 04:39:55PM +1100, Jonathan Gray wrote: > >> Use dev_node_from_fd() with HAVE_LIBDRM

[Mesa-dev] [PATCH] android: fix glcpp building error

2016-04-19 Thread Mauro Rossi
LOCAL_C_INCLUDES needs an additional path to fix the following build error: external/mesa/src/compiler/glsl/glcpp/glcpp-lex.l:30:25: fatal error: glcpp-parse.h: No such file or directory #include "glcpp-parse.h" ^ compilation terminated. build/core/binary.mk:821: recipe

Re: [Mesa-dev] [PATCH 04/13] nir: add a pass to lower some double operations

2016-04-19 Thread Connor Abbott
On Tue, Apr 12, 2016 at 4:05 AM, Samuel Iglesias Gonsálvez wrote: > From: Connor Abbott > > v2: Move to compiler/nir (Iago) > > Signed-off-by: Iago Toral Quiroga > --- > src/compiler/Makefile.sources | 1 + > src/compiler/nir/nir.h | 7 + > src/compiler/nir/nir_lo

Re: [Mesa-dev] [PATCH 4/4] radeonsi: Print a message when scratch allocation fails.

2016-04-19 Thread Nicolai Hähnle
On 19.04.2016 17:50, Bas Nieuwenhuizen wrote: Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 5 - src/gallium/drivers/radeonsi/si_state_shaders.c | 5 - 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi

Re: [Mesa-dev] [PATCH] egl: android: add dma-buf fd support

2016-04-19 Thread Rob Clark
On Tue, Apr 19, 2016 at 9:03 PM, Emil Velikov wrote: > Hi Rob, > > Please bear in mind that there's a fair bit of comments, but before > all don't mix refactoring and new code. Please ? > > On 15 April 2016 at 17:03, Rob Herring wrote: >> Add support for creating images from Android native buffe

Re: [Mesa-dev] [PATCH 03/13] isl: Don't use designated initializers in the header

2016-04-19 Thread Emil Velikov
On 19 April 2016 at 23:18, Chad Versace wrote: > On Tue 19 Apr 2016, Emil Velikov wrote: >> On 16 April 2016 at 20:45, Jason Ekstrand wrote: >> > C++ doesn't support designated initializers and g++ in particular doesn't >> > handle them when the struct gets complicated, i.e. has a union. >> > ---

Re: [Mesa-dev] [PATCH 2/4] radeonsi: Set range metadata on calls to llvm.SI.tid

2016-04-19 Thread Tom Stellard
On Tue, Apr 19, 2016 at 08:12:08PM +0200, Michael Schellenberger Costa wrote: > Hi Tom, > > Am 19.04.2016 um 19:52 schrieb Tom Stellard: > > The range metadata tells LLVM the range of expected values for this > > intrinsic, > > so it can do some additional optimizations on the result. > > --- > >

[Mesa-dev] [Bug 92850] Segfault loading War Thunder

2016-04-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92850 --- Comment #63 from Michel Dänzer --- (In reply to Iaroslav Andrusyak from comment #61) > Works for me with aces -safe and with any settings but without shadows > enabled, with shadows i got > > state_tracker/st_cb_fbo.c:431:st_update_renderbu

Re: [Mesa-dev] [PATCH 1/4] radeonsi: use CE suballocator for CP DMA realignment.

2016-04-19 Thread eocallaghan
On 2016-04-20 09:29, Bas Nieuwenhuizen wrote: I retract patch 1 and 2. Large scratch buffers are nice, but the hardware only supports a 32-bit offset into it. - Bas On Wed, Apr 20, 2016 at 12:50 AM, Bas Nieuwenhuizen wrote: Use the CE suballocator instead of the normal one as the usage is mos

Re: [Mesa-dev] [PATCH] egl: android: add dma-buf fd support

2016-04-19 Thread Emil Velikov
Hi Rob, Please bear in mind that there's a fair bit of comments, but before all don't mix refactoring and new code. Please ? On 15 April 2016 at 17:03, Rob Herring wrote: > Add support for creating images from Android native buffers with dma-buf > fd. As dma-buf support also requires DRI image

Re: [Mesa-dev] [PATCH] swr: fix resource backed constant buffers

2016-04-19 Thread Markus Wick
Am 2016-04-19 01:12, schrieb Tim Rowley: Code was using an incorrect address for the base pointer. Tested-by: Markus Wick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94979 --- src/gallium/drivers/swr/swr_state.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

Re: [Mesa-dev] [PATCH 02/18] anv: Add a new block-based batch emit macro

2016-04-19 Thread Michael Schellenberger Costa
Hi Jason, stupid optional nitpick , but could you go for anv_batch_emit_block? Normally abbreviations below 3 characters aren't really worth it. Michael Am 19/04/2016 um 02:10 schrieb Jason Ekstrand: > This new macro uses a for loop to create an actual code block in which to > place the macro se

Re: [Mesa-dev] [PATCH 2/4] radeonsi: Set range metadata on calls to llvm.SI.tid

2016-04-19 Thread Michael Schellenberger Costa
Hi Tom, Am 19.04.2016 um 19:52 schrieb Tom Stellard: > The range metadata tells LLVM the range of expected values for this intrinsic, > so it can do some additional optimizations on the result. > --- > src/gallium/drivers/radeonsi/si_shader.c | 29 ++--- > 1 file changed,

Re: [Mesa-dev] [PATCH 3/4] radeonsi: Use llvm.amdgcn.mbcnt.* intrinsics instead of llvm.SI.tid v2

2016-04-19 Thread Michael Schellenberger Costa
Hi Tom Am 19.04.2016 um 19:52 schrieb Tom Stellard: > We're trying to move to more of the new style intrinsics with include > the correct target name, and map directly to ISA instructions. > > v2: > - Only do this with LLVM 3.8 and newer. > --- > src/gallium/drivers/radeonsi/si_shader.c | 17 ++

Re: [Mesa-dev] [PATCH 1/4] radeonsi: use CE suballocator for CP DMA realignment.

2016-04-19 Thread Bas Nieuwenhuizen
On Wed, Apr 20, 2016 at 2:13 AM, Nicolai Hähnle wrote: > On 19.04.2016 18:29, Bas Nieuwenhuizen wrote: >> >> I retract patch 1 and 2. Large scratch buffers are nice, but the >> hardware only supports a 32-bit offset into it. > > > Do you mean patch 2 and 3? Do you plan alternative patches to error

Re: [Mesa-dev] [PATCH 1/2] winsys/amdgpu: adjust IB size based on buffer wait time

2016-04-19 Thread Nicolai Hähnle
This is just a slight massaging of the patch you sent previously. What happened to the discussion we had about how to do this properly? Nicolai On 19.04.2016 18:13, Grigori Goronzy wrote: Small IBs help to reduce stalls for workloads that require a lot of synchronization. On the other hand, if

Re: [Mesa-dev] [PATCH 1/4] radeonsi: use CE suballocator for CP DMA realignment.

2016-04-19 Thread Nicolai Hähnle
On 19.04.2016 17:50, Bas Nieuwenhuizen wrote: Use the CE suballocator instead of the normal one as the usage is most similar to the CE, i.e. only read and written on GPU and not mapped to CPU. The scratch buffer is also only read and written by the GPU... Signed-off-by: Bas Nieuwenhuizen --

Re: [Mesa-dev] [PATCH 1/4] radeonsi: use CE suballocator for CP DMA realignment.

2016-04-19 Thread Nicolai Hähnle
On 19.04.2016 18:29, Bas Nieuwenhuizen wrote: I retract patch 1 and 2. Large scratch buffers are nice, but the hardware only supports a 32-bit offset into it. Do you mean patch 2 and 3? Do you plan alternative patches to error out when there is an integer overflow? That's still kind of importa

Re: [Mesa-dev] [PATCH 2/7] i965: Simplify gl_SampleID setup on Gen8+.

2016-04-19 Thread Matt Turner
On Tue, Apr 19, 2016 at 5:07 PM, Kenneth Graunke wrote: > So...what would you like me to change? Just update the comment to match > the code? Or change the code somehow as well? I think just update the comment. ___ mesa-dev mailing list mesa-dev@lists

Re: [Mesa-dev] [PATCH 2/7] i965: Simplify gl_SampleID setup on Gen8+.

2016-04-19 Thread Kenneth Graunke
On Tuesday, April 19, 2016 4:52:44 PM PDT Matt Turner wrote: > On Tue, Apr 19, 2016 at 4:51 PM, Kenneth Graunke wrote: > > On Tuesday, April 19, 2016 11:19:54 AM PDT Matt Turner wrote: > >> On Mon, Apr 18, 2016 at 11:48 PM, Kenneth Graunke > > wrote: > >> > On Gen7+, the thread payload provides

[Mesa-dev] [Bug 92850] Segfault loading War Thunder

2016-04-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92850 --- Comment #62 from Nicolai Hähnle --- Hi Iaroslav, do you have an apitrace with shadows enabled that triggers the assertion? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.

Re: [Mesa-dev] [PATCH 2/7] i965: Simplify gl_SampleID setup on Gen8+.

2016-04-19 Thread Matt Turner
On Tue, Apr 19, 2016 at 4:51 PM, Kenneth Graunke wrote: > On Tuesday, April 19, 2016 11:19:54 AM PDT Matt Turner wrote: >> On Mon, Apr 18, 2016 at 11:48 PM, Kenneth Graunke > wrote: >> > On Gen7+, the thread payload provides the sample ID - we can read it >> > in two instructions, without any ela

Re: [Mesa-dev] [PATCH 2/7] i965: Simplify gl_SampleID setup on Gen8+.

2016-04-19 Thread Kenneth Graunke
On Tuesday, April 19, 2016 11:19:54 AM PDT Matt Turner wrote: > On Mon, Apr 18, 2016 at 11:48 PM, Kenneth Graunke wrote: > > On Gen7+, the thread payload provides the sample ID - we can read it > > in two instructions, without any elaborate calculations. We don't even > > need a state dependency

Re: [Mesa-dev] [PATCH 40/41] glapi: gl_x86_asm.py: simplify method with sum and generator

2016-04-19 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 03/31/2016 05:04 PM, Dylan Baker wrote: > Rather than using a loop, and augmenting a variable use a generator and > sum to achieve the same result. > > Signed-off-by: Dylan Baker > --- > src/mapi/glapi/gen/gl_x86_asm.py | 10 ++ > 1 file chan

Re: [Mesa-dev] [PATCH 41/41] glapi: gl_x86-64_asm.py: use _ for unused variable

2016-04-19 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 03/31/2016 05:04 PM, Dylan Baker wrote: > Don't assign variables that aren't actually used, just put them in _, > the python unused variable. > > Signed-off-by: Dylan Baker > --- > src/mapi/glapi/gen/gl_x86-64_asm.py | 2 +- > 1 file changed, 1 inser

Re: [Mesa-dev] [PATCH 39/41] glapi: glX_server_table.py: use math.log instead of hand coded log2 function

2016-04-19 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 03/31/2016 05:04 PM, Dylan Baker wrote: > This just saves a bit of typing. > > Signed-off-by: Dylan Baker > --- > src/mapi/glapi/gen/glX_server_table.py | 12 ++-- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/src/mapi/

Re: [Mesa-dev] [PATCH 38/41] glapi: glX_proto_size.py: Remove dead code.

2016-04-19 Thread Ian Romanick
Did you try commenting the 'return 0' to see how that affected the binary size? My old experiment was stupid... I just looked at 'ls -l' on the .o file. A better experiment is to look at the output of 'size libglapi.so.0.0.0'. On 03/31/2016 05:04 PM, Dylan Baker wrote: > This code has for a long

Re: [Mesa-dev] [PATCH 37/41] glapi: glX_proto_send.py: simplify XCB string conversion

2016-04-19 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 03/31/2016 05:04 PM, Dylan Baker wrote: > This makes the function a little simpler by using a special case for the > initial "ARB", and just walking the str as a sequence rather than > indexing into it. > > It also uses a list to join rather than overw

Re: [Mesa-dev] [PATCH 36/41] glapi: glX_proto_send.py: remove useless pass keyword

2016-04-19 Thread Ian Romanick
That's weird. It looks like I added this in 66a5548f, but I have no idea why. Even then I knew what pass was for. *shrug* This patch is Reviewed-by: Ian Romanick On 03/31/2016 05:04 PM, Dylan Baker wrote: > The pass keyword is the solution for python's whitespace significant > code. It's used

Re: [Mesa-dev] [PATCH 2/2] winsys/amdgpu: clean up and fix switch statement

2016-04-19 Thread Bas Nieuwenhuizen
On Wed, Apr 20, 2016 at 1:13 AM, Grigori Goronzy wrote: > Add missing break, add default case. Additionally initialize variables > to avoid compiler warnings. > --- > src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/galliu

Re: [Mesa-dev] [PATCH 35/41] glapi: glX_proto_send.py: Don't shadow builtins.

2016-04-19 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 03/31/2016 05:04 PM, Dylan Baker wrote: > str is a builtin in python, although python doesn't prevent builtins > from being shadowed, its still a bad idea. > > Signed-off-by: Dylan Baker > --- > src/mapi/glapi/gen/glX_proto_send.py | 14 +++--

Re: [Mesa-dev] [RFC] add MAINTAINERS and get_maintainer.pl script

2016-04-19 Thread Rob Clark
On Tue, Apr 19, 2016 at 7:04 PM, Matt Turner wrote: > On Tue, Apr 19, 2016 at 3:06 PM, Emil Velikov > wrote: >> Hi Rob, >> >> Speaking of maintainers... I have a patch somewhere that adds you as >> maintainer for $linux/drivers/drm/gpu/msm/. >> Guess I should send it already ;-) >> >> On 19 Apri

Re: [Mesa-dev] [PATCH 33/41] glapi: glX_proto_common.py: use python's _ for unused values

2016-04-19 Thread Ian Romanick
Heh... I don't think _ was a thing when I first wrote this. I like it. This patch is Reviewed-by: Ian Romanick On 03/31/2016 05:04 PM, Dylan Baker wrote: > Rather than using a variable called junk, use _ for unused unpacked > values. This is much more idiomatic. > > Signed-off-by: Dylan Baker

Re: [Mesa-dev] [PATCH 34/41] glapi: glX_proto_send.py: don't unpack useless values.

2016-04-19 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 03/31/2016 05:04 PM, Dylan Baker wrote: > There are two ways to handle this. One is to use the _ placeholder value > when multiple values are needed. The second is to use list indexing to > get only the values actually needed when only one value is desi

Re: [Mesa-dev] [PATCH 22/41] glapi: gl_XML.py: convert gl_api.functionIterateByOffset to a generator

2016-04-19 Thread Dylan Baker
Quoting Ian Romanick (2016-04-19 16:13:51) > On 04/01/2016 11:47 AM, Ilia Mirkin wrote: > > On Fri, Apr 1, 2016 at 2:41 PM, Dylan Baker wrote: > >> Quoting Ilia Mirkin (2016-04-01 08:46:19) > >>> IMHO this is still quite fancy and unnecessarily complicated. > >>> > >>> How about > >>> > >>> temp

Re: [Mesa-dev] [PATCH 32/41] glapi: glX_proto_common.py: remove commented out code.

2016-04-19 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 03/31/2016 05:04 PM, Dylan Baker wrote: > This can easily be restored with a revert if it's ever actually needed. > > Signed-off-by: Dylan Baker > --- > src/mapi/glapi/gen/glX_proto_common.py | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/s

Re: [Mesa-dev] [PATCH 31/41] glapi: glX_proto_common.py: return variable from glx_print_proto.size_call

2016-04-19 Thread Ian Romanick
On 03/31/2016 05:04 PM, Dylan Baker wrote: > The variable has the same value as the explicit None return, but makes > it clearer what's going on. If we're going to do that, I think it makes sense to make the other returns be breaks instead. > > Signed-off-by: Dylan Baker > --- > src/mapi/glapi

Re: [Mesa-dev] [PATCH 30/41] glapi: gl_XML.py: return a tuple from gl_parameter.get_dimensions

2016-04-19 Thread Ian Romanick
I never really was clear on when to use which kind of thing. This patch is Reviewed-by: Ian Romanick On 03/31/2016 05:04 PM, Dylan Baker wrote: > rather than a list. > > In python tuples are mainly for heterogenous collections, especially > when position has relevance. Which makes them the rig

Re: [Mesa-dev] [PATCH 1/4] radeonsi: use CE suballocator for CP DMA realignment.

2016-04-19 Thread Bas Nieuwenhuizen
I retract patch 1 and 2. Large scratch buffers are nice, but the hardware only supports a 32-bit offset into it. - Bas On Wed, Apr 20, 2016 at 12:50 AM, Bas Nieuwenhuizen wrote: > Use the CE suballocator instead of the normal one as the usage > is most similar to the CE, i.e. only read and writt

Re: [Mesa-dev] [PATCH 28/41] glapi: gl_XML.py: add missing method prototype.

2016-04-19 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 03/31/2016 05:04 PM, Dylan Baker wrote: > This method is a no-op, but it shuts up tools that get upset that Print > calls a non-existent method. > > Signed-off-by: Dylan Baker > --- > src/mapi/glapi/gen/gl_XML.py | 3 +++ > 1 file changed, 3 insertio

Re: [Mesa-dev] [PATCH 29/41] glapi: gl_XML.py: refactor out extra else statement

2016-04-19 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 03/31/2016 05:04 PM, Dylan Baker wrote: > This is a pretty minor refactor, but it avoids having an else statement > with a nested if. It instead makes it one big if statement. > > Signed-off-by: Dylan Baker > --- > src/mapi/glapi/gen/gl_XML.py | 13 +

Re: [Mesa-dev] [PATCH 27/41] glapi: gl_XML.py: store compiled re as a module variable

2016-04-19 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 03/31/2016 05:04 PM, Dylan Baker wrote: > This avoids recompiles of the re each time the function is called. > > Signed-off-by: Dylan Baker > --- > src/mapi/glapi/gen/gl_XML.py | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --gi

Re: [Mesa-dev] [PATCH 26/41] glapi: gl_XML.py: avoid unnecessary method call

2016-04-19 Thread Ian Romanick
On 03/31/2016 05:04 PM, Dylan Baker wrote: > Don't call and store a value that might not be used unless it's know known With that fixed, this patch is Reviewed-by: Ian Romanick > it's needed. > > Signed-off-by: Dylan Baker > --

Re: [Mesa-dev] [PATCH 25/41] glapi: gl_XML.py: simplify is_attr_true

2016-04-19 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 03/31/2016 05:04 PM, Dylan Baker wrote: > Use a boolean instead of 0 or 1, and use an assert rather than a runtime > error. > > Signed-off-by: Dylan Baker > --- > src/mapi/glapi/gen/gl_XML.py | 12 +--- > 1 file changed, 5 insertions(+), 7 de

Re: [Mesa-dev] [PATCH 07/13] isl/format: Break the guts of has_[us]int_channel into a helper

2016-04-19 Thread Jason Ekstrand
On Tue, Apr 19, 2016 at 3:38 PM, Chad Versace wrote: > On Sat 16 Apr 2016, Jason Ekstrand wrote: > > --- > > src/intel/isl/isl_format.c | 34 -- > > 1 file changed, 16 insertions(+), 18 deletions(-) > > > > diff --git a/src/intel/isl/isl_format.c b/src/intel/isl/i

Re: [Mesa-dev] [PATCH 20/41] glapi: gl_XML.py: make gl_api.categoryIterate a generator

2016-04-19 Thread Dylan Baker
Quoting Ian Romanick (2016-04-19 15:14:59) > On 03/31/2016 05:04 PM, Dylan Baker wrote: > > This does basically the same thing as the previous implementation, > > although it uses sorted() to act on the dictionary without first copying > > the keys out into a list, and then indexing back into the d

Re: [Mesa-dev] [PATCH 05/13] isl: Add a helper for determining when a typed load/store can be used

2016-04-19 Thread Jason Ekstrand
On Tue, Apr 19, 2016 at 3:29 PM, Chad Versace wrote: > On Sat 16 Apr 2016, Jason Ekstrand wrote: > > --- > > src/intel/isl/isl.h | 7 +++ > > src/intel/isl/isl_storage_image.c | 10 ++ > > 2 files changed, 17 insertions(+) > > > +bool > > +isl_has_matching_typed_storag

Re: [Mesa-dev] [PATCH 24/41] glapi: gl_XML.py: rework gl_api.functionIterateByOffset

2016-04-19 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 03/31/2016 05:04 PM, Dylan Baker wrote: > This reworks this method to use the sorted() built-in rather than taking > the dictionary keys (which involves creating a brand new copy of the > list in memory), sorting it, then iterating the new sorted list a

Re: [Mesa-dev] [PATCH 23/41] glapi: gl_XML.py: use collections to simplify functionsIterateByCategory

2016-04-19 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 03/31/2016 05:04 PM, Dylan Baker wrote: > This uses the collections.defaultdict to remove the need to check and > add an empty dict, since defaultdict will call the default factory for > us whenever a KeyError would be raised (by a missing key value). >

[Mesa-dev] [PATCH 2/2] winsys/amdgpu: clean up and fix switch statement

2016-04-19 Thread Grigori Goronzy
Add missing break, add default case. Additionally initialize variables to avoid compiler warnings. --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgp

[Mesa-dev] [PATCH 1/2] winsys/amdgpu: adjust IB size based on buffer wait time

2016-04-19 Thread Grigori Goronzy
Small IBs help to reduce stalls for workloads that require a lot of synchronization. On the other hand, if there is no notable synchronization, we can use a large IB size to slightly improve performance in some cases. This introduces tuning of the IB size based on feedback on the average buffer wa

Re: [Mesa-dev] [PATCH 22/41] glapi: gl_XML.py: convert gl_api.functionIterateByOffset to a generator

2016-04-19 Thread Ian Romanick
On 04/01/2016 11:47 AM, Ilia Mirkin wrote: > On Fri, Apr 1, 2016 at 2:41 PM, Dylan Baker wrote: >> Quoting Ilia Mirkin (2016-04-01 08:46:19) >>> IMHO this is still quite fancy and unnecessarily complicated. >>> >>> How about >>> >>> temp = dict((f.offset, f) for f in self.functions_by_name.iterv

Re: [Mesa-dev] [PATCH 03/13] isl: Don't use designated initializers in the header

2016-04-19 Thread Jason Ekstrand
On Tue, Apr 19, 2016 at 3:18 PM, Chad Versace wrote: > On Tue 19 Apr 2016, Emil Velikov wrote: > > On 16 April 2016 at 20:45, Jason Ekstrand wrote: > > > C++ doesn't support designated initializers and g++ in particular > doesn't > > > handle them when the struct gets complicated, i.e. has a uni

Re: [Mesa-dev] [PATCH 10/41] glapi: Don't use string module in python modules

2016-04-19 Thread Dylan Baker
Quoting Ian Romanick (2016-04-19 14:55:19) > On 03/31/2016 05:04 PM, Dylan Baker wrote: > > Rather than using the string module, use the same method for the str > > instance (join, split, replace, etc). > > > > It's more forward looking, since it will make smoothing over the > > str/bytes/unicode

Re: [Mesa-dev] [PATCH 17/41] glapi: replace RuntimeError with asserts or Exception

2016-04-19 Thread Dylan Baker
Quoting Ian Romanick (2016-04-19 15:07:09) > On 03/31/2016 05:04 PM, Dylan Baker wrote: > > RuntimeError is a very specific type of error. In almost very case it's > > being raised where an assert is the right choice, and in the rest using > > a plain Exception is better, at least there it's obviou

Re: [Mesa-dev] [PATCH 11/41] glapi: remove superflous parens in python

2016-04-19 Thread Dylan Baker
Quoting Ian Romanick (2016-04-19 14:56:11) > On 03/31/2016 05:04 PM, Dylan Baker wrote: > > Remove parens that don't do anything. Mostly these are extra grouping > > parens in if statements, that aren't needed. Unlike C python doesn't > > require parens around the conditions of if statements, excep

Re: [Mesa-dev] [PATCH 07/41] glapi: remove useless returns from python code

2016-04-19 Thread Dylan Baker
Quoting Ian Romanick (2016-04-19 14:49:19) > I think I did that because it made emacs do-the-right-thing with the > indentation. The return told it to move up a level. Either way, this > patch is It doesn't surprise me that emacs would want the return (or did, they might have fixed it in the int

Re: [Mesa-dev] [RFC] add MAINTAINERS and get_maintainer.pl script

2016-04-19 Thread Matt Turner
On Tue, Apr 19, 2016 at 3:06 PM, Emil Velikov wrote: > Hi Rob, > > Speaking of maintainers... I have a patch somewhere that adds you as > maintainer for $linux/drivers/drm/gpu/msm/. > Guess I should send it already ;-) > > On 19 April 2016 at 22:11, Rob Clark wrote: >> From: Rob Clark >> >> Copi

Re: [Mesa-dev] [PATCH 06/41] glapi: normalize python newlines

2016-04-19 Thread Dylan Baker
Quoting Ian Romanick (2016-04-19 13:00:16) > This patch is > > Reviewed-by: Ian Romanick > > I guess the spurious whitespace changes in the previous patch should > have been in this patch. Probably, I'll see if I can fix that when I spin v2. > > On 03/31/2016 05:04 PM, Dylan Baker wrote: > >

Re: [Mesa-dev] [PATCH 03/41] glapi: Update copyright in python files to cover more than IBM

2016-04-19 Thread Dylan Baker
Quoting Ian Romanick (2016-04-19 12:53:00) > On 03/31/2016 05:04 PM, Dylan Baker wrote: > > It's a bit odd to call IBM out in particular, especially since Brian > > Paul is listed as a copyright holder on chronologically before IBM. > > Either way this should probably have the standard "authors and

Re: [Mesa-dev] [PATCH 02/13] isl: Add an ISL_RESTRICT #define for use in isl.h

2016-04-19 Thread Chad Versace
On Tue 19 Apr 2016, Jason Ekstrand wrote: > On Tue, Apr 19, 2016 at 3:14 PM, Chad Versace > wrote: > > > On Tue 19 Apr 2016, Matt Turner wrote: > > > On Sat, Apr 16, 2016 at 12:45 PM, Jason Ekstrand > > wrote: > > > > C++ doesn't define the "restrict" keyword so g++ barfs when it sees > > isl.h.

[Mesa-dev] [Bug 95003] [Clover / OpenCL] CL_DEVICE_WAVEFRONT_WIDTH_AMD - 0x4043 unimplemented

2016-04-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95003 --- Comment #2 from ros...@gmail.com --- hrm so is there a way with clover to find out the core count of the GPU(320 in my case)? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.__

Re: [Mesa-dev] [PATCH 02/41] glapi: encode python files in utf-8 rather than ascii

2016-04-19 Thread Dylan Baker
Quoting Ian Romanick (2016-04-19 12:51:04) > On 03/31/2016 05:04 PM, Dylan Baker wrote: > > This allows, among other things, the proper use of the Copyright symbol > > in the copyright header (which this patch also does). > > > > It cannot be used in the printed templates however, because they are

Re: [Mesa-dev] [PATCH 2b/3] nir/lower-tex: add srgb->linear lowering

2016-04-19 Thread Jason Ekstrand
2 and 2a are Reviewed-by: Jason Ekstrand On Tue, Apr 19, 2016 at 1:52 PM, Eric Anholt wrote: > Rob Clark writes: > > > From: Rob Clark > > > > Signed-off-by: Rob Clark > > Both are: > > Reviewed-by: Eric Anholt > ___ mesa-dev mailing list mesa-de

Re: [Mesa-dev] [PATCH 02/13] isl: Add an ISL_RESTRICT #define for use in isl.h

2016-04-19 Thread Jason Ekstrand
On Tue, Apr 19, 2016 at 3:14 PM, Chad Versace wrote: > On Tue 19 Apr 2016, Matt Turner wrote: > > On Sat, Apr 16, 2016 at 12:45 PM, Jason Ekstrand > wrote: > > > C++ doesn't define the "restrict" keyword so g++ barfs when it sees > isl.h. > > > Having our own define lets us define it to be a no-

Re: [Mesa-dev] [PATCH 10/13] i965/fs_surface_builder: Take a GL format enum instead of mesa_format

2016-04-19 Thread Chad Versace
On Sat 16 Apr 2016, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 8 +++- > src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp | 7 +-- > src/mesa/drivers/dri/i965/brw_fs_surface_builder.h | 4 ++-- > 3 files changed, 10 insertions(+), 9 deletions

[Mesa-dev] [PATCH 2/4] radeonsi: Use winsys pb_buffer for scratch buffers.

2016-04-19 Thread Bas Nieuwenhuizen
Allows allocation of >= 4 GiB. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 23 +++ src/gallium/drivers/radeonsi/si_pipe.c | 4 ++-- src/gallium/drivers/radeonsi/si_pipe.h | 4 ++-- src/gallium/drivers/radeonsi/si_

[Mesa-dev] [PATCH 4/4] radeonsi: Print a message when scratch allocation fails.

2016-04-19 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 5 - src/gallium/drivers/radeonsi/si_state_shaders.c | 5 - 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_co

[Mesa-dev] [PATCH 3/4] radeonsi: Prevent overflow when calculating the scratch size.

2016-04-19 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 5 - src/gallium/drivers/radeonsi/si_state_shaders.c | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compu

[Mesa-dev] [PATCH 1/4] radeonsi: use CE suballocator for CP DMA realignment.

2016-04-19 Thread Bas Nieuwenhuizen
Use the CE suballocator instead of the normal one as the usage is most similar to the CE, i.e. only read and written on GPU and not mapped to CPU. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_cp_dma.c | 27 ++- 1 file changed, 10 insertions(+), 17

Re: [Mesa-dev] [PATCH 07/13] nir/lower_double_ops: lower ceil()

2016-04-19 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Apr 12, 2016 at 1:05 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From: Iago Toral Quiroga > > At least i965 hardware does not have native support for ceil on doubles. > --- > src/compiler/nir/nir.h | 1 + > src/compiler/n

Re: [Mesa-dev] [PATCH 06/13] nir/lower_double_ops: lower floor()

2016-04-19 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Apr 12, 2016 at 1:05 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From: Iago Toral Quiroga > > At least i965 hardware does not have native support for floor on doubles. > --- > src/compiler/nir/nir.h | 1 + > src/compiler/

Re: [Mesa-dev] [PATCH 08/13] isl/format: Add more isl_format_has_type_channel functions

2016-04-19 Thread Chad Versace
On Sat 16 Apr 2016, Jason Ekstrand wrote: > --- > src/intel/isl/isl.h| 23 +++ > src/intel/isl/isl_format.c | 24 > 2 files changed, 43 insertions(+), 4 deletions(-) Patch 8 is Reviewed-by: Chad Versace ___

Re: [Mesa-dev] [PATCH 07/13] isl/format: Break the guts of has_[us]int_channel into a helper

2016-04-19 Thread Chad Versace
On Sat 16 Apr 2016, Jason Ekstrand wrote: > --- > src/intel/isl/isl_format.c | 34 -- > 1 file changed, 16 insertions(+), 18 deletions(-) > > diff --git a/src/intel/isl/isl_format.c b/src/intel/isl/isl_format.c > index 32bd701..b0450d9 100644 > --- a/src/intel/isl/

Re: [Mesa-dev] [PATCH 08/13] nir/lower_double_ops: lower fract()

2016-04-19 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Apr 12, 2016 at 1:05 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From: Iago Toral Quiroga > > At least i965 hardware does not have native support for fract() on doubles. > --- > src/compiler/nir/nir.h | 1 + > src/compile

Re: [Mesa-dev] [PATCH 05/13] nir/lower_double_ops: lower trunc()

2016-04-19 Thread Jason Ekstrand
On Tue, Apr 12, 2016 at 1:05 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From: Iago Toral Quiroga > > At least i965 hardware does not have native support for truncating doubles. > --- > src/compiler/nir/nir.h | 1 + > src/compiler/nir/nir_lower_double_ops.c |

Re: [Mesa-dev] [PATCH 06/13] anv/image: Use the has_matching_typed_storage_image_format helper from isl

2016-04-19 Thread Chad Versace
On Sat 16 Apr 2016, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_image.c | 15 +++ > 1 file changed, 3 insertions(+), 12 deletions(-) Patch 6 is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https:

Re: [Mesa-dev] [PATCH 05/13] isl: Add a helper for determining when a typed load/store can be used

2016-04-19 Thread Chad Versace
On Sat 16 Apr 2016, Jason Ekstrand wrote: > --- > src/intel/isl/isl.h | 7 +++ > src/intel/isl/isl_storage_image.c | 10 ++ > 2 files changed, 17 insertions(+) > +bool > +isl_has_matching_typed_storage_image_format(const struct brw_device_info > *devinfo, > +

Re: [Mesa-dev] [RFC] add MAINTAINERS and get_maintainer.pl script

2016-04-19 Thread Rob Clark
On Tue, Apr 19, 2016 at 6:06 PM, Emil Velikov wrote: > Hi Rob, > > Speaking of maintainers... I have a patch somewhere that adds you as > maintainer for $linux/drivers/drm/gpu/msm/. > Guess I should send it already ;-) > > On 19 April 2016 at 22:11, Rob Clark wrote: >> From: Rob Clark >> >> Copi

Re: [Mesa-dev] [PATCH 04/13] isl: Take a devinfo in lower_storage_image_format instead of an isl_device

2016-04-19 Thread Chad Versace
Patch 4 is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 03/13] isl: Don't use designated initializers in the header

2016-04-19 Thread Chad Versace
On Tue 19 Apr 2016, Emil Velikov wrote: > On 16 April 2016 at 20:45, Jason Ekstrand wrote: > > C++ doesn't support designated initializers and g++ in particular doesn't > > handle them when the struct gets complicated, i.e. has a union. > > --- > > src/intel/isl/isl.h | 32 ---

Re: [Mesa-dev] [PATCH 21/41] glapi: gl_XML.py: simplify gl_api.functionIterateByOffset

2016-04-19 Thread Ian Romanick
That's much better. This patch is Reviewed-by: Ian Romanick On 03/31/2016 05:04 PM, Dylan Baker wrote: > Use the max function and a generator expression instead of a loop and > if. This is certainly no less efficient, and saves several lines of > code. > > Signed-off-by: Dylan Baker > --- >

Re: [Mesa-dev] [PATCH 20/41] glapi: gl_XML.py: make gl_api.categoryIterate a generator

2016-04-19 Thread Ian Romanick
On 03/31/2016 05:04 PM, Dylan Baker wrote: > This does basically the same thing as the previous implementation, > although it uses sorted() to act on the dictionary without first copying > the keys out into a list, and then indexing back into the dict; and uses > yield to make the method a generato

Re: [Mesa-dev] [PATCH 02/13] isl: Add an ISL_RESTRICT #define for use in isl.h

2016-04-19 Thread Chad Versace
On Tue 19 Apr 2016, Matt Turner wrote: > On Sat, Apr 16, 2016 at 12:45 PM, Jason Ekstrand wrote: > > C++ doesn't define the "restrict" keyword so g++ barfs when it sees isl.h. > > Having our own define lets us define it to be a no-op for C++. > > --- > > src/intel/isl/isl.h | 18 ++---

Re: [Mesa-dev] [PATCH 19/41] glapi: gl_XML.py: remove gl_api.enumIterateByName

2016-04-19 Thread Ian Romanick
It looks like this hasn't been used since cbabf5f9. Should add that to the commit message for posterity. This patch is Reviewed-by: Ian Romanick On 03/31/2016 05:04 PM, Dylan Baker wrote: > Originally I planned to make it more efficient, but then realized that > it wasn't actually used anywher

Re: [Mesa-dev] [PATCH v2] i965: add build rule for brw_nir_trig_workarounds.c on Android

2016-04-19 Thread Emil Velikov
On 19 April 2016 at 20:51, Rob Herring wrote: > Commit bfd17c76c126 ("i965: Port INTEL_PRECISE_TRIG=1 to NIR.") added a > generated file brw_nir_trig_workarounds.c which broke the Android build. > Add the necessary makefiles to the Android build. > > Cc: Kenneth Graunke > Cc: Emil Velikov Thanks

Re: [Mesa-dev] [PATCH 18/41] glapi: gl_XML.py: use python's iter() function rather than calling __iter__

2016-04-19 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 03/31/2016 05:04 PM, Dylan Baker wrote: > Python has what are often referred to as "magic methods". __iter__, > __str__, __add__, and countless more. All of these methods exist to be > called by another function or by an operator. The __add__ method > i

Re: [Mesa-dev] [PATCH 17/41] glapi: replace RuntimeError with asserts or Exception

2016-04-19 Thread Ian Romanick
On 03/31/2016 05:04 PM, Dylan Baker wrote: > RuntimeError is a very specific type of error. In almost very case it's > being raised where an assert is the right choice, and in the rest using > a plain Exception is better, at least there it's obvious it's not that > the python runtime hit an interna

Re: [Mesa-dev] [RFC] add MAINTAINERS and get_maintainer.pl script

2016-04-19 Thread Emil Velikov
Hi Rob, Speaking of maintainers... I have a patch somewhere that adds you as maintainer for $linux/drivers/drm/gpu/msm/. Guess I should send it already ;-) On 19 April 2016 at 22:11, Rob Clark wrote: > From: Rob Clark > > Copied from linux kernel, with minimal changes to script (just to > recog

  1   2   3   >