On Friday, March 25, 2016 2:15:51 PM PDT Jordan Justen wrote:
> Note: This patch appears to violate older OpenGL and OpenGLES specs.
>
> The OpenGLES GLSL 3.1 and OpenGL GLSL 4.3 specifications both remove
> the requirement for the output and input centroid qualifiers to match.
>
> The deqp
> dEQ
Hi all,
Patches for implementing all the pieces of ARB_enhanced_layouts (and
therefore the remain pieces of OpenGL 4.4) are now on the list.
However things are in limbo with component packing due to the
complexity and issues with patch 24 [1].
During development I went from passing the packing in
There is no linear filtering for integer formats, so we should always
be using CLAMP_TO_EDGE mode.
Fixes 46 dEQP cases on Ivybridge.
This workaround doesn't appear to be necessary on later hardware, and
I haven't found any documentation mentioning errata in this area.
However, it seems harmless t
NOTE: someone with access will need to commit this patch after the
review process
v2: modify error message
v3: parse the float instead of returning an ERROR_TOK
Invalidates float suffixes for glsl 1.10
Fixes the following piglit tests:
tests/spec/glsl-1.10/compiler/literals/invalid-float-s
That sounds good to me, I will submit a v3 with those edits.
On Mon, Mar 28, 2016 at 9:19 PM, Kenneth Graunke
wrote:
> On Monday, March 28, 2016 8:16:17 PM PDT Lars Hamre wrote:
> > NOTE: someone with access will need to commit this patch after the
> > review process
> >
> > Invalidates fl
Texture sample instructions specify a sampler unit and texture target
such as "1D", "2D", "CUBE", etc. Sampler view declarations also specify
the sampler unit and texture target.
This patch checks that the texture instructions agree with the declarations
and collects the texture target type for e
No longer called from any other file.
---
src/mesa/main/mipmap.c | 16
src/mesa/main/mipmap.h | 7 ---
2 files changed, 8 insertions(+), 15 deletions(-)
diff --git a/src/mesa/main/mipmap.c b/src/mesa/main/mipmap.c
index cb9afde..5ff53f4 100644
--- a/src/mesa/main/mipmap.c
++
The prepare_mipmap_level() wrapper for _mesa_prepare_mipmap_level() is
not needed. It only served to undo the GL_TEXTURE_1D_ARRAY height/depth
change was was made before the call to prepare_mipmap_level()
Said another way, regardless of how the meta code manipulates the height/
depth dims for GL_
Simplifies the loops in generate_mipmap_uncompressed() and
generate_mipmap_compressed(). Will be used in the state tracker too.
Could probably be used in the meta code. If so, some additional
clean-ups can be done after that.
v2: use unsigned types instead of GLuint, per Ian
---
src/mesa/main/m
On 03/28/2016 02:23 PM, Brian Paul wrote:
On 03/28/2016 12:39 PM, Ian Romanick wrote:
On 03/26/2016 10:21 AM, Brian Paul wrote:
Simplifies the loops in generate_mipmap_uncompressed() and
generate_mipmap_compressed(). Will be used in the state tracker too.
Could probably be used in the meta cod
On Monday, March 28, 2016 8:16:17 PM PDT Lars Hamre wrote:
> NOTE: someone with access will need to commit this patch after the
> review process
>
> Invalidates float suffixes for glsl 1.10
>
> Fixes the following piglit tests:
> tests/spec/glsl-1.10/compiler/literals/invalid-float-suffix-c
OES_texture_buffer combines bits from a number of desktop extensions.
When they're all available, turn it on.
Signed-off-by: Ilia Mirkin
---
src/mesa/state_tracker/st_extensions.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/mesa/state_tracker/st_extensions.c
b/src/mesa/state_t
On Mon, Mar 28, 2016 at 3:04 PM, Ian Romanick wrote:
>> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
>> index 9aec425..731b62e 100644
>> --- a/src/mesa/main/bufferobj.c
>> +++ b/src/mesa/main/bufferobj.c
>> @@ -148,8 +148,8 @@ get_buffer_target(struct gl_context *ctx, GLenum
NOTE: someone with access will need to commit this patch after the
review process
Invalidates float suffixes for glsl 1.10
Fixes the following piglit tests:
tests/spec/glsl-1.10/compiler/literals/invalid-float-suffix-capital-f.vert
tests/spec/glsl-1.10/compiler/literals/invalid-float-suffix
---
src/mesa/drivers/dri/i965/brw_nir_opt_peephole_ffma.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_nir_opt_peephole_ffma.c
b/src/mesa/drivers/dri/i965/brw_nir_opt_peephole_ffma.c
index 6e8b1f9..22ff2e3 100644
--- a/src/mesa/drivers/dri/i965/br
In the first pass of implementing exact handling, I made a mistake with
search-and-replace. In particular, we only reallly handled exact/inexact
on the root of the tree. Instead, we need to check every node in the tree
for an exact/inexact match. As an example of this, consider the following
GLS
In the first pass of implementing exact handling, I made a mistake with
search-and-replace. In particular, we only reallly handled exact/inexact
on the root of the tree. Instead, we need to check every node in the tree
for an exact/inexact match. As an example of this, consider the following
GLS
On Sat, 2016-03-26 at 10:03 -0400, Lars Hamre wrote:
> Invalidates float suffixes for glsl 1.10
>
> Fixes the following piglit tests:
> tests/spec/glsl-1.10/compiler/literals/invalid-float-suffix-capital-
> f.vert
> tests/spec/glsl-1.10/compiler/literals/invalid-float-suffix-f.vert`
>
> Signed-of
On Mon, 2016-03-28 at 20:50 +0200, Alejandro Piñeiro wrote:
> Useful to know if a expression is the recipient of an assignment
> or not, that would be used to (for example) raise warnings of
> "use of uninitialized variable" without getting a false positive
> when assigning first a variable.
>
> B
On Thursday, March 17, 2016 4:42:08 PM PDT Jordan Justen wrote:
> On 2016-03-17 01:04:27, Kenneth Graunke wrote:
> > Yuanhan Liu decided these were useful for linear filtering in
> > commit 76669381 (circa 2011). Prior to that, we never set them;
> > it seems he tried to preserve that behavior for
On 03/28/2016 12:39 PM, Ian Romanick wrote:
On 03/26/2016 10:21 AM, Brian Paul wrote:
Simplifies the loops in generate_mipmap_uncompressed() and
generate_mipmap_compressed(). Will be used in the state tracker too.
Could probably be used in the meta code. If so, some additional
clean-ups can be
This patch is
Reviewed-by: Ian Romanick
On 02/27/2016 01:30 PM, Ilia Mirkin wrote:
> Expose the samplerBuffer/imageBuffer types, and allow the various
> functions to operate on them.
>
> Signed-off-by: Ilia Mirkin
> ---
> src/compiler/glsl/builtin_functions.cpp | 20 ++--
> s
https://bugs.freedesktop.org/show_bug.cgi?id=94731
Alex Deucher changed:
What|Removed |Added
Product|Mesa|freedesktop.org
Assignee|mesa-d
https://bugs.freedesktop.org/show_bug.cgi?id=94731
--- Comment #2 from Alex Deucher ---
I approve giving Bas access to mesa. He has produced a lot of great patches
for mesa.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
On Mon, Mar 28, 2016 at 11:31 AM, Ian Romanick wrote:
> On 03/23/2016 08:09 PM, Jason Ekstrand wrote:
> > Is there a 64-bit pow in GLSL? If so, this is the right implementation.
>
> There isn't. But there also aren't double versions of sin or cos, and
> 9076c4e2 added those. However, it didn't
On Mon, Mar 28, 2016 at 3:07 PM, Ian Romanick wrote:
> On 02/27/2016 01:39 PM, Ilia Mirkin wrote:
>> On Sat, Feb 27, 2016 at 4:30 PM, Ilia Mirkin wrote:
>>> Allow ES 3.1 contexts to access the texture buffer functionality.
>>>
>>> Signed-off-by: Ilia Mirkin
>>> ---
>>> docs/GL3.txt
https://bugs.freedesktop.org/show_bug.cgi?id=91556
--- Comment #13 from Vedran MiletiÄ ---
(In reply to Pavan Yalamanchili from comment #12)
> Is this patch going through into a future release?
Structs are not handled correctly even with the patch applied.
--
You are receiving this mail becau
LLVM when configured with "intel jitevents" enabled can inform
VTune about dynamic code, so individual shaders are attributed
profiling data and the resulting assembly can be examined.
---
src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 9 +
1 file changed, 9 insertions(+)
diff --git a/sr
On 03/28/2016 04:06 AM, eocallag...@alterapraxis.com wrote:
> Determinism is always better regardless of how you get there. A
> null pointer deference `on purpose` is a really poor idea in C.
> I am somewhat surprised you are asking if its really better to
> rely on undefined behavior vs. an assert
https://bugs.freedesktop.org/show_bug.cgi?id=94731
--- Comment #1 from Bas Nieuwenhuizen ---
Created attachment 122597
--> https://bugs.freedesktop.org/attachment.cgi?id=122597&action=edit
SSH key
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee
https://bugs.freedesktop.org/show_bug.cgi?id=94731
Bug ID: 94731
Summary: New account request
Product: Mesa
Version: unspecified
Hardware: Other
OS: All
Status: NEW
Severity: normal
Priority: med
On 02/27/2016 01:39 PM, Ilia Mirkin wrote:
> On Sat, Feb 27, 2016 at 4:30 PM, Ilia Mirkin wrote:
>> Allow ES 3.1 contexts to access the texture buffer functionality.
>>
>> Signed-off-by: Ilia Mirkin
>> ---
>> docs/GL3.txt| 2 +-
>> src/mapi/glapi/gen/apiexec.py
On Mon, Mar 28, 2016 at 1:58 PM, Patrick Baggett
wrote:
>> What are the rules in C when you compare a double
>> variable with a single constant?
>>
>> void foo(double d)
>> {
>> /* Does d get converted to single, or does 0.0f get converted to
>> * double?
>> */
>> if (d == 0.0f)
On 02/27/2016 01:30 PM, Ilia Mirkin wrote:
> Allow ES 3.1 contexts to access the texture buffer functionality.
I didn't review the get_texbuffer_format super closely, but the rest is
Reviewed-by: Ian Romanick
One other comment below that you can take or leave...
> Signed-off-by: Ilia Mirkin
>
> What are the rules in C when you compare a double
> variable with a single constant?
>
> void foo(double d)
> {
> /* Does d get converted to single, or does 0.0f get converted to
> * double?
> */
> if (d == 0.0f)
> printf("zero\n");
> }
The 0.0f is converted to a double
On 03/28/2016 11:53 AM, Ilia Mirkin wrote:
> On Mon, Mar 28, 2016 at 2:48 PM, Ian Romanick wrote:
>> On 02/27/2016 01:30 PM, Ilia Mirkin wrote:
>>> Signed-off-by: Ilia Mirkin
>>> ---
>>> src/mesa/main/extensions_table.h | 2 ++
>>> src/mesa/main/mtypes.h | 1 +
>>> 2 files changed, 3 i
On Mon, Mar 28, 2016 at 2:48 PM, Ian Romanick wrote:
> On 02/27/2016 01:30 PM, Ilia Mirkin wrote:
>> Signed-off-by: Ilia Mirkin
>> ---
>> src/mesa/main/extensions_table.h | 2 ++
>> src/mesa/main/mtypes.h | 1 +
>> 2 files changed, 3 insertions(+)
>>
>> diff --git a/src/mesa/main/exten
Rhys Kidd writes:
> On Saturday, March 19, 2016, Rhys Kidd wrote:
>
>> Found with grep and inspection. Test compiled on RPi hw.
>> Assists any future effort to remove TGSI as an intermediate stage.
>>
>> Signed-off-by: Rhys Kidd >
>> ---
>> src/gallium/drivers/vc4/vc4_nir_lower_txf_ms.c | 1 -
>
v2:
* Take into account out varyings too (Timothy Arceri)
* Fix style (Timothy Arceri)
* Use a new ast_expression variable, instead of an
ast_expression::hir new parameter (Timothy Arceri)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94129
---
src/compiler/glsl/ast_to_hir.cpp | 7
Useful to know if a expression is the recipient of an assignment
or not, that would be used to (for example) raise warnings of
"use of uninitialized variable" without getting a false positive
when assigning first a variable.
By default the value is false, and it is assigned to true on
the followin
This is a re-send of some patches that I sent one month ago, because
as they had a partial review and some new versions of those patches,
I assume that it would be easier this way (correct me if I'm wrong).
The original send can be found here:
https://lists.freedesktop.org/archives/mesa-dev/2016-F
On 02/27/2016 01:30 PM, Ilia Mirkin wrote:
> Signed-off-by: Ilia Mirkin
> ---
> src/mesa/main/extensions_table.h | 2 ++
> src/mesa/main/mtypes.h | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/src/mesa/main/extensions_table.h
> b/src/mesa/main/extensions_table.h
> index c1
On 03/26/2016 10:21 AM, Brian Paul wrote:
> Simplifies the loops in generate_mipmap_uncompressed() and
> generate_mipmap_compressed(). Will be used in the state tracker too.
> Could probably be used in the meta code. If so, some additional
> clean-ups can be done after that.
I'm in favor of just
On 03/23/2016 08:09 PM, Jason Ekstrand wrote:
> Is there a 64-bit pow in GLSL? If so, this is the right implementation.
There isn't. But there also aren't double versions of sin or cos, and
9076c4e2 added those. However, it didn't add double versions of fexp2
or flog2 (both of which are not sup
Only tangentially related, but just making sure you're aware of
GL_ARB_compute_variable_group_size - this allows the local size to be
specified at dispatch time rather than at shader compile time. I
believe your proposed scheme would allow this to be handled as well.
-ilia
On Thu, Mar 24, 2016
One typo below otherwise: Reviewed-by: Sinclair Yeh
On Sat, Mar 26, 2016 at 11:21:19AM -0600, Brian Paul wrote:
> The whole st_generate_mipmap() function was overly complicated. Now
> we just call the new _mesa_prepare_mipmap_levels() function to prepare
> the texture mipmap memory, then call t
Quoting Ian Romanick (2016-03-28 11:03:58)
> On 03/25/2016 05:33 PM, Dylan Baker wrote:
> > Quoting Dylan Baker (2016-03-25 16:01:00)
> >> Quoting Adam Jackson (2016-03-24 11:10:01)
> >>> Signed-off-by: Adam Jackson
> >>> ---
> >>> src/mapi/glapi/gen/gl_XML.py | 2 +-
> >>> 1 file changed, 1 inse
I am confused by this patch. Mesa drivers doesn't support
GL_NV_vertex_program, but the library still supports the protocol for it
for compatibility with other server implementations.
src/glx/glxextensions.c still tries to advertise support. I'm guess
that these aren't getting stuffed in the disp
On Mon, 2016-03-28 at 10:53 -0700, Ian Romanick wrote:
> On 03/24/2016 11:10 AM, Adam Jackson wrote:
> > +print 'if (a == 0 || b == 0) return 0;'
> Is this check actually necessary?
Yes because ...
> > +print 'if (a > INT_MAX / b) return -1;'
... you don't want to divide
On 03/24/2016 11:10 AM, Adam Jackson wrote:
> ---
> src/mapi/glapi/gen/glX_XML.py| 2 +-
> src/mapi/glapi/gen/glX_proto_recv.py | 2 --
> src/mapi/glapi/gen/glX_proto_send.py | 2 --
> src/mapi/glapi/gen/glX_proto_size.py | 24 +++-
> src/mapi/glapi/gen/gl_XML.py
On 03/25/2016 05:33 PM, Dylan Baker wrote:
> Quoting Dylan Baker (2016-03-25 16:01:00)
>> Quoting Adam Jackson (2016-03-24 11:10:01)
>>> Signed-off-by: Adam Jackson
>>> ---
>>> src/mapi/glapi/gen/gl_XML.py | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/src/mapi/gla
Interesting... I had to look up what __attribute__('cold') did. Learn
something new every day...
This patch is
Reviewed-by: Ian Romanick
On 03/24/2016 11:10 AM, Adam Jackson wrote:
> A modest size savings:
>
>text data bss dec hex filename
> 264143 15608
This patch is
Reviewed-by: Ian Romanick
On 03/24/2016 11:10 AM, Adam Jackson wrote:
> Squashes the one remaining warning in the xserver build.
>
> Signed-off-by: Adam Jackson
> ---
> src/mapi/glapi/gen/glX_proto_recv.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a
This patch is
Reviewed-by: Ian Romanick
On 03/24/2016 11:10 AM, Adam Jackson wrote:
> Signed-off-by: Adam Jackson
> ---
> src/mapi/glapi/gen/glX_proto_recv.py | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/mapi/glapi/gen/glX_proto_recv.py
> b/src/mapi/glapi/gen/glX_proto_re
On 03/24/2016 11:10 AM, Adam Jackson wrote:
> We're about to update the generator scripts to use these, easier not to
> vary between client and server.
>
> Signed-off-by: Adam Jackson
> ---
> src/mapi/glapi/gen/glX_proto_send.py | 24
> 1 file changed, 24 insertions(+)
>
Come on! It's always fun to run a bunch of tests on the old code and
wonder why nothing changed.
This patch is
Reviewed-by: Ian Romanick
On 03/24/2016 11:10 AM, Adam Jackson wrote:
> Meaning, always rebuild them when asked instead of bothering to look at
> timestamps (and then wondering why no
This patch is
Reviewed-by: Ian Romanick
On 03/24/2016 11:09 AM, Adam Jackson wrote:
> Signed-off-by: Adam Jackson
> ---
> src/mapi/glapi/gen/glX_proto_recv.py | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/src/mapi/glapi/gen/glX_proto_recv.py
> b/src/mapi
This patch is
Reviewed-by: Ian Romanick
On 03/24/2016 11:09 AM, Adam Jackson wrote:
> Signed-off-by: Adam Jackson
> ---
> src/mapi/glapi/gen/Makefile.am | 11 ---
> src/mapi/glapi/gen/glX_proto_recv.py | 33 ++---
> 2 files changed, 10 insertions(+), 3
On 03/28/2016 10:38 AM, Ilia Mirkin wrote:
On Mon, Mar 28, 2016 at 12:31 PM, Brian Paul wrote:
On 03/28/2016 10:20 AM, Ilia Mirkin wrote:
Thanks! On the off chance you're in the mood for reviewing the rest of
the series but it's lost in your inbox, you can find it here:
https://urldefense.p
On Mon, Mar 28, 2016 at 12:31 PM, Brian Paul wrote:
> On 03/28/2016 10:20 AM, Ilia Mirkin wrote:
>>
>> Thanks! On the off chance you're in the mood for reviewing the rest of
>> the series but it's lost in your inbox, you can find it here:
>>
>>
>> https://urldefense.proofpoint.com/v2/url?u=https-3
On Fri, Mar 25, 2016 at 8:38 PM, Stéphane Marchesin wrote:
> On Wed, Mar 23, 2016 at 5:22 PM, Rob Herring wrote:
>> On Fri, Mar 4, 2016 at 12:07 PM, Rob Clark wrote:
>>> On Fri, Mar 4, 2016 at 12:59 PM, Rob Clark wrote:
So, I've been advocating that for android, gallium drivers use
gr
This can happen when using glDispatchCompute while having only a
compute shader bound.
As far as I can see st_upload_constants is only called with
shader_type = PIPE_SHADER_FRAGMENT if st->fp is not null, and in other
calls the second part of the if condition does not get executed.
- Bas
On Mon,
Reviewed-by: Brian Paul
On 03/27/2016 09:19 AM, Ilia Mirkin wrote:
1-month ping
dEQP has a number of tests both for texture buffers, as well as image
buffers. would be nice to have access to those.
-ilia
On Sat, Feb 27, 2016 at 4:29 PM, Ilia Mirkin wrote:
This fixes all failures with d
On 03/28/2016 05:01 PM, Bas Nieuwenhuizen wrote:
Signed-off-by: Bas Nieuwenhuizen
---
src/mesa/state_tracker/st_atom_constbuf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/state_tracker/st_atom_constbuf.c
b/src/mesa/state_tracker/st_atom_constbuf.c
index
Pushed, thanks.
Marek
On Mon, Mar 28, 2016 at 5:01 PM, Bas Nieuwenhuizen
wrote:
> Signed-off-by: Bas Nieuwenhuizen
> ---
> src/mesa/state_tracker/st_atom_constbuf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/state_tracker/st_atom_constbuf.c
> b/src/m
Signed-off-by: Bas Nieuwenhuizen
---
src/mesa/state_tracker/st_atom_constbuf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/state_tracker/st_atom_constbuf.c
b/src/mesa/state_tracker/st_atom_constbuf.c
index 4d9b344..a980dbe 100644
--- a/src/mesa/state_tracker/
On 03/26/2016 09:51 PM, Timothy Arceri wrote:
The only place this was used was in a gallium debug function that
had to be manually enabled.
I think used this years ago to debug something or other. I guess I can
re-apply it if I ever need it again.
Reviewed-by: Brian Paul
---
src/compi
Determinism is always better regardless of how you get there. A
null pointer deference `on purpose` is a really poor idea in C.
I am somewhat surprised you are asking if its really better to
rely on undefined behavior vs. an assert.
I thought about using a if branch and just returning but I think
To not overwrite buffers and surfaces information, we need to use
a different offset in the driver constant buffer. Currently, OP_SUQ
is only supported for buffers but this will be slightly updated for
images support.
Signed-off-by: Samuel Pitoiset
---
.../drivers/nouveau/codegen/nv50_ir_driver.
From: Patrick Rudolph
Some apps set NEG and ABS on the source param to test for zero.
Use ALU_OP3_CNDE insted of ALU_OP3_CNDGE and unset both modifiers.
It also removes the need for a MOV instruction, as ABS isn't
supported on op3.
Tested on AMD CAYMAN and AMD RV770.
Signed-off-by: Patrick Rud
From: Patrick Rudolph
Some apps set NEG and ABS on the source param to test for zero.
Use ALU_OP3_CNDE insted of ALU_OP3_CNDGE and unset both modifiers.
It also removes the need for a MOV instruction, as ABS isn't
supported on op3.
Tested on AMD CAYMAN and AMD RV770.
Signed-off-by: Patrick Rud
From: Patrick Rudolph
Some apps set NEG and ABS on the source param to test for zero.
Use ALU_OP3_CNDE insted of ALU_OP3_CNDGE and unset both modifiers.
It also removes the need for a MOV instruction, as ABS isn't
supported on op3.
Tested on AMD CAYMAN and AMD RV770.
Signed-off-by: Patrick Rud
https://bugs.freedesktop.org/show_bug.cgi?id=94711
Michel Dänzer changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
73 matches
Mail list logo
