When would that happen? When a user force-enables
ARB_query_buffer_object for a driver that's not ready for it? Is
hitting a deterministic assert in that case any better than hitting a
null deref?
On Sun, Mar 27, 2016 at 11:52 PM, Edward O'Callaghan
wrote:
> Just because we miss a gallium driver
Just because we miss a gallium driver callback don't dereference
invalid memory.
Signed-off-by: Edward O'Callaghan
---
src/mesa/state_tracker/st_cb_queryobj.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/state_tracker/st_cb_queryobj.c
b/src/mesa/state_tracker/st_cb_queryobj.c
in
https://bugs.freedesktop.org/show_bug.cgi?id=94710
--- Comment #1 from Michel Dänzer ---
Please submit patches directly (preferably using git send-email, but definitely
generated by git format-patch) to the mesa-dev@lists.freedesktop.org list for
review.
--
You are receiving this mail because:
On Mon, Mar 28, 2016 at 12:40 AM, Ilia Mirkin wrote:
> Reviewed-by: Ilia Mirkin
>
> I would personally move the for loop down below the "simple" checks.
> Purely optional.
OK. I'll do that.
Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.or
Reviewed-by: Ilia Mirkin
I would personally move the for loop down below the "simple" checks.
Purely optional.
On Sun, Mar 27, 2016 at 2:25 PM, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/gallium/auxiliary/util/u_framebuffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Ilia Mirkin
I was too concentrated on fixing those array piglits to think of this
issue :) I do wonder why dEQP doesn't hit it... i guess 1d arrays
aren't a thing in GLES? Either way, this seems right.
On Sun, Mar 27, 2016 at 2:25 PM, Marek Olšák wrote:
> From: Marek Olšák
>
> The
On Sun, Mar 27, 2016 at 4:49 PM, Marek Olšák wrote:
> On Sun, Mar 27, 2016 at 8:41 PM, Rob Clark wrote:
>> oh, whoops, the ir3 bits were meant to be squashed into a different
>> patch on top of this patchset, which enables ir3 support for nir as
>> preferred IR.. and I think the nir_foreach_vari
On Sun, Mar 27, 2016 at 8:41 PM, Rob Clark wrote:
> oh, whoops, the ir3 bits were meant to be squashed into a different
> patch on top of this patchset, which enables ir3 support for nir as
> preferred IR.. and I think the nir_foreach_variable_safe() bit is
> already in Jason's patchset (so I'll
On 03/27/2016 05:46 PM, Marek Olšák wrote:
Reviewed-by: Marek Olšák
Thanks but actually this patch no longer applies and it is useless since
https://cgit.freedesktop.org/cgit/?url=mesa/mesa/commit/&id=2df141087a56da20ad50b379b4a63426b870344a
Marek
On Fri, Mar 25, 2016 at 12:30 AM, Samu
oh, whoops, the ir3 bits were meant to be squashed into a different
patch on top of this patchset, which enables ir3 support for nir as
preferred IR.. and I think the nir_foreach_variable_safe() bit is
already in Jason's patchset (so I'll either pull in his patch or
rebase on top of his patchset s
From: Marek Olšák
The st_texture_object documentation says:
"the number of 1D array layers will be in height0"
We can't minify that.
Spotted by luck. No app is known to hit this issue.
---
src/mesa/state_tracker/st_cb_texture.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
dif
From: Marek Olšák
---
src/gallium/auxiliary/util/u_framebuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/util/u_framebuffer.c
b/src/gallium/auxiliary/util/u_framebuffer.c
index 2e0ef74..3798d9b 100644
--- a/src/gallium/auxiliary/util/u_framebuff
This patch contains several unrelated changes and cleanups.
Marek
On Sat, Mar 26, 2016 at 10:02 PM, Rob Clark wrote:
> From: Rob Clark
>
> Signed-off-by: Rob Clark
> ---
> src/compiler/nir/nir.h | 2 +
> .../drivers/freedreno/ir3/ir3_compiler_nir.c | 8 +
Reviewed-by: Marek Olšák
Marek
On Sat, Mar 26, 2016 at 10:02 PM, Rob Clark wrote:
> From: Rob Clark
>
> We'll want to re-use this for NIR.
>
> Signed-off-by: Rob Clark
> ---
> src/mesa/Makefile.sources | 2 +
> src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 64 +--
Patches 1-2:
Reviewed-by: Marek Olšák
Marek
On Sat, Mar 26, 2016 at 10:02 PM, Rob Clark wrote:
> From: Rob Clark
>
> Signed-off-by: Rob Clark
> Reviewed-by: Roland Scheidegger
> ---
> src/gallium/include/pipe/p_defines.h | 1 +
> src/gallium/include/pipe/p_screen.h | 9 +
> src/ga
On Sun, Mar 27, 2016 at 8:01 PM, Ilia Mirkin wrote:
> On Thu, Mar 24, 2016 at 9:43 PM, Bas Nieuwenhuizen
> wrote:
>> diff --git a/src/gallium/include/pipe/p_screen.h
>> b/src/gallium/include/pipe/p_screen.h
>> index 4f30e75..6d44cf7 100644
>> --- a/src/gallium/include/pipe/p_screen.h
>> +++ b/sr
I'd like somebody else to take a look at patches 5 & 7.
I've pushed the rest.
Marek
On Thu, Mar 24, 2016 at 1:12 AM, Miklós Máté wrote:
> Now it follows the compatibility criteria listed in section 2.1 of
> the GLX 1.4 specification.
> This is needed for post-process effects in SW:KotOR.
>
> Si
On Thu, Mar 24, 2016 at 9:43 PM, Bas Nieuwenhuizen
wrote:
> diff --git a/src/gallium/include/pipe/p_screen.h
> b/src/gallium/include/pipe/p_screen.h
> index 4f30e75..6d44cf7 100644
> --- a/src/gallium/include/pipe/p_screen.h
> +++ b/src/gallium/include/pipe/p_screen.h
> @@ -109,13 +109,16 @@ stru
The idea sounds good to me.
Marek
On Fri, Mar 25, 2016 at 2:43 AM, Bas Nieuwenhuizen
wrote:
> For radeonsi, native and TGSI use different compilers and this results
> in different limits for different IR's.
>
> The set we strictly need for radeonsi is only the MAX_BLOCK_SIZE
> and MAX_THREADS_PE
ping^3 (1 month since I sent the v2 of the series out)
This enables a bunch of dEQP tests which are a lot more discerning
than the ones we have in piglit. It also points out some problems we
have in our (mesa-wide) interpolateAt* support + varying packing.
Full series is at https://patchwork.free
Looks good.
Marek
On Fri, Mar 25, 2016 at 2:43 AM, Bas Nieuwenhuizen
wrote:
> Currently radeonsi synchronizes after every dispatch and Clover
> does nothing to synchronize. This is overzealous, especially with
> GL compute, so add a barrier for global buffers.
>
> Signed-off-by: Bas Nieuwenhuize
If this is only needed by TGSI, adding TGSI properties is preferred.
Marek
On Fri, Mar 25, 2016 at 2:43 AM, Bas Nieuwenhuizen
wrote:
> This avoids shader variants for radeonsi, or if we go with
> shader variants, it lets us compile an initial variant.
>
> Signed-off-by: Bas Nieuwenhuizen
> ---
This looks good.
Marek
On Fri, Mar 25, 2016 at 2:43 AM, Bas Nieuwenhuizen
wrote:
> Needed to distinguish NATIVE and TGSI compute shaders on
> compute state creation.
>
> Signed-off-by: Bas Nieuwenhuizen
> ---
> src/gallium/drivers/trace/tr_dump_state.c | 2 ++
> src/gallium/include/pip
Reviewed-by: Marek Olšák
Marek
On Sun, Mar 27, 2016 at 4:38 AM, Edward O'Callaghan
wrote:
> Signed-off-by: Edward O'Callaghan
> ---
> src/gallium/drivers/r600/r600_pipe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/r600/r600_pipe.c
> b/src/gal
Reviewed-by: Marek Olšák
Marek
On Sun, Mar 27, 2016 at 4:38 AM, Edward O'Callaghan
wrote:
> Signed-off-by: Edward O'Callaghan
> ---
> docs/GL3.txt | 2 +-
> docs/relnotes/11.3.0.html | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/docs/GL3.txt b/docs/GL3
On Sun, Mar 27, 2016 at 4:38 AM, Edward O'Callaghan
wrote:
> Lets give the developer a little hand if we are going to assert
> on a zero literal at the end of a branch.
>
> Signed-off-by: Edward O'Callaghan
> ---
> src/gallium/drivers/radeonsi/si_state.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Marek Olšák
Marek
On Sun, Mar 27, 2016 at 4:38 AM, Edward O'Callaghan
wrote:
> Signed-off-by: Edward O'Callaghan
> ---
> src/gallium/drivers/radeonsi/si_pipe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_pipe.c
> b/src
Reviewed-by: Marek Olšák
Marek
On Sun, Mar 27, 2016 at 4:38 AM, Edward O'Callaghan
wrote:
> For ARB_framebuffer_no_attachment; A is_format_supported() query
> with 'PIPE_FORMAT_NONE' passed implies a query of the number of
> samples supported from the framebuffer with no attachment.
>
> Signed-
On Sun, Mar 27, 2016 at 4:38 AM, Edward O'Callaghan
wrote:
> Signed-off-by: Edward O'Callaghan
> ---
> src/mesa/main/fbobject.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
> index bb8d4c3..42f40b2 100644
> --- a/src/mesa/main/
On Sun, Mar 27, 2016 at 4:38 AM, Edward O'Callaghan
wrote:
> Using PIPE_FORMAT_NONE to indicate what MSAA modes are supported
> with a framebuffer using no attachment.
>
> V.2:
> Rewrite MSAA mode loop to be more general.
>
> Signed-off-by: Edward O'Callaghan
> ---
> src/mesa/state_tracker/st_a
On Sun, Mar 27, 2016 at 4:38 AM, Edward O'Callaghan
wrote:
> Set default values for the constants required in
> ARB_framebuffer_no_attachments and obtained the number
> of layers from ``PIPE_CAP_MAX_TEXTURE_ARRAY_LAYERS``.
>
> We also obtain the MaxFramebufferSamples value using
> a query back to
On Sun, Mar 27, 2016 at 4:38 AM, Edward O'Callaghan
wrote:
> Add PIPE_CAP to determine if the GL extension
> 'GL_ARB_framebuffer_no_attachments' shall be
> supported.
>
> The driver is required to support 'PIPE_FORMAT_NONE'
> via its 'is_format_supported()' callback in order
> to determine the MSA
Pushed, thanks.
Marek
On Sun, Mar 27, 2016 at 4:05 AM, Edward O'Callaghan
wrote:
> Signed-off-by: Edward O'Callaghan
> ---
> src/gallium/include/pipe/p_context.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/include/pipe/p_context.h
> b/src/gallium/inclu
This series looks good to me. I'll push it shortly.
Marek
On Sat, Mar 26, 2016 at 8:35 AM, Edward O'Callaghan
wrote:
> While here, remove itermediate glsl_feature_level variable.
>
> Signed-off-by: Edward O'Callaghan
> ---
> src/mesa/state_tracker/st_extensions.c | 15 +--
> 1 file
Reviewed-by: Marek Olšák
Marek
On Fri, Mar 25, 2016 at 12:30 AM, Samuel Pitoiset
wrote:
> radeonsi and nouveau are pretty close to have OpenGL 4.2.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/mesa/state_tracker/st_extensions.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
1-month ping
dEQP has a number of tests both for texture buffers, as well as image
buffers. would be nice to have access to those.
-ilia
On Sat, Feb 27, 2016 at 4:29 PM, Ilia Mirkin wrote:
> This fixes all failures with dEQP tests in this area. While
> ARB_texture_buffer_object explicitly say
This is a tiny housekeeping patch which does the following:
* Replaced tabs with three spaces.
* Formatted oneline and multiline code comments. Some doxygen
comments weren't marked as such and some code comments were marked
as doxygen comments.
* Spaces between if- and while-statemen
37 matches
Mail list logo
