[Mesa-dev] [PATCH] mesa: Check glReadBuffer enums against the ES3 table.

2016-03-23 Thread Kenneth Graunke
From the ES 3.2 spec, section 16.1.1 (Selecting Buffers for Reading): "An INVALID_ENUM error is generated if src is not BACK or one of the values from table 15.5." Table 15.5 contains NONE and COLOR_ATTACHMENTi. Mesa properly returned INVALID_ENUM for unknown enums, but it decided what wa

Re: [Mesa-dev] [PATCH] mesa: Include null terminator in GL_DEBUG_NEXT_LOGGED_MESSAGE_LENGTH.

2016-03-23 Thread Eduardo Lima Mitev
Good catch! Reviewed-by: Eduardo Lima Mitev On 03/24/2016 06:24 AM, Kenneth Graunke wrote: From the KHR_debug spec: "Applications can query the number of messages currently in the log by obtaining the value of DEBUG_LOGGED_MESSAGES, and the string length (including its null terminator) of

[Mesa-dev] [PATCH] mesa: Include null terminator in GL_DEBUG_NEXT_LOGGED_MESSAGE_LENGTH.

2016-03-23 Thread Kenneth Graunke
From the KHR_debug spec: "Applications can query the number of messages currently in the log by obtaining the value of DEBUG_LOGGED_MESSAGES, and the string length (including its null terminator) of the oldest message in the log through the value of DEBUG_NEXT_LOGGED_MESSAGE_LENGTH." Because we

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-03-23 Thread Eric Anholt
Rob Herring writes: > On Fri, Mar 4, 2016 at 12:07 PM, Rob Clark wrote: >> On Fri, Mar 4, 2016 at 12:59 PM, Rob Clark wrote: >>> So, I've been advocating that for android, gallium drivers use >>> gralloc_drm_pipe, since with android it seems like you end up with >>> both gralloc and libGL in th

[Mesa-dev] Build completed: mesa 695

2016-03-23 Thread AppVeyor
Build mesa 695 completed Commit 4e060d80ff by Jason Ekstrand on 3/24/2016 4:04 AM: glsl: Add propagate_invariance to the other makefile\n\nThis fixes the scons build Configure your notification preferences

Re: [Mesa-dev] [PATCH 1/5] winsys/amdgpu: addrlib - add Polaris support

2016-03-23 Thread Michel Dänzer
On 24.03.2016 03:43, Alex Deucher wrote: > > diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_id.h > b/src/gallium/winsys/amdgpu/drm/amdgpu_id.h > index 90fe0cd..b9e20b8 100644 > --- a/src/gallium/winsys/amdgpu/drm/amdgpu_id.h > +++ b/src/gallium/winsys/amdgpu/drm/amdgpu_id.h > @@ -138,6 +138,10

Re: [Mesa-dev] [PATCH] nir: Use double-precision pow() when bit_size is 64, powf() otherwise

2016-03-23 Thread Jason Ekstrand
Is there a 64-bit pow in GLSL? If so, this is the right implementation. Reviewed-by: Jason Ekstrand On Mar 23, 2016 7:42 PM, "Ian Romanick" wrote: > From: Ian Romanick > > Found (randomly) by inspection. Looking at the rest of the changes in > this file in commit 9076c4e2, I'm certain this i

Re: [Mesa-dev] [PATCH 04/12] nir/algebraic: Allow for flagging operations as being inexact

2016-03-23 Thread Francisco Jerez
Jason Ekstrand writes: > --- > src/compiler/nir/nir_algebraic.py | 9 - > src/compiler/nir/nir_opt_algebraic.py | 9 - > src/compiler/nir/nir_search.c | 4 > src/compiler/nir/nir_search.h | 6 ++ > 4 files changed, 26 insertions(+), 2 deletions(-) > >

[Mesa-dev] [PATCH] nir: Use double-precision pow() when bit_size is 64, powf() otherwise

2016-03-23 Thread Ian Romanick
From: Ian Romanick Found (randomly) by inspection. Looking at the rest of the changes in this file in commit 9076c4e2, I'm certain this is what was intended. Signed-off-by: Ian Romanick Cc: Connor Abbott Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/nir/nir_opcodes.py | 2 +- 1 file

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-03-23 Thread Chih-Wei Huang
2016-03-24 8:51 GMT+08:00 Rob Clark : [deleted] > > [*] the caveat there is vmwgfx stuff which seems to want to do blits.. > although I'm not entirely sure why or if that is even still requires > w/ newer vmware players. But if vmwgfx still really needs the blit > path, I guess they could still ke

[Mesa-dev] [PATCH] glsl: reduce buffer block duplication

2016-03-23 Thread Timothy Arceri
This reduces some of the craziness required for handing buffer blocks. The problem is each shader stage holds its own information about a block in memory, we were copying that information to a program wide list but the per stage information remained meaning when a binding was updated we needed to u

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-03-23 Thread Rob Clark
On Wed, Mar 23, 2016 at 8:22 PM, Rob Herring wrote: > On Fri, Mar 4, 2016 at 12:07 PM, Rob Clark wrote: >> On Fri, Mar 4, 2016 at 12:59 PM, Rob Clark wrote: >>> So, I've been advocating that for android, gallium drivers use >>> gralloc_drm_pipe, since with android it seems like you end up with >

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-03-23 Thread Rob Herring
On Fri, Mar 4, 2016 at 12:07 PM, Rob Clark wrote: > On Fri, Mar 4, 2016 at 12:59 PM, Rob Clark wrote: >> So, I've been advocating that for android, gallium drivers use >> gralloc_drm_pipe, since with android it seems like you end up with >> both gralloc and libGL in the same process, and having b

[Mesa-dev] [PATCH 4/8] st/mesa: enable GL_ATI_fragment_shader

2016-03-23 Thread Miklós Máté
Signed-off-by: Miklós Máté --- docs/relnotes/11.3.0.html | 1 + src/mesa/state_tracker/st_extensions.c | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/relnotes/11.3.0.html b/docs/relnotes/11.3.0.html index 04564a8..0a1ecbf 100644 --- a/docs/relnotes/11.3.0.html +++ b/docs/

[Mesa-dev] [PATCH 2/8] program: add ATI_fragment_shader to shader stages list

2016-03-23 Thread Miklós Máté
Signed-off-by: Miklós Máté --- src/mesa/program/program.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/program/program.h b/src/mesa/program/program.h index 24e0597..09e6928 100644 --- a/src/mesa/program/program.h +++ b/src/mesa/program/program.h @@ -172,6 +172,8 @@ _mesa_program

[Mesa-dev] [PATCH 5/8] main: rework the compatibility check of visuals in glXMakeCurrent

2016-03-23 Thread Miklós Máté
Now it follows the compatibility criteria listed in section 2.1 of the GLX 1.4 specification. This is needed for post-process effects in SW:KotOR. Signed-off-by: Miklós Máté --- src/mesa/main/context.c | 42 -- 1 file changed, 12 insertions(+), 30 deletion

[Mesa-dev] [PATCH 7/8] glx: fix the refcounting of dri drawables

2016-03-23 Thread Miklós Máté
This fixes premature deallocation on unbind, and introduces support for deleting GLX drawables while they are current to a context. Note that in practice this also introduces a resource leak, because nobody uses the GLX 1.3 glXDestroyWindow and glXDestroyPixmap calls. This fixes disappearing char

[Mesa-dev] [PATCH 1/8] mesa: optionally associate a gl_program to ATI_fragment_shader

2016-03-23 Thread Miklós Máté
the state tracker will use it Acked-by: Brian Paul Reviewed-by: Ian Romanick Signed-off-by: Miklós Máté --- src/mesa/drivers/common/driverfuncs.c | 3 +++ src/mesa/main/atifragshader.c | 13 - src/mesa/main/dd.h| 5 + src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 6/8] st/mesa: fix handling the fallback texture

2016-03-23 Thread Miklós Máté
This fixes crash when post-processing is enabled in SW:KotOR. v2: fix const-ness v3: move assignment into the if() block Signed-off-by: Miklós Máté --- src/mesa/state_tracker/st_atom_sampler.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_a

[Mesa-dev] [PATCH 8/8] mesa: optimize out the realloc from glCopyTexImagexD()

2016-03-23 Thread Miklós Máté
v2: comment about the purpose of the code v3: also compare texFormat, add a perf debug message, formatting fixes Reviewed-by: Ian Romanick Signed-off-by: Miklós Máté --- src/mesa/main/teximage.c | 36 1 file changed, 36 insertions(+) diff --git a/src/mesa

[Mesa-dev] [PATCH 0/8] Fixes for SW:KotOR (v4)

2016-03-23 Thread Miklós Máté
Hi, this series is the fourth version of my patch set, which aims to improve the looks of Star Wars: Knights of the Old Republic (via Wine). The main feature is the implementation of GL_ATI_fragment_shader for all Gallium divers (though I could only test it with radeonsi, llvmpipe, and softpipe

[Mesa-dev] [PATCH 3/8] st/mesa: implement GL_ATI_fragment_shader

2016-03-23 Thread Miklós Máté
v2: fix arithmetic for special opcodes, fix fog state, cleanup v3: simplify handling of special opcodes, fix rebinding with different textargets or fog equation, lots of formatting fixes v4: adapt to the compile early, fix later architecture, formatting fixes Signed-off-by: Miklós Máté --- s

[Mesa-dev] [Bug 92877] Add support for libglvnd

2016-03-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92877 Mike Lothian changed: What|Removed |Added CC||m...@fireburn.co.uk -- You are receiving

[Mesa-dev] Build failed: mesa 694

2016-03-23 Thread AppVeyor
Build mesa 694 failed Commit a984e44abd by Jason Ekstrand on 3/17/2016 10:20 PM: nir/glsl: Propagate invariant into NIR alu ops\n\nReviewed-by: Francisco Jerez Configure your notification preferences ___ m

Re: [Mesa-dev] [PATCH] i965: Always use BRW_TEXCOORDMODE_CUBE when seamless filtering.

2016-03-23 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Mar 23, 2016 3:40 PM, "Kenneth Graunke" wrote: > When using seamless cube map mode and NEAREST filtering, we explicitly > overrode the wrap modes to CLAMP_TO_EDGE. This was to implement the > following spec text: > >"If NEAREST filtering is done within a miple

[Mesa-dev] [PATCH] virgl: drop next shader property for now.

2016-03-23 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/gallium/drivers/virgl/virgl_tgsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/virgl/virgl_tgsi.c b/src/gallium/drivers/virgl/virgl_tgsi.c index 641b0b3..4a2271f 100644 --- a/src/gallium/drivers/virgl/virgl_tgsi.c

Re: [Mesa-dev] [PATCH] nv50/ir: silence unhandled TGSI_PROPERTY_NEXT_SHADER info

2016-03-23 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Mar 23, 2016 at 6:29 PM, Samuel Pitoiset wrote: > radeonsi uses this property to make the best decision about which > shader to compile, but this is not currently used by our codegen. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/codege

[Mesa-dev] [Bug 94522] llvmpipe crash in rendering on Atom

2016-03-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94522 --- Comment #17 from Jose Fonseca --- (In reply to comicfans44 from comment #16) > > How can I help to identify if this is the root cause ? I'm not familar with Wayland implementation details. The said memory must be allocated by one of the

[Mesa-dev] [PATCH] i965: Always use BRW_TEXCOORDMODE_CUBE when seamless filtering.

2016-03-23 Thread Kenneth Graunke
When using seamless cube map mode and NEAREST filtering, we explicitly overrode the wrap modes to CLAMP_TO_EDGE. This was to implement the following spec text: "If NEAREST filtering is done within a miplevel, always apply apply wrap mode CLAMP_TO_EDGE." However, textureGather() ignores th

[Mesa-dev] [PATCH] nv50/ir: silence unhandled TGSI_PROPERTY_NEXT_SHADER info

2016-03-23 Thread Samuel Pitoiset
radeonsi uses this property to make the best decision about which shader to compile, but this is not currently used by our codegen. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/driv

[Mesa-dev] [Bug 92877] Add support for libglvnd

2016-03-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92877 Sven changed: What|Removed |Added CC||sven.koeh...@gmail.com -- You are receiving this

Re: [Mesa-dev] About the usage of the "flat" interpolation qualifier with input (unsigned) integers and doubles in fragment shaders

2016-03-23 Thread Ian Romanick
On 03/18/2016 09:52 PM, Jason Ekstrand wrote: > > > On Fri, Mar 4, 2016 at 5:43 AM, Andres Gomez > wrote: > > Hi, > > as complementary work to the one done to "Add FP64 support to the i965 > shader backends" at: > https://bugs.freedesktop.org/show_bug.

Re: [Mesa-dev] [PATCH] gallium/swr: update rasterizer (532172)

2016-03-23 Thread Rowley, Timothy O
> On Mar 23, 2016, at 2:19 PM, Tom Stellard wrote: > > On Wed, Mar 23, 2016 at 04:53:29PM +, Rowley, Timothy O wrote: >> >> While that situation would be nice, the swr rasterizer is a subset of an >> internal project, and what is upstreamed publicly is not just a straight >> copy of our r

Re: [Mesa-dev] [PATCH] nir: add/export nir_variable_clone()

2016-03-23 Thread Rob Clark
On Wed, Mar 23, 2016 at 4:55 PM, Jason Ekstrand wrote: > > On Mar 23, 2016 1:15 PM, "Rob Clark" wrote: >> >> From: Rob Clark >> >> Signed-off-by: Rob Clark >> --- >> src/compiler/nir/nir.h | 1 + >> src/compiler/nir/nir_clone.c | 16 >> 2 files changed, 17 insertions(+)

Re: [Mesa-dev] [PATCH] nir: add/export nir_variable_clone()

2016-03-23 Thread Jason Ekstrand
On Mar 23, 2016 1:15 PM, "Rob Clark" wrote: > > From: Rob Clark > > Signed-off-by: Rob Clark > --- > src/compiler/nir/nir.h | 1 + > src/compiler/nir/nir_clone.c | 16 > 2 files changed, 17 insertions(+) > > diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h >

Re: [Mesa-dev] [PATCH] st/mesa: use RGBA instead of BGRA for SRGB_ALPHA

2016-03-23 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Mar 23, 2016 at 9:23 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This fixes a regression introduced by commit a8eea696 "st/mesa: honour sized > internal formats in st_choose_format (v2)". > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id

[Mesa-dev] [Bug 94657] [llvmpipe] [softpipe] piglit arb_texture_view-getteximage-srgb regression

2016-03-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94657 --- Comment #1 from Nicolai Hähnle --- I missed that test somehow, sorry for that. There's a fix here: https://patchwork.freedesktop.org/patch/78118/ -- You are receiving this mail because: You are the assignee for the bug. You are the QA Conta

[Mesa-dev] [PATCH] st/mesa: use RGBA instead of BGRA for SRGB_ALPHA

2016-03-23 Thread Nicolai Hähnle
From: Nicolai Hähnle This fixes a regression introduced by commit a8eea696 "st/mesa: honour sized internal formats in st_choose_format (v2)". Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94657 --- src/mesa/state_tracker/st_format.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH] nir: add/export nir_variable_clone()

2016-03-23 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_clone.c | 16 2 files changed, 17 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 69a3084..724aa77 100644 --- a/src/compiler/nir/nir.h +++ b/

Re: [Mesa-dev] [PATCH 05/12] nir/algebraic: Flag inexact optimizations

2016-03-23 Thread Jason Ekstrand
On Wed, Mar 23, 2016 at 12:22 PM, Francisco Jerez wrote: > Jason Ekstrand writes: > > > On Mar 23, 2016 2:07 AM, "Francisco Jerez" > wrote: > >> > >> Jason Ekstrand writes: > >> > >> > Many of our optimizations, while great for cutting shaders down to > size, > >> > aren't really precision-saf

Re: [Mesa-dev] [PATCH 2/3] mesa/st: Trivial, use glsl_feature_level var consistently

2016-03-23 Thread Marek Olšák
On Wed, Mar 23, 2016 at 4:21 AM, Edward O'Callaghan wrote: > Signed-off-by: Edward O'Callaghan > --- > src/mesa/state_tracker/st_extensions.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/state_tracker/st_extensions.c > b/src/mesa/state_tracker/st_ext

Re: [Mesa-dev] [PATCH 05/12] nir/algebraic: Flag inexact optimizations

2016-03-23 Thread Francisco Jerez
Francisco Jerez writes: > Jason Ekstrand writes: > >> On Mar 23, 2016 2:07 AM, "Francisco Jerez" wrote: >>> >>> Jason Ekstrand writes: >>> >>> > Many of our optimizations, while great for cutting shaders down to size, >>> > aren't really precision-safe. This commit tries to flag all of the >>

Re: [Mesa-dev] [PATCH] radeonsi: silence a coverity warning

2016-03-23 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Mar 23, 2016 at 6:00 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The following Coverity warning > > 5378tmpl.fetch_args = atomic_fetch_args; > 5379tmpl.emit = atomic_emit; CID 1357115: Uninitialized variables (U

Re: [Mesa-dev] [PATCH 05/12] nir/algebraic: Flag inexact optimizations

2016-03-23 Thread Francisco Jerez
Jason Ekstrand writes: > On Mar 23, 2016 2:07 AM, "Francisco Jerez" wrote: >> >> Jason Ekstrand writes: >> >> > Many of our optimizations, while great for cutting shaders down to size, >> > aren't really precision-safe. This commit tries to flag all of the >> > inexact floating-point optimizat

Re: [Mesa-dev] [PATCH] gallium/swr: update rasterizer (532172)

2016-03-23 Thread Tom Stellard
On Wed, Mar 23, 2016 at 04:53:29PM +, Rowley, Timothy O wrote: > > > On Mar 23, 2016, at 12:52 AM, Kenneth Graunke wrote: > > > > That's an awkward situation we've not run into before. > > > > If the code is going to live in the upstream Mesa git repository, then > > it seems like the best

Re: [Mesa-dev] [PATCH 1/2] AMDGPU/SI: Add Polaris support

2016-03-23 Thread Tom Stellard
On Wed, Mar 23, 2016 at 02:41:24PM -0400, Alex Deucher via llvm-commits wrote: > From: Sonny Jiang > These two patches need to be squashed, but I can do it before I commit. LGTM. -Tom > Signed-off-by: Sonny Jiang > Reviewed-by: Alex Deucher > --- > lib/Target/AMDGPU/Processors.td | 8 +

[Mesa-dev] [PATCH 2/5] radeonsi: add support for Polaris (v2)

2016-03-23 Thread Alex Deucher
From: Sonny Jiang v2: Polaris chips should be defined after Stoney Signed-off-by: Sonny Jiang (v1) Reviewed-by: Michel Dänzer (v1) Signed-off-by: Leo Liu (v2 diff) Reviewed-by: Alex Deucher (v2 diff) --- src/gallium/drivers/radeon/r600_pipe_common.c | 9 + src/gallium/drivers/radeon

[Mesa-dev] [PATCH 4/5] radeon/vce: add Polaris11 VCE firmware support

2016-03-23 Thread Alex Deucher
From: Sonny Jiang Signed-off-by: Sonny Jiang --- src/gallium/drivers/radeon/radeon_vce.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_vce.c b/src/gallium/drivers/radeon/radeon_vce.c index 2ab74e9..6584393 100644 --- a/src/gallium/drivers/radeon/radeo

[Mesa-dev] [PATCH 5/5] radeon/vce: disable two pipe mode for Polaris11

2016-03-23 Thread Alex Deucher
From: Sonny Jiang Signed-off-by: Sonny Jiang Reviewed-by: Leo Liu --- src/gallium/drivers/radeon/radeon_vce.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vce.c b/src/gallium/drivers/radeon/radeon_vce.c index 6584393..99b82ca 100644 -

[Mesa-dev] [PATCH 3/5] radeonsi: add Polaris PCI IDs

2016-03-23 Thread Alex Deucher
From: Sonny Jiang Signed-off-by: Sonny Jiang Reviewed-by: Alex Deucher (Polaris10) Reviewed-by: Michel Dänzer (Polaris11) --- include/pci_ids/radeonsi_pci_ids.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/pci_ids/radeonsi_pci_ids.h b/include/pci_ids/radeonsi_pci_i

[Mesa-dev] [PATCH 1/5] winsys/amdgpu: addrlib - add Polaris support

2016-03-23 Thread Alex Deucher
From: Sonny Jiang Signed-off-by: Sonny Jiang Reviewed-by: Alex Deucher Reviewed-by: Michel Dänzer --- src/gallium/winsys/amdgpu/drm/addrlib/r800/ciaddrlib.cpp | 8 +++- src/gallium/winsys/amdgpu/drm/addrlib/r800/ciaddrlib.h | 2 ++ src/gallium/winsys/amdgpu/drm/amdgpu_id.h

[Mesa-dev] [PATCH 1/2] AMDGPU/SI: Add Polaris support

2016-03-23 Thread Alex Deucher
From: Sonny Jiang Signed-off-by: Sonny Jiang Reviewed-by: Alex Deucher --- lib/Target/AMDGPU/Processors.td | 8 1 file changed, 8 insertions(+) diff --git a/lib/Target/AMDGPU/Processors.td b/lib/Target/AMDGPU/Processors.td index 32c327d..7c93c6a 100644 --- a/lib/Target/AMDGPU/Process

[Mesa-dev] [PATCH 2/2] AMDGPU/SI: Specify LDS bank count for Polaris

2016-03-23 Thread Alex Deucher
From: Tom Stellard --- lib/Target/AMDGPU/Processors.td | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Target/AMDGPU/Processors.td b/lib/Target/AMDGPU/Processors.td index 7c93c6a..5903bdf 100644 --- a/lib/Target/AMDGPU/Processors.td +++ b/lib/Target/AMDGPU/Processors.

Re: [Mesa-dev] [PATCH 05/12] nir/algebraic: Flag inexact optimizations

2016-03-23 Thread Jason Ekstrand
On Mar 23, 2016 2:07 AM, "Francisco Jerez" wrote: > > Jason Ekstrand writes: > > > Many of our optimizations, while great for cutting shaders down to size, > > aren't really precision-safe. This commit tries to flag all of the > > inexact floating-point optimizations so they don't get run on val

Re: [Mesa-dev] [PATCH v3] compiler/glsl: allow sequence op as a const expr in gles 1.0

2016-03-23 Thread Eduardo Lima Mitev
Pushed: https://cgit.freedesktop.org/mesa/mesa/commit/?id=43c6f3f82f62f28dc97d195750ba25c88051b64e I edited a bit the commit message before pushing, to wrap lines. We try to avoid lines longer than 72 ~ 80 columns. Thanks, Eduardo On 03/23/2016 06:13 PM, Lars Hamre wrote: Thanks! Will do in

Re: [Mesa-dev] [PATCH v3] compiler/glsl: allow sequence op as a const expr in gles 1.0

2016-03-23 Thread Lars Hamre
Thanks! Will do in the future. Regards, Lars On Wed, Mar 23, 2016 at 1:08 PM, Eduardo Lima Mitev wrote: > Hi Lars, > > I suppose you need help pushing your patch upstream. I will do it. > > As a note for the future, once you get a formal Review-by to a patch, it > is not necessary to send a new

Re: [Mesa-dev] [PATCH v3] compiler/glsl: allow sequence op as a const expr in gles 1.0

2016-03-23 Thread Eduardo Lima Mitev
Hi Lars, I suppose you need help pushing your patch upstream. I will do it. As a note for the future, once you get a formal Review-by to a patch, it is not necessary to send a new version only to add the tag. You can instead ask directly someone with committing rights to merge it for you. ch

[Mesa-dev] [PATCH] radeonsi: silence a coverity warning

2016-03-23 Thread Nicolai Hähnle
From: Nicolai Hähnle The following Coverity warning 5378tmpl.fetch_args = atomic_fetch_args; 5379tmpl.emit = atomic_emit; >>> CID 1357115: Uninitialized variables (UNINIT) >>> Using uninitialized value "tmpl". Field "tmpl.intr_name" is >>> uninitialized. 5380

Re: [Mesa-dev] [PATCH] gallium/swr: update rasterizer (532172)

2016-03-23 Thread Rowley, Timothy O
> On Mar 23, 2016, at 12:52 AM, Kenneth Graunke wrote: > > That's an awkward situation we've not run into before. > > If the code is going to live in the upstream Mesa git repository, then > it seems like the best long term plan is to reverse the workflow: make > upstream Mesa the canonical rep

Re: [Mesa-dev] [PATCH] gallium/swr: update rasterizer (532172)

2016-03-23 Thread Rowley, Timothy O
> On Mar 23, 2016, at 12:52 AM, Justen, Jordan L > wrote: > > On 2016-03-22 20:55:10, Rowley, Timothy O wrote: >> >> Yes, there’s a lot in this patch. I froze the public version of the >> rasterizer when I began the upstreaming process mid February, so >> this is syncing up with about a month’

Re: [Mesa-dev] [PATCH 3/3] mesa/st: Remove GLSLVersion clamping

2016-03-23 Thread Nicolai Hähnle
If you're going to abolish the clamping entirely (which is admittedly a matter of taste), I'd rather remove the glsl_feature_level variable and assign to consts->GLSLVersion directly. Cheers, Nicolai On 22.03.2016 22:21, Edward O'Callaghan wrote: Signed-off-by: Edward O'Callaghan --- src/m

Re: [Mesa-dev] [PATCH 1/3] radeon/r600_query.c: Minor style fix

2016-03-23 Thread Nicolai Hähnle
On 22.03.2016 22:21, Edward O'Callaghan wrote: Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/radeon/r600_query.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Nicolai Hähnle diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/gallium/drivers/rade

Re: [Mesa-dev] [PATCH] mesa: replace gl_context->Multisample._Enabled with _mesa_is_multisample_enabled.

2016-03-23 Thread Brian Paul
No regressions here, Bas. -Brian On 03/22/2016 01:27 PM, Brian Paul wrote: If you can wait until tomorrow, Bas, I'll do an overight piglit run to check for regressions. -Brian On 03/22/2016 12:31 PM, Marek Olšák wrote: Reviewed-by: Marek Olšák Somebody from Intel or VMWare might want to ta

Re: [Mesa-dev] [PATCH 07/29] nir/lower_tex: fix get_zero_or_one() to use sized types

2016-03-23 Thread Jason Ekstrand
On Mar 23, 2016 12:32 AM, "Samuel Iglesias Gonsálvez" wrote: > > On 21/03/16 23:40, Jason Ekstrand wrote: > > On Mon, Mar 21, 2016 at 3:39 PM, Jason Ekstrand > > wrote: > > > >> > >> > >> On Mon, Mar 21, 2016 at 5:05 AM, Samuel Iglesias Gonsálvez < > >> sigles...@igalia.com> wrote: > >> > >>> Fro

Re: [Mesa-dev] [PATCH 14/29] nir: add support for printing double immediates

2016-03-23 Thread Jason Ekstrand
On Mar 23, 2016 2:59 AM, "Samuel Iglesias Gonsálvez" wrote: > > > > On 22/03/16 16:17, Samuel Iglesias Gonsálvez wrote: > > On 21/03/16 23:49, Jason Ekstrand wrote: > >> On Mon, Mar 21, 2016 at 5:05 AM, Samuel Iglesias Gonsálvez < > >> sigles...@igalia.com> wrote: > >> > >>> From: Connor Abbott >

[Mesa-dev] [PATCH v3] compiler/glsl: allow sequence op as a const expr in gles 1.0

2016-03-23 Thread Lars Hamre
v3: Added reviewed-by tag v2: Fixed regression pointed out by Eduardo Lima Mitev Allow the sequence operator to be a constant expression in GLSL ES versions prior to GLSL ES 3.0 Fixes the following piglit test: /all/spec/glsl-es-1.0/compiler/array-sized-by-sequence-in-parenthesis.vert

Re: [Mesa-dev] [PATCH 19/29] nir: fix up bit sizes for undefined alu sources

2016-03-23 Thread Samuel Iglesias Gonsálvez
On 22/03/16 17:37, Jason Ekstrand wrote: > On Mar 22, 2016 8:18 AM, "Samuel Iglesias Gonsálvez" > wrote: >> >> >> >> On 21/03/16 23:54, Jason Ekstrand wrote: >>> On Mon, Mar 21, 2016 at 5:05 AM, Samuel Iglesias Gonsálvez < >>> sigles...@igalia.com> wrote: >>> From: Iago Toral Quiroga

[Mesa-dev] [GSOC] looking for information

2016-03-23 Thread Iurie
hi, well, i am not very proficient, so i hope that with this project idea [Switch OpenMAX state tracker in Mesa/Gallium to use Tizonia from http://www.x.org/wiki/SummerOfCodeIdeas/] to solidify my knowledges. i never have contributed to anything. i do not have a blog. i am in electronics engineerin

Re: [Mesa-dev] [PATCH 11/11] docs: mark atomic counters and SSBOs as done for radeonsi

2016-03-23 Thread Marek Olšák
Other than my comment on patch 2, which should be addressed, this series is: Reviewed-by: Marek Olšák Marek On Tue, Mar 22, 2016 at 12:22 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > While I'm at it, add the image extensions in the GL ES section of GL3.txt. > --- > docs/GL3.txt

Re: [Mesa-dev] [PATCH] radeonsi: fix 2D array MSAA failures since image support landed

2016-03-23 Thread Marek Olšák
On Wed, Mar 23, 2016 at 4:52 AM, Michel Dänzer wrote: > On 23.03.2016 02:27, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeonsi/si_state.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/src/gallium/drivers/radeonsi/si_state.c >> b/sr

Re: [Mesa-dev] [PATCH 14/29] nir: add support for printing double immediates

2016-03-23 Thread Samuel Iglesias Gonsálvez
On 22/03/16 16:17, Samuel Iglesias Gonsálvez wrote: > On 21/03/16 23:49, Jason Ekstrand wrote: >> On Mon, Mar 21, 2016 at 5:05 AM, Samuel Iglesias Gonsálvez < >> sigles...@igalia.com> wrote: >> >>> From: Connor Abbott >>> >>> --- >>> src/compiler/nir/nir_print.c | 5 - >>> 1 file changed, 4

Re: [Mesa-dev] [PATCH 05/12] nir/algebraic: Flag inexact optimizations

2016-03-23 Thread Francisco Jerez
Jason Ekstrand writes: > Many of our optimizations, while great for cutting shaders down to size, > aren't really precision-safe. This commit tries to flag all of the > inexact floating-point optimizations so they don't get run on values that > are flagged "exact". It's a bit conservative and m

Re: [Mesa-dev] [PATCH v2] compiler/glsl: allow sequence op as const expression for gles 1.0

2016-03-23 Thread Eduardo Lima Mitev
Reviewed-by: Eduardo Lima Mitev Thanks, Lars! Eduardo On 03/23/2016 03:14 AM, Lars Hamre wrote: v2: Fixed regression pointed out by Eduardo Lima Mitev Allow the sequence operator to be a constant expression in GLSL ES versions prior to GLSL ES 3.0 Fixes the following piglit test: /all/

Re: [Mesa-dev] [PATCH 07/29] nir/lower_tex: fix get_zero_or_one() to use sized types

2016-03-23 Thread Samuel Iglesias Gonsálvez
On 21/03/16 23:40, Jason Ekstrand wrote: > On Mon, Mar 21, 2016 at 3:39 PM, Jason Ekstrand > wrote: > >> >> >> On Mon, Mar 21, 2016 at 5:05 AM, Samuel Iglesias Gonsálvez < >> sigles...@igalia.com> wrote: >> >>> From: Iago Toral Quiroga >>> >>> v2 (Sam): >>> - Use helper to get type size from nir