Re: [Mesa-dev] [RFC] i965/dbg: Expose cases hitting a presumably dead optimization

2016-03-12 Thread Pohjolainen, Topi
On Sat, Mar 12, 2016 at 08:44:54AM -0800, Jason Ekstrand wrote: >On Mar 11, 2016 11:47 PM, "Pohjolainen, Topi" ><[1]topi.pohjolai...@intel.com> wrote: >> >> On Fri, Mar 11, 2016 at 05:59:37PM -0800, Jason Ekstrand wrote: >> >On Fri, Mar 11, 2016 at 4:40 AM, Topi Pohjolainen

Re: [Mesa-dev] [PATCH] softpipe: fix anisotropic filtering crash

2016-03-12 Thread Eduardo Lima Mitev
On 03/13/2016 06:53 AM, srol...@vmware.com wrote: From: Roland Scheidegger The filt_args->offset wasn't assigned but was always used later leading to a crash (as far as I can tell, texel offsets don't actually make much sense with anisotropic filtering, but because there's no explicit setting i

[Mesa-dev] [PATCH] softpipe: fix anisotropic filtering crash

2016-03-12 Thread sroland
From: Roland Scheidegger The filt_args->offset wasn't assigned but was always used later leading to a crash (as far as I can tell, texel offsets don't actually make much sense with anisotropic filtering, but because there's no explicit setting if offsets are enabled there the array is always acce

[Mesa-dev] [Bug 94503] OpenCL segfaults during compilation

2016-03-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94503 --- Comment #3 from Tyson Whitehead --- Created attachment 122262 --> https://bugs.freedesktop.org/attachment.cgi?id=122262&action=edit Simplified kernel that causes other (different) compiler segfault -- You are receiving this mail because:

[Mesa-dev] [Bug 94503] OpenCL segfaults during compilation

2016-03-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94503 --- Comment #2 from Tyson Whitehead --- Thanks for the heads-up Matt. I rebuilt the Debian package of mesa 11.2.0-rc3 against the Debian package of llvm 3.9~svn262954 and am pleased to say the simplified kernel I provided also now compiles for m

[Mesa-dev] [PATCH 2/3] nv50/ir: avoid folding mul + add if the mul has a dnz

2016-03-12 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp index 6192c06..66e7

[Mesa-dev] [PATCH 3/3] nv50, nvc0: handle SQRT lowering inside the driver

2016-03-12 Thread Ilia Mirkin
First off, st/mesa lowers DSQRT incorrectly (it uses CMP to attempt to find out whether the input is less than 0). Secondly the current approach (x * rsq(x)) behaves poorly for x = inf - a NaN is produced instead of inf. Instead we switch to the less accurate rcp(rsq(x)) method - this behaves nice

[Mesa-dev] [PATCH 1/3] nvc0: fix blit triangle size to fully cover FB's > 8192x8192

2016-03-12 Thread Ilia Mirkin
The idea is that a single triangle will cover the whole area being drawn, allowing the blit shader to do its work. However the max fb size is 16384x16384, which means that the triangle we draw needs to be twice that in order to cover the whole area fully. Increase the size of the triangle to 32768x

Re: [Mesa-dev] Mesa include guard style. (Was: [PATCH] i965/cfg: Remove redundant #pragma once.)

2016-03-12 Thread Ian Romanick
On 03/11/2016 03:46 PM, Eric Anholt wrote: > Ian Romanick writes: > >> On 03/10/2016 05:53 PM, Francisco Jerez wrote: >>> Iago Toral writes: >>> On Wed, 2016-03-09 at 19:04 -0800, Francisco Jerez wrote: > Matt Turner writes: > >> On Wed, Mar 9, 2016 at 1:37 PM, Francisco Jerez

Re: [Mesa-dev] [PATCH] radeonsi: avoid crash when a sampler state is bound for a buffer texture

2016-03-12 Thread Ilia Mirkin
On Fri, Mar 11, 2016 at 11:17 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Sampler states don't really make sense with buffer textures, but the PBO > upload code sets one because apparently nouveau needs it. It would be > nice to work that out at some point, but in any case being defensiv

[Mesa-dev] [PATCH 2/3] vc4: Add a helper for NIR->QIR control flow function node

2016-03-12 Thread Rhys Kidd
Templated implementation at present until the recently landed NIR function support is plumbed through. Signed-off-by: Rhys Kidd --- src/gallium/drivers/vc4/vc4_program.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/gallium/drivers/vc4/vc4_program.c b/src/gallium/drivers/

[Mesa-dev] [PATCH 3/3] vc4: Add NIR->QIR control flow graph loops

2016-03-12 Thread Rhys Kidd
Fixes the following piglit tests: - shaders/complex-loop-analysis-bug - shaders/glsl-fs-discard-04 Converts the following piglit tests from crash to fail: - shaders/glsl-fs-continue-inside-do-while - shaders/glsl-fs-loop - shaders/glsl-fs-loop-continue - shaders/glsl-fs-loop-nested - shaders/glsl-

[Mesa-dev] [PATCH 1/3] vc4: Add better debug of NIR->QIR control flow graph failure

2016-03-12 Thread Rhys Kidd
Ensure NIR control flow graph nodes that are unhandled in QIR are reported with sufficient verbosity to aid debugging. This improves piglit outputs, amongst other tools. There are no other remaining uses of assert(0) as a blunt tool within vc4. Signed-off-by: Rhys Kidd --- src/gallium/drivers/

[Mesa-dev] [PATCH 0/3] vc4: Rework NIR control flow graph handling

2016-03-12 Thread Rhys Kidd
Short patchset to go some way towards improving the handling of NIR control flow graphs in vc4. Whilst in no way completely addressing the known issues this improves piglit output, provides better internal handlers for loop and function nir_cf_node types and creates a cleaner base upon which to bu

Re: [Mesa-dev] [PATCH] mesa: Fix error condition for 1d array texture

2016-03-12 Thread Jason Ekstrand
On Mar 11, 2016 12:33 PM, "Alejandro Piñeiro" wrote: > > On 11/03/16 20:15, Anuj Phogat wrote: > > yoffset is also applicable to 1d array textures. > > > > Signed-off-by: Anuj Phogat > > --- > > I don't know if it fixes any test, but it looked incorrect to me. > > No one fixed doing a piglit all.

[Mesa-dev] ARB_shading_language_include

2016-03-12 Thread Karol Herbst
Hi all, the game "Divinity: Original Sin - Enhanced Edition" uses ARB_shading_language_include whenever it detects a non catalyst driver on Linux. Apitraces from the game running on catalyst show that the shaders are simply included within the game engine and replay fine with all mesa drivers as

Re: [Mesa-dev] [GSoC2016] Interested in implementing "Soft" double precision floating point support

2016-03-12 Thread tournier.elie
I found on PCC website that it was imported in OpenBSD and NetBSD system so the license should be compatible. I think I will use it as a base for add, multiply, absolute value, negate, convert to/from single precision, and comparison functions. Tomorrow, I will make a draft of my proposal for GSoC

Re: [Mesa-dev] [PATCH] radeonsi: avoid crash when a sampler state is bound for a buffer texture

2016-03-12 Thread Laurent Carlier
Le vendredi 11 mars 2016, 11:17:21 CET Nicolai Hähnle a écrit : > From: Nicolai Hähnle > > Sampler states don't really make sense with buffer textures, but the PBO > upload code sets one because apparently nouveau needs it. It would be > nice to work that out at some point, but in any case being

Re: [Mesa-dev] [PATCH 1/4] glcpp: Implicitly resolve version after the first non-space/hash token.

2016-03-12 Thread Jon Turney
On 10/03/2016 19:26, Kenneth Graunke wrote: On Wednesday, March 9, 2016 3:18:50 PM PST Jon Turney wrote: On 05/03/2016 03:33, Kenneth Graunke wrote: We resolved the implicit version directive when processing control lines, such as #ifdef, to ensure any built-in macros exist. However, we failed

Re: [Mesa-dev] vulkan: regression on Haswell

2016-03-12 Thread Jacek Konieczny
On 2016-03-12 19:21, Jason Ekstrand wrote: >> > Haswell should still work just fine if >> > you're on a 4.4 kernel, but we really should make it detect the command >> > parser version and do something intelligent. >> >> I am confused now… Should it 'work just fine' without this hack on 4.4, >> or i

Re: [Mesa-dev] vulkan: regression on Haswell

2016-03-12 Thread Jason Ekstrand
On Mar 12, 2016 9:11 AM, "Jacek Konieczny" wrote: > > On 2016-03-12 17:58, Jason Ekstrand wrote: > > There is a bug report that's tracking this regression: > > https://bugs.freedesktop.org/show_bug.cgi?id=94468 > > > > In the meantime, a workaround is comment out: > > genX(cmd_buff

Re: [Mesa-dev] vulkan: regression on Haswell

2016-03-12 Thread Jacek Konieczny
On 2016-03-12 17:58, Jason Ekstrand wrote: > There is a bug report that's tracking this regression: > https://bugs.freedesktop.org/show_bug.cgi?id=94468 > > In the meantime, a workaround is comment out: > genX(cmd_buffer_config_l3)(cmd_buffer, false); > in src/intel/vulkan/genX

Re: [Mesa-dev] vulkan: regression on Haswell

2016-03-12 Thread Jason Ekstrand
On Sat, Mar 12, 2016 at 8:29 AM, Nanley Chery wrote: > On Sat, Mar 12, 2016 at 12:20:26PM +0100, Jacek Konieczny wrote: > > On 2016-03-12 11:59, Jacek Konieczny wrote: > > > Hi, > > > > > > I have been playing with Vulkan API and using the Mesa Intel Vulkan > > > driver from the 'vulkan' branch.

Re: [Mesa-dev] [RFC] i965/dbg: Expose cases hitting a presumably dead optimization

2016-03-12 Thread Jason Ekstrand
On Mar 11, 2016 11:47 PM, "Pohjolainen, Topi" wrote: > > On Fri, Mar 11, 2016 at 05:59:37PM -0800, Jason Ekstrand wrote: > >On Fri, Mar 11, 2016 at 4:40 AM, Topi Pohjolainen > ><[1]topi.pohjolai...@intel.com> wrote: > > > > The logic iterates over param[] which contains pointers to >

Re: [Mesa-dev] [PATCH 01/14] nir: Add explicitly sized types

2016-03-12 Thread Connor Abbott
On Fri, Mar 11, 2016 at 2:33 AM, Samuel Iglesias Gonsálvez wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > > > On 11/03/16 01:08, Jason Ekstrand wrote: >> On Thu, Mar 10, 2016 at 4:00 PM, Connor Abbott >> wrote: >> >>> On Mon, Mar 7, 2016 at 3:45 AM, Samuel Iglesias Gonsálvez >>>

Re: [Mesa-dev] vulkan: regression on Haswell

2016-03-12 Thread Nanley Chery
On Sat, Mar 12, 2016 at 12:20:26PM +0100, Jacek Konieczny wrote: > On 2016-03-12 11:59, Jacek Konieczny wrote: > > Hi, > > > > I have been playing with Vulkan API and using the Mesa Intel Vulkan > > driver from the 'vulkan' branch. > > > > Recent driver upgrade has broken my, previously working c

Re: [Mesa-dev] vulkan: regression on Haswell

2016-03-12 Thread Jacek Konieczny
On 2016-03-12 11:59, Jacek Konieczny wrote: > Hi, > > I have been playing with Vulkan API and using the Mesa Intel Vulkan > driver from the 'vulkan' branch. > > Recent driver upgrade has broken my, previously working code, causing > massive flickering and graphical artifacts. > > git bisect have

[Mesa-dev] vulkan: regression on Haswell

2016-03-12 Thread Jacek Konieczny
Hi, I have been playing with Vulkan API and using the Mesa Intel Vulkan driver from the 'vulkan' branch. Recent driver upgrade has broken my, previously working code, causing massive flickering and graphical artifacts. git bisect have shown, that this is the breaking change: commit 7ebbc3946ae9

Re: [Mesa-dev] [PATCH] swrast: Delete the unused 'slice' parameter

2016-03-12 Thread Alejandro Piñeiro
On 12/03/16 00:16, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat Any reason to not just move the slice assert at line 243 as part of the checks of check_map_teximage? > --- > src/mesa/swrast/s_texture.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/swra