[Mesa-dev] [PATCH] mesa/fbobject: propogate Layered when reusing attachments.

From: Dave Airlie When reusing a depth attachment as a stencil, we need to propogate the layered bit, otherwise we fail to complete the framebuffer. discovered running ./bin/fbo-depth-array depth-layered-clear on virgl on haswell. Signed-off-by: Dave Airlie --- src/mesa/main/fbobject.c | 1 +

Re: [Mesa-dev] [PATCH 4/4] glx: fix error code when there is no context bound

On 02/22/2016 10:16 PM, Ian Romanick wrote: There are 17 total occurrences of grep -r '[(]!gc[)]' src/glx/ and grep -r 'gc[[:space:]]*==[[:space:]]*NULL' src/glx/ None of these check for dummyContext. This is all very suspicious. Looking at the implementation(s) of __glXGetCurrent

Re: [Mesa-dev] [PATCH 2/2] glsl: raise warning when using uninitialized variables

On 26/02/16 22:18, Ian Romanick wrote: > On 02/26/2016 07:09 AM, Alejandro Piñeiro wrote: >> v2: >> * Take into account out varyings too (Timothy Arceri) >> * Fix style (Timothy Arceri) >> * Use a new ast_expression variable, instead of an >>ast_expression::hir new parameter (Timothy Arcer

Re: [Mesa-dev] [PATCH 1/2] glsl: add is_lhs bool on ast_expression

On 26/02/16 22:15, Ian Romanick wrote: > On 02/26/2016 07:09 AM, Alejandro Piñeiro wrote: >> Useful to know if a expression is the recipient of an assignment >> or not, that would be used to (for example) raise warnings of >> "use of uninitialized variable" without getting a false positive >> whe

Re: [Mesa-dev] [PATCH] r600g: Fix ARB_texture_rgb10_a2ui support in big-endian

On Mon, Feb 29, 2016 at 12:31 AM, Oded Gabbay wrote: > On Mon, Feb 29, 2016 at 3:51 AM, Michel Dänzer wrote: >> On 28.02.2016 05:48, Oded Gabbay wrote: >>> This patch enables the correct detection of PIPE_FORMAT_R10G10B10A2_UINT >>> and PIPE_FORMAT_B10G10R10A2_UINT formats in r600g in big-endian

Re: [Mesa-dev] [PATCH] r600g: Fix ARB_texture_rgb10_a2ui support in big-endian

On Mon, Feb 29, 2016 at 3:51 AM, Michel Dänzer wrote: > On 28.02.2016 05:48, Oded Gabbay wrote: >> This patch enables the correct detection of PIPE_FORMAT_R10G10B10A2_UINT >> and PIPE_FORMAT_B10G10R10A2_UINT formats in r600g in big-endian mode, by >> adjusting the order of channels in various func

Re: [Mesa-dev] [PATCH 1/2] radeonsi: allow dumping shader disassemblies to a file

On 26.02.2016 19:37, Marek Olšák wrote: > On Fri, Feb 26, 2016 at 4:27 AM, Michel Dänzer wrote: >> >> What's the purpose of this change? Unless I'm missing something, only >> stderr is ever passed in. > > The second patch uses it. Ah, yes, indeed. This patch is Reviewed-by: Michel Dänzer as w

Re: [Mesa-dev] [PATCH] r600g: Fix ARB_texture_rgb10_a2ui support in big-endian

On 28.02.2016 05:48, Oded Gabbay wrote: > This patch enables the correct detection of PIPE_FORMAT_R10G10B10A2_UINT > and PIPE_FORMAT_B10G10R10A2_UINT formats in r600g in big-endian mode, by > adjusting the order of channels in various functions. > > This enables support for ARB_texture_rgb10_a2ui,

Re: [Mesa-dev] [PATCH 01/26] docs: git tips

On Mon, 2016-02-29 at 12:17 +1100, Timothy Arceri wrote: > From: Timothy Arceri > Whoops I didn't intend to send this with the series its just been sitting in my repo as I wanted to add the commands I always forget somewhere. We can still add it if others think its useful.  > --- >  docs/devinf

[Mesa-dev] [PATCH 15/26] glsl: pack fragment shader outputs with component layout qualifiers

This actually tries to pack any output with an explicit location we just let the optimisiation passes clean up the extra assignments if there was no actual packing done. V2: fix comment (Anuj) Reviewed-by: Anuj Phogat Reviewed-by: Edward O'Callaghan --- src/compiler/glsl/link_varyings.cpp | 17

[Mesa-dev] [PATCH 16/26] glsl: get geometry shader vertex count from type when packing

Rather than passing in the vertex count to the packing pass just use the outermost array size to get the count. Reviewed-by: Anuj Phogat Reviewed-by: Edward O'Callaghan --- src/compiler/glsl/ir_optimization.h | 3 +- src/compiler/glsl/link_varyings.cpp | 19 +++- src/compil

[Mesa-dev] [PATCH 10/26] glsl: add packing rules for tessellation stages to the packing code

Following patches will allow packing of varyings with explicit locations via the component layout qualifier. Adding the rules here will enable us to call an alternate path for packing tessellation stages with explicit locations. V3: Don't remove rules from the varying linking code as we need to di

[Mesa-dev] [PATCH 22/26] glsl: include per-patch varyings when generating reserved slot bitfield

--- src/compiler/glsl/link_varyings.cpp | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index bb444b2..4f1750a 100644 --- a/src/compiler/glsl/link_varyings.cpp +++ b/src/compiler/glsl/link_va

[Mesa-dev] [PATCH 08/26] glsl: pass disable_varying_packing bool to the lowering pass

This will allow us to choose to ignore the disable which will be useful for allowing support of the component layout qualifier while still disabling packing for varyings without an explicit component. Reviewed-by: Anuj Phogat Reviewed-by: Edward O'Callaghan Reviewed-by: Kenneth Graunke --- src

[Mesa-dev] [PATCH 11/26] glsl: enable lowering of varyings with explicit component

Reviewed-by: Anuj Phogat Reviewed-by: Edward O'Callaghan --- src/compiler/glsl/ir_optimization.h | 3 ++- src/compiler/glsl/link_varyings.cpp | 6 -- src/compiler/glsl/lower_packed_varyings.cpp | 31 - 3 files changed, 28 insertions(+), 12 deleti

[Mesa-dev] [PATCH 25/26] mesa: add LOCATION_COMPONENT support to GetProgramResourceiv

From Section 7.3.1.1 (Naming Active Resources) of the OpenGL 4.5 spec: "For the property LOCATION_COMPONENT, a single integer indicating the first component of the location assigned to an active input or output variable is written to params. For input and output variables with a component

[Mesa-dev] [PATCH 17/26] glsl: add pack varying to resource list for vertex input / fragment output

This is needed now that we pack these type of varyings when they have a component layout qualifier. Reviewed-by: Anuj Phogat --- src/compiler/glsl/linker.cpp | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/link

[Mesa-dev] [PATCH 21/26] glsl: don't try to eliminate unused patches with explicit locations

These outputs have a separate location domain from per-vertex outputs and need to be handled separately. For now just skip them. --- src/compiler/glsl/linker.cpp | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp inde

[Mesa-dev] [PATCH 26/26] docs: mark component layout qualifiers as DONE

--- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 8c043e9..e7863e8 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -182,7 +182,7 @@ GL 4.4, GLSL 4.40: - compile-time constant expressions DONE - explicit byt

[Mesa-dev] [PATCH 23/26] glsl: add helper for comparing arrays in varying packing pass

--- src/compiler/glsl/lower_packed_varyings.cpp | 25 + 1 file changed, 25 insertions(+) diff --git a/src/compiler/glsl/lower_packed_varyings.cpp b/src/compiler/glsl/lower_packed_varyings.cpp index 10f2c22..5b2338d 100644 --- a/src/compiler/glsl/lower_packed_varyings.cpp

[Mesa-dev] [PATCH 24/26] glsl: lower tessellation varyings packed with component layout qualifier

For tessellation shaders we cannot just copy everything to the packed varyings like we do in other stages as tessellation uses shared memory for varyings, therefore it is only safe to copy array elements that the shader actually uses. This class searches the IR for uses of varyings and then create

[Mesa-dev] [PATCH 03/26] glsl: validate and store component layout qualifier in GLSL IR

We make use of the existing IR field location_frac used for tracking component locations. Reviewed-by: Anuj Phogat Reviewed-by: Edward O'Callaghan Reviewed-by: Kenneth Graunke --- src/compiler/glsl/ast_to_hir.cpp | 38 ++ src/compiler/glsl/ir.h |

[Mesa-dev] [PATCH 12/26] glsl: validate linking of intrastage component qualifiers

Reviewed-by: Anuj Phogat Reviewed-by: Edward O'Callaghan --- src/compiler/glsl/linker.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index abf568b..1818da5 100644 --- a/src/compiler/glsl/linker.cpp +++ b/src/compiler/gls

[Mesa-dev] [PATCH 18/26] glsl: make needs_lowering() a shared packing helper function

Reviewed-by: Anuj Phogat Reviewed-by: Edward O'Callaghan --- src/compiler/glsl/lower_packed_varyings.cpp | 55 ++--- 1 file changed, 27 insertions(+), 28 deletions(-) diff --git a/src/compiler/glsl/lower_packed_varyings.cpp b/src/compiler/glsl/lower_packed_varyings.cpp

[Mesa-dev] [PATCH 13/26] glsl: add support for explicit components to frag outputs

V2: fix error checking for arrays and components. V1 was only taking into account all the array elements and all the components of one of the varyings during the comparision and treating the other as a single slot/component. Reviewed-by: Anuj Phogat --- src/compiler/glsl/linker.cpp | 72

[Mesa-dev] [PATCH 20/26] glsl: skip location and component packing validation on patch out

These outputs have a separate location domain from per-vertex outputs and need to be handled separately. For now just skip validation so we don't invalidate valid shaders. --- src/compiler/glsl/link_varyings.cpp | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/

[Mesa-dev] [PATCH 19/26] glsl: move packed varying creation code to a helper

This will also be used by tessellation packing code in a following patch. Reviewed-by: Anuj Phogat Reviewed-by: Edward O'Callaghan --- src/compiler/glsl/lower_packed_varyings.cpp | 45 +++-- 1 file changed, 30 insertions(+), 15 deletions(-) diff --git a/src/compiler/gls

[Mesa-dev] [PATCH 06/26] glsl: update explicit location matching to support component qualifier

This is needed so we don't optimise away the varying when more than one shares the same location. Reviewed-by: Anuj Phogat Reviewed-by: Edward O'Callaghan Reviewed-by: Kenneth Graunke --- src/compiler/glsl/linker.cpp | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/

[Mesa-dev] [PATCH 05/26] glsl: cross validate varyings with a component qualifier

This change checks for component overlap, including handling overlap of locations and components by doubles. Previously there was no validation for assigning explicit locations to a location used by the second half of a double. V3: simplify handling of doubles and fix double component aliasing det

[Mesa-dev] [PATCH 14/26] glsl: pack vertex attributes with component layout qualifiers

This actually tries to pack any input with an explicit location we just let the optimisiation passes clean up the extra assignments if there was no actual packing done. V2: drop unncessary formatting changes (Anuj) Reviewed-by: Anuj Phogat Reviewed-by: Edward O'Callaghan --- src/compiler/glsl/

[Mesa-dev] [PATCH 07/26] glsl: include varyings with explicit locations in slot count

This count is used by the packing pass and we need to include varying with explicit locations to be able to pack varyings with explicit components. Reviewed-by: Anuj Phogat Reviewed-by: Edward O'Callaghan Reviewed-by: Kenneth Graunke --- src/compiler/glsl/link_varyings.cpp | 9 +++-- 1 fil

[Mesa-dev] [PATCH 09/26] glsl: add support for packing varyings with explicit locations

Reviewed-by: Anuj Phogat Reviewed-by: Kenneth Graunke --- src/compiler/glsl/lower_packed_varyings.cpp | 45 - 1 file changed, 32 insertions(+), 13 deletions(-) diff --git a/src/compiler/glsl/lower_packed_varyings.cpp b/src/compiler/glsl/lower_packed_varyings.cpp ind

[Mesa-dev] [PATCH 01/26] docs: git tips

From: Timothy Arceri --- docs/devinfo.html | 18 ++ 1 file changed, 18 insertions(+) diff --git a/docs/devinfo.html b/docs/devinfo.html index 8ebf80f..ed9eb9b 100644 --- a/docs/devinfo.html +++ b/docs/devinfo.html @@ -162,6 +162,24 @@ components. perhaps, in very trivial cases.

[Mesa-dev] [PATCH 04/26] glsl: fix cross validation for explicit locations on structs and arrays

Reviewed-by: Anuj Phogat Reviewed-by: Edward O'Callaghan Reviewed-by: Kenneth Graunke --- src/compiler/glsl/link_varyings.cpp | 43 ++--- 1 file changed, 30 insertions(+), 13 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link

[Mesa-dev] [PATCH 02/26] glsl: parse component layout qualifier

Reviewed-by: Anuj Phogat Reviewed-by: Edward O'Callaghan Reviewed-by: Kenneth Graunke --- src/compiler/glsl/ast.h | 14 ++ src/compiler/glsl/ast_type.cpp | 3 +++ src/compiler/glsl/glsl_parser.yy | 11 +++ 3 files changed, 28 insertions(+) diff --git a/src/compi

[Mesa-dev] V3 ARB_enhanced_layouts component qualifier support

Most of this is just a resend. The new patches are: [PATCH 20/26] glsl: skip location and component packing validation on [PATCH 21/26] glsl: don't try to eliminate unused patches with [PATCH 22/26] glsl: include per-patch varyings when generating [PATCH 23/26] glsl: add helper for comparing arra

[Mesa-dev] [Bug 94273] OpenCL segfault during testing of clBLAS

https://bugs.freedesktop.org/show_bug.cgi?id=94273 --- Comment #7 from joshua.r.marshall.1...@gmail.com --- It's running LLVM 3.7. Getting it to work off of SVN is a pain so I've been sticking with Arch's package. -- You are receiving this mail because: You are the assignee for the bug. You are

Re: [Mesa-dev] [PATCH 3/3] gk1100/ir: add missing src predicate emission for BAR.RED

On 02/28/2016 10:50 PM, Ilia Mirkin wrote: On Sun, Feb 28, 2016 at 4:30 PM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv

Re: [Mesa-dev] [PATCH 3/3] gk1100/ir: add missing src predicate emission for BAR.RED

On Sun, Feb 28, 2016 at 4:30 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp > b/src/gallium/d

Re: [Mesa-dev] [PATCH 1/3] gk110/ir: fix wrong emission of BAR.SYNC

On Sun, Feb 28, 2016 at 4:30 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp > b/src

[Mesa-dev] [PATCH 3/3] gk1100/ir: add missing src predicate emission for BAR.RED

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp index ff56987..07e4f4d 1

[Mesa-dev] [PATCH 2/3] gk110/ir: allow to emit immediates for BAR

Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cp

[Mesa-dev] [PATCH 1/3] gk110/ir: fix wrong emission of BAR.SYNC

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp index 264b35f.

Re: [Mesa-dev] [PATCH v3] nv50/ir: emit VOTE instruction

Reviewed-by: Ilia Mirkin On Sun, Feb 28, 2016 at 2:44 PM, Samuel Pitoiset wrote: > Changes from v2: > - add missing NOT modifier for GK110/GM107 > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/codegen/nv50_ir.h | 4 +++ > .../drivers/nouveau/codegen/nv50_ir_emit_g

[Mesa-dev] [PATCH v3] nv50/ir: emit VOTE instruction

Changes from v2: - add missing NOT modifier for GK110/GM107 Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 4 +++ .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 23 + .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 29

Re: [Mesa-dev] [PATCH] gk110/ir: add ld lock/st unlock emission

Reviewed-by: Ilia Mirkin On Sun, Feb 28, 2016 at 12:22 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 30 > -- > 1 file changed, 28 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/

Re: [Mesa-dev] [PATCH v2] nv50/ir: emit VOTE instruction

On Sun, Feb 28, 2016 at 12:25 PM, Samuel Pitoiset wrote: > > > On 02/28/2016 06:24 PM, Ilia Mirkin wrote: >> >> On Sun, Feb 28, 2016 at 12:20 PM, Samuel Pitoiset >> wrote: >>> +void >>> +CodeEmitterNVC0::emitVOTE(const Instruction *i) >>> +{ >>> + assert(i->src(0).getFile() == FILE_PREDICATE &&

Re: [Mesa-dev] [PATCH v2] nv50/ir: emit VOTE instruction

On 02/28/2016 06:24 PM, Ilia Mirkin wrote: On Sun, Feb 28, 2016 at 12:20 PM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 4 .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 21 .../drivers/nouve

Re: [Mesa-dev] [PATCH v2] nv50/ir: emit VOTE instruction

On Sun, Feb 28, 2016 at 12:20 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/codegen/nv50_ir.h | 4 > .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 21 > .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 28 >

[Mesa-dev] [PATCH] gk110/ir: add ld lock/st unlock emission

Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cp

[Mesa-dev] [PATCH v2] nv50/ir: emit VOTE instruction

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 4 .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 21 .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 28 ++ .../drivers/nouveau/codegen/nv50_ir_emit_nvc0.

Re: [Mesa-dev] [PATCH] nvc0/ir: emit VOTE instruction

On 02/28/2016 06:00 PM, Ilia Mirkin wrote: Please add emitters for GK110 and GM107 as well if you want to do this. Yes, sorry this is the wrong patch... On Sun, Feb 28, 2016 at 11:50 AM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50

Re: [Mesa-dev] [PATCH] nvc0/ir: emit VOTE instruction

Please add emitters for GK110 and GM107 as well if you want to do this. On Sun, Feb 28, 2016 at 11:50 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/codegen/nv50_ir.h | 4 > .../drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 23 > ++

[Mesa-dev] [PATCH] nvc0/ir: emit VOTE instruction

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 4 .../drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 23 ++ .../drivers/nouveau/codegen/nv50_ir_print.cpp | 1 + .../drivers/nouveau/codegen/nv50_ir_target.cpp | 3 +++

[Mesa-dev] vulkan: features.pipelineStatisticsQuery is true, but vkCreateQueryPool fails for VK_QUERY_TYPE_PIPELINE_STATISTICS

Hi, Even if it is unfinished, this probably should not be that inconsistent: anv_GetPhysicalDeviceFeatures() in anv_device.c: .pipelineStatisticsQuery = true, anv_CreateQueryPool() in anv_query.c: case VK_QUERY_TYPE_PIPELINE_STATISTICS: return VK_ERROR_INCOMPATI