Only modify interpolation type for integer-based varyings or when the
consumer is known and different than fragment shader.
If we are linking separate shader programs and the consumer is unknown,
the consumer could be added later and be a fragment shader. If we
modify the interpolation type in thi
Reduces local memory usage in a lot of Metro 2033 Redux and a few KSP
shaders:
total local used in shared programs : 54116 -> 30372 (-43.88%)
Probably modest advantage to execution, but it's an imporant
prerequisite to dropping some of the TGSI optimizations done by the
state tracker.
Signed-o
On Wednesday, January 13, 2016 6:40:59 PM PST Rob Clark wrote:
> From: Rob Clark
>
> Signed-off-by: Rob Clark
> ---
> src/gallium/auxiliary/nir/tgsi_to_nir.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c
> b/src/gallium/auxiliary/nir/tgsi_to_n
On 01/14/2016 01:11 AM, Ilia Mirkin wrote:
On Wed, Jan 13, 2016 at 3:55 AM, Tapani Pälli wrote:
On 01/13/2016 10:29 AM, Lofstedt, Marta wrote:
-Original Message-
From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia
Mirkin
Sent: Tuesday, January 12, 2016 7:09 PM
T
The special case from detecting stream duplicates is also
removed, as testing never trigged this error.
From the ARB_shading_language_420pack spec:
"More than one layout qualifier may appear in a single
declaration. If the same layout-qualifier-name occurs in
multiple layout qualifiers f
This makes it a pass, hiding the parameter structs and block callbacks
so it's simpler to work with.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_nir.c | 38 -
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a/src/mesa/drivers
This patch re-implements the pre-Haswell VS attribute workarounds.
Instead of emitting shader code in the vec4 backend, we now simply
call a NIR pass to emit the necessary code.
This simplifies the vec4 backend. Beyond deleting code, it removes
the primary use of ATTR as a destination. It also e
gl_PointSize is delivered in the .w component of the VUE header, while
the language expects it to be a float (and thus in the .x component).
Previously, we emitted MOVs to copy it over to the .x component.
But this is silly - we can just use a . swizzle and access it
without copying anything o
This shouldn't hurt anything, and I'm about to introduce a pass that
will want it.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_nir.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_nir.c
b/src/mesa/drivers/dri/i96
This is no longer necessary...and it doesn't make much sense to
have inputs as destinations.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_vec4.cpp | 16
1 file changed, 16 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp
b/src/mesa/drivers/d
nir_build_ivec4 is more readable and succinct than using nir_build_imm
directly, even if you have C99.
Signed-off-by: Kenneth Graunke
---
src/glsl/nir/nir_builder.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/glsl/nir/nir_builder.h b/src/glsl/nir/nir_builder.h
index c
Shorter than compiler->scalar_stage[MESA_SHADER_VERTEX], which can
help with line-wrapping.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_vec4.cpp | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp
b/src/mesa/
On 13.01.2016 20:23, Marek Olšák wrote:
> On Wed, Jan 13, 2016 at 4:25 AM, Michel Dänzer wrote:
>> On 13.01.2016 03:44, Marek Olšák wrote:
>>> From: Marek Olšák
>>>
>>> We don't want apps to flood stderr. New LLVM + old Mesa is a perfectly
>>> valid combination (if it doesn't fail to build, of co
Previously we were treating any indirect temp array usage to mean that
everything should end up in lmem. The MemoryOpt pass would clean a lot
of that up later, but in the meanwhile we would lose a lot of
opportunity for optimization.
This helps a lot of Metro 2033 Redux and a handful of KSP shader
Both are
Reviewed-by: Connor Abbott
On Wed, Jan 13, 2016 at 2:25 PM, Matt Turner wrote:
> The OpenGL specifications for bitfieldInsert() says:
>
>The result will be undefined if or is negative, or if
>the sum of and is greater than the number of bits
>used to store the operand.
On Jan 13, 2016 4:03 PM, "Rob Clark" wrote:
>
> From: Rob Clark
>
> ---
> An idea for how to bring some sanity to the wild-west of intrinsic
> const_index[] usage. Also w/ nir_print support, which could be
> split into other patch, but makes the nir_print output a bit nicer:
>
> intrinsic stor
From: Rob Clark
---
An idea for how to bring some sanity to the wild-west of intrinsic
const_index[] usage. Also w/ nir_print support, which could be
split into other patch, but makes the nir_print output a bit nicer:
intrinsic store_output (ssa_210, ssa_66) () (0, 15) /* base=0 wrmask=xyzw *
On Wed, Jan 13, 2016 at 11:28 AM, Neil Roberts wrote:
> The internal Mesa format used for a texture might not match the one
> requested in the internalFormat when the texture was created, for
> example if the driver is internally remapping RGB textures to RGBA.
> Otherwise it can cause false posit
From: Rob Clark
Signed-off-by: Rob Clark
---
src/gallium/auxiliary/nir/tgsi_to_nir.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c
b/src/gallium/auxiliary/nir/tgsi_to_nir.c
index 46c9297..e127174 100644
--- a/src/gallium/auxiliary/nir/tgsi_to_nir.c
We check that a bunch of raster operations are disabled in
blit_copy_pixels(). We also need to check that color logicop is
disabled.
---
src/mesa/state_tracker/st_cb_drawpixels.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/state_tracker/st_cb_drawpixels.c
b/src/mesa/state_tracke
On 01/13/2016 12:55 AM, Tapani Pälli wrote:
> On 01/13/2016 10:29 AM, Lofstedt, Marta wrote:
>>
>>> -Original Message-
>>> From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia
>>> Mirkin
>>> Sent: Tuesday, January 12, 2016 7:09 PM
>>> To: Marta Lofstedt
>>> Cc: mesa-dev@li
On Wed, Jan 13, 2016 at 3:55 AM, Tapani Pälli wrote:
> On 01/13/2016 10:29 AM, Lofstedt, Marta wrote:
>>
>>
>>> -Original Message-
>>> From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia
>>> Mirkin
>>> Sent: Tuesday, January 12, 2016 7:09 PM
>>> To: Marta Lofstedt
>>> Cc
On Wed, Jan 13, 2016 at 2:14 PM, Matt Turner wrote:
> On Wed, Jan 13, 2016 at 1:46 PM, Jason Ekstrand
> wrote:
> > On Wed, Jan 13, 2016 at 2:01 AM, Ian Romanick
> wrote:
> >> On 01/12/2016 05:41 PM, Matt Turner wrote:
> >> > Section 8.3.2 of the OpenCL C 2.0 spec is also relevant, but doesn't
>
On Wed, Jan 13, 2016 at 1:46 PM, Jason Ekstrand wrote:
> On Wed, Jan 13, 2016 at 2:01 AM, Ian Romanick wrote:
>> On 01/12/2016 05:41 PM, Matt Turner wrote:
>> > Section 8.3.2 of the OpenCL C 2.0 spec is also relevant, but doesn't
>> > touch directly on the issue at hand.
>> >
>> > I'm worried tha
On Wed, 2016-01-13 at 12:02 -0800, Anuj Phogat wrote:
> Timothy, Do you have a branch somewhere with the latest patches?
https://github.com/tarceri/Mesa_arrays_of_arrays.git explicit_offset
Contains the latest for component, offset, and align qualifiers all of
which have now been sent to the list
On Wed, Jan 13, 2016 at 2:01 AM, Ian Romanick wrote:
> On 01/12/2016 05:41 PM, Matt Turner wrote:
> > On Tue, Jan 12, 2016 at 4:10 PM, Jason Ekstrand
> wrote:
> >> On Tue, Jan 12, 2016 at 3:52 PM, Matt Turner
> wrote:
> >>>
> >>> On Tue, Jan 12, 2016 at 3:35 PM, Jason Ekstrand
> >>> wrote:
> >
On 11/01/16 14:21, Jose Fonseca wrote:
FWIW, I updated SCons to build NIR, both with GCC and MSVC:
http://cgit.freedesktop.org/~jrfonseca/mesa/log/?h=scons-nir
It was actually simpler than I anticipated.
But I hit a wall -- there's actually no way to get NIR used with
softpipe/llvmpipe, not
https://bugs.freedesktop.org/show_bug.cgi?id=92850
--- Comment #57 from Ernst Sjöstrand ---
With current git I get a crash like this:
0x726ff349 in glsl_to_tgsi_visitor::visit (this=0x7fffa2725600,
ir=0x7fffa271baf8) at state_tracker/st_glsl_to_tgsi.cpp:3161
3161 const glsl_type *s
Timothy, Do you have a branch somewhere with the latest patches?
On Wed, Jan 13, 2016 at 10:58 AM, Anuj Phogat wrote:
> On Wed, Jan 13, 2016 at 1:19 AM, Timothy Arceri
> wrote:
>> V2: fix error checking for arrays and components. V1 was
>> only taking into account all the array elements and all
glxgears still works for me, and libGL goes from 4.2M to 3.3M.
Reviewed-by: Matt Turner
We should also include some mention of Arlie's contribution, since he
identified this and sent the initial patch:
Reported-by: Arlie Davis
___
mesa-dev mailing li
The internal Mesa format used for a texture might not match the one
requested in the internalFormat when the texture was created, for
example if the driver is internally remapping RGB textures to RGBA.
Otherwise it can cause false positives for completeness if one mipmap
image is created as RGBA an
The OpenGL specifications for bitfieldExtract() says:
The result will be undefined if or is negative, or if
the sum of and is greater than the number of bits
used to store the operand.
Therefore passing bits=32, offset=0 is legal and defined in GLSL.
But the earlier SM5 ubfe/ibfe op
The OpenGL specifications for bitfieldInsert() says:
The result will be undefined if or is negative, or if
the sum of and is greater than the number of bits
used to store the operand.
Therefore passing bits=32, offset=0 is legal and defined in GLSL.
But the earlier SM5 bfi opcode is
From: Rob Clark
Only user is freedreno, and after array-rework it can cope. Avoids
generating loads for a store.
Signed-off-by: Rob Clark
---
Note: I need to finish some array re-work in ir3 in order to be able
to deal w/ the writemasks, so I intend to push this as part of that
series once I'v
On Wed, Jan 13, 2016 at 1:19 AM, Timothy Arceri
wrote:
> V2: fix error checking for arrays and components. V1 was
> only taking into account all the array elements and all the
> components of one of the varyings during the comparision
> and treating the other as a single slot/component.
>
> Cc: An
Good catch.
Reviewed-by: Nicolai Hähnle
On 13.01.2016 13:32, Marek Olšák wrote:
From: Marek Olšák
I'm not sure about the consequences of this bug, but it's definitely
dangerous.
This applies to SI, CIK, VI.
Cc: 11.0 11.1
---
src/gallium/drivers/radeonsi/si_state_shaders.c | 9 +++--
From: Marek Olšák
I'm not sure about the consequences of this bug, but it's definitely
dangerous.
This applies to SI, CIK, VI.
Cc: 11.0 11.1
---
src/gallium/drivers/radeonsi/si_state_shaders.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/rad
On 13.01.2016 05:41, Fredrik Höglund wrote:
On Tuesday 12 January 2016, Nicolai Hähnle wrote:
On 12.01.2016 13:41, Fredrik Höglund wrote:
On Tuesday 12 January 2016, Nicolai Hähnle wrote:
From: Nicolai Hähnle
---
src/gallium/drivers/r600/r600_pipe.c| 2 +-
src/gallium/drive
On Wed, Jan 13, 2016 at 12:54 PM, Rob Herring wrote:
> On Tue, Jan 12, 2016 at 8:06 PM, Chih-Wei Huang
> wrote:
>> 2016-01-13 6:29 GMT+08:00 Rob Herring :
>>> On Tue, Jan 12, 2016 at 7:05 AM, Chih-Wei Huang
>>> wrote:
2016-01-12 19:55 GMT+08:00 陈渝 :
> hi, Rob, Dave, Zhiwei:
> Tha
Looks like both symbols are defined in
src/mapi/shared-glapi/glapi_mapi_tmp.h which is generated at compile
time by the src/mapi/mapi_abi.py script.
-Brian
On 01/13/2016 08:40 AM, Jouk Jansen wrote:
Hi all,
I'm trying to create a fresh compilation for my OpenVMS system using the
sources I
On Wed, Jan 13, 2016 at 4:35 PM, Axel Davy wrote:
>
>>
>> Axel Davy benchmarked this briefly. We may need more benchmarks though.
>>
>> Marek
>>
>
> I confirm setting this register helps get a few % with heaven.
>
> There was also another register to kill color exports early when doing
> depth onl
Hi all,
I'm trying to create a fresh compilation for my OpenVMS system using the
sources I extracted using git today.
At some point the compilation fails because MAPI_TABLE_NUM_STATIC and
MAPI_TABLE_NUM_DYNAMIC are not defined. In a version compiled sometime ago I
found the definitions in the file
Hi Jason
Am 13/01/2016 um 00:35 schrieb Jason Ekstrand:
> ---
> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 13 +
> src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 10 ++
> 2 files changed, 23 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> b/src/mesa
Patches 3-8:
Reviewed-by: Marek Olšák
Marek
On Tue, Jan 12, 2016 at 5:06 PM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> The whole point of AMD_pinned_memory is that applications don't have to map
> buffers via OpenGL - but they're still allowed to, so make sure we don't break
> the link
From: Sumit Semwal
Android needs libdrm built statically for recovery;
enable that as well.
Signed-off-by: Sumit Semwal
Signed-off-by: Rob Herring
Cc: Chih-Wei Huang
Cc: Emil Velikov
---
Android.mk | 19 +++
1 file changed, 19 insertions(+)
diff --git a/Android.mk b/Android
https://bugs.freedesktop.org/show_bug.cgi?id=93686
--- Comment #2 from Roland Scheidegger ---
I'm not sure if this exact same proposal really came up already. We have seen
some though asking if we couldn't combine llvmpipe with less capable gpus to
make a driver offering more features, that is ex
Am 13.01.2016 um 05:41 schrieb Evangelos Foutras:
> ---
> src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
> b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
> index 3ee708f..b1
>
> Axel Davy benchmarked this briefly. We may need more benchmarks though.
>
> Marek
>
I confirm setting this register helps get a few % with heaven.
There was also another register to kill color exports early when doing
depth only pass that helped a few % (but less).
Axel
___
On Wed, Jan 13, 2016 at 11:41 AM, Fredrik Höglund wrote:
> On Tuesday 12 January 2016, Nicolai Hähnle wrote:
>> On 12.01.2016 13:41, Fredrik Höglund wrote:
>> > On Tuesday 12 January 2016, Nicolai Hähnle wrote:
>> >> From: Nicolai Hähnle
>> >>
>> >> ---
>> >> src/gallium/drivers/r600/r600_pipe.
Mesa 11.1.1 is now available.
With this release we have a significant amount of fixes - from radeonsi
(Fiji, Hyper-Z), r600 (geom. shaders), nouveau (ir), freedreno (piglits),
i965 (UBOs) and a few patches for "GRID Autosport" (i965 and glsl).
Additionally I've included the PCI IDs for Intel's Kab
Bump. Anyone fancy reviewing this small patch? I think it would be good
to have because it makes the code a bit simpler as well as fixing a
corner case and making it more robust.
- Neil
Neil Roberts writes:
> When programming the fast clear color there was previously a chunk of
> code to try to
Removes the public symbol _glapi_create_table_from_handle from
libGL.so.1 on all platforms except Darwin.
Since the symbol is not used on other platforms it makes sense to
build glapi_gentable.c only on Darwin.
A little bit of history:
_glapi_create_table_from_handle was introduced in
commit 85
https://bugs.freedesktop.org/show_bug.cgi?id=92687
--- Comment #3 from Eduardo Lima Mitev ---
(In reply to Eduardo Lima Mitev from comment #2)
>
> Following, there are some initial issues/questions we have been gathering:
>
Independently of feedback to the branch we posted, it would be very us
On Wed, Jan 13, 2016 at 4:25 AM, Michel Dänzer wrote:
> On 13.01.2016 03:44, Marek Olšák wrote:
>> From: Marek Olšák
>>
>> We don't want apps to flood stderr. New LLVM + old Mesa is a perfectly
>> valid combination (if it doesn't fail to build, of course).
>
> Actually it's not, in general.
Why
ping
2015-12-10 16:32 GMT+01:00 Andreas Boll :
> Fixes a regression introduced in
> 406248811eb0dfabf75ae9495b54529ec59cce66
>
> It wrongly sets glut_enabled=yes if glut isn't available and neither
> option --with-glut nor --without-glut was given.
>
> The default behavior in that case should be i
On Tuesday 12 January 2016, Nicolai Hähnle wrote:
> On 12.01.2016 13:41, Fredrik Höglund wrote:
> > On Tuesday 12 January 2016, Nicolai Hähnle wrote:
> >> From: Nicolai Hähnle
> >>
> >> ---
> >> src/gallium/drivers/r600/r600_pipe.c| 2 +-
> >> src/gallium/drivers/radeon/r600_buffer
On 01/12/2016 05:41 PM, Matt Turner wrote:
> On Tue, Jan 12, 2016 at 4:10 PM, Jason Ekstrand wrote:
>> On Tue, Jan 12, 2016 at 3:52 PM, Matt Turner wrote:
>>>
>>> On Tue, Jan 12, 2016 at 3:35 PM, Jason Ekstrand
>>> wrote:
This opcode simply takes a 32-bit floating-point value and reduces it
V2: fix error checking for arrays and components. V1 was
only taking into account all the array elements and all the
components of one of the varyings during the comparision
and treating the other as a single slot/component.
Cc: Anuj Phogat
---
src/glsl/linker.cpp | 72 ++
On Tue, 2016-01-12 at 16:36 -0800, Anuj Phogat wrote:
> On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri
> wrote:
> > ---
> > src/glsl/linker.cpp | 56
> > -
> > 1 file changed, 55 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/glsl/linke
On 01/13/2016 10:29 AM, Lofstedt, Marta wrote:
-Original Message-
From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia
Mirkin
Sent: Tuesday, January 12, 2016 7:09 PM
To: Marta Lofstedt
Cc: mesa-dev@lists.freedesktop.org; Romanick, Ian D; Lofstedt, Marta
Subject: Re: [P
> -Original Message-
> From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia
> Mirkin
> Sent: Tuesday, January 12, 2016 7:09 PM
> To: Marta Lofstedt
> Cc: mesa-dev@lists.freedesktop.org; Romanick, Ian D; Lofstedt, Marta
> Subject: Re: [PATCH V3] glapi: add GL_OES_geometry
61 matches
Mail list logo