Re: [Mesa-dev] [PATCH v2 1/4] mesa: merge bind_xfb_buffers_{base|range}

On 01/08/2016 04:45 PM, Nicolai Hähnle wrote: > I've actually been wondering what the deal is with all those different > boolean types. From what you've written, I'd infer that the intent is > roughly like: > > 1) GLboolean/GL_TRUE/GL_FALSE for values where the API wants it. > 2) bool/true/false e

[Mesa-dev] [PATCH 00/18] Stop using client APIs for sampler objects

From: Ian Romanick This is the second of several series to stop using client APIs in meta. The first series removed the use of buffer object client APIs, and it landed last year. Most of the work was done last year, but I didn't start send patches until I had test cases. The tests are out on th

[Mesa-dev] [PATCH 16/18] meta/decompress: Don't pollute the sampler object namespace

From: Ian Romanick tl;dr: For many types of GL object, we can *NEVER* use the Gen function. In OpenGL ES (all versions!) and OpenGL compatibility profile, applications don't have to call Gen functions. The GL spec is very clear about how you can mix-and-match generated names and non-generated n

[Mesa-dev] [PATCH 14/18] meta/decompress: Track sampler using gl_sampler_object instead of GL API object handle

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 22 +++--- src/mesa/drivers/common/meta.h | 2 +- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 66a7132..

[Mesa-dev] [PATCH 09/18] meta/generate_mipmap: Use internal functions for sampler object access

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta_generate_mipmap.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/common/meta_generate_mipmap.c b/src/mesa/drivers/common/meta_generate_mipmap.c index 2b94

[Mesa-dev] [PATCH 18/18] meta: Unconditionally set GL_SKIP_DECODE_EXT

From: Ian Romanick The path that depends on this will be avoided (by fallback_required) if the extension is not supported. _mesa_set_sampler_srgb_decode does not generate GL errors (by design), so there are no problems there. I kept this change separate and last because it is one of the few in

[Mesa-dev] [PATCH 10/18] meta/generate_mipmap: Track sampler using gl_sampler_object instead of GL API object handle

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.h | 2 +- src/mesa/drivers/common/meta_generate_mipmap.c | 29 ++ 2 files changed, 17 insertions(+), 14 deletions(-) diff --git a/src/mesa/drivers/common/meta.h b/src/mesa/d

[Mesa-dev] [PATCH 05/18] meta/blit: Group the SamplerParameteri calls with the other sampler operations

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta_blit.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/common/meta_blit.c b/src/mesa/drivers/common/meta_blit.c index 4dbf0a7..4212150 100644 --- a/src/mesa/drivers/comm

[Mesa-dev] [PATCH 11/18] meta/generate_mipmap: Save and restore the sampler using gl_sampler_object instead of GL API object handle

From: Ian Romanick Some meta operations can be called recursively. Future changes (the "Don't pollute the ... namespace" changes) will cause objects with invalid names to be used. If a nested meta operation tries to restore an object named 0xDEADBEEF, it will fail. Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 12/18] meta/generate_mipmap: Don't pollute the sampler object namespace

From: Ian Romanick tl;dr: For many types of GL object, we can *NEVER* use the Gen function. In OpenGL ES (all versions!) and OpenGL compatibility profile, applications don't have to call Gen functions. The GL spec is very clear about how you can mix-and-match generated names and non-generated n

[Mesa-dev] [PATCH 17/18] meta: Only bind the sampler in one place

From: Ian Romanick All of the calls after the first _mesa_bind_sampler call are DSA style calls that don't depend on the current binding. I kept this change separate and last because it is one of the few in the series that is not a candidate for the stable branch. Signed-off-by: Ian Romanick -

[Mesa-dev] [PATCH 06/18] meta/blit: Use internal functions for sampler object access

From: Ian Romanick This requires tracking the sampler object using the gl_sampler_object* instead of the object name. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.h| 5 ++-- src/mesa/drivers/common/meta_blit.c | 35 +-- src

[Mesa-dev] [PATCH 07/18] meta/blit: Save and restore the sampler using gl_sampler_object instead of GL API object handle

From: Ian Romanick Some meta operations can be called recursively. Future changes (the "Don't pollute the ... namespace" changes) will cause objects with invalid names to be used. If a nested meta operation tries to restore an object named 0xDEADBEEF, it will fail. Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 13/18] meta/decompress: Use internal functions for sampler object access

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 36bed77..66a7132 100644 --- a/src/mesa/drivers/common/meta.c

[Mesa-dev] [PATCH 15/18] meta/decompress: Save and restore the sampler using gl_sampler_object instead of GL API object handle

From: Ian Romanick Some meta operations can be called recursively. Future changes (the "Don't pollute the ... namespace" changes) will cause objects with invalid names to be used. If a nested meta operation tries to restore an object named 0xDEADBEEF, it will fail. Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 08/18] meta/blit: Don't pollute the sampler object namespace in _mesa_meta_setup_sampler

From: Ian Romanick tl;dr: For many types of GL object, we can *NEVER* use the Gen function. In OpenGL ES (all versions!) and OpenGL compatibility profile, applications don't have to call Gen functions. The GL spec is very clear about how you can mix-and-match generated names and non-generated n

[Mesa-dev] [PATCH 02/18] mesa: Add _mesa_set_sampler_filters method

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/samplerobj.c | 12 src/mesa/main/samplerobj.h | 5 + 2 files changed, 17 insertions(+) diff --git a/src/mesa/main/samplerobj.c b/src/mesa/main/samplerobj.c index 17b3400..3f48ab9f 100644 --- a/src/mesa/main/samp

[Mesa-dev] [PATCH 03/18] mesa: Add _mesa_set_sampler_srgb_decode method

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/samplerobj.c | 10 ++ src/mesa/main/samplerobj.h | 4 2 files changed, 14 insertions(+) diff --git a/src/mesa/main/samplerobj.c b/src/mesa/main/samplerobj.c index 3f48ab9f..1c744b1 100644 --- a/src/mesa/main/sampler

[Mesa-dev] [PATCH 04/18] mesa: Refator _mesa_BindSampler to make _mesa_bind_sampler

From: Ian Romanick Pulls the parts of _mesa_BindSampler that aren't just parameter validation out into a function that can be called from other parts of Mesa (e.g., meta). Signed-off-by: Ian Romanick --- src/mesa/main/samplerobj.c | 18 -- src/mesa/main/samplerobj.h | 4

[Mesa-dev] [PATCH 01/18] mesa: Add _mesa_set_sampler_wrap method

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/samplerobj.c | 16 src/mesa/main/samplerobj.h | 4 2 files changed, 20 insertions(+) diff --git a/src/mesa/main/samplerobj.c b/src/mesa/main/samplerobj.c index 676dd36..17b3400 100644 --- a/src/mesa/main/sa

Re: [Mesa-dev] [PATCH] Add missing platform information for KBL

Sarah Sharp writes: > On Fri, Jan 08, 2016 at 04:30:20PM -0800, Mark Janes wrote: >> In testing KBL, I found: >> >> - urb size was not set for slices gt1.5, gt2, and gt3. The value I >>used for these slices (384) was taken from an earlier patch authored >>by Ben Widawsky. >> >> - sli

Re: [Mesa-dev] [PATCH 0/7] vbo: introduce a minmax_index cache

On 08.01.2016 18:11, Ian Romanick wrote: On 01/07/2016 04:57 PM, Nicolai Hähnle wrote: Hi, this series is intended to address a (big) part of the performance problems that occur when games use an index buffer from a VBO together with vertex attributes supplied by user pointer. On a lower-end Ra

Re: [Mesa-dev] [PATCH 4/7] mesa/main: add USAGE_PERSISTENT_WRITE_MAP flag to buffer UsageHistory

On 08.01.2016 18:09, Ian Romanick wrote: On 01/07/2016 04:57 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle We will want to disable minmax index caching for buffers that are used in this way. I think this is too heavy handed. It seems like what you want is to disable caching of draws in the

Re: [Mesa-dev] [PATCH v2 1/4] mesa: merge bind_xfb_buffers_{base|range}

On 08.01.2016 18:27, Ian Romanick wrote: On 01/08/2016 08:44 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle Reduced code duplication should make the code more maintainable. --- src/mesa/main/bufferobj.c | 172 -- 1 file changed, 59 insertions(+),

[Mesa-dev] [PATCH] Add missing platform information for KBL

In testing KBL, I found: - urb size was not set for slices gt1.5, gt2, and gt3. The value I used for these slices (384) was taken from an earlier patch authored by Ben Widawsky. - slice count was missing. This field was added by a403ad4f5a034e52a3cd845e91c4aa3e6927b731 With this com

Re: [Mesa-dev] [PATCH] glsl: Don't add nir files to libglsl_la_SOURCES

On Fri, Jan 8, 2016 at 4:12 PM, Brian Paul wrote: > Yes, this fixes things. Thanks, Kristian! > > Tested-by: Brian Paul Thanks for testing - I've pushed the fix. Kristian > > On 01/08/2016 05:07 PM, Kristian Høgsberg wrote: >> >> From: Kristian Høgsberg Kristensen >> >> SCons doesn't underst

Re: [Mesa-dev] [PATCH] glsl: Don't add nir files to libglsl_la_SOURCES

Yes, this fixes things. Thanks, Kristian! Tested-by: Brian Paul On 01/08/2016 05:07 PM, Kristian Høgsberg wrote: From: Kristian Høgsberg Kristensen SCons doesn't understand nir yet and doesn't want to compile the glsl to nir pass. Move the files to their own variable so we can add it only f

[Mesa-dev] [PATCH] glsl: Don't add nir files to libglsl_la_SOURCES

From: Kristian Høgsberg Kristensen SCons doesn't understand nir yet and doesn't want to compile the glsl to nir pass. Move the files to their own variable so we can add it only for automake. --- Ok, this one adds shader_enums.c to the SCons build, should fix the issue Brian saw. Kristian src/

Re: [Mesa-dev] [PATCH 3/3] llvmpipe: add sse code for fixed position calculation

Am 08.01.2016 um 23:28 schrieb Jose Fonseca: > On 08/01/16 20:04, Roland Scheidegger wrote: >> Am 08.01.2016 um 20:33 schrieb Roland Scheidegger: >>> Am 07.01.2016 um 19:56 schrieb Roland Scheidegger: Am 07.01.2016 um 16:40 schrieb Jose Fonseca: > On 07/01/16 06:18, Roland Scheidegger wrot

Re: [Mesa-dev] [PATCH] glsl: Don't add nir files to libglsl_la_SOURCES

Still doesn't work for me: scons: done reading SConscript files. scons: Building targets ... Compiling src/mesa/main/shaderapi.c ... Linking build/linux-x86_64-debug/gallium/targets/libgl-xlib/libGL.so.1.5 ... build/linux-x86_64-debug/mesa/libmesa.a(shaderapi.os): In function `compile_shad

Re: [Mesa-dev] [PATCH] glsl: Don't add nir files to libglsl_la_SOURCES

Looks great. Thanks. Reviewed-by: Jose Fonseca We really need to get NIR into SCons. There's no reason not to. It takes time, but when consider the time we all spend with build issues, it's probably not that much. Jose On 08/01/16 23:44, Kristian Høgsberg wrote: From: Kristian Høgsberg

Re: [Mesa-dev] Mesa (master): glsl: Move _mesa_shader_stage_to_string/ abbrev to shader_enums.c

Scons deosn't build nir, so adding nir files to glsl is not an option. We either need to revert e97caba1f6c2bd803f9c8b969b52c21f93daf1d0, or move the nir+glsl files in a different variable ,e.g.,: diff --git a/src/glsl/Makefile.am b/src/glsl/Makefile.am index 33a34e4..cdb9e72 100644 --- a/src/

[Mesa-dev] [PATCH] glsl: Don't add nir files to libglsl_la_SOURCES

From: Kristian Høgsberg Kristensen SCons doesn't understand nir yet and doesn't want to compile the glsl to nir pass. Move the files to their own variable so we can add it only for automake. --- I'm currently build testing this just to be sure, but this should fix the SCons build breakage in my

Re: [Mesa-dev] Fwd: Build failed: mesa 231

On 08/01/16 23:27, Ilia Mirkin wrote: c:\projects\mesa\src\glsl\nir\nir.h(41) : fatal error C1083: Cannot open include file: 'nir_opcodes.h': No such file or directory It seems unlikely to be my bad, given that my commit didn't touch anything outside of nouveau... or does that just list the late

Re: [Mesa-dev] Mesa (master): glsl: Move _mesa_shader_stage_to_string/ abbrev to shader_enums.c

Hi Kristian, This change seems to have broken the scons build. I'm looking at it, but I don't know what's wrong yet. You can try it yourself with "scons dri=no libgl-xlib build=debug" -Brian On 01/08/2016 03:31 PM, Kristian Høgsberg wrote: Module: Mesa Branch: master Commit: 82ad571abf2fa2d

Re: [Mesa-dev] [PATCH 1/8] glsl: optionally declare gl_FragCoord & gl_FrontFacing as system values

On Fri, Jan 8, 2016 at 11:20 PM, Ian Romanick wrote: > On 01/07/2016 05:29 PM, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/glsl/ast_to_hir.cpp| 2 +- >> src/glsl/builtin_variables.cpp | 12 ++-- >> src/glsl/nir/shader_enums.h|

Re: [Mesa-dev] [PATCH v2 1/4] mesa: merge bind_xfb_buffers_{base|range}

On 01/08/2016 08:44 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Reduced code duplication should make the code more maintainable. > --- > src/mesa/main/bufferobj.c | 172 > -- > 1 file changed, 59 insertions(+), 113 deletions(-) > > diff --gi

Re: [Mesa-dev] Fwd: Build failed: mesa 231

c:\projects\mesa\src\glsl\nir\nir.h(41) : fatal error C1083: Cannot open include file: 'nir_opcodes.h': No such file or directory It seems unlikely to be my bad, given that my commit didn't touch anything outside of nouveau... or does that just list the latest commit when it actually built a bunch

Re: [Mesa-dev] [PATCH] mesa: add always-false-for-now enables for GL 4.3, 4.4, 4.5.

On Fri, Jan 8, 2016 at 6:19 PM, Ian Romanick wrote: > On 01/08/2016 12:50 PM, Ilia Mirkin wrote: >> As the relevant extensions get implemented, the lines should be >> uncommented. I believe this is (almost) everything needed for those GL >> versions though. > > It looks like this matches the list

[Mesa-dev] Fwd: Build failed: mesa 231

Forwarded Message Subject:Build failed: mesa 231 Date: Fri, 08 Jan 2016 22:56:40 + From: AppVeyor To: jrfons...@freedesktop.org Build mesa 231 failed Commit e3706a7118 by Ilia Mirkin

Re: [Mesa-dev] [PATCH] mesa: add always-false-for-now enables for GL 4.3, 4.4, 4.5.

On 01/08/2016 12:50 PM, Ilia Mirkin wrote: > As the relevant extensions get implemented, the lines should be > uncommented. I believe this is (almost) everything needed for those GL > versions though. It looks like this matches the list in GL3.txt for 4.3 and 4.4 anyway. There appear to be some mi

Re: [Mesa-dev] [PATCH 0/8] gl_FragCoord and gl_FrontFacing as system values

On Fri, Jan 8, 2016 at 6:13 PM, Rob Clark wrote: > On Fri, Jan 8, 2016 at 5:59 PM, Ian Romanick wrote: >> On 01/08/2016 07:39 AM, Brian Paul wrote: >>> On 01/07/2016 06:29 PM, Marek Olšák wrote: Hi, This series adds the possibility for drivers to get gl_FragCoord and gl_FrontF

Re: [Mesa-dev] [PATCH 0/8] gl_FragCoord and gl_FrontFacing as system values

On Fri, Jan 8, 2016 at 5:59 PM, Ian Romanick wrote: > On 01/08/2016 07:39 AM, Brian Paul wrote: >> On 01/07/2016 06:29 PM, Marek Olšák wrote: >>> Hi, >>> >>> This series adds the possibility for drivers to get gl_FragCoord and >>> gl_FrontFacing as system values. When FACE is a system value, it al

Re: [Mesa-dev] [PATCH 0/7] vbo: introduce a minmax_index cache

On 01/07/2016 04:57 PM, Nicolai Hähnle wrote: > Hi, > > this series is intended to address a (big) part of the performance problems > that occur when games use an index buffer from a VBO together with vertex > attributes supplied by user pointer. On a lower-end Radeon (Carrizo), it This is one of

Re: [Mesa-dev] [PATCH 4/7] mesa/main: add USAGE_PERSISTENT_WRITE_MAP flag to buffer UsageHistory

On 01/07/2016 04:57 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > We will want to disable minmax index caching for buffers that are used in this > way. I think this is too heavy handed. It seems like what you want is to disable caching of draws in the mapped range while it is mapped. If

Re: [Mesa-dev] [PATCH 0/8] gl_FragCoord and gl_FrontFacing as system values

On 01/08/2016 07:39 AM, Brian Paul wrote: > On 01/07/2016 06:29 PM, Marek Olšák wrote: >> Hi, >> >> This series adds the possibility for drivers to get gl_FragCoord and >> gl_FrontFacing as system values. When FACE is a system value, it also >> changes its type to integer from floating-point. >> >>

Re: [Mesa-dev] [PATCH 7/7] vbo: cache/memoize the result of vbo_get_minmax_indices

On 01/07/2016 04:57 PM, Nicolai Hähnle wrote: > diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h > index 4d625da..d4c41a7 100644 > --- a/src/mesa/main/mtypes.h > +++ b/src/mesa/main/mtypes.h > @@ -1283,6 +1283,10 @@ struct gl_buffer_object > GLuint NumMapBufferWriteCalls; > >

Re: [Mesa-dev] [PATCH 3/3] llvmpipe: add sse code for fixed position calculation

On 08/01/16 20:04, Roland Scheidegger wrote: Am 08.01.2016 um 20:33 schrieb Roland Scheidegger: Am 07.01.2016 um 19:56 schrieb Roland Scheidegger: Am 07.01.2016 um 16:40 schrieb Jose Fonseca: On 07/01/16 06:18, Roland Scheidegger wrote: Am 04.01.2016 um 20:38 schrieb Jose Fonseca: On 02/01/1

Re: [Mesa-dev] [PATCH 2/8] program: add a helper for rewriting FP position input to sysval

On 01/07/2016 05:29 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/program/programopt.c | 27 +++ > src/mesa/program/programopt.h | 2 ++ > 2 files changed, 29 insertions(+) > > diff --git a/src/mesa/program/programopt.c b/src/mesa/program/programopt.c >

Re: [Mesa-dev] [PATCH 1/8] glsl: optionally declare gl_FragCoord & gl_FrontFacing as system values

On 01/07/2016 05:29 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/glsl/ast_to_hir.cpp| 2 +- > src/glsl/builtin_variables.cpp | 12 ++-- > src/glsl/nir/shader_enums.h| 3 ++- > src/mesa/main/mtypes.h | 4 ++

Re: [Mesa-dev] [PATCH v2 7/7] vbo: cache/memoize the result of vbo_get_minmax_indices

Reviewed-by: Chris Forbes On 8 Jan 2016 9:03 AM, "Nicolai Hähnle" wrote: > From: Nicolai Hähnle > > Some games developers are unaware that an index buffer in a VBO still needs > to be read by the CPU if some varying data comes from a user pointer > (unless > glDrawRangeElements and friends are

[Mesa-dev] [PATCH] mesa: add always-false-for-now enables for GL 4.3, 4.4, 4.5.

As the relevant extensions get implemented, the lines should be uncommented. I believe this is (almost) everything needed for those GL versions though. Signed-off-by: Ilia Mirkin --- src/mesa/main/version.c | 51 +++-- 1 file changed, 49 insertions(+),

Re: [Mesa-dev] [PATCH v2 3/3] glsl: Move _mesa_shader_stage_to_string/abbrev to shader_enums.c

On Fri, Jan 8, 2016 at 3:38 PM, Kristian Høgsberg wrote: > From: Kristian Høgsberg Kristensen > > These are used by code that doens't necessarily link to libglsl.la. Move > them to shader_enums.[ch] where we keep similar helpers. > --- Please remove the four inclusions of glsl/glsl_parser_extras

Re: [Mesa-dev] [PATCH v2 2/3] i965: Move GLSL lowering passes out of libi965_compiler.la

On Fri, Jan 8, 2016 at 3:38 PM, Kristian Høgsberg wrote: > From: Kristian Høgsberg Kristensen > > The scope of libi965_compiler.la is to be able to take nir shaders and > generate i965 EU code. As such, we don't want the GLSL IR lowering > passes in the library. With this change, libi965_compile

Re: [Mesa-dev] [PATCH v2 1/3] glsl: Move glsl_to_nir files to LIBGLSL_FILES

On Fri, Jan 8, 2016 at 3:38 PM, Kristian Høgsberg wrote: > From: Kristian Høgsberg Kristensen > > libglsl_la_SOURCES includes both NIR_FILES and LIBGLSL_FILES, so for > libglsl.la consumers, this is a no-op. libnir.la however no longer uses > any GLSL IR infrastructre and can be used without also

[Mesa-dev] [PATCH v2 2/3] i965: Move GLSL lowering passes out of libi965_compiler.la

From: Kristian Høgsberg Kristensen The scope of libi965_compiler.la is to be able to take nir shaders and generate i965 EU code. As such, we don't want the GLSL IR lowering passes in the library. With this change, libi965_compiler.la no longer needs to link to libglsl.la. --- src/mesa/drivers/d

[Mesa-dev] [PATCH v2 3/3] glsl: Move _mesa_shader_stage_to_string/abbrev to shader_enums.c

From: Kristian Høgsberg Kristensen These are used by code that doens't necessarily link to libglsl.la. Move them to shader_enums.[ch] where we keep similar helpers. --- src/glsl/glsl_parser_extras.cpp | 38 -- src/glsl/glsl_parser_extras.h | 10 -- s

[Mesa-dev] [PATCH v2 1/3] glsl: Move glsl_to_nir files to LIBGLSL_FILES

From: Kristian Høgsberg Kristensen libglsl_la_SOURCES includes both NIR_FILES and LIBGLSL_FILES, so for libglsl.la consumers, this is a no-op. libnir.la however no longer uses any GLSL IR infrastructre and can be used without also linking to libglsl.la. --- src/glsl/Makefile.sources | 4 ++-- 1

Re: [Mesa-dev] [PATCH 3/3] glsl: Move _mesa_shader_stage_to_string/abbrev to shader_enums.c

Matt Turner writes: > On Fri, Jan 8, 2016 at 2:36 PM, Kristian Høgsberg wrote: >> From: Kristian Høgsberg Kristensen >> >> These are used by code that doens't necessarily link to libglsl.la. Move > > typo: doesn't > >> them to shader_enums.[ch] where we keep similar helpers. >> --- > > Does thi

Re: [Mesa-dev] [PATCH 3/3] glsl: Move _mesa_shader_stage_to_string/abbrev to shader_enums.c

On Fri, Jan 8, 2016 at 2:36 PM, Kristian Høgsberg wrote: > From: Kristian Høgsberg Kristensen > > These are used by code that doens't necessarily link to libglsl.la. Move typo: doesn't > them to shader_enums.[ch] where we keep similar helpers. > --- Does this work for you? I get CXXLDgl

Re: [Mesa-dev] [PATCH 1/3] glsl: Move glsl_to_nir files to LIBGLSL_FILES

On Fri, Jan 8, 2016 at 2:36 PM, Kristian Høgsberg wrote: > From: Kristian Høgsberg Kristensen Bad email. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/3] llvmpipe: add sse code for fixed position calculation

Am 08.01.2016 um 20:33 schrieb Roland Scheidegger: > Am 07.01.2016 um 19:56 schrieb Roland Scheidegger: >> Am 07.01.2016 um 16:40 schrieb Jose Fonseca: >>> On 07/01/16 06:18, Roland Scheidegger wrote: Am 04.01.2016 um 20:38 schrieb Jose Fonseca: > On 02/01/16 20:39, srol...@vmware.com wrot

Re: [Mesa-dev] [PATCH] glsl: Make bitfield_insert/extract and bfi/bfm non-vectorizable.

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] glsl: Make bitfield_insert/extract and bfi/bfm non-vectorizable.

Currently, opt_vectorize() tries to combine: result.x = bitfieldInsert(src0.x, src1.x, src2.x, src3.x); result.y = bitfieldInsert(src0.y, src1.y, src2.y, src3.y); result.z = bitfieldInsert(src0.z, src1.z, src2.z, src3.z); result.w = bitfieldInsert(src0.w, src1.w, src2.w, src3.w);

[Mesa-dev] [PATCH 1/3] glsl: Move glsl_to_nir files to LIBGLSL_FILES

From: Kristian Høgsberg Kristensen libglsl_la_SOURCES includes both NIR_FILES and LIBGLSL_FILES, so for libglsl.la consumers, this is a no-op. libnir.la however no longer uses any GLSL IR infrastructre and can be used without also linking to libglsl.la. --- src/glsl/Makefile.sources | 4 ++-- 1

[Mesa-dev] [PATCH 2/3] i965: Move GLSL lowering passes out of libi965_compiler.la

From: Kristian Høgsberg Kristensen The scope of libi965_compiler.la is to be able to take nir shaders and generate i965 EU code. As such, we don't want the GLSL IR lowering passes in the library. With this change, libi965_compiler.la no longer needs to link to libglsl.la. --- src/mesa/drivers/d

[Mesa-dev] [PATCH 3/3] glsl: Move _mesa_shader_stage_to_string/abbrev to shader_enums.c

From: Kristian Høgsberg Kristensen These are used by code that doens't necessarily link to libglsl.la. Move them to shader_enums.[ch] where we keep similar helpers. --- src/glsl/glsl_parser_extras.cpp | 38 -- src/glsl/glsl_parser_extras.h | 10 -- s

Re: [Mesa-dev] [PATCH 3/3] llvmpipe: add sse code for fixed position calculation

Am 07.01.2016 um 19:56 schrieb Roland Scheidegger: > Am 07.01.2016 um 16:40 schrieb Jose Fonseca: >> On 07/01/16 06:18, Roland Scheidegger wrote: >>> Am 04.01.2016 um 20:38 schrieb Jose Fonseca: On 02/01/16 20:39, srol...@vmware.com wrote: > From: Roland Scheidegger > > This is qu

Re: [Mesa-dev] [PATCH] gallium/dri2: Fix RGB565 EGLImage creation

Le vendredi 08 janvier 2016 à 18:55 +0900, Michel Dänzer a écrit : > The addition of this function and refactoring of existing code to use > it > should be split out into a separate patch. > > Other than that, looks good to me. Great, will do. Nicolas signature.asc Description: This is a digita

Re: [Mesa-dev] [PATCH shader-db 1/2] run: Add compute shader support.

Thanks. Both look good to me. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Hang in dri3_wait_for_event

Hi. 2016-01-08 18:11 GMT+01:00 Martin Peres : > On 08/01/16 18:37, Gustaw Smolarczyk wrote: >> >> Hello, >> >> There are already quite a few bug reports[1][2][3] related to thread >> hang when DRI3 is enabled. The problem still exists, at least for me. >> Should I create another bug report about i

Re: [Mesa-dev] Hang in dri3_wait_for_event

On 08/01/16 18:37, Gustaw Smolarczyk wrote: Hello, There are already quite a few bug reports[1][2][3] related to thread hang when DRI3 is enabled. The problem still exists, at least for me. Should I create another bug report about it? Or maybe the cause of this hang is outside mesa? I do not t

[Mesa-dev] [PATCH v2 7/7] vbo: cache/memoize the result of vbo_get_minmax_indices

From: Nicolai Hähnle Some games developers are unaware that an index buffer in a VBO still needs to be read by the CPU if some varying data comes from a user pointer (unless glDrawRangeElements and friends are used). This is particularly bad when they tell us that the index buffer should live in

[Mesa-dev] [PATCH v2 2/4] mesa: merge bind_uniform_buffers_{base|range}

From: Nicolai Hähnle Reduced code duplication should make the code more maintainable. --- src/mesa/main/bufferobj.c | 158 +++--- 1 file changed, 50 insertions(+), 108 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 1

[Mesa-dev] [PATCH v2 3/4] mesa: merge bind_shader_storage_buffers_{base|range}

From: Nicolai Hähnle Reduced code duplication should make the code more maintainable. --- src/mesa/main/bufferobj.c | 162 +++--- 1 file changed, 51 insertions(+), 111 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 0

[Mesa-dev] [PATCH v2 4/4] mesa: merge bind_atomic_buffers_{base|range}

From: Nicolai Hähnle Reduced code duplication should make the code more maintainable. --- src/mesa/main/bufferobj.c | 155 +++--- 1 file changed, 49 insertions(+), 106 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 2

[Mesa-dev] [PATCH v2 0/4] mesa/bufferobj: reduce code duplication

Hi, thanks to Ian's well-founded remarks, here is a v2 of the series where I added an explicit range parameter to the functions, and the offsets/ sizes are loaded iff that parameter is true. As a consequence, passing NULL for these parameters will crash as expected (which I do agree is better beca

[Mesa-dev] [PATCH v2 1/4] mesa: merge bind_xfb_buffers_{base|range}

From: Nicolai Hähnle Reduced code duplication should make the code more maintainable. --- src/mesa/main/bufferobj.c | 172 -- 1 file changed, 59 insertions(+), 113 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index d

Re: [Mesa-dev] [PATCH 8/8] nine: allow fragment shader POSITION and FACE to be system values

On 08/01/2016 17:30, Marek Olšák wrote: On Fri, Jan 8, 2016 at 12:25 PM, Axel Davy wrote: On 08/01/2016 02:29, Marek Olšák wrote: From: Marek Olšák --- src/gallium/state_trackers/nine/nine_ff.c | 10 +- src/gallium/state_trackers/nine/nine_shader.c | 48 +

[Mesa-dev] Hang in dri3_wait_for_event

Hello, There are already quite a few bug reports[1][2][3] related to thread hang when DRI3 is enabled. The problem still exists, at least for me. Should I create another bug report about it? Or maybe the cause of this hang is outside mesa? I use xserver 1.18, xf86-video-ati git, libdrm git, mesa

Re: [Mesa-dev] [PATCH 8/8] nine: allow fragment shader POSITION and FACE to be system values

On Fri, Jan 8, 2016 at 12:25 PM, Axel Davy wrote: > On 08/01/2016 02:29, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/state_trackers/nine/nine_ff.c | 10 +- >> src/gallium/state_trackers/nine/nine_shader.c | 48 >> +-- >> 2 files changed,

Re: [Mesa-dev] [PATCH 3/8] gallium: add caps for POSITION and FACE system values

On Fri, Jan 8, 2016 at 3:15 AM, Ilia Mirkin wrote: > On Thu, Jan 7, 2016 at 8:29 PM, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/gallium/docs/source/screen.rst | 5 + >> src/gallium/docs/source/tgsi.rst | 6 -- >> src/gallium/drivers/freedreno/

Re: [Mesa-dev] [PATCH 1/2] radeonsi: simplify gl_FragCoord behavior

On Fri, Jan 8, 2016 at 4:30 PM, Nicolai Hähnle wrote: > On 08.01.2016 06:48, Marek Olšák wrote: >> >> On Fri, Jan 8, 2016 at 12:35 PM, Axel Davy wrote: >>> >>> On 08/01/2016 02:30, Marek Olšák wrote: From: Marek Olšák It will become a system value, not an input. ---

Re: [Mesa-dev] [PATCH 0/8] gl_FragCoord and gl_FrontFacing as system values

On 01/07/2016 06:29 PM, Marek Olšák wrote: Hi, This series adds the possibility for drivers to get gl_FragCoord and gl_FrontFacing as system values. When FACE is a system value, it also changes its type to integer from floating-point. Each variable has its own Const flag / Gallium CAP, so dri

[Mesa-dev] [Bug 72877] Wrong colors with Mesa 9.2 and Mesa 10.0 on PPC Linux systems

https://bugs.freedesktop.org/show_bug.cgi?id=72877 --- Comment #19 from joro-2013 --- Actually i had already e-mailed Roland Scheideregger privately (thanking him for still giving some care to this ancient driver with BE systems although the commit didn't fix the problems :-). I already tracked

Re: [Mesa-dev] [PATCH 1/2] radeonsi: simplify gl_FragCoord behavior

On 08.01.2016 06:48, Marek Olšák wrote: On Fri, Jan 8, 2016 at 12:35 PM, Axel Davy wrote: On 08/01/2016 02:30, Marek Olšák wrote: From: Marek Olšák It will become a system value, not an input. --- src/gallium/drivers/radeonsi/si_state_shaders.c | 45 - 1 file ch

Re: [Mesa-dev] [PATCH 7/7] vbo: cache/memoize the result of vbo_get_minmax_indices

On 07.01.2016 23:13, Chris Forbes wrote: I think this misses the image load/store case. (*samplerBuffer) Good catch, thanks! Cheers, Nicolai - Chris From: Nicolai Hähnle mailto:nicolai.haeh...@amd.com>> Some games developers are unaware that an index buffer in a VBO still needs to be read

Re: [Mesa-dev] [PATCH 0/7] vbo: introduce a minmax_index cache

Hi Timothy, On 07.01.2016 23:01, Timothy Arceri wrote: On Thu, 2016-01-07 at 19:57 -0500, Nicolai Hähnle wrote: Hi, this series is intended to address a (big) part of the performance problems that occur when games use an index buffer from a VBO together with vertex attributes supplied by user

Re: [Mesa-dev] [PATCH 1/2] mesa/main: Avoid `void function returning a value` warning.

On 01/08/2016 07:08 AM, Jose Fonseca wrote: Trivial. --- src/mesa/main/shaderimage.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c index c4ebf42..040e9fd 100644 --- a/src/mesa/main/shaderimage.c +++ b/src/mes

Re: [Mesa-dev] [PATCH 2/2] glsl: Ensure 64bits shift is used.

On 01/08/2016 07:08 AM, Jose Fonseca wrote: I believe that `1u << x`, where x >= 32 yields undefined results according to the C standard. Particularly MSVC says `warning C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)`. --- src/glsl/link_varyin

Re: [Mesa-dev] [PATCH 3/3] tgsi/ureg: handle redundant declarations in ureg_DECL_system_value

For the series, Reviewed-by: Brian Paul On 01/07/2016 06:12 PM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_ureg.c b/src/gallium/auxiliary/tgsi

[Mesa-dev] [Bug 93577] Total war: Attila crashes at startup

https://bugs.freedesktop.org/show_bug.cgi?id=93577 --- Comment #6 from Médéric Boquien --- To add to what ArneJ has said, for people trying to run Attila with the r600 driver, one needs 1. to run Mesa git as the GL_ARB_copy_image extension did not make it in time for 11.1 as far as I understand,

[Mesa-dev] [Bug 93628] Exception: attempt to use unavailable module DRM when building MesaGL 11.1.0 on windows

https://bugs.freedesktop.org/show_bug.cgi?id=93628 --- Comment #1 from Emil Velikov --- The following commit should fix it. I'll scoop it up for the next 11.1 release. commit 02afbd247620bd51a5b1661ced9b01a865136484 Author: Jose Fonseca Date: Sat Nov 21 21:19:57 2015 + scons: Conditi

[Mesa-dev] [Bug 72877] Wrong colors with Mesa 9.2 and Mesa 10.0 on PPC Linux systems

https://bugs.freedesktop.org/show_bug.cgi?id=72877 --- Comment #18 from Emil Velikov --- (In reply to joro-2013 from comment #16) > Allow me to add my experiences. > > Whether the colors are garbled on PPC depends on the GL color format used > (among probably a gazillion other parameters :-). Pa

[Mesa-dev] [PATCH 1/2] mesa/main: Avoid `void function returning a value` warning.

Trivial. --- src/mesa/main/shaderimage.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c index c4ebf42..040e9fd 100644 --- a/src/mesa/main/shaderimage.c +++ b/src/mesa/main/shaderimage.c @@ -738,8 +738,10 @@ _mesa_

[Mesa-dev] [PATCH 2/2] glsl: Ensure 64bits shift is used.

I believe that `1u << x`, where x >= 32 yields undefined results according to the C standard. Particularly MSVC says `warning C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)`. --- src/glsl/link_varyings.cpp | 6 +++--- 1 file changed, 3 insertions

[Mesa-dev] [PATCH] mesa: Move sanity check of BindVertexBuffer for OpenGL ES 3.1

From: Marta Lofstedt Sanity check of BindVertexBuffer for OpenGL ES in _mesa_handle_bind_buffer_gen breaks OpenGL ES 2 conformance. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93426 Signed-off-by: Marta Lofstedt --- src/mesa/main/bufferobj.c | 2 +- src/mesa/main/varray.c| 8 +++

[Mesa-dev] [Bug 72877] Wrong colors with Mesa 9.2 and Mesa 10.0 on PPC Linux systems

https://bugs.freedesktop.org/show_bug.cgi?id=72877 --- Comment #17 from joro-2013 --- Addendum: Tested on the pcsx playstation emulator (which makes the GL format selectable) and the peopsxgl plugin ported to PPC. -- You are receiving this mail because: You are the assignee for the bug. ___

[Mesa-dev] [Bug 72877] Wrong colors with Mesa 9.2 and Mesa 10.0 on PPC Linux systems

https://bugs.freedesktop.org/show_bug.cgi?id=72877 --- Comment #16 from joro-2013 --- Allow me to add my experiences. Whether the colors are garbled on PPC depends on the GL color format used (among probably a gazillion other parameters :-). Packed (16-bit) formats have been broken on big-endian

Re: [Mesa-dev] New stable-branch 11.1 candidate pushed

On Fri, 2016-01-08 at 11:44 +, Emil Velikov wrote: > Hello list, > > The candidate for the Mesa 11.1.1 is now available. Currently we > have: > - 51 queued > - 14 nominated (outstanding) > - and 7 rejected/obsolete patches > > Current queue covers a significant amount of fixes - from radeo

  1   2   >