Re: [Mesa-dev] [PATCH 2/6] radeonsi: pass si_context down into si_shader_binary_read

2015-12-31 Thread Marek Olšák
On Thu, Dec 31, 2015 at 3:30 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This will allow us to send shader debug info via the context's debug callback. Could we please pass struct pipe_debug_callback to si_shader_create instead of si_context? This is defensive programming - the compilat

[Mesa-dev] [PATCH] st/mesa: sort extensions enablement array

2015-12-31 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_extensions.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index a0168d8..90eb677 100644 --- a/src/mesa/state_tr

[Mesa-dev] [PATCH 3/4] gallium: add caps to expose support for multi indirect draws

2015-12-31 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/docs/source/screen.rst | 5 + src/gallium/drivers/freedreno/freedreno_screen.c | 2 ++ src/gallium/drivers/i915/i915_screen.c | 2 ++ src/gallium/drivers/ilo/ilo_screen.c | 2 ++ src/gallium/drivers/llvmpipe/lp_scr

[Mesa-dev] [PATCH 4/4] st/mesa: add support for new mesa indirect draw interface

2015-12-31 Thread Ilia Mirkin
This shifts all indirect draws to go through the new function. If the driver doesn't have support for multi draws, we break those up and perform N draws. Otherwise, we pass everything through for just a single draw call. Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_context.c | 2 +

[Mesa-dev] [PATCH 2/4] gallium: add sufficient draw interface to allow new indirect features

2015-12-31 Thread Ilia Mirkin
This makes it possible to support indirect multidraws as well as having the number of such draws to come from a separate GPU resource. Signed-off-by: Ilia Mirkin --- src/gallium/include/pipe/p_state.h | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/gallium/inc

[Mesa-dev] [PATCH 0/4] Actual ARB_multi_draw_indirect support

2015-12-31 Thread Ilia Mirkin
The current support in mesa for ARB_multi_draw_indirect is pretty shameful... it just does N separate draws. Instead make it possible for drivers to handle this in a more efficient manner. Also create the backend interfaces necessary to support ARB_indirect_parameters, although the (trivial) fronte

[Mesa-dev] [PATCH 1/4] vbo: create a new draw function interface for indirect draws

2015-12-31 Thread Ilia Mirkin
This is optional for now in the transition period, but optimally all backends that support indirect draws would switch over to it and we can remove the support for indirect in the "regular" draw function. This should allow a backend to properly support ARB_multi_draw_indirect and ARB_indirect_para

Re: [Mesa-dev] [PATCH 3/5] llvmpipe: Optimize do_triangle_ccw for POWER8

2015-12-31 Thread Roland Scheidegger
Am 31.12.2015 um 19:41 schrieb Roland Scheidegger: > Am 31.12.2015 um 10:15 schrieb Oded Gabbay: >> On Thu, Dec 31, 2015 at 4:13 AM, Roland Scheidegger >> wrote: >>> >>> Am 30.12.2015 um 10:59 schrieb Oded Gabbay: On Wed, Dec 30, 2015 at 1:17 AM, Roland Scheidegger wrote: > The id

[Mesa-dev] [PATCH v2 2/2] mesa: Use separate indices for UBO & SSBO during binding

2015-12-31 Thread Jordan Justen
Previously we were treating the binding index for Uniform Buffer Objects and Shader Storage Buffer Objects as being part of the combined BufferInterfaceBlocks array. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93322 Cc: Samuel Iglesias Gonsálvez Cc: Iago Toral Cc: Tapani Pälli Signed

[Mesa-dev] [PATCH v2 1/2] mesa: Map program UBOs and SSBOs to Interface Blocks

2015-12-31 Thread Jordan Justen
v2: * Fill UboInterfaceBlockIndex and SsboInterfaceBlockIndex in split_ubos_and_ssbos (Iago) Cc: Samuel Iglesias Gonsálvez Cc: Iago Toral Signed-off-by: Jordan Justen Reviewed-by: Juha-Pekka Heikkila --- src/glsl/linker.cpp | 30 +- src/glsl/sta

Re: [Mesa-dev] [PATCH 1/5] configure.ac: Detect if running on POWER8 arch

2015-12-31 Thread Roland Scheidegger
Am 31.12.2015 um 10:30 schrieb Oded Gabbay: > On Wed, Dec 30, 2015 at 5:41 PM, Roland Scheidegger > wrote: >> Am 30.12.2015 um 10:46 schrieb Oded Gabbay: >>> On Wed, Dec 30, 2015 at 1:11 AM, Roland Scheidegger >>> wrote: So, if I see that right, you will automatically generate binarie

Re: [Mesa-dev] [PATCH 3/5] llvmpipe: Optimize do_triangle_ccw for POWER8

2015-12-31 Thread Roland Scheidegger
Am 31.12.2015 um 10:15 schrieb Oded Gabbay: > On Thu, Dec 31, 2015 at 4:13 AM, Roland Scheidegger > wrote: >> >> Am 30.12.2015 um 10:59 schrieb Oded Gabbay: >>> On Wed, Dec 30, 2015 at 1:17 AM, Roland Scheidegger >>> wrote: The idea looks right to me. Though frankly I don't like our c

Re: [Mesa-dev] [shader-db PATCH 1/5] run: create debug contexts

2015-12-31 Thread Ilia Mirkin
On Thu, Dec 31, 2015 at 12:36 PM, Matt Turner wrote: > On Thu, Dec 31, 2015 at 12:25 PM, Ilia Mirkin wrote: >> On Thu, Dec 31, 2015 at 12:17 PM, Matt Turner wrote: >>> On Thu, Dec 31, 2015 at 9:45 AM, Ilia Mirkin wrote: On Dec 31, 2015 9:32 AM, "Matt Turner" wrote: > > On Wed, Dec

Re: [Mesa-dev] [RFC] i965: alternative to memctx for cleaning up nir variants

2015-12-31 Thread Rob Clark
On Thu, Dec 31, 2015 at 12:05 PM, Connor Abbott wrote: > On Thu, Dec 31, 2015 at 10:16 AM, Rob Clark wrote: >> On Tue, Dec 29, 2015 at 10:32 AM, Rob Clark wrote: >> If you do this, you'll be back to always needing a mutable copy. Most >> lowering and optimization passes die the moment t

Re: [Mesa-dev] [shader-db PATCH 1/5] run: create debug contexts

2015-12-31 Thread Matt Turner
On Thu, Dec 31, 2015 at 12:25 PM, Ilia Mirkin wrote: > On Thu, Dec 31, 2015 at 12:17 PM, Matt Turner wrote: >> On Thu, Dec 31, 2015 at 9:45 AM, Ilia Mirkin wrote: >>> On Dec 31, 2015 9:32 AM, "Matt Turner" wrote: On Wed, Dec 30, 2015 at 9:32 PM, Nicolai Hähnle wrote: > For

Re: [Mesa-dev] [shader-db PATCH 1/5] run: create debug contexts

2015-12-31 Thread Ilia Mirkin
On Thu, Dec 31, 2015 at 12:17 PM, Matt Turner wrote: > On Thu, Dec 31, 2015 at 9:45 AM, Ilia Mirkin wrote: >> On Dec 31, 2015 9:32 AM, "Matt Turner" wrote: >>> >>> On Wed, Dec 30, 2015 at 9:32 PM, Nicolai Hähnle >>> wrote: >>> > For Gallium-based drivers, this is required for receiving shader >

Re: [Mesa-dev] [shader-db PATCH 1/5] run: create debug contexts

2015-12-31 Thread Matt Turner
On Thu, Dec 31, 2015 at 9:45 AM, Ilia Mirkin wrote: > On Dec 31, 2015 9:32 AM, "Matt Turner" wrote: >> >> On Wed, Dec 30, 2015 at 9:32 PM, Nicolai Hähnle >> wrote: >> > For Gallium-based drivers, this is required for receiving shader >> > information >> > via debug messages. >> > --- >> >> But t

Re: [Mesa-dev] [RFC] i965: alternative to memctx for cleaning up nir variants

2015-12-31 Thread Connor Abbott
On Thu, Dec 31, 2015 at 10:16 AM, Rob Clark wrote: > On Tue, Dec 29, 2015 at 10:32 AM, Rob Clark wrote: > If you do this, you'll be back to always needing a mutable copy. Most > lowering and optimization passes die the moment they see a register. > You'll > either have to go fi

[Mesa-dev] [PATCH v6 2/3] clover: override ret_object

2015-12-31 Thread Serge Martin
Return an API object from an intrusive reference to a Clover object, incrementing the reference count of the object. Reviewed-by: Francisco Jerez --- src/gallium/state_trackers/clover/api/util.hpp | 12 1 file changed, 12 insertions(+) diff --git a/src/gallium/state_trackers/clover

[Mesa-dev] [PATCH v6 3/3] clover: add clLinkProgram (CL 1.2)

2015-12-31 Thread Serge Martin
Reviewed-by: Francisco Jerez --- src/gallium/state_trackers/clover/api/program.cpp | 31 +++--- src/gallium/state_trackers/clover/core/program.hpp | 4 +-- 2 files changed, 29 insertions(+), 6 deletions(-) diff --git a/src/gallium/state_trackers/clover/api/program.cpp b/src/ga

[Mesa-dev] [PATCH v6 1/3] clover: separate compile and link stages

2015-12-31 Thread Serge Martin
--- src/gallium/state_trackers/clover/api/program.cpp | 19 +- .../state_trackers/clover/core/compiler.hpp| 7 +- src/gallium/state_trackers/clover/core/error.hpp | 7 + src/gallium/state_trackers/clover/core/program.cpp | 41 +++- src/gallium/state_trackers/clover/core/program.hp

[Mesa-dev] [PATCH v6 0/3] add clLinkProgram

2015-12-31 Thread Serge Martin
This serie add clLinkProgram function needed for CL 1.2. However, it lacks the binary type part that is mandatory for input validation and also for CL_PROGRAM_BINARY_TYPE query. This will be adressed in another serie once we agree on the way to store it. This v6 is not different from v5 or v4, exc

Re: [Mesa-dev] [RFC] i965: alternative to memctx for cleaning up nir variants

2015-12-31 Thread Rob Clark
On Tue, Dec 29, 2015 at 10:32 AM, Rob Clark wrote: If you do this, you'll be back to always needing a mutable copy. Most lowering and optimization passes die the moment they see a register. You'll either have to go fix a bunch of stuff up to no-op properly or run vars_t

Re: [Mesa-dev] [RFC PATCH] vbo: create a new draw function interface for indirect draws

2015-12-31 Thread Marek Olšák
On Thu, Dec 31, 2015 at 12:10 AM, Ilia Mirkin wrote: > This is optional for now in the transition period, but optimally all > backends that support indirect draws would switch over to it and we can > remove the support for indirect in the "regular" draw function. > > This should allow a backend to

Re: [Mesa-dev] [shader-db PATCH 1/5] run: create debug contexts

2015-12-31 Thread Ilia Mirkin
On Dec 31, 2015 9:32 AM, "Matt Turner" wrote: > > On Wed, Dec 30, 2015 at 9:32 PM, Nicolai Hähnle wrote: > > For Gallium-based drivers, this is required for receiving shader information > > via debug messages. > > --- > > But that's a Gallium bug, right? > > Ilia sent a similar patch, and in the

Re: [Mesa-dev] [shader-db PATCH 1/5] run: create debug contexts

2015-12-31 Thread Matt Turner
On Wed, Dec 30, 2015 at 9:32 PM, Nicolai Hähnle wrote: > For Gallium-based drivers, this is required for receiving shader information > via debug messages. > --- But that's a Gallium bug, right? Ilia sent a similar patch, and in the discussion I think we decided that what run.c is doing is perfe

Re: [Mesa-dev] [PATCH 1/5] configure.ac: Detect if running on POWER8 arch

2015-12-31 Thread Oded Gabbay
On Thu, Dec 31, 2015 at 2:38 PM, Oded Gabbay wrote: > On Thu, Dec 31, 2015 at 11:30 AM, Oded Gabbay wrote: >> On Wed, Dec 30, 2015 at 5:41 PM, Roland Scheidegger >> wrote: >>> Am 30.12.2015 um 10:46 schrieb Oded Gabbay: On Wed, Dec 30, 2015 at 1:11 AM, Roland Scheidegger wrote:

Re: [Mesa-dev] [PATCH 1/5] configure.ac: Detect if running on POWER8 arch

2015-12-31 Thread Oded Gabbay
On Thu, Dec 31, 2015 at 11:30 AM, Oded Gabbay wrote: > On Wed, Dec 30, 2015 at 5:41 PM, Roland Scheidegger > wrote: >> Am 30.12.2015 um 10:46 schrieb Oded Gabbay: >>> On Wed, Dec 30, 2015 at 1:11 AM, Roland Scheidegger >>> wrote: So, if I see that right, you will automatically genera

Re: [Mesa-dev] [PATCH] i965: Remove unused hw_must_use_separate_stencil

2015-12-31 Thread Kenneth Graunke
On Wednesday, December 30, 2015 9:47:17 AM PST Ben Widawsky wrote: > I spotted this while looking for what needs updating in future platforms. > > I'm too lazy to go through the git logs, but it was probably missed by Jason > when all the brw refactoring happened. > > Signed-off-by: Ben Widawsky

Re: [Mesa-dev] [PATCH] main: Add MESA_VERBOSE=api for several indexed BindBuffer variants

2015-12-31 Thread Kenneth Graunke
On Wednesday, December 30, 2015 4:06:03 PM PST Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/main/bufferobj.c | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c > index e0639c8..8eae72c 100644 >

Re: [Mesa-dev] [PATCH 1/5] configure.ac: Detect if running on POWER8 arch

2015-12-31 Thread Oded Gabbay
On Wed, Dec 30, 2015 at 5:41 PM, Roland Scheidegger wrote: > Am 30.12.2015 um 10:46 schrieb Oded Gabbay: >> On Wed, Dec 30, 2015 at 1:11 AM, Roland Scheidegger >> wrote: >>> >>> So, if I see that right, you will automatically generate binaries using >>> power8 instructions if compiled on power8

Re: [Mesa-dev] [PATCH 2/5] llvmpipe: add POWER8 portability file - u_pwr8.h

2015-12-31 Thread Oded Gabbay
On Wed, Dec 30, 2015 at 5:53 PM, Roland Scheidegger wrote: > Am 30.12.2015 um 10:57 schrieb Oded Gabbay: >> On Wed, Dec 30, 2015 at 3:18 AM, Roland Scheidegger >> wrote: >>> Am 29.12.2015 um 17:12 schrieb Oded Gabbay: This file provides a portability layer that will make it easier to conver

Re: [Mesa-dev] [PATCH 3/5] llvmpipe: Optimize do_triangle_ccw for POWER8

2015-12-31 Thread Oded Gabbay
On Thu, Dec 31, 2015 at 4:13 AM, Roland Scheidegger wrote: > > Am 30.12.2015 um 10:59 schrieb Oded Gabbay: > > On Wed, Dec 30, 2015 at 1:17 AM, Roland Scheidegger > > wrote: > >> The idea looks right to me. > >> Though frankly I don't like our current setup code too much - in > >> particular the

Re: [Mesa-dev] [PATCH] llvmpipe: use aligned data for the assembly program in setup

2015-12-31 Thread Oded Gabbay
On Thu, Dec 31, 2015 at 5:46 AM, wrote: > From: Roland Scheidegger > > Back in the day (before 24678700edaf5bb9da9be93a1367f1a24cfaa471) the values > were not actually in a struct but even then I can't see why we didn't simply > align the values. Especially since it's trivial to do so. > (Not th