Re: [Mesa-dev] [PATCH] nir/builder: fix C90 build errors

2015-12-19 Thread Connor Abbott
On Sun, Dec 20, 2015 at 12:02 AM, Rob Clark wrote: > On Sat, Dec 19, 2015 at 11:46 PM, Connor Abbott wrote: >> On Sat, Dec 19, 2015 at 11:08 PM, Rob Clark wrote: >>> On Sat, Dec 19, 2015 at 10:30 PM, Connor Abbott wrote: On Sat, Dec 19, 2015 at 10:19 PM, Rob Clark wrote: > On Sat, Dec

[Mesa-dev] [PATCH] st/va: hardlink driver instances to gallium_drv_video.so

2015-12-19 Thread Jimmy Berry
Removes the need to set LIBVA_DRIVER_NAME=gallium for supported targets and is consistent with vdpau and general gallium drivers. Signed-off-by: Jimmy Berry --- src/gallium/targets/va/Makefile.am | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/targets/va/Makefile.

Re: [Mesa-dev] [PATCH] nir/builder: fix C90 build errors

2015-12-19 Thread Rob Clark
On Sat, Dec 19, 2015 at 11:46 PM, Connor Abbott wrote: > On Sat, Dec 19, 2015 at 11:08 PM, Rob Clark wrote: >> On Sat, Dec 19, 2015 at 10:30 PM, Connor Abbott wrote: >>> On Sat, Dec 19, 2015 at 10:19 PM, Rob Clark wrote: On Sat, Dec 19, 2015 at 10:05 PM, Connor Abbott wrote: > O

Re: [Mesa-dev] [PATCH] nir/builder: fix C90 build errors

2015-12-19 Thread Connor Abbott
On Sat, Dec 19, 2015 at 11:08 PM, Rob Clark wrote: > On Sat, Dec 19, 2015 at 10:30 PM, Connor Abbott wrote: >> On Sat, Dec 19, 2015 at 10:19 PM, Rob Clark wrote: >>> On Sat, Dec 19, 2015 at 10:05 PM, Connor Abbott wrote: On Sat, Dec 19, 2015 at 9:52 PM, Rob Clark wrote: > On Sat, Dec

Re: [Mesa-dev] [PATCH] nir/builder: fix C90 build errors

2015-12-19 Thread Rob Clark
On Sat, Dec 19, 2015 at 10:30 PM, Connor Abbott wrote: > On Sat, Dec 19, 2015 at 10:19 PM, Rob Clark wrote: >> On Sat, Dec 19, 2015 at 10:05 PM, Connor Abbott wrote: >>> On Sat, Dec 19, 2015 at 9:52 PM, Rob Clark wrote: On Sat, Dec 19, 2015 at 9:30 PM, Connor Abbott wrote: > On Sat, D

Re: [Mesa-dev] [PATCH] nir/builder: fix C90 build errors

2015-12-19 Thread Connor Abbott
On Sat, Dec 19, 2015 at 10:19 PM, Rob Clark wrote: > On Sat, Dec 19, 2015 at 10:05 PM, Connor Abbott wrote: >> On Sat, Dec 19, 2015 at 9:52 PM, Rob Clark wrote: >>> On Sat, Dec 19, 2015 at 9:30 PM, Connor Abbott wrote: On Sat, Dec 19, 2015 at 9:18 PM, Rob Clark wrote: > Note that this

Re: [Mesa-dev] [PATCH] nir/builder: fix C90 build errors

2015-12-19 Thread Rob Clark
On Sat, Dec 19, 2015 at 10:05 PM, Connor Abbott wrote: > On Sat, Dec 19, 2015 at 9:52 PM, Rob Clark wrote: >> On Sat, Dec 19, 2015 at 9:30 PM, Connor Abbott wrote: >>> On Sat, Dec 19, 2015 at 9:18 PM, Rob Clark wrote: Note that this is *only* about the header files.. not the src files. >>>

Re: [Mesa-dev] [PATCH 1/9] st/glsl_to_tgsi: store if dst is double in array

2015-12-19 Thread Michael Schellenberger Costa
Am 19/12/2015 um 05:43 schrieb Dave Airlie: > From: Dave Airlie > > This is just a precursor patch to a fix for doubles with > tessellation that I've written. > > We need to descend into output arrays in that case and > mark dst's as double. > > Signed-off-by: Dave Airlie > --- > src/mesa/s

Re: [Mesa-dev] [PATCH] nir/builder: fix C90 build errors

2015-12-19 Thread Connor Abbott
On Sat, Dec 19, 2015 at 9:52 PM, Rob Clark wrote: > On Sat, Dec 19, 2015 at 9:30 PM, Connor Abbott wrote: >> On Sat, Dec 19, 2015 at 9:18 PM, Rob Clark wrote: >>> Note that this is *only* about the header files.. not the src files. >>> I'm not proposing to make NIR support C90. >> >> Why would y

Re: [Mesa-dev] [PATCH] nir/builder: fix C90 build errors

2015-12-19 Thread Rob Clark
On Sat, Dec 19, 2015 at 9:30 PM, Connor Abbott wrote: > On Sat, Dec 19, 2015 at 9:18 PM, Rob Clark wrote: >> Note that this is *only* about the header files.. not the src files. >> I'm not proposing to make NIR support C90. > > Why would you need to only make the header filef C90 compliant? If yo

Re: [Mesa-dev] [PATCH] nir/builder: fix C90 build errors

2015-12-19 Thread Connor Abbott
On Sat, Dec 19, 2015 at 9:18 PM, Rob Clark wrote: > Note that this is *only* about the header files.. not the src files. > I'm not proposing to make NIR support C90. Why would you need to only make the header filef C90 compliant? If you just need to pass around a nir_shader * or something, you ca

Re: [Mesa-dev] [PATCH] nir/builder: fix C90 build errors

2015-12-19 Thread Rob Clark
Note that this is *only* about the header files.. not the src files. I'm not proposing to make NIR support C90. I will at some point, before it is ready to merge, need to arrange the NIR related bits in mesa st so that we can build without it, for benefit of the MSVC folks. (It might be useful so

Re: [Mesa-dev] [RFC] i965: alternative to memctx for cleaning up nir variants

2015-12-19 Thread Rob Clark
On Sat, Dec 19, 2015 at 9:01 PM, Connor Abbott wrote: > Why don't you just introduce a reference-counted wrapper around a > nir_shader * and pass that around instead? This seems like a > gallium-specific problem, so modifying other things to work around it > doesn't seem so appealing. 1) I wanted

Re: [Mesa-dev] [RFC] i965: alternative to memctx for cleaning up nir variants

2015-12-19 Thread Connor Abbott
Why don't you just introduce a reference-counted wrapper around a nir_shader * and pass that around instead? This seems like a gallium-specific problem, so modifying other things to work around it doesn't seem so appealing. On Sat, Dec 19, 2015 at 8:55 PM, Rob Clark wrote: > From: Rob Clark > >

Re: [Mesa-dev] [PATCH] nir/builder: fix C90 build errors

2015-12-19 Thread Connor Abbott
We haven't allowed NIR in core gallium before, since core gallium has to be built with some old version of MSVC that doesn't support many C99 features that we really wanted to use. The only reason that -Werror exists is for compatibility with old MSVC, and if you want to use NIR with something that

[Mesa-dev] [RFC] i965: alternative to memctx for cleaning up nir variants

2015-12-19 Thread Rob Clark
From: Rob Clark Jason, How much do you hate this idea? Seems like an easy alternative to using ralloc ctx's to clean up nir variants/clones, which would let us drop the parent memctx for nir_shader_create()/clone(), making it easier to introduce reference counting. --- src/mesa/drivers/dri/i9

Re: [Mesa-dev] [PATCH] nir/builder: fix C90 build errors

2015-12-19 Thread eocallaghan
On 2015-12-20 09:39, Rob Clark wrote: From: Rob Clark We are going to start using nir_builder.h from some gallium code, which is currently only C90. Which results in: In file included from nir/nir_emulate.c:26:0: ../../../src/glsl/nir/nir_builder.h: In function ‘nir_build_alu’: ../..

Re: [Mesa-dev] [PATCH] nvc0: add hardware ETC2 and ASTC support where possible

2015-12-19 Thread Ilia Mirkin
On Sat, Dec 19, 2015 at 1:53 PM, Ilia Mirkin wrote: > These are supported on GK20A and GM107. > > Signed-off-by: Ilia Mirkin > --- > > Was a bit torn on where to place the enums... we're about to gut all > the xml definitions so this seemed appropriate for now. > > Tested on GK20A only. > > src/

[Mesa-dev] [PATCH 2/3] radeonsi: fix viewport clipping handling. (v2)

2015-12-19 Thread Dave Airlie
From: Dave Airlie If oViewport is written, vertex reuse need to be turned off. If oViewport is constant, vertex reuse is fine, and VPORT_PROVOKE_DISABLE need to be set. (We don't know if oViewport is constant so we skip this.) Fixes: arb_viewport_array-render-viewport-2 and some CTS tests. v2:

[Mesa-dev] [PATCH 3/3] r600: fix viewport clipping handling (v2)

2015-12-19 Thread Dave Airlie
From: Dave Airlie If oViewport is written, vertex reuse need to be turned off. If oViewport is constant, vertex reuse is fine, and VPORT_PROVOKE_DISABLE need to be set. (we don't have enough info to program VPORT_PROVOKE). Fixes: arb_viewport_array-render-viewport-2 and some CTS tests. v2: drop

[Mesa-dev] [PATCH 1/3] r600: drop VTX_CNT_EN write from initial state

2015-12-19 Thread Dave Airlie
From: Dave Airlie we always program this in shader stages atom now. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_state.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_state.c b/src/gallium/drivers/r600/

[Mesa-dev] [PATCH] nir/builder: fix C90 build errors

2015-12-19 Thread Rob Clark
From: Rob Clark We are going to start using nir_builder.h from some gallium code, which is currently only C90. Which results in: In file included from nir/nir_emulate.c:26:0: ../../../src/glsl/nir/nir_builder.h: In function ‘nir_build_alu’: ../../../src/glsl/nir/nir_builder.h:132:4: er

[Mesa-dev] [PATCH] glx/dri3: a drawable might not be bound at wait time

2015-12-19 Thread Ilia Mirkin
A trace of Alien Isolation hit this on nouveau. Signed-off-by: Ilia Mirkin Cc: "11.0 11.1" --- Disclaimer: I have no idea if this is a legal situation, but other calls to GetGLXDRIDrawable are null-checked. src/glx/dri3_glx.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff -

[Mesa-dev] [PATCH] st/mesa: fix GLSL uniform updates for glBitmap & glDrawPixels (v2)

2015-12-19 Thread Marek Olšák
From: Marek Olšák Spotted by luck. The GLSL uniform storage is only associated once in LinkShader and can't be reallocated afterwards, because that would break the association. v2: don't remove st_upload_constants calls, clarify why they're needed Cc: 11.0 11.1 --- src/mesa/state_tracker/st_c

[Mesa-dev] [PATCH] nvc0: add hardware ETC2 and ASTC support where possible

2015-12-19 Thread Ilia Mirkin
These are supported on GK20A and GM107. Signed-off-by: Ilia Mirkin --- Was a bit torn on where to place the enums... we're about to gut all the xml definitions so this seemed appropriate for now. Tested on GK20A only. src/gallium/drivers/nouveau/nv50/nv50_formats.c | 64 ++

Re: [Mesa-dev] [PATCH 1/2] radeonsi: fix viewport clipping handling.

2015-12-19 Thread Marek Olšák
On Sat, Dec 19, 2015 at 3:16 AM, Dave Airlie wrote: > From: Dave Airlie > > If oViewport is written, vertex reuse need to be turned off. > If oViewport is constant, vertex reuse is fine, and VPORT_PROVOKE_DISABLE > need to be set. > > Fixes: arb_viewport_array-render-viewport-2 and some CTS tests

Re: [Mesa-dev] [PATCH 1/2] virtio_gpu: Add PCI ID to driver map

2015-12-19 Thread Emil Velikov
On 18 December 2015 at 21:33, Dave Airlie wrote: > On 19 December 2015 at 02:57, Emil Velikov wrote: >> On 17 December 2015 at 15:45, Rob Herring wrote: >>> Add the virtio-gpu PCI ID so the driver probing works. >>> >> Dave, I'd imagine that currently this works ala platform device style >> ? I.

Re: [Mesa-dev] [PATCH 2/2] virgl: enable building on Android

2015-12-19 Thread Emil Velikov
On 18 December 2015 at 17:11, Rob Herring wrote: > On Fri, Dec 18, 2015 at 11:01 AM, Emil Velikov > wrote: >> Thank you Rob ! >> >> On 17 December 2015 at 15:45, Rob Herring wrote: >>> This is just a copy-n-paste and rename of vc4 Android makefiles. >>> >> Looks great. >> >> Rob, I take it that

Re: [Mesa-dev] [PATCH 1/2] radeonsi: fix viewport clipping handling.

2015-12-19 Thread Nicolai Hähnle
On 18.12.2015 21:16, Dave Airlie wrote: From: Dave Airlie If oViewport is written, vertex reuse need to be turned off. If oViewport is constant, vertex reuse is fine, and VPORT_PROVOKE_DISABLE need to be set. Fixes: arb_viewport_array-render-viewport-2 and some CTS tests. Signed-off-by: Dave