Re: [Mesa-dev] [PATCH] i965: Combine BRW_NEW_*_BINDING_TABLE dirty bits.

2015-11-10 Thread Pohjolainen, Topi
On Tue, Nov 10, 2015 at 06:33:44PM -0800, Kenneth Graunke wrote: > A while back, we moved to directly emitting the Gen7+ state when > constructing the binding tables. These flags are only used on > Gen4-6, which emit all the binding table pointers at once. > > We gain nothing by having separate f

Re: [Mesa-dev] [PATCH] texgetimage: consolidate 1D array handling code.

2015-11-10 Thread Ben Skeggs
On 11/11/2015 12:34 PM, Dave Airlie wrote: > From: Dave Airlie > > This should fix the getteximage-depth test that currently asserts. > > I was hitting problem with virgl as well in this area. > > This moves the 1D array handling code to a single place. This fixes the exceptions that some NVIDI

[Mesa-dev] [Bug 92633] FBO creation/destruction issue in brw_meta_resolve_color causing assertion in gen8_emit_null_surface_state

2015-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92633 Ian Romanick changed: What|Removed |Added Component|Drivers/DRI/i965|Mesa core Assignee|i...@freedes

Re: [Mesa-dev] [PATCH] texgetimage: consolidate 1D array handling code.

2015-11-10 Thread Ian Romanick
Reviewed-by: Ian Romanick On 11/10/2015 06:34 PM, Dave Airlie wrote: > From: Dave Airlie > > This should fix the getteximage-depth test that currently asserts. > > I was hitting problem with virgl as well in this area. > > This moves the 1D array handling code to a single place. > > Signed-o

Re: [Mesa-dev] [PATCH 3/4] nir: Allow outputs reads and add the relevant intrinsics.

2015-11-10 Thread Kenneth Graunke
On Tuesday, November 10, 2015 01:21:35 AM you wrote: [snip] > diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c > index a42e830..841bace 100644 > --- a/src/glsl/nir/nir_validate.c > +++ b/src/glsl/nir/nir_validate.c > @@ -422,7 +422,6 @@ validate_intrinsic_instr(nir_intrinsic_i

[Mesa-dev] [PATCH] i965: Combine BRW_NEW_*_BINDING_TABLE dirty bits.

2015-11-10 Thread Kenneth Graunke
A while back, we moved to directly emitting the Gen7+ state when constructing the binding tables. These flags are only used on Gen4-6, which emit all the binding table pointers at once. We gain nothing by having separate flags, so combine them. Signed-off-by: Kenneth Graunke --- src/mesa/drive

[Mesa-dev] [PATCH] texgetimage: consolidate 1D array handling code.

2015-11-10 Thread Dave Airlie
From: Dave Airlie This should fix the getteximage-depth test that currently asserts. I was hitting problem with virgl as well in this area. This moves the 1D array handling code to a single place. Signed-off-by: Dave Airlie --- src/mesa/main/texgetimage.c | 24 +--- 1 fil

Re: [Mesa-dev] [PATCH] nir/validate: Allow subroutine types for the tails of derefs

2015-11-10 Thread Dave Airlie
>> >> Well, it's not just a NIR thing -- GLSL IR also effectively treats >> subroutines as integers. Actually, I wonder why the >> glsl_type::is_vector_or_scalar() doesn't return true for subroutine >> types in the first place. > > For that matter, why do we have a special subroutine type at all?

Re: [Mesa-dev] [Spice-devel] [Patchwork] The infrequent patchwork update #1

2015-11-10 Thread Victor Toso
Hi, On Tue, Sep 29, 2015 at 04:33:07PM +0100, Damien Lespiau wrote: > Hi all, > > You may have noticed already, patchwork.freedesktop.org looks different. > > That new version includes: > - Some re-design. Design is very much an iterative process, thoughts > and comments are welcome, > - S

Re: [Mesa-dev] Can't get OpenGL 3.x inside VMware Workstation 12 (Ubuntu guest)

2015-11-10 Thread Valera Rozuvan
On Tue, Nov 10, 2015 at 4:13 AM, Brian Paul wrote: > After running depmod, you probably need to update the initramfs with: 'sudo > update-initramfs -u' > > -Brian Hi Brian. First of all, thank you for your reply. I have tried your suggestion on my working setup, and also doing everything again f

Re: [Mesa-dev] [PATCH] nir/validate: Allow subroutine types for the tails of derefs

2015-11-10 Thread Jason Ekstrand
On Tue, Nov 10, 2015 at 5:02 PM, Connor Abbott wrote: > On Tue, Nov 10, 2015 at 7:49 PM, Jason Ekstrand wrote: >> On Tue, Nov 10, 2015 at 4:18 PM, Connor Abbott wrote: >>> Since subroutine types are really just integers, should we just make >>> glsl_type_is_vector_or_scalar() return true for the

Re: [Mesa-dev] [PATCH] nir/validate: Allow subroutine types for the tails of derefs

2015-11-10 Thread Connor Abbott
On Tue, Nov 10, 2015 at 7:49 PM, Jason Ekstrand wrote: > On Tue, Nov 10, 2015 at 4:18 PM, Connor Abbott wrote: >> Since subroutine types are really just integers, should we just make >> glsl_type_is_vector_or_scalar() return true for them? > > That's an interesting question. It entirely depends

Re: [Mesa-dev] [PATCH] nir/validate: Allow subroutine types for the tails of derefs

2015-11-10 Thread Jason Ekstrand
On Tue, Nov 10, 2015 at 4:18 PM, Connor Abbott wrote: > Since subroutine types are really just integers, should we just make > glsl_type_is_vector_or_scalar() return true for them? That's an interesting question. It entirely depends on whether glsl_type_is_vector_or_scalar is a NIR thing or not.

Re: [Mesa-dev] [PATCH] nir: fix typo in idiv lowering, causing large-udiv-udiv failures

2015-11-10 Thread Ilia Mirkin
On Tue, Nov 10, 2015 at 7:24 PM, Connor Abbott wrote: > On Tue, Nov 10, 2015 at 7:02 PM, Ilia Mirkin wrote: >> On Tue, Nov 10, 2015 at 6:44 PM, Eric Anholt wrote: >>> Ilia Mirkin writes: >>> In nv50, and in the python script that Rob circulated, we do: bld.mkCmp(OP_SET, CC_GE,

Re: [Mesa-dev] [PATCH] nir: fix typo in idiv lowering, causing large-udiv-udiv failures

2015-11-10 Thread Connor Abbott
On Tue, Nov 10, 2015 at 7:02 PM, Ilia Mirkin wrote: > On Tue, Nov 10, 2015 at 6:44 PM, Eric Anholt wrote: >> Ilia Mirkin writes: >> >>> In nv50, and in the python script that Rob circulated, we do: >>> >>>bld.mkCmp(OP_SET, CC_GE, TYPE_U32, (s = bld.getSSA()), TYPE_U32, m, b); >>> >>> Do the

Re: [Mesa-dev] [PATCH] nir/validate: Allow subroutine types for the tails of derefs

2015-11-10 Thread Connor Abbott
Since subroutine types are really just integers, should we just make glsl_type_is_vector_or_scalar() return true for them? On Tue, Nov 10, 2015 at 5:18 PM, Jason Ekstrand wrote: > The shader-subroutine code creates uniforms of type SUBROUTINE for > subroutines that are then read as integers in th

Re: [Mesa-dev] [PATCH] nir: fix typo in idiv lowering, causing large-udiv-udiv failures

2015-11-10 Thread Ilia Mirkin
On Tue, Nov 10, 2015 at 6:44 PM, Eric Anholt wrote: > Ilia Mirkin writes: > >> In nv50, and in the python script that Rob circulated, we do: >> >>bld.mkCmp(OP_SET, CC_GE, TYPE_U32, (s = bld.getSSA()), TYPE_U32, m, b); >> >> Do the same in the nir div lowering pass. This fixes the large-udiv-u

Re: [Mesa-dev] [PATCH 09/10] i965/meta: Remove fast_clear_color variable

2015-11-10 Thread Ben Widawsky
On Wed, Oct 14, 2015 at 08:16:54AM -0700, Ben Widawsky wrote: > On Wed, Oct 14, 2015 at 11:52:03AM +0200, Neil Roberts wrote: > > This patch doesn't look right. See this sentence in “Render Target Fast > > Clear”: > > > > “The pixel shader kernel requires no attributes, and delivers a value of > >

Re: [Mesa-dev] [PATCH] nir: fix typo in idiv lowering, causing large-udiv-udiv failures

2015-11-10 Thread Eric Anholt
Ilia Mirkin writes: > In nv50, and in the python script that Rob circulated, we do: > >bld.mkCmp(OP_SET, CC_GE, TYPE_U32, (s = bld.getSSA()), TYPE_U32, m, b); > > Do the same in the nir div lowering pass. This fixes the large-udiv-udiv > piglit tests on freedreno. I assume you meant *-op-div

[Mesa-dev] [PATCH] radeonsi: fix occlusion queries on Fiji

2015-11-10 Thread Marek Olšák
From: Marek Olšák Untested. I need a new PSU with two 8pin connectors to be able to use Fiji. --- src/gallium/drivers/radeon/r600_pipe_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600

Re: [Mesa-dev] [PATCH] egl/x11/dri3: do not expose the preserved swap behavior (to be squashed)

2015-11-10 Thread Eric Anholt
Martin Peres writes: > The preserved swap behavior is currently untested in piglit and not supported > on the GLX side. Before working on implementing it for EGL/DRI3, let's > disable it until support comes. > > This patch is trivial enough and will likely be squashed in the commit > egl/x11: Imp

Re: [Mesa-dev] [PATCH] mesa/copyimage: allow width/height to not be multiples of block

2015-11-10 Thread Ilia Mirkin
On Tue, Nov 10, 2015 at 5:18 PM, Ian Romanick wrote: > On 11/08/2015 01:50 AM, Ilia Mirkin wrote: >> For compressed textures, the image size is not necessarily a multiple of >> the block size (e.g. the last mip levels). For example the RGTC spec >> calls out this condition as legal, saying to erro

Re: [Mesa-dev] [PATCH 00/13] auxiliary/vl: winsys' galore

2015-11-10 Thread Alex Deucher
On Mon, Nov 9, 2015 at 8:31 AM, Emil Velikov wrote: > Hi all, > > Inspired by the resent interest in alternative vl winsys, I've decided > to rework the winsys into a traditional gallium fashion. > > Namely: add the destroy() and other functions into struct vl_screen. > This will allow users (stat

Re: [Mesa-dev] [Mesa-stable] [PATCH] meta/generate_mipmap: Don't leak the sampler object

2015-11-10 Thread Anuj Phogat
On Tue, Nov 10, 2015 at 2:20 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Cc: "10.6 11.0" > --- > src/mesa/drivers/common/meta_generate_mipmap.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/mesa/drivers/common/meta_generate_mipmap.c > b/src/

[Mesa-dev] [PATCH] meta/generate_mipmap: Don't leak the sampler object

2015-11-10 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Cc: "10.6 11.0" --- src/mesa/drivers/common/meta_generate_mipmap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/common/meta_generate_mipmap.c b/src/mesa/drivers/common/meta_generate_mipmap.c index 4800278..a9da0a2 100644

[Mesa-dev] [PATCH] nir/validate: Allow subroutine types for the tails of derefs

2015-11-10 Thread Jason Ekstrand
The shader-subroutine code creates uniforms of type SUBROUTINE for subroutines that are then read as integers in the backends. If we ever want to do any optimizations on these, we'll need to come up with a better plan where they are actual scalars or something, but this works for now. Bugzilla: h

Re: [Mesa-dev] [PATCH] mesa/copyimage: allow width/height to not be multiples of block

2015-11-10 Thread Ian Romanick
On 11/08/2015 01:50 AM, Ilia Mirkin wrote: > For compressed textures, the image size is not necessarily a multiple of > the block size (e.g. the last mip levels). For example the RGTC spec > calls out this condition as legal, saying to error only when: > > * is not a multiple of four, and pl

Re: [Mesa-dev] [PATCH v3 8/8] mesa: Enable EXT_blend_func_extended if the driver supports the ARB version

2015-11-10 Thread Ian Romanick
Once all the others are ready, this patch is also Reviewed-by: Ian Romanick On 11/05/2015 06:47 PM, Ryan Houdek wrote: > --- > docs/relnotes/11.1.0.html | 1 + > src/mesa/main/extensions.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.

Re: [Mesa-dev] [PATCH v3 2/8] glsl: Add required variables to _mesa_glsl_parse_state for EXT_blend_func_extended

2015-11-10 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 11/05/2015 06:47 PM, Ryan Houdek wrote: > This adds a state for the maximum dual source draw variables available > and the variable for determining if the extension has been enabled > in the program shaders. > --- > src/glsl/glsl_parser_extras.cpp | 3

Re: [Mesa-dev] [PATCH v3 1/8] glapi: Add EXT_blend_func_extended XML definitions

2015-11-10 Thread Ian Romanick
Okay... I see what happened. I thought it was weird that it added glBindFragDataLocationEXT to an ES3 context because GLES3 surely already has glBindFragDataLocation. It actually doesn't. The only way to set the fragment shader output location is using a layout qualifier in the shader. GLES gen

Re: [Mesa-dev] [PATCH] mesa/copyimage: allow width/height to not be multiples of block

2015-11-10 Thread Jason Ekstrand
LGTM as well Revewed-by: Jason Ekstrand On Tue, Nov 10, 2015 at 1:54 PM, Alex Deucher wrote: > On Sun, Nov 8, 2015 at 4:50 AM, Ilia Mirkin wrote: >> For compressed textures, the image size is not necessarily a multiple of >> the block size (e.g. the last mip levels). For example the RGTC spec

Re: [Mesa-dev] [PATCH] mesa/copyimage: allow width/height to not be multiples of block

2015-11-10 Thread Alex Deucher
On Sun, Nov 8, 2015 at 4:50 AM, Ilia Mirkin wrote: > For compressed textures, the image size is not necessarily a multiple of > the block size (e.g. the last mip levels). For example the RGTC spec > calls out this condition as legal, saying to error only when: > > * is not a multiple of four,

Re: [Mesa-dev] [PATCH 1/8] r600: geometry shader gsvs itemsize workaround

2015-11-10 Thread Marek Olšák
Patches 1,2,4: Reviewed-by: Marek Olšák I replied on 3 and 6. I'm not sure off hand about 5,7,8. Marek On Tue, Nov 10, 2015 at 5:10 AM, Dave Airlie wrote: > From: Dave Airlie > > On some chips the GSVS itemsize needs to be aligned to a cacheline size. > > This only applies to some of the r60

Re: [Mesa-dev] [PATCH] RFC: llvmpipe map scene buffers outside thread.

2015-11-10 Thread Jose Fonseca
On 09/11/15 03:58, Dave Airlie wrote: From: Dave Airlie There might be a reason we do this inside the thread, but I'm not aware of it yet, move stuff around and see if this jogs anyone's memory. It might be a relic from the time where we had swizzled tiles. Jose Doing this outside the thr

Re: [Mesa-dev] [PATCH 6/8] r600: SMX returns CONTEXT_DONE early workaround

2015-11-10 Thread Marek Olšák
On Tue, Nov 10, 2015 at 5:10 AM, Dave Airlie wrote: > From: Dave Airlie > > streamout, gs rings bug on certain r600s, requires a wait idle > before each surface sync. > > Signed-off-by: Dave Airlie > --- > src/gallium/drivers/r600/r600_hw_context.c | 4 > src/gallium/drivers/r600/r600_p

Re: [Mesa-dev] [PATCH V2 04/12] glsl: add layout qualifier validation to the ast for vars

2015-11-10 Thread Timothy Arceri
On Tue, 2015-11-10 at 12:21 +, Emil Velikov wrote: > Hi Tim, > > On 8 November 2015 at 22:34, Timothy Arceri wrote: > > From: Timothy Arceri > > > > This is in preparation for compile-time constant support, > > a later patch will remove validation from the parser. > > Thanks for splitting

Re: [Mesa-dev] [PATCH 3/8] r600: do SQ flush ES ring rolling workaround

2015-11-10 Thread Marek Olšák
On Tue, Nov 10, 2015 at 5:10 AM, Dave Airlie wrote: > From: Dave Airlie > > Need to insert a SQ_NON_EVENT when ever geometry > shaders are enabled. > > Signed-off-by: Dave Airlie > --- > src/gallium/drivers/r600/r600_hw_context.c | 5 + > src/gallium/drivers/r600/r600_pipe.h | 1 +

Re: [Mesa-dev] [PATCH V2 10/12] glsl: add support for complie-time constant expressions

2015-11-10 Thread Timothy Arceri
On Tue, 2015-11-10 at 13:43 +, Emil Velikov wrote: > Hi Tim, > > Mostly trivial suggestions, and one bug caught :-) > > On 8 November 2015 at 22:34, Timothy Arceri wrote: > > From: Timothy Arceri > > > > This patch replaces the old interger constant qualifiers with either > typo "integer"

Re: [Mesa-dev] [PATCH 2/3] st/mesa: implement ARB_clear_texture

2015-11-10 Thread Marek Olšák
Patches 1-2: Reviewed-by: Marek Olšák Marek On Mon, Nov 9, 2015 at 7:40 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/mesa/state_tracker/st_cb_texture.c | 29 + > src/mesa/state_tracker/st_extensions.c | 1 + > 2 files changed, 30 insertions(+)

Re: [Mesa-dev] Introducing OpenSWR: High performance software rasterizer

2015-11-10 Thread Roland Scheidegger
Am 10.11.2015 um 20:36 schrieb Rowley, Timothy O: > >> On Oct 22, 2015, at 4:17 PM, Jose Fonseca wrote: >> >> They do share a lot already, Mesa, gallium statetracker, and gallivm. If >> further development in openswr is planned, it might require to jump through >> a few hoops, but I think it's

Re: [Mesa-dev] [PATCH V2 08/12] glsl: add process_qualifier_constant() helper

2015-11-10 Thread Timothy Arceri
On Tue, 2015-11-10 at 13:46 +, Emil Velikov wrote: > On 8 November 2015 at 22:34, Timothy Arceri wrote: > > From: Timothy Arceri > > > > This helper is similar to the function added as part of the > > ast_layout_expression class but will be used when only the > > ast_expression type is requi

Re: [Mesa-dev] [PATCH V2 08/12] glsl: add process_qualifier_constant() helper

2015-11-10 Thread Timothy Arceri
On Tue, 2015-11-10 at 12:33 +, Emil Velikov wrote: > On 8 November 2015 at 22:34, Timothy Arceri wrote: > > From: Timothy Arceri > > > > This helper is similar to the function added as part of the > > ast_layout_expression class but will be used when only the > > ast_expression type is requi

Re: [Mesa-dev] [PATCH V2 07/12] glsl: add new type from compile time constants

2015-11-10 Thread Timothy Arceri
On Tue, 2015-11-10 at 12:33 +, Emil Velikov wrote: > Hi Tim, > > On 8 November 2015 at 22:34, Timothy Arceri wrote: > > From: Timothy Arceri > > > > In this patch we introduce a new ast type for holding the new > > compile-time constant expressions. The main reason for this is that > > we c

Re: [Mesa-dev] [PATCH 0/3] Fix racy full-vector writes for v[i].x

2015-11-10 Thread Kristian Høgsberg
On Mon, Nov 9, 2015 at 6:26 PM, Jason Ekstrand wrote: > On Mon, Nov 9, 2015 at 3:52 PM, Ian Romanick wrote: >> On 11/04/2015 03:55 PM, Jason Ekstrand wrote: >>> Here's some shader-db numbers: >>> >>> total instructions in shared programs: 6236146 -> 6255385 (0.31%) >>> instructions in affected p

Re: [Mesa-dev] [PATCH] i965: Map GL_PATCHES to 3DPRIM_PATCHLIST_n.

2015-11-10 Thread Kenneth Graunke
On Tuesday, November 10, 2015 08:41:22 AM Ian Romanick wrote: > On 11/10/2015 01:19 AM, Kenneth Graunke wrote: > > Inspired by a patch by Fabian Bieler. > > > > Fabian defined a _3DPRIM_PATCHLIST_0 macro (which isn't actually a valid > > topology type); I instead chose to make a macro that takes a

Re: [Mesa-dev] [PATCH 2/3] glsl: Lower UBO and SSBO access in glsl linker

2015-11-10 Thread Kristian Høgsberg
On Tue, Nov 10, 2015 at 12:09 AM, Iago Toral wrote: > On Mon, 2015-11-09 at 16:52 +0100, Iago Toral wrote: >> On Wed, 2015-11-04 at 15:33 -0800, Kristian Høgsberg Kristensen wrote: >> > All GLSL IR consumers run this lowering pass so we can move it to the >> > linker. This moves the pass up quite

Re: [Mesa-dev] [PATCH 04/10] i965/skl: skip fast clears for certain surface formats

2015-11-10 Thread Ben Widawsky
There is one thing I need a response on at the very bottom, the rest will be addressed in v2. Thanks. On Mon, Nov 09, 2015 at 11:33:17AM -0800, Chad Versace wrote: > On Tue 03 Nov 2015, Ben Widawsky wrote: > > On Fri, Oct 16, 2015 at 04:05:22PM -0700, Chad Versace wrote: > > > On Tue 13 Oct 2015,

Re: [Mesa-dev] Introducing OpenSWR: High performance software rasterizer

2015-11-10 Thread Rowley, Timothy O
> On Oct 22, 2015, at 4:17 PM, Jose Fonseca wrote: > > They do share a lot already, Mesa, gallium statetracker, and gallivm. If > further development in openswr is planned, it might require to jump through a > few hoops, but I think it's worth to figure out what would take to get this > merge

Re: [Mesa-dev] [PATCH] i965: Implement ARB_pipeline_statistics_query tessellation counters.

2015-11-10 Thread Kenneth Graunke
On Tuesday, November 10, 2015 08:33:51 AM Ben Widawsky wrote: > On Mon, Nov 09, 2015 at 11:59:43PM -0800, Kenneth Graunke wrote: > > We basically just need to uncomment Ben's code. > > > > Signed-off-by: Kenneth Graunke > > --- > > src/mesa/drivers/dri/i965/gen6_queryobj.c | 8 > > 1 fi

Re: [Mesa-dev] [RFCv2 06/13] mesa/st: add support for NIR as possible driver IR

2015-11-10 Thread Marek Olšák
On Tue, Nov 10, 2015 at 5:42 PM, Rob Clark wrote: > I think I'll end up moving st_glsl_to_nir (plus the fxns only called > from it) into a new file. But I think get_mesa_program_nir() and > get_mesa_program_tgsi() could end up sharing more common code like I > am doing w/ st_translate_xyz_program

Re: [Mesa-dev] [PATCH 16/23] meta: Don't pollute the buffer object namespace in _mesa_meta_setup_vertex_objects

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > tl;dr: For many types of GL object, we can *NEVER* use the Gen function. > > In OpenGL ES (all versions!) and OpenGL compatibility profile, > applications don't have to call Gen functions. The GL spec is very > clear ab

Re: [Mesa-dev] [PATCH 14/23] meta: Use DSA functions for VBOs in _mesa_meta_setup_vertex_objects

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > The fixed-function attribute paths don't get the DSA treatment because > there are no DSA entry-points for fixed-function attributes. These > could have been added, but this is a temporary patch intended to make > later

Re: [Mesa-dev] [PATCH 15/23] meta: Use internal functions for buffer object and VAO access

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/common/meta.c | 76 > -- > 1 file changed, 43 insertions(+), 33 deletions(-) > > diff --git a/src/mesa/drivers/common/meta.c

Re: [Mesa-dev] [PATCH 13/23] meta: Track VBO using gl_buffer_object instead of GL API object handle

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/common/meta.c| 69 > +++ > src/mesa/drivers/common/meta.h| 19 --- > src/mesa/drivers/common/meta_bl

Re: [Mesa-dev] [PATCH 12/23] meta: Don't leave the VBO bound after _mesa_meta_setup_vertex_objects

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Meta currently does this, but future changes will make this impossible. > Explicitly do it as a step in the patch series now to catch any possible > kinks. > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/commo

Re: [Mesa-dev] [PATCH 11/23] i965: Use _mesa_NamedBufferSubData for users of _mesa_meta_setup_vertex_objects

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c >

Re: [Mesa-dev] [PATCH 10/23] meta: Use _mesa_NamedBufferData and _mesa_NamedBufferSubData for users of _mesa_meta_setup_vertex_objects

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/common/meta.c | 12 +--- > src/mesa/drivers/common/meta_blit.c| 2 +- > src/mesa/drivers/common/meta_generate_mipmap.c | 4 ++--

Re: [Mesa-dev] [PATCH 0/7] DRI3 support for EGL (v4)

2015-11-10 Thread Axel Davy
Hi, I did take a look, and it looks good to me. I'm happy you implemented DRI_PRIME support as well. About it, do you need testers to check everything works ? A mistake about it I noticed is that you don't disable EGL_KHR_image_pixmap when is_different_gpu is set. It should be disabled, just li

[Mesa-dev] [PATCH] egl/x11/dri3: do not expose the preserved swap behavior (to be squashed)

2015-11-10 Thread Martin Peres
The preserved swap behavior is currently untested in piglit and not supported on the GLX side. Before working on implementing it for EGL/DRI3, let's disable it until support comes. This patch is trivial enough and will likely be squashed in the commit egl/x11: Implement dri3 support with loader's

Re: [Mesa-dev] [PATCH 4/7] i965/fs: Use image_format_info for doing image_load_store workarounds

2015-11-10 Thread Chad Versace
On Mon 09 Nov 2015, Jason Ekstrand wrote: > On Mon, Nov 9, 2015 at 2:24 PM, Chad Versace wrote: > > On Wed 04 Nov 2015, Jason Ekstrand wrote: > >> --- > >> .../drivers/dri/i965/brw_fs_surface_builder.cpp| 157 > >> ++--- > >> 1 file changed, 106 insertions(+), 51 deletions(-)

Re: [Mesa-dev] [PATCH 08/23] i965: Don't pollute the buffer object namespace in brw_meta_fast_clear

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > tl;dr: For many types of GL object, we can *NEVER* use the Gen function. > > In OpenGL ES (all versions!) and OpenGL compatibility profile, > applications don't have to call Gen functions. The GL spec is very > clear ab

Re: [Mesa-dev] [PATCH 09/23] meta: Use DSA functions for PBO in create_texture_for_pbo

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/common/meta_tex_subimage.c | 30 > +++-- > 1 file changed, 11 insertions(+), 19 deletions(-) > > diff --git a/src/mesa/drivers/common/meta_t

Re: [Mesa-dev] [PATCH 07/23] i965: Use internal functions for buffer object access

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Instead of going through the GL API implementation functions, use the > lower-level functions. This means that we have to keep track of a > pointer to the gl_buffer_object and the gl_vertex_array_object. > > This has tw

Re: [Mesa-dev] [PATCH 04/23] mesa: Refactor enable_vertex_array_attrib to make _mesa_enable_vertex_array_attrib

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Pulls the parts of enable_vertex_array_attrib that aren't just parameter > validation out into a function that can be called from other parts of > Mesa (e.g., meta). > > _mesa_enable_vertex_array_attrib can also be used

Re: [Mesa-dev] [PATCH 06/23] i965: Use DSA functions for VBOs in brw_meta_fast_clear

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c

Re: [Mesa-dev] [PATCH 05/23] i965: Pass brw_context instead of gl_context to brw_draw_rectlist

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Future patches will use the brw_context instead. Keeping this > non-functional change separate should make the function changes easier > to review. > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/dri/i965/brw

Re: [Mesa-dev] [PATCH 02/23] mesa: Make bind_vertex_buffer avilable outside varray.c

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/main/varray.c | 29 +++-- > src/mesa/main/varray.h | 7 +++ > 2 files changed, 22 insertions(+), 14 deletions(-) > > diff --git a/src/mesa/main/

Re: [Mesa-dev] [PATCH 03/23] mesa: Refactor update_array_format to make _mesa_update_array_format_public

2015-11-10 Thread Anuj Phogat
On Mon, Nov 9, 2015 at 4:56 PM, Ian Romanick wrote: > From: Ian Romanick > > Pulls the parts of update_array_format that aren't just parameter > validation out into a function that can be called from other parts of > Mesa (e.g., meta). > > Signed-off-by: Ian Romanick > --- > src/mesa/main/varra

Re: [Mesa-dev] [PATCH 3/3] i965/nir/opt_peephole_ffma: Bypass fusion if any operand of fadd and fmul is a const

2015-11-10 Thread Jason Ekstrand
On Tue, Nov 10, 2015 at 4:03 AM, Eduardo Lima Mitev wrote: > I realized that patch 1/2 hasn't been reviewed, and this one didn't get > R-b. Any objection to these two? Go ahead Reviewed-by: Jason Ekstrand > thanks, > Eduardo > > On 10/23/2015 05:55 PM, Eduardo Lima Mitev wrote: >> When both f

[Mesa-dev] [PATCH 4/7] egl/x11: Implement dri3 support with loader's dri3 helper

2015-11-10 Thread Martin Peres
From: Boyan Ding v2: From Martin Peres - Tell we are compiling the dri3 backend in configure.ac - Update the Makefile.am - get rid of the LIBDRM_HAS_RENDERNODE_SUPPORT macro - fix some warnings related to EGLuint64KHR to int64_t conversions - use dri2_get_dri_config to get the __DRIconfig in

[Mesa-dev] [PATCH 5/7] loader/dri3: Expose function to create __DRIimage from pixmap

2015-11-10 Thread Martin Peres
From: Boyan Ding Used to support EGL_KHR_image_pixmap. Signed-off-by: Boyan Ding Reviewed-by: Martin Peres Reviewed-by: Kristian Høgsberg --- src/loader/loader_dri3_helper.c | 78 ++--- src/loader/loader_dri3_helper.h | 9 + 2 files changed, 58 insert

[Mesa-dev] [PATCH 0/7] DRI3 support for EGL (v4)

2015-11-10 Thread Martin Peres
Here is an update to the v3, addressing almost all the comments I got during the previous round. The one item that is left to do is the handling of EGL_BUFFER_PRESERVED which will take some time since I need to write a piglit test for it.

[Mesa-dev] [PATCH 7/7] egl: make it clear which platform x11 backend is being used (dri2 or 3)

2015-11-10 Thread Martin Peres
Signed-off-by: Martin Peres Reviewed-by: Boyan Ding Reviewed-by: Kristian Høgsberg --- src/egl/drivers/dri2/egl_dri2.c | 6 +++--- src/egl/drivers/dri2/platform_x11.c | 6 +- src/egl/drivers/dri2/platform_x11_dri3.c | 10 +- 3 files changed, 13 insertions(+), 9 delet

[Mesa-dev] [PATCH 2/7] glx/dri3: Convert to use dri3 helper in loader library

2015-11-10 Thread Martin Peres
From: Boyan Ding v2: From Martin Peres - convert to the new drawable interface - delete dead code after the dropping of some vfuncs - delete the width and height attributes since they are found in the helper Signed-off-by: Boyan Ding Signed-off-by: Martin Peres Reviewed-by: Kristian Høgsber

[Mesa-dev] [PATCH 3/7] egl_dri2: Add a function to let platform code return dri drawable from _EGLSurface

2015-11-10 Thread Martin Peres
From: Boyan Ding dri3 for EGL will use different struct other than dri2_egl_surface for an EGL surface, the common code only uses __DRIdrawable from that struct, so instead of converting _EGLSurface to dri2_egl_surface, let the platform code return the __DRIdrawable by its own (although the curre

[Mesa-dev] [PATCH 1/7] loader: Add dri3 helper

2015-11-10 Thread Martin Peres
From: Boyan Ding v2: From Martin Peres - Try to fit in the 80-col limit as much as possible v3: From Martin Peres - introduce loader_dri3_helper.la to avoid dragging the xcb dep everywhere (Kristian & Emil) - get rid of the width, height, dri_screen and is_different_gpu vfuncs (Kristian) -

[Mesa-dev] [PATCH 6/7] egl/x11_dri3: Implement EGL_KHR_image_pixmap

2015-11-10 Thread Martin Peres
From: Boyan Ding v2: from Martin Peres - Replace a tab with spaces Signed-off-by: Boyan Ding Reviewed-by: Martin Peres Reviewed-by: Kristian Høgsberg --- src/egl/drivers/dri2/platform_x11.c | 1 + src/egl/drivers/dri2/platform_x11_dri3.c | 77 +++- 2 files

Re: [Mesa-dev] Potential spec change request for EXT_buffer_storage

2015-11-10 Thread Ian Romanick
On 11/09/2015 04:29 PM, Ilia Mirkin wrote: > On Mon, Nov 9, 2015 at 7:10 PM, Ian Romanick wrote: >> On 11/04/2015 03:26 PM, Ryan Houdek wrote: >>> I'm hoping to potentially convince about lowering the minimum >>> requirement of EXT_buffer_storage from ES 3.1 to ES 3.0. >>> The only thing that caus

Re: [Mesa-dev] Potential spec change request for EXT_buffer_storage

2015-11-10 Thread Ian Romanick
On 11/09/2015 04:10 PM, Ian Romanick wrote: > On 11/04/2015 03:26 PM, Ryan Houdek wrote: >> I'm hoping to potentially convince about lowering the minimum >> requirement of EXT_buffer_storage from ES 3.1 to ES 3.0. >> The only thing that causes it to require ES 3.1 is glMemoryBarrier, >> which shoul

Re: [Mesa-dev] Can't get OpenGL 3.x inside VMware Workstation 12 (Ubuntu guest)

2015-11-10 Thread Brian Paul
On 11/09/2015 09:24 PM, Valera Rozuvan wrote: On Tue, Nov 10, 2015 at 4:13 AM, Brian Paul wrote: After running depmod, you probably need to update the initramfs with: 'sudo update-initramfs -u' -Brian Hi Brian. First of all, thank you for your reply. I have tried your suggestion on my worki

Re: [Mesa-dev] [RFCv2 06/13] mesa/st: add support for NIR as possible driver IR

2015-11-10 Thread Rob Clark
I think I'll end up moving st_glsl_to_nir (plus the fxns only called from it) into a new file. But I think get_mesa_program_nir() and get_mesa_program_tgsi() could end up sharing more common code like I am doing w/ st_translate_xyz_program().. at least that is my current thinking.. BR, -R On Tue

Re: [Mesa-dev] [PATCH] i965: Map GL_PATCHES to 3DPRIM_PATCHLIST_n.

2015-11-10 Thread Ian Romanick
On 11/10/2015 01:19 AM, Kenneth Graunke wrote: > Inspired by a patch by Fabian Bieler. > > Fabian defined a _3DPRIM_PATCHLIST_0 macro (which isn't actually a valid > topology type); I instead chose to make a macro that takes an argument. > He also took the number of patch vertices from _mesa_prim

Re: [Mesa-dev] [RFCv2 06/13] mesa/st: add support for NIR as possible driver IR

2015-11-10 Thread Rob Clark
On Tue, Nov 10, 2015 at 10:59 AM, Connor Abbott wrote: > On Sun, Nov 8, 2015 at 3:12 PM, Rob Clark wrote: >> --- >> src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 410 >> - >> src/mesa/state_tracker/st_glsl_to_tgsi.h | 5 + >> src/mesa/state_tracker/st_program.c

Re: [Mesa-dev] [PATCH] i965: Implement ARB_pipeline_statistics_query tessellation counters.

2015-11-10 Thread Ben Widawsky
On Mon, Nov 09, 2015 at 11:59:43PM -0800, Kenneth Graunke wrote: > We basically just need to uncomment Ben's code. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/gen6_queryobj.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/drive

[Mesa-dev] [Bug 92869] OpenGL ES 3.0 context creation failure

2015-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92869 --- Comment #3 from Jose Fonseca --- I believe that there was a problem with xserver's glx/createcontext.c Ian mentioned on http://lists.freedesktop.org/archives/mesa-dev/2015-April/082010.html but it has been fixed http://lists.freedesk

Re: [Mesa-dev] [RFCv2 06/13] mesa/st: add support for NIR as possible driver IR

2015-11-10 Thread Connor Abbott
On Sun, Nov 8, 2015 at 3:12 PM, Rob Clark wrote: > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 410 > - > src/mesa/state_tracker/st_glsl_to_tgsi.h | 5 + > src/mesa/state_tracker/st_program.c| 118 +++-- > src/mesa/state_tracker/st_program.h

Re: [Mesa-dev] [RFCv2 01/13] gallium: refactor pipe_shader_state to support multiple IR's

2015-11-10 Thread Roland Scheidegger
Am 10.11.2015 um 15:41 schrieb Rob Clark: > On Tue, Nov 10, 2015 at 7:24 AM, Marek Olšák wrote: >>> +/** >>> + * The 'ir' parameter identifies whether the shader state contains TGSI >>> + * tokens, etc. If the driver returns 'PIPE_SHADER_IR_TGSI' for the >>> + * 'PIPE_SHADER_CAP_PREFERRED_IR' sha

Re: [Mesa-dev] [RFCv2 06/13] mesa/st: add support for NIR as possible driver IR

2015-11-10 Thread Marek Olšák
In my opinion, glsl_to_nir should be in its own file and independent of glsl_to_tgsi. Marek On Sun, Nov 8, 2015 at 9:12 PM, Rob Clark wrote: > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 410 > - > src/mesa/state_tracker/st_glsl_to_tgsi.h | 5 + > src/mes

Re: [Mesa-dev] [RFCv2 01/13] gallium: refactor pipe_shader_state to support multiple IR's

2015-11-10 Thread Brian Paul
On 11/08/2015 01:12 PM, Rob Clark wrote: The goal is to allow the pipe driver to request something other than TGSI, but detect whether what is getting is TGSI vs what it requested. The pipe drivers will always have to support TGSI (and convert that into whatever it is that they prefer), but in so

Re: [Mesa-dev] [PATCH] nouveau: fix double free when screen_create fails

2015-11-10 Thread Emil Velikov
Hi Samuel, Sorry about this I thought I already replied :-\ On 29 October 2015 at 22:22, Samuel Pitoiset wrote: > On 10/27/2015 02:01 PM, samuel.pitoiset wrote: >> On 27/10/2015 12:52, Emil Velikov wrote: >>> >>> On 27 October 2015 at 10:50, samuel.pitoiset >>> wrote: On 27/10/2015 11

Re: [Mesa-dev] [PATCH v3] gallium/hud: control visibility at startup and runtime.

2015-11-10 Thread Brian Paul
On 11/09/2015 10:20 PM, Jimmy Berry wrote: On Mon, Nov 9, 2015 at 11:28 AM, Brian Paul wrote: On 11/07/2015 09:05 PM, Jimmy Berry wrote: - env GALLIUM_HUD_VISIBLE: control default visibility - env GALLIUM_HUD_SIGNAL_TOGGLE: toggle visibility via signal --- docs/envvars.html

Re: [Mesa-dev] [RFCv2 01/13] gallium: refactor pipe_shader_state to support multiple IR's

2015-11-10 Thread Rob Clark
On Tue, Nov 10, 2015 at 7:24 AM, Marek Olšák wrote: >> +/** >> + * The 'ir' parameter identifies whether the shader state contains TGSI >> + * tokens, etc. If the driver returns 'PIPE_SHADER_IR_TGSI' for the >> + * 'PIPE_SHADER_CAP_PREFERRED_IR' shader param, the ir will *always* be >> + * 'PIPE_

Re: [Mesa-dev] [PATCH V2 11/12] glsl: add subroutine index qualifier support

2015-11-10 Thread Emil Velikov
On 8 November 2015 at 22:34, Timothy Arceri wrote: > From: Timothy Arceri > > ARB_explicit_uniform_location allows the index for subroutine functions > to be explicitly set in the shader. > > This patch reduces the restriction on the index qualifier in > validate_layout_qualifiers() to allow it t

Re: [Mesa-dev] [PATCH V2 08/12] glsl: add process_qualifier_constant() helper

2015-11-10 Thread Emil Velikov
On 8 November 2015 at 22:34, Timothy Arceri wrote: > From: Timothy Arceri > > This helper is similar to the function added as part of the > ast_layout_expression class but will be used when only the > ast_expression type is required for the qualifier. > > ast_expression is used if qualifier can't

Re: [Mesa-dev] [PATCH V2 10/12] glsl: add support for complie-time constant expressions

2015-11-10 Thread Emil Velikov
Hi Tim, Mostly trivial suggestions, and one bug caught :-) On 8 November 2015 at 22:34, Timothy Arceri wrote: > From: Timothy Arceri > > This patch replaces the old interger constant qualifiers with either typo "integer" > the new ast_layout_expression type if the qualifier requires merging > o

Re: [Mesa-dev] [PATCH V2 08/12] glsl: add process_qualifier_constant() helper

2015-11-10 Thread Emil Velikov
On 8 November 2015 at 22:34, Timothy Arceri wrote: > From: Timothy Arceri > > This helper is similar to the function added as part of the > ast_layout_expression class but will be used when only the > ast_expression type is required for the qualifier. > > ast_expression is used if qualifier can't

Re: [Mesa-dev] [PATCH V2 07/12] glsl: add new type from compile time constants

2015-11-10 Thread Emil Velikov
Hi Tim, On 8 November 2015 at 22:34, Timothy Arceri wrote: > From: Timothy Arceri > > In this patch we introduce a new ast type for holding the new > compile-time constant expressions. The main reason for this is that > we can no longer do merging of layout qualifiers before they have been > con

Re: [Mesa-dev] [PATCH V2 06/12] glsl: remove layout qualifier validation from the parser

2015-11-10 Thread Emil Velikov
On 8 November 2015 at 22:34, Timothy Arceri wrote: > From: Timothy Arceri > > Now that we have added validation elsewhere we can remove it from > the parser. Despite the comments that cover the last few patches (04-06 incl.) these look functionally correct, and if others disagree with my suggesti

Re: [Mesa-dev] [PATCH V2 05/12] glsl: add layout qualifier validation for the shader outside the parser

2015-11-10 Thread Emil Velikov
Hi Tim, On 8 November 2015 at 22:34, Timothy Arceri wrote: > From: Timothy Arceri > > This is in preparation for compile-time constant support, a later patch > will remove the validation from the shader. > > The global shader layout qualifiers will now mostly be validated in > glsl_parser_extras

Re: [Mesa-dev] [RFCv2 02/13] gallium: add NIR as a possible IR

2015-11-10 Thread Marek Olšák
On Sun, Nov 8, 2015 at 9:12 PM, Rob Clark wrote: > --- > src/gallium/include/pipe/p_defines.h | 1 + > src/gallium/include/pipe/p_state.h | 7 +++ > 2 files changed, 8 insertions(+) > > diff --git a/src/gallium/include/pipe/p_defines.h > b/src/gallium/include/pipe/p_defines.h > index 0a9d9

  1   2   >