Re: [Mesa-dev] [PATCH] nouveau: avoid queueing too much work onto a single fence

2015-11-05 Thread Ilia Mirkin
On Fri, Nov 6, 2015 at 1:27 AM, Jan Vesely wrote: > On Fri, 2015-11-06 at 00:46 -0500, Ilia Mirkin wrote: >> Force the fence to get kicked off, which won't actually wait for its >> completion, but any additional work will be put onto a fresh list. >> >> This fixes crashes in teximage-colors --benc

Re: [Mesa-dev] [PATCH] nouveau: avoid queueing too much work onto a single fence

2015-11-05 Thread Jan Vesely
On Fri, 2015-11-06 at 00:46 -0500, Ilia Mirkin wrote: > Force the fence to get kicked off, which won't actually wait for its > completion, but any additional work will be put onto a fresh list. > > This fixes crashes in teximage-colors --benchmark with too many > active > maps. > > Signed-off-by:

Re: [Mesa-dev] [PATCH v4 5/7] glsl: Add precision information to ir_variable

2015-11-05 Thread Tapani Pälli
On 11/05/2015 03:13 PM, Tapani Pälli wrote: From: Iago Toral Quiroga We will need this later on when we implement proper support for precision qualifiers in the drivers and also to do link time checks for uniforms as indicated by the spec. This patch also adds compile-time checks for variable

[Mesa-dev] [PATCH] i965: Split nir_emit_intrinsic by stage with a general fallback.

2015-11-05 Thread Kenneth Graunke
Many intrinsics only apply to a particular stage (such as discard). In other cases, we may want to interpret them differently based on the stage (such as load_primitive_id or load_input). The current method isn't that pretty - we handle all intrinsics in one giant function. Sometimes we assert on

[Mesa-dev] [PATCH] nouveau: avoid queueing too much work onto a single fence

2015-11-05 Thread Ilia Mirkin
Force the fence to get kicked off, which won't actually wait for its completion, but any additional work will be put onto a fresh list. This fixes crashes in teximage-colors --benchmark with too many active maps. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nouveau_fence.c | 68 ++

[Mesa-dev] [PATCH v2 2/3] glsl: Lower UBO and SSBO access in glsl linker

2015-11-05 Thread Kristian Høgsberg Kristensen
All GLSL IR consumers run this lowering pass so we can move it to the linker. This moves the pass up quite a bit, but that's the point: it needs to run before we throw away information about per-component vector access. Signed-off-by: Kristian Høgsberg Kristensen --- src/glsl/linker.cpp

[Mesa-dev] [PATCH v2 0/3] Lower UBO/SSBO access early

2015-11-05 Thread Kristian Høgsberg Kristensen
Here's v2 of the series I sent out yesterday. Nothing changed in what we're trying to do, but I figured out the shader-db regression. I used ir_type_variable instead of ir_type_dereference_variable when trying to make opt_dead_code_local not stomp on my vector array deref lvalue. As a result, the

[Mesa-dev] [PATCH v2 1/3] glsl: Drop exec_list argument to lower_ubo_reference

2015-11-05 Thread Kristian Høgsberg Kristensen
We always pass in shader->ir and we already pass in the shader, so just drop the exec_list. Most passes either take just a exec_list or a shader, so this seems more consistent. Reviewed-by: Timothy Arceri Signed-off-by: Kristian Høgsberg Kristensen --- src/glsl/ir_optimization.h

[Mesa-dev] [PATCH v2 3/3] glsl: Use array deref for access to vector components

2015-11-05 Thread Kristian Høgsberg Kristensen
We've assumed that we could lower per-component vector access from vec[i] = scalar to vec = ir_triop_vector_insert(vec, scalar, i) but with SSBOs (and compute shader SLM and tesselation outputs) this is no longer valid. If a vector is "externally visible", multiple threads can write indepen

Re: [Mesa-dev] [PATCH 2/3] glsl: Lower UBO and SSBO access in glsl linker

2015-11-05 Thread Kristian Høgsberg
On Thu, Nov 5, 2015 at 5:39 PM, Timothy Arceri wrote: > On Wed, 2015-11-04 at 15:33 -0800, Kristian Høgsberg Kristensen wrote: >> All GLSL IR consumers run this lowering pass so we can move it to the >> linker. This moves the pass up quite a bit, but that's the point: it >> needs to run before we

[Mesa-dev] [PATCH] android: fix LOCAL_C_INCLUDES to find glsl_types.h

2015-11-05 Thread Mauro Rossi
These changes are necessary to avoid building errors in glsl and i965 --- src/glsl/Android.mk | 6 -- src/mesa/drivers/dri/i965/Android.mk | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/glsl/Android.mk b/src/glsl/Android.mk index f63b7da..6902ea4 1

Re: [Mesa-dev] [PATCH 4/4] st/omx: add headless support

2015-11-05 Thread Liu, Leo
>-Original Message- >From: Emil Velikov [mailto:emil.l.veli...@gmail.com] >Sent: Thursday, November 05, 2015 6:30 PM >To: Liu, Leo >Cc: ML mesa-dev >Subject: Re: [Mesa-dev] [PATCH 4/4] st/omx: add headless support > >On 5 November 2015 at 18:47, Leo Liu wrote: >> This will allow dec/enc/

Re: [Mesa-dev] [PATCH] st/va: add mpeg4 startcode workaround

2015-11-05 Thread Liu, Leo
+Boyuan, forgot to Cc him when I sent. Regards, Leo >-Original Message- >From: Emil Velikov [mailto:emil.l.veli...@gmail.com] >Sent: Thursday, November 05, 2015 7:00 PM >To: Liu, Leo >Cc: ML mesa-dev >Subject: Re: [Mesa-dev] [PATCH] st/va: add mpeg4 startcode workaround > >On 5 November

[Mesa-dev] [PATCH 2/2] gbm: Add flags to enable creation of rotated scanout buffers (v3)

2015-11-05 Thread Vivek Kasireddy
For certain platforms that support rotated scanout buffers, currently, there is no way to create them with the GBM DRI interface. These flags will instruct the DRI driver to create the buffer by setting additional requirements such as tiling mode. v2: Reserve a bit per angle. (Ville and Michel) v

[Mesa-dev] [PATCH 1/2] dri_interface: Introduce __DRI_IMAGE_USE_SCANOUT_ROTATION_* flags

2015-11-05 Thread Vivek Kasireddy
These flags can be used by the DRI driver to set additional requirements such as tiling while creating buffers. Cc: Michel Danzer Signed-off-by: Vivek Kasireddy --- include/GL/internal/dri_interface.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/GL/internal/dri_interface.h b/

Re: [Mesa-dev] [PATCH v3 0/8] Implement support for EXT_blend_func_extended

2015-11-05 Thread Ilia Mirkin
On Thu, Nov 5, 2015 at 9:47 PM, Ryan Houdek wrote: > This implements support for a very new extension to ES, which allows you > to do dual source blending just like in desktop OpenGL. > This works with the piglits that I am writing that just need to be cleaned > before they are pushed, and it also

Re: [Mesa-dev] [PATCH] gbm: Add a flag to enable creation of rotated scanout buffers (v2)

2015-11-05 Thread Vivek Kasireddy
On Thu, 5 Nov 2015 15:34:27 +0900 Michel Dänzer wrote: > On 05.11.2015 11:32, Vivek Kasireddy wrote: > > For certain platforms that support rotated scanout buffers, > > currently, there is no way to create them with the GBM DRI > > interface. This flag will instruct the DRI driver to create the >

[Mesa-dev] [PATCH v3 1/8] glapi: Add EXT_blend_func_extended XML definitions

2015-11-05 Thread Ryan Houdek
--- src/mapi/glapi/gen/EXT_gpu_shader4.xml | 3 ++- src/mapi/glapi/gen/es_EXT.xml | 26 ++ src/mesa/main/tests/dispatch_sanity.cpp | 8 3 files changed, 36 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/EXT_gpu_shader4.xml b/src/mapi/gl

[Mesa-dev] [PATCH v3 7/8] mesa: Allow MAX_DUAL_SOURCE_DRAW_BUFFERS to be available to ES

2015-11-05 Thread Ryan Houdek
--- src/mesa/main/get_hash_params.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py index fbc7b8f..9b22b91 100644 --- a/src/mesa/main/get_hash_params.py +++ b/src/mesa/main/get_hash_params.py @@ -330,6 +330

[Mesa-dev] [PATCH v3 0/8] Implement support for EXT_blend_func_extended

2015-11-05 Thread Ryan Houdek
This implements support for a very new extension to ES, which allows you to do dual source blending just like in desktop OpenGL. This works with the piglits that I am writing that just need to be cleaned before they are pushed, and it also works fantastically with the Dolphin emulator (Only known a

[Mesa-dev] [PATCH v3 3/8] glsl: Add support for the new builtins that EXT_blend_func_extended provides.

2015-11-05 Thread Ryan Houdek
gl_MaxDualSourceDrawBuffersEXT - Maximum DS draw buffers supported Only for ESSL 1.0 it provides two builtins since you can't have user-defined color output variables gl_SecondaryFragColorEXT and gl_SecondaryFragDataEXT[MaxDSDrawBuffers] --- src/glsl/ast_to_hir.cpp| 16 +++ src/gl

[Mesa-dev] [PATCH v3 4/8] glsl: Add GL_EXT_blend_func_extended preprocessor define

2015-11-05 Thread Ryan Houdek
--- src/glsl/glcpp/glcpp-parse.y | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index 4acccf7..10bf83f 100644 --- a/src/glsl/glcpp/glcpp-parse.y +++ b/src/glsl/glcpp/glcpp-parse.y @@ -2384,6 +2384,8 @@ _glcpp_parser_handle_version_

[Mesa-dev] [PATCH v3 6/8] mesa: Enable usage of blend_func_extended blend factors

2015-11-05 Thread Ryan Houdek
--- src/mesa/main/blend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index 20aa498..185e30e 100644 --- a/src/mesa/main/blend.c +++ b/src/mesa/main/blend.c @@ -67,7 +67,7 @@ legal_src_factor(const struct gl_context *ctx, GLe

[Mesa-dev] [PATCH v3 8/8] mesa: Enable EXT_blend_func_extended if the driver supports the ARB version

2015-11-05 Thread Ryan Houdek
--- docs/relnotes/11.1.0.html | 1 + src/mesa/main/extensions.c | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.1.0.html index c35d91f..5c2e530 100644 --- a/docs/relnotes/11.1.0.html +++ b/docs/relnotes/11.1.0.html @@ -56,6 +56,7 @@ Note: some of

[Mesa-dev] [PATCH v3 5/8] glsl: Add a parse check to check for the index layout qualifier

2015-11-05 Thread Ryan Houdek
This can only be used if EXT_blend_func_extended is enabled --- src/glsl/glsl_parser.yy | 5 + 1 file changed, 5 insertions(+) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index 4636435..40e60e5 100644 --- a/src/glsl/glsl_parser.yy +++ b/src/glsl/glsl_parser.yy @@ -1463,6 +1

[Mesa-dev] [PATCH v3 2/8] glsl: Add required variables to _mesa_glsl_parse_state for EXT_blend_func_extended

2015-11-05 Thread Ryan Houdek
This adds a state for the maximum dual source draw variables available and the variable for determining if the extension has been enabled in the program shaders. --- src/glsl/glsl_parser_extras.cpp | 3 +++ src/glsl/glsl_parser_extras.h | 5 + 2 files changed, 8 insertions(+) diff --git a/s

Re: [Mesa-dev] ARB_enhanced_layout compile-time-constants

2015-11-05 Thread Timothy Arceri
On Thu, 2015-11-05 at 22:17 +1100, Timothy Arceri wrote: > This series adds support for compile time constants and also adds > subroutine index qualifier support which was missing for > ARB_explicit_uniform_location > it doesn't add the missing subroutine location qualifier I'll add that in > a fol

[Mesa-dev] [PATCH v2 5/7] mesa: Enable usage of blend_func_extended blend factors

2015-11-05 Thread Ryan Houdek
--- src/mesa/main/blend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index 20aa498..185e30e 100644 --- a/src/mesa/main/blend.c +++ b/src/mesa/main/blend.c @@ -67,7 +67,7 @@ legal_src_factor(const struct gl_context *ctx, GLe

[Mesa-dev] [PATCH v2 2/7] glsl: Add required variables to _mesa_glsl_parse_state for EXT_blend_func_extended

2015-11-05 Thread Ryan Houdek
This adds a state for the maximum dual source draw variables available and the variable for determining if the extension has been enabled in the program shaders. --- src/glsl/glsl_parser_extras.cpp | 3 +++ src/glsl/glsl_parser_extras.h | 5 + 2 files changed, 8 insertions(+) diff --git a/s

[Mesa-dev] [PATCH v2 4/7] glsl: Add a parse check to check for the index layout qualifier

2015-11-05 Thread Ryan Houdek
This can only be used if EXT_blend_func_extended is enabled --- src/glsl/glsl_parser.yy | 5 + 1 file changed, 5 insertions(+) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index 4636435..40e60e5 100644 --- a/src/glsl/glsl_parser.yy +++ b/src/glsl/glsl_parser.yy @@ -1463,6 +1

[Mesa-dev] [PATCH v2 6/7] mesa: Allow MAX_DUAL_SOURCE_DRAW_BUFFERS to be available to ES

2015-11-05 Thread Ryan Houdek
--- src/mesa/main/get_hash_params.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py index fbc7b8f..9b22b91 100644 --- a/src/mesa/main/get_hash_params.py +++ b/src/mesa/main/get_hash_params.py @@ -330,6 +330

[Mesa-dev] [PATCH v2 0/8] Implement support for EXT_blend_func_extended

2015-11-05 Thread Ryan Houdek
This implements support for a very new extension to ES, which allows you to do dual source blending just like in desktop OpenGL. This works with the piglits that I am writing that just need to be cleaned before they are pushed, and it also works fantastically with the Dolphin emulator (Only known a

[Mesa-dev] [PATCH v2 7/7] mesa: Enable EXT_blend_func_extended if the driver supports the ARB version

2015-11-05 Thread Ryan Houdek
--- docs/relnotes/11.1.0.html | 1 + src/mesa/main/extensions.c | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.1.0.html index c35d91f..5c2e530 100644 --- a/docs/relnotes/11.1.0.html +++ b/docs/relnotes/11.1.0.html @@ -56,6 +56,7 @@ Note: some of

[Mesa-dev] [PATCH v2 3/7] glsl: Add support for the new builtins that EXT_blend_func_extended provides.

2015-11-05 Thread Ryan Houdek
gl_MaxDualSourceDrawBuffersEXT - Maximum DS draw buffers supported Only for ESSL 1.0 it provides two builtins since you can't have user-defined color output variables gl_SecondaryFragColorEXT and gl_SecondaryFragDataEXT[MaxDSDrawBuffers] --- src/glsl/ast_to_hir.cpp| 16 +++ src/gl

[Mesa-dev] [PATCH v2 1/7] glapi: Add EXT_blend_func_extended XML definitions

2015-11-05 Thread Ryan Houdek
--- src/mapi/glapi/gen/EXT_gpu_shader4.xml | 3 ++- src/mapi/glapi/gen/es_EXT.xml | 26 ++ src/mesa/main/tests/dispatch_sanity.cpp | 8 3 files changed, 36 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/EXT_gpu_shader4.xml b/src/mapi/gl

Re: [Mesa-dev] [PATCH 2/3] glsl: Lower UBO and SSBO access in glsl linker

2015-11-05 Thread Timothy Arceri
On Wed, 2015-11-04 at 15:33 -0800, Kristian Høgsberg Kristensen wrote: > All GLSL IR consumers run this lowering pass so we can move it to the > linker. This moves the pass up quite a bit, but that's the point: it > needs to run before we throw away information about per-component vector > access.

[Mesa-dev] [Bug 92840] New account request

2015-11-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92840 Brian Paul changed: What|Removed |Added Component|Other |New Accounts Version|git

Re: [Mesa-dev] [PATCH 6/7] nir: add shader reference counting

2015-11-05 Thread Rob Clark
On Thu, Nov 5, 2015 at 7:24 PM, Kenneth Graunke wrote: > On Saturday, October 24, 2015 01:07:59 PM Rob Clark wrote: >> From: Rob Clark >> >> For gallium, at least, we'll need this to manage shader's lifetimes, >> since in some cases both the driver and the state tracker will need >> to hold on to

Re: [Mesa-dev] [PATCH 6/7] nir: add shader reference counting

2015-11-05 Thread Rob Clark
On Thu, Nov 5, 2015 at 5:58 PM, Jason Ekstrand wrote: > On Thu, Nov 5, 2015 at 10:53 AM, Rob Clark wrote: >> On Thu, Nov 5, 2015 at 1:13 PM, Jason Ekstrand wrote: >>> On Sat, Oct 24, 2015 at 10:07 AM, Rob Clark wrote: From: Rob Clark For gallium, at least, we'll need this to man

Re: [Mesa-dev] [PATCH 6/7] nir: add shader reference counting

2015-11-05 Thread Kenneth Graunke
On Saturday, October 24, 2015 01:07:59 PM Rob Clark wrote: > From: Rob Clark > > For gallium, at least, we'll need this to manage shader's lifetimes, > since in some cases both the driver and the state tracker will need > to hold on to a reference for variant managing. > > Use nir_shader_mutable

[Mesa-dev] [RFC PATCH] main/tests: add inverse lookup test

2015-11-05 Thread Emil Velikov
Seems that we've been forgetting to update this test, leading to decreased usefulness. Thus lets add a test which walks over the mesa generated enums and checks the string (if non "0x" prefixed) against the local table. Signed-off-by: Emil Velikov --- I'm not 100% sure on the purpose of this tes

Re: [Mesa-dev] [PATCH] st/va: add mpeg4 startcode workaround

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 21:00, Leo Liu wrote: > From: Boyuan Zhang > > Signed-off-by: Boyuan Zhang > Reviewed-by: Christian König > --- > src/gallium/state_trackers/va/buffer.c | 24 +- > src/gallium/state_trackers/va/context.c| 7 ++ > src/gallium/state_trackers/va/picture.c|

Re: [Mesa-dev] [PATCH] nvc0: enable compute support on Fermi

2015-11-05 Thread Samuel Pitoiset
On 11/06/2015 12:43 AM, Ilia Mirkin wrote: On Thu, Nov 5, 2015 at 6:41 PM, Samuel Pitoiset wrote: Altough the compute support is still not complete because textures and surfaces need to be implemented, it allows to launch very simple compute kernel like one which reads reading MP performance

Re: [Mesa-dev] [PATCH] nvc0: enable compute support on Fermi

2015-11-05 Thread Ilia Mirkin
On Thu, Nov 5, 2015 at 6:41 PM, Samuel Pitoiset wrote: > Altough the compute support is still not complete because textures and > surfaces need to be implemented, it allows to launch very simple compute > kernel like one which reads reading MP performance counters. Didn't those end up breaking 3d

[Mesa-dev] [PATCH] nvc0: enable compute support on Fermi

2015-11-05 Thread Samuel Pitoiset
Altough the compute support is still not complete because textures and surfaces need to be implemented, it allows to launch very simple compute kernel like one which reads reading MP performance counters. This turns on PIPE_CAP_COMPUTE and PIPE_SHADER_COMPUTE. Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [Bug 92840] New account request

2015-11-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92840 --- Comment #1 from Emil Velikov --- Fwiw I'm in favour of giving Julien commit access to mesa. He's doing some swell job on the vaapi side of things. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assig

Re: [Mesa-dev] [PATCH 0/4] st/va: indent, leak fix and RGBx/BGRx for vpp

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 23:13, Julien Isorce wrote: > On 5 November 2015 at 14:22, Christian König > wrote: >> >> Patches #1-#3 are Reviewed-by: Christian König >> >> Please split patch #4 in two with first adding the new vl_video_buffer >> formats and then using them in the state tracker. > > > M

Re: [Mesa-dev] [PATCH 4/4] st/omx: add headless support

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 18:47, Leo Liu wrote: > This will allow dec/enc/transcode without X > Are we talking about multi GPU setup where X is running on one, and OMX on another, or a true "without X" case ? I'm leaning that the latter isn't really possible, yet. > Signed-off-by: Leo Liu > --- > s

Re: [Mesa-dev] [PATCH 0/4] st/va: indent, leak fix and RGBx/BGRx for vpp

2015-11-05 Thread Julien Isorce
On 5 November 2015 at 14:22, Christian König wrote: > Patches #1-#3 are Reviewed-by: Christian König > > Please split patch #4 in two with first adding the new vl_video_buffer > formats and then using them in the state tracker. > Makes sense, I'll split it. > > Should I commit that for you as

Re: [Mesa-dev] [PATCH 2/4] vl: add drm support for vl_screen

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 19:43, Christian König wrote: >> >> +/** >> + * >> + * Copyright 2009 Younes Manton. >> + * All Rights Reserved. > > You probably want to change the copyright here. > Heh considering that 90% of the follo

Re: [Mesa-dev] [PATCH 4/4] st/va: add support for RGBX and BGRX in VPP

2015-11-05 Thread Julien Isorce
On 5 November 2015 at 16:27, Emil Velikov wrote: > Hi Julien, > > On 5 November 2015 at 08:24, Julien Isorce > wrote: > > Before it was only possible to convert a NV12 surface to > > RGBA or BGRA. This patch uses the same post processing > > function, "handleVAProcPipelineParameterBufferType", b

Re: [Mesa-dev] [PATCH 3/4] st/va: properly indent buffer.c, config.c, image.c and picture.c

2015-11-05 Thread Julien Isorce
On 5 November 2015 at 16:28, Emil Velikov wrote: > On 5 November 2015 at 08:24, Julien Isorce > wrote: > > Some lines were using 4 indentation spaces instead of 3. > > > > The switch in vlVaAcquireBufferHandle actually had wrong brackets > > surrounding case+default. > > > Please don't mix white

[Mesa-dev] [Bug 92840] New account request

2015-11-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92840 Bug ID: 92840 Summary: New account request Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium

Re: [Mesa-dev] [PATCH 6/7] nir: add shader reference counting

2015-11-05 Thread Jason Ekstrand
On Thu, Nov 5, 2015 at 10:53 AM, Rob Clark wrote: > On Thu, Nov 5, 2015 at 1:13 PM, Jason Ekstrand wrote: >> On Sat, Oct 24, 2015 at 10:07 AM, Rob Clark wrote: >>> From: Rob Clark >>> >>> For gallium, at least, we'll need this to manage shader's lifetimes, >>> since in some cases both the drive

Re: [Mesa-dev] [PATCH 13/13] i965/fs_visitor: do not explicitly set outputs[x].file

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 22:06, Matt Turner wrote: > On Thu, Nov 5, 2015 at 12:24 PM, Emil Velikov > wrote: >> On 5 November 2015 at 19:15, Matt Turner wrote: >>> On Thu, Nov 5, 2015 at 8:18 AM, Emil Velikov >>> wrote: From: Emil Velikov This commits partially reverts "i965: Init

Re: [Mesa-dev] [PATCH 07/24] i965: Use immediate storage in inherited brw_reg.

2015-11-05 Thread Kenneth Graunke
On Monday, November 02, 2015 04:29:17 PM Matt Turner wrote: [snip] > @@ -362,8 +362,10 @@ src_reg::equals(const src_reg &r) const > abs == r.abs && > swizzle == r.swizzle && > !reladdr && !r.reladdr && > -memcmp(&fixed_hw_reg, &r.fixed_hw_reg, > - si

Re: [Mesa-dev] [PATCH 08/13] i965: do not memcmp to check if brw_regs are equal

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 16:17, Emil Velikov wrote: > From: Emil Velikov > > As of last commit one can easily the whole brw_reg as two unsigned The about above should read "... one can easily _access_ the whole..." -Emil ___ mesa-dev mailing list mesa-dev

Re: [Mesa-dev] [PATCH 06/24] i965: Add and use enum brw_reg_file.

2015-11-05 Thread Kenneth Graunke
On Monday, November 02, 2015 04:29:16 PM Matt Turner wrote: [snip] > diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp > b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp > index e980003..ed3e335 100644 > --- a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp > +++ b/src/mesa/drivers/dri/i9

Re: [Mesa-dev] [PATCH 13/13] i965/fs_visitor: do not explicitly set outputs[x].file

2015-11-05 Thread Matt Turner
On Thu, Nov 5, 2015 at 12:24 PM, Emil Velikov wrote: > On 5 November 2015 at 19:15, Matt Turner wrote: >> On Thu, Nov 5, 2015 at 8:18 AM, Emil Velikov >> wrote: >>> From: Emil Velikov >>> >>> This commits partially reverts "i965: Initialize registers' file to >>> BAD_FILE." >>> >>> No longer n

[Mesa-dev] [PATCH] st/va: add mpeg4 startcode workaround

2015-11-05 Thread Leo Liu
From: Boyuan Zhang Signed-off-by: Boyuan Zhang Reviewed-by: Christian König --- src/gallium/state_trackers/va/buffer.c | 24 +- src/gallium/state_trackers/va/context.c| 7 ++ src/gallium/state_trackers/va/picture.c| 117 + src/gallium/state_tracke

Re: [Mesa-dev] [PATCH 05/13] i965/vec4: one dst_reg() constructor less

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 19:04, Matt Turner wrote: > On Thu, Nov 5, 2015 at 8:17 AM, Emil Velikov wrote: >> From: Emil Velikov >> >> Just fold the brw_type_for_base_type() and use a delegated >> constructor. >> >> Note this is a c++11 feature and the compiler will warn us if it's >> set/defaults to

Re: [Mesa-dev] [PATCH 13/13] i965/fs_visitor: do not explicitly set outputs[x].file

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 19:15, Matt Turner wrote: > On Thu, Nov 5, 2015 at 8:18 AM, Emil Velikov wrote: >> From: Emil Velikov >> >> This commits partially reverts "i965: Initialize registers' file to >> BAD_FILE." >> >> No longer needed as of commit "i965/fs: properly construct fs_reg" which >> re

[Mesa-dev] [PATCHv2] mesa: use the correct string for the ES GL_KHR_debug functions

2015-11-05 Thread Emil Velikov
As defined in the spec when implemented in an OpenGL ES context, all entry points defined by this extension must have a "KHR" suffix. Signed-off-by: Emil Velikov --- Actually build tested this time. src/mesa/main/errors.c | 40 --- src/mesa/mai

[Mesa-dev] [PATCH] mesa: use the correct string for the ES GL_KHR_debug functions

2015-11-05 Thread Emil Velikov
As defined in the spec when implemented in an OpenGL ES context, all entry points defined by this extension must have a "KHR" suffix. Signed-off-by: Emil Velikov --- The final piece afaict for KHR_debug + ES contexts. Mildly related - the enum tests seems somewhat busted/incomplete. Ext

Re: [Mesa-dev] [PATCH 1/2] main: Don't restrict several KHR_debug enum to desktop GL

2015-11-05 Thread Emil Velikov
Hi Boyan, On 4 November 2015 at 15:25, Boyan Ding wrote: > In preparation for supporting GL_KHR_debug in OpenGL ES > > Signed-off-by: Boyan Ding > --- > src/mesa/main/enable.c| 5 + > src/mesa/main/getstring.c | 5 + > 2 files changed, 2 insertions(+), 8 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] radeonsi: add basic glClearBufferSubData acceleration

2015-11-05 Thread Marek Olšák
On Thu, Nov 5, 2015 at 7:58 PM, Nicolai Hähnle wrote: > On 04.11.2015 00:47, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeonsi/si_blit.c | 55 >> ++ >> 1 file changed, 55 insertions(+) >> >> diff --git a/src/gallium/drivers/rad

[Mesa-dev] [PATCH v3 1/3] glsl: Add new barrier functions for compute shaders

2015-11-05 Thread Jordan Justen
When these functions are called in GLSL code, we create an intrinsic function call: * groupMemoryBarrier => __intrinsic_group_memory_barrier * memoryBarrierAtomicCounter => __intrinsic_memory_barrier_atomic_counter * memoryBarrierBuffer => __intrinsic_memory_barrier_buffer * memoryBarrierImage

[Mesa-dev] [PATCH v3 3/3] i965/nir/fs: Implement new barrier functions for compute shaders

2015-11-05 Thread Jordan Justen
For these nir intrinsics, we emit the same code as nir_intrinsic_memory_barrier: * nir_intrinsic_memory_barrier_atomic_counter * nir_intrinsic_memory_barrier_buffer * nir_intrinsic_memory_barrier_image We treat these nir intrinsics as no-ops: * nir_intrinsic_group_memory_barrier * nir_intrin

[Mesa-dev] [PATCH v3 2/3] nir: Add new barrier functions for compute shaders

2015-11-05 Thread Jordan Justen
When these functions are called in glsl-ir, we create a corresponding nir intrinsic function call. Signed-off-by: Jordan Justen Reviewed-by: Francisco Jerez --- src/glsl/nir/glsl_to_nir.cpp | 15 +++ src/glsl/nir/nir_intrinsics.h | 11 +++ 2 files changed, 26 insertions(+)

Re: [Mesa-dev] [PATCH 2/4] vl: add drm support for vl_screen

2015-11-05 Thread Christian König
+/** + * + * Copyright 2009 Younes Manton. + * All Rights Reserved. You probably want to change the copyright here. With that fixed the whole series is Reviewed-by: Christian König Regards, Christian. On 05.11.2015 19:

[Mesa-dev] [PATCH 4/4] st/omx: add headless support

2015-11-05 Thread Leo Liu
This will allow dec/enc/transcode without X Signed-off-by: Leo Liu --- src/gallium/state_trackers/omx/entrypoint.c | 39 + 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/src/gallium/state_trackers/omx/entrypoint.c b/src/gallium/state_trackers/omx/ent

Re: [Mesa-dev] [PATCH 13/13] i965/fs_visitor: do not explicitly set outputs[x].file

2015-11-05 Thread Matt Turner
On Thu, Nov 5, 2015 at 8:18 AM, Emil Velikov wrote: > From: Emil Velikov > > This commits partially reverts "i965: Initialize registers' file to > BAD_FILE." > > No longer needed as of commit "i965/fs: properly construct fs_reg" which > removes the memset(...0...), and correctly sets BAD_FILE. I

Re: [Mesa-dev] [PATCH 05/13] i965/vec4: one dst_reg() constructor less

2015-11-05 Thread Matt Turner
On Thu, Nov 5, 2015 at 8:17 AM, Emil Velikov wrote: > From: Emil Velikov > > Just fold the brw_type_for_base_type() and use a delegated > constructor. > > Note this is a c++11 feature and the compiler will warn us if it's > set/defaults to an earlier version of the standard. > > XXX: Should we ju

[Mesa-dev] [PATCH 3/4] st/va: move vl screen drm support to vl_wys_drm

2015-11-05 Thread Leo Liu
--- src/gallium/state_trackers/va/context.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/src/gallium/state_trackers/va/context.c b/src/gallium/state_trackers/va/context.c index 25fa905..845b547 100644 --- a/src/gallium/state_trackers/va/context.c +++ b

[Mesa-dev] [PATCH 2/4] vl: add drm support for vl_screen

2015-11-05 Thread Leo Liu
This will allow the state trackers to use render nodes with screen creation Signed-off-by: Leo Liu --- src/gallium/auxiliary/Makefile.sources | 3 +- src/gallium/auxiliary/vl/vl_winsys.h | 6 +++ src/gallium/auxiliary/vl/vl_winsys_drm.c | 76 3 files chan

Re: [Mesa-dev] [PATCH] radeonsi: add basic glClearBufferSubData acceleration

2015-11-05 Thread Nicolai Hähnle
On 04.11.2015 00:47, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_blit.c | 55 ++ 1 file changed, 55 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index fce014a..e934146

Re: [Mesa-dev] [PATCH 6/7] nir: add shader reference counting

2015-11-05 Thread Rob Clark
On Thu, Nov 5, 2015 at 1:13 PM, Jason Ekstrand wrote: > On Sat, Oct 24, 2015 at 10:07 AM, Rob Clark wrote: >> From: Rob Clark >> >> For gallium, at least, we'll need this to manage shader's lifetimes, >> since in some cases both the driver and the state tracker will need >> to hold on to a refer

[Mesa-dev] [PATCH 1/4] st/va: fix build fails with pipe loader

2015-11-05 Thread Leo Liu
There is no dev in drv, and dev should be from vl_screen here --- src/gallium/state_trackers/va/context.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/va/context.c b/src/gallium/state_trackers/va/context.c index ec9e048..25fa905 100644 --- a/

Re: [Mesa-dev] [PATCH 6/7] nir: add shader reference counting

2015-11-05 Thread Jason Ekstrand
On Sat, Oct 24, 2015 at 10:07 AM, Rob Clark wrote: > From: Rob Clark > > For gallium, at least, we'll need this to manage shader's lifetimes, > since in some cases both the driver and the state tracker will need > to hold on to a reference for variant managing. > > Use nir_shader_mutable() before

Re: [Mesa-dev] [PATCH v2 1/3] glsl: Add new barrier functions for compute shaders

2015-11-05 Thread Francisco Jerez
Jordan Justen writes: > On 2015-11-05 06:07:02, Francisco Jerez wrote: >> Jordan Justen writes: >> >> > When these functions are called in GLSL code, we create an intrinsic >> > function call: >> > >> > * groupMemoryBarrier => __intrinsic_group_memory_barrier >> > * memoryBarrierAtomicCounter

Re: [Mesa-dev] [PATCH 8/8] Enable EXT_blend_func_extended if the driver supports the ARB version

2015-11-05 Thread Ilia Mirkin
Add a note to release notes as well? Please fix up the subjects throughout the series to conform to other patches going to those areas. Generally glsl: or mesa: or glapi: depending on the area (for the bits you're touching). On Thu, Nov 5, 2015 at 12:16 PM, Ryan Houdek wrote: > --- > src/mesa/ma

Re: [Mesa-dev] [PATCH v2 1/3] glsl: Add new barrier functions for compute shaders

2015-11-05 Thread Jordan Justen
On 2015-11-05 06:07:02, Francisco Jerez wrote: > Jordan Justen writes: > > > When these functions are called in GLSL code, we create an intrinsic > > function call: > > > > * groupMemoryBarrier => __intrinsic_group_memory_barrier > > * memoryBarrierAtomicCounter => __intrinsic_memory_barrier_at

Re: [Mesa-dev] [PATCH 5/8] Enable usage of blend_func_extended blend factors

2015-11-05 Thread Ilia Mirkin
On Thu, Nov 5, 2015 at 12:16 PM, Ryan Houdek wrote: > --- > src/mesa/main/blend.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c > index 20aa498..8da81ee 100644 > --- a/src/mesa/main/blend.c > +++ b/src/mesa/main/blend.c

Re: [Mesa-dev] [PATCH 0/8] Implement support for EXT_blend_func_extended

2015-11-05 Thread Ilia Mirkin
You appear to be missing a patch to add this to glcpp: A new preprocessor #define is added to the OpenGL ES Shading Language: #define GL_EXT_blend_func_extended 1 On Thu, Nov 5, 2015 at 12:16 PM, Ryan Houdek wrote: > This implements support for a very new extension to ES, which allows

Re: [Mesa-dev] [PATCH 7/8] Add EXT_blend_func_extended functions to the dispatch_sanity test

2015-11-05 Thread Ilia Mirkin
This need to be done along with the patch which adds these to the xml On Thu, Nov 5, 2015 at 12:16 PM, Ryan Houdek wrote: > --- > src/mesa/main/tests/dispatch_sanity.cpp | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/mesa/main/tests/dispatch_sanity.cpp > b/src/mesa/main/te

Re: [Mesa-dev] [PATCH 3/8] Add support for the new builtins that EXT_blend_func_extended provides.

2015-11-05 Thread Ilia Mirkin
On Thu, Nov 5, 2015 at 12:16 PM, Ryan Houdek wrote: subject: glsl: ... > gl_MaxDualSourceDrawBuffersEXT - Maximum DS draw buffers supported > > Only for ESSL 1.0 it provides two builtins since you can't have user-defined > color output variables > gl_SecondaryFragColorEXT and gl_SecondaryFragDat

Re: [Mesa-dev] [PATCH 1/8] Add EXT_blend_func_extended XML definitions

2015-11-05 Thread Ilia Mirkin
subject: glapi: add ... On Thu, Nov 5, 2015 at 12:16 PM, Ryan Houdek wrote: > --- > src/mapi/glapi/gen/EXT_gpu_shader4.xml | 3 ++- > src/mapi/glapi/gen/es_EXT.xml | 38 > ++ > 2 files changed, 40 insertions(+), 1 deletion(-) > > diff --git a/src/mapi/g

Re: [Mesa-dev] [PATCH 2/8] Add required variables to _mesa_glsl_parse_state for EXT_blend_func_extended

2015-11-05 Thread Ilia Mirkin
subject: glsl: ... On Thu, Nov 5, 2015 at 12:16 PM, Ryan Houdek wrote: > This adds a state for the maximum dual source draw variables available > and the variable for determining if the extension has been enabled > in the program shaders. > --- > src/glsl/glsl_parser_extras.cpp | 3 +++ > src/gl

[Mesa-dev] [PATCH 0/8] Implement support for EXT_blend_func_extended

2015-11-05 Thread Ryan Houdek
This implements support for a very new extension to ES, which allows you to do dual source blending just like in desktop OpenGL. This works with the piglits that I am writing that just need to be cleaned before they are pushed, and it also works fantastically with the Dolphin emulator (Only known a

[Mesa-dev] [PATCH 5/8] Enable usage of blend_func_extended blend factors

2015-11-05 Thread Ryan Houdek
--- src/mesa/main/blend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index 20aa498..8da81ee 100644 --- a/src/mesa/main/blend.c +++ b/src/mesa/main/blend.c @@ -67,7 +67,7 @@ legal_src_factor(const struct gl_context *ctx, GLe

[Mesa-dev] [PATCH 1/8] Add EXT_blend_func_extended XML definitions

2015-11-05 Thread Ryan Houdek
--- src/mapi/glapi/gen/EXT_gpu_shader4.xml | 3 ++- src/mapi/glapi/gen/es_EXT.xml | 38 ++ 2 files changed, 40 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/EXT_gpu_shader4.xml b/src/mapi/glapi/gen/EXT_gpu_shader4.xml index b1f7eae..b4120b

[Mesa-dev] [PATCH 2/8] Add required variables to _mesa_glsl_parse_state for EXT_blend_func_extended

2015-11-05 Thread Ryan Houdek
This adds a state for the maximum dual source draw variables available and the variable for determining if the extension has been enabled in the program shaders. --- src/glsl/glsl_parser_extras.cpp | 3 +++ src/glsl/glsl_parser_extras.h | 5 + 2 files changed, 8 insertions(+) diff --git a/s

[Mesa-dev] [PATCH 6/8] Allow MAX_DUAL_SOURCE_DRAW_BUFFERS to be available to ES

2015-11-05 Thread Ryan Houdek
--- src/mesa/main/get_hash_params.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py index fbc7b8f..9b22b91 100644 --- a/src/mesa/main/get_hash_params.py +++ b/src/mesa/main/get_hash_params.py @@ -330,6 +330

[Mesa-dev] [PATCH 3/8] Add support for the new builtins that EXT_blend_func_extended provides.

2015-11-05 Thread Ryan Houdek
gl_MaxDualSourceDrawBuffersEXT - Maximum DS draw buffers supported Only for ESSL 1.0 it provides two builtins since you can't have user-defined color output variables gl_SecondaryFragColorEXT and gl_SecondaryFragDataEXT[MaxDSDrawBuffers] --- src/glsl/ast_to_hir.cpp| 16 +++ src/gl

[Mesa-dev] [PATCH 7/8] Add EXT_blend_func_extended functions to the dispatch_sanity test

2015-11-05 Thread Ryan Houdek
--- src/mesa/main/tests/dispatch_sanity.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_sanity.cpp index abe0f43..97f81f9 100644 --- a/src/mesa/main/tests/dispatch_sanity.cpp +++ b/src/mesa/main/tests/dispatch_

[Mesa-dev] [PATCH 8/8] Enable EXT_blend_func_extended if the driver supports the ARB version

2015-11-05 Thread Ryan Houdek
--- src/mesa/main/extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index bdc6817..f1692ba 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c @@ -221,6 +221,7 @@ static const struct extension extension_tab

[Mesa-dev] [PATCH 4/8] Add a parse check to check for the index layout qualifier

2015-11-05 Thread Ryan Houdek
This can only be used if EXT_blend_func_extended is enabled --- src/glsl/glsl_parser.yy | 5 + 1 file changed, 5 insertions(+) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index 4636435..40e60e5 100644 --- a/src/glsl/glsl_parser.yy +++ b/src/glsl/glsl_parser.yy @@ -1463,6 +1

[Mesa-dev] [PATCH] Implement EXT_blend_func_extended

2015-11-05 Thread Ryan Houdek
This is a very new extension to ES that gives you dual source blending just like in desktop OpenGL. This works with the piglits that I've written, which are in the process of being cleaned up so they can be pushed, and this also works great with the Dolphin emulator. --- src/glsl/ast_to_hir.cpp

Re: [Mesa-dev] [PATCH 13/13] i965/fs_visitor: do not explicitly set outputs[x].file

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 16:18, Emil Velikov wrote: > From: Emil Velikov > > This commits partially reverts "i965: Initialize registers' file to > BAD_FILE." > > No longer needed as of commit "i965/fs: properly construct fs_reg" which > removes the memset(...0...), and correctly sets BAD_FILE. > > S

Re: [Mesa-dev] [PATCH 3/4] st/va: properly indent buffer.c, config.c, image.c and picture.c

2015-11-05 Thread Emil Velikov
On 5 November 2015 at 08:24, Julien Isorce wrote: > Some lines were using 4 indentation spaces instead of 3. > > The switch in vlVaAcquireBufferHandle actually had wrong brackets > surrounding case+default. > Please don't mix whitespace (trivial) patches and bugfixes. -Emil __

  1   2   >