Re: [Mesa-dev] [PATCH 7/9] i965: Add mask_control_ex field and handle it in compaction.

2015-10-20 Thread Iago Toral
On Mon, 2015-10-19 at 21:09 -0700, Matt Turner wrote: > Documentation is sparse, but it appears to have existed on G45 and ILK > as a second bit extension of the mask_control field. Setting the pair of > bits to 0b11 enables "NoCMask". It shows up in the compacted table for g45 in bit 23, but bit

Re: [Mesa-dev] [PATCH 4/9] i965: Compact acc_wr_control only on Gen6+.

2015-10-20 Thread Iago Toral
On Tue, 2015-10-20 at 11:38 -0700, Matt Turner wrote: > On Tue, Oct 20, 2015 at 1:51 AM, Iago Toral wrote: > > On Mon, 2015-10-19 at 21:09 -0700, Matt Turner wrote: > >> It only exists on Gen6+, and the next patches will add compaction > >> support for the (unused) field in the same location on ea

Re: [Mesa-dev] [PATCH 1/7] nir/info: Add more information about geometry shaders

2015-10-20 Thread Kenneth Graunke
On Tuesday, October 20, 2015 06:14:23 PM Jason Ekstrand wrote: > I have no idea why, but gmail and git-send-email aren't getting along > for me. The entire series (including patches 6 and 7) can be found > here: > > http://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/i965-gs-cleanup > > --Jas

Re: [Mesa-dev] [PATCH 4/4] mesa: Draw indirect is not allowed when xfb is active and unpaused

2015-10-20 Thread Tapani Pälli
On 10/20/2015 05:19 PM, Marta Lofstedt wrote: From: Marta Lofstedt OpenGL ES 3.1 specification, section 10.5: "An INVALID_OPERATION error is generated if transform feedback is active and not paused." Signed-off-by: Marta Lofstedt --- src/mesa/main/api_validate.c | 9 + 1 file chang

Re: [Mesa-dev] [PATCH 2/4] mesa: Draw Indirect is not allowed when no vertex array binding exists.

2015-10-20 Thread Tapani Pälli
On 10/20/2015 08:54 PM, Marek Olšák wrote: On Tue, Oct 20, 2015 at 4:19 PM, Marta Lofstedt wrote: From: Marta Lofstedt OpenGL ES 3.1 spec. section 10.5: "An INVALID_OPERATION error is generated if zero is bound to VERTEX_ARRAY_BINDING, DRAW_INDIRECT_BUFFER or to any enabled vertex array." Si

Re: [Mesa-dev] [PATCH 1/2] glsl: add is_array_of_arrays() helper

2015-10-20 Thread Tapani Pälli
Nice! Both patches are Reviewed-by: Tapani Pälli On 10/21/2015 06:23 AM, Timothy Arceri wrote: As suggested by Ian Romanick Cc: Tapani Pälli --- src/glsl/nir/glsl_types.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/glsl/nir/glsl_types.h b/src/glsl/nir/glsl_types.h index

Re: [Mesa-dev] [PATCH 4/7] glsl: set image access qualifiers for AoA

2015-10-20 Thread Timothy Arceri
On Fri, 2015-10-16 at 10:28 +1100, Timothy Arceri wrote: > Cc: Francisco Jerez Hi Curro, Just pinging you on this patch and patch 5. These are the final two patches remaining unreviewed before I can enable arrays of arrays. If your not able to review these can you let me know so I can chase thi

Re: [Mesa-dev] [PATCH 3/7] glsl: add AoA support to subroutines

2015-10-20 Thread Timothy Arceri
On Wed, 2015-10-21 at 13:28 +1000, Dave Airlie wrote: > On 16 October 2015 at 12:51, Timothy Arceri > wrote: > > On Fri, 2015-10-16 at 11:44 +1000, Dave Airlie wrote: > > > you gotta give me something in the commit msg to have any idea > > > what > > > I'm reading here :-) > > > > > > why does pr

Re: [Mesa-dev] [PATCH 3/7] glsl: add AoA support to subroutines

2015-10-20 Thread Dave Airlie
On 16 October 2015 at 12:51, Timothy Arceri wrote: > On Fri, 2015-10-16 at 11:44 +1000, Dave Airlie wrote: >> you gotta give me something in the commit msg to have any idea what >> I'm reading here :-) >> >> why does process_parameters move? > > Because we need actual_parameters processed earlier

Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling UniformRemapTable

2015-10-20 Thread Timothy Arceri
On Tue, 2015-10-20 at 13:55 +0300, Tapani Pälli wrote: > > On 10/20/2015 01:40 PM, Lofstedt, Marta wrote: > > > -Original Message- > > > From: Palli, Tapani > > > Sent: Tuesday, October 20, 2015 12:25 PM > > > To: Lofstedt, Marta; mesa-dev@lists.freedesktop.org > > > Subject: Re: [Mesa-dev

[Mesa-dev] [PATCH 2/2] glsl: check for arrays of arrays when assigning explicit locations

2015-10-20 Thread Timothy Arceri
This fixes assigning explicit locations in the CTS test: ES31-CTS.explicit_uniform_location.uniform-loc-arrays-of-arrays Cc: Tapani Pälli --- Note: the test still fails, looks like some compute shader support is missing. src/glsl/link_uniforms.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 d

[Mesa-dev] [PATCH 1/2] glsl: add is_array_of_arrays() helper

2015-10-20 Thread Timothy Arceri
As suggested by Ian Romanick Cc: Tapani Pälli --- src/glsl/nir/glsl_types.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/glsl/nir/glsl_types.h b/src/glsl/nir/glsl_types.h index 3ec7642..52ca826 100644 --- a/src/glsl/nir/glsl_types.h +++ b/src/glsl/nir/glsl_types.h @@ -513,6 +513,

[Mesa-dev] [Bug 92552] [softpipe] piglit egl-create-context-valid-flag-forward-compatible-gl regression

2015-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92552 --- Comment #7 from Boyan Ding --- (In reply to Matthew Waters from comment #5) > IIRC, when I made that original patch over a year ago, I stole that logic > from the GLX code which does exactly the same thing. > > Essentially the problem is whe

[Mesa-dev] [Bug 81174] Gallium: GL_LINE_LOOP broken with more than 512 points

2015-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81174 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/7] nir/info: Add more information about geometry shaders

2015-10-20 Thread Jason Ekstrand
I have no idea why, but gmail and git-send-email aren't getting along for me. The entire series (including patches 6 and 7) can be found here: http://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/i965-gs-cleanup --Jason On Tue, Oct 20, 2015 at 6:10 PM, Jason Ekstrand wrote: > --- > src/glsl

[Mesa-dev] [PATCH] docs/index.html: fix typo

2015-10-20 Thread Fabio Pedretti
--- docs/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/index.html b/docs/index.html index 138447f..e28c63d 100644 --- a/docs/index.html +++ b/docs/index.html @@ -28,7 +28,7 @@ This is a bug-fix release. This is a bug-fix release. NOTE: It is anticipated th

[Mesa-dev] [PATCH 1/7] nir/info: Add more information about geometry shaders

2015-10-20 Thread Jason Ekstrand
--- src/glsl/nir/glsl_to_nir.cpp | 3 +++ src/glsl/nir/nir.h | 9 + 2 files changed, 12 insertions(+) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index c9cdf35..91b766a 100644 --- a/src/glsl/nir/glsl_to_nir.cpp +++ b/src/glsl/nir/glsl_to_nir.cpp @@ -

[Mesa-dev] [PATCH 3/7] i965/gs: Set static_vertex_count unconditionally on GEN8+

2015-10-20 Thread Jason Ekstrand
We always have NIR, so there's no reason for the check. --- src/mesa/drivers/dri/i965/brw_gs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_gs.c b/src/mesa/drivers/dri/i965/brw_gs.c index 10a7f28..02f506d 100644 --- a/src/mesa/drivers/dri/i965/

[Mesa-dev] [PATCH 4/7] i965/gs: Move the mem_ctx argument to brw_compile_gs

2015-10-20 Thread Jason Ekstrand
This makes it better match the other brw_compile_* functions. --- src/mesa/drivers/dri/i965/brw_compiler.h | 2 +- src/mesa/drivers/dri/i965/brw_gs.c| 4 ++-- src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff -

[Mesa-dev] [PATCH 2/7] nir: Constify nir_gs_count_vertices

2015-10-20 Thread Jason Ekstrand
--- src/glsl/nir/nir.h | 2 +- src/glsl/nir/nir_gs_count_vertices.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index 64fa70b..9bad408 100644 --- a/src/glsl/nir/nir.h +++ b/src/glsl/nir/nir.h @@ -1896,7 +1896,7 @@

[Mesa-dev] [PATCH 5/7] i965/gs: Use NIR instead of the brw_geometry_program for GS metadata

2015-10-20 Thread Jason Ekstrand
With this, we can remove the geometry program from brw_gs_compile. --- src/mesa/drivers/dri/i965/brw_compiler.h | 2 -- src/mesa/drivers/dri/i965/brw_gs.c| 1 - src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 6 +++--- src/mesa/drivers/dri/i965/gen6_gs_visitor.cpp

Re: [Mesa-dev] [PATCH] svga: add switch case for PIPE_SHADER_CAP_MAX_UNROLL_ITERATIONS_HINT

2015-10-20 Thread Roland Scheidegger
Am 21.10.2015 um 02:23 schrieb Brian Paul: > A third instance of this was needed but missed in the previous commit. > Return 32 as for the two other cases. > --- > src/gallium/drivers/svga/svga_screen.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/gallium/drivers/svga/svga_scree

Re: [Mesa-dev] [PATCH] svga: add switch case for PIPE_SHADER_CAP_MAX_UNROLL_ITERATIONS_HINT

2015-10-20 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: mesa-dev on behalf of Brian Paul Sent: Tuesday, October 20, 2015 5:23 PM To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH] svga: add switch case for PIPE_SHADER_CAP_MAX_UNROLL_ITERATIONS_HINT A third inst

[Mesa-dev] [PATCH] svga: add switch case for PIPE_SHADER_CAP_MAX_UNROLL_ITERATIONS_HINT

2015-10-20 Thread Brian Paul
A third instance of this was needed but missed in the previous commit. Return 32 as for the two other cases. --- src/gallium/drivers/svga/svga_screen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index 17b04

Re: [Mesa-dev] [PATCH] draw: fix splitting of line loops (v2)

2015-10-20 Thread Roland Scheidegger
Looks good to me - this stuff is tricky... Reviewed-by: Roland Scheidegger Am 21.10.2015 um 01:21 schrieb Brian Paul: > When the draw module splits long line loops, the sections are emitted > as line strips. But the primitive type wasn't set correctly so each > section was being drawn as a loop

Re: [Mesa-dev] [RFC 17/21] mesa: Fix ARB_ES3_compatibility functionality leaks

2015-10-20 Thread Nanley Chery
On Tue, Oct 20, 2015 at 8:45 AM, Marek Olšák wrote: > NAK. I'd like this extension in compatibility contexts. The fact the > spec requires OpenGL 3.3 was just authors' laziness. > > If it's the right thing to do, I can allow all versions of GL compatibility by simply replacing '33' with 'GLL' in

[Mesa-dev] [PATCH] draw: fix splitting of line loops (v2)

2015-10-20 Thread Brian Paul
When the draw module splits long line loops, the sections are emitted as line strips. But the primitive type wasn't set correctly so each section was being drawn as a loop, introducing extra line segments. To fix this, we pass a new DRAW_LINE_LOOP_AS_STRIP flag to the run() function. The linear/

Re: [Mesa-dev] Introducing OpenSWR: High performance software rasterizer

2015-10-20 Thread Jose Fonseca
On 20/10/15 23:16, Rowley, Timothy O wrote: On Oct 20, 2015, at 4:23 PM, Jose Fonseca wrote: I tried it on my i7-5500U, but I run into two issues: - OpenSWR seems to only use 2 threads (even though my system support 4 threads) - and even when I compensate llvmpipe to only use 2 rasterizer t

Re: [Mesa-dev] [PATCH 5/6] Implement the proper packing for the stencil payload

2015-10-20 Thread Matt Turner
On Tue, Oct 20, 2015 at 3:25 PM, Ben Widawsky wrote: > On Tue, Oct 20, 2015 at 03:17:38PM -0700, Matt Turner wrote: >> On Tue, Oct 20, 2015 at 2:29 PM, Ben Widawsky >> wrote: >> > This patch is split out for review. It will be squashed before pushing. >> > --- >> > src/mesa/drivers/dri/i965/brw_

Re: [Mesa-dev] [PATCH 2/6] i965/fs: Enumerate logical fb writes arguments

2015-10-20 Thread Matt Turner
On Tue, Oct 20, 2015 at 3:27 PM, Ben Widawsky wrote: > On Tue, Oct 20, 2015 at 03:19:48PM -0700, Matt Turner wrote: >> What I should have said in the previous email is that assigning >> arbitrary numbers to enums in brw_defines.h is confusing because one >> might be led to believe that these are h

Re: [Mesa-dev] [PATCH 2/9] i965/vec4: Initialize LOD to 0.0f.

2015-10-20 Thread Matt Turner
On Tue, Oct 20, 2015 at 1:19 AM, Iago Toral wrote: > On Mon, 2015-10-19 at 23:11 -0700, Matt Turner wrote: >> On Mon, Oct 19, 2015 at 9:09 PM, Matt Turner wrote: >> > We implement textureQueryLevels (which takes no arguments, save the >> > sampler) using the resinfo message (which takes an argume

[Mesa-dev] [PATCH] nvc0: do upload-time fixups for interpolation parameters

2015-10-20 Thread Ilia Mirkin
WIP: only support SM35, need to add SM20 and SM50 support Unfortunately flatshading is an all-or-nothing proposition on nvc0, while GL 3.0 calls for the ability to selectively specify explicit interpolation parameters on gl_Color/gl_SecondaryColor which would override the flatshading setting. This

Re: [Mesa-dev] [PATCH 2/6] i965/fs: Enumerate logical fb writes arguments

2015-10-20 Thread Ben Widawsky
On Tue, Oct 20, 2015 at 03:19:48PM -0700, Matt Turner wrote: > On Tue, Oct 20, 2015 at 3:11 PM, Ben Widawsky wrote: > > On Tue, Oct 20, 2015 at 02:57:24PM -0700, Matt Turner wrote: > >> On Tue, Oct 20, 2015 at 2:54 PM, Ben Widawsky wrote: > >> > On Tue, Oct 20, 2015 at 02:52:29PM -0700, Matt Turn

Re: [Mesa-dev] [PATCH 5/6] Implement the proper packing for the stencil payload

2015-10-20 Thread Ben Widawsky
On Tue, Oct 20, 2015 at 03:17:38PM -0700, Matt Turner wrote: > On Tue, Oct 20, 2015 at 2:29 PM, Ben Widawsky > wrote: > > This patch is split out for review. It will be squashed before pushing. > > --- > > src/mesa/drivers/dri/i965/brw_defines.h| 1 + > > src/mesa/drivers/dri/i965/brw_fs

Re: [Mesa-dev] [PATCH 1/9] i965/vec4: Don't emit MOVs for unused URB slots.

2015-10-20 Thread Matt Turner
On Tue, Oct 20, 2015 at 1:01 AM, Iago Toral wrote: > On Mon, 2015-10-19 at 21:08 -0700, Matt Turner wrote: >> Otherwise we'd emit a MOV from the null register (which isn't allowed). >> >> Helps 24 programs in shader-db (the geometry shaders in GSCloth): >> >> instructions in affected programs:

Re: [Mesa-dev] [PATCH 6/6] i965: Advertise ARB_shader_stencil_export (gen9+)

2015-10-20 Thread Matt Turner
On Tue, Oct 20, 2015 at 2:29 PM, Ben Widawsky wrote: > Signed-off-by: Ben Widawsky > --- > docs/relnotes/11.1.0.html| 1 + > src/mesa/drivers/dri/i965/intel_extensions.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.1.

Re: [Mesa-dev] [PATCH 2/6] i965/fs: Enumerate logical fb writes arguments

2015-10-20 Thread Matt Turner
On Tue, Oct 20, 2015 at 3:11 PM, Ben Widawsky wrote: > On Tue, Oct 20, 2015 at 02:57:24PM -0700, Matt Turner wrote: >> On Tue, Oct 20, 2015 at 2:54 PM, Ben Widawsky wrote: >> > On Tue, Oct 20, 2015 at 02:52:29PM -0700, Matt Turner wrote: >> >> On Tue, Oct 20, 2015 at 2:29 PM, Ben Widawsky >> >>

Re: [Mesa-dev] [PATCH 5/6] Implement the proper packing for the stencil payload

2015-10-20 Thread Matt Turner
On Tue, Oct 20, 2015 at 2:29 PM, Ben Widawsky wrote: > This patch is split out for review. It will be squashed before pushing. > --- > src/mesa/drivers/dri/i965/brw_defines.h| 1 + > src/mesa/drivers/dri/i965/brw_fs.cpp | 6 +++- > src/mesa/drivers/dri/i965/brw_fs.h

Re: [Mesa-dev] Introducing OpenSWR: High performance software rasterizer

2015-10-20 Thread Rowley, Timothy O
> On Oct 20, 2015, at 4:23 PM, Jose Fonseca wrote: > > I tried it on my i7-5500U, but I run into two issues: > > - OpenSWR seems to only use 2 threads (even though my system support 4 > threads) > > - and even when I compensate llvmpipe to only use 2 rasterizer threads, I > still only get ha

[Mesa-dev] [PATCH v3 6/7] radeonsi: Add DCC decompression.

2015-10-20 Thread Bas Nieuwenhuizen
This is currently not needed but will be necessary when we have features that do not work with DCC enabled, such as image stores and sharing non-scanout surfaces. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_blit.c | 31 +-- src/gallium/driver

[Mesa-dev] [PATCH v3 3/7] radeonsi: Add FLUSH_AND_INV_CB_DATA_TS for DCC.

2015-10-20 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_state_draw.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index ce6c98c..29c40d2 100644 --- a/src/gallium/drivers/r

[Mesa-dev] [PATCH v3 5/7] radeonsi: Implement DCC fast clear.

2015-10-20 Thread Bas Nieuwenhuizen
Uses the DCC buffer instead of the CMASK buffer. The ELIMINATE_FAST_CLEAR still works. Furthermore, with DCC compression we can directly clear to a limited set of colors such that we do not need a postprocessing step. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeon/r600_texture.c

[Mesa-dev] [PATCH v3 4/7] radeonsi: Enable DCC.

2015-10-20 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/drivers/radeon/r600_texture.c | 2 ++ src/gallium/drivers/radeon/r600d_common.h | 1 + src/gallium/drivers/radeonsi/si_descriptors.c | 5 +++ src/gallium/drivers/radeonsi/si_pipe.h

Re: [Mesa-dev] [PATCH 2/6] i965/fs: Enumerate logical fb writes arguments

2015-10-20 Thread Ben Widawsky
On Tue, Oct 20, 2015 at 02:57:24PM -0700, Matt Turner wrote: > On Tue, Oct 20, 2015 at 2:54 PM, Ben Widawsky wrote: > > On Tue, Oct 20, 2015 at 02:52:29PM -0700, Matt Turner wrote: > >> On Tue, Oct 20, 2015 at 2:29 PM, Ben Widawsky > >> wrote: > >> > Gen9 adds the ability to write out a stencil v

[Mesa-dev] [PATCH v3 7/7] radeonsi: Add DCC compression tracking machinery.

2015-10-20 Thread Bas Nieuwenhuizen
Add a mask to track if a texture level is still in its decompressed state or that we would need to decompress again. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/drivers/radeon/r600_texture.c | 1 + src/gallium/drivers/radeonsi/si_bl

[Mesa-dev] [PATCH v3 2/7] radeonsi: Disable operations that do not work with DCC.

2015-10-20 Thread Bas Nieuwenhuizen
Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeon/r600_texture.c | 5 + src/gallium/drivers/radeonsi/cik_sdma.c | 3 ++- src/gallium/drivers/radeonsi/si_blit.c| 3 ++- src/gallium/drivers/radeonsi/si_dma.c | 3 ++- 4 files changed, 11 insertions(+), 3 deletions(-) dif

[Mesa-dev] [PATCH v3 1/7] radeonsi: Allocate buffers for DCC.

2015-10-20 Thread Bas Nieuwenhuizen
As the alignment requirements can be 32 KiB or more, also adding an aligned buffer creation function. DCC is disabled for textures that can be shared as sharing the DCC buffers has not been implemented yet. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeon/r600_buffer_common.c | 2

[Mesa-dev] [PATCH v3 0/7] Add DCC support

2015-10-20 Thread Bas Nieuwenhuizen
These patches enable delta color compression (DCC) for Vulcanic Islands GPU's. This should reduce memory bandwidth to increase performance. For the third version I incorporated the suggestions from Marek as well as fixed a bug with the fast clear. There is still no MSAA support yet, as I currentl

Re: [Mesa-dev] [PATCH 3/6] i965: (trivial) rename computes stencil to gen9

2015-10-20 Thread Kenneth Graunke
On Tuesday, October 20, 2015 02:29:38 PM Ben Widawsky wrote: > All the documentation I can find says that this bit (and functionality) only > exists on SKL+. Since the bit isn't yet used, there is no real impact here. > > The original code was added by Ken here (a surprisingly long time ago): > co

Re: [Mesa-dev] [PATCH 2/6] i965/fs: Enumerate logical fb writes arguments

2015-10-20 Thread Matt Turner
On Tue, Oct 20, 2015 at 2:54 PM, Ben Widawsky wrote: > On Tue, Oct 20, 2015 at 02:52:29PM -0700, Matt Turner wrote: >> On Tue, Oct 20, 2015 at 2:29 PM, Ben Widawsky >> wrote: >> > Gen9 adds the ability to write out a stencil value, so we need to expand >> > the >> > virtual payload by one. Abstr

Re: [Mesa-dev] [PATCH 2/6] i965/fs: Enumerate logical fb writes arguments

2015-10-20 Thread Ben Widawsky
On Tue, Oct 20, 2015 at 02:52:29PM -0700, Matt Turner wrote: > On Tue, Oct 20, 2015 at 2:29 PM, Ben Widawsky > wrote: > > Gen9 adds the ability to write out a stencil value, so we need to expand the > > virtual payload by one. Abstracting this now makes that change easier to > > read. > > > > I w

Re: [Mesa-dev] [PATCH 2/6] i965/fs: Enumerate logical fb writes arguments

2015-10-20 Thread Matt Turner
On Tue, Oct 20, 2015 at 2:29 PM, Ben Widawsky wrote: > Gen9 adds the ability to write out a stencil value, so we need to expand the > virtual payload by one. Abstracting this now makes that change easier to read. > > I was admittedly confused early on about some of the hardcoding. If people > beli

Re: [Mesa-dev] [PATCH] i965/fs: Disable opt_sampler_eot for more message types

2015-10-20 Thread Matt Turner
On Tue, Oct 20, 2015 at 2:41 PM, Ben Widawsky wrote: > On Tue, Oct 20, 2015 at 11:56:15AM +0200, Neil Roberts wrote: >> In bfdae9149e0 I disabled the opt_sampler_eot optimisation for TG4 >> message types because I found by experimentation that it doesn't work. >> I wrote in the comment that I coul

Re: [Mesa-dev] [PATCH] i965/fs: Disable opt_sampler_eot for more message types

2015-10-20 Thread Ben Widawsky
On Tue, Oct 20, 2015 at 11:56:15AM +0200, Neil Roberts wrote: > In bfdae9149e0 I disabled the opt_sampler_eot optimisation for TG4 > message types because I found by experimentation that it doesn't work. > I wrote in the comment that I couldn't find any documentation for this > problem. However I'v

[Mesa-dev] [PATCH 5/6] Implement the proper packing for the stencil payload

2015-10-20 Thread Ben Widawsky
This patch is split out for review. It will be squashed before pushing. --- src/mesa/drivers/dri/i965/brw_defines.h| 1 + src/mesa/drivers/dri/i965/brw_fs.cpp | 6 +++- src/mesa/drivers/dri/i965/brw_fs.h | 2 ++ src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 44 +

[Mesa-dev] [PATCH 6/6] i965: Advertise ARB_shader_stencil_export (gen9+)

2015-10-20 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- docs/relnotes/11.1.0.html| 1 + src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.1.0.html index d3dbe9d..9abc6df 100644 --- a/docs/relnotes/11.1.0.htm

[Mesa-dev] [PATCH 4/6] i965: Implement ARB_shader_stencil_export (SKL+)

2015-10-20 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_compiler.h | 1 + src/mesa/drivers/dri/i965/brw_defines.h| 5 +++-- src/mesa/drivers/dri/i965/brw_fs.cpp | 14 ++ src/mesa/drivers/dri/i965/brw_fs.h | 2 ++ src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH 1/6] i965: Correct the comment about fb write payload

2015-10-20 Thread Ben Widawsky
Cc: Francisco Jerez Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_defines.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa/drivers/dri/i965/brw_defines.h index 393f17a..7a5ee1b 100644 --- a/src/mesa/driv

[Mesa-dev] [PATCH 2/6] i965/fs: Enumerate logical fb writes arguments

2015-10-20 Thread Ben Widawsky
Gen9 adds the ability to write out a stencil value, so we need to expand the virtual payload by one. Abstracting this now makes that change easier to read. I was admittedly confused early on about some of the hardcoding. If people believe the resulting code is inferior, I am not super attached to

[Mesa-dev] [PATCH 3/6] i965: (trivial) rename computes stencil to gen9

2015-10-20 Thread Ben Widawsky
All the documentation I can find says that this bit (and functionality) only exists on SKL+. Since the bit isn't yet used, there is no real impact here. The original code was added by Ken here (a surprisingly long time ago): commit f3c6d6f1e151f6a44a76038dccebe4434038dcb1 Author: Kenneth Graunke

[Mesa-dev] [PATCH 0/6] Add ARB_shader_stencil_export for SKL+

2015-10-20 Thread Ben Widawsky
This patch series implements ARB_shader_stencil_export. The fragment shader is able to natively understand the W-tile format of stencil, and write results to the stencil buffer. The patch series has no piglit regressions, and it is passing both my new test (mentioned below) as well as the original

Re: [Mesa-dev] Introducing OpenSWR: High performance software rasterizer

2015-10-20 Thread Jose Fonseca
On 20/10/15 18:11, Rowley, Timothy O wrote: Hi. I'd like to introduce the Mesa3D community to a software project that we hope to upstream. We're a small team at Intel working on software defined visualization (http://sdvis.org/), and have opensource projects in both the raytracing (Embree, OSPR

Re: [Mesa-dev] [RFC 16/21] mesa: Fix ARB_texture_compression_bptc functionality leaks

2015-10-20 Thread Nanley Chery
On Tue, Oct 20, 2015 at 8:37 AM, Marek Olšák wrote: > NAK. I'd like this extension in compatibility contexts. The fact the > spec requires OpenGL 3.1 was just authors' laziness. > > I had thought it might be the case that some specs may unecessarily require a certain version, when in fact a longe

Re: [Mesa-dev] [PATCH 2/7] i965/gen9: Don't call tr_mode_vertical_texture_alignment() for 1D textures

2015-10-20 Thread Anuj Phogat
On Tue, Oct 20, 2015 at 12:56 AM, Pohjolainen, Topi wrote: > On Mon, Oct 19, 2015 at 02:29:04PM -0700, Anuj Phogat wrote: >> On Thu, Aug 13, 2015 at 2:51 PM, Anuj Phogat wrote: >> > Vertical alignment is not applicable to 1D textures. >> > >> > Signed-off-by: Anuj Phogat >> > --- >> > src/mesa/

Re: [Mesa-dev] [PATCH 5/7] i965/fs: move the fs_reg::smear() from get_timestamp() to the callers

2015-10-20 Thread Connor Abbott
On Tue, Oct 20, 2015 at 1:00 PM, Emil Velikov wrote: > We're about to reuse get_timestamp() for the nir_intrinsic_shader_clock. > In the latter the generalisation does not apply, so move the smear() > where needed. This also makes the function analogous to the vec4 one. > > v2: Tweak the comment -

Re: [Mesa-dev] [PATCH] i965/fs: Disable opt_sampler_eot for more message types

2015-10-20 Thread Ilia Mirkin
On Tue, Oct 20, 2015 at 5:56 AM, Neil Roberts wrote: > In bfdae9149e0 I disabled the opt_sampler_eot optimisation for TG4 > message types because I found by experimentation that it doesn't work. > I wrote in the comment that I couldn't find any documentation for this > problem. However I've now fo

Re: [Mesa-dev] Introducing OpenSWR: High performance software rasterizer

2015-10-20 Thread Roland Scheidegger
Am 20.10.2015 um 19:11 schrieb Rowley, Timothy O: > Hi. I'd like to introduce the Mesa3D community to a software project > that we hope to upstream. We're a small team at Intel working on > software defined visualization (http://sdvis.org/), and have > opensource projects in both the raytracing (

Re: [Mesa-dev] [PATCH] i965/fs: Disable opt_sampler_eot for more message types

2015-10-20 Thread Matt Turner
On Tue, Oct 20, 2015 at 11:57 AM, Matt Turner wrote: > On Tue, Oct 20, 2015 at 2:56 AM, Neil Roberts wrote: >> In bfdae9149e0 I disabled the opt_sampler_eot optimisation for TG4 >> message types because I found by experimentation that it doesn't work. >> I wrote in the comment that I couldn't fin

Re: [Mesa-dev] [PATCH 1/2] i965: Remove block arg from foreach_inst_in_block_*_starting_from

2015-10-20 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCHv4 4/7] nir: add shader_clock intrinsic

2015-10-20 Thread Connor Abbott
On Tue, Oct 20, 2015 at 12:55 PM, Emil Velikov wrote: > v2: Add flags and inline comment/description. > v3: None of the input/outputs are variables > v4: Drop clockARB reference, relate code motion barrier comment wrt > intrinsic flag. > > Signed-off-by: Emil Velikov > --- > > Matt, > > Hopefully

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Make emit_uniformize a no-op for immediates

2015-10-20 Thread Francisco Jerez
Kristian Høgsberg writes: > On Tue, Oct 20, 2015 at 3:16 AM, Francisco Jerez > wrote: >> Kristian Høgsberg writes: >> >>> On Mon, Oct 19, 2015 at 4:19 AM, Francisco Jerez >>> wrote: Neil Roberts writes: > Just a thought, would it be better to move this check into the > eli

Re: [Mesa-dev] [PATCH] i965/fs: Disable opt_sampler_eot for more message types

2015-10-20 Thread Matt Turner
On Tue, Oct 20, 2015 at 2:56 AM, Neil Roberts wrote: > In bfdae9149e0 I disabled the opt_sampler_eot optimisation for TG4 > message types because I found by experimentation that it doesn't work. > I wrote in the comment that I couldn't find any documentation for this > problem. However I've now fo

Re: [Mesa-dev] [PATCH] draw: fix splitting of line loops

2015-10-20 Thread Brian Paul
On 10/19/2015 08:29 AM, Brian Paul wrote: On 10/19/2015 04:53 AM, Roland Scheidegger wrote: I thought just changing the prim type would cause the loop to not get closed in the end, albeit I looked at it only briefly (I thought the DRAW_SPLIT_AFTER/BEFORE flags were supposed to be able to deal wi

Re: [Mesa-dev] Introducing OpenSWR: High performance software rasterizer

2015-10-20 Thread Rowley, Timothy O
> On Oct 20, 2015, at 12:44 PM, Ilia Mirkin wrote: > > On Tue, Oct 20, 2015 at 1:43 PM, Ilia Mirkin wrote: >> On Tue, Oct 20, 2015 at 1:11 PM, Rowley, Timothy O >> wrote: >>> Does one build work on both AVX and AVX2? >>> - >>> >>> * Unfortunately, no.

Re: [Mesa-dev] [PATCHv2 6/7] i965: Implement nir_intrinsic_shader_clock

2015-10-20 Thread Connor Abbott
On Tue, Oct 20, 2015 at 1:02 PM, Emil Velikov wrote: > v2: > - Add a few const qualifiers for good measure. > - Drop unneeded retype()s (Matt) > - Convert timestamp to SIMD8/16, as fs_visitor::get_timestamp() returns > SIMD4 (Connor) > > Signed-off-by: Emil Velikov > --- > src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH 4/9] i965: Compact acc_wr_control only on Gen6+.

2015-10-20 Thread Matt Turner
On Tue, Oct 20, 2015 at 1:51 AM, Iago Toral wrote: > On Mon, 2015-10-19 at 21:09 -0700, Matt Turner wrote: >> It only exists on Gen6+, and the next patches will add compaction >> support for the (unused) field in the same location on earlier >> platforms. > > The docs say that this exists also in

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Make emit_uniformize a no-op for immediates

2015-10-20 Thread Kristian Høgsberg
On Tue, Oct 20, 2015 at 3:16 AM, Francisco Jerez wrote: > Kristian Høgsberg writes: > >> On Mon, Oct 19, 2015 at 4:19 AM, Francisco Jerez >> wrote: >>> Neil Roberts writes: >>> Just a thought, would it be better to move this check into the eliminate_find_live_channel optimisation? Th

Re: [Mesa-dev] [PATCH 3/4] mesa: Draw Indirect return wrong error code on unalinged

2015-10-20 Thread Ilia Mirkin
On Tue, Oct 20, 2015 at 10:19 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > From OpenGL 4.4 specification, section 10.4 and > Open GL Es 3.1 section 10.5: > "An INVALID_VALUE error is generated if indirect is not a multiple > of the size, in basic machine units, of uint." > > However, the

[Mesa-dev] [Bug 92552] [softpipe] piglit egl-create-context-valid-flag-forward-compatible-gl regression

2015-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92552 --- Comment #6 from Emil Velikov --- Personally I think that one can interpret the return value in either way - GL_BAD_ATTRIBUTE or EGL_BAD_MATCH. I'd vote for consistency so I'll check what the other GL test suites are doing. -- You are receiv

Re: [Mesa-dev] [PATCH 2/4] mesa: Draw Indirect is not allowed when no vertex array binding exists.

2015-10-20 Thread Marek Olšák
On Tue, Oct 20, 2015 at 4:19 PM, Marta Lofstedt wrote: > From: Marta Lofstedt > > OpenGL ES 3.1 spec. section 10.5: > "An INVALID_OPERATION error is generated if zero is bound > to VERTEX_ARRAY_BINDING, DRAW_INDIRECT_BUFFER or to > any enabled vertex array." > > Signed-off-by: Marta Lofstedt > -

Re: [Mesa-dev] Introducing OpenSWR: High performance software rasterizer

2015-10-20 Thread Ilia Mirkin
[re-adding mesa-dev, dropped accidentally] On Tue, Oct 20, 2015 at 1:43 PM, Ilia Mirkin wrote: > On Tue, Oct 20, 2015 at 1:11 PM, Rowley, Timothy O > wrote: >> Does one build work on both AVX and AVX2? >> - >> >> * Unfortunately, no. The architecture sup

[Mesa-dev] Introducing OpenSWR: High performance software rasterizer

2015-10-20 Thread Rowley, Timothy O
Hi. I'd like to introduce the Mesa3D community to a software project that we hope to upstream. We're a small team at Intel working on software defined visualization (http://sdvis.org/), and have opensource projects in both the raytracing (Embree, OSPRay) and rasterization (OpenSWR) realms. We're

Re: [Mesa-dev] [PATCH 0/7] ARB_shader_clock support

2015-10-20 Thread Emil Velikov
On 19 October 2015 at 19:39, Matt Turner wrote: > On Mon, Oct 19, 2015 at 7:45 AM, Emil Velikov > wrote: >> Hi all, >> >> This is a resent of the previous RFC series with a few minor changes >> - fs_reg:;smear() has been moved out of get_timestamp() >> - clock2x32ARB() has proper return value

Re: [Mesa-dev] [PATCH 3/3] i965/fs: Read all components of a SSBO field with one send

2015-10-20 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2015-10-18 21:31:44, Kristian Høgsberg Kristensen wrote: > Instead of looping through single-component reads, read all components > in one go. > > Signed-off-by: Kristian Høgsberg Kristensen > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 25 +++

Re: [Mesa-dev] [PATCH v2 1/7] nvc0: fix crash when nv50_miptree_from_handle fails

2015-10-20 Thread samuel.pitoiset
Is there a particular situation where nv50_miptree_from_handle() fails? And did you check nv50? Anyway, this patch is: Reviewed-by: Samuel Pitoiset On 20/10/2015 18:34, Julien Isorce wrote: Signed-off-by: Julien Isorce --- src/gallium/drivers/nouveau/nvc0/nvc0_resource.c | 3 ++- 1 file c

[Mesa-dev] [PATCHv2 6/7] i965: Implement nir_intrinsic_shader_clock

2015-10-20 Thread Emil Velikov
v2: - Add a few const qualifiers for good measure. - Drop unneeded retype()s (Matt) - Convert timestamp to SIMD8/16, as fs_visitor::get_timestamp() returns SIMD4 (Connor) Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 11 +++ src/mesa/drivers/dri/i965/brw

Re: [Mesa-dev] [RFC 18/21] mesa/extensions: Remove extra memsets on gl_extensions

2015-10-20 Thread Nanley Chery
On Tue, Oct 20, 2015 at 8:49 AM, Marek Olšák wrote: > On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery > wrote: > > From: Nanley Chery > > > > Aside from those modified in this commit, all gl_extensions structs are > > zero-initialized by default. There is therefore no need to memset the > > stru

[Mesa-dev] [PATCH 5/7] i965/fs: move the fs_reg::smear() from get_timestamp() to the callers

2015-10-20 Thread Emil Velikov
We're about to reuse get_timestamp() for the nir_intrinsic_shader_clock. In the latter the generalisation does not apply, so move the smear() where needed. This also makes the function analogous to the vec4 one. v2: Tweak the comment - The caller -> We (Matt, Connor). Signed-off-by: Emil Velikov

[Mesa-dev] [Bug 92552] [softpipe] piglit egl-create-context-valid-flag-forward-compatible-gl regression

2015-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92552 --- Comment #5 from Matthew Waters --- (In reply to Boyan Ding from comment #4) > The spec of EGL_KHR_create_context says: > requesting a forward-compatible context for OpenGL versions less > than 3.0 will generate an error > > The code

[Mesa-dev] [PATCHv4 4/7] nir: add shader_clock intrinsic

2015-10-20 Thread Emil Velikov
v2: Add flags and inline comment/description. v3: None of the input/outputs are variables v4: Drop clockARB reference, relate code motion barrier comment wrt intrinsic flag. Signed-off-by: Emil Velikov --- Matt, Hopefully the updated comment makes more sense (the clockARB reference was an unin

Re: [Mesa-dev] [PATCH 7/7] st/va: add headless support, i.e. VA_DISPLAY_DRM

2015-10-20 Thread Arnaud Vrac
On Tue, Oct 20, 2015 at 6:35 PM, Emil Velikov wrote: > On 20 October 2015 at 17:06, Julien Isorce > wrote: > > > > > > On 19 October 2015 at 17:16, Emil Velikov > wrote: > >> > >> On 17 October 2015 at 00:14, Julien Isorce > >> wrote: > >> > This patch allows to use gallium vaapi without requi

Re: [Mesa-dev] [RFC 21/21] mesa/extensions: Declare _mesa_init_extensions() static inline

2015-10-20 Thread Nanley Chery
On Tue, Oct 20, 2015 at 9:31 AM, Marek Olšák wrote: > On Tue, Oct 20, 2015 at 6:25 PM, Nanley Chery > wrote: > > > > > > On Tue, Oct 20, 2015 at 8:57 AM, Marek Olšák wrote: > >> > >> On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery > >> wrote: > >> > From: Nanley Chery > >> > > >> > Avoid the f

[Mesa-dev] [PATCH v2 4/7] st/va: implement VaCreateSurfaces2 and VaQuerySurfaceAttributes

2015-10-20 Thread Julien Isorce
Inspired from http://cgit.freedesktop.org/vaapi/intel-driver/ especially src/i965_drv_video.c::i965_CreateSurfaces2. This patch is mainly to support gstreamer-vaapi and tools that uses this newer libva API. The first advantage of using VaCreateSurfaces2 over existing VaCreateSurfaces, is that it i

Re: [Mesa-dev] [PATCH 7/7] st/va: add headless support, i.e. VA_DISPLAY_DRM

2015-10-20 Thread Emil Velikov
On 20 October 2015 at 17:06, Julien Isorce wrote: > > > On 19 October 2015 at 17:16, Emil Velikov wrote: >> >> On 17 October 2015 at 00:14, Julien Isorce >> wrote: >> > This patch allows to use gallium vaapi without requiring >> > a X server running for your second graphic card. >> > >> I've sen

[Mesa-dev] [PATCH v2 1/7] nvc0: fix crash when nv50_miptree_from_handle fails

2015-10-20 Thread Julien Isorce
Signed-off-by: Julien Isorce --- src/gallium/drivers/nouveau/nvc0/nvc0_resource.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_resource.c b/src/gallium/drivers/nouveau/nvc0/nvc0_resource.c index 12b5a02..15c803c 100644 --- a/src/gall

[Mesa-dev] [PATCH v2 5/7] st/va: implement dmabuf import for VaCreateSurfaces2

2015-10-20 Thread Julien Isorce
For now it is limited to RGBA, BGRA, RGBX, BGRX surfaces. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/surface.c | 97 - 1 file changed, 96 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/surface.c b/src/gallium/state_tr

[Mesa-dev] [PATCH v2 2/7] st/va: properly defines VAImageFormat formats and improve VaCreateImage

2015-10-20 Thread Julien Isorce
Also add RGBA, RGBX and BGRX. Also extend ChromaToPipe and implement PipeToYCbCr. Note that gstreamer-vaapi check all the VAImageFormat fields. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/image.c | 18 +++--- src/gallium/state_trackers/va/va_private.h | 38 ++

[Mesa-dev] [PATCH v2 3/7] st/va: do not destroy old buffer when new one failed

2015-10-20 Thread Julien Isorce
If formats are not the same vlVaPutImage re-creates the video buffer with the right format. But if the creation of this new video buffer fails then the surface looses its current buffer. Let's just destroy the previous buffer on success. Signed-off-by: Julien Isorce --- src/gallium/state_tracker

Re: [Mesa-dev] [RFC 21/21] mesa/extensions: Declare _mesa_init_extensions() static inline

2015-10-20 Thread Marek Olšák
On Tue, Oct 20, 2015 at 6:25 PM, Nanley Chery wrote: > > > On Tue, Oct 20, 2015 at 8:57 AM, Marek Olšák wrote: >> >> On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery >> wrote: >> > From: Nanley Chery >> > >> > Avoid the function call overhead for this one-liner. >> >> Can you measure the overhead

Re: [Mesa-dev] [RFC 21/21] mesa/extensions: Declare _mesa_init_extensions() static inline

2015-10-20 Thread Nanley Chery
On Tue, Oct 20, 2015 at 8:57 AM, Marek Olšák wrote: > On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery > wrote: > > From: Nanley Chery > > > > Avoid the function call overhead for this one-liner. > > Can you measure the overhead? If not, there is no reason for this change. > > The .text size does

  1   2   >