Re: [Mesa-dev] [PATCH 09/17] i965: Use a const nir_shader in backend_shader

On Thu, Oct 08, 2015 at 05:22:41PM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_fs.h| 2 +- > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 +- > src/mesa/drivers/dri/i965/brw_shader.cpp | 2 +- > src/mesa/drivers/dri/i965/brw_shader.h

Re: [Mesa-dev] [PATCH 02/17] nir: Add a label to nir_shader_info

On Thu, Oct 08, 2015 at 05:22:34PM -0700, Jason Ekstrand wrote: > --- > src/glsl/nir/glsl_to_nir.cpp | 2 ++ > src/glsl/nir/nir.h | 3 +++ > src/glsl/nir/nir_sweep.c | 2 ++ > 3 files changed, 7 insertions(+) This is needed in patch 8 and is: Reviewed-by: Topi Pohjolainen > > di

Re: [Mesa-dev] [PATCH 04/17] nir/info: Move the GS info into a stage-specific info union

On Thu, Oct 08, 2015 at 05:22:36PM -0700, Jason Ekstrand wrote: > This way we can have other stage-specific info without consuming too much > extra space. While we're at it, we make sure that the geometry info is > only set if we're actually a goemetry shader. > --- > src/glsl/nir/glsl_to_nir.cpp

Re: [Mesa-dev] [PATCH 01/17] i965/asm: Explicitly use a nir_instr for IR annotations

On Thu, Oct 08, 2015 at 05:22:33PM -0700, Jason Ekstrand wrote: > Now that everything goes through NIR, we don't need this to be a void > pointer anymore. > --- > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 2 +- > src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 2 +- > src/mesa/driver

[Mesa-dev] [PATCH] i965: Do not dereference NULL brw_shader pointer when debugging

For the VS and FS stages that use ARB_vertex_program or ARB_fragment_program we don't have a shader program, however, when debuging is enabled, we call brw_dump_ir like this: brw_dump_ir("vertex", prog, &vs->base, &vp->program.Base); which unconditionally dereferences vs, producing a NULL pointer

[Mesa-dev] [PATCH] changes to get rid of ir_variable

Hi; Here's a proposal to start creating gl_shader_variable structs to program resource list instead of maintaining a whole ir_variable. This is done to strip dependency on GLSL IR from program resource queries. It also may give possibility to free IR (or NIR) after linking, maybe some more fields

[Mesa-dev] [PATCH] mesa: use gl_shader_variable in program resource list WIP

Patch changes linker to allocate gl_shader_variable instead of using ir_variable. This makes it possible to get rid of ir_variables and ir as a whole. Signed-off-by: Tapani Pälli --- src/glsl/linker.cpp| 42 ++- src/mesa/main/mtypes.h | 56

Re: [Mesa-dev] [PATCH] gallium/swrast: fix front buffer blitting. (v2)

On 9 October 2015 at 13:30, Boyan Ding wrote: > 2015-10-09 8:38 GMT+08:00 Dave Airlie : >> From: Dave Airlie >> >> So I've known this was broken before, cogl has a workaround >> for it from what I know, but with the gallium based swrast >> drivers BlitFramebuffer from back to front or vice-versa

Re: [Mesa-dev] [PATCH 01/12] i965: Move brw_dump_ir() out of brw_*_emit() functions

On Thu, 2015-10-08 at 11:19 -0700, Kristian Høgsberg wrote: > On Thu, Oct 8, 2015 at 4:42 AM, Iago Toral wrote: > > On Thu, 2015-10-08 at 12:32 +0100, Chris Wilson wrote: > >> On Thu, Oct 08, 2015 at 01:23:27PM +0200, Iago Toral wrote: > >> > Well, this is weird this patch makes this crash: >

[Mesa-dev] [PATCH v3 4/7] nir: add an instruction set API

This will replace direct usage of nir_instrs_equal() in the CSE pass, which reduces an O(n^2) algorithm with an effectively O(n) one. It'll also be useful for implementing GVN on top of GCM. v2: - Add texture support. - Add more comments. - Rename instr_can_hash() to instr_can_rewrite() since it's

Re: [Mesa-dev] [PATCH] gallium/swrast: fix front buffer blitting. (v2)

2015-10-09 8:38 GMT+08:00 Dave Airlie : > From: Dave Airlie > > So I've known this was broken before, cogl has a workaround > for it from what I know, but with the gallium based swrast > drivers BlitFramebuffer from back to front or vice-versa > was pretty broken. > > The legacy swrast driver trac

Re: [Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

On 07.10.2015 04:58, Kyle Brenneman wrote: > On 10/06/2015 12:43 PM, Emil Velikov wrote: >> On 6 October 2015 at 16:39, Kyle Brenneman wrote: >>> On 10/06/2015 07:34 AM, Emil Velikov wrote: * The existing x11glvnd extension seems to be a "xserver only" approach. Iirc at XDC last y

Re: [Mesa-dev] [PATCH] mesa: Correctly handle GL_BGRA_EXT in ES3 format_and_type checks

Hi, Am 08.10.2015 um 00:58 schrieb Jason Ekstrand: > The EXT_texture_format_BGRA extension (which mesa supports > unconditionally) adds a new format and internal format called > GL_BGRA_EXT. Previously, this was not really handled at all in > _mesa_ex3_error_check_format_and_type. When the

[Mesa-dev] [PATCH] gallium/swrast: fix front buffer blitting. (v2)

From: Dave Airlie So I've known this was broken before, cogl has a workaround for it from what I know, but with the gallium based swrast drivers BlitFramebuffer from back to front or vice-versa was pretty broken. The legacy swrast driver tracks when a front buffer is used and does the get/put im

Re: [Mesa-dev] [PATCH 00/17] i965: More compiler cleanups

On Thu, Oct 8, 2015 at 5:22 PM, Jason Ekstrand wrote: > This series contains even more compiler code-shuffling and cleanups. In > particular, it gets us down to the point where we can, for the most part, > just go NIR -> binary. It also rolls the entire compiler API into a single > header file w

[Mesa-dev] [PATCH 07/17] i965/fs: Remove the gl_program from the generator

--- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs.cpp| 4 ++-- src/mesa/drivers/dri/i965/brw_fs.h | 3 --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 3 +-- src/mesa/drivers/dri/i965/brw_vec4.cpp | 2 +- 5 files ch

[Mesa-dev] [PATCH 14/17] i965/cs: Rework cs_emit to take a nir_shader and a brw_compiler

This commit removes all dependence on GL state by getting rid of the brw_context parameter and the GL data structures. --- src/mesa/drivers/dri/i965/brw_cs.c | 10 +-- src/mesa/drivers/dri/i965/brw_cs.h | 10 --- src/mesa/drivers/dri/i965/brw_fs.cpp | 51 ---

[Mesa-dev] [PATCH 13/17] i965/gs: Rework gs_emit to take a nir_shader and a brw_compiler

This commit removes all dependence on GL state by getting rid of the brw_context parameter and the GL data structures. Unfortunately, we still have to pass in the gl_shader_program for gen6 because it's needed for transform feedback. --- src/mesa/drivers/dri/i965/brw_gs.c| 6 ++-

[Mesa-dev] [PATCH 04/17] nir/info: Move the GS info into a stage-specific info union

This way we can have other stage-specific info without consuming too much extra space. While we're at it, we make sure that the geometry info is only set if we're actually a goemetry shader. --- src/glsl/nir/glsl_to_nir.cpp | 12 ++-- src/glsl/nir/nir.h | 14 -- 2 fi

[Mesa-dev] [PATCH 12/17] i965/vs: Rework vs_emit to take a nir_shader and a brw_compiler

This commit removes all dependence on GL state by getting rid of the brw_context parameter and the GL data structures. --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 67 +- src/mesa/drivers/dri/i965/brw_vs.c | 14 ++- src/mesa/drivers/dri/i965/brw_vs.h | 1

[Mesa-dev] [PATCH 03/17] mesa: Move gl_frag_depth_layout from mtypes.h to shader_enums.h

--- src/glsl/shader_enums.h | 17 + src/mesa/main/mtypes.h | 18 -- 2 files changed, 17 insertions(+), 18 deletions(-) diff --git a/src/glsl/shader_enums.h b/src/glsl/shader_enums.h index 2a5d2c5..1c2f5dc 100644 --- a/src/glsl/shader_enums.h +++ b/src/glsl/shader_

[Mesa-dev] [PATCH 05/17] nir/info: Add compute shader local size to nir_shader_info

--- src/glsl/nir/glsl_to_nir.cpp | 8 src/glsl/nir/nir.h | 4 2 files changed, 12 insertions(+) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index da15927..e4aa709 100644 --- a/src/glsl/nir/glsl_to_nir.cpp +++ b/src/glsl/nir/glsl_to_nir.cpp @@ -

[Mesa-dev] [PATCH 08/17] i965/vec4: Remove gl_program and gl_shader_program from the generator

--- src/mesa/drivers/dri/i965/brw_vec4.cpp| 4 ++-- src/mesa/drivers/dri/i965/brw_vec4.h | 10 +++--- src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 24 ++- src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 11 +-- 4 files changed, 2

[Mesa-dev] [PATCH 11/17] i965/fs: Rework wm_fs_emit to take a nir_shader and a brw_compiler

This commit removes all dependence on GL state by getting rid of the brw_context parameter and the GL data structures. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 59 src/mesa/drivers/dri/i965/brw_wm.c | 14 +++-- src/mesa/drivers/dri/i965/brw_wm.h | 13

[Mesa-dev] [PATCH 10/17] i965/vs: Move use_legacy_snorm_formula into the shader key

This is really an input into the shader compiler so it kind of makes sense in the key. Also, given where it's placed into the key, it doesn't actually make it any bigger. --- src/mesa/drivers/dri/i965/brw_program.h | 2 ++ src/mesa/drivers/dri/i965/brw_vec4.cpp| 3 +-- src/m

[Mesa-dev] [PATCH 01/17] i965/asm: Explicitly use a nir_instr for IR annotations

Now that everything goes through NIR, we don't need this to be a void pointer anymore. --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 2 +- src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 2 +- src/mesa/drivers/dri/i965/intel_asm_annotation.c | 17 ++--- src/mesa/drivers/d

[Mesa-dev] [PATCH 15/17] i965/fs: Move some of the prog_data setup into brw_wm_emit

This commit moves the common/modern stuff. Some legacy stuff such as setting use_alt_mode was left because it needs to know whether or not we're an ARB program. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 98 src/mesa/drivers/dri/i965/brw_wm.c | 98 --

[Mesa-dev] [PATCH 06/17] nir/info: Add a few bits of info for fragment shaders

--- src/glsl/nir/glsl_to_nir.cpp | 9 + src/glsl/nir/nir.h | 13 + src/mesa/program/prog_to_nir.c | 6 ++ 3 files changed, 28 insertions(+) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index e4aa709..ddacb4e 100644 --- a/src/glsl

[Mesa-dev] [PATCH 00/17] i965: More compiler cleanups

This series contains even more compiler code-shuffling and cleanups. In particular, it gets us down to the point where we can, for the most part, just go NIR -> binary. It also rolls the entire compiler API into a single header file with a bunch of structs and 6 functions. It also reworks the em

[Mesa-dev] [PATCH 02/17] nir: Add a label to nir_shader_info

--- src/glsl/nir/glsl_to_nir.cpp | 2 ++ src/glsl/nir/nir.h | 3 +++ src/glsl/nir/nir_sweep.c | 2 ++ 3 files changed, 7 insertions(+) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index efaa73e..cdae2d1 100644 --- a/src/glsl/nir/glsl_to_nir.cpp +++ b/src/

[Mesa-dev] [PATCH 09/17] i965: Use a const nir_shader in backend_shader

--- src/mesa/drivers/dri/i965/brw_fs.h| 2 +- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 +- src/mesa/drivers/dri/i965/brw_shader.cpp | 2 +- src/mesa/drivers/dri/i965/brw_shader.h| 4 ++-- src/mesa/drivers/dri/i965/brw_vec4.h | 2 +- sr

[Mesa-dev] [PATCH 16/17] i965: Rename brw_foo_emit to brw_compile_foo

--- src/mesa/drivers/dri/i965/brw_cs.c| 6 +++--- src/mesa/drivers/dri/i965/brw_cs.h| 16 src/mesa/drivers/dri/i965/brw_fs.cpp | 18 +- src/mesa/drivers/dri/i965/brw_gs.c| 6 +++--- src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH 1/7] glsl: move gl_shader_stage_name() definition to shader_enums.h

On Thu, Oct 8, 2015 at 1:52 PM, Emil Velikov wrote: > On 8 October 2015 at 18:08, Ilia Mirkin wrote: >> On Thu, Oct 8, 2015 at 1:09 PM, Emil Velikov >> wrote: >>> This is a trivial enough function that can live in the header. While >>> we're here, add a STATIC_ASSERT for good measure. >>> >>> S

Re: [Mesa-dev] [PATCH 1/7] glsl: move gl_shader_stage_name() definition to shader_enums.h

On Thu, Oct 8, 2015 at 6:29 PM, Ilia Mirkin wrote: > On Thu, Oct 8, 2015 at 3:57 PM, Emil Velikov wrote: >> On 8 October 2015 at 19:38, Ilia Mirkin wrote: >>> On Thu, Oct 8, 2015 at 2:34 PM, Emil Velikov >>> wrote: On 8 October 2015 at 19:32, Ilia Mirkin wrote: > On Thu, Oct 8, 2015

Re: [Mesa-dev] [PATCH 1/7] glsl: move gl_shader_stage_name() definition to shader_enums.h

On Thu, Oct 8, 2015 at 3:57 PM, Emil Velikov wrote: > On 8 October 2015 at 19:38, Ilia Mirkin wrote: >> On Thu, Oct 8, 2015 at 2:34 PM, Emil Velikov >> wrote: >>> On 8 October 2015 at 19:32, Ilia Mirkin wrote: On Thu, Oct 8, 2015 at 2:23 PM, Emil Velikov wrote: > On 8 October 2

[Mesa-dev] [PATCH] glsl: move shader_enums into nir

From: Rob Clark First step towards inverting the dependency between glsl and nir (so nir can be used without glsl). Also solves this issue with 'make distclean' Making distclean in mesa make[2]: Entering directory '/mnt/sdb1/Src64/Mesa-git/mesa/src/mesa' Makefile:2486: ../glsl/.deps/shade

[Mesa-dev] [PATCH 1/2] i965/gen9: Disable MCS for 1x color surfaces

Fast color clears are disabled for gen9 (see the checks in brw_meta_fast_clear), so there is no reason to allocate the MCS and track its clear/resolve state. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/drivers/dri/i965/inte

[Mesa-dev] [PATCH 2/2] i965/gen9: Enable rep clears on gen9

The (gen < 9) check in brw_clear() was too broad. It disabled all types of fast color clears: a. singlesample rep clears b. singlesample MCS fast clears c. multisample MCS fast clears The MCS clears are still buggy, but the rep clear works well. So let's enable it. --- src/mesa/driver

[Mesa-dev] [PATCH 0/2] i965/gen9: Enable rep clears

This series lives at git://github.com/chadversary/mesa refs/tags/skl-fast-clear-v08.01 No Piglit regressions on: - Skylake 0x1912 (rev 06) - linux 4.3-rc4 - piglit master@2b23e7b Chad Versace (2): i965/gen9: Disable MCS for 1x color surfaces i965/gen9: Enable rep clears on gen9 src/

Re: [Mesa-dev] [PATCH 3/8] radeonsi: Enable DCC.

Hi Bas, How's it going? I've gotten a response from Catalyst devs and they're saying CMASK is unnecessary here. If it's always cleared to 0xff, it's better to disable it to save some bandwidth. Also, it looks like we don't need DCC decompression at all, right? It might be better to get rid of it

Re: [Mesa-dev] [PATCH 1/7] glsl: move gl_shader_stage_name() definition to shader_enums.h

On 8 October 2015 at 19:38, Ilia Mirkin wrote: > On Thu, Oct 8, 2015 at 2:34 PM, Emil Velikov wrote: >> On 8 October 2015 at 19:32, Ilia Mirkin wrote: >>> On Thu, Oct 8, 2015 at 2:23 PM, Emil Velikov >>> wrote: On 8 October 2015 at 18:57, Ilia Mirkin wrote: > On Thu, Oct 8, 2015 at 1

Re: [Mesa-dev] [PATCH 12/12] i965: Link compiler unit tests to libi965_compiler.la

On 7 October 2015 at 15:11, Kristian Høgsberg Kristensen wrote: > We can now link the unit tests against just libi965_compiler.la. This > lets us drop a lot of DRI driver dependencies, but we still pull in all > of libmesa and more. > > This also provides a few standalone users of libi965_compiler

Re: [Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

On 10/08/2015 12:29 PM, Emil Velikov wrote: On 06/10/15 20:58, Kyle Brenneman wrote: On 10/06/2015 12:43 PM, Emil Velikov wrote: On 6 October 2015 at 16:39, Kyle Brenneman wrote: On 10/06/2015 07:34 AM, Emil Velikov wrote: Hello Kyle, A few questions/points of discussion: * What is your

[Mesa-dev] [PATCH] i965/gen8: Remove gen<8 checks in gen8 code

Some assertions in gen8_surface_state.c checked for gen < 8. --- src/mesa/drivers/dri/i965/gen8_surface_state.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen8_surface_state.c b/src/mesa/drivers/dri/i965/gen8_surface_state.c index e1e7704

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

On Thu, Oct 8, 2015 at 11:01 AM, Brian Paul wrote: > You tested with all 3 patches and everything's OK now? > > I guess I'd still like an R-b on the 3rd patch ("mesa,meta: move > gl_texture_object::TargetIndex initializations") from someone before > pushing. done. > > -Brian > > > On 10/08/2015 11

Re: [Mesa-dev] [PATCH 3/3] mesa, meta: move gl_texture_object::TargetIndex initializations

On Thu, Oct 8, 2015 at 7:20 AM, Brian Paul wrote: > Before, we were unconditionally assigning the TargetIndex field in > _mesa_BindTexture(), even if it was already set properly. Now we > initialize TargetIndex wherever we initialize the Target field, in > _mesa_initialize_texture_object(), finis

Re: [Mesa-dev] [PATCH] i965/gen8: Drop some assertions for gen < 8

Nevermind this patch. It contains a stupid mistake. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965/gen8: Drop some assertions for gen < 8

--- src/mesa/drivers/dri/i965/gen8_surface_state.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen8_surface_state.c b/src/mesa/drivers/dri/i965/gen8_surface_state.c index e1e7704..1e3ae3f 100644 --- a/src/mesa/drivers/dri/i965/gen8_surface_state.c +++ b/src/mesa

Re: [Mesa-dev] [PATCH 12/12] i965: Link compiler unit tests to libi965_compiler.la

Looks good to me. This patch and 12 are Reviewed-by: Jason Ekstrand On Wed, Oct 7, 2015 at 7:11 AM, Kristian Høgsberg Kristensen wrote: > We can now link the unit tests against just libi965_compiler.la. This > lets us drop a lot of DRI driver dependencies, but we still pull in all > of libmesa

Re: [Mesa-dev] [PATCH 09/12] i965: Move brw_get_shader_time_index() call out of emit functions

On Wed, Oct 7, 2015 at 7:11 AM, Kristian Høgsberg Kristensen wrote: > brw_get_shader_time_index() is all tangled up in brw_context state and > we can't call it from the compiler. Thanks the Jasons recent > refactoring, we can just get the index and pass to the emit functions > instead. > > Signed-

Re: [Mesa-dev] [PATCH 10/12] i965/cs: Get max_cs_threads from brw_compiler devinfo

On Thu, Oct 8, 2015 at 11:35 AM, Kristian Høgsberg wrote: > On Wed, Oct 7, 2015 at 10:09 PM, Jason Ekstrand wrote: >> >> On Oct 7, 2015 3:36 PM, "Kristian Høgsberg" wrote: >>> >>> On Wed, Oct 7, 2015 at 3:11 PM, Matt Turner wrote: >>> > On Wed, Oct 7, 2015 at 7:11 AM, Kristian Høgsberg Kristens

Re: [Mesa-dev] [PATCH 1/7] glsl: move gl_shader_stage_name() definition to shader_enums.h

On Thu, Oct 8, 2015 at 2:34 PM, Emil Velikov wrote: > On 8 October 2015 at 19:32, Ilia Mirkin wrote: >> On Thu, Oct 8, 2015 at 2:23 PM, Emil Velikov >> wrote: >>> On 8 October 2015 at 18:57, Ilia Mirkin wrote: On Thu, Oct 8, 2015 at 1:52 PM, Emil Velikov wrote: > On 8 October 2

Re: [Mesa-dev] [PATCH 10/12] i965/cs: Get max_cs_threads from brw_compiler devinfo

On Wed, Oct 7, 2015 at 10:09 PM, Jason Ekstrand wrote: > > On Oct 7, 2015 3:36 PM, "Kristian Høgsberg" wrote: >> >> On Wed, Oct 7, 2015 at 3:11 PM, Matt Turner wrote: >> > On Wed, Oct 7, 2015 at 7:11 AM, Kristian Høgsberg Kristensen >> > wrote: >> >> Signed-off-by: Kristian Høgsberg Kristensen

Re: [Mesa-dev] [PATCH 1/7] glsl: move gl_shader_stage_name() definition to shader_enums.h

On 8 October 2015 at 19:32, Ilia Mirkin wrote: > On Thu, Oct 8, 2015 at 2:23 PM, Emil Velikov wrote: >> On 8 October 2015 at 18:57, Ilia Mirkin wrote: >>> On Thu, Oct 8, 2015 at 1:52 PM, Emil Velikov >>> wrote: On 8 October 2015 at 18:08, Ilia Mirkin wrote: > On Thu, Oct 8, 2015 at 1

Re: [Mesa-dev] [PATCH 1/7] glsl: move gl_shader_stage_name() definition to shader_enums.h

On Thu, Oct 8, 2015 at 2:23 PM, Emil Velikov wrote: > On 8 October 2015 at 18:57, Ilia Mirkin wrote: >> On Thu, Oct 8, 2015 at 1:52 PM, Emil Velikov >> wrote: >>> On 8 October 2015 at 18:08, Ilia Mirkin wrote: On Thu, Oct 8, 2015 at 1:09 PM, Emil Velikov wrote: > This is a triv

Re: [Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

On 06/10/15 20:58, Kyle Brenneman wrote: > On 10/06/2015 12:43 PM, Emil Velikov wrote: >> On 6 October 2015 at 16:39, Kyle Brenneman wrote: >>> On 10/06/2015 07:34 AM, Emil Velikov wrote: Hello Kyle, A few questions/points of discussion: * What is your take on having a l

Re: [Mesa-dev] [PATCH 1/7] glsl: move gl_shader_stage_name() definition to shader_enums.h

On 8 October 2015 at 18:57, Ilia Mirkin wrote: > On Thu, Oct 8, 2015 at 1:52 PM, Emil Velikov wrote: >> On 8 October 2015 at 18:08, Ilia Mirkin wrote: >>> On Thu, Oct 8, 2015 at 1:09 PM, Emil Velikov >>> wrote: This is a trivial enough function that can live in the header. While we'r

Re: [Mesa-dev] [PATCH 01/12] i965: Move brw_dump_ir() out of brw_*_emit() functions

On Thu, Oct 8, 2015 at 4:42 AM, Iago Toral wrote: > On Thu, 2015-10-08 at 12:32 +0100, Chris Wilson wrote: >> On Thu, Oct 08, 2015 at 01:23:27PM +0200, Iago Toral wrote: >> > Well, this is weird this patch makes this crash: >> > >> > INTEL_DEBUG=vs glxgears >> > >> > because that uses a vertex

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

Brian Paul writes: > You tested with all 3 patches and everything's OK now? Sorry, I should have been more clear: Series is Tested-by: Mark Janes > > I guess I'd still like an R-b on the 3rd patch ("mesa,meta: move > gl_texture_object::TargetIndex initializations") from someone before > pu

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

Brian Paul writes: > On 10/07/2015 04:47 PM, Mark Janes wrote: >> Brian Paul writes: >> >>> On 10/05/2015 05:18 PM, Mark Janes wrote: I tested this patch and found: regressions: spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW only)

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

You tested with all 3 patches and everything's OK now? I guess I'd still like an R-b on the 3rd patch ("mesa,meta: move gl_texture_object::TargetIndex initializations") from someone before pushing. -Brian On 10/08/2015 11:57 AM, Mark Janes wrote: Tested-by: Mark Janes Brian Paul writes:

Re: [Mesa-dev] [PATCH 05/12] i965/cs: Split out helper for building local id payload

On Thu, Oct 8, 2015 at 1:34 AM, Pohjolainen, Topi wrote: > On Wed, Oct 07, 2015 at 07:11:45AM -0700, Kristian H?gsberg Kristensen wrote: >> The initial motivation for this patch was to avoid calling >> brw_cs_prog_local_id_payload_dwords() in gen7_cs_state.c from the >> compiler. This commit ends

Re: [Mesa-dev] [PATCH 05/12] i965/cs: Split out helper for building local id payload

On Thu, Oct 08, 2015 at 10:53:59AM -0700, Kristian H?gsberg wrote: > On Thu, Oct 8, 2015 at 1:53 AM, Pohjolainen, Topi > wrote: > > On Wed, Oct 07, 2015 at 07:11:45AM -0700, Kristian H?gsberg Kristensen > > wrote: > >> The initial motivation for this patch was to avoid calling > >> brw_cs_prog_lo

Re: [Mesa-dev] [PATCH 1/7] glsl: move gl_shader_stage_name() definition to shader_enums.h

On Thu, Oct 8, 2015 at 1:52 PM, Emil Velikov wrote: > On 8 October 2015 at 18:08, Ilia Mirkin wrote: >> On Thu, Oct 8, 2015 at 1:09 PM, Emil Velikov >> wrote: >>> This is a trivial enough function that can live in the header. While >>> we're here, add a STATIC_ASSERT for good measure. >>> >>> S

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

Tested-by: Mark Janes Brian Paul writes: > Callers of create_texture() will either pass target=0 or a validated > GL texture target enum so no need to do another error check inside > the loop. > --- > src/mesa/main/texobj.c | 11 ++- > 1 file changed, 2 insertions(+), 9 deletions(-) >

Re: [Mesa-dev] [PATCH 05/12] i965/cs: Split out helper for building local id payload

On Thu, Oct 8, 2015 at 1:53 AM, Pohjolainen, Topi wrote: > On Wed, Oct 07, 2015 at 07:11:45AM -0700, Kristian H?gsberg Kristensen wrote: >> The initial motivation for this patch was to avoid calling >> brw_cs_prog_local_id_payload_dwords() in gen7_cs_state.c from the >> compiler. This commit ends

Re: [Mesa-dev] [PATCH 1/7] glsl: move gl_shader_stage_name() definition to shader_enums.h

On 8 October 2015 at 18:08, Ilia Mirkin wrote: > On Thu, Oct 8, 2015 at 1:09 PM, Emil Velikov wrote: >> This is a trivial enough function that can live in the header. While >> we're here, add a STATIC_ASSERT for good measure. >> >> Signed-off-by: Emil Velikov >> --- >> src/glsl/shader_enums.c |

Re: [Mesa-dev] [PATCH 02/12] util: Move DRI parse_debug_string() to util

On Thu, Oct 8, 2015 at 6:43 AM, Iago Toral wrote: > Moe than moving, this patch is duplicating it... wouldn't it be better > if we moved it for real? Seems like it would only be a matter of adding > #include "util/debug.h" s/driParseDebugString/parse_debug_string/ in the > following files: > > ./s

Re: [Mesa-dev] [PATCH 02/12] util: Move DRI parse_debug_string() to util

On Thu, Oct 8, 2015 at 12:03 AM, Pohjolainen, Topi wrote: > On Wed, Oct 07, 2015 at 07:11:42AM -0700, Kristian H?gsberg Kristensen wrote: >> We want to use intel_debug.c in code that doesn't link to dri common. >> >> Signed-off-by: Kristian Høgsberg Kristensen >> --- >> src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH 4/4] glsl: In later GLSL versions, sequence operator is cannot be a constant expression

On 10/08/2015 03:31 AM, Iago Toral wrote: > On Wed, 2015-10-07 at 14:34 -0700, Ian Romanick wrote: >> From: Ian Romanick >> >> Fixes: >> ES3-CTS.shaders.negative.constant_sequence >> >> spec/glsl-es-3.00/compiler/global-initializer/from-sequence.vert >> spec/glsl-es-3.00/compiler/globa

Re: [Mesa-dev] [PATCH] mesa: Correctly handle GL_BGRA_EXT in ES3 format_and_type checks

No regressions were indicated by this patch. However, the initial regression did not trigger any test failures, either. It is unacceptable for such an obvious regression to pass Mesa's automated test suites. I re-opened the bug, pending the creation of suitable tests. -Mark Emil Velikov write

Re: [Mesa-dev] make distclean failing

On 8 October 2015 at 16:56, Rob Clark wrote: > On Thu, Oct 8, 2015 at 11:39 AM, Emil Velikov > wrote: >> On 8 October 2015 at 16:12, Matt Turner wrote: >>> On Thu, Oct 8, 2015 at 6:56 AM, Rob Clark wrote: On Wed, Oct 7, 2015 at 6:00 PM, Andy Furniss wrote: > Noticed recently that mak

[Mesa-dev] [Bug 92265] Black windows in weston after update mesa to 11.0.2-1

https://bugs.freedesktop.org/show_bug.cgi?id=92265 Mark Janes changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

Re: [Mesa-dev] [PATCH 1/7] glsl: move gl_shader_stage_name() definition to shader_enums.h

On Thu, Oct 8, 2015 at 1:09 PM, Emil Velikov wrote: > This is a trivial enough function that can live in the header. While > we're here, add a STATIC_ASSERT for good measure. > > Signed-off-by: Emil Velikov > --- > src/glsl/shader_enums.c | 13 - > src/glsl/shader_enums.h | 23 ++

Re: [Mesa-dev] [PATCH 1/4] glsl: Only set ir_variable::constant_value for const-decorated variables

On 10/08/2015 02:50 AM, Iago Toral wrote: > On Wed, 2015-10-07 at 14:34 -0700, Ian Romanick wrote: >> From: Ian Romanick >> >> Right now we're also setting for uniforms, and that doesn't seem to hurt >> things. The next patch will make general global variables in GLSL ES, >> and those definitely

[Mesa-dev] [PATCH 7/7] glsl: remove shader_enums.c

It's an empty file now. Signed-off-by: Emil Velikov --- src/Makefile.am | 1 - src/glsl/shader_enums.c | 34 -- src/mesa/Makefile.sources | 4 +--- 3 files changed, 1 insertion(+), 38 deletions(-) delete mode 100644 src/glsl/shader_enums.c diff --g

[Mesa-dev] [PATCH 6/7] glsl: move gl_frag_result_name() definition to shader_enums.h

This is a trivial enough function that can live in the header. While we're here, add a STATIC_ASSERT for good measure. Move FRAG_RESULT_MAX macro to shader_enums.h Signed-off-by: Emil Velikov --- src/glsl/shader_enums.c | 18 -- src/glsl/shader_enums.h | 26 +

[Mesa-dev] [PATCH 2/7] glsl: move gl_vert_attrib_name() definition to shader_enums.h

This is a trivial enough function that can live in the header. While we're here, add a STATIC_ASSERT for good measure. Signed-off-by: Emil Velikov --- src/glsl/shader_enums.c | 40 src/glsl/shader_enums.h | 45 -

[Mesa-dev] [PATCH 5/7] glsl: move glsl_interp_qualifier_name() definition to shader_enums.h

This is a trivial enough function that can live in the header. While we're here, add a STATIC_ASSERT for good measure. Signed-off-by: Emil Velikov --- src/glsl/shader_enums.c | 11 --- src/glsl/shader_enums.h | 16 +++- 2 files changed, 15 insertions(+), 12 deletions(-) diff

[Mesa-dev] [PATCH 1/7] glsl: move gl_shader_stage_name() definition to shader_enums.h

This is a trivial enough function that can live in the header. While we're here, add a STATIC_ASSERT for good measure. Signed-off-by: Emil Velikov --- src/glsl/shader_enums.c | 13 - src/glsl/shader_enums.h | 23 +-- 2 files changed, 21 insertions(+), 15 deletions

[Mesa-dev] [PATCH 3/7] glsl: move gl_varying_slot_name() definition to shader_enums.h

This is a trivial enough function that can live in the header. While we're here, add a STATIC_ASSERT for good measure. Move VARYING_SLOT_MAX macro to shader_enums.h Signed-off-by: Emil Velikov --- src/glsl/shader_enums.c | 65 src/glsl/shader_enums.h

[Mesa-dev] [PATCH 4/7] glsl: move gl_system_value_name() definition to shader_enums.h

This is a trivial enough function that can live in the header. While we're here, add a STATIC_ASSERT for good measure. Add the missing SYSTEM_VALUE_NUM_WORK_GROUPS enum. Signed-off-by: Emil Velikov --- src/glsl/shader_enums.c | 24 src/glsl/shader_enums.h | 30 +

[Mesa-dev] [Bug 92122] [bisected, cts] Regression with Assault Android Cactus

https://bugs.freedesktop.org/show_bug.cgi?id=92122 Alex Deucher changed: What|Removed |Added CC||kylesiefr...@gmail.com --- Comment #18 fr

Re: [Mesa-dev] [PATCH 03/12] i965: Configure bufmgr debug options from intel_screen.c

On Thu, Oct 8, 2015 at 6:52 AM, Iago Toral wrote: > On Thu, 2015-10-08 at 10:07 +0300, Pohjolainen, Topi wrote: >> On Wed, Oct 07, 2015 at 07:11:43AM -0700, Kristian H?gsberg Kristensen wrote: >> > We need the debug flag parsing and INTEL_DEBUG in the compiler, but we >> > don't want the dependenc

Re: [Mesa-dev] [PATCH 2/3] mesa: remove unused _mesa_create_nameless_texture()

On Thu, Oct 8, 2015 at 7:20 AM, Brian Paul wrote: > --- > src/mesa/main/texobj.c | 20 > src/mesa/main/texobj.h | 3 --- > 2 files changed, 23 deletions(-) > > diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c > index aa4b38c..66eacf8 100644 > --- a/src/mesa/main/

Re: [Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

On Thu, Oct 8, 2015 at 7:20 AM, Brian Paul wrote: > Callers of create_texture() will either pass target=0 or a validated > GL texture target enum so no need to do another error check inside > the loop. > --- > src/mesa/main/texobj.c | 11 ++- > 1 file changed, 2 insertions(+), 9 deletions

Re: [Mesa-dev] [PATCH 4/6] nir: add shader_clock intrinsic

On Thu, Oct 8, 2015 at 10:09 AM, Emil Velikov wrote: > On 8 October 2015 at 14:20, Connor Abbott wrote: >> On Thu, Oct 8, 2015 at 6:54 AM, Emil Velikov >> wrote: >>> On 7 October 2015 at 23:50, Connor Abbott wrote: On Wed, Oct 7, 2015 at 4:48 PM, Emil Velikov wrote: > On 7 Octo

Re: [Mesa-dev] make distclean failing

On Thu, Oct 8, 2015 at 11:39 AM, Emil Velikov wrote: > On 8 October 2015 at 16:12, Matt Turner wrote: >> On Thu, Oct 8, 2015 at 6:56 AM, Rob Clark wrote: >>> On Wed, Oct 7, 2015 at 6:00 PM, Andy Furniss wrote: Noticed recently that make distclean is failing for me - Making distcl

Re: [Mesa-dev] make distclean failing

On 8 October 2015 at 16:12, Matt Turner wrote: > On Thu, Oct 8, 2015 at 6:56 AM, Rob Clark wrote: >> On Wed, Oct 7, 2015 at 6:00 PM, Andy Furniss wrote: >>> Noticed recently that make distclean is failing for me - >>> >>> Making distclean in mesa >>> make[2]: Entering directory '/mnt/sdb1/Src64/

Re: [Mesa-dev] [PATCH V7 21/24] glsl: build ubo name and indexing offset for AoA

On 07/10/15 00:47, Timothy Arceri wrote: > --- > src/glsl/lower_ubo_reference.cpp | 119 > --- > 1 file changed, 87 insertions(+), 32 deletions(-) > > diff --git a/src/glsl/lower_ubo_reference.cpp > b/src/glsl/lower_ubo_reference.cpp > index 247620e..7e983d0

Re: [Mesa-dev] make distclean failing

On Thu, Oct 8, 2015 at 6:56 AM, Rob Clark wrote: > On Wed, Oct 7, 2015 at 6:00 PM, Andy Furniss wrote: >> Noticed recently that make distclean is failing for me - >> >> Making distclean in mesa >> make[2]: Entering directory '/mnt/sdb1/Src64/Mesa-git/mesa/src/mesa' >> Makefile:2486: ../glsl/.deps

Re: [Mesa-dev] [PATCH] nir: Mark the shader name during nir_sweep

On Thu, Oct 8, 2015 at 7:58 AM, Neil Roberts wrote: > Previously the name of the nir shader was being freed prematurely > during nir_sweep. Since 756613ed35d the name was later being used to > generate filenames for the optimiser debug output and these would end > up with garbage from the dangling

Re: [Mesa-dev] [PATCH] nir/sweep: Reparent the shader name

Oops, I just made a similar patch without noticing this one. Feel free to take the commit message from my patch if you want. Either way this one is: Reviewed-by: Neil Roberts http://patchwork.freedesktop.org/patch/61369/ Sorry for the noise. Regards, - Neil Jason Ekstrand writes: > --- > s

Re: [Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

Am 08.10.2015 um 16:46 schrieb Marek Olšák: > > On Oct 8, 2015 4:03 PM, "Roland Scheidegger" > wrote: >> >> Was that because stencil used sampler 1 but sview 0 which looks >> definitely wrong as there needs o be a 1:1 mapping between these when >> the tex opcodes are us

[Mesa-dev] [PATCH] nir: Mark the shader name during nir_sweep

Previously the name of the nir shader was being freed prematurely during nir_sweep. Since 756613ed35d the name was later being used to generate filenames for the optimiser debug output and these would end up with garbage from the dangling pointer. --- src/glsl/nir/nir_sweep.c | 3 +++ 1 file chang

Re: [Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

On Oct 8, 2015 4:03 PM, "Roland Scheidegger" wrote: > > Was that because stencil used sampler 1 but sview 0 which looks > definitely wrong as there needs o be a 1:1 mapping between these when > the tex opcodes are used? I don't remember how the SVIEW declarations work. It was TEX and there were 2

Re: [Mesa-dev] [PATCH 0/4] program: removal of Mesa IR functions

On 10/07/2015 06:11 PM, Marek Olšák wrote: Hi, Some of these functions became unused after I made the big st/mesa patch series. Hopefully, nobody will miss them. The last one is a cleanup. Please review. LGTM. Reviewed-by: Brian Paul ___ mesa-de

Re: [Mesa-dev] [PATCH 10/17] st/mesa: make Z/S drawpix shaders independent of variants, don't use Mesa IR

On 10/07/2015 06:02 PM, Marek Olšák wrote: Hi Brian, This is the commit that broke DrawPixels on llvmpipe, but not radeonsi and softpipe. It's fixed in v2, which is attached. Thanks. That fixes the conform and piglit regressions. For the series, Reviewed-by: Brian Paul Tested-by: Brian Pau

[Mesa-dev] [PATCH 2/3] mesa: remove unused _mesa_create_nameless_texture()

--- src/mesa/main/texobj.c | 20 src/mesa/main/texobj.h | 3 --- 2 files changed, 23 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index aa4b38c..66eacf8 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -1185,26 +1185,6 @@ inval

[Mesa-dev] [PATCH 1/3] mesa: remove unneeded error check in create_textures()

Callers of create_texture() will either pass target=0 or a validated GL texture target enum so no need to do another error check inside the loop. --- src/mesa/main/texobj.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj

  1   2   >