[Mesa-dev] [PATCH 3/8] [v2] i965: Add viewport extents (gen8) to batch decode

2015-05-15 Thread Ben Widawsky
0x7da0: 0xc1da740e: SF_CLIP VP: guardband xmin = -27.306667 0x7da4: 0x41da740e: SF_CLIP VP: guardband xmax = 27.306667 0x7da4: 0x41da740e: SF_CLIP VP: guardband ymin = -23.405714 0x7da8: 0xc1bb3ee7: SF_CLIP VP: guardband ymax = 23.405714 0x7db0: 0x00

[Mesa-dev] [PATCH 5/8] [v2] i965: Add gen8 surface state debug info

2015-05-15 Thread Ben Widawsky
AFAICT, none of the old data was wrong (the gen7 decoder), but it wa smissing a bunch of stuff. Adds a tick (') to denote the beginning of the surface state for easier reading. This will be replaced later with some better, but more risky code. OLD: 0x7980: 0x23016000: SURF: 2D BRW_SU

[Mesa-dev] [PATCH 4/8] [v2] i965: Add gen7+ sampler state to batch debug

2015-05-15 Thread Ben Widawsky
OLD: 0x7e00: 0x1000: WM SAMP0: filtering 0x7e04: 0x000d: WM SAMP0: wrapping, lod 0x7e08: 0x: WM SAMP0: default color pointer 0x7e0c: 0x0090: WM SAMP0: chroma key, aniso NEW: 0x7e00: 0x1000: SAMPLER_STATE 0: Disabled = no, Base Mi

[Mesa-dev] [PATCH 6/8] [v2] i965: Add Gen9 surface state decoding

2015-05-15 Thread Ben Widawsky
Gen9 surface state is very similar to the previous generation. The important changes here are aux mode, and the way clear colors work. NOTE: There are some things intentionally left out of this decoding. v2: Redo the string for the aux buffer type to address compressed variants. Signed-off-by: B

[Mesa-dev] [PATCH 7/8] [v3] i965: Add renderbuffer surface indexes to debug

2015-05-15 Thread Ben Widawsky
This patch is optional in the series. It does make the output much cleaner, but there is some risk. Sample output (v3): 0x7e80: 0x231d7000: SURF000: 2D R8G8B8A8_UNORM VALIGN4 HALIGN4 Y-tiled 0x7e84: 0x0500: SURF000: MOCS: 0x5 Base MIP: 0.0 (0 mips) Surface QPitch: 0 0x00

[Mesa-dev] [PATCH 2/8] [v3] i965: Add all surface types to the batch decode

2015-05-15 Thread Ben Widawsky
It's true that not all surfaces apply for every gen, but for the most part this is what we want. (The unfortunate case is when we use an valid surface, but not for the specific GEN). This was automated with a vim macro. v2: Shortened common forms such as R8G8B8A8->RGBA8. Note that this makes some

[Mesa-dev] [PATCH 8/8] [v2] i965: Add gen8 blend state

2015-05-15 Thread Ben Widawsky
OLD: 0x7340: 0x0080:BLEND: 0x7344: 0x84202100:BLEND: NEW: 0x7340: 0x0080:BLEND: Alpha blend/test 0x7344: 0x000b84202100: BLEND_ENTRY00: Color Buffer Blend factor ONE,ONE,ONE,ONE (src,dst,src alpha, dst alpha)

[Mesa-dev] [PATCH 1/8] i965: Add string for surface format to table

2015-05-15 Thread Ben Widawsky
Recommended-by: Kenneth Graunke Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_surface_formats.c | 436 1 file changed, 219 insertions(+), 217 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_surface_formats.c b/src/mesa/drivers/dri/i965/brw_surfa

Re: [Mesa-dev] [PATCH:mesa] swrast: Build fix for Solaris

2015-05-15 Thread Alan Coopersmith
Ah yes, I see Jons patch now in https://bugs.freedesktop.org/show_bug.cgi?id=90147#c9 That looks like it should work for Solaris too, so whichever the Mesa developers prefer... -alan- On 05/15/15 07:16 PM, Jeremy Huddleston Sequoia wrote: Looks right to me. I think this was also menti

Re: [Mesa-dev] [PATCH 5/7] i965: Add Gen9 surface state decoding

2015-05-15 Thread Ben Widawsky
On Fri, May 15, 2015 at 08:22:29PM -0700, Ben Widawsky wrote: > On Fri, Apr 24, 2015 at 09:05:44PM +0300, Pohjolainen, Topi wrote: > > On Thu, Apr 23, 2015 at 04:50:02PM -0700, Ben Widawsky wrote: > > > Gen9 surface state is very similar to the previous generation. The > > > important > > > change

Re: [Mesa-dev] [PATCH 5/7] i965: Add Gen9 surface state decoding

2015-05-15 Thread Ben Widawsky
On Fri, Apr 24, 2015 at 09:05:44PM +0300, Pohjolainen, Topi wrote: > On Thu, Apr 23, 2015 at 04:50:02PM -0700, Ben Widawsky wrote: > > Gen9 surface state is very similar to the previous generation. The important > > changes here are aux mode, and the way clear colors work. > > > > NOTE: There are

Re: [Mesa-dev] [PATCH 4/7] i965: Add gen8 surface state debug info

2015-05-15 Thread Ben Widawsky
On Fri, May 15, 2015 at 07:49:44PM -0700, Ben Widawsky wrote: > On Thu, Apr 23, 2015 at 09:35:23PM -0700, Matt Turner wrote: > > On Thu, Apr 23, 2015 at 4:50 PM, Ben Widawsky > > wrote: > > > AFAICT, none of the old data was wrong (the gen7 decoder), but it wa > > > smissing a > > > bunch of stuf

Re: [Mesa-dev] [PATCH 4/7] i965: Add gen8 surface state debug info

2015-05-15 Thread Ben Widawsky
On Thu, Apr 23, 2015 at 09:35:23PM -0700, Matt Turner wrote: > On Thu, Apr 23, 2015 at 4:50 PM, Ben Widawsky > wrote: > > AFAICT, none of the old data was wrong (the gen7 decoder), but it wa > > smissing a > > bunch of stuff. > > > > Adds a tick (') to denote the beginning of the surface state fo

Re: [Mesa-dev] [PATCH:mesa] swrast: Build fix for Solaris

2015-05-15 Thread Jeremy Huddleston Sequoia
Looks right to me. I think this was also mentioned in the bugzilla ticket where this change was committed from. Reviewed-by: Jeremy Huddleston Sequoia > On May 15, 2015, at 19:05, Alan Coopersmith > wrote: > > Fixes regression from commit 5b2d3480f57168d50ad24cf0b8c9244414bd3701 > > Signed

[Mesa-dev] [PATCH:mesa] swrast: Build fix for Solaris

2015-05-15 Thread Alan Coopersmith
Fixes regression from commit 5b2d3480f57168d50ad24cf0b8c9244414bd3701 Signed-off-by: Alan Coopersmith CC: Jeremy Huddleston Sequoia --- configure.ac |1 + src/mesa/drivers/dri/swrast/swrast.c |4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v3)

2015-05-15 Thread Jason Ekstrand
On May 15, 2015 2:40 PM, "Francisco Jerez" wrote: > > Jason Ekstrand writes: > > > On Fri, May 15, 2015 at 9:51 AM, Francisco Jerez wrote: > >> Jason Ekstrand writes: > >> > >>> I haven't said much about this series up until now. I've mostly sat > >>> and watched and focused my time on other t

Re: [Mesa-dev] [PATCH 00/74] ARB_shader_storage_buffer_object (mesa, i965)

2015-05-15 Thread Jordan Justen
On 2015-05-14 07:06:03, Iago Toral Quiroga wrote: > Notice that NIR is not supported yet, so anyone wanting to test this on > i965 needs to set INTEL_USE_NIR=0. We aren't going to get this feature in 10.6, and the non-nir support is planned to be removed shortly after the 10.6 branch. So, this is

[Mesa-dev] [Bug 90457] New Account Request

2015-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90457 --- Comment #4 from Carl Worth --- (In reply to Brian Paul from comment #3) > Normally we don't give git privileges until after the individual has some > history of submitting some good patches. Right. > Carl, is Nanley is a coworker of your's

Re: [Mesa-dev] [RFC: PATCH 4/4] i965: Refactor all upload__prog functions up into brw_upload_programs

2015-05-15 Thread Carl Worth
Yes. That patch was severely broken in several ways. In its place, here is a pair of patches intending to do the same thing in two steps. Thanks to Ken for helpful review and guidance to get to this point. At this point, I'm quite confident that the logic of the code is undisturbed by the refacto

[Mesa-dev] [PATCH 1/2] i965: Refactor brw_upload_programs by inlining per-stage upload functions

2015-05-15 Thread Carl Worth
In this commit, the function bodies of each of the brw_upload__prog functions are manually inlined into brw_upload_programs. This commit is intended to have no functional change. The resulting function body of brw_upload_programs is fairly messy, and is expected to be cleaned up by subsequent comm

[Mesa-dev] [PATCH 2/2] i965: Refactor brw_upload_programs with a loop over each stage

2015-05-15 Thread Carl Worth
This refactor idetnfies as much common code as possible across the various stages within brw_upload_programs. The resulting code is a loop over all relevant stages and various accessory functions (per_stage_state_dirty, per_stage_populate_key, per_stage_codegen, and per_stage_vue_map_update), whene

Re: [Mesa-dev] Mesa (master): 57 new commits

2015-05-15 Thread Fredrik Höglund
On Friday 15 May 2015, Ian Romanick wrote: > On 05/15/2015 12:10 PM, Fredrik Höglund wrote: > > On Friday 15 May 2015, Ian Romanick wrote: > >> On 05/15/2015 05:26 AM, Fredrik Höglund wrote: > >> I'm also going to say that I'm quite pissed that this series landed > >> without my objections being ad

Re: [Mesa-dev] [PATCH V2 01/22] meta: Enable _mesa_meta_pbo_GetTexSubImage() to read in to non-pbo buffers

2015-05-15 Thread Anuj Phogat
On Tue, Apr 21, 2015 at 3:20 PM, Neil Roberts wrote: > > Anuj Phogat writes: > > > This will allow Skylake to use _mesa_meta_pbo_GetTexSubImage() for reading > > YF/YS > > tiled surfaces. > > > > V2: Make changes suggested by Neil. > > > > Signed-off-by: Anuj Phogat > > Cc: Neil Roberts > > --

Re: [Mesa-dev] [PATCH 1/7] i965: Move texture buffer dispatch into single location

2015-05-15 Thread Matt Turner
On Thu, May 7, 2015 at 8:01 AM, Pohjolainen, Topi wrote: > If Ken and Matt are happy with this series, so am I. I'm just glad if we > can land it. I don't have a preference. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedeskt

Re: [Mesa-dev] Glamor wiki page is obsolete

2015-05-15 Thread Emil Velikov
On 15 May 2015 at 21:09, Emil Velikov wrote: > This page is obsolete, please update or remove it: > > http://www.freedesktop.org/wiki/Software/Glamor/ > Haha, not sure who managed to spoof this one but well done sir. We're making improvements over the xorg-devel version [1] :-) -Emil [1] http://

Re: [Mesa-dev] [PATCH 3/6] i965/fs: Add set_sechalf() method.

2015-05-15 Thread Francisco Jerez
Matt Turner writes: > Used in the next commit. > --- > src/mesa/drivers/dri/i965/brw_ir_fs.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_ir_fs.h > b/src/mesa/drivers/dri/i965/brw_ir_fs.h > index 7ac7ff8..a79713c 100644 > --- a/src/mesa/driv

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v3)

2015-05-15 Thread Francisco Jerez
Jason Ekstrand writes: > On Fri, May 15, 2015 at 9:51 AM, Francisco Jerez > wrote: >> Jason Ekstrand writes: >> >>> I haven't said much about this series up until now. I've mostly sat >>> and watched and focused my time on other things. As I said in the >>> meeting today, I think that part o

Re: [Mesa-dev] [PATCH 00/20] glapi yak shaving and GLES 3.1 enabling

2015-05-15 Thread Emil Velikov
On 15/05/15 18:29, Ian Romanick wrote: > On 05/14/2015 03:01 PM, Emil Velikov wrote: >> Hi Ian, >> >> On 13/05/15 19:44, Ian Romanick wrote: >>> We've known for a long time that having all those tags in the >>> entries in the XML is bad. For example, people cut-and-paste for >>> everything, and,

[Mesa-dev] Glamor wiki page is obsolete

2015-05-15 Thread Emil Velikov
This page is obsolete, please update or remove it: http://www.freedesktop.org/wiki/Software/Glamor/ Thanks ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 90438] glxinfo should have a quiet mode

2015-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90438 --- Comment #3 from Brian Paul --- Just minor nits: 1. I'll fix up some indentation/formatting issues. 2. I think 'quiet' isn't quite the right term. How about 'brief' using -B as the flag (since -b is already taken)? 3. I'll also update wglinfo

[Mesa-dev] [PATCH 0/6] i965/fs: Integer multiplication improvements

2015-05-15 Thread Matt Turner
This series reworks how we do integer multiplication in the i965/fs backend and significantly improves code generation for Broadwell's scalar vertex shaders with NIR by allowing constant propagation into the MUL instruction (wow that code was stupid, and it still kind of is!). Before this series,

[Mesa-dev] [PATCH 5/6] i965/fs: Rework compression control selection.

2015-05-15 Thread Matt Turner
The next commit uses an add(16) with a UW destination with a stride of 2, which needs compression control since it's writing two registers. The old code would have failed to set compression control correctly. --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 9 ++--- 1 file changed, 6 inser

[Mesa-dev] [PATCH 6/6] i965/fs: Implement integer multiply without mul/mach.

2015-05-15 Thread Matt Turner
Ivybridge and Baytrail can't use mach with 2Q quarter control, so just do it without the accumulator. Stupid accumulator. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 94 +--- 1 file changed, 66 insertions(+), 28 deletions(-) diff --git a/src/mesa/drivers/dri/i965/br

[Mesa-dev] [PATCH 2/6] i965/fs: Unrestrict constant propagation into integer multiply.

2015-05-15 Thread Matt Turner
Gen8+'s MUL instruction doesn't ignore the high 16-bits of one source like on earlier platforms, so we can constant propagate into it without worry. Integer multiplies (not into the accumulator, which is done for imul_high) are lowered in lower_integer_multiplication(), so it's safe there as well.

[Mesa-dev] [PATCH 1/6] i965/fs: Lower integer multiplication after optimizations.

2015-05-15 Thread Matt Turner
32-bit x 32-bit integer multiplication requires multiple instructions until Broadwell. This patch just lets us treat the MUL instruction in the FS backend like it operates on Broadwell, and after optimizations we lower it into a sequence of instructions on older platforms. Doing this will allow us

[Mesa-dev] [PATCH 4/6] i965/fs: Support integer multiplication in SIMD16 on Haswell.

2015-05-15 Thread Matt Turner
Ivybridge (and presumably Baytrail) have a bug that prevents this from working. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 52 1 file changed, 47 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_f

[Mesa-dev] [PATCH 3/6] i965/fs: Add set_sechalf() method.

2015-05-15 Thread Matt Turner
Used in the next commit. --- src/mesa/drivers/dri/i965/brw_ir_fs.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_ir_fs.h b/src/mesa/drivers/dri/i965/brw_ir_fs.h index 7ac7ff8..a79713c 100644 --- a/src/mesa/drivers/dri/i965/brw_ir_fs.h +++ b/src/mesa

Re: [Mesa-dev] [PATCH] Fix symbol 'x86_64_entry_start' is already defined when building with LLVM/clang

2015-05-15 Thread Emil Velikov
On 15/05/15 20:25, Brian Paul wrote: > Has the patch also been tested with gcc? > > If these are now extern declarations, where's the actual definition of > the symbols? > > The reason patches like this sit around for a while is because few > people understand the ramifications or potential side

Re: [Mesa-dev] [PATCH] mesa: do not use _glapi_new_nop_table() for DRI builds

2015-05-15 Thread Emil Velikov
On 15/05/15 17:58, Brian Paul wrote: > On 05/15/2015 11:14 AM, Emil Velikov wrote: >> On 15/05/15 15:13, Brian Paul wrote: >>> Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table() and >>> _glapi_set_nop_handler() functions in the glapi dispatcher (which >>> live in libGL.so). The calls to th

Re: [Mesa-dev] [PATCH] Fix symbol 'x86_64_entry_start' is already defined when building with LLVM/clang

2015-05-15 Thread Brian Paul
Has the patch also been tested with gcc? If these are now extern declarations, where's the actual definition of the symbols? The reason patches like this sit around for a while is because few people understand the ramifications or potential side effects and are hesitant to give an R-b. -Br

Re: [Mesa-dev] [PATCH] st/mesa: Flush the bitmap cache in st_BlitFramebuffer

2015-05-15 Thread Fredrik Höglund
On Friday 15 May 2015, Brian Paul wrote: > On 05/15/2015 12:10 PM, Fredrik Höglund wrote: > > With DSA we can no longer rely on this being done in st_validate_state > > in response to the framebuffer bindings having changed. > > > > This fixes the ext_framebuffer_multisample-bitmap piglit test. > >

Re: [Mesa-dev] Mesa (master): 57 new commits

2015-05-15 Thread Ian Romanick
On 05/15/2015 12:10 PM, Fredrik Höglund wrote: > On Friday 15 May 2015, Ian Romanick wrote: >> On 05/15/2015 05:26 AM, Fredrik Höglund wrote: >>> On Friday 15 May 2015, Michel Dänzer wrote: On 14.05.2015 22:52, fred...@kemper.freedesktop.org (Fredrik HXXglund) wrote: > > URL:

Re: [Mesa-dev] [PATCH 14/20] glapi: Use the offsets from static_data.py instead of from the XML

2015-05-15 Thread Dylan Baker
Reviewed-by: Dylan Baker On Wed, May 13, 2015 at 12:44:42PM -0700, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Cc: Dylan Baker > --- > src/mapi/glapi/gen/gl_XML.py | 22 +- > 1 file changed, 5 insertions(+), 17 deletions(-) > > diff --git a

Re: [Mesa-dev] [PATCH 15/20] i915: Enable intel_render path for points

2015-05-15 Thread Ian Romanick
There are some really twitchy tests in ES1 (and possibly ES2) conformance related to this. Do any of those tests change with this commit? On 03/23/2015 05:47 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The sub-pixel adjustment for points was killed off in > commit 60d762

Re: [Mesa-dev] [PATCH 06/20] glapi: Whitespace clean up after the previous commit

2015-05-15 Thread Dylan Baker
With an opinion on using json rather than python for this data: Patches 3-6: Reviewed-by: Dylan Baker signature.asc Description: Digital signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/m

Re: [Mesa-dev] [PATCH 12/20] i915: Make hw_prim[] const

2015-05-15 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 03/23/2015 05:47 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The table used to map the GL primitive to the hw primitive never > changes so make it const. > > Signed-off-by: Ville Syrjälä > --- > src/mesa/drivers/dri/i915/inte

Re: [Mesa-dev] [PATCH 07/20] t_dd_dmatmp: Make the render_tab[]s const

2015-05-15 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 03/23/2015 05:47 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > These tables hold function pointers and they never change so > make them const. > > Signed-off-by: Ville Syrjälä > --- > src/mesa/tnl_dd/t_dd_dmatmp.h | 4 ++-- > 1

Re: [Mesa-dev] [PATCH 14/20] i915: Use COPY_DWORDS for points

2015-05-15 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 03/23/2015 05:47 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The sub-pixel adjustment for points was killed off in > commit 60d762aa625095a8c1f9597d8530bb5a6fa61b4c > Author: Xiang, Haihao > Date: Wed Jan 2 11:38:51 2008 +

Re: [Mesa-dev] [PATCH 03/20] glapi: Store static dispatch offsets in a separate table

2015-05-15 Thread Dylan Baker
On Wed, May 13, 2015 at 12:44:31PM -0700, Ian Romanick wrote: > From: Ian Romanick [snip] > diff --git a/src/mapi/glapi/gen/static_data.py > b/src/mapi/glapi/gen/static_data.py > new file mode 100644 > index 000..2ce093c > --- /dev/null > +++ b/src/mapi/glapi/gen/static_data.py > @@ -0,0 +1

Re: [Mesa-dev] [PATCH 13/20] i915: Use c99 initializers for primitive arrays

2015-05-15 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 03/23/2015 05:47 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Using c99 initializers for the primitive arrays makes things more > readable. > > Signed-off-by: Ville Syrjälä > --- > src/mesa/drivers/dri/i915/intel_render.c | 60

Re: [Mesa-dev] [PATCH 09/20] i915: Handle provoking vertex in intelFastRenderClippedPoly()

2015-05-15 Thread Ian Romanick
This patch seems obviously correct and is Reviewed-by: Ian Romanick On 03/23/2015 05:47 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > intelFastRenderClippedPoly() renders the polygon using triangles. For > polygons the provoking vertex is always the first one, and currentl

Re: [Mesa-dev] Mesa (master): 57 new commits

2015-05-15 Thread Fredrik Höglund
On Friday 15 May 2015, Ian Romanick wrote: > On 05/15/2015 05:26 AM, Fredrik Höglund wrote: > > On Friday 15 May 2015, Michel Dänzer wrote: > >> On 14.05.2015 22:52, fred...@kemper.freedesktop.org (Fredrik HXXglund) > >> wrote: > >>> > >>> URL: > >> http://cgit.freedesktop.org/mesa/mesa/commit/?id=

Re: [Mesa-dev] [PATCH 08/20] i915: Fix collision between I830_UPLOAD_RASTER_RULES and I830_UPLOAD_TEX(0)

2015-05-15 Thread Ian Romanick
This patch seems obviously correct and is Reviewed-by: Ian Romanick On 03/23/2015 05:47 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > I830_UPLOAD_RASTER_RULES and I830_UPLOAD_TEX(0) are trying to occupy > the same bit. Move the texture bits upwards a bit to make room for >

Re: [Mesa-dev] [PATCH] i965: Fix FS unit tests

2015-05-15 Thread Matt Turner
On Fri, May 15, 2015 at 12:06 PM, Kenneth Graunke wrote: > Sorry! > > Reviewed-by: Kenneth Graunke Capital W in your email. idr, please fix this before you commit. :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org

Re: [Mesa-dev] [PATCH 03/20] t_dd_dmatmp: Disallow flat shading when rendering quad strips via tri strips

2015-05-15 Thread Ian Romanick
On 03/23/2015 05:47 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > When rendering quad strips via tri strips we can't get the provoking > vertex right, so disallow flat shading. Same comments as for patch 2. > Signed-off-by: Ville Syrjälä > --- > src/mesa/tnl_dd/t_dd_dmatm

Re: [Mesa-dev] [PATCH 02/20] t_dd_dmatmp: Allow flat shaded polygons with tri fans

2015-05-15 Thread Ian Romanick
On 03/23/2015 05:47 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We can allow rendering flat shaded polygons using tri fans if we check > the provoking vertex convention. This sounds reasonable since it matches the DX behavior. Is there a piglit test that would hit this?

Re: [Mesa-dev] [PATCH] i965: Fix FS unit tests

2015-05-15 Thread Kenneth Graunke
On Friday, May 15, 2015 11:57:16 AM Ian Romanick wrote: > From: Ian Romanick > > Commit 3687d75 changed the fs_visitor constructors, but it didn't update > all the users. As a result, 'make check' fails. > > I added the explicit cast to the gl_program* parameter to make it more > clear which NU

Re: [Mesa-dev] [PATCH 01/20] t_dd_dmatmp: Kill the paths rendering quads/quad strips via indexed vertices

2015-05-15 Thread Ian Romanick
On 03/23/2015 05:47 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > No driver supports elts currently, and these make the validate_render > code a bit hard to follow. Just kill them. It looks like both r200_tcl.c and radeon_tcl.c define HAVE_TRI_STRIPS and HAVE_ELTS, but I gue

[Mesa-dev] [PATCH] i965: Fix FS unit tests

2015-05-15 Thread Ian Romanick
From: Ian Romanick Commit 3687d75 changed the fs_visitor constructors, but it didn't update all the users. As a result, 'make check' fails. I added the explicit cast to the gl_program* parameter to make it more clear which NULL was which. Signed-off-by: Ian Romanick Cc: Kenneth Graunke ---

Re: [Mesa-dev] [PATCH 01/12] nv50/ir: optimize the use of std::tr1::unordered_set

2015-05-15 Thread Ilia Mirkin
Please elaborate why this is necessary. I have, in the past, had requests to move to the C++11 std::unordered_set -- would that work for you? I'd be happy with a #if c++11 is available, use std::unordered_set. Otherwise use std::tr1::unordered_set. On Fri, May 15, 2015 at 2:42 PM, Chih-Wei Huang

[Mesa-dev] [PATCH] Fix symbol 'x86_64_entry_start' is already defined when building with LLVM/clang

2015-05-15 Thread Yunlian Jiang
This is just a re-post of the patch submitted by Tomasz at https://bugs.freedesktop.org/show_bug.cgi?id=89599 Thanks diff -Naur mesa-10.5.2/src/mapi/entry_x86-64_tls.h mesa-10.5.2.tpg/src/mapi/entry_x86-64_tls.h --- mesa-10.5.2/src/mapi/entry_x86-64_tls.h 2015-03-28 18:20:39.0 + +++

[Mesa-dev] [PATCH 03/12] android: loader: export the path to be included

2015-05-15 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang --- src/egl/drivers/dri2/Android.mk | 1 - src/loader/Android.mk | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/Android.mk b/src/egl/drivers/dri2/Android.mk index 5931ce8..d4d809b 100644 --- a/src/egl/drivers/dri2

[Mesa-dev] [PATCH 10/12] android: fix building errors with stlport

2015-05-15 Thread Chih-Wei Huang
In Android the nouveau driver is built with stlport by including libstlport.mk. However, it changes the include paths order to be in favor of external/stlport/stlport. The assert.h defined in it is chosen that causes the building errors on compiling C code. Strictly speaking, stlport should only b

[Mesa-dev] [PATCH 11/12] android: generate files by $(call es-gen)

2015-05-15 Thread Chih-Wei Huang
Use the pre-defined macro es-gen to generate new added files instead of writing new rules manually. The handmade rules that may generate the files before the directory is created result in such an error: /bin/bash: out/target/product/x86/gen/STATIC_LIBRARIES/libmesa_st_mesa_intermediates/main/for

[Mesa-dev] [PATCH 08/12] android: clean up the makefile of libGLES_mesa

2015-05-15 Thread Chih-Wei Huang
Most of the logic for the gallium drivers has been moved to src/gallium/targets/dri/Android.mk. Signed-off-by: Chih-Wei Huang --- src/egl/main/Android.mk | 79 ++--- 1 file changed, 2 insertions(+), 77 deletions(-) diff --git a/src/egl/main/Android.mk

[Mesa-dev] [PATCH 12/12] android: enable the radeonsi driver

2015-05-15 Thread Chih-Wei Huang
Based on the nice work of Paulo Sergio Travaglia . The main modifications are: - Include paths for LLVM header files and shared/static libraries - Set C++ flag "c++11" to avoid compiling errors on LLVM header files - Set defines for LLVM - Add GALLIVM source files - Changes path of libelf library

[Mesa-dev] [PATCH 05/12] android: add rules to build gallium/state_trackers/dri

2015-05-15 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang --- src/gallium/Android.mk| 5 ++- src/gallium/state_trackers/dri/Android.mk | 64 +++ 2 files changed, 67 insertions(+), 2 deletions(-) create mode 100644 src/gallium/state_trackers/dri/Android.mk diff --git a/src/g

[Mesa-dev] [PATCH 07/12] android: enable the rules to build gallium st/dri

2015-05-15 Thread Chih-Wei Huang
The libmesa_dri_common and libmesa_egl_dri2 should not be limited to the classical drivers only. Allow them to be built with the gallium drivers. Signed-off-by: Chih-Wei Huang --- Android.mk | 6 +- src/egl/main/Android.mk | 8 ++-- 2 files changed, 3 insertions(+), 11 delet

[Mesa-dev] [PATCH 09/12] egl/main: let EGL_RECORDABLE_ANDROID be a valid attrib

2015-05-15 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang --- src/egl/main/eglconfig.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/egl/main/eglconfig.h b/src/egl/main/eglconfig.h index 84cb227..7121b3d 100644 --- a/src/egl/main/eglconfig.h +++ b/src/egl/main/eglconfig.h @@ -86,6 +86,7 @@ struct _egl_config

[Mesa-dev] [PATCH 00/12] More Android patches

2015-05-15 Thread Chih-Wei Huang
This is another series of patches for Android. Summary of the changes: * Fix nouveau driver build with Android stlport. * Add gallium_dri.so for Android. This fixes gallium support since 5564c36. * Enable radeonsi driver for Android. * Miscellaneous fixes. Chih-Wei Huang (12): nv50/ir: optimize

[Mesa-dev] [PATCH 04/12] android: export more dirs from libmesa_dri_common

2015-05-15 Thread Chih-Wei Huang
The include paths of libmesa_dri_common are also used by modules that need libmesa_dri_common. Signed-off-by: Chih-Wei Huang --- src/mesa/drivers/dri/common/Android.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/common/Android.mk b/src/mesa/driver

[Mesa-dev] [PATCH 01/12] nv50/ir: optimize the use of std::tr1::unordered_set

2015-05-15 Thread Chih-Wei Huang
Instead of using unordered_set directly, the patch changes to use unordered_set and adds a wrapper template class to convert the iterators to the expected user-defined type. This avoid instantiating the template multiple times and make it be more compatible with stlport. Signed-off-by: Chih-Wei H

[Mesa-dev] [PATCH 06/12] android: add rules to build gallium_dri

2015-05-15 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang --- src/gallium/Android.mk | 7 +- src/gallium/targets/dri/Android.mk | 110 +++ src/gallium/winsys/sw/dri/Android.mk | 35 ++ src/gallium/winsys/sw/kms-dri/Android.mk | 37 +++ 4 files chang

[Mesa-dev] [PATCH 02/12] android: make the code be compatible with stlport

2015-05-15 Thread Chih-Wei Huang
The android's stlport doesn't have tr1/unordered_set but unordered_set. Signed-off-by: Chih-Wei Huang --- src/egl/main/Android.mk | 5 +++-- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 5 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/egl/main/

Re: [Mesa-dev] [PATCH 44/57] mesa: Add ARB_direct_state_access checks in XFB functions

2015-05-15 Thread Ilia Mirkin
On Fri, May 15, 2015 at 2:29 PM, Ian Romanick wrote: > On 05/14/2015 12:51 PM, Ilia Mirkin wrote: >> Don't you have to add the checks either way? And should these have just been >> >> if (ctx->API != CORE && (ctx->API != COMPAT || ctx->Version < 20)) { >> ... >> } >> >> And removing compat will

Re: [Mesa-dev] [PATCH 00/20] glapi yak shaving and GLES 3.1 enabling

2015-05-15 Thread Ian Romanick
On 05/14/2015 03:01 PM, Emil Velikov wrote: > Hi Ian, > > On 13/05/15 19:44, Ian Romanick wrote: >> We've known for a long time that having all those tags in the >> entries in the XML is bad. For example, people cut-and-paste for >> everything, and, as a result, we export a bunch of functions th

Re: [Mesa-dev] [PATCH 44/57] mesa: Add ARB_direct_state_access checks in XFB functions

2015-05-15 Thread Ian Romanick
On 05/14/2015 12:51 PM, Ilia Mirkin wrote: > Don't you have to add the checks either way? And should these have just been > > if (ctx->API != CORE && (ctx->API != COMPAT || ctx->Version < 20)) { > ... > } > > And removing compat will just reduce these checks to > > if (ctx->API != CORE) > > ?

Re: [Mesa-dev] [PATCH] st/mesa: Flush the bitmap cache in st_BlitFramebuffer

2015-05-15 Thread Brian Paul
On 05/15/2015 12:10 PM, Fredrik Höglund wrote: With DSA we can no longer rely on this being done in st_validate_state in response to the framebuffer bindings having changed. This fixes the ext_framebuffer_multisample-bitmap piglit test. --- src/mesa/state_tracker/st_cb_blit.c | 4 1 file

Re: [Mesa-dev] [PATCH 11/20] glapi: Remove static dispatch for functions that didn't exist in fglrx

2015-05-15 Thread Ian Romanick
On 05/15/2015 12:11 PM, Emil Velikov wrote: > On 15/05/15 17:29, Ian Romanick wrote: >> On 05/14/2015 03:01 PM, Emil Velikov wrote: >>> On 13/05/15 19:44, Ian Romanick wrote: From: Ian Romanick Comparing the output of nm -D arch/x86_64/usr/X11R6/lib64/fglrx/fglrx-libGL

Re: [Mesa-dev] Mesa (master): 57 new commits

2015-05-15 Thread Ian Romanick
On 05/15/2015 05:26 AM, Fredrik Höglund wrote: > On Friday 15 May 2015, Michel Dänzer wrote: >> On 14.05.2015 22:52, fred...@kemper.freedesktop.org (Fredrik HXXglund) >> wrote: >>> >>> URL: >> http://cgit.freedesktop.org/mesa/mesa/commit/?id=6b284f08ab399154ad10e2166440b44cbbdcb2c5 >>> Author: Laur

Re: [Mesa-dev] [PATCH 02/20] mesa: Remove all vestiges of glFramebufferTextureFaceARB

2015-05-15 Thread Emil Velikov
On 15/05/15 17:35, Ian Romanick wrote: > On 05/14/2015 02:44 PM, Emil Velikov wrote: >> On 13/05/15 19:44, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> Mesa does not (and probably never will) support GL_ARB_geometry_shader4, >>> so this function will never exist. >> In the (very unlikely) ev

Re: [Mesa-dev] [PATCH 11/20] glapi: Remove static dispatch for functions that didn't exist in fglrx

2015-05-15 Thread Emil Velikov
On 15/05/15 17:29, Ian Romanick wrote: > On 05/14/2015 03:01 PM, Emil Velikov wrote: >> On 13/05/15 19:44, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> Comparing the output of >>> >>> nm -D arch/x86_64/usr/X11R6/lib64/fglrx/fglrx-libGL.so.1.2 |\ >>> grep ' T gl[^X]' | sed 's/.* T

[Mesa-dev] [PATCH] st/mesa: Flush the bitmap cache in st_BlitFramebuffer

2015-05-15 Thread Fredrik Höglund
With DSA we can no longer rely on this being done in st_validate_state in response to the framebuffer bindings having changed. This fixes the ext_framebuffer_multisample-bitmap piglit test. --- src/mesa/state_tracker/st_cb_blit.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/st

Re: [Mesa-dev] [PATCH] mesa: do not use _glapi_new_nop_table() for DRI builds

2015-05-15 Thread Brian Paul
On 05/15/2015 11:14 AM, Emil Velikov wrote: On 15/05/15 15:13, Brian Paul wrote: Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table() and _glapi_set_nop_handler() functions in the glapi dispatcher (which live in libGL.so). The calls to those functions from context.c would be undefined (i.

Re: [Mesa-dev] RFC: Supporting mediump in NIR

2015-05-15 Thread Pohjolainen, Topi
On Fri, May 15, 2015 at 10:32:44AM -0700, Jason Ekstrand wrote: > Hey Topi! Thanks for working on this! > > I've been meaning to do something for fp16 and fp64 in NIR for a while > and just haven't gotten to it. I just sent out three "patches" laying > out how I was intending to do it. I put "p

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v3)

2015-05-15 Thread Jason Ekstrand
On Fri, May 15, 2015 at 9:51 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> I haven't said much about this series up until now. I've mostly sat >> and watched and focused my time on other things. As I said in the >> meeting today, I think that part of the problem here is that there ar

Re: [Mesa-dev] [PATCH] mesa: fix glPushAttrib(0) / glPopAttrib() error

2015-05-15 Thread Brian Paul
On 05/15/2015 11:31 AM, Brian Paul wrote: If the glPushAttrib() mask value was zero we didn't actually push anything onto the attribute stack. A subsequent glPopAttrib() error I'll s/error/call/ there. would generate GL_STACK_UNDERFLOW. Now push a dummy attribute in that case to prevent the

Re: [Mesa-dev] [PATCH 5/5] target/haiku-softpipe: Move api init into st code

2015-05-15 Thread Brian Paul
Series looks OK to me (though I didn't look too closely at the specific Haiku changes). Reviewed-by: Brian Paul On 05/15/2015 11:29 AM, Alexander von Gluck IV wrote: We also reduce the amount of need-to-know information about st_api to require one less extern "C" in st_manager.h --- .../tar

Re: [Mesa-dev] [PATCH 02/20] mesa: Remove all vestiges of glFramebufferTextureFaceARB

2015-05-15 Thread Ian Romanick
On 05/14/2015 02:44 PM, Emil Velikov wrote: > On 13/05/15 19:44, Ian Romanick wrote: >> From: Ian Romanick >> >> Mesa does not (and probably never will) support GL_ARB_geometry_shader4, >> so this function will never exist. > In the (very unlikely) event that we do support the extension, won't > t

Re: [Mesa-dev] RFC: Supporting mediump in NIR

2015-05-15 Thread Jason Ekstrand
Hey Topi! Thanks for working on this! I've been meaning to do something for fp16 and fp64 in NIR for a while and just haven't gotten to it. I just sent out three "patches" laying out how I was intending to do it. I put "patches" in quotes because they're so half-baked they barely compile. It's

[Mesa-dev] [PATCH 5/5] target/haiku-softpipe: Move api init into st code

2015-05-15 Thread Alexander von Gluck IV
We also reduce the amount of need-to-know information about st_api to require one less extern "C" in st_manager.h --- .../targets/haiku-softpipe/GalliumContext.cpp | 23 +++ .../targets/haiku-softpipe/GalliumContext.h|6 + 2 files changed, 10 insertions(+), 1

[Mesa-dev] [PATCH 1/5] gallium/aux: Add needed extern "C" wrappers

2015-05-15 Thread Alexander von Gluck IV
--- src/gallium/auxiliary/postprocess/postprocess.h |9 + src/gallium/auxiliary/util/u_tests.h|8 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/src/gallium/auxiliary/postprocess/postprocess.h b/src/gallium/auxiliary/postprocess/postprocess.h

[Mesa-dev] [PATCH 2/5] gallium/drivers: Add extern "C" wrappers to public entry

2015-05-15 Thread Alexander von Gluck IV
--- src/gallium/drivers/llvmpipe/lp_public.h |8 src/gallium/drivers/rbug/rbug_public.h |8 src/gallium/drivers/softpipe/sp_public.h |8 3 files changed, 24 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_public.h b/src/gallium/

[Mesa-dev] [PATCH 4/5] st/hgl: Move st_api creation to st and extern "C" it

2015-05-15 Thread Alexander von Gluck IV
--- src/gallium/state_trackers/hgl/hgl.c | 16 src/gallium/state_trackers/hgl/hgl_context.h | 14 ++ 2 files changed, 22 insertions(+), 8 deletions(-) diff --git a/src/gallium/state_trackers/hgl/hgl.c b/src/gallium/state_trackers/hgl/hgl.c index 77f7c22..

[Mesa-dev] [PATCH 3/5] winsys/hgl: Add needed extern "C" to hgl winsys

2015-05-15 Thread Alexander von Gluck IV
--- src/gallium/winsys/sw/hgl/hgl_sw_winsys.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/gallium/winsys/sw/hgl/hgl_sw_winsys.h b/src/gallium/winsys/sw/hgl/hgl_sw_winsys.h index bdcddfb..a81f890 100644 --- a/src/gallium/winsys/sw/hgl/hgl_sw_winsys.h +++ b/sr

Re: [Mesa-dev] [PATCH 11/20] glapi: Remove static dispatch for functions that didn't exist in fglrx

2015-05-15 Thread Ian Romanick
On 05/14/2015 03:01 PM, Emil Velikov wrote: > On 13/05/15 19:44, Ian Romanick wrote: >> From: Ian Romanick >> >> Comparing the output of >> >> nm -D arch/x86_64/usr/X11R6/lib64/fglrx/fglrx-libGL.so.1.2 |\ >> grep ' T gl[^X]' | sed 's/.* T //' >> >> between Catalyst 14.6 Beta and this c

[Mesa-dev] [PATCH] mesa: fix glPushAttrib(0) / glPopAttrib() error

2015-05-15 Thread Brian Paul
If the glPushAttrib() mask value was zero we didn't actually push anything onto the attribute stack. A subsequent glPopAttrib() error would generate GL_STACK_UNDERFLOW. Now push a dummy attribute in that case to prevent the error. Mesa now matches nvidia's behavior. --- src/mesa/main/attrib.c |

Re: [Mesa-dev] RFC: Supporting mediump in NIR

2015-05-15 Thread Jason Ekstrand
On Fri, May 15, 2015 at 2:39 AM, Topi Pohjolainen wrote: > I wanted to kick-off discussion on how to support floating point > precision qualifiers in NIR. This is purely on optimization for > GLES where one can reduce the number of GPU cycles. At the moment > the compiler discards the qualifiers e

[Mesa-dev] [counter-RFC 2/3] nir: Add explicitly sized types

2015-05-15 Thread Jason Ekstrand
--- src/glsl/nir/nir.h | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index bc8f063..8dfc68d 100644 --- a/src/glsl/nir/nir.h +++ b/src/glsl/nir/nir.h @@ -644,9 +644,23 @@ typedef enum { nir_type_float, nir_type_i

[Mesa-dev] [counter-RFC 3/3] nir: Add a bit_size to nir_register and nir_ssa_def

2015-05-15 Thread Jason Ekstrand
This really hacky commit adds a bit size to registers and SSA values. It also adds rules in the validator to validate that they do the right things. It's still an open question as to whether or not we want a bit_size in nir_alu_instr or if we just want to let it inherit from the destination. I'm

  1   2   >