Re: [Mesa-dev] [PATCH] nir/cse: fix bug with comparing non-per-component sources

2015-04-14 Thread Jason Ekstrand
On Tue, Apr 14, 2015 at 2:00 PM, Connor Abbott wrote: > On Tue, Apr 14, 2015 at 4:56 PM, Jason Ekstrand wrote: >> On Tue, Apr 14, 2015 at 1:39 PM, Connor Abbott wrote: >>> On Tue, Apr 14, 2015 at 3:55 PM, Jason Ekstrand wrote: On Tue, Apr 14, 2015 at 12:51 PM, Connor Abbott wrote: > W

Re: [Mesa-dev] [PATCH] i965: Implement proper workaround for Gen4 GPU CONSTANT_BUFFER hangs.

2015-04-14 Thread Ben Widawsky
On Mon, 13 Apr 2015 01:26:57 -0700 Kenneth Graunke wrote: > I finally managed to dig up some information on our mysterious GPU > hangs. A wiki page from the Crestline validation team mentions that > they found a GPU hang in "Serious Sam 2" (on Windows) with remarkably > similar conditions to the

Re: [Mesa-dev] [PATCH] i965/skl: Add the header for constant loads outside of the generator

2015-04-14 Thread Ian Romanick
On 04/14/2015 04:02 PM, Ben Widawsky wrote: > On Tue, Apr 14, 2015 at 07:08:14PM +0100, Neil Roberts wrote: >> +/** >> + * Emits the instructions needed to perform a pull constant load. >> before_block >> + * and before_inst can be NULL in which case the instruction will be >> appended >> + * to

[Mesa-dev] [Bug 90032] build fails, undefined reference to llvm:RTDyldMemoryManager

2015-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90032 --- Comment #9 from Felix von Leitner --- That fixed that problem, but there is another one: api/event.cpp: In function ‘cl_int clGetEventProfilingInfo(cl_event, cl_profiling_info, size_t, void*, size_t*)’: api/event.cpp:255:58: error: ‘dynamic_

[Mesa-dev] [Bug 90032] build fails, undefined reference to llvm:RTDyldMemoryManager

2015-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90032 --- Comment #8 from Felix von Leitner --- Hah, this is actually quite funny. src/gallium/auxiliary/util/u_debug.h 185 #ifdef DEBUG 186 #define debug_assert(expr) ((expr) ? (void)0 : _debug_assert_fail(#expr, __FILE__, __LINE__, __FUNCTION__)) 1

[Mesa-dev] [Bug 90032] build fails, undefined reference to llvm:RTDyldMemoryManager

2015-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90032 --- Comment #7 from Jan Vesely --- (In reply to Ilia Mirkin from comment #6) > (In reply to Felix von Leitner from comment #5) > > Did not help. Here's the error message: > > > > In file included from > > ../../../../src/gallium/auxiliary/util/u

[Mesa-dev] [Bug 90032] build fails, undefined reference to llvm:RTDyldMemoryManager

2015-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90032 --- Comment #6 from Ilia Mirkin --- (In reply to Felix von Leitner from comment #5) > Did not help. Here's the error message: > > In file included from > ../../../../src/gallium/auxiliary/util/u_inlines.h:36:0, > from ./codegen/

[Mesa-dev] [Bug 90032] build fails, undefined reference to llvm:RTDyldMemoryManager

2015-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90032 --- Comment #5 from Felix von Leitner --- Did not help. Here's the error message: In file included from ../../../../src/gallium/auxiliary/util/u_inlines.h:36:0, from ./codegen/nv50_ir_util.h:36, from ./codegen/n

[Mesa-dev] [Bug 90032] build fails, undefined reference to llvm:RTDyldMemoryManager

2015-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90032 --- Comment #4 from Felix von Leitner --- I tried to compile mesa without RTTI, but the build fails. CXX="g++ -fno-rtti" ./configure --prefix=/usr/X11R7 --sysconfdir=/etc --localstatedir=/var `libdir /usr/X11R7` --with-gallium-drivers=i915,nouve

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Rob Clark
On Tue, Apr 14, 2015 at 7:08 PM, Rob Clark wrote: > On Tue, Apr 14, 2015 at 6:24 PM, Connor Abbott wrote: >> On Tue, Apr 14, 2015 at 5:16 PM, Rob Clark wrote: >>> On Tue, Apr 14, 2015 at 4:59 PM, Jason Ekstrand >>> wrote: > + /** > +* Addressing mode for corresponding _in

[Mesa-dev] [PATCH 08/10] i965/fs: Emit ADDs for gl_FragCoord, not virtual opcodes.

2015-04-14 Thread Matt Turner
These were used only on Gen4 and 5. emit_interpolation_setup_gen6() emits ADDs directly. The virtual opcodes weren't providing anything useful. I'm going to repurpose these opcodes, so deleting and readding them makes it simpler to see what's going on. --- src/mesa/drivers/dri/i965/brw_defines.h

[Mesa-dev] [PATCH 06/10] i965/fs: Add LINTERP's src0 to fs_inst::regs_read().

2015-04-14 Thread Matt Turner
LINTERP's src0 is PLN's src1, and PLN's src1 reads exec_size / 4 registers. Having that information lets us drop the delta_x/y special case code in split_virtual_grfs(). --- src/mesa/drivers/dri/i965/brw_fs.cpp | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 07/10] i965/fs: Manually set source regioning on PLN instructions.

2015-04-14 Thread Matt Turner
Like LINE (commit 92346db0), src0 must have a scalar region. Setting src1's region to <8,8,1> lets us pass a properly sized combined delta_xy argument in a few commits without getting a bogus <16,16,1> region. --- src/mesa/drivers/dri/i965/brw_eu_emit.c | 14 +- 1 file changed, 13 inse

[Mesa-dev] [PATCH 05/10] i965/fs: Set compression only if writing two registers.

2015-04-14 Thread Matt Turner
We don't want to set compression control on a SIMD16 instruction operating on words or smaller. --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw

[Mesa-dev] [PATCH 10/10] i965/fs: Combine pixel center calculation into one inst.

2015-04-14 Thread Matt Turner
The X and Y values come interleaved in g1 (.4-.11 inclusive), so we can calculate them together with a single add(32) instruction on some platforms like Broadwell and newer or in SIMD8 elsewhere. Note that I also moved the PIXEL_X/PIXEL_Y virtual opcodes from before LINTERP to after it. That's bec

[Mesa-dev] [PATCH 09/10] i965/fs: Calculate delta_x and delta_y together.

2015-04-14 Thread Matt Turner
This lets SIMD16 programs on G45 and Gen5 use the PLN instruction. On Ironlake: total instructions in shared programs: 5634757 -> 5518055 (-2.07%) instructions in affected programs: 1745837 -> 1629135 (-6.68%) helped:11439 HURT:

[Mesa-dev] [PATCH 01/10] i965/fs: Ensure delta_x/y are even-aligned registers on Gen6.

2015-04-14 Thread Matt Turner
The BSpec says this applies to Gen6 as well. --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp| 2 +- src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/d

[Mesa-dev] [PATCH 03/10] i965: Make type_sz() return unsigned.

2015-04-14 Thread Matt Turner
Avoids annoying warnings when comparing with sizeof(...). --- src/mesa/drivers/dri/i965/brw_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_reg.h b/src/mesa/drivers/dri/i965/brw_reg.h index 924b059..3a50e86 100644 --- a/src/mesa/drivers/dri/

[Mesa-dev] [PATCH 00/10] i965/fs: Optimize interpolation setup

2015-04-14 Thread Matt Turner
This series fixes the interpolation setup code to let us emit PLN instructions on G45 and Gen5 in SIMD16. On Gen5, this cuts 6.68% of instructions from 11k (SIMD16) programs. Available from git://people.freedesktop.org/~mattst88/mesa gen5-pln ___ mes

[Mesa-dev] [PATCH 04/10] i965/fs: Allow an execution size of 32.

2015-04-14 Thread Matt Turner
In a few commits, we'll start emitting an add(32) instruction on some platforms. --- src/mesa/drivers/dri/i965/brw_eu_emit.c| 2 +- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 7 ++- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_eu_em

[Mesa-dev] [PATCH 02/10] i965: Replace guess_execution_size with something simpler.

2015-04-14 Thread Matt Turner
guess_execution_size() does two things: 1. Cope with small destination registers. 2. Cope with SIMD8 vs SIMD16 mode. This patch replaces the first with a simple if block in brw_set_dest: if the destination register width is less than 8, you probably want the execution size to match. (I did

[Mesa-dev] [Bug 90032] build fails, undefined reference to llvm:RTDyldMemoryManager

2015-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90032 --- Comment #3 from Jan Vesely --- you can try building mesa without rtti, to confirm that rtti is indeed an issue. you can also try building llvm with a patch from here: https://llvm.org/bugs/show_bug.cgi?id=14200 afair, the configuration sett

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Rob Clark
On Tue, Apr 14, 2015 at 6:24 PM, Connor Abbott wrote: > On Tue, Apr 14, 2015 at 5:16 PM, Rob Clark wrote: >> On Tue, Apr 14, 2015 at 4:59 PM, Jason Ekstrand wrote: + /** +* Addressing mode for corresponding _indirect intrinsics: +*/ + nir_addressin

Re: [Mesa-dev] [PATCH] i965/skl: Add the header for constant loads outside of the generator

2015-04-14 Thread Ben Widawsky
On Tue, Apr 14, 2015 at 07:08:14PM +0100, Neil Roberts wrote: > Commit 5a06ee738 added a step to the generator to set up the message > header when generating the VS_OPCODE_PULL_CONSTANT_LOAD_GEN7 > instruction. That pseudo opcode is implemented in terms of multiple > actual opcodes, one of which wr

[Mesa-dev] [Bug 90032] build fails, undefined reference to llvm:RTDyldMemoryManager

2015-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90032 --- Comment #2 from Felix von Leitner --- yes, my llvm is a cmake build. Here's the output of llvm-config: -I/usr/include -fPIC -fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializ

[Mesa-dev] [Bug 90032] build fails, undefined reference to llvm:RTDyldMemoryManager

2015-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90032 --- Comment #1 from Jan Vesely --- Do you happen to use cmake compiled llvm? Can you post the output of llvm-config --cxxflags -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. __

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Connor Abbott
On Tue, Apr 14, 2015 at 5:16 PM, Rob Clark wrote: > On Tue, Apr 14, 2015 at 4:59 PM, Jason Ekstrand wrote: >>> + /** >>> +* Addressing mode for corresponding _indirect intrinsics: >>> +*/ >>> + nir_addressing_mode var_addressing_mode; >>> + nir_addressing_mode in

[Mesa-dev] [PATCH 08/10] st/dri: implement the fence interface

2015-04-14 Thread Marek Olšák
From: Marek Olšák --- src/gallium/state_trackers/dri/dri2.c | 80 +++ 1 file changed, 80 insertions(+) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index f8f4ecf..9b56313 100644 --- a/src/gallium/state_trackers/dri/d

[Mesa-dev] [PATCH 04/10] egl/dri2: implement EGL_KHR_fence_sync

2015-04-14 Thread Marek Olšák
From: Marek Olšák --- src/egl/drivers/dri2/egl_dri2.c | 95 + src/egl/drivers/dri2/egl_dri2.h | 9 src/egl/main/eglapi.c | 34 --- 3 files changed, 133 insertions(+), 5 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c

[Mesa-dev] [PATCH 03/10] mesa: add GL_OES_EGL_sync

2015-04-14 Thread Marek Olšák
From: Marek Olšák This is an empty extension whose presence means that EGL sync objects can be used with ES contexts. --- src/mesa/main/extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index f212015..81c5bea 100644 --- a/src

[Mesa-dev] [PATCH 00/10] EGL Sync extensions

2015-04-14 Thread Marek Olšák
Hi, This patch series implements: - EGL_KHR_fence_sync - EGL_KHR_wait_sync - EGL_KHR_cl_event2 These extensions are required by EGL 1.5. EGL_KHR_fence_sync has piglit tests. The other two don't. EGL_KHR_wait_sync doesn't do anything useful, because no Mesa driver implements the equivalent func

[Mesa-dev] [PATCH 07/10] egl/dri2: return the latest sync status in eglGetSyncAttribKHR

2015-04-14 Thread Marek Olšák
From: Marek Olšák --- src/egl/main/eglsync.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/egl/main/eglsync.c b/src/egl/main/eglsync.c index ae3af4f..413d24e 100644 --- a/src/egl/main/eglsync.c +++ b/src/egl/main/eglsync.c @@ -30,6 +30,7 @@ #include "eglsync.

[Mesa-dev] [PATCH 06/10] egl/dri2: implement EGL_KHR_cl_event2

2015-04-14 Thread Marek Olšák
From: Marek Olšák --- src/egl/drivers/dri2/egl_dri2.c | 25 +++-- src/egl/main/eglapi.c | 30 ++--- src/egl/main/eglapi.h | 2 +- src/egl/main/egldisplay.h | 1 + src/egl/main/eglsync.c | 59 ++--

[Mesa-dev] [PATCH 05/10] egl/dri2: implement EGL_KHR_wait_sync

2015-04-14 Thread Marek Olšák
From: Marek Olšák --- src/egl/drivers/dri2/egl_dri2.c | 15 +++ src/egl/main/eglapi.c | 28 src/egl/main/eglapi.h | 2 ++ src/egl/main/egldisplay.h | 1 + src/egl/main/eglfallbacks.c | 1 + 5 files changed, 47 insertions(+

[Mesa-dev] [PATCH 02/10] dri_interface: add an interface for fences

2015-04-14 Thread Marek Olšák
From: Marek Olšák --- include/GL/internal/dri_interface.h | 60 + 1 file changed, 60 insertions(+) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index eb7da23..c827bb6 100644 --- a/include/GL/internal/dri_interface.h

[Mesa-dev] [PATCH 09/10] gallium, clover: add OpenCL interoperability support for CL events

2015-04-14 Thread Marek Olšák
From: Marek Olšák --- src/gallium/include/state_tracker/opencl_interop.h | 42 ++ src/gallium/state_trackers/clover/Makefile.sources | 1 + src/gallium/state_trackers/clover/core/event.hpp | 4 ++ src/gallium/state_trackers/clover/core/interop.cpp | 66 ++ src

[Mesa-dev] [PATCH 01/10] egl/dri: don't expose configs with an accumulation buffer

2015-04-14 Thread Marek Olšák
From: Marek Olšák --- src/egl/drivers/dri2/egl_dri2.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index a428f28..14b9be9 100644 --- a/src/egl/drivers/dri2/egl_dri2.c +++ b/src/egl/drivers/dri2/egl_dri2.c @@ -194,6

[Mesa-dev] [PATCH 10/10] st/dri: implement the fence interface for CL events

2015-04-14 Thread Marek Olšák
From: Marek Olšák --- src/gallium/state_trackers/dri/dri2.c | 71 - src/gallium/state_trackers/dri/dri_screen.c | 1 + src/gallium/state_trackers/dri/dri_screen.h | 9 3 files changed, 80 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_tracke

[Mesa-dev] [Bug 90032] build fails, undefined reference to llvm:RTDyldMemoryManager

2015-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90032 Bug ID: 90032 Summary: build fails, undefined reference to llvm:RTDyldMemoryManager Product: Mesa Version: 10.5 Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [Mesa-dev] [PATCH 1/2] st/mesa: add a debug option to compile shaders at link time

2015-04-14 Thread Marek Olšák
It's difficult to guess what the better key should be. All "zeros" is usually the best. Sometimes clamp_color should be flipped on, but not everytime. This patch is meant to be for shader-db. I don't expect any other uses. Marek On Tue, Apr 14, 2015 at 10:35 PM, Dave Airlie wrote: > On 14 April

[Mesa-dev] [Bug 89978] nine_state.c:1440: error: unknown field ‘m’ specified in initializer

2015-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89978 --- Comment #6 from Emil Velikov --- You are correct on the part that pre 4.6 is old and barely widely used. Although as the change is trivial, it might be good to be nice for the extra 1-2 users that might be using it :) After all the decision

Re: [Mesa-dev] [PATCH 00/15] GL_AMD_performance_monitor

2015-04-14 Thread Robert Bragg
On Tue, Mar 31, 2015 at 6:56 PM, Alex Deucher wrote: > On Thu, Mar 19, 2015 at 6:40 PM, Robert Bragg wrote: >> Hi Samuel, >> >> I thought I should let you and others know of some related changes >> I've been playing around with to try and improve our support for the >> INTEL_performance_query ext

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Rob Clark
On Tue, Apr 14, 2015 at 4:59 PM, Jason Ekstrand wrote: >> + /** >> +* Addressing mode for corresponding _indirect intrinsics: >> +*/ >> + nir_addressing_mode var_addressing_mode; >> + nir_addressing_mode input_addressing_mode; >> + nir_addressing_mode output

Re: [Mesa-dev] [PATCH 00/15] GL_AMD_performance_monitor

2015-04-14 Thread Robert Bragg
Hi Samuel, On Tue, Mar 31, 2015 at 5:56 PM, Samuel Pitoiset wrote: > Hello Robert, > > Sorry for the delay, I just saw your message few days ago, and I probably > removed the mail by mistake too... And then I was on holiday; so more delay :-) > > I have never heard about your work on this area,

Re: [Mesa-dev] [PATCH] nir/cse: fix bug with comparing non-per-component sources

2015-04-14 Thread Connor Abbott
On Tue, Apr 14, 2015 at 4:56 PM, Jason Ekstrand wrote: > On Tue, Apr 14, 2015 at 1:39 PM, Connor Abbott wrote: >> On Tue, Apr 14, 2015 at 3:55 PM, Jason Ekstrand wrote: >>> On Tue, Apr 14, 2015 at 12:51 PM, Connor Abbott wrote: We weren't comparing the right number of components when check

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Jason Ekstrand
On Tue, Apr 14, 2015 at 12:56 PM, Rob Clark wrote: > On Tue, Apr 14, 2015 at 3:32 PM, Jason Ekstrand wrote: >> On Tue, Apr 14, 2015 at 11:54 AM, Rob Clark wrote: >>> On Tue, Apr 14, 2015 at 1:56 PM, Eric Anholt wrote: Rob Clark writes: > From: Rob Clark > > Add compiler

Re: [Mesa-dev] [PATCH] nir/cse: fix bug with comparing non-per-component sources

2015-04-14 Thread Jason Ekstrand
On Tue, Apr 14, 2015 at 1:39 PM, Connor Abbott wrote: > On Tue, Apr 14, 2015 at 3:55 PM, Jason Ekstrand wrote: >> On Tue, Apr 14, 2015 at 12:51 PM, Connor Abbott wrote: >>> We weren't comparing the right number of components when checking >>> swizzles. Use nir_ssa_alu_instr_num_src_components()

Re: [Mesa-dev] [PATCH] nir/cse: fix bug with comparing non-per-component sources

2015-04-14 Thread Connor Abbott
On Tue, Apr 14, 2015 at 3:55 PM, Jason Ekstrand wrote: > On Tue, Apr 14, 2015 at 12:51 PM, Connor Abbott wrote: >> We weren't comparing the right number of components when checking >> swizzles. Use nir_ssa_alu_instr_num_src_components() to do the right > > I don't like the name of that function,

Re: [Mesa-dev] [PATCH 1/2] st/mesa: add a debug option to compile shaders at link time

2015-04-14 Thread Dave Airlie
On 14 April 2015 at 22:36, Marek Olšák wrote: > Ping. This is required for shader-db. > > Marek Reviewed-by: Dave Airlie Only one question, could we pick a "better" key than all 0? Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http:/

Re: [Mesa-dev] [PATCH 2/5] tgsi: also dump label for TGSI_OPCODE_BGNSUB opcode

2015-04-14 Thread Jose Fonseca
On 14/04/15 17:56, Brian Paul wrote: So we can see the label associated with subroutines. --- src/gallium/auxiliary/tgsi/tgsi_dump.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_dump.c b/src/gallium/auxiliary/tgsi/tgsi_dump.c index 7ae4049..13d6769 10064

Re: [Mesa-dev] [PATCH 1/5] st/mesa: also emit labels for TGSI_OPCODE_BGNSUB

2015-04-14 Thread Jose Fonseca
On 14/04/15 17:56, Brian Paul wrote: Subroutines need labels so they can be identied by CAL instructions. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/me

Re: [Mesa-dev] [PATCH] nir/cse: fix bug with comparing non-per-component sources

2015-04-14 Thread Ian Romanick
Reviewed-by: Ian Romanick As soon as it lands, I'll rebase and push my patch. On 04/14/2015 12:51 PM, Connor Abbott wrote: > We weren't comparing the right number of components when checking > swizzles. Use nir_ssa_alu_instr_num_src_components() to do the right > thing. > > I haven't piglited t

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Ilia Mirkin
On Tue, Apr 14, 2015 at 3:47 PM, Jason Ekstrand wrote: > On Tue, Apr 14, 2015 at 12:44 PM, Ilia Mirkin wrote: >> On Tue, Apr 14, 2015 at 3:32 PM, Jason Ekstrand wrote: >>> On Tue, Apr 14, 2015 at 11:54 AM, Rob Clark wrote: On Tue, Apr 14, 2015 at 1:56 PM, Eric Anholt wrote: > Rob Clar

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Rob Clark
On Tue, Apr 14, 2015 at 3:32 PM, Jason Ekstrand wrote: > On Tue, Apr 14, 2015 at 11:54 AM, Rob Clark wrote: >> On Tue, Apr 14, 2015 at 1:56 PM, Eric Anholt wrote: >>> Rob Clark writes: >>> From: Rob Clark Add compiler options so driver can request the units for address value, >>

Re: [Mesa-dev] [PATCH] nir/cse: fix bug with comparing non-per-component sources

2015-04-14 Thread Jason Ekstrand
On Tue, Apr 14, 2015 at 12:51 PM, Connor Abbott wrote: > We weren't comparing the right number of components when checking > swizzles. Use nir_ssa_alu_instr_num_src_components() to do the right I don't like the name of that function, but oh well. Reviewed-by: Jason Ekstrand > thing. > > I have

[Mesa-dev] [PATCH] nir/cse: fix bug with comparing non-per-component sources

2015-04-14 Thread Connor Abbott
We weren't comparing the right number of components when checking swizzles. Use nir_ssa_alu_instr_num_src_components() to do the right thing. I haven't piglited this yet, but it seems straightforward. Cc: Ian Romanick Signed-off-by: Connor Abbott --- src/glsl/nir/nir_opt_cse.c | 17 +++

Re: [Mesa-dev] [PATCH 2/3] nir: Try commutative sources in CSE

2015-04-14 Thread Jason Ekstrand
On Tue, Apr 14, 2015 at 12:33 PM, Connor Abbott wrote: > On Tue, Apr 14, 2015 at 11:43 AM, Ian Romanick wrote: >> From: Ian Romanick >> >> Shader-db results: >> >> GM45 NIR: >> total instructions in shared programs: 4082044 -> 4081919 (-0.00%) >> instructions in affected programs: 27609 -> 2

Re: [Mesa-dev] [PATCH 3/3] nir: Fix typo in ushr by 0 algebraic replacement

2015-04-14 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Apr 14, 2015 at 8:43 AM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Cc: "10.5" > --- > src/glsl/nir/nir_opt_algebraic.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/glsl/nir/nir_opt_algebraic

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Jason Ekstrand
On Tue, Apr 14, 2015 at 12:44 PM, Ilia Mirkin wrote: > On Tue, Apr 14, 2015 at 3:32 PM, Jason Ekstrand wrote: >> On Tue, Apr 14, 2015 at 11:54 AM, Rob Clark wrote: >>> On Tue, Apr 14, 2015 at 1:56 PM, Eric Anholt wrote: Rob Clark writes: > From: Rob Clark > > Add compile

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Ilia Mirkin
On Tue, Apr 14, 2015 at 3:32 PM, Jason Ekstrand wrote: > On Tue, Apr 14, 2015 at 11:54 AM, Rob Clark wrote: >> On Tue, Apr 14, 2015 at 1:56 PM, Eric Anholt wrote: >>> Rob Clark writes: >>> From: Rob Clark Add compiler options so driver can request the units for address value, >>

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Kenneth Graunke
On Tuesday, April 14, 2015 12:32:47 PM Jason Ekstrand wrote: > On Tue, Apr 14, 2015 at 11:54 AM, Rob Clark wrote: > > On Tue, Apr 14, 2015 at 1:56 PM, Eric Anholt wrote: [snip] > >> This seems like a good idea, as it'll mean we can have passes that do > >> things like scalarizing uniform loads, w

Re: [Mesa-dev] [PATCH 2/3] nir: Try commutative sources in CSE

2015-04-14 Thread Connor Abbott
On Tue, Apr 14, 2015 at 11:43 AM, Ian Romanick wrote: > From: Ian Romanick > > Shader-db results: > > GM45 NIR: > total instructions in shared programs: 4082044 -> 4081919 (-0.00%) > instructions in affected programs: 27609 -> 27484 (-0.45%) > helped:44 > > Iro

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Jason Ekstrand
On Tue, Apr 14, 2015 at 11:54 AM, Rob Clark wrote: > On Tue, Apr 14, 2015 at 1:56 PM, Eric Anholt wrote: >> Rob Clark writes: >> >>> From: Rob Clark >>> >>> Add compiler options so driver can request the units for address value, >>> for the various _indirect intrinsics. This way, the front end

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Rob Clark
On Tue, Apr 14, 2015 at 1:56 PM, Eric Anholt wrote: > Rob Clark writes: > >> From: Rob Clark >> >> Add compiler options so driver can request the units for address value, >> for the various _indirect intrinsics. This way, the front end can >> insert the appropriate multiply/shift operations to

Re: [Mesa-dev] [PATCH 06/18] i965/cs: Add support for the SEND message that terminates a CS thread.

2015-04-14 Thread Matt Turner
On Tue, Apr 14, 2015 at 11:35 AM, Jordan Justen wrote: > On 2015-04-13 23:41:15, Matt Turner wrote: >> On Sat, Mar 14, 2015 at 9:54 PM, Jordan Justen >> wrote: >> > From: Paul Berry >> > >> > This message must be sent to the "thread spawner" unit. >> > >> > Reviewed-by: Jordan Justen >> > --- >

Re: [Mesa-dev] [PATCH 06/18] i965/cs: Add support for the SEND message that terminates a CS thread.

2015-04-14 Thread Jordan Justen
On 2015-04-13 23:41:15, Matt Turner wrote: > On Sat, Mar 14, 2015 at 9:54 PM, Jordan Justen > wrote: > > From: Paul Berry > > > > This message must be sent to the "thread spawner" unit. > > > > Reviewed-by: Jordan Justen > > --- > > src/mesa/drivers/dri/i965/brw_eu.h | 4 +++ > > src/mesa

[Mesa-dev] [PATCH] i965/skl: Add the header for constant loads outside of the generator

2015-04-14 Thread Neil Roberts
Commit 5a06ee738 added a step to the generator to set up the message header when generating the VS_OPCODE_PULL_CONSTANT_LOAD_GEN7 instruction. That pseudo opcode is implemented in terms of multiple actual opcodes, one of which writes to one of the source registers in order to set up the message hea

Re: [Mesa-dev] [PATCH 1/5] st/mesa: also emit labels for TGSI_OPCODE_BGNSUB

2015-04-14 Thread Brian Paul
On 04/14/2015 10:58 AM, Ilia Mirkin wrote: Nothing against this patch per se, but are there any actual users of BGNSUB/CAL/etc? Was it done in anticipation of ARB_shader_subroutines (and/or whatever corresponding feature in DirectX)? I found a shader that becomes extremely large after all the f

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Eric Anholt
Rob Clark writes: > From: Rob Clark > > Add compiler options so driver can request the units for address value, > for the various _indirect intrinsics. This way, the front end can > insert the appropriate multiply/shift operations to get the address into > the units that the driver needs, avoid

Re: [Mesa-dev] [PATCH] i965/skl: Use an exec size of 8 to initialise the message header

2015-04-14 Thread Ben Widawsky
On Mon, Apr 13, 2015 at 02:04:53PM +0100, Neil Roberts wrote: > Ben Widawsky writes: > > > Can you do me a favor since I am lazy? Can you send the generated asm > > diff with this patch? I am admittedly rusty on the matter, but I > > thought a mov is just a mov, and only the regioning is effected

[Mesa-dev] [Bug 89978] nine_state.c:1440: error: unknown field ‘m’ specified in initializer

2015-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89978 --- Comment #5 from David Heidelberg (okias) --- (In reply to Emil Velikov from comment #3) > Imho a better solution would be to add -fms-extensions to the CFLAGS. This > will enable anonymous struct/unions and keep things working for pre 4.6 > v

[Mesa-dev] [Bug 89978] nine_state.c:1440: error: unknown field ‘m’ specified in initializer

2015-04-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89978 --- Comment #4 from David Heidelberg (okias) --- (In reply to Emil Velikov from comment #3) > Imho a better solution would be to add -fms-extensions to the CFLAGS. This > will enable anonymous struct/unions and keep things working for pre 4.6 > v

Re: [Mesa-dev] [PATCH 1/4] gallium/ttn: add support for texture offsets

2015-04-14 Thread Eric Anholt
Rob Clark writes: > From: Rob Clark > > Signed-off-by: Rob Clark 1-3 (with the fix to 1 that you posted in irc) are: Reviewed-by: Eric Anholt I don't like the mismatch on bytes vs vec4s in the load_ubo_indirect arguments for patch 4, and will be interested in seeing the version you were wor

Re: [Mesa-dev] [PATCH 1/5] st/mesa: also emit labels for TGSI_OPCODE_BGNSUB

2015-04-14 Thread Ilia Mirkin
Nothing against this patch per se, but are there any actual users of BGNSUB/CAL/etc? Was it done in anticipation of ARB_shader_subroutines (and/or whatever corresponding feature in DirectX)? On Tue, Apr 14, 2015 at 12:56 PM, Brian Paul wrote: > Subroutines need labels so they can be identied by C

[Mesa-dev] [PATCH 3/5] mesa: add _mesa_log(), _mesa_get_log_file() functions

2015-04-14 Thread Brian Paul
_mesa_log() simply writes log information to stderr or MESA_LOG_FILE. _mesa_get_log_file() returns the file handle to use for logging. This will be used for shader dumping/logging instead of always printing to stderr. --- src/mesa/main/errors.c | 43 --- sr

[Mesa-dev] [PATCH 1/5] st/mesa: also emit labels for TGSI_OPCODE_BGNSUB

2015-04-14 Thread Brian Paul
Subroutines need labels so they can be identied by CAL instructions. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp inde

[Mesa-dev] [PATCH 2/5] tgsi: also dump label for TGSI_OPCODE_BGNSUB opcode

2015-04-14 Thread Brian Paul
So we can see the label associated with subroutines. --- src/gallium/auxiliary/tgsi/tgsi_dump.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_dump.c b/src/gallium/auxiliary/tgsi/tgsi_dump.c index 7ae4049..13d6769 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_d

[Mesa-dev] [PATCH 4/5] mesa: log shaders, GLSL info log with _mesa_log()

2015-04-14 Thread Brian Paul
Now, if we set MESA_LOG_FILE and MESA_GLSL=dump, all the shader info will get logged to the named file instead of stderr. --- src/mesa/main/shaderapi.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderap

[Mesa-dev] [PATCH 5/5] st/mesa: log shaders, GLSL info log with _mesa_log()

2015-04-14 Thread Brian Paul
As with previous patch. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index eb0ce07..94ff2e0 100644 --- a/src/mesa/state_tracker/

[Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Rob Clark
From: Rob Clark Add compiler options so driver can request the units for address value, for the various _indirect intrinsics. This way, the front end can insert the appropriate multiply/shift operations to get the address into the units that the driver needs, avoiding need for driver to insert t

Re: [Mesa-dev] [PATCH 02/13] i965: Change header_present to header_size in backend_instruction

2015-04-14 Thread Ian Romanick
On 04/01/2015 06:19 PM, Jason Ekstrand wrote: > diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp > b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp > index e6fb0cb..0624528 100644 > --- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp > +++ b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp > @@

[Mesa-dev] [PATCH] glx: Create proper server dependency for GLX_EXT_create_context_es2_profile

2015-04-14 Thread Ian Romanick
From: Ian Romanick Previously GLX_EXT_create_context_es2_profile was marked as "direct only" so that it would not depend on server support. Since the extension required functions that are part of GLX_ARB_create_context_profile, support for the EXT was disabled if the ARB was not supported. This

Re: [Mesa-dev] [PATCH] glx: Allow to create any OpenGL ES version.

2015-04-14 Thread Ian Romanick
On 04/14/2015 08:36 AM, Emil Velikov wrote: > On 14 April 2015 at 13:52, Jose Fonseca wrote: >> On 13/04/15 22:59, Ian Romanick wrote: >>> >>> On 04/10/2015 03:36 PM, Jose Fonseca wrote: From: José Fonseca The latest version of GLX_EXT_create_context_es2_profile states: >

Re: [Mesa-dev] [PATCH 1/2] mesa: Enable _mesa_dlopen on MSVC too.

2015-04-14 Thread Brian Paul
On 04/14/2015 07:29 AM, Jose Fonseca wrote: As pointed out by Shervin Sharifi. --- src/mesa/main/dlopen.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/dlopen.h b/src/mesa/main/dlopen.h index 1e77849..4d20ff2 100644 --- a/src/mesa/main/dlopen.h +++ b/s

Re: [Mesa-dev] [PATCH 1/3] nir: Silence unused parameter warnings

2015-04-14 Thread Jordan Justen
Yikes. Good catch on 3/3. :) Series Reviewed-by: Jordan Justen On 2015-04-14 08:43:39, Ian Romanick wrote: > From: Ian Romanick > > nir/nir.h: In function 'nir_validate_shader': > nir/nir.h:1567:56: warning: unused parameter 'shader' [-Wunused-parameter] > static inline void nir_validate_shad

[Mesa-dev] [PATCH 3/3] nir: Fix typo in ushr by 0 algebraic replacement

2015-04-14 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Cc: "10.5" --- src/glsl/nir/nir_opt_algebraic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/nir_opt_algebraic.py b/src/glsl/nir/nir_opt_algebraic.py index 319732d..cdb1924 100644 --- a/src/glsl/nir/nir_opt_al

[Mesa-dev] [PATCH 1/3] nir: Silence unused parameter warnings

2015-04-14 Thread Ian Romanick
From: Ian Romanick nir/nir.h: In function 'nir_validate_shader': nir/nir.h:1567:56: warning: unused parameter 'shader' [-Wunused-parameter] static inline void nir_validate_shader(nir_shader *shader) { } ^ nir/nir_opt_cse.c: In function 'src

[Mesa-dev] [PATCH 2/3] nir: Try commutative sources in CSE

2015-04-14 Thread Ian Romanick
From: Ian Romanick Shader-db results: GM45 NIR: total instructions in shared programs: 4082044 -> 4081919 (-0.00%) instructions in affected programs: 27609 -> 27484 (-0.45%) helped:44 Iron Lake NIR: total instructions in shared programs: 5678776 -> 5678646 (-

Re: [Mesa-dev] [PATCH] glx: Allow to create any OpenGL ES version.

2015-04-14 Thread Emil Velikov
On 14 April 2015 at 13:52, Jose Fonseca wrote: > On 13/04/15 22:59, Ian Romanick wrote: >> >> On 04/10/2015 03:36 PM, Jose Fonseca wrote: >>> >>> From: José Fonseca >>> >>> The latest version of GLX_EXT_create_context_es2_profile states: >>> >>>"If the version requested is a valid and support

Re: [Mesa-dev] [PATCH 1/2] configure.ac: print LLVM_LDFLAGS

2015-04-14 Thread Marek Olšák
I use --with-llvm-prefix=, which avoids this issue too. For 32-bit: /usr/llvm/i386-linux-gnu (... /bin/llvm-config) For 64-bit: /usr/llvm/x86_64-linux-gnu (... /bin/llvm-config) This is a good solution for people who build LLVM from source and don't want to overwrite their default distribution p

Re: [Mesa-dev] [PATCH 2/2] configure.ac: add --enable-assertions

2015-04-14 Thread Marek Olšák
On Tue, Apr 14, 2015 at 3:12 PM, Emil Velikov wrote: > On 14 April 2015 at 13:27, Marek Olšák wrote: >> If --enable-debug is used, --enable-assertions is ignored. >> --enable-assertions is basically a weaker version of --enable-debug. >> > Doesn't this make things more counter-intuitive ? I'm gui

[Mesa-dev] [PATCH 2/2] st/wgl: Couple of fixes to opengl32.dll's wglCreateContext/wglDeleteContext dispatch.

2015-04-14 Thread Jose Fonseca
- Use GetModuleHandle instead of LoadLibrary to avoid incrementing the opengl32.dll reference count (otherwise the opengl32.dll will linger in memory forever.) - Ensure we use our fake wglCreateContext/wglDeleteContext when using Mesa as a drop-in replacement for opengl32.dll Untested. Jus

Re: [Mesa-dev] [PATCH 1/2] configure.ac: print LLVM_LDFLAGS

2015-04-14 Thread Laurent Carlier
Le mardi 14 avril 2015, 15:19:08 Marek Olšák a écrit : > On Tue, Apr 14, 2015 at 2:55 PM, Emil Velikov wrote: > > On 14 April 2015 at 13:32, Marek Olšák wrote: > >> On Tue, Apr 14, 2015 at 2:19 PM, Emil Velikov wrote: > >>> On 13 April 2015 at 21:06, Marek Olšák wrote: > From: Marek Olšá

[Mesa-dev] [PATCH 1/2] mesa: Enable _mesa_dlopen on MSVC too.

2015-04-14 Thread Jose Fonseca
As pointed out by Shervin Sharifi. --- src/mesa/main/dlopen.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/dlopen.h b/src/mesa/main/dlopen.h index 1e77849..4d20ff2 100644 --- a/src/mesa/main/dlopen.h +++ b/src/mesa/main/dlopen.h @@ -50,7 +50,7 @@ _mesa_dl

Re: [Mesa-dev] [PATCH 1/2] configure.ac: print LLVM_LDFLAGS

2015-04-14 Thread Marek Olšák
On Tue, Apr 14, 2015 at 2:55 PM, Emil Velikov wrote: > On 14 April 2015 at 13:32, Marek Olšák wrote: >> On Tue, Apr 14, 2015 at 2:19 PM, Emil Velikov >> wrote: >>> On 13 April 2015 at 21:06, Marek Olšák wrote: From: Marek Olšák --- configure.ac | 1 + 1 file changed,

Re: [Mesa-dev] [PATCH 2/2] configure.ac: add --enable-assertions

2015-04-14 Thread Emil Velikov
On 14 April 2015 at 13:27, Marek Olšák wrote: > If --enable-debug is used, --enable-assertions is ignored. > --enable-assertions is basically a weaker version of --enable-debug. > Doesn't this make things more counter-intuitive ? I'm guilty of making --enable-debug a bit messy (and I'm ok with rev

Re: [Mesa-dev] Building Mesa for Windows using Visual Studio

2015-04-14 Thread Jose Fonseca
On 14/04/15 13:41, Emil Velikov wrote: Hi Shervin, On 14 April 2015 at 00:22, Shervin Sharifi wrote: Hi, I tried to use Mesa (compiled with MSVC) to run OpenGL ES content on Windows . I ran into a few problems. I don't know if this is the right way of reporting issues, but thought peop

Re: [Mesa-dev] [PATCH 1/2] configure.ac: print LLVM_LDFLAGS

2015-04-14 Thread Emil Velikov
On 14 April 2015 at 13:32, Marek Olšák wrote: > On Tue, Apr 14, 2015 at 2:19 PM, Emil Velikov > wrote: >> On 13 April 2015 at 21:06, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> --- >>> configure.ac | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/configure.ac b/configure.ac

Re: [Mesa-dev] [PATCH] glx: Allow to create any OpenGL ES version.

2015-04-14 Thread Jose Fonseca
On 13/04/15 22:59, Ian Romanick wrote: On 04/10/2015 03:36 PM, Jose Fonseca wrote: From: José Fonseca The latest version of GLX_EXT_create_context_es2_profile states: "If the version requested is a valid and supported OpenGL-ES version, and the GLX_CONTEXT_ES_PROFILE_BIT_EXT bit is set

Re: [Mesa-dev] Building Mesa for Windows using Visual Studio

2015-04-14 Thread Emil Velikov
Hi Shervin, On 14 April 2015 at 00:22, Shervin Sharifi wrote: > Hi, > I tried to use Mesa (compiled with MSVC) to run OpenGL ES content on > Windows . I ran into a few problems. > I don't know if this is the right way of reporting issues, but thought > people may be interested to know. > Anot

  1   2   >