Re: [Mesa-dev] [PATCH 06/18] i965/cs: Add support for the SEND message that terminates a CS thread.

2015-04-13 Thread Matt Turner
On Sat, Mar 14, 2015 at 9:54 PM, Jordan Justen wrote: > From: Paul Berry > > This message must be sent to the "thread spawner" unit. > > Reviewed-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/brw_eu.h | 4 +++ > src/mesa/drivers/dri/i965/brw_eu_emit.c | 46 > +++

Re: [Mesa-dev] [PATCH v2 05/24] mesa: glGetProgramResourceIndex

2015-04-13 Thread Tapani Pälli
On 04/13/2015 03:29 PM, Martin Peres wrote: On 01/04/15 15:14, Tapani Pälli wrote: Patch adds required helper functions to shaderapi.h and the actual implementation. v2: code cleanup (Ilia Mirkin) corresponding Piglit test: arb_program_interface_query-resource-index Signed-off-by: Tapan

Re: [Mesa-dev] [PATCH] Fix 32bit compilation with -Werror=implicit-function-declaration

2015-04-13 Thread Pali Rohár
On Monday 13 April 2015 22:32:10 Brian Paul wrote: > On 04/13/2015 01:49 PM, Pali Rohár wrote: > > On Monday 13 April 2015 21:26:32 Pali Rohár wrote: > >> File glapi_entrypoint.c calls memcpy() function, but does > >> not include string.h header. So compilation can fail at > >> error: implicit decl

Re: [Mesa-dev] [PATCH 12/18] i965/cache: Add support for CS in program state cache

2015-04-13 Thread Kristian Høgsberg
On Sat, Mar 14, 2015 at 9:54 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/Makefile.sources | 1 + > src/mesa/drivers/dri/i965/brw_cs.cpp| 48 > + > src/mesa/drivers/dri/i965/brw_

Re: [Mesa-dev] [PATCH 11/18] i965/cs: Add BRW_NEW_CS_PROG_DATA and BRW_CACHE_CS_PROG

2015-04-13 Thread Kristian Høgsberg
On Sat, Mar 14, 2015 at 9:54 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_context.h | 2 ++ > src/mesa/drivers/dri/i965/brw_state_dump.c | 3 +++ > src/mesa/drivers/dri/i965/brw_state_upload.c | 1 + > 3 fi

Re: [Mesa-dev] [PATCH 10/18] i965/cs: Add brw_cs_prog_data, brw_cs_prog_key and brw_context::cs.

2015-04-13 Thread Kristian Høgsberg
On Sat, Mar 14, 2015 at 9:54 PM, Jordan Justen wrote: > From: Paul Berry Reviewed-by: Kristian Høgsberg > jordan.l.jus...@intel.com: > * Added brw_cs_prog_key structure > * Added brw_cs_prog_data::dispatch_grf_start_reg_16 > * Added brw_cs_prog_data::no_8 > * Added brw_cs_prog_data::local_

Re: [Mesa-dev] [PATCH 09/18] i965/cs: Emit gen code for CS_OPCODE_CS_TERMINATE

2015-04-13 Thread Kristian Høgsberg
On Sat, Mar 14, 2015 at 9:54 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_fs.h | 1 + > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 11 +++ > 2 files changed, 12 insertions(+) > > diff --

Re: [Mesa-dev] [PATCH 07/18] i965/cs: Support CS_OPCODE_CS_TERMINATE

2015-04-13 Thread Kristian Høgsberg
On Sat, Mar 14, 2015 at 9:54 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_defines.h | 5 + > src/mesa/drivers/dri/i965/brw_fs.h | 1 + > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 11 +

Re: [Mesa-dev] [PATCH 06/18] i965/cs: Add support for the SEND message that terminates a CS thread.

2015-04-13 Thread Kristian Høgsberg
On Sat, Mar 14, 2015 at 9:54 PM, Jordan Justen wrote: > From: Paul Berry > > This message must be sent to the "thread spawner" unit. > > Reviewed-by: Jordan Justen Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_eu.h | 4 +++ > src/mesa/drivers/dri/i965/brw_eu_emit

Re: [Mesa-dev] [PATCH 05/18] i965: Add an INTEL_DEBUG=cs option.

2015-04-13 Thread Kristian Høgsberg
On Sat, Mar 14, 2015 at 9:54 PM, Jordan Justen wrote: > From: Paul Berry > > At the moment it's not wired up to anything. Later patches will hook > it up to the compute shader back-end. > > Reviewed-by: Jordan Justen Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/intel_deb

Re: [Mesa-dev] [PATCH 04/18] mesa/cs: Add compute support to update_program().

2015-04-13 Thread Kristian Høgsberg
On Sat, Mar 14, 2015 at 9:54 PM, Jordan Justen wrote: > From: Paul Berry > > Reviewed-by: Jordan Justen Reviewed-by: Kristian Høgsberg > --- > src/mesa/main/state.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/src/mesa/main/state.c b/src/mesa/main/state.c >

Re: [Mesa-dev] [PATCH 03/18] mesa/cs: Update program.c for compute shaders.

2015-04-13 Thread Kristian Høgsberg
On Sat, Mar 14, 2015 at 9:54 PM, Jordan Justen wrote: > From: Paul Berry > > Reviewed-by: Jordan Justen Reviewed-by: Kristian Høgsberg > --- > src/mesa/program/program.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mesa/program/program.c b/src/mesa/program/program.c > inde

Re: [Mesa-dev] [PATCH 02/18] mesa/cs: Add inline functions for dealing with compute shaders.

2015-04-13 Thread Kristian Høgsberg
On Sat, Mar 14, 2015 at 9:54 PM, Jordan Justen wrote: > From: Paul Berry > > Reviewed-by: Jordan Justen Reviewed-by: Kristian Høgsberg > --- > src/mesa/program/program.h | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/src/mesa/program/program.h b/src/mesa/pro

Re: [Mesa-dev] [PATCH 01/18] i965/cs: Add BRW_NEW_COMPUTE_PROGRAM state flag.

2015-04-13 Thread Kristian Høgsberg
On Sat, Mar 14, 2015 at 9:54 PM, Jordan Justen wrote: > From: Paul Berry > > Also add code to brw_upload_state to set it when the compute program > changes. > > Reviewed-by: Jordan Justen Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_context.h | 3 +++ > src/mesa/

Re: [Mesa-dev] Building Mesa for Windows using Visual Studio

2015-04-13 Thread Shervin Sharifi
Hi, I tried to use Mesa (compiled with MSVC) to run OpenGL ES content on Windows . I ran into a few problems. I don't know if this is the right way of reporting issues, but thought people may be interested to know. Here's a piece of code in functions _mesa_dlopen(const char*, int) in src\mesa

Re: [Mesa-dev] [PATCH shader-db 1/5] run.c: Use computed value of max_threads

2015-04-13 Thread Matt Turner
Thanks Tom. I fixed a couple of whitespace mistakes and pushed these! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glsl: extend GLSLSkipStrictMaxUniformLimitCheck to uniform block size

2015-04-13 Thread Marcin Ślusarz
On Tue, Apr 14, 2015 at 12:05:25AM +0200, Roland Scheidegger wrote: > FWIW fsexceed crashes badly with llvmpipe (this is because we copy the > constants into scene data, and the block size there is 64kB). I've > actually wondered if it's the state tracker's job or that of the driver > to ensure not

[Mesa-dev] [PATCH v2] glsl: extend GLSLSkipStrictMaxUniformLimitCheck to uniform block size

2015-04-13 Thread Marcin Ślusarz
ARB_uniform_buffer_object spec says: "The total amount of buffer object storage available for any given uniform block is subject to an implementation-dependent limit; the maximum amount of available space, in basic machine units, can be queried by calling GetIntegerv with the constant MAX_UNIFORM_B

Re: [Mesa-dev] [PATCH 3/3] util: Change util/set to use quadratic probing

2015-04-13 Thread Jason Ekstrand
On Mon, Apr 13, 2015 at 3:22 PM, Thomas Helland wrote: > > On 14 Apr 2015 00:05, "Jason Ekstrand" wrote: >> >> On Sat, Apr 11, 2015 at 4:25 PM, Thomas Helland >> wrote: >> > The same rationale applies here as for the hash table. >> > Power of two size should give better performance, >> > and usi

[Mesa-dev] [PATCH 3/3] util: Change util/set to use quadratic probing

2015-04-13 Thread Thomas Helland
On 14 Apr 2015 00:05, "Jason Ekstrand" wrote: > > On Sat, Apr 11, 2015 at 4:25 PM, Thomas Helland > wrote: > > The same rationale applies here as for the hash table. > > Power of two size should give better performance, > > and using the algorithm hash = sh + i/2 + i*i/2 > > should result in only

Re: [Mesa-dev] [PATCH 0/3] Hash-table and hash-set, V4

2015-04-13 Thread Jason Ekstrand
On Sat, Apr 11, 2015 at 4:25 PM, Thomas Helland wrote: > The performance numbers (shader-db runtime) are: > > Difference at 95.0% confidence > -14.7608 +/- 3.36786 > -9.05064% +/- 2.06501% > (Original runtime was 160 seconds) Good Work! I had one comment on the hash set patch. With t

Re: [Mesa-dev] [PATCH 3/3] util: Change util/set to use quadratic probing

2015-04-13 Thread Jason Ekstrand
On Sat, Apr 11, 2015 at 4:25 PM, Thomas Helland wrote: > The same rationale applies here as for the hash table. > Power of two size should give better performance, > and using the algorithm hash = sh + i/2 + i*i/2 > should result in only distinct hash values when hitting collisions. > > Difference

Re: [Mesa-dev] [PATCH] glsl: extend GLSLSkipStrictMaxUniformLimitCheck to uniform block size

2015-04-13 Thread Roland Scheidegger
FWIW fsexceed crashes badly with llvmpipe (this is because we copy the constants into scene data, and the block size there is 64kB). I've actually wondered if it's the state tracker's job or that of the driver to ensure nothing bad happens. It is however happening due to the actual buffer being lar

Re: [Mesa-dev] [PATCH] glx: Allow to create any OpenGL ES version.

2015-04-13 Thread Ian Romanick
On 04/10/2015 03:36 PM, Jose Fonseca wrote: > From: José Fonseca > > The latest version of GLX_EXT_create_context_es2_profile states: > > "If the version requested is a valid and supported OpenGL-ES version, > and the GLX_CONTEXT_ES_PROFILE_BIT_EXT bit is set in the > GLX_CONTEXT_PROFILE_M

Re: [Mesa-dev] [PATCH] glsl: extend GLSLSkipStrictMaxUniformLimitCheck to uniform block size

2015-04-13 Thread Marcin Ślusarz
On Mon, Apr 13, 2015 at 02:17:24PM -0700, Ian Romanick wrote: > On 04/11/2015 09:48 AM, Marcin Ślusarz wrote: > > ARB_uniform_buffer_object spec says: > > "The total amount of buffer object storage available for any given uniform > > block is subject to an implementation-dependent limit; the maximu

[Mesa-dev] [PATCH 14/12] nir/lower_source_mods: Don't propagate register sources

2015-04-13 Thread Jason Ekstrand
The nir_lower_source_mods pass does a weak form of copy propagation to clean up all of the mov-with-negate's that get generated. However, we weren't properly checking that the sources were SSA and so we could end up moving a register read which is not, in general, valid. --- src/glsl/nir/nir_lowe

[Mesa-dev] [PATCH 13/12] nir: Rewrite instr_rewrite_src

2015-04-13 Thread Jason Ekstrand
The old code wasn't correctly handling the case where the new value of the source contains an indirect. --- src/glsl/nir/nir.c | 52 1 file changed, 28 insertions(+), 24 deletions(-) diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c index a7

Re: [Mesa-dev] [PATCH] i965/fs: Correct mistake in determining whether a MUL is negated.

2015-04-13 Thread Ian Romanick
On 04/13/2015 01:11 PM, Matt Turner wrote: > a * b is equivalent to -a * -b, and the previous code was failing at > that. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89961 > --- > src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[Mesa-dev] [Bug 89018] Civilization: Beyond Earth terrain section not rendered

2015-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89018 --- Comment #16 from Sami Liedes --- I think this might be related to the color rendering weirdness: On fglrx, CivBE uses the GL_NV_half_float extension, which is not available on Mesa. Looking at interesting words or enums that are present in on

Re: [Mesa-dev] [PATCH] glx: Allow to create any OpenGL ES version.

2015-04-13 Thread Ian Romanick
On 04/10/2015 04:57 PM, Chad Versace wrote: > On Fri 10 Apr 2015, Jose Fonseca wrote: >> From: José Fonseca >> >> The latest version of GLX_EXT_create_context_es2_profile states: >> >> "If the version requested is a valid and supported OpenGL-ES version, >> and the GLX_CONTEXT_ES_PROFILE_BIT_EXT

Re: [Mesa-dev] [PATCH] i965/fs: Correct mistake in determining whether a MUL is negated.

2015-04-13 Thread Anuj Phogat
On Mon, Apr 13, 2015 at 1:11 PM, Matt Turner wrote: > a * b is equivalent to -a * -b, and the previous code was failing at > that. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89961 > --- > src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

Re: [Mesa-dev] [PATCH] glsl: extend GLSLSkipStrictMaxUniformLimitCheck to uniform block size

2015-04-13 Thread Ian Romanick
On 04/11/2015 09:48 AM, Marcin Ślusarz wrote: > ARB_uniform_buffer_object spec says: > "The total amount of buffer object storage available for any given uniform > block is subject to an implementation-dependent limit; the maximum amount > of available space, in basic machine units, can be queried

Re: [Mesa-dev] [PATCH 3/3] radeon/llvm: Improve codegen for KILL_IF

2015-04-13 Thread Marek Olšák
t; >> I assume you tested piglit, because I remember there had been some >> crashes with the instruction combining pass and the kill instruction. >> > > I sent out an llvm patch to fix the crashes: > > http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150413

Re: [Mesa-dev] [PATCH 1/4] nir: Fix bug in handling non-SSA copy prop of indirect register access.

2015-04-13 Thread Connor Abbott
Patches 1 and 2 are Reviewed-by: Connor Abbott Adding stricter assertions for tex sources makes sense to me now after some thought/discussion, but if we're going to do it then we should go all the way and make intrinsic srcs and dests and if srcs more strict as well. Also, maybe you've done this

Re: [Mesa-dev] [PATCH 3/3] radeon/llvm: Improve codegen for KILL_IF

2015-04-13 Thread Tom Stellard
llvm patch to fix the crashes: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150413/271018.html -Tom > Marek > > On Mon, Apr 13, 2015 at 8:21 PM, Tom Stellard wrote: > > Rather than emitting one kill instruction per component of KILL_IF's src > > reg, we now

Re: [Mesa-dev] [PATCH 3/3] radeon/llvm: Improve codegen for KILL_IF

2015-04-13 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák I assume you tested piglit, because I remember there had been some crashes with the instruction combining pass and the kill instruction. Marek On Mon, Apr 13, 2015 at 8:21 PM, Tom Stellard wrote: > Rather than emitting one kill instruction per componen

[Mesa-dev] [PATCH shader-db 3/5] run.c: Add -1 option for disabling multi-threading

2015-04-13 Thread Tom Stellard
--- run.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/run.c b/run.c index 3027004..8dc1be0 100644 --- a/run.c +++ b/run.c @@ -276,7 +276,9 @@ const struct platform platforms[] = { void print_usage(const char *prog_name) { fprintf(stderr, -

[Mesa-dev] [PATCH shader-db 4/5] Add si-report.py for parsing dumps from radeonsi

2015-04-13 Thread Tom Stellard
--- si-report.py | 324 +++ 1 file changed, 324 insertions(+) create mode 100755 si-report.py diff --git a/si-report.py b/si-report.py new file mode 100755 index 000..fbeed11 --- /dev/null +++ b/si-report.py @@ -0,0 +1,324 @@ +#!/usr/bi

[Mesa-dev] [PATCH shader-db 5/5] README: Add instructions for radeonsi

2015-04-13 Thread Tom Stellard
--- README | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/README b/README index 4e09937..adb970c 100644 --- a/README +++ b/README @@ -4,7 +4,7 @@ A giant pile of shaders from various apps, for whatever purpose. In particular, we use it to capture assembly

[Mesa-dev] [PATCH shader-db 2/5] run.c: Use getopt for argument parsing

2015-04-13 Thread Tom Stellard
--- run.c | 62 -- 1 file changed, 40 insertions(+), 22 deletions(-) diff --git a/run.c b/run.c index a9d370d..3027004 100644 --- a/run.c +++ b/run.c @@ -1,6 +1,7 @@ /* vim: set expandtab tabstop=4 softtabstop=4 shiftwidth=4: */ /* *

[Mesa-dev] [PATCH shader-db 1/5] run.c: Use computed value of max_threads

2015-04-13 Thread Tom Stellard
--- run.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/run.c b/run.c index 414f21d..a9d370d 100644 --- a/run.c +++ b/run.c @@ -477,7 +477,7 @@ main(int argc, char **argv) if (signal(SIGSEGV, abort_handler) == SIG_ERR) fprintf(stderr, "WARNING: could not install

[Mesa-dev] [PATCH 3/4] nir: Validate that tex_instr src components are the right size.

2015-04-13 Thread Eric Anholt
--- src/glsl/nir/nir_validate.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c index a7aa798..d7ba374 100644 --- a/src/glsl/nir/nir_validate.c +++ b/src/glsl/nir/nir_validate.c @@ -97,6 +97,16 @@ ty

[Mesa-dev] [PATCH 1/4] nir: Fix bug in handling non-SSA copy prop of indirect register access.

2015-04-13 Thread Eric Anholt
The intention was to not copy propagate this source (which has some variable access), but instead copy propagate its variable offset value. --- src/glsl/nir/nir_opt_copy_propagate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/nir_opt_copy_propagate.c b/src/gls

[Mesa-dev] [PATCH 2/4] gallium/ttn: Validate our shader after we generate it.

2015-04-13 Thread Eric Anholt
There's a bunch of lovely code to sanity-check us in ways that we might not catch immediately (or as obviously) through piglit fails, so let's use it. --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/ga

[Mesa-dev] [PATCH 4/4] nir: Validate that the tex_instr dest is the right size.

2015-04-13 Thread Eric Anholt
--- src/glsl/nir/nir_validate.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c index d7ba374..2c80e44 100644 --- a/src/glsl/nir/nir_validate.c +++ b/src/glsl/nir/nir_validate.c @@ -107,6 +107,16 @@

Re: [Mesa-dev] [PATCH] Fix 32bit compilation with -Werror=implicit-function-declaration

2015-04-13 Thread Brian Paul
On 04/13/2015 01:49 PM, Pali Rohár wrote: On Monday 13 April 2015 21:26:32 Pali Rohár wrote: File glapi_entrypoint.c calls memcpy() function, but does not include string.h header. So compilation can fail at error: implicit declaration of function 'memcpy'. --- src/mapi/glapi/glapi_entrypoint.c

[Mesa-dev] [PATCH] Fix 32bit compilation with -Werror=implicit-function-declaration

2015-04-13 Thread Pali Rohár
File glapi_entrypoint.c calls memcpy() function, but does not include string.h header. So compilation can fail at error: implicit declaration of function 'memcpy'. --- src/mapi/glapi/glapi_entrypoint.c 2015-04-13 21:11:09.0 +0200 +++ src/mapi/glapi/glapi_entrypoint.c 2015-04-13 21:11:

Re: [Mesa-dev] [PATCH] Fix 32bit compilation with -Werror=implicit-function-declaration

2015-04-13 Thread Pali Rohár
On Monday 13 April 2015 21:26:32 Pali Rohár wrote: > File glapi_entrypoint.c calls memcpy() function, but does not > include string.h header. So compilation can fail at error: > implicit declaration of function 'memcpy'. > > --- src/mapi/glapi/glapi_entrypoint.c 2015-04-13 > 21:11:09.0 +02

Re: [Mesa-dev] [PATCH 1/2] configure.ac: print LLVM_LDFLAGS

2015-04-13 Thread Brian Paul
On 04/13/2015 02:06 PM, Marek Olšák wrote: From: Marek Olšák --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index 9e8c1d8..6ccf3b4 100644 --- a/configure.ac +++ b/configure.ac @@ -2543,6 +2543,7 @@ if test "x$MESA_LLVM" = x1; then echo

[Mesa-dev] [Bug 89018] Civilization: Beyond Earth terrain section not rendered

2015-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89018 --- Comment #15 from Brian Paul --- If you want to temporarily disable an extension in mesa: export MESA_EXTENSION_OVERRIDE=-GL_NV_texture_rectangle for example. Note the leading "-" which means 'turn off this extension'. For the firegl drive

[Mesa-dev] [Bug 89018] Civilization: Beyond Earth terrain section not rendered

2015-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89018 --- Comment #14 from Sami Liedes --- I grepped the game executable for any of the 159 extensions which are either available in Mesa but not in fglrx or the other way round, since it's obvious something (maybe the presence or lack of an extension?

Re: [Mesa-dev] st/mesa: align cube map arrays layers

2015-04-13 Thread Tom Stellard
Hi Dave, This patch fixes: https://bugs.freedesktop.org/show_bug.cgi?id=89957 And should also be marked cc stable. Tested-by: Tom Stellard ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965/fs: Correct mistake in determining whether a MUL is negated.

2015-04-13 Thread Matt Turner
a * b is equivalent to -a * -b, and the previous code was failing at that. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89961 --- src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_cse.cpp b/src/

[Mesa-dev] [PATCH 1/2] configure.ac: print LLVM_LDFLAGS

2015-04-13 Thread Marek Olšák
From: Marek Olšák --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index 9e8c1d8..6ccf3b4 100644 --- a/configure.ac +++ b/configure.ac @@ -2543,6 +2543,7 @@ if test "x$MESA_LLVM" = x1; then echo "LLVM_CFLAGS: $LLVM_CFLAGS" ech

[Mesa-dev] [PATCH 2/2] configure.ac: add --enable-assertions

2015-04-13 Thread Marek Olšák
From: Marek Olšák --- configure.ac | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6ccf3b4..f5eeb7d 100644 --- a/configure.ac +++ b/configure.ac @@ -402,6 +402,13 @@ AC_ARG_ENABLE([debug], [enable_debug="$enableval"], [e

[Mesa-dev] [PATCH 3/3] radeon/llvm: Improve codegen for KILL_IF

2015-04-13 Thread Tom Stellard
Rather than emitting one kill instruction per component of KILL_IF's src reg, we now or the components of the src register together and use the result as a condition for just one kill instruction. shader-db stats (bonaire): 979 shaders Totals: SGPRS: 34872 -> 34848 (-0.07 %) VGPRS: 20696 -> 20676

[Mesa-dev] [PATCH 2/3] radeon/llvm: Run LLVM's instruction combining pass

2015-04-13 Thread Tom Stellard
This should improve code quality in general and will help with some future changes to how we emit kill instructions. shader-db shows a few regressions, but these don't seem to be the result of deficiencies in instcombine. They're mostly caused by the scheduler making different decisions than befo

[Mesa-dev] [PATCH 1/3] radeonsi: Add header and footer to shader stat dump

2015-04-13 Thread Tom Stellard
This makes it easier to parse. --- src/gallium/drivers/radeonsi/si_shader.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index b4709ac..89f02ab 100644 --- a/src/gallium/drivers/radeons

Re: [Mesa-dev] [PATCH] i965: Flush batchbuffer containing the query on glQueryCounter.

2015-04-13 Thread Mathias Fröhlich
Hi Kenneth, > D'oh. Thanks :) > > Reviewed-by: Kenneth Graunke > Cc: mesa-sta...@lists.freedesktop.org Thanks for the review and pushed! Mathias ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/

Re: [Mesa-dev] [PATCH] i965: Flush batchbuffer containing the query on glQueryCounter.

2015-04-13 Thread Mathias Fröhlich
Hi, On Sunday, April 12, 2015 10:29:57 Matt Turner wrote: > In the future, instead of putting this in the commit message itself, > use git send-email --annotate and put it below the --- > > Commentary below --- won't be put into the git log when you git am the patch. Ok, I try to remember this

[Mesa-dev] [Bug 86701] [regression] weston-simple-egl not running anymore inside qemu

2015-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86701 --- Comment #13 from Daniel Stone --- Two reasons why VGEM is less helpful on Wayland than X11: - MIT-SHM on X forces you to allocate out of POSIX/SysV (forget which) SHM regions, i.e. shmat() and friends; this is not true of wl_shm, which lets

Re: [Mesa-dev] [PATCH] glsl-1.10: new test for a special case in glsl-to-tgsi

2015-04-13 Thread Marek Olšák
Sorry, wrong mailing list. Marek On Mon, Apr 13, 2015 at 7:59 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > .../glsl-1.10/execution/uniform-update.shader_test | 50 > ++ > 1 file changed, 50 insertions(+) > create mode 100644 tests/spec/glsl-1.10/execution/uniform-

[Mesa-dev] [Bug 86701] [regression] weston-simple-egl not running anymore inside qemu

2015-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86701 --- Comment #12 from Daniel Stone --- (In reply to Marek Olšák from comment #11) > Is it the EGL_WL_bind_wayland_display extension that you'd like to have or > something else? I'd like to understand exactly what is missing. Client-side support f

[Mesa-dev] [PATCH] glsl-1.10: new test for a special case in glsl-to-tgsi

2015-04-13 Thread Marek Olšák
From: Marek Olšák --- .../glsl-1.10/execution/uniform-update.shader_test | 50 ++ 1 file changed, 50 insertions(+) create mode 100644 tests/spec/glsl-1.10/execution/uniform-update.shader_test diff --git a/tests/spec/glsl-1.10/execution/uniform-update.shader_test b/tests/sp

Re: [Mesa-dev] [PATCH] i965: Always use Y-tiled buffers on SKL+

2015-04-13 Thread Chris Wilson
On Mon, Apr 13, 2015 at 04:31:29PM +0200, Daniel Vetter wrote: > On Sat, Apr 11, 2015 at 01:16:11PM -0700, Ben Widawsky wrote: > > Starting with Skylake, the display engine is capable of scanning out from > > Y-tiled buffers. As such, we can and should use Y-tiling for better > > efficiency. > >

Re: [Mesa-dev] [PATCH 1/4] gallium/ttn: add support for texture offsets

2015-04-13 Thread Rob Clark
On Mon, Apr 13, 2015 at 1:34 PM, Eric Anholt wrote: > Rob Clark writes: > >> From: Rob Clark >> >> Signed-off-by: Rob Clark >> --- >> src/gallium/auxiliary/nir/tgsi_to_nir.c | 30 +- >> 1 file changed, 29 insertions(+), 1 deletion(-) >> >> diff --git a/src/gallium/a

Re: [Mesa-dev] [PATCH 1/4] gallium/ttn: add support for texture offsets

2015-04-13 Thread Ilia Mirkin
On Mon, Apr 13, 2015 at 1:34 PM, Eric Anholt wrote: > Rob Clark writes: > >> From: Rob Clark >> >> Signed-off-by: Rob Clark >> --- >> src/gallium/auxiliary/nir/tgsi_to_nir.c | 30 +- >> 1 file changed, 29 insertions(+), 1 deletion(-) >> >> diff --git a/src/gallium/a

Re: [Mesa-dev] [PATCH 1/4] gallium/ttn: add support for texture offsets

2015-04-13 Thread Eric Anholt
Rob Clark writes: > From: Rob Clark > > Signed-off-by: Rob Clark > --- > src/gallium/auxiliary/nir/tgsi_to_nir.c | 30 +- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c > b/src/gallium/auxiliary/nir/tgsi_t

[Mesa-dev] [Bug 86701] [regression] weston-simple-egl not running anymore inside qemu

2015-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86701 --- Comment #11 from Marek Olšák --- Is it the EGL_WL_bind_wayland_display extension that you'd like to have or something else? I'd like to understand exactly what is missing. -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [Bug 86701] [regression] weston-simple-egl not running anymore inside qemu

2015-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86701 --- Comment #10 from Manuel Bachmann --- This is a very important feature for us, too. Reading the upstream thread, it seems there were legitimate reasons to remove egl-gallium, but bringing egl_dri2 to feature parity before doing that was ignore

Re: [Mesa-dev] [PATCH 1/6] glsl_to_tgsi: cleanup includes

2015-04-13 Thread Brian Paul
On 04/11/2015 01:12 PM, Marek Olšák wrote: From: Marek Olšák --- src/mesa/state_tracker/st_atom_shader.c| 3 +-- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 24 src/mesa/state_tracker/st_glsl_to_tgsi.h | 7 --- 3 files changed, 9 insertions(+), 25 dele

Re: [Mesa-dev] Concurrent piglit run on Skylake (was: [PATCH] i965/skl: Use an exec size of 8 to initialise the message header)

2015-04-13 Thread Neil Roberts
Ben Widawsky writes: > Does this happen to allow concurrent piglit to not die in a fire? Hrm, I just tried running piglit without -1 on my wip/skylake branch (without this patch) and it seems to work fine! I don't know what has fixed it but these are the three patches on that branch: d2e8cd7 i9

Re: [Mesa-dev] [PATCH] swrast: Mark MAX_GLUINT literal with u suffix.

2015-04-13 Thread Brian Paul
On 04/11/2015 11:23 AM, Matt Turner wrote: Coverity is confused by the "float < int / 2" expression and suggests casting MAX_GLUINT to unsigned, which I believe it was supposed to have been already. --- src/mesa/swrast/s_tritemp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [Mesa-dev] [PATCH 1/2] st/mesa: add a debug option to compile shaders at link time

2015-04-13 Thread Tom Stellard
On Sat, Apr 11, 2015 at 01:49:26AM +0200, Marek Olšák wrote: > From: Marek Olšák > > v2: fix crashes Both patches are: Tested-by: Tom Stellard > --- > src/mesa/state_tracker/st_cb_program.c | 4 +++ > src/mesa/state_tracker/st_debug.c | 1 + > src/mesa/state_tracker/st_debug.h

Re: [Mesa-dev] [PATCH] i965: Implement proper workaround for Gen4 GPU CONSTANT_BUFFER hangs.

2015-04-13 Thread Matt Turner
On Mon, Apr 13, 2015 at 1:26 AM, Kenneth Graunke wrote: > I finally managed to dig up some information on our mysterious GPU hangs. > A wiki page from the Crestline validation team mentions that they found > a GPU hang in "Serious Sam 2" (on Windows) with remarkably similar > conditions to the one

Re: [Mesa-dev] [PATCH v2 15/24] mesa: mesa_bufferiv utility function for buffer objects

2015-04-13 Thread Martin Peres
On 01/04/15 15:14, Tapani Pälli wrote: Patch adds new function 'mesa_bufferiv' and refactors existing GetActiveUniformBlockiv and GetActiveAtomicCounterBufferiv to use it. corresponding Piglit tests: arb_uniform_buffer_object* arb_shader_atomic_counters* (Many tests hit the correspondin

Re: [Mesa-dev] [PATCH 3/7] i965: Refactor brw_is_hiz_depth_format()

2015-04-13 Thread Chad Versace
On Fri 10 Apr 2015, Pohjolainen, Topi wrote: On Thu, Apr 09, 2015 at 08:57:04PM -0700, Chad Versace wrote: diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index a906460..492338b 100644 --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree

Re: [Mesa-dev] [PATCH 4/7] i965: Add field intel_mipmap_tree::disable_aux_buffers

2015-04-13 Thread Chad Versace
On Fri 10 Apr 2015, Pohjolainen, Topi wrote: On Thu, Apr 09, 2015 at 08:57:05PM -0700, Chad Versace wrote: @@ -440,6 +451,10 @@ intel_miptree_create_layout(struct brw_context *brw, brw_miptree_layout(brw, mt); + if (mt->disable_aux_buffers) { + assert(mt->msaa_layout != INTEL_MSAA

Re: [Mesa-dev] Valve games for Mesa/DRI developers

2015-04-13 Thread Daniel Stone
Hi, On 13 April 2015 at 15:06, Thierry Reding wrote: > I'm not much of a gamer myself, but I imagine that these games would be > useful, real-life tests and/or entertaining benchmarks. Given that I > work mostly on ARM systems, do you know if there are any plans on making > these games available

Re: [Mesa-dev] [PATCH v2 24/24] mesa: refactor GetUniformBlockIndex

2015-04-13 Thread Martin Peres
On 01/04/15 15:14, Tapani Pälli wrote: Use _mesa_program_resource_index to get index. Signed-off-by: Tapani Pälli --- src/mesa/main/uniforms.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c index f4de1df..5

Re: [Mesa-dev] [PATCH v2 14/24] mesa: refactor GetFragDataIndex

2015-04-13 Thread Martin Peres
On 01/04/15 15:14, Tapani Pälli wrote: Use _mesa_program_resource_location_index to fetch index. Signed-off-by: Tapani Pälli Reviewed-by: Ilia Mirkin --- src/mesa/main/shader_query.cpp | 25 ++--- 1 file changed, 2 insertions(+), 23 deletions(-) diff --git a/src/mesa/

Re: [Mesa-dev] [PATCH v2 23/24] mesa: refactor GetUniformIndices

2015-04-13 Thread Martin Peres
On 01/04/15 15:14, Tapani Pälli wrote: Use _mesa_program_resource_index to get indices. Signed-off-by: Tapani Pälli --- src/mesa/main/uniforms.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c index 0c16641..f4de1d

Re: [Mesa-dev] [PATCH] i965: Always use Y-tiled buffers on SKL+

2015-04-13 Thread Daniel Vetter
On Sat, Apr 11, 2015 at 01:16:11PM -0700, Ben Widawsky wrote: > Starting with Skylake, the display engine is capable of scanning out from > Y-tiled buffers. As such, we can and should use Y-tiling for better > efficiency. > > Note that the buffer allocation done for mipmaps will already never all

Re: [Mesa-dev] [PATCH v2 22/24] mesa: refactor GetUniformLocation

2015-04-13 Thread Martin Peres
On 01/04/15 15:14, Tapani Pälli wrote: Use _mesa_program_resource_location to get location. Signed-off-by: Tapani Pälli --- src/mesa/main/uniforms.c | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c ind

Re: [Mesa-dev] [PATCH v2 21/24] mesa: refactor GetActiveUniformBlockName

2015-04-13 Thread Martin Peres
On 01/04/15 15:14, Tapani Pälli wrote: Use _mesa_get_program_resource_name to get name. Signed-off-by: Tapani Pälli --- src/mesa/main/uniforms.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c index 0

Re: [Mesa-dev] [PATCH v2 20/24] mesa: remove unused _mesa_get_uniform_name

2015-04-13 Thread Martin Peres
On 01/04/15 15:14, Tapani Pälli wrote: Signed-off-by: Tapani Pälli --- src/mesa/main/uniforms.c | 39 --- src/mesa/main/uniforms.h | 5 - 2 files changed, 44 deletions(-) diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c index 69f8a3f.

Re: [Mesa-dev] [PATCH v2 19/24] mesa: refactor GetActiveUniformName

2015-04-13 Thread Martin Peres
On 01/04/15 15:14, Tapani Pälli wrote: Use _mesa_get_program_resource_name to get name. Signed-off-by: Tapani Pälli --- src/mesa/main/uniforms.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c index dc9b5a0..

Re: [Mesa-dev] [PATCH v2 18/24] mesa: refactor GetActiveUniform

2015-04-13 Thread Martin Peres
On 01/04/15 15:14, Tapani Pälli wrote: Signed-off-by: Tapani Pälli --- src/mesa/main/uniform_query.cpp | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 9611667..4e77b

Re: [Mesa-dev] [PATCH v2 17/24] mesa: refactor GetTransformFeedbackVarying

2015-04-13 Thread Martin Peres
On 01/04/15 15:14, Tapani Pälli wrote: Signed-off-by: Tapani Pälli --- src/mesa/main/transformfeedback.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/transformfeedback.c b/src/mesa/main/transformfeedback.c index 0a6d00c..103011c 10064

Re: [Mesa-dev] [PATCH v2 13/24] mesa: refactor GetFragDataLocation

2015-04-13 Thread Martin Peres
On 01/04/15 15:14, Tapani Pälli wrote: Use program_resource_location to fetch location. Signed-off-by: Tapani Pälli --- src/mesa/main/shader_query.cpp | 38 -- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/src/mesa/main/shader_query.cpp

Re: [Mesa-dev] [PATCH v2 12/24] mesa: refactor GetAttribLocation

2015-04-13 Thread Martin Peres
On 01/04/15 15:14, Tapani Pälli wrote: Use program_resource_location to fetch location. Signed-off-by: Tapani Pälli --- src/mesa/main/shader_query.cpp | 42 -- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/src/mesa/main/shader_query.c

Re: [Mesa-dev] [PATCH v2 01/24] linker: fix varying linking if SSO program has only gs and fs

2015-04-13 Thread Martin Peres
On 13/04/15 14:15, Tapani Pälli wrote: On 04/13/2015 11:18 AM, Martin Peres wrote: On 13/04/15 11:08, Martin Peres wrote: On 02/04/15 13:27, Tapani Pälli wrote: On 04/02/2015 12:36 PM, Martin Peres wrote: On 01/04/15 15:14, Tapani Pälli wrote: Previously linker did not take in to

Re: [Mesa-dev] [PATCH v2 10/24] mesa: enable GL_ARB_program_interface_query extension

2015-04-13 Thread Martin Peres
On 01/04/15 15:14, Tapani Pälli wrote: (and mark it as DONE in docs/GL3.txt + 10.6.0 relnotes) Signed-off-by: Tapani Pälli --- docs/GL3.txt | 4 ++-- docs/relnotes/10.6.0.html | 1 + src/mesa/main/extensions.c | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --g

Re: [Mesa-dev] [PATCH v2 09/24] mesa: implementation of glGetProgramResourceiv

2015-04-13 Thread Martin Peres
On 01/04/15 15:14, Tapani Pälli wrote: Patch adds required helper functions to shaderapi.h and the actual implementation. The property query functionality can be tested with tests for following functions that are refactored by later patches: GetActiveAtomicCounterBufferiv GetActiveUnifo

Re: [Mesa-dev] Valve games for Mesa/DRI developers

2015-04-13 Thread Thierry Reding
Hi Daniel, I'm not much of a gamer myself, but I imagine that these games would be useful, real-life tests and/or entertaining benchmarks. Given that I work mostly on ARM systems, do you know if there are any plans on making these games available on ARM? I know some of Valve's games have been port

Re: [Mesa-dev] [PATCH v2 08/24] mesa: glGetProgramResourceLocationIndex

2015-04-13 Thread Martin Peres
On 01/04/15 15:14, Tapani Pälli wrote: Patch adds required helper functions to shaderapi.h and the actual implementation. The added functionality can be tested by tests for following functions that are refactored by later patches: GetFragDataIndex v2: return -1 if output not referenced by

Re: [Mesa-dev] [PATCH v2 07/24] mesa: glGetProgramResourceLocation

2015-04-13 Thread Martin Peres
On 01/04/15 15:14, Tapani Pälli wrote: Patch adds required helper functions to shaderapi.h and the actual implementation. corresponding Piglit test: arb_program_interface_query-resource-location The added functionality can be tested by tests for following functions that are refactored by la

Re: [Mesa-dev] [PATCH v2 06/24] mesa: glGetProgramResourceName

2015-04-13 Thread Martin Peres
On 01/04/15 15:14, Tapani Pälli wrote: Patch adds required helper functions to shaderapi.h and the actual implementation. Name generation copied from '_mesa_get_uniform_name' which can be removed later by refactoring functions to use resource list. The added functionality can be tested by tests

Re: [Mesa-dev] [PATCH] i965/skl: Use an exec size of 8 to initialise the message header

2015-04-13 Thread Neil Roberts
Ben Widawsky writes: > Can you do me a favor since I am lazy? Can you send the generated asm > diff with this patch? I am admittedly rusty on the matter, but I > thought a mov is just a mov, and only the regioning is effected by the > retype. If it indeed does what you say, it really should fix >

[Mesa-dev] [Bug 86701] [regression] weston-simple-egl not running anymore inside qemu

2015-04-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86701 --- Comment #9 from Marko Moberg --- SW rastering for EGL is really an important feature for us. We have an embedded device with no GPU and no display. We are planning on using Wayland/Weston with RDP protocol to display OpenGl graphics over netw

  1   2   >