Re: [Mesa-dev] [PATCH 1/4] Whitespace cleanup

2015-03-08 Thread Michel Dänzer
On 07.03.2015 16:56, Giuseppe Bilotta wrote: > --- > src/gallium/include/pipe/p_screen.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/include/pipe/p_screen.h > b/src/gallium/include/pipe/p_screen.h > index ac88506..4018f8a 100644 > --- a/src/gallium/includ

Re: [Mesa-dev] [PATCH 2/4] Introduce get_device_vendor() entrypoint for pipes

2015-03-08 Thread Michel Dänzer
On 07.03.2015 16:56, Giuseppe Bilotta wrote: > This will be needed by Clover to return the correct information > to CL_DEVICE_VENDOR info queries. > --- > src/gallium/docs/source/screen.rst | 6 ++ > src/gallium/include/pipe/p_screen.h | 8 > 2 files changed, 14 insertions(+) > > di

Re: [Mesa-dev] nesa-10.4.4: gallivm/lp_bld_misc.cpp:503:38: error: no viable conversion from 'ShaderMemoryManager *' to 'std::unique_ptr'

2015-03-08 Thread Sedat Dilek
On Fri, Mar 6, 2015 at 8:06 PM, Emil Velikov wrote: > On 4 March 2015 at 18:07, Roland Scheidegger wrote: >> Am 04.03.2015 um 12:38 schrieb Jose Fonseca: >>> On 04/03/15 02:00, Emil Velikov wrote: On 27 February 2015 at 23:28, Sedat Dilek wrote: > On Mon, Feb 9, 2015 at 6:30 PM, Emil Ve

Re: [Mesa-dev] [PATCH] st/mesa: drop unused texture function

2015-03-08 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Sun, Mar 8, 2015 at 7:52 PM, Dave Airlie wrote: > This has no users. > > Signed-off-by: Dave Airlie > --- > src/mesa/state_tracker/st_texture.c | 40 > - > src/mesa/state_tracker/st_texture.h | 10 -- > 2 files changed, 5

[Mesa-dev] [PATCH] st/mesa: drop unused texture function

2015-03-08 Thread Dave Airlie
This has no users. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_texture.c | 40 - src/mesa/state_tracker/st_texture.h | 10 -- 2 files changed, 50 deletions(-) diff --git a/src/mesa/state_tracker/st_texture.c b/src/mesa/state_tracker/st_t

Re: [Mesa-dev] [RFC] i965: Factor out descriptor building for indirect send messages

2015-03-08 Thread Pohjolainen, Topi
On Sat, Mar 07, 2015 at 04:15:08PM +0200, Francisco Jerez wrote: > Topi Pohjolainen writes: > > > The original patch from Curro was based on something that is not > > present in the master yet. This patch tries to mimick the logic on > > top master. > > I wanted to see if could separate the build

Re: [Mesa-dev] [PATCH 1/5] i965/fs: Set force_writemask_all on shader_time instructions.

2015-03-08 Thread Kenneth Graunke
On Sunday, March 08, 2015 01:32:33 PM Matt Turner wrote: > On Sun, Mar 8, 2015 at 1:08 AM, Kenneth Graunke wrote: > > These computations don't have anything to do with the currently > > executing channels, so they should use force_writemask_all. > > > > This fixes assert failures. > > > > Bugzilla

Re: [Mesa-dev] [PATCH 1/5] i965/fs: Set force_writemask_all on shader_time instructions.

2015-03-08 Thread Matt Turner
On Sun, Mar 8, 2015 at 1:08 AM, Kenneth Graunke wrote: > These computations don't have anything to do with the currently > executing channels, so they should use force_writemask_all. > > This fixes assert failures. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86974 > Signed-off-by: K

Re: [Mesa-dev] [PATCH] nvc0: fix wrong max value for driver queries

2015-03-08 Thread Samuel Pitoiset
On 03/08/2015 05:45 PM, Ilia Mirkin wrote: On Sun, Mar 8, 2015 at 12:18 PM, Samuel Pitoiset wrote: The maximum value of a Gallium HUD's panel is automatically adjusted when the current value is greater than the max. If we set the pipe_query_driver_info::max_value to UINT64_MAX, the maximum va

Re: [Mesa-dev] [PATCH] nvc0: fix wrong max value for driver queries

2015-03-08 Thread Ilia Mirkin
On Sun, Mar 8, 2015 at 12:18 PM, Samuel Pitoiset wrote: > The maximum value of a Gallium HUD's panel is automatically adjusted > when the current value is greater than the max. If we set the > pipe_query_driver_info::max_value to UINT64_MAX, the maximum value is > never adjusted and this results i

[Mesa-dev] [PATCH] nvc0: fix wrong max value for driver queries

2015-03-08 Thread Samuel Pitoiset
The maximum value of a Gallium HUD's panel is automatically adjusted when the current value is greater than the max. If we set the pipe_query_driver_info::max_value to UINT64_MAX, the maximum value is never adjusted and this results in a right instead of a pretty curve which is correctly scaled. S

Re: [Mesa-dev] [PATCH v4] mesa: improve ARB_copy_image internal format compat check

2015-03-08 Thread Jason Ekstrand
On Mar 7, 2015 10:33 PM, "Kenneth Graunke" wrote: > > On Saturday, March 07, 2015 10:09:15 PM Jason Ekstrand wrote: > > LGTM. > > Jason, > > Sean doesn't have commit access (it's actually his first patch) - if > this is good to go, would you mind pushing it for him? I thought as much. I'll push o

[Mesa-dev] INTEL_DEBUG=shader_time scalar backend fixes

2015-03-08 Thread Kenneth Graunke
Welcome to the rabbit trail. In order to fix Football Manager, I had to rework INTEL_DEBUG=shader_time in the FS backend. While doing that, I hit two assertion failures. After fixing that, I compared numbers. I noticed that VS again accounted for 0 cycles. Matt - could you take a look at brw_ve

[Mesa-dev] [PATCH 5/5] i965/fs: Make emit_shader_time_end() insert before EOT.

2015-03-08 Thread Kenneth Graunke
Previously, we emitted the shader-time epilogue from emit_fb_writes(), during the middle of looping through color regions (or emit_urb_writes for the VS). This is duplicated several times and rather awkward. I need to fix a bug in our FB write handling, and it will be a lot easier if we move emit

[Mesa-dev] [PATCH 2/5] i965/fs: Set smear on shader_time diff register.

2015-03-08 Thread Kenneth Graunke
The ADD(diff, diff, fs_reg(-2u)) instruction reads diff, which is a width 1 register. We need to read it as <0,1,0> with a subreg of 0, which is what smear accomplishes. Fixes assertion: brw_eu_emit.c:285: validate_reg: Assertion `hstride == 0' failed. Bugzilla: https://bugs.freedesktop.org/show

[Mesa-dev] [PATCH 1/5] i965/fs: Set force_writemask_all on shader_time instructions.

2015-03-08 Thread Kenneth Graunke
These computations don't have anything to do with the currently executing channels, so they should use force_writemask_all. This fixes assert failures. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86974 Signed-off-by: Kenneth Graunke Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/

[Mesa-dev] [PATCH 3/5] i965/fs: Make emit_shader_time_write return rather than emit.

2015-03-08 Thread Kenneth Graunke
Instead of emit_shader_time_write, we now do emit(SHADER_TIME_ADD(...)). The advantage is that we can also insert a shader time write at an arbitrary location in the instruction stream, rather than being restricted to emitting at the end. Signed-off-by: Kenneth Graunke Reviewed-by: Topi Pohjolain

[Mesa-dev] [PATCH 4/5] i965/fs: Make get_timestamp() pass back the MOV rather than emitting it.

2015-03-08 Thread Kenneth Graunke
This makes another part of the INTEL_DEBUG=shader_time code emittable at arbitrary locations, rather than just at the end of the instruction stream. v2: Don't lose smear! Caught by Topi Pohjolainen. v3: Don't set smear on the destination of the MOV. Thanks Topi! Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH v2 2/4] i965/fs: Make get_timestamp() return an fs_inst * rather than emitting.

2015-03-08 Thread Kenneth Graunke
On Friday, February 27, 2015 11:37:01 PM Pohjolainen, Topi wrote: > On Fri, Feb 27, 2015 at 11:15:35AM -0800, Kenneth Graunke wrote: > > This makes another part of the INTEL_DEBUG=shader_time code emittable > > at arbitrary locations, rather than just at the end of the instruction > > stream. > >