Re: [Mesa-dev] [PATCH] i965/fs: Implement SIMD16 dual source blending.

This looks fine to me. I just kicked off a build on our test farm and, assuming that looks good (I'll send another e-mail in the morning if it does), Reviewed-by: Jason Ekstrand I ran shader-db on the change and I was kind of surprised to see that it doesn't really do anything. GAINED: shaders

Re: [Mesa-dev] [PATCH] nir: Make the printer include nir_variable::location too.

Reviewed-by: Connor Abbott On Thu, Mar 5, 2015 at 11:26 PM, Kenneth Graunke wrote: > Being able to see both location and driver_location can be useful when > debugging IO mistakes. > > Signed-off-by: Kenneth Graunke > --- > src/glsl/nir/nir_print.c | 2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [Mesa-dev] [PATCH v2 6/6] i965: Don't write past the end of the application supplied buffer

On Wednesday, March 04, 2015 09:55:46 AM Ian Romanick wrote: > From: Ian Romanick > > Both the AMD and Intel APIs provide a dataSize parameter, and this > function would merrily ignore it. Neither API specifies what to do when > the buffer isn't big enough. I take the easy route of writing all

Re: [Mesa-dev] [PATCH 0/8] Hash table and hash set reworking

On Thu, Mar 5, 2015 at 5:36 PM, Thomas Helland wrote: > 2015-02-28 17:05 GMT+01:00 Jason Ekstrand : > > > > On Feb 28, 2015 4:55 AM, "Thomas Helland" > wrote: > >> > >> So here comes my hash-table series mentioned earlier. > >> > >> So, first of all, there's some issues. > >> I've been strugling

Re: [Mesa-dev] [PATCH] nir: Make the printer include nir_variable::location too.

Fine by me Reviewed-by: Jason Ekstrand On Thu, Mar 5, 2015 at 8:26 PM, Kenneth Graunke wrote: > Being able to see both location and driver_location can be useful when > debugging IO mistakes. > > Signed-off-by: Kenneth Graunke > --- > src/glsl/nir/nir_print.c | 2 +- > 1 file changed, 1 inser

[Mesa-dev] [PATCH] nir: Make the printer include nir_variable::location too.

Being able to see both location and driver_location can be useful when debugging IO mistakes. Signed-off-by: Kenneth Graunke --- src/glsl/nir/nir_print.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/nir_print.c b/src/glsl/nir/nir_print.c index 6a3c6a0..30d4821

[Mesa-dev] [PATCH] i965: Move need_throttle and first_post_swapbuffers_batch into the renderbuffer

If there are multiple EGL surfaces associated with one EGL context, for any given surface, we unnecessarily have to wait for swapbuffers to complete on other EGL surfaces because we throttle to the context. By moving first_post_swapbuffers_batch from the brw context into intel_renderuffer, we would

[Mesa-dev] [Bug 89452] [Regression] Gamma controls broken on all SDL/Quake based games

https://bugs.freedesktop.org/show_bug.cgi?id=89452 Luke changed: What|Removed |Added See Also||https://bugzilla.libsdl.org |

Re: [Mesa-dev] [PATCH 0/8] Hash table and hash set reworking

2015-02-28 17:05 GMT+01:00 Jason Ekstrand : > > On Feb 28, 2015 4:55 AM, "Thomas Helland" wrote: >> >> So here comes my hash-table series mentioned earlier. >> >> So, first of all, there's some issues. >> I've been strugling with hitting assertion failures. >> The table returns null at times when

[Mesa-dev] Ask for some help in graphic driver

Hello all,I'm a college student. I have a project that have to write a driver for a GPU implemented on FPGA. I am new in driver and ask for some resource . please help me to start.thanks in advance ___ mesa-dev mailing list mesa-dev@lists.freedesktop

[Mesa-dev] [Bug 89452] [Regression] Gamma controls broken on all SDL/Quake based games

https://bugs.freedesktop.org/show_bug.cgi?id=89452 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 89452] [Regression] Gamma controls broken on all SDL/Quake based games

https://bugs.freedesktop.org/show_bug.cgi?id=89452 Bug ID: 89452 Summary: [Regression] Gamma controls broken on all SDL/Quake based games Product: Mesa Version: git Hardware: Other OS: All Status

Re: [Mesa-dev] [PATCH] Fix invalid extern "C" around header inclusion.

Matt Turner writes: > On Thu, Mar 5, 2015 at 4:54 AM, Jose Fonseca wrote: >> Thanks for doing this. It looks great. >> >> Reviewed-by: Jose Fonseca >> >> >> Feel free to push my patch or I'll push it after you push this one. > > Thanks José. I've just pushed it.

Re: [Mesa-dev] [PATCH 1/3] mesa: Simplify some tests in update_array_format()

On 03/05/2015 03:56 PM, Ian Romanick wrote: On 03/05/2015 10:56 AM, Fredrik Höglund wrote: There is no need to check if these extensions are supported here; if the data type is not supported, we will already have returned a GL_INVALID_ENUM error. From where would GL_INVALID_ENUM have been gen

Re: [Mesa-dev] [PATCH 1/3] mesa: Simplify some tests in update_array_format()

On 03/05/2015 10:56 AM, Fredrik Höglund wrote: > There is no need to check if these extensions are supported here; > if the data type is not supported, we will already have returned a > GL_INVALID_ENUM error. From where would GL_INVALID_ENUM have been generated? Is that the "(typeBit & legalTypes

Re: [Mesa-dev] [PATCH 2/3] mesa: Simplify the update_array_format() tests some more

This patch is Reviewed-by: Ian Romanick On 03/05/2015 10:56 AM, Fredrik Höglund wrote: > Use the typeBit instead of the type when comparing against multiple > data types. > --- > src/mesa/main/varray.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/src/mesa

Re: [Mesa-dev] [PATCH 1/2] i965/vec4: Handle saturate in dump_instruction().

Series is Reviewed-by: Ian Romanick On 03/05/2015 11:39 AM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_vec4.cpp | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp > b/src/mesa/drivers/dri/i965/brw_vec4.cpp > index 0a68413..8edb4d0 1

Re: [Mesa-dev] [PATCH] i965: Throttle rendering to an fbo

On 03/04/2015 10:28 AM, Chad Versace wrote: > On 03/04/2015 09:52 AM, Chris Wilson wrote: >> On Wed, Mar 04, 2015 at 09:41:56AM -0800, Chad Versace wrote: >>> On 02/26/2015 05:24 AM, Chris Wilson wrote: When rendering to an fbo, even though it may be acting as a winsys frontbuffer or just

Re: [Mesa-dev] [PATCH 2/2] i965/skl: Disable SIMD16 when 3-source instructions are used

On 03/04/2015 06:46 AM, Neil Roberts wrote: > Ilia Mirkin writes: > >> On Wed, Mar 4, 2015 at 9:33 AM, Neil Roberts wrote: >>> Stepping C0 of Skylake fails when using SIMD16 with 3-source >>> instructions (such as MAD). This patch just makes it disable SIMD16 in >>> that case. >>> >>> This imple

[Mesa-dev] [PATCH 2/4] Introduce get_device_vendor() entrypoint for pipes

This will be needed by Clover to return the correct information to CL_DEVICE_VENDOR info queries. --- src/gallium/include/pipe/p_screen.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/gallium/include/pipe/p_screen.h b/src/gallium/include/pipe/p_screen.h index 4018f8a..cba4c95 1

[Mesa-dev] [PATCH 3/4] Implement get_device_vendor() for existing drivers

The only hackish ones are llvmpipe and softpipe, which currently return the same string as for get_vendor(), while ideally they should return the CPU vendor. --- src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/galahad/glhd_screen.c| 10 ++ src/gallium/d

[Mesa-dev] [PATCH 0/4] Separate device from driver vendor

OpenCL (as opposed to OpenGL) has separate vendor strings for the implementation/driver/platform and the device. CL_PLATFORM_VENDOR is akin to the GL_VENDOR string, while CL_DEVICE_VENDOR is supposed to return the actual device vendor. (For example, the AMD OpenCL platform returns GenuineIntel as

[Mesa-dev] [PATCH 1/4] Whitespace cleanup

--- src/gallium/include/pipe/p_screen.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/include/pipe/p_screen.h b/src/gallium/include/pipe/p_screen.h index ac88506..4018f8a 100644 --- a/src/gallium/include/pipe/p_screen.h +++ b/src/gallium/include/pipe/p_screen.h @

[Mesa-dev] [PATCH 4/4] Clover: use get_device_vendor instead of get_vendor

The pipe's get_vendor method returns something more akin to a driver vendor string in most cases, instead of the actual device vendor. Use get_device_vendor instead, which was introduced specifically for this purpose. --- src/gallium/state_trackers/clover/core/device.cpp | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH] i965: Fix URB size for CHV

On Thursday, March 05, 2015 07:41:29 PM Ville Syrjälä wrote: > On Fri, Jan 23, 2015 at 12:12:56PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Increase the device info .urb.size for CHV to match the default URB > > size (192kB). > > > > Signed-off-by: Ville Syrjälä

Re: [Mesa-dev] [PATCH 2/4] mesa: Set the correct image size in _mesa_validate_pbo_access()

Reviewed-by: Laura Ekstrand On Thu, Mar 5, 2015 at 12:20 AM, Eduardo Lima Mitev wrote: > _mesa_validate_pbo_access() provides a generic way to check that a > requested pixel transfer operation on a PBO falls within the > boundaries of the buffer. It is used in various other places, and > depend

Re: [Mesa-dev] [PATCH] mesa: Fix build errors on x86+sse

On Thu, Mar 05, 2015 at 11:40:16AM -0800, Matt Turner wrote: > On Thu, Mar 5, 2015 at 11:32 AM, wrote: > > From: Ville Syrjälä > > I committed a patch a little while ago from Mark to fix this (as > commit 5f9ee6a0). Yep see it now. I must have fetched more or less just before you pushed it. Bu

[Mesa-dev] [PATCH 3/5] i915: Remove (mostly) unused IS_PNV, IS_PNVG, and IS_PNVGM macros

From: Ian Romanick Inspired by Damien's recent libdrm changes. Signed-off-by: Ian Romanick Cc: Damien Lespiau --- src/mesa/drivers/dri/i915/intel_chipset.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i915/intel_chipset.h b/src/mesa/drivers

[Mesa-dev] [PATCH 2/5] i915: Remove IS_9XX macro

From: Ian Romanick Since the i915 / i965 split, IS_9XX just means IS_GEN3. Inspired by Damien's recent libdrm changes. Signed-off-by: Ian Romanick Cc: Damien Lespiau --- src/mesa/drivers/dri/i915/intel_chipset.h | 3 --- src/mesa/drivers/dri/i915/intel_screen.c | 4 ++-- 2 files changed, 2

[Mesa-dev] [PATCH 5/5] i915: Remove unused IS_GEN2 macro

From: Ian Romanick Inspired by Damien's recent libdrm changes. Signed-off-by: Ian Romanick Cc: Damien Lespiau --- src/mesa/drivers/dri/i915/intel_chipset.h | 5 - 1 file changed, 5 deletions(-) diff --git a/src/mesa/drivers/dri/i915/intel_chipset.h b/src/mesa/drivers/dri/i915/intel_chip

[Mesa-dev] [PATCH 1/5] i915: Remove unused IS_MOBILE macro

From: Ian Romanick Inspired by Damien's recent libdrm changes. Signed-off-by: Ian Romanick Cc: Damien Lespiau --- src/mesa/drivers/dri/i915/intel_chipset.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/src/mesa/drivers/dri/i915/intel_chipset.h b/src/mesa/drivers/dri/i915/int

[Mesa-dev] [PATCH 4/5] i915: Remove (mostly) unused IS_915 macro

From: Ian Romanick Inspired by Damien's recent libdrm changes. Signed-off-by: Ian Romanick Cc: Damien Lespiau --- src/mesa/drivers/dri/i915/intel_chipset.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i915/intel_chipset.h b/src/mesa/drivers

Re: [Mesa-dev] [PATCH] mesa: Fix build errors on x86+sse

On Thu, Mar 5, 2015 at 11:32 AM, wrote: > From: Ville Syrjälä I committed a patch a little while ago from Mark to fix this (as commit 5f9ee6a0). ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mes

[Mesa-dev] [PATCH 2/2] i965/vec4: Don't lose the saturate modifier in copy propagation.

From: Andrey Sudnik Cc: 10.4, 10.5 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89224 Reviewed-by: Matt Turner --- src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_copy_propa

[Mesa-dev] [PATCH 1/2] i965/vec4: Handle saturate in dump_instruction().

--- src/mesa/drivers/dri/i965/brw_vec4.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp index 0a68413..8edb4d0 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp +++ b/src/mesa/drivers/dri/i965/brw_vec4.cpp

[Mesa-dev] [PATCH] mesa: Fix build errors on x86+sse

From: Ville Syrjälä tnl/t_vertex_sse.c: In function ‘build_vertex_emit’: tnl/t_vertex_sse.c:500:6: error: implicit declaration of function ‘printf’ [-Werror=implicit-function-declaration] printf("Can't emit 1ub %x %x %d\n", a->vertoffset, a[-1].vertoffset, a[-1].vertattrsize ); ^ tn

Re: [Mesa-dev] [PATCH 7/9] radeonsi: add support for easy opcodes from ARB_gpu_shader5

On Mon, Mar 02, 2015 at 12:54:21PM +0100, Marek Olšák wrote: > From: Marek Olšák > Hi Marek, After discussing with Matt, I think we should use LLVM IR rather than intrinsics for IBFE and UBFE and then add patterns for them either in the TableGen Files or AMDGPUISelDAGToDAG.cpp. Using intrinsic

Re: [Mesa-dev] [PATCH] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG

> On Mar 5, 2015, at 10:42 AM, Francisco Jerez wrote: > > Could you add that this is according to the OpenCL 1.1 specification? > OpenCL 1.2 is even weaker (CL_FP_INF_NAN is not required, only one of > CL_FP_ROUND_TO_ZERO or CL_FP_ROUND_TO_NEAREST is required, and no FP > capabilities at all are

[Mesa-dev] [PATCH 3/3] mesa: Reorder some tests in update_array_format()

GL_INVALID_OPERATION should take precedence over GL_INVALID_VALUE when there is a size error with a packed type. --- src/mesa/main/varray.c | 59 +++--- 1 file changed, 42 insertions(+), 17 deletions(-) diff --git a/src/mesa/main/varray.c b/src/mesa/mai

[Mesa-dev] [PATCH 2/3] mesa: Simplify the update_array_format() tests some more

Use the typeBit instead of the type when comparing against multiple data types. --- src/mesa/main/varray.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c index efc1431..3571f7d 100644 --- a/src/mesa/main/varray.c +++ b

[Mesa-dev] [PATCH 1/3] mesa: Simplify some tests in update_array_format()

There is no need to check if these extensions are supported here; if the data type is not supported, we will already have returned a GL_INVALID_ENUM error. --- src/mesa/main/varray.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/src/mesa/main/varray.c b/

Re: [Mesa-dev] [PATCH] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG

Tom Stellard writes: > This means dropping CL_FP_DENORM from the current return value. > --- > src/gallium/state_trackers/clover/api/device.cpp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/state_trackers/clover/api/device.cpp > b/src/gallium/state_trac

Re: [Mesa-dev] [PATCH 1/4] meta: Remove error checks for texture <-> pixel-buffer transfers that don't belong in driver code

On 03/05/2015 06:55 PM, Laura Ekstrand wrote: > > On Thu, Mar 5, 2015 at 12:20 AM, Eduardo Lima Mitev > wrote: > > diff --git a/src/mesa/drivers/common/meta_tex_subimage.c > b/src/mesa/drivers/common/meta_tex_subimage.c > index bba2b4f..34ef191 100644 > -

Re: [Mesa-dev] [PATCH 2/9] radeonsi: use V_BFE for extracting a sample index

> On Mar 5, 2015, at 6:50 AM, Tom Stellard wrote: > > On Mon, Mar 02, 2015 at 02:09:29PM -0800, Matt Arsenault wrote: >> >>> On Mar 2, 2015, at 1:19 PM, Tom Stellard wrote: >>> >>> On Mon, Mar 02, 2015 at 10:14:00PM +0100, Marek Olšák wrote: On Mon, Mar 2, 2015 at 10:05 PM, Tom Stellard

Re: [Mesa-dev] [PATCH] Fix invalid extern "C" around header inclusion.

On Thu, Mar 5, 2015 at 4:54 AM, Jose Fonseca wrote: > Thanks for doing this. It looks great. > > Reviewed-by: Jose Fonseca > > > Feel free to push my patch or I'll push it after you push this one. Thanks José. I've just pushed it. ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG

On Thu, 2015-03-05 at 14:34 +, Tom Stellard wrote: > This means dropping CL_FP_DENORM from the current return value. > --- > src/gallium/state_trackers/clover/api/device.cpp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/state_trackers/clover/api/devic

Re: [Mesa-dev] [PATCH] fix m32 build: missing stdio inclusions

On Thu, Mar 5, 2015 at 10:14 AM, Mark Janes wrote: > Several patches added include statements where required by the m64 > build. Some files are only compiled for m32, and require similar > changes. > --- Thanks Mark. I changed the prefix to "mesa/x86:" and pushed it.

[Mesa-dev] [PATCH] fix m32 build: missing stdio inclusions

Several patches added include statements where required by the m64 build. Some files are only compiled for m32, and require similar changes. --- src/mesa/tnl/t_vertex_sse.c | 2 ++ src/mesa/x86/rtasm/x86sse.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/mesa/tnl/t_vertex_sse.c b/src

Re: [Mesa-dev] [PATCH 1/4] meta: Remove error checks for texture <-> pixel-buffer transfers that don't belong in driver code

On Thu, Mar 5, 2015 at 12:20 AM, Eduardo Lima Mitev wrote: > The implementation of texture <-> pixel-buffer transfers in drivers common > layer > includes certain error checks and argument validation that don't belong > there, > considering how the Mesa codebase is laid out. These are higher leve

Re: [Mesa-dev] [PATCH] i965: Reserve more batch space to accomodate Gen6 perfmonitors.

On Wed, Mar 04, 2015 at 03:46:57PM -0800, Kenneth Graunke wrote: > Ben noticed that I said each PIPE_CONTROL was 4 DWords, but it's > actually 5 DWords on Gen6-7. We've been reserving insufficient space > for performance monitoring on Sandybridge, which means it would likely > break if you used th

Re: [Mesa-dev] [PATCH] i965: Fix URB size for CHV

On Fri, Jan 23, 2015 at 12:12:56PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Increase the device info .urb.size for CHV to match the default URB > size (192kB). > > Signed-off-by: Ville Syrjälä Ping? > --- > src/mesa/drivers/dri/i965/brw_device_info.c | 2 +- > 1

[Mesa-dev] [Bug 89387] Double delete in lp_bld_misc.cpp

https://bugs.freedesktop.org/show_bug.cgi?id=89387 --- Comment #2 from Chris Vine --- That will work fine. This does beg the question whether the code is correct for llvm < 3.6 (it fixes llvm >= 3.6). -- You are receiving this mail because: You are the assignee for the bug. ___

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA (v2)

Series is: Reviewed-by: Ilia Mirkin On Thu, Mar 5, 2015 at 11:15 AM, Marek Olšák wrote: > From: Marek Olšák > > Needed by ARB_gpu_shader5. > > v2: select DMAD for FMA with double precision; it can be later changed to DFMA > --- > src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + > src/

Re: [Mesa-dev] [PATCH 2/9] radeonsi: use V_BFE for extracting a sample index

On Thu, Mar 05, 2015 at 05:14:09PM +0100, Marek Olšák wrote: > Since you acked patch #3, which depends on this, I assume this has your Rb > too? > No, I still want to resolved with Matt what to do about intrinsics vs IR. -Tom > Marek > > On Mon, Mar 2, 2015 at 10:05 PM, Tom Stellard wrote: >

Re: [Mesa-dev] [PATCH 2/9] radeonsi: use V_BFE for extracting a sample index

Since you acked patch #3, which depends on this, I assume this has your Rb too? Marek On Mon, Mar 2, 2015 at 10:05 PM, Tom Stellard wrote: > On Mon, Mar 02, 2015 at 12:54:16PM +0100, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeonsi/si_shader.c | 22

[Mesa-dev] [PATCH 2/2] tgsi: handle bitwise opcodes in tgsi_opcode_infer_type (v2)

From: Marek Olšák v2: set the same types as the destination type in tgsi_exec --- src/gallium/auxiliary/tgsi/tgsi_info.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_info.c b/src/gallium/auxiliary/tgsi/tgsi_info.c index e6e0a60..93b9a73 100644 ---

[Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA (v2)

From: Marek Olšák Needed by ARB_gpu_shader5. v2: select DMAD for FMA with double precision; it can be later changed to DFMA --- src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + src/gallium/auxiliary/tgsi/tgsi_exec.h | 1 + src/gallium/auxiliary/tgsi/tgsi_info.c | 2

Re: [Mesa-dev] [PATCH] c99_alloca.h: Include stdlib.h on all non-Windows.

Reviewed-by: Brian Paul On 03/05/2015 08:56 AM, Jon TURNEY wrote: On 01/03/2015 21:00, Alan Coopersmith wrote: On 03/ 1/15 12:52 PM, Vinson Lee wrote: Fix build on FreeBSD. Bugzilla: https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fid-3D89364&d=AwICa

Re: [Mesa-dev] [PATCH] c99_alloca.h: Include stdlib.h on all non-Windows.

On 01/03/2015 21:00, Alan Coopersmith wrote: On 03/ 1/15 12:52 PM, Vinson Lee wrote: Fix build on FreeBSD. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89364 Signed-off-by: Vinson Lee --- include/c99_alloca.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a

[Mesa-dev] [PATCH] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG

This means dropping CL_FP_DENORM from the current return value. --- src/gallium/state_trackers/clover/api/device.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/device.cpp b/src/gallium/state_trackers/clover/api/device.cpp index b1f

Re: [Mesa-dev] [PATCH 2/2] i965/skl: Break down SIMD16 3-source instructions when required.

Yes, I like this approach much better. I ran it through Piglit and I can confirm it fixes the same tests as my patch. Reviewed-by: Neil Roberts There's no need to reset the author to me. Thanks for looking at this. Regards, - Neil Kenneth Graunke writes: > Several steppings of Skylake fail w

Re: [Mesa-dev] [PATCH 7/9] radeonsi: add support for easy opcodes from ARB_gpu_shader5

On Mon, Mar 02, 2015 at 12:54:21PM +0100, Marek Olšák wrote: > From: Marek Olšák > I'm still unsure whether it's better to use intrinsics or LLVM IR to implement these. I will think about this some more. -Tom > --- > src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 8 > 1 file

Re: [Mesa-dev] [PATCH 3/9] radeonsi: use S_BFE/V_BFE for extracting bitfields from parameters

On Mon, Mar 02, 2015 at 12:54:17PM +0100, Marek Olšák wrote: > From: Marek Olšák Reviewed-by: Tom Stellard > > And use AND/OR in special cases. > > This universal helper will be used a lot (especially by tessellation). > --- > src/gallium/drivers/radeonsi/si_shader.c | 48 > +

Re: [Mesa-dev] [PATCH 5/9] radeonsi: add support for FMA

On Mon, Mar 02, 2015 at 12:54:19PM +0100, Marek Olšák wrote: > From: Marek Olšák Reviewed-by: Tom Stellard > > --- > src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 2 ++ > src/gallium/drivers/radeonsi/si_pipe.c | 3 ++- > 2 files changed, 4 insertions(+), 1 deletion(-) > >

Re: [Mesa-dev] [PATCH 6/9] radeonsi: add support for SQRT

On Mon, Mar 02, 2015 at 12:54:20PM +0100, Marek Olšák wrote: > From: Marek Olšák > Reviewed-by: Tom Stellard > --- > src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 2 ++ > src/gallium/drivers/radeonsi/si_pipe.c | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > >

Re: [Mesa-dev] [PATCH 2/9] radeonsi: use V_BFE for extracting a sample index

On Mon, Mar 02, 2015 at 02:09:29PM -0800, Matt Arsenault wrote: > > > On Mar 2, 2015, at 1:19 PM, Tom Stellard wrote: > > > > On Mon, Mar 02, 2015 at 10:14:00PM +0100, Marek Olšák wrote: > >> On Mon, Mar 2, 2015 at 10:05 PM, Tom Stellard wrote: > >>> On Mon, Mar 02, 2015 at 12:54:16PM +0100, Ma

Re: [Mesa-dev] [PATCH] mapi: actually remove unused u_thread.h

On 5 March 2015 at 14:25, Brian Paul wrote: > I thought this was in the previous commit. > --- > src/mapi/u_thread.h | 126 > > 1 file changed, 126 deletions(-) > delete mode 100644 src/mapi/u_thread.h > Nice :-) Reviewed-by: Emil Velikov -

Re: [Mesa-dev] [PATCH 7/7] mapi: remove u_thread.h

On 5 March 2015 at 14:41, Emil Velikov wrote: > On 05/03/15 02:19, Brian Paul wrote: >> Just use c11 threads directly. >> --- >> src/mapi/Makefile.sources | 3 +-- >> src/mapi/glapi/glapi.h| 1 - >> src/mapi/mapi.c | 1 - >> src/mapi/stub.c | 14 +++--- >> src/m

Re: [Mesa-dev] [PATCH 7/7] mapi: remove u_thread.h

On 05/03/15 02:19, Brian Paul wrote: > Just use c11 threads directly. > --- > src/mapi/Makefile.sources | 3 +-- > src/mapi/glapi/glapi.h| 1 - > src/mapi/mapi.c | 1 - > src/mapi/stub.c | 14 +++--- > src/mapi/u_current.c | 28 ++-- >

[Mesa-dev] [PATCH] mapi: actually remove unused u_thread.h

I thought this was in the previous commit. --- src/mapi/u_thread.h | 126 1 file changed, 126 deletions(-) delete mode 100644 src/mapi/u_thread.h diff --git a/src/mapi/u_thread.h b/src/mapi/u_thread.h deleted file mode 100644 index a3a65c3..00

Re: [Mesa-dev] [PATCH] Fix invalid extern "C" around header inclusion.

Thanks for doing this. It looks great. Reviewed-by: Jose Fonseca Feel free to push my patch or I'll push it after you push this one. Jose On 05/03/15 00:37, Mark Janes wrote: System headers may contain C++ declarations, which cannot be given C linkage. For this reason, include statements

[Mesa-dev] [Bug 89433] GCC 4.2 does not support -Wvla

https://bugs.freedesktop.org/show_bug.cgi?id=89433 --- Comment #2 from José Fonseca --- (In reply to Jonathan Gray from comment #1) > Created attachment 114016 [details] [review] > make -Wvla conditional > > How about the attached patch to make it conditional on the GCC version? Thanks for look

Re: [Mesa-dev] [PATCH 12/12] osmesa: include stdio.h

On 05/03/15 02:18, Brian Paul wrote: --- src/mesa/drivers/osmesa/osmesa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/osmesa/osmesa.c b/src/mesa/drivers/osmesa/osmesa.c index 9f1a5a8..022523e 100644 --- a/src/mesa/drivers/osmesa/osmesa.c +++ b/src/mesa/drivers/osmesa/o

[Mesa-dev] [PATCH] i965/fs: Implement SIMD16 dual source blending.

From the SNB PRM, volume 4, part 1, page 193: "The dual source render target messages only have SIMD8 forms due to maximum message length limitations. SIMD16 pixel shaders must send two of these messages to cover all of the pixels. Each message contains two colors (4 channels each) for each pix

Re: [Mesa-dev] [PATCH 7/7] mapi: remove u_thread.h

On 05/03/15 02:19, Brian Paul wrote: Just use c11 threads directly. --- src/mapi/Makefile.sources | 3 +-- src/mapi/glapi/glapi.h| 1 - src/mapi/mapi.c | 1 - src/mapi/stub.c | 14 +++--- src/mapi/u_current.c | 28 ++-- src/ma

Re: [Mesa-dev] [PATCH] clover: Enable cl_khr_fp64 for devices that support doubles v4

Tom Stellard writes: > v2: > - Report correct values for CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE > and CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE. > - Only define cl_khr_fp64 if the extension is supported. > - Remove trailing space from extension string. > - Rename device query function fro

Re: [Mesa-dev] [PATCH] i965: Split Gen4-5 BlitFramebuffer code; prefer BLT over Meta.

Reviewed-by: Jordan Justen On 2015-03-04 20:44:19, Kenneth Graunke wrote: > A while back I switched intel_blit_framebuffer to prefer Meta over the > BLT. This meant that Gen8 platforms would start using the 3D engine > for blits, just like we do on Gen6-7.5. > > However, I hadn't considered Gen

[Mesa-dev] [Bug 88885] Transform feedback uses incorrect interleaving if a previous draw did not write gl_Position

https://bugs.freedesktop.org/show_bug.cgi?id=5 Chris Forbes changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH 4/4] mesa: Check for valid PBO access in gl(Compressed)Tex(Sub)Image calls

This patch adds two types of checks to the gl(Compressed)Tex(Sub)Imgage family of functions when a pixel buffer object is bound to GL_PIXEL_UNPACK_BUFFER: - That the buffer is not mapped. - The total data size is within the boundaries of the buffer size. It does so by calling auxiliary validation

[Mesa-dev] [PATCH 3/4] mesa: Separate PBO validation checks from buffer mapping, to allow reuse

Internal PBO functions such as _mesa_map_validate_pbo_source() and _mesa_validate_pbo_compressed_teximage() perform validation and buffer mapping within the same call. This patch takes out the validation into separate functions to allow reuse of functionality by other code (i.e, gl(Compressed)Tex(

[Mesa-dev] [PATCH 2/4] mesa: Set the correct image size in _mesa_validate_pbo_access()

_mesa_validate_pbo_access() provides a generic way to check that a requested pixel transfer operation on a PBO falls within the boundaries of the buffer. It is used in various other places, and depending on the caller, some arguments are used or not. In particular, the 'clientMemSize' argument is

[Mesa-dev] [PATCH 0/4] glCompressedTex(Sub)Image(2, 3) on mapped PBOs

Hi Ian, I finally came up with 4 patches that essentially do what you proposed: First patch (1/4) removes the checks from driver code. Patch 2/4 fixes an error I hit in the PBO boundary access validation. Patch 3/4 factorizes validation code in pbo.c, which is currently mixed with buffer mappin

[Mesa-dev] [PATCH 1/4] meta: Remove error checks for texture <-> pixel-buffer transfers that don't belong in driver code

The implementation of texture <-> pixel-buffer transfers in drivers common layer includes certain error checks and argument validation that don't belong there, considering how the Mesa codebase is laid out. These are higher level validations that, if necessary, should be performed earlier (i.e, in

Re: [Mesa-dev] [PATCH] i965: Split Gen4-5 BlitFramebuffer code; prefer BLT over Meta.

On Wed, Mar 04, 2015 at 08:44:19PM -0800, Kenneth Graunke wrote: > A while back I switched intel_blit_framebuffer to prefer Meta over the > BLT. This meant that Gen8 platforms would start using the 3D engine > for blits, just like we do on Gen6-7.5. > > However, I hadn't considered Gen4-5 when ma