Re: [Mesa-dev] [PATCH] configure: ax_check_python_mako_module.m4 sets output variable

2015-03-03 Thread Samuel Iglesias Gonsálvez
On Tue, 2015-03-03 at 16:50 +0100, Kai Wasserbäch wrote: > Samuel Iglesias Gonsalvez wrote on 03.03.2015 08:56: > > This output variables gives more flexibility for future changes > > in autoconf to detect if it is needed to auto-generate files and > > check for the auto-generation dependencies. >

Re: [Mesa-dev] [PATCH 1/2] common: Correct texture init for meta pbo uploads and downloads.

2015-03-03 Thread Kenneth Graunke
On Wednesday, March 04, 2015 02:01:30 AM Emil Velikov wrote: > On 24 February 2015 at 23:20, Laura Ekstrand wrote: > > This moves the line setting immutability for the texture to after > > _mesa_initialize_texture_object so that the initializer function will not > > cancel it out. Moreover, becaus

Re: [Mesa-dev] [PATCH] gallivm: init MM = NULL to silence warning

2015-03-03 Thread Matt Turner
On Tue, Mar 3, 2015 at 8:07 PM, Brian Paul wrote: > --- > src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp > b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp > index 5210acc..e2578c

[Mesa-dev] [PATCH] gallivm: init MM = NULL to silence warning

2015-03-03 Thread Brian Paul
--- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp index 5210acc..e2578cf 100644 --- a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp +++

[Mesa-dev] [PATCH 1/7] glx: use ARRAY_SIZE from macros.h

2015-03-03 Thread Brian Paul
--- src/glx/Makefile.am | 1 + src/glx/SConscript | 1 + src/glx/glxclient.h | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/glx/Makefile.am b/src/glx/Makefile.am index 3ea1b30..6e50e09 100644 --- a/src/glx/Makefile.am +++ b/src/glx/Makefile.am @@ -35,6 +35,7 @@ endif A

[Mesa-dev] [PATCH 4/7] mesa: consolidate PUBLIC macro definition

2015-03-03 Thread Brian Paul
Define the macro in src/util/macros.h rather than in two different places. Note that USED isn't actually used anywhere at this time. --- src/gallium/include/pipe/p_compiler.h | 12 src/mesa/main/compiler.h | 20 src/util/macros.h

[Mesa-dev] [PATCH 2/7] mapi: remove unneeded ARRAY_SIZE #define

2015-03-03 Thread Brian Paul
include util/macros.h instead. --- src/mapi/Makefile.am | 1 + src/mapi/shared-glapi/SConscript | 1 + src/mapi/stub.c | 2 +- src/mapi/vgapi/SConscript| 1 + 4 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mapi/Makefile.am b/src/mapi/Makefile

[Mesa-dev] [PATCH 6/7] mapi: use util/macros.h instead of locally defined macros

2015-03-03 Thread Brian Paul
The next step is to get rid of u_compiler.h completely. --- src/mapi/glapi/SConscript | 1 + src/mapi/u_compiler.h | 22 +- 2 files changed, 2 insertions(+), 21 deletions(-) diff --git a/src/mapi/glapi/SConscript b/src/mapi/glapi/SConscript index 97ebfe6..f1e9a99 100644 -

[Mesa-dev] [PATCH 7/7] mapi: remove u_compiler.h

2015-03-03 Thread Brian Paul
Just include c99_compat.h or util/macros.h where needed. --- src/mapi/Makefile.sources | 1 - src/mapi/entry.h | 1 - src/mapi/glapi/glapi.h| 1 + src/mapi/mapi.h | 2 -- src/mapi/table.h | 4 +++- src/mapi/u_compiler.h | 7 --- src/mapi/u_current.h | 6

[Mesa-dev] [PATCH 5/7] mapi: replace INLINE with inline

2015-03-03 Thread Brian Paul
--- src/mapi/entry.c | 2 +- src/mapi/table.h | 6 +++--- src/mapi/u_compiler.h | 6 -- src/mapi/u_current.h | 4 ++-- src/mapi/u_thread.h | 10 +- 5 files changed, 11 insertions(+), 17 deletions(-) diff --git a/src/mapi/entry.c b/src/mapi/entry.c index b6e8db2..f0287

[Mesa-dev] [PATCH 3/7] st/xlib: include p_compiler.h to get PUBLIC definition

2015-03-03 Thread Brian Paul
To prevent build break with following changes. --- src/gallium/state_trackers/glx/xlib/glx_getproc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/glx/xlib/glx_getproc.c b/src/gallium/state_trackers/glx/xlib/glx_getproc.c index af7afdb..e7564ad 100644 --- a/src/ga

Re: [Mesa-dev] [PATCH] gallium/auxiliary/indices: fix start param

2015-03-03 Thread Ilia Mirkin
On Fri, Feb 27, 2015 at 1:40 PM, Marc-André Lureau wrote: > Since commit 28f3f8d, indices generator take a start parameter. However, some > index values have been left to start at 0. > > This fixes the glean/fbo test with the virgl driver. I independently arrived at an identical patch when trying

[Mesa-dev] [PATCH] i915: Fix GCC unused-variable warning in release build.

2015-03-03 Thread Vinson Lee
i915_debug_fp.c: In function ‘i915_disassemble_program’: i915_debug_fp.c:302:11: warning: unused variable ‘size’ [-Wunused-variable] GLuint size = program[0] & 0x1ff; ^ Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/i915/i915_debug_fp.c | 3 +-- 1 file changed, 1 insertion(+),

[Mesa-dev] [PATCH] glsl: Fix GCC unused-variable warning in release build.

2015-03-03 Thread Vinson Lee
CXX ast_array_index.lo ast_array_index.cpp: In function ‘void update_max_array_access(ir_rvalue*, int, YYLTYPE*, _mesa_glsl_parse_state*)’: ast_array_index.cpp:86:30: warning: unused variable ‘interface_type’ [-Wunused-variable] const glsl_type *interface_type =

Re: [Mesa-dev] [PATCH] mesa: Free memory allocated for luminance in readpixels.

2015-03-03 Thread Matt Turner
On Tue, Mar 3, 2015 at 6:02 PM, Emil Velikov wrote: > This commit does not apply cleanly for 10.4. I'm suspecting that it's > not applicable for that branch, but if you feel otherwise pleasesend > over a backport. Nope, this one shouldn't apply to 10.4. either. Whoops! ___

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: Indent break statements and add a missing one.

2015-03-03 Thread Matt Turner
On Tue, Mar 3, 2015 at 6:01 PM, Emil Velikov wrote: > Seems like you've added 10.4 to the list before pushing. Upon closer > looks it seems that this addresses Iago and others' formats rework. > The latter of which never made it in 10.4. Can you confirm if we want > this for 10.4 ? Ah, nope, the

Re: [Mesa-dev] [PATCH] mesa: Free memory allocated for luminance in readpixels.

2015-03-03 Thread Emil Velikov
On 28 February 2015 at 19:10, Matt Turner wrote: > --- > src/mesa/main/readpix.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c > index 2e4a460..ed0104c 100644 > --- a/src/mesa/main/readpix.c > +++ b/src/mesa/main/readpix.c > @@ -594,6 +

Re: [Mesa-dev] [PATCH 1/2] common: Correct texture init for meta pbo uploads and downloads.

2015-03-03 Thread Emil Velikov
On 24 February 2015 at 23:20, Laura Ekstrand wrote: > This moves the line setting immutability for the texture to after > _mesa_initialize_texture_object so that the initializer function will not > cancel it out. Moreover, because of the ARB_texture_view extension, immutable > textures must have N

Re: [Mesa-dev] [PATCH 2/2] common: Correct PBO 2D_ARRAY handling.

2015-03-03 Thread Emil Velikov
On 24 February 2015 at 23:20, Laura Ekstrand wrote: > Changes PBO uploads and downloads to use a tall (height * depth) 2D texture > for blitting. This fixes the bug where 2D_ARRAY, 3D, and CUBE_MAP_ARRAY > textures are not properly uploaded and downloaded. > > Removes the option to use a 2D ARRAY

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: Indent break statements and add a missing one.

2015-03-03 Thread Emil Velikov
On 28 February 2015 at 19:02, Matt Turner wrote: > Always indenting break statements makes spotting missing ones easier. > > Cc: 10.5 > --- > src/mesa/main/pack.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/src/mesa/main/pack.c b/src/mesa/main/pack.c > in

Re: [Mesa-dev] nesa-10.4.4: gallivm/lp_bld_misc.cpp:503:38: error: no viable conversion from 'ShaderMemoryManager *' to 'std::unique_ptr'

2015-03-03 Thread Emil Velikov
On 27 February 2015 at 23:28, Sedat Dilek wrote: > On Mon, Feb 9, 2015 at 6:30 PM, Emil Velikov wrote: >> On 07/02/15 21:44, Sedat Dilek wrote: >>> Hi, >>> >>> I was building mesa v10.4.4 with my llvm-toolchain v3.6.0rc2. >>> >>> My build breaks like this... >>> >>> ... >>> >>> Please cherry-pick

Re: [Mesa-dev] [PATCH] i965/fs: Use unsigned for CS/VS atomics pixel mask immediate data

2015-03-03 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/gen6 gs: Convert brw_imm_ud/brw_imm_d to src_reg

2015-03-03 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/6] main: Add utility function _mesa_lookup_bufferobj_err.

2015-03-03 Thread Laura Ekstrand
I also need it in teximage.c for Texture Buffer objects. On Tue, Mar 3, 2015 at 5:24 PM, Fredrik Höglund wrote: > On Wednesday 04 March 2015, Anuj Phogat wrote: > > On Fri, Feb 27, 2015 at 4:07 PM, Laura Ekstrand > wrote: > > > --- > > > src/mesa/main/bufferobj.c | 19 +++ > > >

[Mesa-dev] [PATCH 26/38] main: Add entry points for InvalidateNamedFramebuffer[Sub]Data.

2015-03-03 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 16 ++ src/mesa/main/fbobject.c | 67 ++ src/mesa/main/fbobject.h | 12 + src/mesa/main/tests/dispatch_sanity.cpp| 2 + 4 files changed, 97 insertions(+) diff

[Mesa-dev] [PATCH 28/38] main: Fake entry point for glClearNamedFramebufferuiv.

2015-03-03 Thread Laura Ekstrand
Mesa's ClearBuffer framework is very complicated and thoroughly married to the object binding model. Moreover, the OpenGL spec for ClearBuffer is also very complicated. At some point, we should implement buffer clearing for arbitrary framebuffer objects, but for now, we will just wrap ClearBuffer

[Mesa-dev] [PATCH 23/38] main: _mesa_blit_framebuffer updates its arbitrary framebuffers.

2015-03-03 Thread Laura Ekstrand
Previously, we used _mesa_update_state to update the currently bound framebuffers prior to performing a blit. Now that _mesa_blit_framebuffer uses arbitrary framebuffers, _mesa_update_state is not specific enough. --- src/mesa/main/blit.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletion

[Mesa-dev] [PATCH 04/38] main: Rename framebuffer renderbuffer software fallback.

2015-03-03 Thread Laura Ekstrand
Rename _mesa_framebuffer_renderbuffer to _mesa_FramebufferRenderbuffer_sw in preparation for adding the ARB_direct_state_access backend function for FramebufferRenderbuffer and NamedFramebufferRenderbuffer to share. --- src/mesa/drivers/common/driverfuncs.c | 2 +- src/mesa/drivers/dri/i915/i

[Mesa-dev] [PATCH 05/38] main: Add entry point for NamedFramebufferRenderbuffer.

2015-03-03 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 ++ src/mesa/main/fbobject.c | 139 + src/mesa/main/fbobject.h | 12 +++ src/mesa/main/tests/dispatch_sanity.cpp| 1 + 4 files changed, 115 insertions(+), 44 dele

[Mesa-dev] [PATCH 34/38] main: Add entry point for NamedFramebufferDrawBuffer.

2015-03-03 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 5 + src/mesa/main/buffers.c| 18 ++ src/mesa/main/buffers.h| 3 +++ src/mesa/main/tests/dispatch_sanity.cpp| 1 + 4 files changed, 27 insertions(+) diff --git a/src

[Mesa-dev] [PATCH 32/38] main: Refactor _mesa_drawbuffers.

2015-03-03 Thread Laura Ekstrand
--- src/mesa/drivers/common/meta.c | 3 ++- src/mesa/main/buffers.c| 25 - src/mesa/main/buffers.h| 4 +++- src/mesa/main/context.c| 3 ++- src/mesa/main/framebuffer.c| 2 +- 5 files changed, 20 insertions(+), 17 deletions(-) diff --git a/sr

[Mesa-dev] [PATCH 21/38] main: Refactor _mesa_update_draw_buffer_bounds.

2015-03-03 Thread Laura Ekstrand
--- src/mesa/drivers/dri/i915/i830_vtbl.c | 2 +- src/mesa/drivers/dri/i915/i915_vtbl.c | 2 +- src/mesa/drivers/dri/r200/r200_state.c | 2 +- src/mesa/drivers/dri/radeon/radeon_common.c | 2 +- src/mesa/drivers/dri/radeon/radeon_state.c | 2 +- src/mesa/main/framebuffer.c

[Mesa-dev] [PATCH 36/38] main: Add entry point for NamedFramebufferReadBuffer.

2015-03-03 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 5 + src/mesa/main/buffers.c| 18 ++ src/mesa/main/buffers.h| 3 +++ src/mesa/main/tests/dispatch_sanity.cpp| 1 + 4 files changed, 27 insertions(+) diff --git a/src

[Mesa-dev] [PATCH 22/38] main: Add entry point for BlitNamedFramebuffer.

2015-03-03 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 15 src/mesa/main/blit.c | 50 ++ src/mesa/main/blit.h | 6 src/mesa/main/tests/dispatch_sanity.cpp| 1 + 4 files changed, 72 insertions(+) diff

[Mesa-dev] [PATCH 38/38] main: Add entry point for NamedFramebufferDrawBuffers.

2015-03-03 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 ++ src/mesa/main/buffers.c| 19 +++ src/mesa/main/buffers.h| 4 src/mesa/main/tests/dispatch_sanity.cpp| 1 + 4 files changed, 30 insertions(+) diff --git a/

[Mesa-dev] [PATCH 29/38] main: Fake entry point for glClearNamedFramebufferfv.

2015-03-03 Thread Laura Ekstrand
Mesa's ClearBuffer framework is very complicated and thoroughly married to the object binding model. Moreover, the OpenGL spec for ClearBuffer is also very complicated. At some point, we should implement buffer clearing for arbitrary framebuffer objects, but for now, we will just wrap ClearBuffer

[Mesa-dev] [PATCH 15/38] main: Fix whitespace in blit.c

2015-03-03 Thread Laura Ekstrand
--- src/mesa/main/blit.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c index 2898723..899dd45 100644 --- a/src/mesa/main/blit.c +++ b/src/mesa/main/blit.c @@ -305,7 +305,7 @@ _mesa_BlitFramebuf

[Mesa-dev] [PATCH 19/38] main: Refactor _mesa_[update|get]_clamp_fragment_color.

2015-03-03 Thread Laura Ekstrand
--- src/mesa/main/blend.c | 19 ++- src/mesa/main/blend.h | 6 -- src/mesa/main/framebuffer.c | 2 +- src/mesa/main/get.c | 8 src/mesa/main/texenv.c| 2 +- src/mesa/main/texparam.c | 2 +- src/mesa/

[Mesa-dev] [PATCH 24/38] main: Refactor invalidate_framebuffer_storage.

2015-03-03 Thread Laura Ekstrand
--- src/mesa/main/fbobject.c | 38 +++--- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 467a8cd..7a1684c 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -3468,19 +346

[Mesa-dev] [PATCH 37/38] main: Refactor DrawBuffers.

2015-03-03 Thread Laura Ekstrand
This could have added a new DD table entry for DrawBuffers that takes an arbitrary draw buffer, but, after looking at the existing DD functions, Kenneth Graunke recommended that we just skip calling the DD functions in the case of ARB_direct_state_access. The DD implementations for DrawBuffer(s) h

[Mesa-dev] [PATCH 03/38] main: Add utility function _mesa_lookup_renderbuffer_err.

2015-03-03 Thread Laura Ekstrand
--- src/mesa/main/fbobject.c | 18 ++ src/mesa/main/fbobject.h | 4 2 files changed, 22 insertions(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index b361967..8bc7ec7 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -119,6 +119,2

[Mesa-dev] [PATCH 14/38] main: Add entry point GetNamedFramebufferAttachmentParameteriv.

2015-03-03 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 ++ src/mesa/main/fbobject.c | 131 - src/mesa/main/fbobject.h | 10 ++ src/mesa/main/tests/dispatch_sanity.cpp| 1 + 4 files changed, 103 insertions(+), 46 delet

[Mesa-dev] [PATCH 01/38] main: Add utility function _mesa_lookup_framebuffer_err.

2015-03-03 Thread Laura Ekstrand
--- src/mesa/main/fbobject.c | 18 ++ src/mesa/main/fbobject.h | 4 2 files changed, 22 insertions(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index f8d0d92..8c2eb25 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -136,6 +136,2

[Mesa-dev] [PATCH 06/38] main: Removed tabs in framebuffer_texture.

2015-03-03 Thread Laura Ekstrand
--- src/mesa/main/fbobject.c | 49 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 3895328..5062033 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -25

[Mesa-dev] [PATCH 08/38] main: Refactor get_texture_for_framebuffer.

2015-03-03 Thread Laura Ekstrand
This moves a few blocks around so that the control flow is more obvious. If the texture is 0, just return true at the beginning of the function. Likewise, if the texObj is NULL, return true at the beginning of the funciton as well. --- src/mesa/main/fbobject.c | 43 +--

[Mesa-dev] [PATCH 27/38] main: Fake entry point for glClearNamedFramebufferiv.

2015-03-03 Thread Laura Ekstrand
Mesa's ClearBuffer framework is very complicated and thoroughly married to the object binding model. Moreover, the OpenGL spec for ClearBuffer is also very complicated. At some point, we should implement buffer clearing for arbitrary framebuffer objects, but for now, we will just wrap ClearBuffer

[Mesa-dev] [PATCH 09/38] main: Fix indentation in get_texture_for_framebuffer.

2015-03-03 Thread Laura Ekstrand
--- src/mesa/main/fbobject.c | 148 +++ 1 file changed, 74 insertions(+), 74 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index f86e1a0..2ac9903 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -24

[Mesa-dev] [PATCH 20/38] main: Refactor _mesa_get_clamp_read_color.

2015-03-03 Thread Laura Ekstrand
This wasn't neccessary for ARB_direct_state_access, but felt like a good idea for the sake of completeness. --- src/mesa/main/blend.c | 5 +++-- src/mesa/main/blend.h | 3 ++- src/mesa/main/readpix.c | 4 ++-- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/blend.c

[Mesa-dev] [PATCH 16/38] main: Refactor glBlitFramebuffer.

2015-03-03 Thread Laura Ekstrand
--- src/mesa/main/blit.c | 119 --- src/mesa/main/blit.h | 7 +++ 2 files changed, 73 insertions(+), 53 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c index 899dd45..b6d6d75 100644 --- a/src/mesa/main/blit.c +++ b/src/mesa/m

[Mesa-dev] [PATCH 13/38] main: Add entry point for CheckNamedFramebufferStatus.

2015-03-03 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 +++ src/mesa/main/fbobject.c | 73 -- src/mesa/main/fbobject.h | 7 +++ src/mesa/main/tests/dispatch_sanity.cpp| 1 + 4 files changed, 72 insertions(+), 15 deletio

[Mesa-dev] [PATCH 07/38] main: Split framebuffer_texture.

2015-03-03 Thread Laura Ekstrand
Split apart utility function framebuffer_texture to better prepare for implementing NamedFramebufferTexture and NamedFramebufferTextureLayer. This should also pave the way for some future cleanup work. --- src/mesa/main/fbobject.c | 270 ++- src/mesa/ma

[Mesa-dev] [PATCH 35/38] main: Refactor _mesa_ReadBuffer.

2015-03-03 Thread Laura Ekstrand
This could have added a new DD table entry for ReadBuffer that takes an arbitrary read buffer, but, after looking at the existing DD functions, Kenneth Graunke recommended that we just skip calling the DD functions in the case of ARB_direct_state_access. The DD implementations for ReadBuffer have

[Mesa-dev] [PATCH 02/38] main: Add glCreateFramebuffers.

2015-03-03 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 + src/mesa/main/fbobject.c | 40 ++ src/mesa/main/fbobject.h | 3 ++ src/mesa/main/tests/dispatch_sanity.cpp| 1 + 4 files changed, 46 insertions(+), 5 deletio

[Mesa-dev] [PATCH 33/38] main: Refactor _mesa_DrawBuffer.

2015-03-03 Thread Laura Ekstrand
This could have added a new DD table entry for DrawBuffer that takes an arbitrary draw buffer, but, after looking at the existing DD functions, Kenneth Graunke recommended that we just skip calling the DD functions in the case of ARB_direct_state_access. The DD implementations for DrawBuffer(s) ha

[Mesa-dev] [PATCH 31/38] main: Add stubs for [Get]NamedFramebufferParameteri[v].

2015-03-03 Thread Laura Ekstrand
The ARB_direct_state_access specification says (as of 2015.02.05): "Interactions with OpenGL 4.3 or ARB_framebuffer_no_attachments If neither OpenGL 4.3 nor ARB_framebuffer_no_attachments are supported, ignore the support for NamedFramebufferParameteri and GetNamedFramebuff

[Mesa-dev] [PATCH 25/38] main: Complete error conditions for glInvalidate*Framebuffer.

2015-03-03 Thread Laura Ekstrand
--- src/mesa/main/fbobject.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 7a1684c..0b4cabe 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -3476,12 +3476,29 @@ invalidate_f

[Mesa-dev] [PATCH 18/38] main: Refactor _mesa_[update|get]_clamp_vertex_color.

2015-03-03 Thread Laura Ekstrand
--- src/mesa/main/blend.c | 13 - src/mesa/main/blend.h | 7 +-- src/mesa/main/framebuffer.c | 2 +- 3 files changed, 14 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index 774fc88..ee76b47 100644 --- a/src/mesa/main/blend.c

[Mesa-dev] [PATCH 12/38] main: Fix indents in former get_texture_for_framebuffer functions.

2015-03-03 Thread Laura Ekstrand
--- src/mesa/main/fbobject.c | 82 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 4df0b6b..1435576 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -24

[Mesa-dev] [PATCH 11/38] main: Major refactor of get_texture_for_framebuffer.

2015-03-03 Thread Laura Ekstrand
This splits off the (still) rather large chunk that is get_texture_for_framebuffer into lots of smaller functions specialized to service the wide variety of unique needs of *FramebufferTexture* entry points. The result is much cleaner because, rather than having a pile of branches and confusing con

[Mesa-dev] [PATCH 30/38] main: Fake entry point for glClearNamedFramebufferfi.

2015-03-03 Thread Laura Ekstrand
Mesa's ClearBuffer framework is very complicated and thoroughly married to the object binding model. Moreover, the OpenGL spec for ClearBuffer is also very complicated. At some point, we should implement buffer clearing for arbitrary framebuffer objects, but for now, we will just wrap ClearBuffer

[Mesa-dev] [PATCH 10/38] main: Add entry points for glNamedFramebufferTexture[Layer].

2015-03-03 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 15 +++ src/mesa/main/fbobject.c | 62 ++ src/mesa/main/fbobject.h | 8 src/mesa/main/tests/dispatch_sanity.cpp| 2 + 4 files changed, 87 insertions(+) diff

[Mesa-dev] [PATCH 17/38] main: Refactor _mesa_update_framebuffer.

2015-03-03 Thread Laura Ekstrand
_mesa_update_framebuffer now operates on arbitrary read and draw framebuffers. This allows BlitNamedFramebuffer to update the state of its arbitrary read and draw framebuffers. --- src/mesa/drivers/dri/i915/i830_vtbl.c | 2 +- src/mesa/drivers/dri/i915/i915_vtbl.c | 2 +- src/mesa/dr

Re: [Mesa-dev] [PATCH] i965/gen6 gs: Convert brw_imm_ud/brw_imm_d to src_reg

2015-03-03 Thread Chris Forbes
Reviewed-by: Chris Forbes On Wed, Mar 4, 2015 at 2:25 PM, Jordan Justen wrote: > Same idea as this patch, only for gen6_gs_visitor: > > commit 49a938a265f5959c9b558995cc658f80acb6eb18 > Author: Jordan Justen > Date: Fri Feb 20 12:12:25 2015 -0800 > i965/fs: Use fs_reg for CS/VS atomics pi

[Mesa-dev] [PATCH] i965/gen6 gs: Convert brw_imm_ud/brw_imm_d to src_reg

2015-03-03 Thread Jordan Justen
Same idea as this patch, only for gen6_gs_visitor: commit 49a938a265f5959c9b558995cc658f80acb6eb18 Author: Jordan Justen Date: Fri Feb 20 12:12:25 2015 -0800 i965/fs: Use fs_reg for CS/VS atomics pixel mask immediate data Suggested-by: Matt Turner Signed-off-by: Jordan Justen --- src/me

[Mesa-dev] [PATCH] i965/fs: Use unsigned for CS/VS atomics pixel mask immediate data

2015-03-03 Thread Jordan Justen
brw_imm_ud(0x) should have been converted to fs_reg(0xu) to make sure the uint32_t fs_reg constructor was matched. commit 49a938a265f5959c9b558995cc658f80acb6eb18 Author: Jordan Justen Date: Fri Feb 20 12:12:25 2015 -0800 i965/fs: Use fs_reg for CS/VS atomics pixel mask immediate da

Re: [Mesa-dev] [PATCH 4/6] main: Add utility function _mesa_lookup_bufferobj_err.

2015-03-03 Thread Fredrik Höglund
On Wednesday 04 March 2015, Anuj Phogat wrote: > On Fri, Feb 27, 2015 at 4:07 PM, Laura Ekstrand wrote: > > --- > > src/mesa/main/bufferobj.c | 19 +++ > > src/mesa/main/bufferobj.h | 4 > > 2 files changed, 23 insertions(+) > > > > diff --git a/src/mesa/main/bufferobj.c b/s

Re: [Mesa-dev] [PATCH 4/6] main: Add utility function _mesa_lookup_bufferobj_err.

2015-03-03 Thread Anuj Phogat
On Fri, Feb 27, 2015 at 4:07 PM, Laura Ekstrand wrote: > --- > src/mesa/main/bufferobj.c | 19 +++ > src/mesa/main/bufferobj.h | 4 > 2 files changed, 23 insertions(+) > > diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c > index f026fc3..617242b 100644 > --

Re: [Mesa-dev] [PATCH 3/6] main: Checking for cube completeness in GetCompressedTextureImage.

2015-03-03 Thread Anuj Phogat
On Fri, Feb 27, 2015 at 4:07 PM, Laura Ekstrand wrote: > --- > src/mesa/main/texgetimage.c | 51 > - > 1 file changed, 50 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c > index 24df5b6..327a397 1

Re: [Mesa-dev] RFC: Prune stale components

2015-03-03 Thread Emil Velikov
On 03/03/15 22:04, Jose Fonseca wrote: > On 03/03/15 18:39, Emil Velikov wrote: >> On 3 March 2015 at 17:16, Jose Fonseca wrote: >> ... >>> >>> I've prototyped this in >>> >>> >>> https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.freedesktop.org_-7Ejrfonseca_mesa_log_-3Fh-3Dremove-2Dst-2

Re: [Mesa-dev] [PATCH 2/6] main: Add TEXTURE_CUBE_MAP support for glCompressedTextureSubImage3D.

2015-03-03 Thread Anuj Phogat
On Fri, Feb 27, 2015 at 4:07 PM, Laura Ekstrand wrote: > --- > src/mesa/main/teximage.c | 204 > --- > src/mesa/main/teximage.h | 3 +- > 2 files changed, 179 insertions(+), 28 deletions(-) > > diff --git a/src/mesa/main/teximage.c b/src/mesa/main/te

Re: [Mesa-dev] [PATCH 1/2] r300g: Use PATH_MAX instead of limiting ourselves to 100 chars.

2015-03-03 Thread Tom Stellard
On Tue, Mar 03, 2015 at 04:12:56PM -0800, Matt Turner wrote: > When built with Gentoo's package manager, the Mesa source directory > exists seven directories deep. The path to the .test file is too long > and is silently truncated, leading to a crash. Just use PATH_MAX. > > Cc: 10.4, 10.5 > Bugzi

Re: [Mesa-dev] [PATCH 1/6] main: Check for NULL in texturesubimage.

2015-03-03 Thread Anuj Phogat
On Tue, Mar 3, 2015 at 4:15 PM, Anuj Phogat wrote: > On Fri, Feb 27, 2015 at 4:07 PM, Laura Ekstrand wrote: >> --- >> src/mesa/main/teximage.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c >> index 6e45cc9..dfad9ed 100644 >> ---

Re: [Mesa-dev] [PATCH 1/6] main: Check for NULL in texturesubimage.

2015-03-03 Thread Anuj Phogat
On Fri, Feb 27, 2015 at 4:07 PM, Laura Ekstrand wrote: > --- > src/mesa/main/teximage.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c > index 6e45cc9..dfad9ed 100644 > --- a/src/mesa/main/teximage.c > +++ b/src/mesa/main/teximage.c

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Consider cmod when propagating to inst with different type.

2015-03-03 Thread Kenneth Graunke
On Friday, February 27, 2015 11:34:06 AM Matt Turner wrote: > We can safely propagate the conditional mod to an instruction with a > different type if the conditional mod does not involve comparing for > equality with zero (or probably NaN, but ignore that for now). > > This is because -0.0 and +0

[Mesa-dev] [PATCH 1/2] r300g: Use PATH_MAX instead of limiting ourselves to 100 chars.

2015-03-03 Thread Matt Turner
When built with Gentoo's package manager, the Mesa source directory exists seven directories deep. The path to the .test file is too long and is silently truncated, leading to a crash. Just use PATH_MAX. Cc: 10.4, 10.5 Bugzilla: https://bugs.gentoo.org/show_bug.cgi?id=540970 --- src/gallium/driv

[Mesa-dev] [PATCH 2/2] r300g: Check return value of snprintf().

2015-03-03 Thread Matt Turner
Would have at least prevented the crash the previous patch fixed. Cc: 10.4, 10.5 Bugzilla: https://bugs.gentoo.org/show_bug.cgi?id=540970 --- src/gallium/drivers/r300/compiler/tests/rc_test_helpers.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r3

[Mesa-dev] [PATCH] [RFC] egl: propose simple EGL_MESA_image_dma_buf_export v2.3

2015-03-03 Thread Dave Airlie
From: Dave Airlie At the moment to get an EGL image to a dma-buf file descriptor, you have to use EGL_MESA_drm_image, and then use libdrm to convert this to a file descriptor. This extension just provides an API modelled on EGL_MESA_drm_image, to return a dma-buf file descriptor. v2: update spe

Re: [Mesa-dev] egl dma-buf export extension again

2015-03-03 Thread Kristian Høgsberg
On Tue, Mar 3, 2015 at 10:43 AM, Chad Versace wrote: > On 03/02/2015 09:36 PM, Dave Airlie wrote: >> On 3 March 2015 at 13:57, Dave Airlie wrote: >>> >>> Okay I've revised this to add some more info to the interface, >>> essentially I need to get the fourcc back so I can later pass >>> it across

Re: [Mesa-dev] [PATCH] [RFC] egl: propose simple EGL_MESA_image_dma_buf_export v2.2

2015-03-03 Thread Dave Airlie
On 4 March 2015 at 05:23, Chad Versace wrote: > On 03/03/2015 11:13 AM, Dave Airlie wrote: >> On 4 March 2015 at 05:06, Chad Versace wrote: >>> On 03/03/2015 11:01 AM, Daniel Stone wrote: Hi, On 3 March 2015 at 18:40, Chad Versace wrote: > On 03/03/2015 12:13 AM, Daniel Stone

Re: [Mesa-dev] RFC: Prune stale components

2015-03-03 Thread Jose Fonseca
On 03/03/15 18:39, Emil Velikov wrote: On 3 March 2015 at 17:16, Jose Fonseca wrote: ... I've prototyped this in https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.freedesktop.org_-7Ejrfonseca_mesa_log_-3Fh-3Dremove-2Dst-2Degl&d=AwIBaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r

Re: [Mesa-dev] replace __FUNCTION__ with __func__ task

2015-03-03 Thread Jose Fonseca
On 03/03/15 20:56, Jan Vesely wrote: On Tue, 2015-03-03 at 10:07 -0700, Brian Paul wrote: On 03/03/2015 09:56 AM, Jose Fonseca wrote: On 03/03/15 15:57, Brian Paul wrote: We're using both of these in Mesa/gallium. It would be nice to consistently just use C99's __func__ everywhere. This woul

Re: [Mesa-dev] [PATCH] main/base_tex_format: Properly handle STENCIL_INDEX1/4/16

2015-03-03 Thread Ilia Mirkin
On Tue, Mar 3, 2015 at 4:31 PM, Jason Ekstrand wrote: > > > On Tue, Mar 3, 2015 at 1:00 PM, Ilia Mirkin wrote: >> >> On Tue, Mar 3, 2015 at 3:58 PM, Kenneth Graunke >> wrote: >> > On Monday, March 02, 2015 02:33:31 PM Ilia Mirkin wrote: >> >> On Mon, Mar 2, 2015 at 2:32 PM, Jason Ekstrand >> >>

Re: [Mesa-dev] [PATCH] main/base_tex_format: Properly handle STENCIL_INDEX1/4/16

2015-03-03 Thread Jason Ekstrand
On Tue, Mar 3, 2015 at 1:00 PM, Ilia Mirkin wrote: > On Tue, Mar 3, 2015 at 3:58 PM, Kenneth Graunke > wrote: > > On Monday, March 02, 2015 02:33:31 PM Ilia Mirkin wrote: > >> On Mon, Mar 2, 2015 at 2:32 PM, Jason Ekstrand > wrote: > >> > > >> > > >> > On Mon, Mar 2, 2015 at 11:18 AM, Ilia Mirk

Re: [Mesa-dev] [PATCH] main/base_tex_format: Properly handle STENCIL_INDEX1/4/16

2015-03-03 Thread Ilia Mirkin
On Tue, Mar 3, 2015 at 3:58 PM, Kenneth Graunke wrote: > On Monday, March 02, 2015 02:33:31 PM Ilia Mirkin wrote: >> On Mon, Mar 2, 2015 at 2:32 PM, Jason Ekstrand wrote: >> > >> > >> > On Mon, Mar 2, 2015 at 11:18 AM, Ilia Mirkin wrote: >> >> >> >> Hmmm... I was just looking at this code in con

Re: [Mesa-dev] [PATCH] main/base_tex_format: Properly handle STENCIL_INDEX1/4/16

2015-03-03 Thread Kenneth Graunke
On Monday, March 02, 2015 02:33:31 PM Ilia Mirkin wrote: > On Mon, Mar 2, 2015 at 2:32 PM, Jason Ekstrand wrote: > > > > > > On Mon, Mar 2, 2015 at 11:18 AM, Ilia Mirkin wrote: > >> > >> Hmmm... I was just looking at this code in connection to attepmting to > >> enable ARB_texture_stencil8, and i

Re: [Mesa-dev] replace __FUNCTION__ with __func__ task

2015-03-03 Thread Jan Vesely
On Tue, 2015-03-03 at 10:07 -0700, Brian Paul wrote: > On 03/03/2015 09:56 AM, Jose Fonseca wrote: > > On 03/03/15 15:57, Brian Paul wrote: > >> We're using both of these in Mesa/gallium. It would be nice to > >> consistently just use C99's __func__ everywhere. This would be any easy > >> task fo

[Mesa-dev] [GSoC] Improved application of GLSL complier optimizations

2015-03-03 Thread Alexander Mezin
Hello. I plan to participate in GSoC this year as a student. And I've found a project idea which I like very much on X.Org's ideas page. It's called "Improved application of GLSL compiler optimizations". For me, it looks mostly like an optimization problem in mathematical meaning. Benchmark could

Re: [Mesa-dev] [PATCH] [RFC] egl: propose simple EGL_MESA_image_dma_buf_export v2.2

2015-03-03 Thread Chad Versace
On 03/03/2015 11:13 AM, Dave Airlie wrote: > On 4 March 2015 at 05:06, Chad Versace wrote: >> On 03/03/2015 11:01 AM, Daniel Stone wrote: >>> Hi, >>> >>> On 3 March 2015 at 18:40, Chad Versace wrote: On 03/03/2015 12:13 AM, Daniel Stone wrote: > On Tuesday, March 3, 2015, Dave Airlie >>>

Re: [Mesa-dev] [PATCH] [RFC] egl: propose simple EGL_MESA_image_dma_buf_export v2.2

2015-03-03 Thread Dave Airlie
On 4 March 2015 at 05:06, Chad Versace wrote: > On 03/03/2015 11:01 AM, Daniel Stone wrote: >> Hi, >> >> On 3 March 2015 at 18:40, Chad Versace wrote: >>> On 03/03/2015 12:13 AM, Daniel Stone wrote: On Tuesday, March 3, 2015, Dave Airlie >>> > wrote: +E

Re: [Mesa-dev] [PATCH 2/2] egl: implement EGL_MESA_transparent_alpha for x11 and wayland

2015-03-03 Thread Daniel Stone
Hi, On 3 March 2015 at 18:56, Jason Ekstrand wrote: > On Tue, Mar 3, 2015 at 10:07 AM, Chad Versace > wrote: >> On 02/23/2015 06:32 AM, Jonny Lamb wrote: >> > + static const EGLint argb_attrs[] = { >> > + EGL_TRANSPARENT_TYPE, EGL_TRANSPARENT_ALPHA_MESA, >> > + EGL_NONE >> > + };

Re: [Mesa-dev] [PATCH] [RFC] egl: propose simple EGL_MESA_image_dma_buf_export v2.2

2015-03-03 Thread Chad Versace
On 03/03/2015 11:01 AM, Daniel Stone wrote: > Hi, > > On 3 March 2015 at 18:40, Chad Versace wrote: >> On 03/03/2015 12:13 AM, Daniel Stone wrote: >>> On Tuesday, March 3, 2015, Dave Airlie >> > wrote: >>> +EGLBoolean eglExportDMABUFImageQueryMESA(EGLDisplay dpy,

Re: [Mesa-dev] [PATCH] [RFC] egl: propose simple EGL_MESA_image_dma_buf_export v2.2

2015-03-03 Thread Daniel Stone
Hi, On 3 March 2015 at 18:40, Chad Versace wrote: > On 03/03/2015 12:13 AM, Daniel Stone wrote: >> On Tuesday, March 3, 2015, Dave Airlie > > wrote: >> +EGLBoolean eglExportDMABUFImageQueryMESA(EGLDisplay dpy, >> + EGLImageKHR

Re: [Mesa-dev] [PATCH] intel: fix EGLImage renderbuffer _BaseFormat

2015-03-03 Thread Chad Versace
On 02/19/2015 03:09 PM, Frank Henigman wrote: > Correctly set _BaseFormat field when creating a gl_renderbuffer > with EGLImage storage. > > Signed-off-by: Frank Henigman > Reviewed-by: Stéphane Marchesin > --- > src/mesa/drivers/dri/i915/intel_fbo.c | 3 +-- > src/mesa/drivers/dri/i965/intel_f

Re: [Mesa-dev] [PATCH 2/2] egl: implement EGL_MESA_transparent_alpha for x11 and wayland

2015-03-03 Thread Jason Ekstrand
On Tue, Mar 3, 2015 at 10:07 AM, Chad Versace wrote: > On 02/23/2015 06:32 AM, Jonny Lamb wrote: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67676 > > --- > > include/EGL/eglmesaext.h| 5 + > > src/egl/drivers/dri2/platform_wayland.c | 9 +++-- > > src/eg

Re: [Mesa-dev] egl dma-buf export extension again

2015-03-03 Thread Chad Versace
On 03/02/2015 09:36 PM, Dave Airlie wrote: > On 3 March 2015 at 13:57, Dave Airlie wrote: >> >> Okay I've revised this to add some more info to the interface, >> essentially I need to get the fourcc back so I can later pass >> it across the "wire" to the EGL_EXT_image_dma_buf_import, also >> the n

Re: [Mesa-dev] [PATCH] [RFC] egl: propose simple EGL_MESA_image_dma_buf_export v2.2

2015-03-03 Thread Chad Versace
On 03/03/2015 12:13 AM, Daniel Stone wrote: > Hi, > > On Tuesday, March 3, 2015, Dave Airlie > wrote: > > +EGLBoolean eglExportDMABUFImageQueryMESA(EGLDisplay dpy, > + EGLImageKHR image, > +

Re: [Mesa-dev] RFC: Prune stale components

2015-03-03 Thread Emil Velikov
On 3 March 2015 at 17:16, Jose Fonseca wrote: ... > > I've prototyped this in > > http://cgit.freedesktop.org/~jrfonseca/mesa/log/?h=remove-st-egl > > The changes are massive, so I'm not sure it's even worth spamming the list > with them. > > Could you please give a look and let me know if there

Re: [Mesa-dev] [PATCH] egl: Report correct GBM formats

2015-03-03 Thread Chad Versace
On 03/02/2015 06:23 AM, Tom Stellard wrote: > From: Daniel Stone > > This fixes almost all piglit regressions when running with > PIGLIT_PLATFORM=gbm > > Tom Stellard: > - Fix ARGB2101010 format > > Cc: "10.4 10.5" Reviewed-by: Chad Versace signature.asc Description: OpenPGP digital si

Re: [Mesa-dev] [PATCH] i965: Fix uint64_t overflow in intel_client_wait_sync()

2015-03-03 Thread Matt Turner
On Mon, Mar 2, 2015 at 4:27 PM, Kristian Høgsberg wrote: > DRM_IOCTL_I915_GEM_WAIT takes an int64_t for the timeout value but > GL_ARB_sync takes an uint64_t. Further, the ioctl used to wait > indefinitely when passed a negative timeout, but it's been broken and > now returns immediately in that

Re: [Mesa-dev] [PATCH 1/2] egl: add EGL_MESA_transparent_alpha extension

2015-03-03 Thread Chad Versace
On 02/23/2015 06:32 AM, Jonny Lamb wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67676 > Reviewed-by: Chad Versace > --- > docs/specs/EGL_MESA_transparent_alpha.txt | 120 > ++ > 1 file changed, 120 insertions(+) > create mode 100644 docs/specs/EGL_

  1   2   >