Re: [Mesa-dev] [PATCH] i965/gs: Check newly-generated GS-out VUE map against correct stage

On Fri, Feb 27, 2015 at 11:03 PM, Chris Forbes wrote: > Previously, we compared our new GS-out VUE map to the existing *VS*-out > VUE map, which is bogus. > > This would mostly manifest as redundant dirty flagging where the GS is > in use but the VS and GS output layouts differ; but there is a sca

Re: [Mesa-dev] nesa-10.4.4: gallivm/lp_bld_misc.cpp:503:38: error: no viable conversion from 'ShaderMemoryManager *' to 'std::unique_ptr'

On Mon, Feb 9, 2015 at 6:30 PM, Emil Velikov wrote: > On 07/02/15 21:44, Sedat Dilek wrote: >> Hi, >> >> I was building mesa v10.4.4 with my llvm-toolchain v3.6.0rc2. >> >> My build breaks like this... >> >> ... >> >> Please cherry-pick... >> >> commit ef7e0b39a24966526b102643523feac765771842 >> "

[Mesa-dev] [PATCH] i965/gs: Check newly-generated GS-out VUE map against correct stage

Previously, we compared our new GS-out VUE map to the existing *VS*-out VUE map, which is bogus. This would mostly manifest as redundant dirty flagging where the GS is in use but the VS and GS output layouts differ; but there is a scary case where we would fail to flag a GS-out layout change if it

Re: [Mesa-dev] [PATCH] i965/skl: Ignore the vertical alignment for the qpitch of 1D textures

On Feb 27, 2015 9:17 PM, "Ben Widawsky" wrote: > > On Fri, Feb 27, 2015 at 07:24:16PM +, Neil Roberts wrote: > > The vertical alignment is ignored in the surface state for 1D array > > textures so we can tightly pack them. > > > > I've run this through Piglit and it doesn't cause any regressio

Re: [Mesa-dev] [PATCH] i965/skl: Ignore the vertical alignment for the qpitch of 1D textures

On Fri, Feb 27, 2015 at 07:24:16PM +, Neil Roberts wrote: > The vertical alignment is ignored in the surface state for 1D array > textures so we can tightly pack them. > > I've run this through Piglit and it doesn't cause any regressions. > > (This should probably be squashed into the patch e

Re: [Mesa-dev] [PATCH 3/6] i965/fs: Silence unused parameter warning

On Fri, Feb 27, 2015 at 6:50 PM, Ian Romanick wrote: > From: Ian Romanick > > I don't this opt_cmod_propagation_local ever used the fs_visitor. I think I was probably using liveness information at some WIP stage. Reviewed-by: Matt Turner ___ mesa-dev

Re: [Mesa-dev] [PATCH] main/base_tex_format: Properly handle STENCIL_INDEX1/4/16

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] Testing the link_uniform_block_active_visitor code

Hi all, I'm in the process of extending this code to support arrays of arrays but I'm struggling to find piglit tests that exercise it. Does anyone know if there are tests designed to test this code path specifically? Thanks, Tim ___ mesa-dev mailing l

Re: [Mesa-dev] [PATCH 1/7] mesa: move ONE_DIV_SQRT_LN2 to prog_statevars.c

Patches 1 through 5 seem innocuous enough and are Reviewed-by: Ian Romanick Do you have a tree somewhere that I could pull to make sure the others don't break my build? :) On 02/27/2015 04:47 PM, Brian Paul wrote: > --- > src/mesa/main/compiler.h | 4 > src/mesa/program/prog_stat

[Mesa-dev] [PATCH 3/6] i965/fs: Silence unused parameter warning

From: Ian Romanick I don't this opt_cmod_propagation_local ever used the fs_visitor. brw_fs_cmod_propagation.cpp:52:40: warning: unused parameter 'v' [-Wunused-parameter] opt_cmod_propagation_local(fs_visitor *v, bblock_t *block) ^ Signed-off-by: Ian Ro

[Mesa-dev] [PATCH 1/6] i965/fs: Silence unused parameter warning

From: Ian Romanick brw_fs_visitor.cpp:2162:56: warning: unused parameter 'offset_components' [-Wunused-parameter] fs_reg offset_value, unsigned offset_components, ^ Signed-off-by: Ian Romanick Cc: Jordan Justen

[Mesa-dev] [PATCH 6/6] i965: Don't write past the end of the application supplied buffer

From: Ian Romanick Both the AMD and Intel APIs provide a dataSize parameter, and this function would merrily ignore it. Neither API specifies what to do when the buffer isn't big enough. I take the easy route of writing all the complete bits of data that will fit. With more complete specs, we

[Mesa-dev] [PATCH 2/6] i965/fs: Silence unused parameter warning

From: Ian Romanick Unused since b18fd23. brw_fs.cpp:2878:44: warning: unused parameter 'dispatch_width' [-Wunused-parameter] clear_deps_for_inst_src(fs_inst *inst, int dispatch_width, bool *deps, ^ Signed-off-by: Ian Romanick Cc: Jason Ekstrand --

[Mesa-dev] [PATCH 5/6] i965: Silence unused parameter warning

From: Ian Romanick All dd functions take a gl_context as the first parameter. Instead of removing it, just silence the warning. brw_performance_monitor.c: In function 'brw_new_perf_monitor': brw_performance_monitor.c:1354:41: warning: unused parameter 'ctx' [-Wunused-parameter] brw_new_perf_m

[Mesa-dev] [PATCH 4/6] i965: Silence many 'static' is not at beginning of declaration warnings

From: Ian Romanick What a useful warning. #ThanksGCC brw_performance_monitor.c:153:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] const static struct gl_perf_monitor_counter gen5_raw_chaps_counters[] = { ^ brw_performance_monitor.c:185:1: warning: 'static' i

[Mesa-dev] [Bug 89364] c99_alloca.h:40:22: fatal error: alloca.h: No such file or directory

https://bugs.freedesktop.org/show_bug.cgi?id=89364 Vinson Lee changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

[Mesa-dev] [RFC] nir: Use an instruction for the condition on if statements

Previously, the nir_if control-flow node had a source built straight into it that was the if condition. This has been the source of a lot of edge-case headaches due to, in particular, the two different use sets that we were carrying around. This patch changes it to have a special jump instruction

[Mesa-dev] merging compiler.h, util/macros.h and p_compiler.h

These three files all define macros in the same vein and are useful everywhere. I'd like to replace them with a common util/compiler.h file. There's already some overlap in these files. Take a look at them and let me know if there's any concerns. I think a few things could be factored out

Re: [Mesa-dev] [PATCH 1/5] meta: silence uninitialized variable warnings for MinGW

On 02/27/2015 06:00 PM, Matt Turner wrote: On Fri, Feb 27, 2015 at 12:07 PM, Brian Paul wrote: --- src/mesa/drivers/common/meta_blit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/common/meta_blit.c b/src/mesa/drivers/common/meta_blit.c index 971a2ff..bb21642 10064

Re: [Mesa-dev] [PATCH 1/5] meta: silence uninitialized variable warnings for MinGW

On Fri, Feb 27, 2015 at 12:07 PM, Brian Paul wrote: > --- > src/mesa/drivers/common/meta_blit.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/mesa/drivers/common/meta_blit.c > b/src/mesa/drivers/common/meta_blit.c > index 971a2ff..bb21642 100644 > --- a/src/mesa/drivers/common/m

Re: [Mesa-dev] [PATCH V2 1/3] glsl: move array validation into its own function

On Fri, 2015-02-27 at 11:59 -0800, Matt Turner wrote: > On Wed, Feb 25, 2015 at 11:45 PM, Timothy Arceri > wrote: > > V2: return true when var->type is unsized by max access is within valid > > range > > > > --- > > src/glsl/linker.cpp | 89 > > ++---

[Mesa-dev] [PATCH 7/7] mesa: trim down #includes in api_loopback.h

--- src/mesa/main/api_loopback.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/mesa/main/api_loopback.h b/src/mesa/main/api_loopback.h index eb3d54b..4451440 100644 --- a/src/mesa/main/api_loopback.h +++ b/src/mesa/main/api_loopback.h @@ -27,12 +27,7 @@ #ifndef API

[Mesa-dev] [PATCH 2/7] mesa: move FLT_MAX_EXP to c99_math.h

--- include/c99_math.h | 4 src/mesa/main/compiler.h | 4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/c99_math.h b/include/c99_math.h index 35173c6..0a49950 100644 --- a/include/c99_math.h +++ b/include/c99_math.h @@ -156,5 +156,9 @@ llrintf(float f) #de

[Mesa-dev] [PATCH 6/7] mesa: trim down includes of compiler.h

In some cases, glheader.h is the right #include. Also remove some instances of struct _glapi_table declarations. --- src/mesa/main/api_loopback.h | 1 - src/mesa/main/atifragshader.h| 3 +-- src/mesa/main/attrib.h | 1 - src/mesa/main/blit.h | 1 - src/mesa/main/color

[Mesa-dev] [PATCH 4/7] mesa: move finite macro to imports.h

Move it to the only place it's used. --- src/mesa/main/compiler.h | 8 src/mesa/main/imports.h | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h index 9d7df05..796870d 100644 --- a/src/mesa/main/compiler.h +++

[Mesa-dev] [PATCH 3/7] mesa: remove _NORMAPI, _NORMAPIP macros

Was only used in one place. Use equivalent _XFORMAPIP there instead. --- src/mesa/main/compiler.h | 7 --- src/mesa/math/m_xform.h | 2 +- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h index cb1ea46..9d7df05 100644 --- a/src

[Mesa-dev] [PATCH 5/7] mesa: include macros.h in stencil.h

Since it uses the CLAMP macro. --- src/mesa/main/stencil.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/stencil.h b/src/mesa/main/stencil.h index 6480b2a..3302cb9 100644 --- a/src/mesa/main/stencil.h +++ b/src/mesa/main/stencil.h @@ -33,6 +33,7 @@ #include "glheader.h" +#

[Mesa-dev] [PATCH 1/7] mesa: move ONE_DIV_SQRT_LN2 to prog_statevars.c

--- src/mesa/main/compiler.h | 4 src/mesa/program/prog_statevars.c | 3 +++ 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h index dd65d07..231dee7 100644 --- a/src/mesa/main/compiler.h +++ b/src/mesa/main/compiler.h

[Mesa-dev] Mesa 10.5.0 release candidate 3

Mesa 10.5.0 release candidate 3 is now available for testing. The current plan is to have an additional release candidate every Friday until the eventual 10.5.0 release on Mar 6th. The tag in the git repository for Mesa 10.5.0-rc3 is 'mesa-10.5.0-rc3'. Mesa 10.5.0 release candidate 3 is available

Re: [Mesa-dev] [PATCH 2/2] configure: Leverage gcc warn options to enable safe use of C99 features where possible.

On Friday, February 27, 2015 09:58:51 PM Jose Fonseca wrote: > Sorry, this didn't pop up when I built it here. And I'm afraid I won't have > time to look into this today, and possibly the weekend. > > If there's not an obvious fix feel free to push a commit commiting out the > .MSVC2013_COMPAT

Re: [Mesa-dev] RFC: Prune stale components

On Fri, Feb 27, 2015 at 5:05 PM, Emil Velikov wrote: >> - src/gallium/drivers/rbug: -- do people use it? does it work? it >> predates apitrace GL + GUI, which sort of enables a lot of the same >> things, but without the issue of having to hit moving target, which is >> what gallium interfaces are

[Mesa-dev] [PATCH 2/6] main: Add TEXTURE_CUBE_MAP support for glCompressedTextureSubImage3D.

--- src/mesa/main/teximage.c | 204 --- src/mesa/main/teximage.h | 3 +- 2 files changed, 179 insertions(+), 28 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index dfad9ed..d454dd9 100644 --- a/src/mesa/main/teximage.c

[Mesa-dev] [PATCH 6/6] main: Add entry point for TextureBufferRange.

v2: Review by Martin Peres - Get rid of difficult-to-follow code copied and pasted from the original TexBufferRange --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 8 + src/mesa/main/tests/dispatch_sanity.cpp| 1 + src/mesa/main/teximage.c | 46

[Mesa-dev] [PATCH 5/6] main: Refactor Tex[ture]Buffer[Range].

Uses _mesa_lookup_bufferobj_err to clean up buffer object retrieval. Moves error checking statements into separate functions to allow code sharing between traditional and ARB_direct_state_access entry points. --- src/mesa/main/teximage.c | 201 ++- src/

[Mesa-dev] [PATCH 3/6] main: Checking for cube completeness in GetCompressedTextureImage.

--- src/mesa/main/texgetimage.c | 51 - 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index 24df5b6..327a397 100644 --- a/src/mesa/main/texgetimage.c +++ b/src/mesa/main/texgetimag

[Mesa-dev] [PATCH 1/6] main: Check for NULL in texturesubimage.

--- src/mesa/main/teximage.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 6e45cc9..dfad9ed 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -3688,6 +3688,8 @@ texturesubimage(struct gl_context *ctx, GLuint di

[Mesa-dev] [PATCH 4/6] main: Add utility function _mesa_lookup_bufferobj_err.

--- src/mesa/main/bufferobj.c | 19 +++ src/mesa/main/bufferobj.h | 4 2 files changed, 23 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index f026fc3..617242b 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -1006,

[Mesa-dev] [PATCH] main/base_tex_format: Properly handle STENCIL_INDEX1/4/16

From: Jason Ekstrand This takes "fbo-stencil blit GL_STENCIL_INDEX1/4/16" from crash to pass on BDW. --- src/mesa/main/teximage.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 6e45cc9..a68574d 100644 --- a/src/mesa/main/teximage.

Re: [Mesa-dev] [PATCH] i965/skl: Fix the maximum thread count format for the PS

On Fri, Feb 27, 2015 at 11:20 AM, Neil Roberts wrote: > According to the bspec for some reason the format of the maximum > number of threads field has changed from U8-2 to U8-1 for the PS. > > I've run this through Piglit and it doesn't cause any regressions. > --- > src/mesa/drivers/dri/i965/gen

Re: [Mesa-dev] [PATCH 1/2] nir: Use alloca instead of variable length arrays.

On Fri, Feb 27, 2015 at 6:04 AM, Jose Fonseca wrote: > On 26/02/15 18:07, Brian Paul wrote: > >> On 02/26/2015 09:51 AM, Jose Fonseca wrote: >> >>> This is to enable the code to build with -Werror=vla in the short term, >>> and enable the code to build with MSVC2013 soon after. >>> --- >>> incl

Re: [Mesa-dev] [PATCH] i965/skl: Ignore the vertical alignment for the qpitch of 1D textures

On Fri, Feb 27, 2015 at 11:24 AM, Neil Roberts wrote: > The vertical alignment is ignored in the surface state for 1D array > textures so we can tightly pack them. > > I've run this through Piglit and it doesn't cause any regressions. > > (This should probably be squashed into the patch entitled “

Re: [Mesa-dev] [PATCH] i965/fs/nir: Use emit_math for nir_op_fpow

Reviewed-by: Jason Ekstrand On Fri, Feb 27, 2015 at 2:19 PM, Ian Romanick wrote: > From: Ian Romanick > > It appears that all the other instructions that need it already use it. > This one just got missed. > > Signed-off-by: Ian Romanick > Cc: "10.5" > Cc: Jason Ekstrand > --- > src/mesa/d

[Mesa-dev] [Bug 89364] c99_alloca.h:40:22: fatal error: alloca.h: No such file or directory

https://bugs.freedesktop.org/show_bug.cgi?id=89364 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 2/2] configure: Leverage gcc warn options to enable safe use of C99 features where possible.

On 27/02/15 15:59, Ian Romanick wrote: > I like the idea as it should prevent future thrash. There are a couple > comments below. > True. Not to mention that having -Werror=pointer-arith and -Werror=declaration-after-statement does not sounds too bad either. Although I would suspect that either

[Mesa-dev] [PATCH] i965/fs/nir: Use emit_math for nir_op_fpow

From: Ian Romanick It appears that all the other instructions that need it already use it. This one just got missed. Signed-off-by: Ian Romanick Cc: "10.5" Cc: Jason Ekstrand --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/

Re: [Mesa-dev] [PATCH 1/5] meta: silence uninitialized variable warnings for MinGW

On Fri, Feb 27, 2015 at 12:07 PM, Brian Paul wrote: > --- > src/mesa/drivers/common/meta_blit.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/mesa/drivers/common/meta_blit.c > b/src/mesa/drivers/common/meta_blit.c > index 971a2ff..bb21642 100644 > --- a/src/mesa/drivers/common/m

Re: [Mesa-dev] RFC: Prune stale components

On 27/02/15 15:16, Jose Fonseca wrote: > As we're gaining momentum cleanup Mesa code, I think it would help if we > also removed some stale components. > > What do people feel about removing: > > - src/mesa/drivers/windows/gdi -- the old SW rasterizer for Windows -- I > haven't used in a very lon

Re: [Mesa-dev] [PATCH] mapi: Don't rely on GNU void pointer arithmetic.

Thanks! From: mesa-dev on behalf of Matt Turner Sent: 27 February 2015 19:48 To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH] mapi: Don't rely on GNU void pointer arithmetic. Commit 79daa510c added -Werror=pointer-arith to CFLAGS, which mak

Re: [Mesa-dev] [PATCH 3/5] mesa: move declaration before code

I think this is fine now. We need to update SCons to be less pedantic about the -Wdeclaration-after-statement / -Wpointer-arith this on a per-directory-basis, like my recent configure.ac change. Jose From: mesa-dev on behalf of Brian Paul Sent: 27 F

Re: [Mesa-dev] [PATCH 4/4] i965/fs: Don't issue FB writes for bound but unwritten color targets.

Thanks for figuring out how to do this properly. Reviewed-by: Jason Ekstrand On Fri, Feb 27, 2015 at 12:06 AM, Kenneth Graunke wrote: > We used to loop over all color attachments, and emit FB writes for each > one, even if the shader didn't write to a corresponding output variable. > Those col

Re: [Mesa-dev] [PATCH 2/2] configure: Leverage gcc warn options to enable safe use of C99 features where possible.

Sorry, this didn't pop up when I built it here. And I'm afraid I won't have time to look into this today, and possibly the weekend. If there's not an obvious fix feel free to push a commit commiting out the .MSVC2013_COMPAT_*FLAGS= in configure.ac I'll act on other reviews too as soon as I ca

Re: [Mesa-dev] [PATCH v2 2/4] i965/fs: Make get_timestamp() return an fs_inst * rather than emitting.

On Fri, Feb 27, 2015 at 11:15:35AM -0800, Kenneth Graunke wrote: > This makes another part of the INTEL_DEBUG=shader_time code emittable > at arbitrary locations, rather than just at the end of the instruction > stream. > > v2: Don't lose smear! Caught by Topi Pohjolainen. > > Signed-off-by: Ken

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/3] i965/fs: Consider cmod when propagating to inst with different type.

On 02/27/2015 11:34 AM, Matt Turner wrote: > We can safely propagate the conditional mod to an instruction with a > different type if the conditional mod does not involve comparing for > equality with zero (or probably NaN, but ignore that for now). > > This is because -0.0 and +0.0 are both test

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/3] i965: Avoid applying negate to wrong MAD source.

With the tiny nit below fixed, this patch is Reviewed-by: Ian Romanick On 02/27/2015 11:34 AM, Matt Turner wrote: > For some given GLSL IR like (+ (neg x) (* 1.2 x)), the try_emit_mad > function would see that one of the +'s sources was a negate expression > and set mul_negate = true without con

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] i965/vec4: Fix implementation of i2b.

This patch is Reviewed-by: Ian Romanick On 02/27/2015 11:34 AM, Matt Turner wrote: > I broke this in commit 2881b123d. I must have misread i2b as b2i. > > Cc: 10.5 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88246 > --- > src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 2 +- > 1

[Mesa-dev] [Bug 89363] build error - error: pointer of type 'void *' used in arithmetic [-Werror=pointer-arith]

https://bugs.freedesktop.org/show_bug.cgi?id=89363 Frederik vom Hofe changed: What|Removed |Added CC||frederik.h...@gmail.com -- You are

Re: [Mesa-dev] [PATCH] meta/TexSubImage: Stash everything other than PIXEL_TRANSFER/store in meta_begin

Alternatively, it's probably safe (and faster) to just save/restore the scissor in meta_begin/end. The _mesa_meta_BlitFramebuffer implementation stashes everything else anyway. --Jason On Fri, Feb 27, 2015 at 12:29 PM, Jason Ekstrand wrote: > Cc: 10.5 > Bugzilla: https://bugs.freedesktop.org/s

Re: [Mesa-dev] [PATCH] nir: Zero undefined variables when zero_undefiend_variables is set

NEVER MIND THIS PATCH. I had a git-send-email fail On Fri, Feb 27, 2015 at 12:26 PM, Jason Ekstrand wrote: > Cc: 10.5 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89292 > --- > src/glsl/nir/nir_lower_vars_to_ssa.c| 34 > + > src/mesa/drivers/co

[Mesa-dev] [PATCH] meta/TexSubImage: Stash everything other than PIXEL_TRANSFER/store in meta_begin

Cc: 10.5 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89292 --- src/mesa/drivers/common/meta_tex_subimage.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/common/meta_tex_subimage.c b/src/mesa/drivers/common/meta_tex_subimage.c index 5ae12c

[Mesa-dev] [PATCH] nir: Zero undefined variables when zero_undefiend_variables is set

Cc: 10.5 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89292 --- src/glsl/nir/nir_lower_vars_to_ssa.c| 34 + src/mesa/drivers/common/meta_tex_subimage.c | 2 +- 2 files changed, 26 insertions(+), 10 deletions(-) diff --git a/src/glsl/nir/nir_lower_va

Re: [Mesa-dev] [PATCH] mapi: Don't rely on GNU void pointer arithmetic.

Reviewed-by: Brian Paul On 02/27/2015 12:48 PM, Matt Turner wrote: Commit 79daa510c added -Werror=pointer-arith to CFLAGS, which makes arithmetic on void pointers an error. See https://urldefense.proofpoint.com/v2/url?u=https-3A__gcc.gnu.org_onlinedocs_gcc_Pointer-2DArith.html&d=AwIGaQ&c=Sqc

[Mesa-dev] [PATCH 3/5] mesa: move declaration before code

To fix MinGW warning. --- src/mesa/main/queryobj.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c index e02969d2..0842b54 100644 --- a/src/mesa/main/queryobj.c +++ b/src/mesa/main/queryobj.c @@ -146,12 +146,13 @@ static

[Mesa-dev] [PATCH 2/5] meta: silence declaration after code warning on MinGW

--- src/mesa/drivers/common/meta_tex_subimage.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/common/meta_tex_subimage.c b/src/mesa/drivers/common/meta_tex_subimage.c index 5ae12c8..bba2b4f 100644 --- a/src/mesa/drivers/common/meta_tex_subimage.c +++ b/src

[Mesa-dev] [PATCH 1/5] meta: silence uninitialized variable warnings for MinGW

--- src/mesa/drivers/common/meta_blit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/common/meta_blit.c b/src/mesa/drivers/common/meta_blit.c index 971a2ff..bb21642 100644 --- a/src/mesa/drivers/common/meta_blit.c +++ b/src/mesa/drivers/common/meta_blit.c @@ -133,6 +133,

[Mesa-dev] [PATCH 5/5] glsl: silence uninitialized var warning on MinGW

--- src/glsl/opt_algebraic.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index c3f3842..c6040bf 100644 --- a/src/glsl/opt_algebraic.cpp +++ b/src/glsl/opt_algebraic.cpp @@ -866,6 +866,7 @@ ir_algebraic_visitor::handle_expression(ir_

[Mesa-dev] [PATCH] gallium/util: add debug_print_usage_enum() debug helper

--- src/gallium/auxiliary/util/u_debug.c | 19 +++ src/gallium/auxiliary/util/u_debug.h | 3 +++ 2 files changed, 22 insertions(+) diff --git a/src/gallium/auxiliary/util/u_debug.c b/src/gallium/auxiliary/util/u_debug.c index f54fc3a..2d2d049 100644 --- a/src/gallium/auxiliary/u

[Mesa-dev] [PATCH] c99_alloca.h: fix #include for MinGW

As with MSVC, include malloc.h but don't redefine alloca. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89364 --- include/c99_alloca.h | 4 1 file changed, 4 insertions(+) diff --git a/include/c99_alloca.h b/include/c99_alloca.h index 6d96d06..7a81c50 100644 --- a/include/c99_alloc

[Mesa-dev] [PATCH 4/5] mesa: silence unused var warning in get_tex_rgba_uncompressed()

--- src/mesa/main/texgetimage.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index 24df5b6..f975c16 100644 --- a/src/mesa/main/texgetimage.c +++ b/src/mesa/main/texgetimage.c @@ -375,7 +375,7 @@ get_tex_rgba_uncompr

Re: [Mesa-dev] [PATCH V2 1/3] glsl: move array validation into its own function

On Wed, Feb 25, 2015 at 11:45 PM, Timothy Arceri wrote: > V2: return true when var->type is unsized by max access is within valid range > > --- > src/glsl/linker.cpp | 89 > ++--- > src/glsl/linker.h | 5 +++ > 2 files changed, 55 insertions(+),

[Mesa-dev] [PATCH] gallium/util: fix 'statement with no effect' warning

--- src/gallium/auxiliary/util/u_math.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_math.h b/src/gallium/auxiliary/util/u_math.h index 959f76e..5400fce 100644 --- a/src/gallium/auxiliary/util/u_math.h +++ b/src/gallium/auxiliary/util/u_math

Re: [Mesa-dev] [PATCH 1/2] nir: Use alloca instead of variable length arrays.

On Friday, February 27, 2015 02:04:47 PM Jose Fonseca wrote: > On 26/02/15 18:07, Brian Paul wrote: [snip] > > AFAIK, there's no zeroing version of alloca(). > > Yes, I also searched. And unfortunately inline functions can't be used > due to alloca semantics. I'm not sure if there's any C-prepr

[Mesa-dev] [PATCH] mapi: Don't rely on GNU void pointer arithmetic.

Commit 79daa510c added -Werror=pointer-arith to CFLAGS, which makes arithmetic on void pointers an error. See https://gcc.gnu.org/onlinedocs/gcc/Pointer-Arith.html --- src/mapi/entry_x86-64_tls.h | 2 +- src/mapi/entry_x86_tls.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --

[Mesa-dev] [Bug 89364] c99_alloca.h:40:22: fatal error: alloca.h: No such file or directory

https://bugs.freedesktop.org/show_bug.cgi?id=89364 --- Comment #1 from Brian Paul --- The _MSC_VER check fails on MinGW. I'll post a patch... -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. __

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Consider cmod when propagating to inst with different type.

On Fri, Feb 27, 2015 at 11:34 AM, Matt Turner wrote: > We can safely propagate the conditional mod to an instruction with a > different type if the conditional mod does not involve comparing for > equality with zero (or probably NaN, but ignore that for now). > > This is because -0.0 and +0.0 are

[Mesa-dev] [PATCH 1/3] i965/vec4: Fix implementation of i2b.

I broke this in commit 2881b123d. I must have misread i2b as b2i. Cc: 10.5 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88246 --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visito

[Mesa-dev] [PATCH 3/3] i965: Avoid applying negate to wrong MAD source.

For some given GLSL IR like (+ (neg x) (* 1.2 x)), the try_emit_mad function would see that one of the +'s sources was a negate expression and set mul_negate = true without confirming that it was actually a multiply. Cc: 10.5 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89315 Bugzilla:

[Mesa-dev] [PATCH 2/3] i965/fs: Consider cmod when propagating to inst with different type.

We can safely propagate the conditional mod to an instruction with a different type if the conditional mod does not involve comparing for equality with zero (or probably NaN, but ignore that for now). This is because -0.0 and +0.0 are both test equal to zero, but their integer representations do n

[Mesa-dev] [PATCH] i965/skl: Ignore the vertical alignment for the qpitch of 1D textures

The vertical alignment is ignored in the surface state for 1D array textures so we can tightly pack them. I've run this through Piglit and it doesn't cause any regressions. (This should probably be squashed into the patch entitled “i965/skl: Fix the qpitch value”) --- src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH] i965/skl: Fix the maximum thread count format for the PS

According to the bspec for some reason the format of the maximum number of threads field has changed from U8-2 to U8-1 for the PS. I've run this through Piglit and it doesn't cause any regressions. --- src/mesa/drivers/dri/i965/gen8_ps_state.c | 7 ++- 1 file changed, 6 insertions(+), 1 delet

[Mesa-dev] [PATCH v2 2/4] i965/fs: Make get_timestamp() return an fs_inst * rather than emitting.

This makes another part of the INTEL_DEBUG=shader_time code emittable at arbitrary locations, rather than just at the end of the instruction stream. v2: Don't lose smear! Caught by Topi Pohjolainen. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs.cpp | 24 +-

Re: [Mesa-dev] [PATCH 3/4] i965: Prevent infinite finish_batch recursion

On Fri, Feb 27, 2015 at 10:22:10AM -0800, Ben Widawsky wrote: > From the comments in the code: > >Called from intel_batchbuffer_flush before emitting MI_BATCHBUFFER_END and >sending it off. > > This fixes a possible, unlikely infinite recursion in our batch flush path. > More > important

[Mesa-dev] [Bug 89364] c99_alloca.h:40:22: fatal error: alloca.h: No such file or directory

https://bugs.freedesktop.org/show_bug.cgi?id=89364 Bug ID: 89364 Summary: c99_alloca.h:40:22: fatal error: alloca.h: No such file or directory Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (A

[Mesa-dev] [Bug 89363] build error - error: pointer of type 'void *' used in arithmetic [-Werror=pointer-arith]

https://bugs.freedesktop.org/show_bug.cgi?id=89363 Bug ID: 89363 Summary: build error - error: pointer of type 'void *' used in arithmetic [-Werror=pointer-arith] Product: Mesa Version: git Hardware: All OS:

[Mesa-dev] [PATCH] gallium/auxiliary/indices: fix start param

Since commit 28f3f8d, indices generator take a start parameter. However, some index values have been left to start at 0. This fixes the glean/fbo test with the virgl driver. --- src/gallium/auxiliary/indices/u_indices_gen.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --gi

[Mesa-dev] [PATCH 4/4] [v2] i965/hsw: Implement end of batch workaround

v2: Sent out the wrong patch original. This patches switches the order of flushes, doing the generic flush before the CC_STATE, and the required workaround flush afterwards Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 17 + 1 file changed, 17 in

Re: [Mesa-dev] [PATCH 1/4] i965: Rename some PIPE_CONTROL flags

On Fri, Feb 27, 2015 at 10:22 AM, Ben Widawsky wrote: > I'm not really sure of the origins of the existing flag names. Modern docs > have > some slightly different names. Having the correct names makes it easier to > determine if existing PIPE_CONTROL flag settings are correct, as well as > maki

Re: [Mesa-dev] [PATCH 3/4] i965: Prevent infinite finish_batch recursion

On Fri, Feb 27, 2015 at 10:22:10AM -0800, Ben Widawsky wrote: > From the comments in the code: > >Called from intel_batchbuffer_flush before emitting MI_BATCHBUFFER_END and >sending it off. > > This fixes a possible, unlikely infinite recursion in our batch flush path. > More > important

[Mesa-dev] [PATCH 4/4] i965/hsw: Implement end of batch workaround

Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 16 1 file changed, 16 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c b/src/mesa/drivers/dri/i965/intel_batchbuffer.c index b0ebec7..e405918 100644 --- a/src/mesa/drivers/d

[Mesa-dev] [PATCH 2/4] i965/hsw: Properly handle RO state invalidation

Before invalidating the "RO state" caches, we have to emit a PIPE_CONTROL... The following is the best I can explain things as I understand them without getting too far into the low-level details. I believe the "read only" aspect of this is misleading. It just so happens that the state caches are

[Mesa-dev] [PATCH 1/4] i965: Rename some PIPE_CONTROL flags

I'm not really sure of the origins of the existing flag names. Modern docs have some slightly different names. Having the correct names makes it easier to determine if existing PIPE_CONTROL flag settings are correct, as well as making adding new PIPE_CONTROLs easier. This originally came up while

[Mesa-dev] [PATCH 3/4] i965: Prevent infinite finish_batch recursion

From the comments in the code: Called from intel_batchbuffer_flush before emitting MI_BATCHBUFFER_END and sending it off. This fixes a possible, unlikely infinite recursion in our batch flush path. More importantly it allows me to add some code here. The relevant part of the call chain for

Re: [Mesa-dev] [RFC] configure.ac: Don't check for python mako module if python is not installed

On Fri, Feb 27, 2015 at 7:27 AM, Samuel Iglesias Gonsalvez wrote: > This could be the case of trying to compile a Mesa tarball (from 'make dist' > command) in a machine without Python interpreter installed. The autogenerated > files from mako templates were already created during tarball > generat

Re: [Mesa-dev] RFC: Prune stale components

On 02/27/2015 10:05 AM, Matt Turner wrote: On Fri, Feb 27, 2015 at 7:16 AM, Jose Fonseca wrote: Anything else? Are the classic xlib and osmesa drivers useful given that they both have Gallium alternatives these days? Yeah, I'd like to keep those. -Brian ___

Re: [Mesa-dev] RFC: Prune stale components

On Fri, Feb 27, 2015 at 7:16 AM, Jose Fonseca wrote: > Anything else? Are the classic xlib and osmesa drivers useful given that they both have Gallium alternatives these days? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedes

Re: [Mesa-dev] [PATCH 2/7] i965: Remove the create_raw_surface vtbl hook.

On Sat, Jan 17, 2015 at 3:04 PM, Francisco Jerez wrote: > It's a wrapper around emit_buffer_surface_state with format=RAW, pitch=1, > rw=true and the remaining arguments ordered differently. There's no point in > having a separate vtbl pointer for that. Yeah, I agree, that can go. Reviewed-by:

Re: [Mesa-dev] RFC: Prune stale components

On Fri, Feb 27, 2015 at 10:16 AM, Jose Fonseca wrote: > - src/gallium/drivers/rbug: -- do people use it? does it work? it predates > apitrace GL + GUI, which sort of enables a lot of the same things, but > without the issue of having to hit moving target, which is what gallium > interfaces are A

Re: [Mesa-dev] [PATCH 2/2] configure: Leverage gcc warn options to enable safe use of C99 features where possible.

Hi, This patch breaks the build for me: CFLAGS="-g" CXXFLAGS="$CFLAGS" CC="ccache gcc" CXX="ccache g++" ./autogen.sh \ --prefix=/usr/local \ --with-dri-drivers="no" \ --with-gallium-drivers="r600,radeonsi" \ --enable-glx-tls \ --enable-debug \ --enable-shared-glapi \ --with-egl-platforms=x11,drm

Re: [Mesa-dev] RFC: Prune stale components

On 02/27/2015 08:16 AM, Jose Fonseca wrote: As we're gaining momentum cleanup Mesa code, I think it would help if we also removed some stale components. What do people feel about removing: - src/mesa/drivers/windows/gdi -- the old SW rasterizer for Windows -- I haven't used in a very long time,

Re: [Mesa-dev] [PATCH 1/2] nir: Use alloca instead of variable length arrays.

On 02/26/2015 10:07 AM, Brian Paul wrote: > On 02/26/2015 09:51 AM, Jose Fonseca wrote: >> This is to enable the code to build with -Werror=vla in the short term, >> and enable the code to build with MSVC2013 soon after. >> --- >> include/c99_alloca.h | 45 >> +

Re: [Mesa-dev] [PATCH 2/2] configure: Leverage gcc warn options to enable safe use of C99 features where possible.

I like the idea as it should prevent future thrash. There are a couple comments below. On 02/26/2015 08:51 AM, Jose Fonseca wrote: > The main objective of this change is to enable Linux developers to use > more of C99 throughout Mesa, with confidence that the portions that need > to be built with

  1   2   >